Re: [Mesa-dev] [PATCH] r600g/sb: Don't fold integer value into float CND

2015-02-12 Thread Connor Abbott
What does the source look like? Both the TGSI and GLSL looks fine to me. This is essentially doing: vec3 vec_value_tmp = ...; bvec3 dereference_condition = equals(row.xxx, vec3(0, 1, 2)); //per-component equals float tmp; //called vec_index_tmp_v in the GLSL IR // this is where the use-before-def

[Mesa-dev] [PATCH] i965: Fix a crash in the texture gradient lowering pass with cube samplers

2015-02-12 Thread Iago Toral Quiroga
We need to swizzle the rhs to match the number of components in the writemask, otherwise we'll hit an assertion in ir_assignment. --- src/mesa/drivers/dri/i965/brw_lower_texture_gradients.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_lower

[Mesa-dev] Nomination Period for the X.Org Foundation BoD Election ENDS

2015-02-12 Thread Egbert Eich
Just as a reminder, the nomination period for the X.Org Foundation Board of Directors election ends on Monday, Feb 16 2015, 23:59 UTC (12:59 PM UTC). If you would like to nominate yourself, please send email to electi...@x.org. Please note that to be a candidate in this election your have to b

Re: [Mesa-dev] Incorrect assertion in ir_assignment?

2015-02-12 Thread Iago Toral
On Thu, 2015-02-12 at 08:05 -0800, Ian Romanick wrote: > On 02/12/2015 06:19 AM, Iago Toral wrote: > > Hi, > > > > is this assertion in ir_assignment::ir_assignment() src/glsl/ir.cpp > > correct? > > > > assert(lhs_components == this->rhs->type->vector_elements); > > > > We will hit this any tim

[Mesa-dev] [Bug 89112] u_atomic_test: u_atomic_test.c:124: test_atomic_8bits_bool: Assertion `r == 65 && "p_atomic_add"' failed.

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89112 José Fonseca changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |jfons...@vmware.com |or

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89068 --- Comment #9 from Iago Toral --- (In reply to Jason Ekstrand from comment #8) > (In reply to Iago Toral from comment #7) > > After testing with a binary provided by the reporter and comparing with the > > old code it looks like the problem come

[Mesa-dev] [Bug 89131] [Bisected] Graphical corruption in Weston, shows old framebuffer pieces

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89131 --- Comment #1 from James Harvey --- Created attachment 113451 --> https://bugs.freedesktop.org/attachment.cgi?id=113451&action=edit dmesg and weston output -- You are receiving this mail because: You are the QA Contact for the bug. _

[Mesa-dev] [Bug 89131] [Bisected] Graphical corruption in Weston, shows old framebuffer pieces

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89131 James Harvey changed: What|Removed |Added Attachment #113450|text/plain |image/png mime type|

[Mesa-dev] [Bug 89131] [Bisected] Graphical corruption in Weston, shows old framebuffer pieces

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89131 Bug ID: 89131 Summary: [Bisected] Graphical corruption in Weston, shows old framebuffer pieces Product: Mesa Version: git Hardware: x86-64 (AMD64) OS: Linu

Re: [Mesa-dev] [PATCH] r600g/sb: Don't fold integer value into float CND

2015-02-12 Thread Dave Airlie
On 12 February 2015 at 23:49, Maarten Lankhorst wrote: > Op 12-02-15 om 14:23 schreef Glenn Kennard: >> Don't try to do float comparisons on signed integer values, >> some of them look like NaNs. >> >> Fixes fs-temp-array-mat3-index-col-row-rd.shader_test regression >> caused by 0d4272cd8e7c451571

[Mesa-dev] [Bug 88907] [PNV Bisected]Ogles2conform ES2-CTS.gtf.GL2ExtensionTests.texture_float.texture_float segfault

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88907 --- Comment #5 from Tapani Pälli --- (In reply to Ian Romanick from comment #3) > Comment on attachment 113390 [details] [review] > patch to fix the issue > > Review of attachment 113390 [details] [review]: >

[Mesa-dev] [Bug 89107] [Radeonsi/Hawaii] Rendering errors when running basic opengl 3 demo

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89107 Michel Dänzer changed: What|Removed |Added Component|Drivers/Gallium/radeonsi|Mesa core Assignee|dri-devel@l

Re: [Mesa-dev] [PATCH 3/4] radeonsi: small fix in SPI state

2015-02-12 Thread Michel Dänzer
On 12.02.2015 19:50, Marek Olšák wrote: > On Thu, Feb 12, 2015 at 8:15 AM, Michel Dänzer wrote: >> On 11.02.2015 23:23, Marek Olšák wrote: >>> From: Marek Olšák >>> >>> Cc: 10.4 >>> --- >>> src/gallium/drivers/radeonsi/si_state_shaders.c | 6 -- >>> 1 file changed, 4 insertions(+), 2 deleti

Re: [Mesa-dev] [PATCH 2/2] i965: Optimize multiplication by -1 into a negated MOV.

2015-02-12 Thread Matt Turner
On Thu, Feb 12, 2015 at 5:45 PM, Tom Stellard wrote: > On Thu, Feb 12, 2015 at 03:36:37PM -0800, Matt Turner wrote: >> instructions in affected programs: 968 -> 942 (-2.69%) >> helped:4 >> --- >> src/mesa/drivers/dri/i965/brw_fs.cpp | 9 + >> src/mesa

Re: [Mesa-dev] [PATCH 2/2] i965: Optimize multiplication by -1 into a negated MOV.

2015-02-12 Thread Tom Stellard
On Thu, Feb 12, 2015 at 03:36:37PM -0800, Matt Turner wrote: > instructions in affected programs: 968 -> 942 (-2.69%) > helped:4 > --- > src/mesa/drivers/dri/i965/brw_fs.cpp | 9 + > src/mesa/drivers/dri/i965/brw_vec4.cpp | 5 + > 2 files changed,

[Mesa-dev] [PATCH v2] i965: Perform program state upload outside of atom handling

2015-02-12 Thread Carl Worth
Across the board of the various generations, the intial few atoms in all of the atom lists are basically the same, (performing uploads for the various programs). The only difference is that prior to gen6 there's an ff_gs upload in place of the later gs upload. In this commit, instead of using the

Re: [Mesa-dev] [PATCH 1/2] i965: Add an is_negative_one() method.

2015-02-12 Thread Kenneth Graunke
On Thursday, February 12, 2015 03:36:36 PM Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_shader.cpp | 16 > src/mesa/drivers/dri/i965/brw_shader.h | 1 + > 2 files changed, 17 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp > b/src/mesa/driv

Re: [Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

2015-02-12 Thread Eric Anholt
Jose Fonseca writes: > Thanks for doing this. I appreciate it. > > I have no objection with the series. I'm happy to see more reuse. We > can always move things around later, and it will be much easier when > then are less entangled/duplicated. > > We'll need to update SCons include paths too

[Mesa-dev] [Bug 89112] u_atomic_test: u_atomic_test.c:124: test_atomic_8bits_bool: Assertion `r == 65 && "p_atomic_add"' failed.

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89112 Bug ID: 89112 Summary: u_atomic_test: u_atomic_test.c:124: test_atomic_8bits_bool: Assertion `r == 65 && "p_atomic_add"' failed. Product: Mesa Version: git

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Vinson Lee changed: What|Removed |Added Depends on||89112 -- You are receiving this mail becau

[Mesa-dev] [PATCH] i965/fs/nir: Emit CMPs instead of MOV.NZ.

2015-02-12 Thread Matt Turner
--- I guess this is kind of a companion to the patch I sent recently that converts MOV -> CMP in opt_algebraic. src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 2/2] i965: Optimize multiplication by -1 into a negated MOV.

2015-02-12 Thread Matt Turner
instructions in affected programs: 968 -> 942 (-2.69%) helped:4 --- src/mesa/drivers/dri/i965/brw_fs.cpp | 9 + src/mesa/drivers/dri/i965/brw_vec4.cpp | 5 + 2 files changed, 14 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/sr

[Mesa-dev] [PATCH 1/2] i965: Add an is_negative_one() method.

2015-02-12 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_shader.cpp | 16 src/mesa/drivers/dri/i965/brw_shader.h | 1 + 2 files changed, 17 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index 8b87d0d..d7b9c44 100644 --- a/src/mesa/dri

Re: [Mesa-dev] [PATCH] mesa: fix OES_texture_float texture render target behavior

2015-02-12 Thread Matt Turner
On Thu, Feb 12, 2015 at 4:33 AM, Tapani Pälli wrote: > Current implementation allowed usage of unsized type texture GL_FLOAT > and GL_HALF_FLOAT as a render target as this was 'expected behavior' by > WEBGL_oes_texture_float and is also allowed by the oes-texture-float > WebGL test. However this b

Re: [Mesa-dev] [PATCH 1/2] gallium: include util/macros.h

2015-02-12 Thread Jose Fonseca
LGTM. On 12/02/15 17:31, Tobias Klausmann wrote: The most common macros are defined there, no use to duplicate these Clean up the already redefinded macros Signed-off-by: Tobias Klausmann --- src/gallium/include/pipe/p_compiler.h | 57 ++- 1 file changed, 2 i

Re: [Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

2015-02-12 Thread Jose Fonseca
Thanks for doing this. I appreciate it. I have no objection with the series. I'm happy to see more reuse. We can always move things around later, and it will be much easier when then are less entangled/duplicated. We'll need to update SCons include paths too. If you have a git repos with

Re: [Mesa-dev] [PATCH] mesa: fix OES_texture_float texture render target behavior

2015-02-12 Thread Ian Romanick
On 02/12/2015 01:47 PM, Ian Romanick wrote: > On 02/12/2015 04:33 AM, Tapani Pälli wrote: >> Current implementation allowed usage of unsized type texture GL_FLOAT >> and GL_HALF_FLOAT as a render target as this was 'expected behavior' by >> WEBGL_oes_texture_float and is also allowed by the oes-tex

Re: [Mesa-dev] [PATCH] meta: Fix saving the results of the current occlusion query

2015-02-12 Thread Ian Romanick
On 02/12/2015 01:39 PM, Carl Worth wrote: > On Tue, Nov 25 2014, Neil Roberts wrote: >> This patch fixes it by making it actually wait for the query object to be >> ready before grabbing the previous result. The downside of doing this is that >> it could introduce a stall but I think this situation

Re: [Mesa-dev] [PATCH] mesa: fix OES_texture_float texture render target behavior

2015-02-12 Thread Ian Romanick
On 02/12/2015 04:33 AM, Tapani Pälli wrote: > Current implementation allowed usage of unsized type texture GL_FLOAT > and GL_HALF_FLOAT as a render target as this was 'expected behavior' by > WEBGL_oes_texture_float and is also allowed by the oes-texture-float > WebGL test. However this broke some

Re: [Mesa-dev] [PATCH] meta: Fix saving the results of the current occlusion query

2015-02-12 Thread Carl Worth
On Tue, Nov 25 2014, Neil Roberts wrote: > This patch fixes it by making it actually wait for the query object to be > ready before grabbing the previous result. The downside of doing this is that > it could introduce a stall but I think this situation is unlikely so it might > not matter too much.

[Mesa-dev] [Bug 82477] [softpipe] piglit fp-long-alu regression

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82477 Carl Worth changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 82477, which changed state. Bug 82477 Summary: [softpipe] piglit fp-long-alu regression https://bugs.freedesktop.org/show_bug.cgi?id=82477 What|Removed |Added ---

Re: [Mesa-dev] [PATCH] Revert use of Mesa IR optimizer for ARB_fragment_programs

2015-02-12 Thread Ian Romanick
On 02/12/2015 12:13 PM, Ian Romanick wrote: > Reviewed-by: Ian Romanick And please add Cc: "10.4 10.5" > On 02/12/2015 11:46 AM, Carl Worth wrote: >> Commit f82f2fb3dc770902f1657ab1c22e6004faa3afab added use of the Mesa >> IR optimizer for both ARB_fragment_program and ARB_vertex_program, but

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 86837, which changed state. Bug 86837 Summary: kodi segfault since auxiliary/vl: rework the build of the VL code https://bugs.freedesktop.org/show_bug.cgi?id=86837 What|Removed |Added -

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 00/23] ARB_direct_state_access buffer objects (v2)

2015-02-12 Thread Laura Ekstrand
Yes, Ilia's right. The _mesa_buffer_data backend is exposed to the rest of the driver (for use in the near future in Meta), so it has "_meta". In this v2, I discovered that some of the software fallbacks in bufferobj.c were static and named "_mesa" (not my doing). I changed them in the v2 to rem

Re: [Mesa-dev] [PATCH v3] Fixing an x86 FPU bug.

2015-02-12 Thread Brian Paul
I have a few concerns about this patch. Firstly, including prog_parameter.h from macros.h feels wrong. Macros are a lower-level concept than program parameters so the "lower" thing shouldn't be including the "higher" thing. Instead of using gl_constant_value everywhere, why not use the fi_ty

Re: [Mesa-dev] [PATCH] Revert use of Mesa IR optimizer for ARB_fragment_programs

2015-02-12 Thread Ian Romanick
Reviewed-by: Ian Romanick On 02/12/2015 11:46 AM, Carl Worth wrote: > Commit f82f2fb3dc770902f1657ab1c22e6004faa3afab added use of the Mesa > IR optimizer for both ARB_fragment_program and ARB_vertex_program, but > only justified the vertex-program portions with measured performance > improvement

Re: [Mesa-dev] [PATCH 00/23] ARB_direct_state_access buffer objects (v2)

2015-02-12 Thread Ilia Mirkin
On Thu, Feb 12, 2015 at 3:09 PM, Martin Peres wrote: > On 12/02/15 04:05, Laura Ekstrand wrote: >> >> This includes a v2 of all of the buffer object code plus a v2 of the >> related >> TextureBufferRange entry point. >> >> Note that some implementations have been merged together (MapBuffer and >>

Re: [Mesa-dev] [PATCH 00/23] ARB_direct_state_access buffer objects (v2)

2015-02-12 Thread Martin Peres
On 12/02/15 04:05, Laura Ekstrand wrote: This includes a v2 of all of the buffer object code plus a v2 of the related TextureBufferRange entry point. Note that some implementations have been merged together (MapBuffer and MapBufferRange, for instance) because it didn't seem to make sense to keep

Re: [Mesa-dev] [PATCH 14/16] i965/fs: Allow flipping cond mod for negated arguments.

2015-02-12 Thread Matt Turner
On Thu, Feb 5, 2015 at 4:14 AM, Ian Romanick wrote: > On 01/20/2015 01:31 AM, Matt Turner wrote: >> @@ -73,10 +72,14 @@ opt_cmod_propagation_local(fs_visitor *v, bblock_t >> *block) >> scan_inst->dst.reg == inst->src[0].reg && >> scan_inst->dst.reg_offset == inst->src[

[Mesa-dev] [Bug 88907] [PNV Bisected]Ogles2conform ES2-CTS.gtf.GL2ExtensionTests.texture_float.texture_float segfault

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88907 --- Comment #4 from Ian Romanick --- (In reply to Ian Romanick from comment #3) > Comment on attachment 113390 [details] [review] > patch to fix the issue > > Review of attachment 113390 [details] [review]: >

[Mesa-dev] [Bug 88907] [PNV Bisected]Ogles2conform ES2-CTS.gtf.GL2ExtensionTests.texture_float.texture_float segfault

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88907 --- Comment #3 from Ian Romanick --- Comment on attachment 113390 --> https://bugs.freedesktop.org/attachment.cgi?id=113390 patch to fix the issue Review of attachment 113390: -

[Mesa-dev] [PATCH] Revert use of Mesa IR optimizer for ARB_fragment_programs

2015-02-12 Thread Carl Worth
Commit f82f2fb3dc770902f1657ab1c22e6004faa3afab added use of the Mesa IR optimizer for both ARB_fragment_program and ARB_vertex_program, but only justified the vertex-program portions with measured performance improvements. Meanwhile, the optimizer was seen to generate hundreds of unused immediate

[Mesa-dev] [Bug 88907] [PNV Bisected]Ogles2conform ES2-CTS.gtf.GL2ExtensionTests.texture_float.texture_float segfault

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88907 Matt Turner changed: What|Removed |Added QA Contact||mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 0/7] i965 L3 caching and pull constant improvements.

2015-02-12 Thread Kenneth Graunke
On Thursday, February 12, 2015 04:13:06 PM Francisco Jerez wrote: > Francisco Jerez writes: > > Kenneth Graunke writes: > >> On Sunday, January 18, 2015 01:04:02 AM Francisco Jerez wrote: > >>> This is the first part of a series meant to improve our usage of the L3 > >>> cache. > >>> Currently i

Re: [Mesa-dev] [PATCH 2/2] util/u_atomic: Add _InterlockedExchangeAdd8/16 for older MSVC.

2015-02-12 Thread Jose Fonseca
On 12/02/15 17:03, Brian Paul wrote: On 02/12/2015 09:27 AM, Jose Fonseca wrote: We need to build certain parts of Mesa (namely gallium, llvmpipe, and therefore util) with Windows SDK 7.0.7600, which includes MSVC 2008. --- src/util/u_atomic.h | 32 ++-- 1 file cha

Re: [Mesa-dev] [PATCH 01/32] i965: Factor out virtual GRF allocation to a separate object.

2015-02-12 Thread Matt Turner
On Mon, Feb 9, 2015 at 11:25 AM, Matt Turner wrote: > On Fri, Feb 6, 2015 at 2:40 PM, Matt Turner wrote: >> 8 - Sent a question >> 9 - Like mine better? >> 10 - Looks wrong to me >> 11-13 - Asked Jason to review >> 14 - Asked for an example showing the problem >> 15-16 - R-b >> 17-18 - R-b - but

Re: [Mesa-dev] [PATCH 30/32] i965: Handle F16TO32/F32TO16 with dword src/dst consistently on both back-ends.

2015-02-12 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 29/32] i965/gen8: Fix F32TO16 in vec4 mode if the source and destination registers alias.

2015-02-12 Thread Matt Turner
Heh, that's a nice bug. Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 28/32] i965/fs: Replace ud_reg_to_w() with a more general helper function.

2015-02-12 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 21/32] i965/vec4: Fix the scheduler to take into account reads and writes of multiple registers.

2015-02-12 Thread Matt Turner
On Fri, Feb 6, 2015 at 6:43 AM, Francisco Jerez wrote: > --- We don't have any operations today that return more than a single register in the vec4 backend, do we? Presumably this is partly preparation for image_load_store? Reviewed-by: Matt Turner __

[Mesa-dev] [PATCH] i965: Perform program state upload outside of atom handling

2015-02-12 Thread Carl Worth
Across the board of the various generations, the intial few atoms in all of the atom lists are basically the same, (performing uploads for the various programs). The only difference is that prior to gen6 there's an ff_gs upload in place of the later gs upload. In this commit, instead of using the

[Mesa-dev] [PATCH v3] Fixing an x86 FPU bug.

2015-02-12 Thread marius . predut
From: Marius Predut On 32-bit, for floating point operations is used x86 FPU registers instead SSE, reason for when reinterprets an integer as a float result is unexpected (modify floats when they are written to memory). The defect was checked with and without -O3 compiler flag This patch is ba

[Mesa-dev] [PATCH 1/2] gallium: include util/macros.h

2015-02-12 Thread Tobias Klausmann
The most common macros are defined there, no use to duplicate these Clean up the already redefinded macros Signed-off-by: Tobias Klausmann --- src/gallium/include/pipe/p_compiler.h | 57 ++- 1 file changed, 2 insertions(+), 55 deletions(-) diff --git a/src/galliu

[Mesa-dev] [PATCH 2/2] st/nine: Mark end of non-void function unreachable

2015-02-12 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/state_trackers/nine/nine_pipe.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/nine/nine_pipe.h b/src/gallium/state_trackers/nine/nine_pipe.h index 17844d5..b8e728e 100644 --- a/src/gallium/state_trac

Re: [Mesa-dev] [PATCH] automake: Use AM_DISTCHECK_CONFIGURE_FLAGS

2015-02-12 Thread Matt Turner
On Thu, Feb 12, 2015 at 7:27 AM, Emil Velikov wrote: > Currently we use DISTCHECK_CONFIGURE_FLAGS, which is reserved for > the user. As with other variables, one should use the AM_ variable > within the makefile. I remember not being sure about which to use, but this makes more sense. Reviewed-b

Re: [Mesa-dev] [PATCH 2/2] util/u_atomic: Add _InterlockedExchangeAdd8/16 for older MSVC.

2015-02-12 Thread Brian Paul
On 02/12/2015 09:27 AM, Jose Fonseca wrote: We need to build certain parts of Mesa (namely gallium, llvmpipe, and therefore util) with Windows SDK 7.0.7600, which includes MSVC 2008. --- src/util/u_atomic.h | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-)

Re: [Mesa-dev] [PATCH 2/2] util/u_atomic: Add _InterlockedExchangeAdd8/16 for older MSVC.

2015-02-12 Thread Roland Scheidegger
Series looks good to me. Roland Am 12.02.2015 um 17:27 schrieb Jose Fonseca: > We need to build certain parts of Mesa (namely gallium, llvmpipe, and > therefore util) with Windows SDK 7.0.7600, which includes MSVC 2008. > --- > src/util/u_atomic.h | 32 ++-- > 1 file

Re: [Mesa-dev] [PATCH 1/2] util/u_atomic: Test p_atomic_add() for 8bit integers.

2015-02-12 Thread Brian Paul
Reviewed-by: Brian Paul On 02/12/2015 09:27 AM, Jose Fonseca wrote: --- src/util/u_atomic_test.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/src/util/u_atomic_test.c b/src/util/u_atomic_test.c index c506275..8bddf8d 100644 --- a/src/

[Mesa-dev] [PATCH 2/2] util/u_atomic: Add _InterlockedExchangeAdd8/16 for older MSVC.

2015-02-12 Thread Jose Fonseca
We need to build certain parts of Mesa (namely gallium, llvmpipe, and therefore util) with Windows SDK 7.0.7600, which includes MSVC 2008. --- src/util/u_atomic.h | 32 ++-- 1 file changed, 30 insertions(+), 2 deletions(-) diff --git a/src/util/u_atomic.h b/src/util/u_

[Mesa-dev] [PATCH 1/2] util/u_atomic: Test p_atomic_add() for 8bit integers.

2015-02-12 Thread Jose Fonseca
--- src/util/u_atomic_test.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/src/util/u_atomic_test.c b/src/util/u_atomic_test.c index c506275..8bddf8d 100644 --- a/src/util/u_atomic_test.c +++ b/src/util/u_atomic_test.c @@ -37,8 +37,9 @@ #in

Re: [Mesa-dev] [PATCH] docs: add ARB_draw_indirect to ES 3.1 list

2015-02-12 Thread Ian Romanick
Reviewed-by: Ian Romanick On 02/12/2015 03:17 AM, Ilia Mirkin wrote: > Signed-off-by: Ilia Mirkin > --- > docs/GL3.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/docs/GL3.txt b/docs/GL3.txt > index 23f5561..e376f6b 100644 > --- a/docs/GL3.txt > +++ b/docs/GL3.txt > @@ -212,6 +212

Re: [Mesa-dev] Incorrect assertion in ir_assignment?

2015-02-12 Thread Ian Romanick
On 02/12/2015 06:19 AM, Iago Toral wrote: > Hi, > > is this assertion in ir_assignment::ir_assignment() src/glsl/ir.cpp > correct? > > assert(lhs_components == this->rhs->type->vector_elements); > > We will hit this any time we emit code such as this: > > assign(var1, expr, WRITEMASK_XY) In th

[Mesa-dev] [PATCH] automake: Use AM_DISTCHECK_CONFIGURE_FLAGS

2015-02-12 Thread Emil Velikov
Currently we use DISTCHECK_CONFIGURE_FLAGS, which is reserved for the user. As with other variables, one should use the AM_ variable within the makefile. Signed-off-by: Emil Velikov --- Makefile.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.am b/Makefile.am inde

Re: [Mesa-dev] [PATCH 7/7] mesa: Drop dependency on mtypes.h for core NIR.

2015-02-12 Thread Connor Abbott
Sorry, should've clarified to mean this patch gets my r-b. On Wed, Feb 11, 2015 at 9:20 PM, Connor Abbott wrote: > Given that this commit only changes NIR code, I think it should be > prefixed by "nir: ", e.g. "nir: Drop dependency on mtypes.h in nir.h." > Once that's done, this gets my r-b. > >

Re: [Mesa-dev] [PATCH] opengles2: fix building without X11

2015-02-12 Thread Alex Deucher
On Thu, Feb 12, 2015 at 8:23 AM, Emil Velikov wrote: > Humble ping. Reviewed-by: Alex Deucher > > On 22/01/15 18:28, Emil Velikov wrote: >> From: Michael Olbrich >> >> es2_info, es2gears_x11 and es2tri require X11, so don't build them if X11 >> is disabled. >> >> Bugzilla: https://bugs.freedes

[Mesa-dev] Mesa 10.5.0 release candidate 1

2015-02-12 Thread Emil Velikov
Mesa 10.5.0 release candidate 1 is now available for testing. The current plan is to have an additional release candidate every Friday until the eventual 10.5.0 release on Mar 6th. The tag in the git repository for Mesa 10.5.0-rc1 is 'mesa-10.5.0-rc1'. As a reminder, with the 10.5 branch now crea

[Mesa-dev] Incorrect assertion in ir_assignment?

2015-02-12 Thread Iago Toral
Hi, is this assertion in ir_assignment::ir_assignment() src/glsl/ir.cpp correct? assert(lhs_components == this->rhs->type->vector_elements); We will hit this any time we emit code such as this: assign(var1, expr, WRITEMASK_XY) where expr and var1 are vec3. At least if we emit that code from lo

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89068 --- Comment #8 from Jason Ekstrand --- (In reply to Iago Toral from comment #7) > After testing with a binary provided by the reporter and comparing with the > old code it looks like the problem comes from the fact that they are using > transferO

Re: [Mesa-dev] [PATCH 0/7] i965 L3 caching and pull constant improvements.

2015-02-12 Thread Francisco Jerez
Francisco Jerez writes: > Kenneth Graunke writes: > >> On Sunday, January 18, 2015 01:04:02 AM Francisco Jerez wrote: >>> This is the first part of a series meant to improve our usage of the L3 >>> cache. >>> Currently it's far from ideal since the following objects aren't taking any >>> advant

Re: [Mesa-dev] [PATCH 2/6] gallium: add interface and state tracker support for GL_AMD_pinned_memory

2015-02-12 Thread Roland Scheidegger
Am 11.02.2015 um 21:18 schrieb Marek Olšák: > From: Marek Olšák > > --- > src/gallium/docs/source/screen.rst | 5 + > src/gallium/drivers/i915/i915_screen.c | 1 + > src/gallium/drivers/ilo/ilo_screen.c | 1 + > src/gallium/drivers/llvmpipe/lp_screen.c

Re: [Mesa-dev] [PATCH] r600g/sb: Don't fold integer value into float CND

2015-02-12 Thread Maarten Lankhorst
Op 12-02-15 om 14:23 schreef Glenn Kennard: > Don't try to do float comparisons on signed integer values, > some of them look like NaNs. > > Fixes fs-temp-array-mat3-index-col-row-rd.shader_test regression > caused by 0d4272cd8e7c45157140dc8e283707714a8238d5. > > Signed-off-by: Glenn Kennard > Cc:

[Mesa-dev] [PATCH] r600g/sb: Don't fold integer value into float CND

2015-02-12 Thread Glenn Kennard
Don't try to do float comparisons on signed integer values, some of them look like NaNs. Fixes fs-temp-array-mat3-index-col-row-rd.shader_test regression caused by 0d4272cd8e7c45157140dc8e283707714a8238d5. Signed-off-by: Glenn Kennard --- src/gallium/drivers/r600/sb/sb_peephole.cpp | 2 +- 1 fi

Re: [Mesa-dev] [PATCH] opengles2: fix building without X11

2015-02-12 Thread Emil Velikov
Humble ping. On 22/01/15 18:28, Emil Velikov wrote: > From: Michael Olbrich > > es2_info, es2gears_x11 and es2tri require X11, so don't build them if X11 > is disabled. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88618 > Reviewed-by: Emil Velikov > --- > > Noticed this patch in

Re: [Mesa-dev] [PATCH] glx: do not leak the dri2 extension information

2015-02-12 Thread Emil Velikov
Humble ping. On 22/01/15 17:35, Emil Velikov wrote: > The XExtensionInfo is allocated dynamically (if the pointer is NULL) > in the XEXT_GENERATE_FIND_DISPLAY macro. On the other hand the > macro XEXT_GENERATE_CLOSE_DISPLAY does not check/free the memory. > > Follow the example set by dri1 and ap

[Mesa-dev] [PATCH] mesa: fix OES_texture_float texture render target behavior

2015-02-12 Thread Tapani Pälli
Current implementation allowed usage of unsized type texture GL_FLOAT and GL_HALF_FLOAT as a render target as this was 'expected behavior' by WEBGL_oes_texture_float and is also allowed by the oes-texture-float WebGL test. However this broke some ES3 conformance tests that do not accept such behavi

[Mesa-dev] [PATCH] docs: add ARB_draw_indirect to ES 3.1 list

2015-02-12 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- docs/GL3.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/GL3.txt b/docs/GL3.txt index 23f5561..e376f6b 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -212,6 +212,7 @@ These are the extensions cherry-picked to make GLES 3.1 GLES3.1, GLSL ES 3.1 GL_A

Re: [Mesa-dev] [PATCH 3/4] radeonsi: small fix in SPI state

2015-02-12 Thread Marek Olšák
On Thu, Feb 12, 2015 at 8:15 AM, Michel Dänzer wrote: > On 11.02.2015 23:23, Marek Olšák wrote: >> From: Marek Olšák >> >> Cc: 10.4 >> --- >> src/gallium/drivers/radeonsi/si_state_shaders.c | 6 -- >> 1 file changed, 4 insertions(+), 2 deletions(-) >> >> diff --git a/src/gallium/drivers/rad

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89068 Iago Toral changed: What|Removed |Added CC||ja...@jlekstrand.net --- Comment #7 from Ia

Re: [Mesa-dev] [PATCH 1/3] glsl: Propagate negates through multiplication chains.

2015-02-12 Thread Kenneth Graunke
On Wednesday, February 11, 2015 04:14:20 PM Ian Romanick wrote: > On 02/11/2015 04:05 PM, Matt Turner wrote: > > On Wed, Feb 11, 2015 at 3:51 PM, Ian Romanick wrote: > >> On 02/11/2015 02:54 PM, Matt Turner wrote: > >>> We propagate negations to the right-most leaves of the multiplication > >>> ex

[Mesa-dev] [Bug 88535] Mesa 10.3.0 implementation error: gen7_update_renderbuffer_surface: renderbuffer format MESA_FORMAT_RGBX_UNORM16 unsupported

2015-02-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88535 Kenneth Graunke changed: What|Removed |Added Component|Mesa core |Drivers/DRI/i965 Assignee|me

Re: [Mesa-dev] [PATCH 1/6] mesa: implement GL_AMD_pinned_memory

2015-02-12 Thread Christian König
Sorry for forgetting to bump the driver version, been to busy lately. Patches are Reviewed-by: Christian König Regards, Christian. Am 11.02.2015 um 21:18 schrieb Marek Olšák: From: Marek Olšák It's not possible to query the current buffer binding, because the extension doesn't define GL_...

Re: [Mesa-dev] [PATCH 2/2] i965/vec4/vp: Use vec4_visitor::CMP.

2015-02-12 Thread Kenneth Graunke
On Wednesday, February 11, 2015 06:17:23 PM Matt Turner wrote: > ... instead of emit(BRW_OPCODE_CMP, ...). In commit 6b3a301f I changed > vec4_visitor::CMP to set the destination's type to that of src0. In the > following commit (2335153f) I removed an apparently now unnecessary work > around for G