Re: [Mesa-dev] [PATCH 3/4] radeonsi: small fix in SPI state

On 11.02.2015 23:23, Marek Olšák wrote: > From: Marek Olšák > > Cc: 10.4 > --- > src/gallium/drivers/radeonsi/si_state_shaders.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_state_shaders.c > b/src/gallium/drivers/radeonsi/si_s

Re: [Mesa-dev] [PATCH 2/4] r600g, radeonsi: use fences to implement PIPE_QUERY_GPU_FINISHED

On 11.02.2015 23:23, Marek Olšák wrote: > From: Marek Olšák Please add Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89014 and resolve the bug report when pushing the commit. With that added, Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | htt

Re: [Mesa-dev] [PATCH 5/5] r200: Drop unused variable.

On Wed, Feb 11, 2015 at 7:42 PM, Eric Anholt wrote: > Quiets compiler warning since e7f2f2dea5acdbd1a12ed88914e64a38a97432f0. Reviewed-by: Alex Deucher > --- > src/mesa/drivers/dri/r200/r200_ioctl.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/r200/r200_ioctl.c

Re: [Mesa-dev] [PATCH 7/7] mesa: Drop dependency on mtypes.h for core NIR.

Given that this commit only changes NIR code, I think it should be prefixed by "nir: ", e.g. "nir: Drop dependency on mtypes.h in nir.h." Once that's done, this gets my r-b. On Wed, Feb 11, 2015 at 7:48 PM, Eric Anholt wrote: > One less new directory necessary for gallium code that wants to inter

[Mesa-dev] [PATCH 1/2] i965/vec4: Add and use byte-MOV instruction for unpack 4x8.

Previously we were using a B/UB source in an Align16 instruction, which is illegal. It for some reason works on all platforms, except Broadwell. Cc: "10.5" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=86811 --- I know! Another instruction for MOV! Sorry! src/mesa/drivers/dri/i965/brw_

[Mesa-dev] [PATCH 2/2] i965/vec4/vp: Use vec4_visitor::CMP.

... instead of emit(BRW_OPCODE_CMP, ...). In commit 6b3a301f I changed vec4_visitor::CMP to set the destination's type to that of src0. In the following commit (2335153f) I removed an apparently now unnecessary work around for Gen8 that did the same thing. But there was a single place that emitted

[Mesa-dev] [PATCH 22/23] main: Add entry point for glGetNamedBufferSubData.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +++ src/mesa/main/bufferobj.c | 22 ++ src/mesa/main/bufferobj.h | 4 src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 34 insertions(+) diff --gi

[Mesa-dev] [PATCH 06/23] main: Add entry point for NamedBufferStorage.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +++ src/mesa/main/bufferobj.c | 63 +++--- src/mesa/main/bufferobj.h | 9 src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 64 insertions(+), 16 deleti

[Mesa-dev] [PATCH 05/23] main: Add entry point for CreateBuffers.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +++ src/mesa/main/bufferobj.c | 65 -- src/mesa/main/bufferobj.h | 5 +- src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 64 insertions(+), 14 deletion

[Mesa-dev] [PATCH 17/23] main: Refactor FlushMappedBufferRange.

v2:-Remove "_mesa" from in front of static software fallback. -Split out the refactor from the addition of the DSA entry points. --- src/mesa/main/bufferobj.c | 60 +++ src/mesa/main/bufferobj.h | 6 + 2 files changed, 40 insertions(+), 26 deleti

[Mesa-dev] [PATCH 16/23] main: Add entry point for UnmapNamedBuffer.

v2: review from Ian Romanick - Restore VBO_DEBUG and BOUNDS_CHECK - Remove _mesa from static software fallback unmap_buffer. --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 5 +++ src/mesa/main/bufferobj.c | 47 +++--- src/mesa/main/bufferobj.h

[Mesa-dev] [PATCH 01/23] main: Fix whitespace in teximage.c.

--- src/mesa/main/teximage.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 29c325b..336feff 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -5031,7 +5031,7 @@ _mesa_validate_texbuffer_format(con

[Mesa-dev] [PATCH 00/23] ARB_direct_state_access buffer objects (v2)

This includes a v2 of all of the buffer object code plus a v2 of the related TextureBufferRange entry point. Note that some implementations have been merged together (MapBuffer and MapBufferRange, for instance) because it didn't seem to make sense to keep two separate and nearly identical versions

[Mesa-dev] [PATCH 20/23] main: Add entry points for GetBufferParameteri[64]v.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 12 src/mesa/main/bufferobj.c | 39 ++ src/mesa/main/bufferobj.h | 7 + src/mesa/main/tests/dispatch_sanity.cpp| 2 ++ 4 files changed, 60 insertions(+) di

[Mesa-dev] [PATCH 07/23] main: Add entry point for NamedBufferData.

v2: review from Ian Romanick - Fix space in ARB_direct_state_access.xml. - Remove "_mesa" from the name of buffer_data static fallback. - Restore VBO_DEBUG and BOUNDS_CHECK. - Fix beginning of comment to start on same line as /* --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 +

[Mesa-dev] [PATCH 21/23] main: Add entry point for GetNamedBufferPointerv.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++ src/mesa/main/bufferobj.c | 27 +++--- src/mesa/main/bufferobj.h | 4 src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 35 insertions(+), 3 dele

[Mesa-dev] [PATCH 10/23] main: Add entry point for CopyNamedBufferSubData.

v2: remove _mesa in front of static software fallback. --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 +++ src/mesa/main/bufferobj.c | 99 +- src/mesa/main/bufferobj.h | 12 src/mesa/main/tests/dispatch_sanity.cpp

[Mesa-dev] [PATCH 13/23] main: Minor whitespace fixes in ClearNamedBuffer[Sub]Data.

--- src/mesa/main/bufferobj.c | 4 ++-- src/mesa/main/bufferobj.h | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index bd21c8a..88230d6 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1765,10

[Mesa-dev] [PATCH 18/23] main: Add entry point for FlushMappedNamedBufferRange.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 ++ src/mesa/main/bufferobj.c | 16 src/mesa/main/bufferobj.h | 4 src/mesa/main/tests/dispatch_sanity.cpp| 1 + 4 files changed, 27 insertions(+) diff --git a/src

[Mesa-dev] [PATCH 19/23] main: Refactor GetBufferParameteri[64]v.

v2: Split into a refactor commit and an entry point commit. --- src/mesa/main/bufferobj.c | 119 ++ 1 file changed, 45 insertions(+), 74 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 9b3d2ea..dfeda21 100644 --- a/

[Mesa-dev] [PATCH 02/23] main: Add entry point for TextureBufferRange.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 +++ src/mesa/main/tests/dispatch_sanity.cpp| 1 + src/mesa/main/teximage.c | 90 ++ src/mesa/main/teximage.h | 4 ++ 4 files changed, 103 insertions(+) diff --git

[Mesa-dev] [PATCH 23/23] main: Cosmetic changes to GetBufferSubData.

--- src/mesa/main/bufferobj.c | 2 +- src/mesa/main/bufferobj.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 0272704..38d8b5a 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1668,7 +1

[Mesa-dev] [PATCH 14/23] main: Refactor MapBuffer[Range].

v2: review from Jason Ekstrand - Split refactor from addition of DSA entry points. review from Ian Romanick - Remove "_mesa" from static software fallback map_buffer_range - Restore VBO_DEBUG and BOUNDS_CHECK --- src/mesa/main/bufferobj.c | 286

[Mesa-dev] [PATCH 03/23] main: Add utility function _mesa_lookup_bufferobj_err.

--- src/mesa/main/bufferobj.c | 19 +++ src/mesa/main/bufferobj.h | 4 2 files changed, 23 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 0c1ce98..b7dce0e 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1001,

[Mesa-dev] [PATCH 11/23] main: Refactor ClearBuffer[Sub]Data.

v2: review by Jason Ekstrand - Split refactor of clear buffer sub data from addition of DSA entry points. --- src/mesa/main/bufferobj.c| 125 --- src/mesa/main/bufferobj.h| 19 ++-- src/mesa/state_tracker/st_cb_bufferobjects.

[Mesa-dev] [PATCH 04/23] main: Tex[ture]Buffer[Range] functions now use _mesa_lookup_bufferobj_err.

--- src/mesa/main/teximage.c | 46 +- 1 file changed, 25 insertions(+), 21 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index ce6f446..d17f15e 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/main/teximage.c @@ -5091

[Mesa-dev] [PATCH 08/23] main: Add entry point for NamedBufferSubData.

v2: review by Ian Romanick - Remove "_mesa" from name of static software fallback buffer_sub_data. - Remove mappedRange from _mesa_buffer_sub_data. - Removed some cosmetic changes to a separate commit. --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 7 ++ src/mesa/main/bufferobj.c

[Mesa-dev] [PATCH 09/23] main: Cosmetic changes to BufferSubData infrastructure.

--- src/mesa/main/bufferobj.c | 10 +++--- src/mesa/main/bufferobj.h | 4 ++-- 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 4f89748..fc01d02 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@

[Mesa-dev] [PATCH 15/23] main: Add entry points for MapNamedBuffer[Range].

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 14 + src/mesa/main/bufferobj.c | 42 ++ src/mesa/main/bufferobj.h | 14 +++-- src/mesa/main/tests/dispatch_sanity.cpp| 2 ++ 4 files changed, 69 insertions(+

[Mesa-dev] [PATCH 12/23] main: Add entry points for ClearNamedBuffer[Sub]Data.

--- src/mapi/glapi/gen/ARB_direct_state_access.xml | 18 + src/mesa/main/bufferobj.c | 35 ++ src/mesa/main/bufferobj.h | 11 src/mesa/main/tests/dispatch_sanity.cpp| 2 ++ 4 files changed, 66 insertion

Re: [Mesa-dev] [PATCH 2.1/3?] squash! nir_algebraic.py: don't store a dictionary of indexes

Kenneth Graunke writes: > Since condition_list is an ordered list, we can just use enumerate() > when walking through it to get (index, value) pairs, rather than storing > a second dictionary mapping items to their indices. When looking for an > existing entry, use list.index() to get the index

[Mesa-dev] [Bug 86944] glsl_parser_extras.cpp", line 1455: Error: Badly formed expression. (Oracle Studio)

https://bugs.freedesktop.org/show_bug.cgi?id=86944 Matt Turner changed: What|Removed |Added Summary|glsl_parser_extras.cpp",|glsl_parser_extras.cpp",

[Mesa-dev] [Bug 86944] glsl_parser_extras.cpp", line 1455: Error: Badly formed expression.

https://bugs.freedesktop.org/show_bug.cgi?id=86944 Vinson Lee changed: What|Removed |Added Status|NEEDINFO|NEW --- Comment #11 from Vinson Lee --- (I

Re: [Mesa-dev] [PATCH 3/5] i965: Move some asserts to unreachable.

Matt Turner writes: > On Wed, Feb 11, 2015 at 4:50 PM, Matt Turner wrote: >> I don't see any of these warnings, strangely enough. > > But on another system with the same distribution and same gcc, I do. I don't know if it's related, but I've been having weird behavior for about a year where som

Re: [Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

Matt Turner writes: > On Wed, Feb 11, 2015 at 4:48 PM, Eric Anholt wrote: >> --- > > Maybe I just read what I wanted to read in the cover letter, but I was > expecting you to move u_math.h to src/util instead of this patch. > > That doesn't work because of u_math's inclusion of pipe/p_compiler.h

Re: [Mesa-dev] [PATCH 4/7] mesa: Make bitset.h not rely on Mesa-specific types and functions.

On 02/11/2015 04:59 PM, Matt Turner wrote: > On Wed, Feb 11, 2015 at 4:48 PM, Eric Anholt wrote: >> Note that we can't use u_math.h's align() because it's a function instead >> of a macro, while BITSET_DECLARE needs a constant expression for nouveau's >> usage in global declarations. >> --- >> sr

Re: [Mesa-dev] [PATCH 3/3] dri/common: Fix returned value of __DRI2_RENDERER_PREFERRED_PROFILE

On 02/09/2015 04:19 AM, Andreas Boll wrote: > If the renderer supports the core profile the query returned incorrectly > 0x8 as value, because it was using (1U << __DRI_API_OPENGL_CORE) for the > returned value. > > The same happened with the compatibility profile. It returned 0x1 > (1U << __DRI_A

Re: [Mesa-dev] [PATCH 3/5] i965: Move some asserts to unreachable.

On Wed, Feb 11, 2015 at 4:50 PM, Matt Turner wrote: > I don't see any of these warnings, strangely enough. But on another system with the same distribution and same gcc, I do. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedes

Re: [Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

On Wed, Feb 11, 2015 at 5:02 PM, Matt Turner wrote: > On Wed, Feb 11, 2015 at 4:48 PM, Eric Anholt wrote: >> --- > > Maybe I just read what I wanted to read in the cover letter, but I was > expecting you to move u_math.h to src/util instead of this patch. > > That doesn't work because of u_math's

[Mesa-dev] GSoC Ideas!

Hi everyone! It's that time of year again. Time to start coming up with GSoC ideas. Martin and I are organizing this year's Xorg entry. We need to fill in our ideas page with some good possible projects for students. The project ideas should be something that a student could accomplish over th

Re: [Mesa-dev] [LLVMdev] mesa-10.4.4: BROKEN TLS support in GLX with llvm-toolchain v3.6.0rc2

On Wed, Feb 11, 2015 at 12:09 AM, Emil Velikov wrote: > On 10/02/15 13:17, Dimitry Andric wrote: >> On 09 Feb 2015, at 18:52, Sedat Dilek wrote: >>> >>> On Mon, Feb 9, 2015 at 6:44 PM, Emil Velikov >>> wrote: On 07/02/15 22:42, Sedat Dilek wrote: >> ... > In file included from ../../sr

Re: [Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

On Wed, Feb 11, 2015 at 4:48 PM, Eric Anholt wrote: > --- Maybe I just read what I wanted to read in the cover letter, but I was expecting you to move u_math.h to src/util instead of this patch. That doesn't work because of u_math's inclusion of pipe/p_compiler.h? ___

Re: [Mesa-dev] [PATCH 4/7] mesa: Make bitset.h not rely on Mesa-specific types and functions.

On Wed, Feb 11, 2015 at 4:48 PM, Eric Anholt wrote: > Note that we can't use u_math.h's align() because it's a function instead > of a macro, while BITSET_DECLARE needs a constant expression for nouveau's > usage in global declarations. > --- > src/mesa/main/bitset.h | 7 +++ > 1 file changed

Re: [Mesa-dev] [PATCH 3/5] i965: Move some asserts to unreachable.

I don't see any of these warnings, strangely enough. This is (removing the !, like idr pointed out) Reviewed-by: Matt Turner as I guess the rest are. I really don't like useless initializations but I can't offer anything better. ___ mesa-dev mailing l

Re: [Mesa-dev] [PATCH 2/5] i965: Shut up a compiler warning about uninitialized var.

Patches 2, 4, and 5 are Reviewed-by: Ian Romanick On 02/11/2015 04:42 PM, Eric Anholt wrote: > We always pass this argument, even if it won't be used by the particular > texture op. > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > dif

[Mesa-dev] [PATCH 7/7] mesa: Drop dependency on mtypes.h for core NIR.

One less new directory necessary for gallium code that wants to interact with NIR. --- src/glsl/nir/nir.h | 4 +++- src/glsl/nir/nir_lower_atomics.c | 1 + src/glsl/nir/nir_lower_system_values.c | 1 + 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/src/glsl

[Mesa-dev] [PATCH 3/7] mesa: Use u_math.h from macros.h

This avoids duplication of some macros and other definitions across the tree. Note that COPY_4FV switches from a memcpy-based implementation to an assignment of 4 floats. --- src/mesa/drivers/dri/i915/intel_tris.c | 6 -- src/mesa/drivers/dri/nouveau/nouveau_util.h | 6 -- src/mesa

Re: [Mesa-dev] [PATCH 3/5] i965: Move some asserts to unreachable.

On 02/11/2015 04:42 PM, Eric Anholt wrote: > If execution was supposed to be supported in this case, we'd run into > trouble from completely uninitialized sat_imm values. Shuts up compiler > warnings. > --- > src/mesa/drivers/dri/i965/brw_shader.cpp | 4 ++-- > 1 file changed, 2 insertions(+), 2

[Mesa-dev] gallium includes from Mesa, nir.h stops using Mesa main.

OK, I think this is kind of the next step from the gallium-versus-mesa includes discussion earlier: Accept that u_math.h is an OK name, and the parent directory is OK, too, and just start sharing code. Once that's in place, I can get bitset.h out of Mesa main and into util/, so that nir.h doesn't

[Mesa-dev] [PATCH 5/7] util: Move Mesa's bitset.h to util/.

--- src/glsl/nir/nir.h | 2 +- src/mesa/Makefile.sources | 1 - .../drivers/dri/i965/brw_fs_copy_propagation.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs_live_variables.h | 2 +- .../drivers/dri/i965/brw_performance_monitor.c | 2

[Mesa-dev] [PATCH 4/7] mesa: Make bitset.h not rely on Mesa-specific types and functions.

Note that we can't use u_math.h's align() because it's a function instead of a macro, while BITSET_DECLARE needs a constant expression for nouveau's usage in global declarations. --- src/mesa/main/bitset.h | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/bit

[Mesa-dev] [PATCH 2/7] gallium/util: Don't include unused debug functions from u_math.h

It introduces references to gallium util/ symbols which means we don't get to include it from outside-of-gallium code. --- src/gallium/auxiliary/util/u_math.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_math.h b/src/gallium/auxiliary/util/u_math.h index 5db5b66

[Mesa-dev] [PATCH 6/7] glsl: Only include mtypes from glsl_types.h for the C++ code that needs it.

It's used in one of the methods, not in the structure definitions. --- src/glsl/glsl_types.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/glsl_types.h b/src/glsl/glsl_types.h index 441015c..74a038a 100644 --- a/src/glsl/glsl_types.h +++ b/src/glsl/glsl_types.h @@ -2

[Mesa-dev] [PATCH 1/7] mesa: Add gallium include dirs to more parts of the tree.

--- src/glsl/Makefile.am | 2 ++ src/mesa/drivers/dri/common/Makefile.am | 2 ++ src/mesa/drivers/dri/i915/Makefile.am| 2 ++ src/mesa/drivers/dri/i965/Makefile.am| 2 ++ src/mesa/drivers/dri/nouveau/Makefile.am | 2 ++ src/mesa/drivers/dri/r200/Makefile.am| 2 ++

[Mesa-dev] [PATCH 4/5] i965: Quiet another compiler warning about uninitialized values.

The compiler can't tell that we're always going to hit the first if block on the first time through the loop. --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_v

[Mesa-dev] [PATCH 2/5] i965: Shut up a compiler warning about uninitialized var.

We always pass this argument, even if it won't be used by the particular texture op. --- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index da81b61..

[Mesa-dev] [PATCH 1/5] gallium/dri: Shut up a compiler warning.

The compiler doesn't see that buffers is set in the !image case and used in the !image case. --- src/gallium/state_trackers/dri/dri2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/dri2.c b/src/gallium/state_trackers/dri/dri2.c index aecc8eb..7

[Mesa-dev] [PATCH 5/5] r200: Drop unused variable.

Quiets compiler warning since e7f2f2dea5acdbd1a12ed88914e64a38a97432f0. --- src/mesa/drivers/dri/r200/r200_ioctl.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/mesa/drivers/dri/r200/r200_ioctl.c b/src/mesa/drivers/dri/r200/r200_ioctl.c index 515be92..d665c8b 100644 --- a/src/mesa/driver

[Mesa-dev] [PATCH 3/5] i965: Move some asserts to unreachable.

If execution was supposed to be supported in this case, we'd run into trouble from completely uninitialized sat_imm values. Shuts up compiler warnings. --- src/mesa/drivers/dri/i965/brw_shader.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/br

[Mesa-dev] [Bug 88885] Transform feedback uses incorrect interleaving if a previous draw did not write gl_Position

https://bugs.freedesktop.org/show_bug.cgi?id=5 Carl Worth changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |cwo...@cworth.org |org

Re: [Mesa-dev] [PATCH 1/3] glsl: Propagate negates through multiplication chains.

On 02/11/2015 04:05 PM, Matt Turner wrote: > On Wed, Feb 11, 2015 at 3:51 PM, Ian Romanick wrote: >> On 02/11/2015 02:54 PM, Matt Turner wrote: >>> We propagate negations to the right-most leaves of the multiplication >>> expression trees: >>> >>> - mul(neg(x), neg(y)) -> mul(x, y) >>> - mul(neg

Re: [Mesa-dev] [PATCH] i965: Use new/delete instead of realloc() in brw_ir_allocator.h

On 02/11/2015 12:15 PM, Francisco Jerez wrote: > Matt Turner writes: >> [...] >> Indeed. And another thing to consider is that we've discussed >> compiling with -fno-exceptions. >> > > Heh, the benefit you get from doing that is virtually zero. And in > cases like this where failure would have t

Re: [Mesa-dev] [PATCH 3/3] i965: Emit MUL with a negated src for neg(mul(...)).

On Wed, Feb 11, 2015 at 3:57 PM, Ian Romanick wrote: > On 02/11/2015 02:54 PM, Matt Turner wrote: >> total instructions in shared programs: 5932832 -> 5932736 (-0.00%) >> instructions in affected programs: 8184 -> 8088 (-1.17%) >> helped:52 >> HURT:

Re: [Mesa-dev] [PATCH 1/3] glsl: Propagate negates through multiplication chains.

On Wed, Feb 11, 2015 at 3:51 PM, Ian Romanick wrote: > On 02/11/2015 02:54 PM, Matt Turner wrote: >> We propagate negations to the right-most leaves of the multiplication >> expression trees: >> >> - mul(neg(x), neg(y)) -> mul(x, y) >> - mul(neg(x), y) -> neg(mul(x, y)) >> - mul(x, neg(y)) -> n

Re: [Mesa-dev] [PATCH 1/6] mesa: implement GL_AMD_pinned_memory

I was wondering when you'd get around to implementing this. :) This patch is Reviewed-by: Ian Romanick On 02/11/2015 12:18 PM, Marek Olšák wrote: > From: Marek Olšák > > It's not possible to query the current buffer binding, because the extension > doesn't define GL_..._BUFFER__BINDING_AMD. >

[Mesa-dev] [Bug 63717] Poor performance in games with Intel 965GM

https://bugs.freedesktop.org/show_bug.cgi?id=63717 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 3/3] i965: Emit MUL with a negated src for neg(mul(...)).

On 02/11/2015 02:54 PM, Matt Turner wrote: > total instructions in shared programs: 5932832 -> 5932736 (-0.00%) > instructions in affected programs: 8184 -> 8088 (-1.17%) > helped:52 > HURT: 14 > GAINED:

Re: [Mesa-dev] [PATCH 1/3] glsl: Propagate negates through multiplication chains.

On 02/11/2015 02:54 PM, Matt Turner wrote: > We propagate negations to the right-most leaves of the multiplication > expression trees: > > - mul(neg(x), neg(y)) -> mul(x, y) > - mul(neg(x), y) -> neg(mul(x, y)) > - mul(x, neg(y)) -> neg(mul(x, y)) > > total instructions in shared programs: 594

Re: [Mesa-dev] [PATCH 10/10] i965/fs: Add algebraic optimizations for MAD.

On Mon, Feb 9, 2015 at 6:00 PM, Kenneth Graunke wrote: > With that fixed, and the shader-db numbers confirmed, patches 9-10 are: > Reviewed-by: Kenneth Graunke To close the loop, the shader-db results are unchanged after the fix. ___ mesa-dev mailing l

Re: [Mesa-dev] [PATCH v3 01/12] nir/dominance: Expose the dominance intersection function

Reviewed-by: Connor Abbott On Mon, Feb 9, 2015 at 11:24 PM, Jason Ekstrand wrote: > Being able to find the least common anscestor in the dominance tree is a > useful thing that we may want to do in other passes. In particular, we > need it for GCM. > > v2: Handle NULL inputs by returning the ot

[Mesa-dev] [Bug 89088] Mesa fails to build if indent does not support requested arguments (eg: -nut)

https://bugs.freedesktop.org/show_bug.cgi?id=89088 Matt Turner changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|mesa-dev@lists

[Mesa-dev] [Bug 82477] [softpipe] piglit fp-long-alu regression

https://bugs.freedesktop.org/show_bug.cgi?id=82477 --- Comment #3 from Ian Romanick --- *** Bug 82471 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list m

[Mesa-dev] [Bug 82471] [swrast] piglit fp-condition_codes-01 regression

https://bugs.freedesktop.org/show_bug.cgi?id=82471 Ian Romanick changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 82471, which changed state. Bug 82471 Summary: [swrast] piglit fp-condition_codes-01 regression https://bugs.freedesktop.org/show_bug.cgi?id=82471 What|Removed |Added ---

[Mesa-dev] [Bug 86944] glsl_parser_extras.cpp", line 1455: Error: Badly formed expression.

https://bugs.freedesktop.org/show_bug.cgi?id=86944 Ian Romanick changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #10 from Ian Romanic

[Mesa-dev] [PATCH 1/3] i965/fs: Add unit tests for saturate propagation pass.

Cc: --- src/mesa/drivers/dri/i965/Makefile.am | 7 + .../dri/i965/test_fs_saturate_propagation.cpp | 355 + 2 files changed, 362 insertions(+) create mode 100644 src/mesa/drivers/dri/i965/test_fs_saturate_propagation.cpp diff --git a/src/mesa/drivers/dri/

[Mesa-dev] [PATCH 1/3] glsl: Propagate negates through multiplication chains.

We propagate negations to the right-most leaves of the multiplication expression trees: - mul(neg(x), neg(y)) -> mul(x, y) - mul(neg(x), y) -> neg(mul(x, y)) - mul(x, neg(y)) -> neg(mul(x, y)) total instructions in shared programs: 5943123 -> 5937229 (-0.10%) instructions in affected programs:

[Mesa-dev] [PATCH 3/3] i965/fs: Consider MOV.SAT to interfere if it has a source modifier.

The saturate propagation pass recognizes that the second instruction below does not interfere with an attempt to propagate the saturate modifier from instruction 3 to 1. 1: add(8) dst0 src0 src1 2: mov.sat(8) dst1 dst0 3: mov.sat(8) dst2 dst0 Unfortunately, we did not consider th

[Mesa-dev] [PATCH 2/3] i965/fs: Allow CSE to handle MULs with negated arguments.

mul x, -y is equivalent to mul -x, y; and mul x, y is the negation of mul x, -y. total instructions in shared programs: 5937689 -> 5929512 (-0.14%) instructions in affected programs: 871152 -> 862975 (-0.94%) helped:4228 HURT: 17

[Mesa-dev] [PATCH 2/3] i965/fs: Use fs_inst::overwrites_reg() in saturate propagation.

This is safer and matches the conditional_mod propagation pass. Cc: --- .../dri/i965/brw_fs_saturate_propagation.cpp | 8 ++--- .../dri/i965/test_fs_saturate_propagation.cpp | 40 ++ 2 files changed, 44 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/

[Mesa-dev] [PATCH 3/3] i965: Emit MUL with a negated src for neg(mul(...)).

total instructions in shared programs: 5932832 -> 5932736 (-0.00%) instructions in affected programs: 8184 -> 8088 (-1.17%) helped:52 HURT: 14 GAINED:1 --- src/mesa/drivers/dri/i965/brw_fs_visitor.

[Mesa-dev] [Bug 88535] Mesa 10.3.0 implementation error: gen7_update_renderbuffer_surface: renderbuffer format MESA_FORMAT_RGBX_UNORM16 unsupported

https://bugs.freedesktop.org/show_bug.cgi?id=88535 Ian Romanick changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #3 from Ian Romanick

Re: [Mesa-dev] [PATCH] nir: Zero-init our structures.

I didn't look through it close enough to call it a review, but I like it. Especially getting rid of src/def_init. Acked-by: Jason Ekstrand On Wed, Feb 11, 2015 at 4:32 PM, Eric Anholt wrote: > We were filling out almost all fields of almost all instructions, but > leaving out a couple of them.

[Mesa-dev] [Bug 88852] macros.h(181) : error C2143: syntax error : missing '{' before 'enum [tag]'

https://bugs.freedesktop.org/show_bug.cgi?id=88852 Jason Ekstrand changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Mesa-dev] [Bug 88852] macros.h(181) : error C2143: syntax error : missing '{' before 'enum [tag]'

https://bugs.freedesktop.org/show_bug.cgi?id=88852 Ian Romanick changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #2 from Ian Romanick

[Mesa-dev] [Bug 89088] Mesa fails to build if indent does not support requested arguments (eg: -nut)

https://bugs.freedesktop.org/show_bug.cgi?id=89088 --- Comment #2 from Jeremy Huddleston --- No, I was encountering this on the MacPorts Snow Leopard buildbot after updating mesa from 8.0.5 to 10.4.4. We should probably cherry-pick that into 10.5 and 10.4. -- You are receiving this mail becaus

[Mesa-dev] [Bug 89050] [HSW DRI3] Piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fails

https://bugs.freedesktop.org/show_bug.cgi?id=89050 Chris Wilson changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Mesa-dev] [Bug 79629] [Dri3 bisected] piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fail

https://bugs.freedesktop.org/show_bug.cgi?id=79629 --- Comment #18 from Chris Wilson --- *** Bug 89050 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list

[Mesa-dev] [Bug 89050] [HSW DRI3] Piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fails

https://bugs.freedesktop.org/show_bug.cgi?id=89050 Ian Romanick changed: What|Removed |Added Status|NEW |NEEDINFO Assignee|mesa-dev@list

Re: [Mesa-dev] [PATCH 1/2] gallium: define unreachable macro

On 11.02.2015 16:50, Ilia Mirkin wrote: It's already defined in src/util/macros.h which you can include via #include "util/macros.h" -- I suspect some key gallium file should include that... Mh, i was under the expression these should be duped, as we already have STATIC_ASSERT and likely/unlike

[Mesa-dev] [PATCH] nir: Zero-init our structures.

We were filling out almost all fields of almost all instructions, but leaving out a couple of them. This simplifies the source code, cuts 700 bytes from the compiled binary, and prevents developer surprise when one field of your otherwise-containing-defaults struct is actually uninitialized. ---

Re: [Mesa-dev] [PATCH] glext.h: Add missing include of stddef.h for ptrdiff_t

On Wed, Feb 11, 2015 at 12:36 PM, Jeremy Huddleston Sequoia wrote: > > Signed-off-by: Jeremy Huddleston Sequoia The file comes from Khronos. We can't update it. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailm

[Mesa-dev] [PATCH] glext.h: Add missing include of stddef.h for ptrdiff_t

Signed-off-by: Jeremy Huddleston Sequoia --- include/GL/glext.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/GL/glext.h b/include/GL/glext.h index 256ad35..0328cf6 100644 --- a/include/GL/glext.h +++ b/include/GL/glext.h @@ -4470,6 +4470,7 @@ GLAPI void APIENTRY glVertexBlendARB (

[Mesa-dev] [Bug 89088] Mesa fails to build if indent does not support requested arguments (eg: -nut)

https://bugs.freedesktop.org/show_bug.cgi?id=89088 --- Comment #1 from Matt Turner --- A commit was made recently to require GNU indent: commit efef6c828092702b1f928f98d15fb90b4544a85c Author: Samuel Iglesias Gonsalvez Date: Tue Jan 13 11:02:27 2015 +0100 configure: add check for GNU ind

Re: [Mesa-dev] [PATCH 1/3] nir: Add support for CSE on textures.

On Wed, Feb 11, 2015 at 3:17 PM, Eric Anholt wrote: > Connor Abbott writes: > >> On Wed, Feb 11, 2015 at 2:36 PM, Eric Anholt wrote: >>> Connor Abbott writes: >>> On Tue, Feb 10, 2015 at 1:32 PM, Eric Anholt wrote: > Connor Abbott writes: > >> On Sat, Feb 7, 2015 at 12:16 AM,

[Mesa-dev] [PATCH 6/6] r600g, radeonsi: implement GL_AMD_pinned_memory

From: Marek Olšák --- src/gallium/drivers/r600/r600_pipe.c| 3 ++ src/gallium/drivers/radeon/r600_buffer_common.c | 47 ++--- src/gallium/drivers/radeon/r600_pipe_common.c | 1 + src/gallium/drivers/radeon/r600_pipe_common.h | 4 +++ src/gallium/drivers/rad

[Mesa-dev] [PATCH 5/6] winsys/radeon: test the userptr ioctl to see if it's present

From: Marek Olšák There seems to be no other way to check for support. The DRM version wasn't bumped. --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 18 -- src/gallium/winsys/radeon/drm/radeon_drm_cs.h | 1 - src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 15 ++

[Mesa-dev] [PATCH 4/6] winsys/radeon: allow unaligned size for user-memory buffers

From: Marek Olšák This is not required, but being user-friendly doesn't hurt. --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c b/src/gallium/winsys/radeon/drm/radeon_drm_bo.c index

[Mesa-dev] [PATCH 2/6] gallium: add interface and state tracker support for GL_AMD_pinned_memory

From: Marek Olšák --- src/gallium/docs/source/screen.rst | 5 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_screen.c | 1 + src/gallium/drivers/nouveau/nv30/nv30_screen.c |

[Mesa-dev] [PATCH 1/6] mesa: implement GL_AMD_pinned_memory

From: Marek Olšák It's not possible to query the current buffer binding, because the extension doesn't define GL_..._BUFFER__BINDING_AMD. Drivers should check the target parameter of Drivers.BufferData. If it's equal to GL_EXTERNAL_VIRTUAL_MEMORY_BUFFER_AMD, the memory should be pinned. That's a

  1   2   >