[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89068 --- Comment #4 from Iago Toral --- (In reply to Brad King from comment #0) (...) > After the change, _mesa_format_convert is called but none of the coe paths > invoking _mesa_pack_ubyte_rgba_row is taken. Instead the path using > compute_src2dst

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89068 Iago Toral changed: What|Removed |Added CC||ito...@igalia.com -- You are receiving thi

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89068 --- Comment #3 from Iago Toral --- Thanks for reporting this, I'll have a look. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___ mesa-d

Re: [Mesa-dev] [PATCH 01/11] i965: Fix ctx->Texture.CubeMapSeamless

2015-02-10 Thread Iago Toral
On Tue, 2015-02-10 at 09:33 -0800, Ian Romanick wrote: > On 02/10/2015 07:40 AM, Eduardo Lima Mitev wrote: > > From: Iago Toral Quiroga > > > > The intel driver code, and apparently all other Mesa drivers, call > > _mesa_initialize_context early in the CreateContext hook. That > > function will e

Re: [Mesa-dev] [PATCH 06/11] mesa: Add _mesa_is_array_texture helper

2015-02-10 Thread Iago Toral
On Tue, 2015-02-10 at 09:24 -0800, Ian Romanick wrote: > On 02/10/2015 08:10 AM, Brian Paul wrote: > > On 02/10/2015 08:40 AM, Eduardo Lima Mitev wrote: > >> From: Iago Toral Quiroga > >> > >> --- > >> src/mesa/main/teximage.c | 22 ++ > >> src/mesa/main/teximage.h | 3 +++

Re: [Mesa-dev] [PATCH v5 00/29] add fp64 support to mesa and glsl compiler

2015-02-10 Thread Tapani Pälli
On 02/10/2015 01:58 PM, Ilia Mirkin wrote: I spent a lot of quality time with Ian's random_ubo.py script, and I'm happy to report that with the current iteration, it doesn't spot any problems (after ~1000 shaders). I only had to make the following change to it: diff --git a/generated_tests/ran

Re: [Mesa-dev] [PATCH 02/11] i965/blorp: round to nearest when converting float to integer

2015-02-10 Thread Samuel Iglesias Gonsálvez
On Tuesday 10 February 2015 11:32:32 Matt Turner wrote: > On Tue, Feb 10, 2015 at 10:52 AM, Matt Turner wrote: > >> + /* Round floating point values to nearest integer to avoid "off by > >> one texel" +* kind of errors when blitting. > >> +*/ > >> + x0 = wm_push_consts.dst_x0 = dst_x0

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #23 from Alberto Salvia Novella --- I confirm it also happens with the Adobe Flash player when reproducing videos in YouTube. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the b

[Mesa-dev] [PATCH] program: Remove _mesa_nop_vertex_program/_mesa_nop_fragment_program.

2015-02-10 Thread Matt Turner
Dead since commit 284ce20901b0c2cfab1d952cc129b8f3cd068f12 Author: Eric Anholt Date: Fri Aug 20 10:52:14 2010 -0700 Remove remnants of the old glsl compiler. --- src/mesa/program/programopt.c | 91 --- src/mesa/program/programopt.h | 6

[Mesa-dev] [PATCH] egl, wayland: RGB565 format support on Back-buffer

2015-02-10 Thread Dongwon Kim
From: Vivek Kasireddy In current code, color format is always hardcoded to __DRI_IMAGE_FORMAT_ARGB when buffer or DRI image is allocated in function calls, get_back_bo and dri2_get_buffers, regardless of current target's color format. This problem may leads to incorrect render pitch calculati

Re: [Mesa-dev] Naming conventions, DSA, and meta

2015-02-10 Thread Laura Ekstrand
I'm planning to release a v2 for buffer objects. Can we get the naming scheme decided upon? I suggest mesa buffer data fallback. On Feb 3, 2015 10:30 AM, "Kristian Høgsberg" wrote: > On Mon, Feb 2, 2015 at 11:59 AM, Thomas Helland > wrote: > > 2015-02-02 19:18 GMT+01:00 Jason Ekstrand : > >> H

Re: [Mesa-dev] [LLVMdev] mesa-10.4.4: BROKEN TLS support in GLX with llvm-toolchain v3.6.0rc2

2015-02-10 Thread Dimitry Andric
On 09 Feb 2015, at 18:52, Sedat Dilek wrote: > > On Mon, Feb 9, 2015 at 6:44 PM, Emil Velikov wrote: >> On 07/02/15 22:42, Sedat Dilek wrote: ... >>> In file included from ../../src/mapi/entry.c:49: >>> ./entry_x86-64_tls.h:66:1: warning: tentative array definition assumed >>> to have one elemen

Re: [Mesa-dev] [PATCH v2] Fixing an x86 FPU bug.

2015-02-10 Thread Predut, Marius
> -Original Message- > From: Neil Roberts [mailto:n...@linux.intel.com] > Sent: Wednesday, February 04, 2015 4:02 PM > To: Predut, Marius; mesa-dev@lists.freedesktop.org > Cc: mesa-sta...@lists.freedesktop.org > Subject: Re: [Mesa-dev] [PATCH v2] Fixing an x86 FPU bug. > > Hi Marius, >

[Mesa-dev] [Bug 89050] [HSW DRI3] Piglit glx_GLX_ARB_create_context_current_with_no_framebuffer fails

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89050 --- Comment #2 from lu hua --- When run webgl case on HSW, report "This browser does not appear to support WebGL". -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. ___

[Mesa-dev] [PATCH] i965/vs/skl: Use vec4 datatypes for message header

2015-02-10 Thread Ben Widawsky
Since we can be in this code with SIMD4x2, the execsize will be 4, and so the register width must be <= 4. If you use a vec8, the width is 8, and we'll assert fail. Fixes the following piglit tests: spec/glsl-1.20/compiler/structure-and-array-operations/array-selection.vert spec/glsl-es-3.00/compi

Re: [Mesa-dev] [PATCH] winsys/radeon: add user pointer support

2015-02-10 Thread Marek Olšák
One more thing. How can userspace check if this is supported by the kernel driver? The DRM version should have been bumped probably. Marek On Tue, Feb 10, 2015 at 9:35 AM, Christian König wrote: > Am 10.02.2015 um 03:41 schrieb Alex Deucher: >> >> On Mon, Feb 9, 2015 at 7:29 PM, Marek Olšák wro

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure: don't try to build gallium DRI drivers if --disable-dri is set

2015-02-10 Thread Emil Velikov
On 10/02/15 23:40, Brian Paul wrote: > On 02/10/2015 04:24 PM, Emil Velikov wrote: >> On 10/02/15 16:32, Brian Paul wrote: >>> Before, if --disable-dri was set we were still testing the libdrm >>> version >>> for r300, r600, vmware/svga. >>> >> Fwiw there is no libdrm* check for vmware/svga. > > R

[Mesa-dev] ARB_shader_subroutine notes

2015-02-10 Thread Ian Romanick
I just wanted to get some ideas for implementing ARB_shader_subroutine out of my brain and into the public... just in case anyone wants to work on it. It's not a newbie project by any stretch of the imagination. My basic idea for a quick-and-dirty implementation had 5 steps. All of this happens

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure: don't try to build gallium DRI drivers if --disable-dri is set

2015-02-10 Thread Brian Paul
On 02/10/2015 04:24 PM, Emil Velikov wrote: On 10/02/15 16:32, Brian Paul wrote: Before, if --disable-dri was set we were still testing the libdrm version for r300, r600, vmware/svga. Fwiw there is no libdrm* check for vmware/svga. Right, but if --disable-dri is given, we shouldn't build any

[Mesa-dev] [Bug 89043] undefined symbol: _glapi_tls_Dispatch

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89043 --- Comment #4 from Emil Velikov --- As Brian pointed out try building with --enable-tls. If that does not work, explain step by step what you're doing. Getting the output when LIBGL_DEBUG=verbose and LD_DEBUG=libs are set would be nice. You can

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #31 from darkbasic --- Works fine here, thanks. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://li

Re: [Mesa-dev] [PATCH] arb_occlusion_query2: expect an error when target mismatch in glBeginQuery()

2015-02-10 Thread Emil Velikov
I'm guessing that this was meant for the piglit ML - Cc-ing it :) -Emil On 10/02/15 07:48, Eduardo Lima Mitev wrote: > From the OpenGL ES 3.0.0 spec, section "2.13. ASYNCHRONOUS QUERIES", > page 82: > > "BeginQuery generates an INVALID_OPERATION error if any of the > following condition

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure: don't try to build gallium DRI drivers if --disable-dri is set

2015-02-10 Thread Emil Velikov
On 10/02/15 16:32, Brian Paul wrote: > Before, if --disable-dri was set we were still testing the libdrm version > for r300, r600, vmware/svga. > Fwiw there is no libdrm* check for vmware/svga. Your concern is that as you pass --disable-dri, you still get an error about missing libdrm_radeon depe

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #30 from John --- (In reply to Emil Velikov from comment #29) > Forgot to update the omx target, silly me - v2 of the patch should handle > that > http://patchwork.freedesktop.org/patch/42260/ That works! Thanks for the quick v2. --

Re: [Mesa-dev] [LLVMdev] mesa-10.4.4: BROKEN TLS support in GLX with llvm-toolchain v3.6.0rc2

2015-02-10 Thread Emil Velikov
On 10/02/15 13:17, Dimitry Andric wrote: > On 09 Feb 2015, at 18:52, Sedat Dilek wrote: >> >> On Mon, Feb 9, 2015 at 6:44 PM, Emil Velikov >> wrote: >>> On 07/02/15 22:42, Sedat Dilek wrote: > ... In file included from ../../src/mapi/entry.c:49: ./entry_x86-64_tls.h:66:1: warning: tent

Re: [Mesa-dev] [PATCH] glsl: Optimize 1/exp(x) into exp(-x).

2015-02-10 Thread Ian Romanick
On 02/10/2015 01:11 PM, Jason Ekstrand wrote: > Looks fine to me but why are we still adding algebraic optimizations to > GLSL-IR? Some cases, though this is not one, can slightly reduce memory usage. GLSL IR will likely live on for some time as the pre-linked IR, so that's a benefit we shouldn't

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #29 from Emil Velikov --- Forgot to update the omx target, silly me - v2 of the patch should handle that http://patchwork.freedesktop.org/patch/42260/ -- You are receiving this mail because: You are the assignee for the bug. ___

[Mesa-dev] [PATCH v2] auxiliary/vl: bring back the VL code for the dri targets

2015-02-10 Thread Emil Velikov
With commit c642e87d9f4(auxiliary/vl: rework the build of the VL code) we split out the VL code into a separate static library that was meant to be used by the VL targets alone - va, vdpau, xvmc. The commit failed to consider the way we handle vdpau-gl interop and broke it. Bring back the function

Re: [Mesa-dev] [PATCH 3/4] configure: rework wayland_scanner handling(fix make distcheck)

2015-02-10 Thread Emil Velikov
On 10/02/15 18:23, Matt Turner wrote: > On Tue, Feb 10, 2015 at 8:08 AM, Emil Velikov > wrote: >> Currently having the wayland-scanner is optional, which causes problems >> when autotools parses through the makefiles, and tries to generate all >> the BUILT_SOURCES. >> >> As the config option --wi

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #28 from John --- (In reply to Emil Velikov from comment #25) > Hi guys, sorry about the delay. > > Christian had some comments on the original patch which I've addressed here > - http://patchwork.freedesktop.org/patch/42201/ Can you

Re: [Mesa-dev] [PATCH] glsl: Optimize 1/exp(x) into exp(-x).

2015-02-10 Thread Matt Turner
On Tue, Feb 10, 2015 at 1:11 PM, Jason Ekstrand wrote: > Looks fine to me but why are we still adding algebraic optimizations to > GLSL-IR? I'm a little bothered by that question. It's at least the second time it's been asked of me. Until both of our backends are accepting NIR by default I don't

Re: [Mesa-dev] [PATCH] glsl: Optimize 1/exp(x) into exp(-x).

2015-02-10 Thread Jason Ekstrand
Looks fine to me but why are we still adding algebraic optimizations to GLSL-IR? Reviewed-by: Jason Ekstrand On Feb 10, 2015 12:36 PM, "Matt Turner" wrote: > Lots of shaders divide by exp2(...) which we turn into a multiplication > by the reciprocal. We can avoid the reciprocal by simply negati

Re: [Mesa-dev] [PATCH 1/3] nir: Remove unused has_indirect variable.

2015-02-10 Thread Jason Ekstrand
Reviewed-by: Jason Ekstrand On Feb 10, 2015 11:24 AM, "Matt Turner" wrote: > --- > src/glsl/nir/nir_lower_samplers.cpp | 4 > 1 file changed, 4 deletions(-) > > diff --git a/src/glsl/nir/nir_lower_samplers.cpp > b/src/glsl/nir/nir_lower_samplers.cpp > index dca086d..3015dbd 100644 > --- a/

Re: [Mesa-dev] [PATCH] mesa: silence uninitialized var warning in get_tex_rgba_uncompressed()

2015-02-10 Thread Matt Turner
On Tue, Feb 10, 2015 at 12:20 PM, Brian Paul wrote: > --- Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glsl: Optimize 1/exp(x) into exp(-x).

2015-02-10 Thread Matt Turner
Lots of shaders divide by exp2(...) which we turn into a multiplication by the reciprocal. We can avoid the reciprocal by simply negating exp2's argument. total instructions in shared programs: 5947154 -> 5946695 (-0.01%) instructions in affected programs: 118661 -> 118202 (-0.39%) helped:

[Mesa-dev] [PATCH] mesa: silence uninitialized var warning in get_tex_rgba_uncompressed()

2015-02-10 Thread Brian Paul
--- src/mesa/main/texgetimage.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index ee465e6..db674dc 100644 --- a/src/mesa/main/texgetimage.c +++ b/src/mesa/main/texgetimage.c @@ -450,7 +450,7 @@ get_tex_rgba_uncompr

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #27 from darkbasic --- Created attachment 113327 --> https://bugs.freedesktop.org/attachment.cgi?id=113327&action=edit build.log It doesn't build anymore with your latest patch (Mesa-dev-4-4-auxiliary-vl-bring-back-the-VL-code-for-

Re: [Mesa-dev] nir warnings

2015-02-10 Thread Brian Paul
On 02/10/2015 12:19 PM, Matt Turner wrote: On Tue, Feb 10, 2015 at 11:15 AM, Brian Paul wrote: There's a number of new compiler warnings (gcc 4.8.2) in the nir code: I'm glad I'm not the only one annoyed by new warnings. nir/glsl_to_nir.cpp: In member function 'virtual void {anonymous}::nir

[Mesa-dev] [PATCH] i965/fs: Convert MOV null with conditional mod into CMP.

2015-02-10 Thread Matt Turner
The cmod propagation pass handles CMP and MOV.NZ. If we propagated a conditional modifier other than NZ onto a MOV, it would be stuck there. Convert these instructions into a CMP to let the cmod be propagated further. instructions in affected programs: 1482 -> 1454 (-1.89%) helped:

Re: [Mesa-dev] [PATCH 3/3] nir: Remove casts from void*.

2015-02-10 Thread Connor Abbott
Reviewed-by: Connor Abbott On Tue, Feb 10, 2015 at 2:24 PM, Matt Turner wrote: > --- > src/glsl/nir/nir.c | 16 > src/glsl/nir/nir_dominance.c | 6 +++--- > src/glsl/nir/nir_lower_atomics.c | 3 +-- > src/glsl/nir/nir_remove_dead_vari

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89068 --- Comment #2 from Brad King --- Created attachment 113325 --> https://bugs.freedesktop.org/attachment.cgi?id=113325&action=edit VTK test output image after change -- You are receiving this mail because: You are the QA Contact for the bug. Y

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89068 --- Comment #1 from Brad King --- Created attachment 113324 --> https://bugs.freedesktop.org/attachment.cgi?id=113324&action=edit VTK test output image before change -- You are receiving this mail because: You are the QA Contact for the bug.

Re: [Mesa-dev] [PATCH 02/11] i965/blorp: round to nearest when converting float to integer

2015-02-10 Thread Matt Turner
On Tue, Feb 10, 2015 at 10:52 AM, Matt Turner wrote: >> + /* Round floating point values to nearest integer to avoid "off by one >> texel" >> +* kind of errors when blitting. >> +*/ >> + x0 = wm_push_consts.dst_x0 = dst_x0 + 0.5; >> + y0 = wm_push_consts.dst_y0 = dst_y0 + 0.5; >> +

[Mesa-dev] [Bug 89068] glTexImage2D regression by texstore_rgba switch to _mesa_format_convert

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=89068 Bug ID: 89068 Summary: glTexImage2D regression by texstore_rgba switch to _mesa_format_convert Product: Mesa Version: git Hardware: Other OS: All

Re: [Mesa-dev] [PATCH 2/3] nir: Replace assert(0) with unreachable().

2015-02-10 Thread Connor Abbott
Reviewed-by: Connor Abbott On Tue, Feb 10, 2015 at 2:24 PM, Matt Turner wrote: > --- > src/glsl/nir/glsl_to_nir.cpp | 14 +++--- > 1 file changed, 7 insertions(+), 7 deletions(-) > > diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp > index 46cfac3..e505a1d 100644

Re: [Mesa-dev] [PATCH 2/4] nir: add missing header to the sources list

2015-02-10 Thread Connor Abbott
Reviewed-by: Connor Abbott On Tue, Feb 10, 2015 at 11:08 AM, Emil Velikov wrote: > Cc: "10.5" > Signed-off-by: Emil Velikov > --- > src/glsl/Makefile.sources | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/glsl/Makefile.sources b/src/glsl/Makefile.sources > index a580b6e..7e66e91

[Mesa-dev] [PATCH 3/3] nir: Remove casts from void*.

2015-02-10 Thread Matt Turner
--- src/glsl/nir/nir.c | 16 src/glsl/nir/nir_dominance.c | 6 +++--- src/glsl/nir/nir_lower_atomics.c | 3 +-- src/glsl/nir/nir_remove_dead_variables.c | 2 +- 4 files changed, 13 insertions(+), 14 deletions(-) diff --git a/src/glsl/n

[Mesa-dev] [PATCH 2/3] nir: Replace assert(0) with unreachable().

2015-02-10 Thread Matt Turner
--- src/glsl/nir/glsl_to_nir.cpp | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp index 46cfac3..e505a1d 100644 --- a/src/glsl/nir/glsl_to_nir.cpp +++ b/src/glsl/nir/glsl_to_nir.cpp @@ -604,7 +604,7 @@ ni

[Mesa-dev] [PATCH 1/3] nir: Remove unused has_indirect variable.

2015-02-10 Thread Matt Turner
--- src/glsl/nir/nir_lower_samplers.cpp | 4 1 file changed, 4 deletions(-) diff --git a/src/glsl/nir/nir_lower_samplers.cpp b/src/glsl/nir/nir_lower_samplers.cpp index dca086d..3015dbd 100644 --- a/src/glsl/nir/nir_lower_samplers.cpp +++ b/src/glsl/nir/nir_lower_samplers.cpp @@ -69,7 +69,6

Re: [Mesa-dev] nir warnings

2015-02-10 Thread Matt Turner
On Tue, Feb 10, 2015 at 11:15 AM, Brian Paul wrote: > There's a number of new compiler warnings (gcc 4.8.2) in the nir code: I'm glad I'm not the only one annoyed by new warnings. > nir/glsl_to_nir.cpp: In member function 'virtual void > {anonymous}::nir_visitor::visit(ir_call*)': > nir/glsl_to_

[Mesa-dev] nir warnings

2015-02-10 Thread Brian Paul
There's a number of new compiler warnings (gcc 4.8.2) in the nir code: nir/glsl_to_nir.cpp: In member function 'virtual void {anonymous}::nir_visitor::visit(ir_call*)': nir/glsl_to_nir.cpp:610:73: warning: 'op' may be used uninitialized in this function [-Wmaybe-uninitialized] nir_intri

[Mesa-dev] [PATCH 4/4] i965/blorp: Emit MADs.

2015-02-10 Thread Matt Turner
Low hanging fruit: cuts a couple of instructions. --- src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 6 ++ src/mesa/drivers/dri/i965/brw_blorp_blit_eu.h | 9 + 2 files changed, 11 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_blit.cpp b/src/mesa/driv

[Mesa-dev] [PATCH 3/4] i965/blorp: Optimize clamping tex coords.

2015-02-10 Thread Matt Turner
Each emit_cond_mov() emits a CMP of its first to arguments using the specified conditional mod, followed by a predicated MOV of the fifth argument into the fourth. In all four cases here, it was just implementing MIN/MAX which we can do in a single SEL instruction. Also reorder the instructions fo

[Mesa-dev] [PATCH 1/4] i965: Don't emit saturates for instructions without destinations.

2015-02-10 Thread Matt Turner
We were special casing OPCODE_END but no other instructions that have no destination, like OPCODE_KIL, leading us to emitting MOVs with null destinations. total instructions in shared programs: 5950886 -> 5947182 (-0.06%) instructions in affected programs: 139700 -> 135996 (-2.65%) helped:

[Mesa-dev] [PATCH 2/4] i965: Use greater-equal cmod to implement maximum.

2015-02-10 Thread Matt Turner
The docs specifically call out SEL with .l and .ge as the implementations of MIN and MAX respectively. Among other things, SEL with these conditional mods are commutative. --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 5 - src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp| 6 +++---

Re: [Mesa-dev] [PATCH 1/3] nir: Add support for CSE on textures.

2015-02-10 Thread Connor Abbott
On Tue, Feb 10, 2015 at 1:32 PM, Eric Anholt wrote: > Connor Abbott writes: > >> On Sat, Feb 7, 2015 at 12:16 AM, Eric Anholt wrote: >>> NIR instruction count results on i965: >>> total instructions in shared programs: 1261954 -> 1261937 (-0.00%) >>> instructions in affected programs: 455 ->

Re: [Mesa-dev] [PATCH 02/11] i965/blorp: round to nearest when converting float to integer

2015-02-10 Thread Matt Turner
On Tue, Feb 10, 2015 at 7:40 AM, Eduardo Lima Mitev wrote: > From: Samuel Iglesias Gonsalvez > > Round floating point values to nearest integer to avoid "off by one texel" > kind of errors when blitting. > > Fixes: > > dEQP-GLES3.functional.fbo.blit.rect.out_of_bounds_nearest > dEQP-GLES3.functio

Re: [Mesa-dev] [PATCH 1/3] nir: Add support for CSE on textures.

2015-02-10 Thread Jason Ekstrand
On Tue, Feb 10, 2015 at 10:32 AM, Eric Anholt wrote: > Connor Abbott writes: > > > On Sat, Feb 7, 2015 at 12:16 AM, Eric Anholt wrote: > >> NIR instruction count results on i965: > >> total instructions in shared programs: 1261954 -> 1261937 (-0.00%) > >> instructions in affected programs:

Re: [Mesa-dev] [PATCH 1/3] nir: Add support for CSE on textures.

2015-02-10 Thread Eric Anholt
Connor Abbott writes: > On Sat, Feb 7, 2015 at 12:16 AM, Eric Anholt wrote: >> NIR instruction count results on i965: >> total instructions in shared programs: 1261954 -> 1261937 (-0.00%) >> instructions in affected programs: 455 -> 438 (-3.74%) >> >> One in yofrankie, two in tropics. Appar

Re: [Mesa-dev] [PATCH 3/4] configure: rework wayland_scanner handling(fix make distcheck)

2015-02-10 Thread Matt Turner
On Tue, Feb 10, 2015 at 8:08 AM, Emil Velikov wrote: > Currently having the wayland-scanner is optional, which causes problems > when autotools parses through the makefiles, and tries to generate all > the BUILT_SOURCES. > > As the config option --with-egl-platform=wayland is not the default, we >

Re: [Mesa-dev] [PATCH 2/2] i915c: Use the actual MIN instruction.

2015-02-10 Thread Matt Turner
Both look like what I'd expect, FWIW. Thanks Ken! Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #26 from Andy Furniss --- (In reply to Emil Velikov from comment #25) > Hi guys, sorry about the delay. > > Christian had some comments on the original patch which I've addressed here > - http://patchwork.freedesktop.org/patch/42201/

Re: [Mesa-dev] [PATCH 10/11] mesa: Return error if BeginQuery is called with an existing object of different type

2015-02-10 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick We'll have to see if this breaks any applications... On 02/10/2015 07:40 AM, Eduardo Lima Mitev wrote: > Section 2.14 Asynchronous Queries, page 84 of the OpenGL ES 3.0.4 > spec states: > > "BeginQuery generates an INVALID_OPERATION error if any of the

Re: [Mesa-dev] [PATCH 01/11] i965: Fix ctx->Texture.CubeMapSeamless

2015-02-10 Thread Ian Romanick
On 02/10/2015 07:40 AM, Eduardo Lima Mitev wrote: > From: Iago Toral Quiroga > > The intel driver code, and apparently all other Mesa drivers, call > _mesa_initialize_context early in the CreateContext hook. That > function will end up calling _mesa_init_texture which will do: > > ctx->Texture.C

Re: [Mesa-dev] [PATCH 08/11] mesa: Return INVALID_OPERATION when querying a never bound Query obj

2015-02-10 Thread Ian Romanick
This patch is Reviewed-by: Ian Romanick On 02/10/2015 07:40 AM, Eduardo Lima Mitev wrote: > Section 2.14 Asynchronous Queries, page 84 of the OpenGL ES 3.0.4 states: > > "The command void GenQueries( sizei n, uint *ids ); returns n previously > unused > query object names in ids. These names a

Re: [Mesa-dev] [PATCH 06/11] mesa: Add _mesa_is_array_texture helper

2015-02-10 Thread Ian Romanick
On 02/10/2015 08:10 AM, Brian Paul wrote: > On 02/10/2015 08:40 AM, Eduardo Lima Mitev wrote: >> From: Iago Toral Quiroga >> >> --- >> src/mesa/main/teximage.c | 22 ++ >> src/mesa/main/teximage.h | 3 +++ >> 2 files changed, 25 insertions(+) >> >> diff --git a/src/mesa/ma

Re: [Mesa-dev] [PATCH 05/11] mesa: Fix error validating args for TexSubImage3D

2015-02-10 Thread Ian Romanick
On 02/10/2015 08:12 AM, Brian Paul wrote: > On 02/10/2015 08:40 AM, Eduardo Lima Mitev wrote: >> The zoffset and depth values were not being considered when calling >> error_check_subtexture_dimensions(). >> >> Fixes 2 dEQP tests: >> * dEQP-GLES3.functional.negative_api.texture.texsubimage3d_neg_of

Re: [Mesa-dev] [PATCH 04/11] mesa: Add missing error checks to GetProgramInfoLog, GetShaderInfoLog and GetProgramiv

2015-02-10 Thread Ian Romanick
On 02/10/2015 07:40 AM, Eduardo Lima Mitev wrote: > Fixes 3 dEQP tests: > * dEQP-GLES3.functional.negative_api.state.get_program_info_log > * dEQP-GLES3.functional.negative_api.state.get_shader_info_log > * dEQP-GLES3.functional.negative_api.state.get_programiv > --- > src/mesa/main/shaderapi.c |

Re: [Mesa-dev] [PATCH 03/11] mesa: Return INVALID_ENUM in glClearBufferiv() when buffer is not color or stencil

2015-02-10 Thread Ian Romanick
On 02/10/2015 07:40 AM, Eduardo Lima Mitev wrote: > Section 4.2.3 Clearing the Buffers, page 190 of the OpenGL ES 3.0.4 spec says: > "ClearBufferiv generates an INVALID_ENUM error if buffer is not COLOR or > STENCIL." > > Fixes 1 dEQP test: > * dEQP-GLES3.functional.negative_api.buffer.clear_buff

Re: [Mesa-dev] [PATCH 3/4] configure: rework wayland_scanner handling(fix make distcheck)

2015-02-10 Thread Kristian Høgsberg
On Tue, Feb 10, 2015 at 8:08 AM, Emil Velikov wrote: > Currently having the wayland-scanner is optional, which causes problems > when autotools parses through the makefiles, and tries to generate all > the BUILT_SOURCES. > > As the config option --with-egl-platform=wayland is not the default, we >

Re: [Mesa-dev] [PATCH 2/2] i915c: Use the actual MIN instruction.

2015-02-10 Thread Ian Romanick
On 02/10/2015 03:36 AM, Kenneth Graunke wrote: > Matt Turner noticed that the hardware has always had a MIN > instruction, but the driver always used MAX+MOV for no > apparent reason. And it has been right there in the docs the whole time too. WTF? > This should cut an instruction, and a tempora

[Mesa-dev] [PATCH] configure: don't try to build gallium DRI drivers if --disable-dri is set

2015-02-10 Thread Brian Paul
Before, if --disable-dri was set we were still testing the libdrm version for r300, r600, vmware/svga. Cc: "10.4, 10.5" --- I'm not an autoconf expert, so there might be a better way of doing this. --- configure.ac | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/configu

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2015-02-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #25 from Emil Velikov --- Hi guys, sorry about the delay. Christian had some comments on the original patch which I've addressed here - http://patchwork.freedesktop.org/patch/42201/ Can you give it a spin ? -- You are receiving thi

Re: [Mesa-dev] [PATCH 1/4] nir: resolve nir.h dependency list (fix make distcheck)

2015-02-10 Thread Emil Velikov
On 10/02/15 16:07, Emil Velikov wrote: > Use nir/nir_opcodes.h as is (w/o the absolute path), as it is the target > name used to generate the actual file. Otherwise the target is missing, > the file won't get generated and the build will fail. > > Cc: "10.5" Fwiw the "destkop" typo in all 4 patch

[Mesa-dev] [PATCH 1/4] nir: resolve nir.h dependency list (fix make distcheck)

2015-02-10 Thread Emil Velikov
Use nir/nir_opcodes.h as is (w/o the absolute path), as it is the target name used to generate the actual file. Otherwise the target is missing, the file won't get generated and the build will fail. Cc: "10.5" Signed-off-by: Emil Velikov --- src/glsl/Makefile.am | 2 +- 1 file changed, 1 insert

Re: [Mesa-dev] [PATCH 05/11] mesa: Fix error validating args for TexSubImage3D

2015-02-10 Thread Brian Paul
On 02/10/2015 08:40 AM, Eduardo Lima Mitev wrote: The zoffset and depth values were not being considered when calling error_check_subtexture_dimensions(). Fixes 2 dEQP tests: * dEQP-GLES3.functional.negative_api.texture.texsubimage3d_neg_offset * dEQP-GLES3.functional.negative_api.texture.texsub

Re: [Mesa-dev] [PATCH 06/11] mesa: Add _mesa_is_array_texture helper

2015-02-10 Thread Brian Paul
On 02/10/2015 08:40 AM, Eduardo Lima Mitev wrote: From: Iago Toral Quiroga --- src/mesa/main/teximage.c | 22 ++ src/mesa/main/teximage.h | 3 +++ 2 files changed, 25 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index c9c48bb..f0d0ef0

[Mesa-dev] [PATCH 4/4] auxiliary/vl: bring back the VL code for the dri targets

2015-02-10 Thread Emil Velikov
With commit c642e87d9f4(auxiliary/vl: rework the build of the VL code) we split out the VL code into a separate static library that was meant to be used by the VL targets alone - va, vdpau, xvmc. The commit failed to consider the way we handle vdpau-gl interop and broke it. Bring back the function

[Mesa-dev] [PATCH 2/4] nir: add missing header to the sources list

2015-02-10 Thread Emil Velikov
Cc: "10.5" Signed-off-by: Emil Velikov --- src/glsl/Makefile.sources | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/Makefile.sources b/src/glsl/Makefile.sources index a580b6e..7e66e91 100644 --- a/src/glsl/Makefile.sources +++ b/src/glsl/Makefile.sources @@ -21,6 +21,7 @@ NIR_FILES

[Mesa-dev] [PATCH 3/4] configure: rework wayland_scanner handling(fix make distcheck)

2015-02-10 Thread Emil Velikov
Currently having the wayland-scanner is optional, which causes problems when autotools parses through the makefiles, and tries to generate all the BUILT_SOURCES. As the config option --with-egl-platform=wayland is not the default, we won't end up setting the WAYLAND_SCANNER variable, which in turn

[Mesa-dev] [PATCH 08/11] mesa: Return INVALID_OPERATION when querying a never bound Query obj

2015-02-10 Thread Eduardo Lima Mitev
Section 2.14 Asynchronous Queries, page 84 of the OpenGL ES 3.0.4 states: "The command void GenQueries( sizei n, uint *ids ); returns n previously unused query object names in ids. These names are marked as used, for the purposes of GenQueries only, but no object is associated with them until the

[Mesa-dev] [PATCH 01/11] i965: Fix ctx->Texture.CubeMapSeamless

2015-02-10 Thread Eduardo Lima Mitev
From: Iago Toral Quiroga The intel driver code, and apparently all other Mesa drivers, call _mesa_initialize_context early in the CreateContext hook. That function will end up calling _mesa_init_texture which will do: ctx->Texture.CubeMapSeamless = _mesa_is_gles3(ctx); But this won't work at th

[Mesa-dev] [PATCH 07/11] i965: Make sure we always mark array surfaces as such

2015-02-10 Thread Eduardo Lima Mitev
From: Iago Toral Quiroga Even if they only have one slice, otherwise textureSize() won't produce correct results for the depth value. Fixes 10 dEQP tests in this category: dEQP-GLES3.functional.shaders.texture_functions.texturesize.sampler2darray* --- src/mesa/drivers/dri/i965/gen7_wm_surface_s

[Mesa-dev] [PATCH 04/11] mesa: Add missing error checks to GetProgramInfoLog, GetShaderInfoLog and GetProgramiv

2015-02-10 Thread Eduardo Lima Mitev
Fixes 3 dEQP tests: * dEQP-GLES3.functional.negative_api.state.get_program_info_log * dEQP-GLES3.functional.negative_api.state.get_shader_info_log * dEQP-GLES3.functional.negative_api.state.get_programiv --- src/mesa/main/shaderapi.c | 84 --- 1 file cha

[Mesa-dev] [PATCH 03/11] mesa: Return INVALID_ENUM in glClearBufferiv() when buffer is not color or stencil

2015-02-10 Thread Eduardo Lima Mitev
Section 4.2.3 Clearing the Buffers, page 190 of the OpenGL ES 3.0.4 spec says: "ClearBufferiv generates an INVALID_ENUM error if buffer is not COLOR or STENCIL." Fixes 1 dEQP test: * dEQP-GLES3.functional.negative_api.buffer.clear_bufferiv --- src/mesa/main/clear.c | 13 + 1 file cha

[Mesa-dev] [PATCH 02/11] i965/blorp: round to nearest when converting float to integer

2015-02-10 Thread Eduardo Lima Mitev
From: Samuel Iglesias Gonsalvez Round floating point values to nearest integer to avoid "off by one texel" kind of errors when blitting. Fixes: dEQP-GLES3.functional.fbo.blit.rect.out_of_bounds_nearest dEQP-GLES3.functional.fbo.blit.rect.out_of_bounds_linear dEQP-GLES3.functional.fbo.blit.rect.

[Mesa-dev] [PATCH 11/11] i965: Fix textureSize for Lod > 0 with non-mipmap filters

2015-02-10 Thread Eduardo Lima Mitev
From: Iago Toral Quiroga Currently, when the MinFilter is GL_LINEAR or GL_NEAREST we hide the actual miplevel count from the hardware (and we avoid re-creating the miptree structure with all the levels), since we don't expect levels other than the base level to be needed. Unfortunately, GLSL's te

[Mesa-dev] [PATCH 10/11] mesa: Return error if BeginQuery is called with an existing object of different type

2015-02-10 Thread Eduardo Lima Mitev
Section 2.14 Asynchronous Queries, page 84 of the OpenGL ES 3.0.4 spec states: "BeginQuery generates an INVALID_OPERATION error if any of the following conditions hold: [...] id is the name of an existing query object whose type does not match target; [...] Similar wording exists in the O

[Mesa-dev] [PATCH 09/11] i965: Fix non-AA wide line rendering with fractional line widths

2015-02-10 Thread Eduardo Lima Mitev
From: Iago Toral Quiroga From 14.5.2.2. Wide Lines of the OpenGL spec 4.5: "(...)Let w be the width rounded to the nearest integer (...). If the line segment has endpoints given by (x0,y0) and (x1,y1) in window coordinates, the segment with endpoints (x0,y0-(w-1)/2) and (x1,y1-(w-1/2)) is raste

[Mesa-dev] [PATCH 06/11] mesa: Add _mesa_is_array_texture helper

2015-02-10 Thread Eduardo Lima Mitev
From: Iago Toral Quiroga --- src/mesa/main/teximage.c | 22 ++ src/mesa/main/teximage.h | 3 +++ 2 files changed, 25 insertions(+) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index c9c48bb..f0d0ef0 100644 --- a/src/mesa/main/teximage.c +++ b/src/mesa/ma

[Mesa-dev] [PATCH 05/11] mesa: Fix error validating args for TexSubImage3D

2015-02-10 Thread Eduardo Lima Mitev
The zoffset and depth values were not being considered when calling error_check_subtexture_dimensions(). Fixes 2 dEQP tests: * dEQP-GLES3.functional.negative_api.texture.texsubimage3d_neg_offset * dEQP-GLES3.functional.negative_api.texture.texsubimage3d_invalid_offset --- src/mesa/main/teximage.c

[Mesa-dev] [PATCH 00/11] More patches fixing dEQP test fails

2015-02-10 Thread Eduardo Lima Mitev
Hi, This is yet another batch of fixes for dEQP failing tests. It fixes a total of 249 test cases. The test failures were gathered on i965 (gen7) against 10.4.2, but again there are driver and version agnostic fixes. A GIT tree with these patches based on git-08a06 is available at: https://git

[Mesa-dev] [PATCHv4 32/32] i965: Don't compact instructions with unmapped bits.

2015-02-10 Thread Francisco Jerez
Some instruction bits don't have a mapping defined to any compacted instruction field. If they're ever set and we end up compacting the instruction they will be forced to zero. Avoid using compaction in such cases. v2: Align multiple lines of an expression to the same column. Change conditi

[Mesa-dev] [PATCH v5 18/29] glsl/lexer: Support double floats

2015-02-10 Thread Ilia Mirkin
From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Ian Romanick Reviewed-by: Matt Turner --- src/glsl/glsl_lexer.ll | 31 +++ 1 file changed, 27 insertions(+), 4 deletions(-) diff --git a/src/glsl/glsl_lexer.ll b/src/glsl/glsl_lexer.ll index 48ba463..8dc3d1

[Mesa-dev] [PATCH v5 03/29] glsl: Add double builtin type

2015-02-10 Thread Ilia Mirkin
This causes a lot of warnings about unchecked type in switch statements - fix them later. Signed-off-by: Dave Airlie Reviewed-by: Matt Turner --- src/glsl/glsl_types.h | 9 + 1 file changed, 9 insertions(+) diff --git a/src/glsl/glsl_types.h b/src/glsl/glsl_types.h index 441015c..f472d

[Mesa-dev] [PATCH v5 14/29] glsl: Add support doubles in optimization passes

2015-02-10 Thread Ilia Mirkin
From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner --- src/glsl/opt_algebraic.cpp| 26 ++ src/glsl/opt_constant_propagation.cpp | 3 +++ src/glsl/opt_minmax.cpp | 13 + 3 files changed, 38 insertions(+), 4 deleti

[Mesa-dev] [PATCH v5 22/29] glsl: add double support to lower_mat_op_to_vec

2015-02-10 Thread Ilia Mirkin
From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Ian Romanick --- src/glsl/lower_mat_op_to_vec.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/lower_mat_op_to_vec.cpp b/src/glsl/lower_mat_op_to_vec.cpp index 105ee0d..dda754f 100644 --- a/src/glsl/lower_mat_op_to_vec

[Mesa-dev] [PATCH v5 07/29] glsl: Uniform linking support for doubles

2015-02-10 Thread Ilia Mirkin
From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/link_uniforms.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index de2f6c9..3aa6e0a 100644 --- a/src/glsl/link_uniforms.cpp +++ b/src/glsl/link_unifor

[Mesa-dev] [PATCH v5 04/29] mesa: add double uniform support. (v5)

2015-02-10 Thread Ilia Mirkin
From: Dave Airlie This adds support for the new uniform interfaces from ARB_gpu_shader_fp64. v2: support ARB_separate_shader_objects ProgramUniform*d* (Ian) don't allow boolean uniforms to be updated (issue 15) (Ian) v3: fix size_mul v4: Teach uniform update to take into account double precisio

[Mesa-dev] [PATCH v5 15/29] glsl: Add ubo lowering support for doubles

2015-02-10 Thread Ilia Mirkin
From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/lower_ubo_reference.cpp | 57 +++- 1 file changed, 33 insertions(+), 24 deletions(-) diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp index 43dd067..4ea4ccb 100644 ---

  1   2   >