Re: [Mesa-dev] [PATCH v2 11/28] glsl/ir: Add cloning support for doubles

This patch is Reviewed-by: Ian Romanick On 02/06/2015 06:56 AM, Ilia Mirkin wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > Reviewed-by: Matt Turner > --- > src/glsl/ir_clone.cpp | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/src/glsl/ir_clone.cpp b/src/glsl/ir_clone.

Re: [Mesa-dev] [PATCH v2 04/28] mesa: add double uniform support. (v5)

On Fri, Feb 06, 2015 at 09:18:35AM +0200, Ian Romanick wrote: > On 02/06/2015 06:56 AM, Ilia Mirkin wrote: > > From: Dave Airlie > > > > This adds support for the new uniform interfaces > > from ARB_gpu_shader_fp64. > > > > v2: > > support ARB_separate_shader_objects ProgramUniform*d* (Ian) > >

Re: [Mesa-dev] [PATCH v2 10/28] glsl/ir: Add printing support for doubles

This patch is Reviewed-by: Ian Romanick On 02/06/2015 06:56 AM, Ilia Mirkin wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > Reviewed-by: Matt Turner > --- > src/glsl/ir_print_visitor.cpp | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/glsl/ir_print_vis

Re: [Mesa-dev] [PATCH v2 09/28] glsl/ir: Add builtin function support for doubles

There's a bunch of tabs that should be replaced with spaces. Other comments below... On 02/06/2015 06:56 AM, Ilia Mirkin wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > --- > src/glsl/ir.cpp | 104 > ++-- > src/glsl/ir.h

Re: [Mesa-dev] [PATCH v2 11/28] glsl/ir: Add cloning support for doubles

On Thu, Feb 05, 2015 at 11:56:33PM -0500, Ilia Mirkin wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > Reviewed-by: Matt Turner If we want to squash this somewhere, the first patch of the split (glsl: Add double builtin type) could be a candidate - we get rid of one warning. > ---

Re: [Mesa-dev] [PATCH v2 08/28] glsl: Uniform linking support for doubles

On 02/06/2015 06:56 AM, Ilia Mirkin wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > --- > src/glsl/link_uniforms.cpp | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp > index de2f6c9..0a4dac2 10064

Re: [Mesa-dev] [PATCH v2 07/28] glsl: Add double builtin type generation

This patch is Reviewed-by: Ian Romanick On 02/06/2015 06:56 AM, Ilia Mirkin wrote: > From: Dave Airlie > > Signed-off-by: Dave Airlie > Reviewed-by: Matt Turner > --- > src/glsl/builtin_types.cpp | 30 ++ > 1 file changed, 30 insertions(+) > > diff --git a/src/g

Re: [Mesa-dev] [PATCH v2 06/28] glsl: Add double builtin type

With the minor nit below fixed, this patch is Reviewed-by: Ian Romanick On 02/06/2015 06:56 AM, Ilia Mirkin wrote: > From: Dave Airlie > > This causes a lot of warnings about unchecked type in > switch statements - fix them later. > > Signed-off-by: Dave Airlie > Reviewed-by: Matt Turner >

Re: [Mesa-dev] [PATCH v2 04/28] mesa: add double uniform support. (v5)

On 02/06/2015 06:56 AM, Ilia Mirkin wrote: > From: Dave Airlie > > This adds support for the new uniform interfaces > from ARB_gpu_shader_fp64. > > v2: > support ARB_separate_shader_objects ProgramUniform*d* (Ian) > don't allow boolean uniforms to be updated (issue 15) (Ian) > > v3: fix size_mu

Re: [Mesa-dev] [PATCH v2 02/28] mesa: add ARB_gpu_shader_fp64 extension info (v2)

This patch is Reviewed-by: Ian Romanick On 02/06/2015 06:56 AM, Ilia Mirkin wrote: > From: Dave Airlie > > This just adds the entries to extensions.c and mtypes.h > > v2: use core profile only (Ian) > > Signed-off-by: Dave Airlie > --- > src/mesa/main/extensions.c | 1 + > src/mesa/main/mt

Re: [Mesa-dev] [PATCH v2 01/28] glapi: add ARB_gpu_shader_fp64 (v2)

This patch is Reviewed-by: Ian Romanick On 02/06/2015 06:56 AM, Ilia Mirkin wrote: > From: Dave Airlie > > Just add the xml file covering this extension, > and dummy interface files in mesa, and fix up > sanity tests. > > v2: > Enable ProgramUniform*d* from ARB_separate_shader_objects (Ian) >

Re: [Mesa-dev] [PATCH v2 03/28] mesa: add mesa_type_is_double helper function (v2)

On 02/06/2015 06:56 AM, Ilia Mirkin wrote: > From: Dave Airlie > > This is a helper to return if a type is based on a double. > > v2: GLboolean->bool (Ian) > > Reviewed-by: Ian Romanick > Signed-off-by: Dave Airlie > --- > src/mesa/program/prog_parameter.h | 23 +++ > 1 f

[Mesa-dev] [PATCH 2/3] i965/fs: Handle CMP.nz ... 0 and AND.nz ... 1 similarly in cmod propagation

From: Ian Romanick Espically on platforms that do not natively generate 0u and ~0u for Boolean results, we generate a lot of sequences where a CMP is followed by an AND with 1. emit_bool_to_cond_code does this, for example. On ILK, this results in a sequence like: add(8) g3<1>F

[Mesa-dev] [PATCH 3/3] i965/fs: Use MOV.nz instead of AND.nz to generate flag on SNB+

From: Ian Romanick On SNB+, the Boolean result is always 0 or ~0, so MOV.nz produces the same effect as AND.nz. However, later cmod propagation passes can handle the MOV.nz, but they cannot handle the AND.nz due to src1 being 1. Shader-db results: Ivy Bridge (0x0166): total instructions in sha

[Mesa-dev] [PATCH 1/3] i965/fs: Emit better b2f of an expression on pre-SNB

From: Ian Romanick On platforms that do not natively generate 0u and ~0u for Boolean results, b2f expressions that look like f = b2f(expr cmp 0) will generate better code by pretending the expression is f = ir_triop_sel(0.0, 1.0, expr cmp 0) This is because the last instruction of "exp

Re: [Mesa-dev] [PATCH v2 04/28] mesa: add double uniform support. (v5)

I think 'component_size' would be better over the various dmul, size_mul, etc. On Fri, Feb 6, 2015 at 5:56 PM, Ilia Mirkin wrote: > From: Dave Airlie > > This adds support for the new uniform interfaces > from ARB_gpu_shader_fp64. > > v2: > support ARB_separate_shader_objects ProgramUniform*d* (

Re: [Mesa-dev] [PATCH 09/10] nir: Add a global code motion (GCM) pass

On Thu, Feb 5, 2015 at 7:01 PM, Connor Abbott wrote: > On Thu, Feb 5, 2015 at 9:33 PM, Jason Ekstrand > wrote: > > > > On Feb 5, 2015 5:07 PM, "Connor Abbott" wrote: > >> > >> On Thu, Feb 5, 2015 at 5:29 PM, Jason Ekstrand > >> wrote: > >> > --- > >> > src/glsl/Makefile.sources | 1 + > >>

[Mesa-dev] [PATCH v2 01/28] glapi: add ARB_gpu_shader_fp64 (v2)

From: Dave Airlie Just add the xml file covering this extension, and dummy interface files in mesa, and fix up sanity tests. v2: Enable ProgramUniform*d* from ARB_separate_shader_objects (Ian) use 40 instead of 43 for dispatch_sanity.cpp (Chris) uncomment PU sanity tests. Signed-off-by: Dave Ai

[Mesa-dev] [PATCH v2 03/28] mesa: add mesa_type_is_double helper function (v2)

From: Dave Airlie This is a helper to return if a type is based on a double. v2: GLboolean->bool (Ian) Reviewed-by: Ian Romanick Signed-off-by: Dave Airlie --- src/mesa/program/prog_parameter.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/src/mesa/program/prog

[Mesa-dev] [PATCH v2 14/28] glsl: Add support doubles in optimization passes

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner --- src/glsl/opt_constant_propagation.cpp | 3 +++ src/glsl/opt_minmax.cpp | 13 + 2 files changed, 16 insertions(+) diff --git a/src/glsl/opt_constant_propagation.cpp b/src/glsl/opt_constant_pro

[Mesa-dev] [PATCH v2 04/28] mesa: add double uniform support. (v5)

From: Dave Airlie This adds support for the new uniform interfaces from ARB_gpu_shader_fp64. v2: support ARB_separate_shader_objects ProgramUniform*d* (Ian) don't allow boolean uniforms to be updated (issue 15) (Ian) v3: fix size_mul v4: Teach uniform update to take into account double precisio

[Mesa-dev] [PATCH v2 28/28] glsl: add a lowering pass for frexp/ldexp with double arguments

Signed-off-by: Ilia Mirkin --- src/glsl/ir_optimization.h | 1 + src/glsl/lower_instructions.cpp | 279 +++- 2 files changed, 279 insertions(+), 1 deletion(-) diff --git a/src/glsl/ir_optimization.h b/src/glsl/ir_optimization.h index 9f91e2f..7eb861a 10

[Mesa-dev] [PATCH v2 25/28] glsl/lower_instructions: add double lowering passes

From: Dave Airlie This lowers double dot product and lrp to fma. Signed-off-by: Dave Airlie --- src/glsl/lower_instructions.cpp | 83 + 1 file changed, 83 insertions(+) diff --git a/src/glsl/lower_instructions.cpp b/src/glsl/lower_instructions.cpp index

[Mesa-dev] [PATCH v2 27/28] glsl: lower double optional passes (v2)

From: Dave Airlie These lowering passes are optional for the backend to request, currently the TGSI softpipe backend most likely the r600g backend would want to use these passes as is. They aim to hit the gallium opcodes from the standard rounding/truncation functions. v2: also lower floor in mo

[Mesa-dev] [PATCH v2 22/28] glsl: add double support to lower_mat_op_to_vec

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/lower_mat_op_to_vec.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/glsl/lower_mat_op_to_vec.cpp b/src/glsl/lower_mat_op_to_vec.cpp index 105ee0d..dda754f 100644 --- a/src/glsl/lower_mat_op_to_vec.cpp +++ b/src/glsl/lower_m

[Mesa-dev] [PATCH v2 23/28] glsl: validate output types for shader stages

From: Tapani Pälli Patch fixes Piglit test: arb_gpu_shader_fp64/preprocessor/fs-output-double.frag and adds additional validation for shader outputs. Signed-off-by: Tapani Pälli Signed-off-by: Dave Airlie --- src/glsl/ast_to_hir.cpp | 47 +++ 1

[Mesa-dev] [PATCH v2 24/28] glsl: enable/disable certain lowering passes for doubles

From: Dave Airlie We want to restrict some lowering passes to floats only, and enable other for doubles. Signed-off-by: Dave Airlie --- src/glsl/lower_instructions.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/lower_instructions.cpp b/src/glsl/lower_ins

[Mesa-dev] [PATCH v2 02/28] mesa: add ARB_gpu_shader_fp64 extension info (v2)

From: Dave Airlie This just adds the entries to extensions.c and mtypes.h v2: use core profile only (Ian) Signed-off-by: Dave Airlie --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/mai

[Mesa-dev] [PATCH v2 21/28] glsl: Linking support for doubles

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/link_uniform_initializers.cpp | 8 +++- src/glsl/link_varyings.cpp | 3 ++- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/src/glsl/link_uniform_initializers.cpp b/src/glsl/link_uniform_initializers.cpp i

[Mesa-dev] [PATCH v2 00/28] add fp64 support to mesa and glsl compiler

This series has Topi's split of the initial "glsl: add double support" patch. I've also integrated feedback (and R-b's) from Matt and Brian. I believe that all the comments were either implemented or I sent questions on-list. Please let me know if I've missed anything, or otherwise messed things up

[Mesa-dev] [PATCH v2 05/28] glsl: add ARB_gpu_shader_fp64 to the glsl extensions. (v2)

From: Dave Airlie v2: add define bit (Tapani Pälli) Patch makes following Piglit tests pass: arb_gpu_shader_fp64/preprocessor/define.vert arb_gpu_shader_fp64/preprocessor/define.frag Reviewed-by: Ian Romanick Signed-off-by: Dave Airlie Reviewed-by: Matt Turner --- src/glsl/glcpp/glcpp

[Mesa-dev] [PATCH v2 26/28] glsl: implement double builtin functions

From: Dave Airlie This implements the bulk of the builtin functions for fp64 support. Signed-off-by: Dave Airlie --- src/glsl/builtin_functions.cpp | 751 +++-- 1 file changed, 492 insertions(+), 259 deletions(-) diff --git a/src/glsl/builtin_functions.cpp

[Mesa-dev] [PATCH v2 19/28] glsl: Support double inouts

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/ir_set_program_inouts.cpp | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/src/glsl/ir_set_program_inouts.cpp b/src/glsl/ir_set_program_inouts.cpp index 97ead75..b38742c 100644 --- a/src/

[Mesa-dev] [PATCH v2 07/28] glsl: Add double builtin type generation

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner --- src/glsl/builtin_types.cpp | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/glsl/builtin_types.cpp b/src/glsl/builtin_types.cpp index 10fac0f..fef86df 100644 --- a/src/glsl/builtin_

[Mesa-dev] [PATCH v2 09/28] glsl/ir: Add builtin function support for doubles

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/ir.cpp | 104 ++-- src/glsl/ir.h | 21 src/glsl/ir_validate.cpp| 68 +++--- src/mesa/program/ir_to_mesa.cpp | 10 4 files

[Mesa-dev] [PATCH v2 15/28] glsl: Add ubo lowering support for doubles

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner --- src/glsl/lower_ubo_reference.cpp | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp index 43dd067..b1eaf62 100644 --- a/sr

[Mesa-dev] [PATCH v2 13/28] glsl/ir: Add builder support for functions with double floats

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner --- src/glsl/ir_builder.cpp | 23 +++ src/glsl/ir_builder.h | 5 + 2 files changed, 28 insertions(+) diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir_builder.cpp index a2f6f29..37bbffa 100644 --

[Mesa-dev] [PATCH v2 16/28] glsl/ast: Support double floats

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/ast.h | 2 ++ src/glsl/ast_function.cpp | 67 + src/glsl/ast_to_hir.cpp | 38 +-- src/glsl/glsl_parser_extras.cpp | 4 +++ 4 files changed, 96 i

[Mesa-dev] [PATCH v2 12/28] glsl/ir: Add builtin constant function support for doubles

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/ir_constant_expression.cpp | 242 +++- 1 file changed, 210 insertions(+), 32 deletions(-) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_constant_expression.cpp index 1e8b3a3..33b8f4f 100

[Mesa-dev] [PATCH v2 20/28] glsl: Support double loop control

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/loop_controls.cpp | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/src/glsl/loop_controls.cpp b/src/glsl/loop_controls.cpp index 1c1d34f..412bb20 100644 --- a/src/glsl/loop_controls.cpp +++ b/src/glsl

[Mesa-dev] [PATCH v2 11/28] glsl/ir: Add cloning support for doubles

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner --- src/glsl/ir_clone.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/ir_clone.cpp b/src/glsl/ir_clone.cpp index dffa578..5c7279c 100644 --- a/src/glsl/ir_clone.cpp +++ b/src/glsl/ir_clone.cpp @@ -327,6 +327

[Mesa-dev] [PATCH v2 17/28] glsl/parser: Support double floats

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner --- src/glsl/glsl_parser.yy | 33 + 1 file changed, 29 insertions(+), 4 deletions(-) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 7fb8c38..596e432 100644 --- a/src/gls

[Mesa-dev] [PATCH v2 18/28] glsl/lexer: Support double floats

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/glsl_lexer.ll | 29 + 1 file changed, 25 insertions(+), 4 deletions(-) diff --git a/src/glsl/glsl_lexer.ll b/src/glsl/glsl_lexer.ll index 57c46be..d8bdaa7 100644 --- a/src/glsl/glsl_lexer.ll +++ b/src/glsl/gl

[Mesa-dev] [PATCH v2 06/28] glsl: Add double builtin type

From: Dave Airlie This causes a lot of warnings about unchecked type in switch statements - fix them later. Signed-off-by: Dave Airlie Reviewed-by: Matt Turner --- src/glsl/builtin_type_macros.h | 16 ++ src/glsl/glsl_parser_extras.h | 5 ++ src/glsl/glsl_types.cpp| 109 ++

[Mesa-dev] [PATCH v2 10/28] glsl/ir: Add printing support for doubles

From: Dave Airlie Signed-off-by: Dave Airlie Reviewed-by: Matt Turner --- src/glsl/ir_print_visitor.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/glsl/ir_print_visitor.cpp b/src/glsl/ir_print_visitor.cpp index bd39805..3600827 100644 --- a/src/glsl/ir_print_visitor.c

[Mesa-dev] [PATCH v2 08/28] glsl: Uniform linking support for doubles

From: Dave Airlie Signed-off-by: Dave Airlie --- src/glsl/link_uniforms.cpp | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index de2f6c9..0a4dac2 100644 --- a/src/glsl/link_uniforms.cpp +++ b/src/glsl/link_unifor

Re: [Mesa-dev] [PATCH 05/13] mesa: add double uniform support. (v4)

On Thu, Feb 5, 2015 at 11:17 AM, Brian Paul wrote: > On 02/05/2015 12:27 AM, Ilia Mirkin wrote: >> >> From: Dave Airlie >> >> This adds support for the new uniform interfaces >> from ARB_gpu_shader_fp64. >> >> v2: >> support ARB_separate_shader_objects ProgramUniform*d* (Ian) >> don't allow boole

Re: [Mesa-dev] [PATCH 4/4] i965: Allow Y-tiled allocations for large surfaces

On Wed, Jan 14, 2015 at 10:34:52AM -0800, Jason Ekstrand wrote: > On Tue, Jan 13, 2015 at 11:37 PM, Ben Widawsky > wrote: > > > This patch will use a new calculation to determine if a surface can be > > blitted > > from or to. Previously, the "total_height" member was used. Total_height > > in th

[Mesa-dev] [Bug 65534] Piglit glx_glx-multithread-shader-compile randomly aborts or core dumps

https://bugs.freedesktop.org/show_bug.cgi?id=65534 lu hua changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Mesa-dev] [Bug 65534] Piglit glx_glx-multithread-shader-compile randomly aborts or core dumps

https://bugs.freedesktop.org/show_bug.cgi?id=65534 lu hua changed: What|Removed |Added Status|RESOLVED|VERIFIED --- Comment #8 from lu hua --- Verifi

Re: [Mesa-dev] [PATCH 05/13] mesa: add double uniform support. (v4)

On Thu, Feb 5, 2015 at 2:49 AM, Matt Turner wrote: > On Wed, Feb 4, 2015 at 11:27 PM, Ilia Mirkin wrote: >> diff --git a/src/mesa/program/prog_parameter.c >> b/src/mesa/program/prog_parameter.c >> index 0ef4641..e1bbc00 100644 >> --- a/src/mesa/program/prog_parameter.c >> +++ b/src/mesa/program/

Re: [Mesa-dev] [PATCH 03/13] mesa: add mesa_type_is_double helper function (v2)

On Thu, Feb 5, 2015 at 2:48 AM, Matt Turner wrote: > On Wed, Feb 4, 2015 at 11:27 PM, Ilia Mirkin wrote: >> From: Dave Airlie >> >> This is a helper to return if a type is based on a double. >> >> v2: GLboolean->bool (Ian) >> >> Reviewed-by: Ian Romanick >> Signed-off-by: Dave Airlie >> --- >>

Re: [Mesa-dev] [PATCH] gallium/postprocessing: fix crash at context destruction

On 06.02.2015 02:31, Marek Olšák wrote: > From: Marek Olšák > > --- > src/gallium/state_trackers/dri/dri_context.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/state_trackers/dri/dri_context.c > b/src/gallium/state_trackers/dri/dri_context.c > ind

Re: [Mesa-dev] [PATCH 09/10] nir: Add a global code motion (GCM) pass

On Thu, Feb 5, 2015 at 9:33 PM, Jason Ekstrand wrote: > > On Feb 5, 2015 5:07 PM, "Connor Abbott" wrote: >> >> On Thu, Feb 5, 2015 at 5:29 PM, Jason Ekstrand >> wrote: >> > --- >> > src/glsl/Makefile.sources | 1 + >> > src/glsl/nir/nir.h | 2 + >> > src/glsl/nir/nir_opt_gcm.c | 49

Re: [Mesa-dev] [PATCH 15/17] glsl: Support double loop control (was: add double support)

On Thu, Feb 5, 2015 at 2:16 PM, Matt Turner wrote: > On Thu, Feb 5, 2015 at 3:05 AM, Topi Pohjolainen > wrote: >> From: Dave Airlie >> >> Signed-off-by: Dave Airlie >> --- >> src/glsl/loop_controls.cpp | 19 +++ >> 1 file changed, 15 insertions(+), 4 deletions(-) >> >> diff --g

Re: [Mesa-dev] [PATCH 3/4] i965: Attempt to blit for larger textures

On Wed, Jan 14, 2015 at 10:42:01AM -0800, Jason Ekstrand wrote: > On Tue, Jan 13, 2015 at 11:37 PM, Ben Widawsky > wrote: > > > The blit engine is limited to 32Kx32K transfer. In cases where we have to > > fall > > back to the blitter, and when trying to blit a slice of a 2d texture > > array, or

Re: [Mesa-dev] [PATCH 1/2] r300g: handle unsupported blend factor gracefully

On 06.02.2015 09:14, David Heidelberg wrote: > these days all (r600+,nv50+) modern HW support > PIPE_CAP_MAX_DUAL_SOURCE_RENDER_TARGETS Konsole output which r300 don't. > > Instead of adding another expensive checks to Nine, Why would that be expensive? It only needs to be done once per pipe_scre

Re: [Mesa-dev] [PATCH 14/17] glsl: Support double inouts (was: add double support)

On Thu, Feb 5, 2015 at 2:14 PM, Matt Turner wrote: > On Thu, Feb 5, 2015 at 3:05 AM, Topi Pohjolainen > wrote: >> From: Dave Airlie >> >> Signed-off-by: Dave Airlie >> --- >> src/glsl/ir_set_program_inouts.cpp | 24 +--- >> 1 file changed, 21 insertions(+), 3 deletions(-) >

Re: [Mesa-dev] [PATCH 10/10] i965/nir: Use Global Code Motion

On Feb 5, 2015 5:12 PM, "Connor Abbott" wrote: > > Maybe we should run this after DCE so that we don't do unnecessary > work by scheduling stuff that we then delete. Yeah, I thought about that. Also, this has interesting interactions with the select peephole. I think more analysis is needed bef

Re: [Mesa-dev] [PATCH 09/10] nir: Add a global code motion (GCM) pass

On Feb 5, 2015 5:07 PM, "Connor Abbott" wrote: > > On Thu, Feb 5, 2015 at 5:29 PM, Jason Ekstrand wrote: > > --- > > src/glsl/Makefile.sources | 1 + > > src/glsl/nir/nir.h | 2 + > > src/glsl/nir/nir_opt_gcm.c | 499 + > > 3 files changed

Re: [Mesa-dev] [PATCH 11/17] glsl/ast: Support double floats (was: add double support)

On Thu, Feb 5, 2015 at 2:06 PM, Matt Turner wrote: >> + case ast_double_constant: >> + printf("%lf ", primary_expression.double_constant); > > I don't think l is a modifier that you can use with %f. Neat. According to the man page, %f == double.

Re: [Mesa-dev] [PATCH 07/17] glsl/ir: Add builtin constant function support for doubles

On Thu, Feb 5, 2015 at 1:57 PM, Matt Turner wrote: > On Thu, Feb 5, 2015 at 3:05 AM, Topi Pohjolainen > wrote: >> From: Dave Airlie >> >> (was: add double support) > > I was going to suggest removing this from the commit subjects, but > just so you don't miss this one, remove it too. :) Yeah, t

Re: [Mesa-dev] [PATCH 04/17] glsl/ir: Add builtin function support for doubles (was: add double support)

On Thu, Feb 5, 2015 at 1:37 PM, Matt Turner wrote: >> @@ -499,6 +525,12 @@ static const char *const operator_strs[] = { >> "bitcast_u2f", >> "bitcast_f2u", >> "any", >> + "d2f", >> + "f2d", >> + "d2i", >> + "i2d", >> + "d2u", >> + "u2d", > > I see in the spec that you can c

Re: [Mesa-dev] [PATCH 03/17] glsl: Uniform linking support for doubles (was: add double support)

On Thu, Feb 5, 2015 at 1:27 PM, Matt Turner wrote: > On Thu, Feb 5, 2015 at 3:05 AM, Topi Pohjolainen > wrote: >> From: Dave Airlie >> >> Signed-off-by: Dave Airlie >> --- >> src/glsl/link_uniforms.cpp | 8 +++- >> 1 file changed, 7 insertions(+), 1 deletion(-) >> >> diff --git a/src/glsl/

Re: [Mesa-dev] [PATCH 08/10] nir: Add an instruction index

On the one hand, this really should use the metadata framework since it is metadata. On the other hand, this would get invalidated *all the time* so it doesn't seem so useful to have a dirty flag for it. Maybe add a comment explaining this? Other than that, Connor Abbott On Thu, Feb 5, 2015 at 5

Re: [Mesa-dev] [PATCH 10/10] i965/nir: Use Global Code Motion

Maybe we should run this after DCE so that we don't do unnecessary work by scheduling stuff that we then delete. On Thu, Feb 5, 2015 at 5:29 PM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH 09/10] nir: Add a global code motion (GCM) pass

On Thu, Feb 5, 2015 at 5:29 PM, Jason Ekstrand wrote: > --- > src/glsl/Makefile.sources | 1 + > src/glsl/nir/nir.h | 2 + > src/glsl/nir/nir_opt_gcm.c | 499 > + > 3 files changed, 502 insertions(+) > create mode 100644 src/glsl/nir/nir_

Re: [Mesa-dev] [PATCH 06/10] nir: Make nir_[cf_node/instr]_[prev/next] return null if at the end

On Thu, Feb 5, 2015 at 3:40 PM, Connor Abbott wrote: > This should go before the previous patch, or else that patch won't > work as intended, and also it confused me a little by using a behavior > (the returning NULL) before introducing it. > The previous patch is a bug. It uses a cast of a chu

Re: [Mesa-dev] [PATCH 2/2] r300g: small code cleanup

On 02/06/2015 12:57 AM, Matt Turner wrote: On Thu, Feb 5, 2015 at 2:56 PM, David Heidelberg wrote: Signed-off-by: David Heidelberg --- This is not a small clean up. This is removing a bunch of potentially informative comments. I checked sources & docs: * all unsure comments has been verifi

Re: [Mesa-dev] [PATCH 1/2] r300g: handle unsupported blend factor gracefully

these days all (r600+,nv50+) modern HW support PIPE_CAP_MAX_DUAL_SOURCE_RENDER_TARGETS Konsole output which r300 don't. Instead of adding another expensive checks to Nine, this is way to simply avoid it and do not cause assertion at no cost. David On 02/06/2015 12:59 AM, Matt Turner wrote:

Re: [Mesa-dev] [PATCH 1/2] r300g: handle unsupported blend factor gracefully

On Thu, Feb 5, 2015 at 2:56 PM, David Heidelberg wrote: > Rather not assert on known factors, just print warning and use ZERO. ... because this allows me to and I cannot fix the actual bug because of ...? ___ mesa-dev mailing list mesa-dev@lists.freed

Re: [Mesa-dev] [PATCH 2/2] r300g: small code cleanup

On Thu, Feb 5, 2015 at 2:56 PM, David Heidelberg wrote: > Signed-off-by: David Heidelberg > --- This is not a small clean up. This is removing a bunch of potentially informative comments. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://

Re: [Mesa-dev] [PATCH 07/10] nir/dominance: Also record the dominance depth

Reviewed-by: Connor Abbott On Thu, Feb 5, 2015 at 5:29 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir.h | 3 +++ > src/glsl/nir/nir_dominance.c | 9 - > 2 files changed, 11 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h > index 32c991

Re: [Mesa-dev] [PATCH 06/10] nir: Make nir_[cf_node/instr]_[prev/next] return null if at the end

This should go before the previous patch, or else that patch won't work as intended, and also it confused me a little by using a behavior (the returning NULL) before introducing it. On Thu, Feb 5, 2015 at 5:29 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir.h | 28 ++--

Re: [Mesa-dev] [PATCH 05/10] nir/from_ssa: Don't try to read an invalid instruction

Could use a comment here explaining that nir_instr_prev() may return NULL above if the only instruction in the block is a jump instruction. On Thu, Feb 5, 2015 at 5:29 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_from_ssa.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

Re: [Mesa-dev] [PATCH] st/mesa: Don't use PIPE_USAGE_STREAM for GL_PIXEL_UNPACK_BUFFER_ARB

Reviewed-by: Marek Olšák Marek On Thu, Feb 5, 2015 at 4:47 AM, Michel Dänzer wrote: > From: Michel Dänzer > > The latter currently implies CPU access, so we have to avoid getting > uncacheable memory. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=88658 > Cc: "10.3 10.4" > Signed-

Re: [Mesa-dev] [PATCH 04/10] nir/validate: Validate SSA defs the same way we do for registers

Other than one small comment below, 3 and 4 are Reviewed-by: Connor Abbott On Thu, Feb 5, 2015 at 5:28 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_validate.c | 87 > - > 1 file changed, 79 insertions(+), 8 deletions(-) > > diff --git a/src/gl

Re: [Mesa-dev] [PATCH 01/10] nir: use nir_foreach_ssa_def for indexing ssa defs

Reviewed-by: Connor Abbott On Thu, Feb 5, 2015 at 5:28 PM, Jason Ekstrand wrote: > This is both simpler and more correct. The old code didn't properly index > load_const instructions. > --- > src/glsl/nir/nir.c | 26 -- > 1 file changed, 4 insertions(+), 22 deletions(-)

Re: [Mesa-dev] [PATCH 02/10] nir: Properly clean up CF nodes when we remove them

While we're cleaning this up, we should go a little farther - we should also see if anything is using the SSA result of any of these instructions, and if so make it point to an undef_instr instead to avoid dangling pointers. This doesn't come up yet but it will when we start cleaning up constant co

[Mesa-dev] [Bug 65534] Piglit glx_glx-multithread-shader-compile randomly aborts or core dumps

https://bugs.freedesktop.org/show_bug.cgi?id=65534 Kaveh changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |huax...@intel.com |org

[Mesa-dev] [Bug 65534] Piglit glx_glx-multithread-shader-compile randomly aborts or core dumps

https://bugs.freedesktop.org/show_bug.cgi?id=65534 Jason Ekstrand changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #5 from Jason Ekst

[Mesa-dev] [PATCH 1/2] r300g: handle unsupported blend factor gracefully

Rather not assert on known factors, just print warning and use ZERO. Signed-off-by: David Heidelberg --- src/gallium/drivers/r300/r300_state_inlines.h | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/r300/r300_state_inlines.h b/src/gallium/driv

[Mesa-dev] [PATCH 2/2] r300g: small code cleanup

Signed-off-by: David Heidelberg --- src/gallium/drivers/r300/r300_reg.h| 22 ++ src/gallium/drivers/r300/r300_screen.c | 4 +--- src/gallium/drivers/r300/r300_state.c | 1 - 3 files changed, 3 insertions(+), 24 deletions(-) diff --git a/src/gallium/drivers/r300/r300_re

Re: [Mesa-dev] Low-level infrastructure for the shader cache

On Wed, Feb 04 2015, Carl Worth wrote: > First, when mapping the index file: > >/* FIXME: We map this shared, which is a start, but we need to think about > * how to make it multi-process safe. */ >cache->index = (unsigned char *) > mmap(NULL, size, PROT_READ | PROT_WRITE, MAP_SHA

[Mesa-dev] [PATCH 05/10] nir/from_ssa: Don't try to read an invalid instruction

--- src/glsl/nir/nir_from_ssa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/nir/nir_from_ssa.c b/src/glsl/nir/nir_from_ssa.c index 2e7add3..2ac114d 100644 --- a/src/glsl/nir/nir_from_ssa.c +++ b/src/glsl/nir/nir_from_ssa.c @@ -277,7 +277,7 @@ get_parallel_copy_at_e

[Mesa-dev] [PATCH 01/10] nir: use nir_foreach_ssa_def for indexing ssa defs

This is both simpler and more correct. The old code didn't properly index load_const instructions. --- src/glsl/nir/nir.c | 26 -- 1 file changed, 4 insertions(+), 22 deletions(-) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index 10e6ed3..9a88bd3 100644 --- a/src

[Mesa-dev] [PATCH 02/10] nir: Properly clean up CF nodes when we remove them

Previously, if you remved a CF node that still had instructions in it, none of the use/def information from those instructions would get cleaned up. Also, we weren't removing if statements from the if_uses of the corresponding register or SSA def. This commit fixes both of these problems --- src/

[Mesa-dev] [PATCH 00/10] nir: Implment global code motion

This patch series provides an implementation of the global code motion algorithm. The first 6 patches are fixups for pre-existing bugs in NIR, the next 2 are add features needed by GCM, and the last two add GCM and turn it on in i965. Shader-db numbers are as follows: total NIR instructions in s

[Mesa-dev] [PATCH 10/10] i965/nir: Use Global Code Motion

--- src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp index c3c268c..ba03291 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp +++ b/src/mesa/drivers/dri/i965/brw_f

[Mesa-dev] [PATCH 08/10] nir: Add an instruction index

This index, unlike the others, has to be manually updated by passes that want to use it. --- src/glsl/nir/nir.c | 20 src/glsl/nir/nir.h | 4 2 files changed, 24 insertions(+) diff --git a/src/glsl/nir/nir.c b/src/glsl/nir/nir.c index 8ea7bb5..6758a72 100644 --- a/src/g

[Mesa-dev] [PATCH 07/10] nir/dominance: Also record the dominance depth

--- src/glsl/nir/nir.h | 3 +++ src/glsl/nir/nir_dominance.c | 9 - 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index 32c991a..8e5e686 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h @@ -1136,6 +1136,9 @@ typedef

[Mesa-dev] [PATCH 04/10] nir/validate: Validate SSA defs the same way we do for registers

--- src/glsl/nir/nir_validate.c | 87 - 1 file changed, 79 insertions(+), 8 deletions(-) diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c index 13010ae..172406e 100644 --- a/src/glsl/nir/nir_validate.c +++ b/src/glsl/nir/nir_valida

[Mesa-dev] [PATCH 03/10] nir/validate: Validate if_uses on registers

--- src/glsl/nir/nir_validate.c | 62 - 1 file changed, 44 insertions(+), 18 deletions(-) diff --git a/src/glsl/nir/nir_validate.c b/src/glsl/nir/nir_validate.c index a34a017..13010ae 100644 --- a/src/glsl/nir/nir_validate.c +++ b/src/glsl/nir/nir_valid

[Mesa-dev] [PATCH 09/10] nir: Add a global code motion (GCM) pass

--- src/glsl/Makefile.sources | 1 + src/glsl/nir/nir.h | 2 + src/glsl/nir/nir_opt_gcm.c | 499 + 3 files changed, 502 insertions(+) create mode 100644 src/glsl/nir/nir_opt_gcm.c diff --git a/src/glsl/Makefile.sources b/src/glsl/Makefile.

[Mesa-dev] [PATCH 06/10] nir: Make nir_[cf_node/instr]_[prev/next] return null if at the end

--- src/glsl/nir/nir.h | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h index 4cb2e92..32c991a 100644 --- a/src/glsl/nir/nir.h +++ b/src/glsl/nir/nir.h @@ -416,15 +416,23 @@ typedef struct { } nir_instr; s

[Mesa-dev] [PATCH v3] r600g: Implement GL_ARB_draw_indirect for EG/CM

Requires Evergreen/Cayman and radeon kernel module 2.41.0 or newer. Signed-off-by: Glenn Kennard --- Changes since v2: * Fix failing arb_draw_indirect-vertexid piglit test cases. * Ensure start_instance, base_vertex, index_offset are reset when switching back to direct draws. * Juggled some hea

Re: [Mesa-dev] Removing out of date Mesa wiki pages

On Thu, Feb 5, 2015 at 2:47 PM, Benjamin Bellec wrote: > And what about removing the "RadeonProgram" page [1] ? > > From my point of view, this page depicts a wrong picture of the Radeon Mesa > driver. While I'm pretty sure most of the current and past games runs fine > today with r300g/r600g/rade

Re: [Mesa-dev] Removing out of date Mesa wiki pages

And what about removing the "RadeonProgram" page [1] ? >From my point of view, this page depicts a wrong picture of the Radeon Mesa driver. While I'm pretty sure most of the current and past games runs fine today with r300g/r600g/radeonsi, this is not what one could think at a first look when read

[Mesa-dev] [Bug 88275] [865G] Intel OpenGL rendering isn't starting

https://bugs.freedesktop.org/show_bug.cgi?id=88275 --- Comment #29 from Eugene --- I tried stable MESA 10.1.3 with kernels 3.13.0-45 and 3.18.5. It works without any problems. But installing latest MESA git immediately causes OpenGL not to start with following errors: libGL error: failed to crea

Re: [Mesa-dev] Split version of 07/13 glsl: add double support

On Thu, Feb 5, 2015 at 2:26 PM, Matt Turner wrote: > On Thu, Feb 5, 2015 at 3:05 AM, Topi Pohjolainen > wrote: >> I wanted to try if this could be split into smaller chunks to aid >> review. Only compile tested (each step compiles). > > Thanks a bunch for splitting these. It indeed makes it a ton

  1   2   >