[Mesa-dev] [Bug 88467] nir.c:140: error: ‘nir_src’ has no member named ‘ssa’

https://bugs.freedesktop.org/show_bug.cgi?id=88467 Vinson Lee changed: What|Removed |Added CC||airl...@freedesktop.org QA Contact|

Re: [Mesa-dev] [PATCH 03/11] i965: Fix negate with unsigned integers

On Tue, 2015-01-20 at 19:06 -0800, Anuj Phogat wrote: > On Mon, Jan 19, 2015 at 3:32 AM, Eduardo Lima Mitev wrote: > > From: Iago Toral Quiroga > > > > For code such as: > > > > uint tmp1 = uint(in0); > > uint tmp2 = -tmp1; > > float out0 = float(tmp2); > > > > We produce code like: > > mov(8)

[Mesa-dev] [PATCH v2] glsl: do not allow interface block to have name already taken

Fixes currently failing Piglit case interface-blocks-name-reused-globally.vert v2: combine var declaration with assignment (Ian) Signed-off-by: Tapani Pälli --- src/glsl/ast_to_hir.cpp | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cp

Re: [Mesa-dev] [PATCH] glsl: do not allow interface block to have name already taken

On 01/20/2015 08:29 PM, Ian Romanick wrote: On 01/19/2015 10:55 PM, Tapani Pälli wrote: Fixes currently failing Piglit case interface-blocks-name-reused-globally.vert Signed-off-by: Tapani Pälli --- src/glsl/ast_to_hir.cpp | 17 - 1 file changed, 16 insertions(+), 1 dele

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon

https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #25 from Michel Dänzer --- (In reply to Stéphane Travostino from comment #24) > yes I confirm I can reproduce the same FPS drops with glxgears, Intel and > vsync disabled. So, it seems like something is causing the performance of you

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

On Tue, Jan 20, 2015 at 4:02 PM, Matt Turner wrote: > On Tue, Jan 20, 2015 at 3:51 PM, Jason Ekstrand > wrote: > > Except typeless... We need some sort of assurance that the result of a > NIR > > comparison is always 0 or ~0. > > Help me understand how this is a different situation from what we

Re: [Mesa-dev] [PATCH 4/5] radeonsi: Re-enable LLVM IR dumps

On 16.01.2015 09:48, Tom Stellard wrote: > This was inadvertently disabled by > 761e36b4caab4e8e09a4c2b1409a825902fc7d2c. > --- > src/gallium/drivers/radeon/radeon_llvm_emit.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c

Re: [Mesa-dev] [PATCH v2] glsl: Improve precision of mod(x,y)

On 01/20/2015 08:09 AM, Iago Toral Quiroga wrote: > Currently, Mesa uses the lowering pass MOD_TO_FRACT to implement > mod(x,y) as y * fract(x/y). This implementation has a down side though: > it introduces precision errors due to the fract() operation. Even worse, > since the result of fract() is

Re: [Mesa-dev] [mesa-dev][PATCH] Remove UINT_AS_FLT, INT_AS_FLT, FLOAT_AS_FLT macros.No functional changes, only bug fixed.

On 01/20/2015 07:30 AM, marius.pre...@intel.com wrote: > From: Marius Predut > > On 32-bit, for floating point operations is used x86 FPU registers instead > SSE, > reason for when reinterprets an integer as a float result is unexpected > (modify floats when they are written to memory). > This

Re: [Mesa-dev] [PATCH 03/11] i965: Fix negate with unsigned integers

On Mon, Jan 19, 2015 at 3:32 AM, Eduardo Lima Mitev wrote: > From: Iago Toral Quiroga > > For code such as: > > uint tmp1 = uint(in0); > uint tmp2 = -tmp1; > float out0 = float(tmp2); > > We produce code like: > mov(8)g5<1>.xF-g9<4,4,1>.xUD > > which does not produce correct results. This

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon

https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #24 from Stéphane Travostino --- Thanks Michel, yes I confirm I can reproduce the same FPS drops with glxgears, Intel and vsync disabled. No FPS HUD for Intel, but I can see the FPS numbers change between ~5.6k and 1.6k every 10 sec

Re: [Mesa-dev] [PATCH 05/11] mesa: Validate internal format and format type first to provide accurate error code

On Mon, Jan 19, 2015 at 3:32 AM, Eduardo Lima Mitev wrote: > The specification states that glTexImage2D and glTexImage3D should return > GL_INVALID_VALUE if the internal format is invalid, and GL_INVALID_ENUM is > the format type is invalid. However, current error check only considers the > combin

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon

https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #23 from Michel Dänzer --- (In reply to Stéphane Travostino from comment #21) > I'm trying to reproduce the same thing with Intel, but it's V-synced and > can't manage to have it run more than 59 FPS. Have you tried 'vblank_mode=0 gl

Re: [Mesa-dev] [PATCH] radeonsi: Enable VGPR spilling for all shader types v3

On 20.01.2015 22:39, Marek Olšák wrote: > The problem with CPDMA (DMA_DATA and WRITE_DATA) is that the ordering > of flushes must be correct. First, partial flushes must be done, so > that the shaders are idle. That's only necessary when reusing a single BO for the shader code, not when allocating

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

https://bugs.freedesktop.org/show_bug.cgi?id=88536 Alberto Salvia Novella changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #18 from A

Re: [Mesa-dev] [mesa-dev][PATCH] Remove UINT_AS_FLT, INT_AS_FLT, FLOAT_AS_FLT macros.No functional changes, only bug fixed.

On Tue, Jan 20, 2015 at 7:30 AM, wrote: > From: Marius Predut > > On 32-bit, for floating point operations is used x86 FPU registers instead > SSE, > reason for when reinterprets an integer as a float result is unexpected > (modify floats when they are written to memory). > This fixes https://b

[Mesa-dev] [mesa-dev][PATCH] Remove UINT_AS_FLT, INT_AS_FLT, FLOAT_AS_FLT macros.No functional changes, only bug fixed.

From: Marius Predut On 32-bit, for floating point operations is used x86 FPU registers instead SSE, reason for when reinterprets an integer as a float result is unexpected (modify floats when they are written to memory). This fixes https://bugs.freedesktop.org/show_bug.cgi?id=82668 Reviewed-by:

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #17 from Alberto Salvia Novella --- Wait, comment 2 says further steps are needed... I'm testing now. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #16 from Alberto Salvia Novella --- The Synaptic package manager says there isn't any fglrx package installed, and following instructions at

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #15 from Timothy Arceri --- The open and closed drivers currently don't play nice together. Hopefully one day that will change. But to me it looks like you haven't fully removed fglrx and this is causing you problems. -- You are rec

Re: [Mesa-dev] [PATCH] nir: Add a nir_foreach_phi_src helper macro

On Tue, Jan 20, 2015 at 4:37 PM, Connor Abbott wrote: > Assuming you grepped for uses of foreach_list* with nir_phi_src and > made sure there were no more, > I did > Reviewed-by: Connor Abbott > thanks --Jason > > On Tue, Jan 20, 2015 at 7:34 PM, Jason Ekstrand > wrote: > > --- > > src/g

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #14 from Alberto Salvia Novella --- I can confirm upgrading from the PPA didn't solve the problem :) Graphics hanged again just after finishing the latest comment. -- You are receiving this mail because: You are the QA Contact for

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #13 from Alberto Salvia Novella --- So why is this happening also with the proprietary driver? And about upgrading using the PPA, I have just done it. If in three weeks the problem doesn't reproduce, I will report it as gone in git v

Re: [Mesa-dev] [PATCH] nir: Add a nir_foreach_phi_src helper macro

Assuming you grepped for uses of foreach_list* with nir_phi_src and made sure there were no more, Reviewed-by: Connor Abbott On Tue, Jan 20, 2015 at 7:34 PM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir.c | 4 ++-- > src/glsl/nir/nir.h | 3 +++ > src/g

[Mesa-dev] [PATCH] nir: Add a nir_foreach_phi_src helper macro

--- src/glsl/nir/nir.c | 4 ++-- src/glsl/nir/nir.h | 3 +++ src/glsl/nir/nir_from_ssa.c| 4 ++-- src/glsl/nir/nir_live_variables.c | 2 +- src/glsl/nir/nir_opt_cse.c | 4 ++-- src/glsl/nir/nir_opt_peephole_select.c | 2 +- src/g

Re: [Mesa-dev] [PATCH 02/16] glsl: Add a foreach_in_list_reverse_safe macro.

On Tue, Jan 20, 2015 at 1:15 PM, Matt Turner wrote: > On Tue, Jan 20, 2015 at 6:16 AM, Connor Abbott wrote: >> Shouldn't the subject say "exec_list: Add a >> foreach_in_list_reverse_safe macro."? > > Meh? Shortlog on this file shows glsl2, exec_list, glsl, glsl/list. Well, given that this stuff

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

On Tue, Jan 20, 2015 at 3:51 PM, Jason Ekstrand wrote: > Except typeless... We need some sort of assurance that the result of a NIR > comparison is always 0 or ~0. Help me understand how this is a different situation from what we have today? Let's take for instance a vec2 == vec2 comparison. On

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

On Tue, Jan 20, 2015 at 3:31 PM, Matt Turner wrote: > On Tue, Jan 20, 2015 at 3:17 PM, Jason Ekstrand > wrote: > > > > > > On Tue, Jan 20, 2015 at 3:09 PM, Matt Turner wrote: > >> > >> On Tue, Jan 20, 2015 at 2:58 PM, Jason Ekstrand > >> wrote: > >> > On Mon, Jan 19, 2015 at 3:31 PM, Matt Turn

[Mesa-dev] [PATCH 09/16] i965/fs: Apply conditional mod specially to split MAD/LRP.

Otherwise we'll apply the conditional mod to only one of SIMD8 instructions and trigger an assertion. NoDDClr/NoDDChk have the same problem but we never apply those to these instructions, so I'm leaving them for a later time. --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 24 +++

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

On Tue, Jan 20, 2015 at 3:17 PM, Jason Ekstrand wrote: > > > On Tue, Jan 20, 2015 at 3:09 PM, Matt Turner wrote: >> >> On Tue, Jan 20, 2015 at 2:58 PM, Jason Ekstrand >> wrote: >> > On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner wrote: >> >> >> >> For some reason, we occasionally write the flag r

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

On Tue, Jan 20, 2015 at 3:09 PM, Matt Turner wrote: > On Tue, Jan 20, 2015 at 2:58 PM, Jason Ekstrand > wrote: > > On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner wrote: > >> > >> For some reason, we occasionally write the flag register with a MOV.NZ > >> instruction: > >> > >>add(8)

Re: [Mesa-dev] [PATCH 16/16] i965: Convert CMP.GE -(abs)reg 0 -> CMP.Z reg 0.

On Mon, Jan 19, 2015 at 8:08 PM, Ian Romanick wrote: > On 01/19/2015 03:31 PM, Matt Turner wrote: >> total instructions in shared programs: 5952059 -> 5951603 (-0.01%) >> instructions in affected programs: 138812 -> 138356 (-0.33%) >> GAINED:1 >> LOST:

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

On Tue, Jan 20, 2015 at 2:58 PM, Jason Ekstrand wrote: > On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner wrote: >> >> For some reason, we occasionally write the flag register with a MOV.NZ >> instruction: >> >>add(8) g25<1>F -g6<0,1,0>F g15<8,8,1>F >>cmp.l.f0(8) g26<

Re: [Mesa-dev] [PATCH 04/16] i965/cfg: Add a foreach_block_reverse macro.

Patches 1, 3, and 4 are also Reviewed-by: Jason Ekstrand On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_cfg.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_cfg.h > b/src/mesa/drivers/dri/i965/brw_cfg.h > ind

Re: [Mesa-dev] [PATCH 11/16] i965/fs: Add pass to propagate conditional modifiers.

On Tue, Jan 20, 2015 at 2:56 PM, Jason Ekstrand wrote: > On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner wrote: >> + if (scan_inst->dst.file == GRF && >> + scan_inst->dst.reg == inst->src[0].reg && >> + scan_inst->dst.reg_offset == inst->src[0].reg_offset && >> +

Re: [Mesa-dev] [PATCH 12/16] i965/fs: Add unit tests for cmod propagation pass.

I had comments on 11 and 15, but 12-14 are Reviewed-by: Jason Ekstrand On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/Makefile.am | 7 + > .../drivers/dri/i965/test_fs_cmod_propagation.cpp | 271 > + > 2 files changed,

Re: [Mesa-dev] [PATCH 15/16] i965/fs: Add support for removing MOV.NZ instructions.

On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner wrote: > For some reason, we occasionally write the flag register with a MOV.NZ > instruction: > >add(8) g25<1>F -g6<0,1,0>F g15<8,8,1>F >cmp.l.f0(8) g26<1>D g25<8,8,1>F 0F >mov.nz.f0(8)null

Re: [Mesa-dev] [PATCH 11/16] i965/fs: Add pass to propagate conditional modifiers.

On Mon, Jan 19, 2015 at 3:31 PM, Matt Turner wrote: > total instructions in shared programs: 5974160 -> 5959463 (-0.25%) > instructions in affected programs: 1743737 -> 1729040 (-0.84%) > GAINED:0 > LOST: 12 > --- > src/mesa/dr

[Mesa-dev] [PATCH] egl/dri2: implement platform_null.

Try the render node first and use it if available. Otherwise fall back to normal nodes. Signed-off-by: Haixia Shi --- src/egl/drivers/dri2/Makefile.am | 5 + src/egl/drivers/dri2/egl_dri2.c | 11 ++- src/egl/drivers/dri2/egl_dri2.h | 3 + src/egl/drivers/dri2/platform_null.c |

Re: [Mesa-dev] [PATCH] egl/dri2: implement platform_null.

On Tue, Jan 20, 2015 at 2:25 PM, Haixia Shi wrote: > diff --git a/src/egl/drivers/dri2/platform_null.c > b/src/egl/drivers/dri2/platform_null.c > new file mode 100644 > index 000..9c59809 > --- /dev/null > +++ b/src/egl/drivers/dri2/platform_null.c > @@ -0,0 +1,156 @@ > +/* > + * Copyright (c

[Mesa-dev] [PATCH] egl/dri2: implement platform_null.

Try the render node first and use it if available. Otherwise fall back to normal nodes. Signed-off-by: Haixia Shi --- src/egl/drivers/dri2/Makefile.am | 5 ++ src/egl/drivers/dri2/egl_dri2.c | 11 ++- src/egl/drivers/dri2/egl_dri2.h | 3 + src/egl/drivers/dri2/platform_null.c

Re: [Mesa-dev] Implement GLX_EXT_buffer_age for DRI2

On 19 January 2015 at 21:00, Chris Wilson wrote: > In order to suport GLX_EXT_buffer_age in DRI2, we need to pass back the > last swap buffer count that the back buffer was defined for. For > simplicity, we can reuse an existing field in the DRI2GetBuffers reply > that is not used by current drive

Re: [Mesa-dev] [PATCH 0/5] NIR opcodes and constant folding

Connor, You mentioned commit access. I'll try and poke someone, but if you resend with changes, I can get it pushed. --Jason On Tue, Jan 20, 2015 at 11:45 AM, Jason Ekstrand wrote: > There's still some cleanups needed for 2/5. The rest is > Reviewed-by: Jason Ekstrand > > > On Fri, Jan 16, 20

Re: [Mesa-dev] [PATCH 10/16] i965/fs: Eliminate null-dst instructions without side-effects.

> That makes sense. However, in the vec4 backend, we do emit scratch reads > and writes prior to optimization - in move_grf_array_access_to_scratch(). > I've been meaning to port that over to the scalar backend. At which > point, SHADER_OPCODE_GEN4_SCRATCH_WRITE would be a problem. Sort of off-t

Re: [Mesa-dev] [dri2proto] Declare DRI2ParamXHasBufferAge

On 01/19/2015 03:00 AM, Chris Wilson wrote: > In order for X/DDX to reuse a driver specific field of the DRI2GetBuffers > reply, we need to declare the change in semantics. To indicate that the > flags field now continues the last swap buffers count instead, we > introduce the has-buffer-age parame

Re: [Mesa-dev] [PATCH 10/16] i965/fs: Eliminate null-dst instructions without side-effects.

On Tuesday, January 20, 2015 10:13:09 AM Matt Turner wrote: > On Tue, Jan 20, 2015 at 12:53 AM, Kenneth Graunke > wrote: > > On Monday, January 19, 2015 03:31:09 PM Matt Turner wrote: > >> --- > >> src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp | 11 +++ > >> 1 file changed, 11

Re: [Mesa-dev] [xorg 1/3] dri2: Allow GetBuffers to match any format

On 01/19/2015 03:00 AM, Chris Wilson wrote: > Since the introduction of DRI2GetBuffersWithFormat, the old > DRI2GetBuffers interface would always recreate all buffers all the time > as it was no longer agnostic to the format value being set by the DDXes. > This causes an issue with clients intermix

Re: [Mesa-dev] [mesa 9/9] glx/dri2: Implement getBufferAge

On 01/20/2015 12:35 PM, Ian Romanick wrote: > On 01/19/2015 03:00 AM, Chris Wilson wrote: >> + DRI2Buffer *buffers; >> + >> + for (i = 0; i < priv->bufferCount; i++) >> + attachments[i] = priv->buffers[i].attachment; >> + >> + buffers = DRI2GetBuffers(priv->base.psc-

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon

https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #22 from Stéphane Travostino --- (In reply to Eero Tamminen from comment #20) > Are you still getting INTEL_DEBUG=perf output from them? > > -> if you're still getting recompile messages, re-check you have latest Mesa > > -> if ther

Re: [Mesa-dev] [mesa 9/9] glx/dri2: Implement getBufferAge

On 01/19/2015 03:00 AM, Chris Wilson wrote: > Within the DRI2GetBuffers return packet there is a 4-byte field that is > currently unused by any driver, i.e. flags. With the co-operation of a > suitably modified X server, we can pass the last SBC on which the buffer > was defined (i.e. the last Swap

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon

https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #21 from Stéphane Travostino --- (In reply to Hohahiu from comment #19) > Maybe a wild guess, but what are the temperatures of the GPUs in your > laptop? Is this an overheating issue? No, but GOOD NEWS i've managed to reproduce the s

Re: [Mesa-dev] [PATCH 4/4] i965: Implemente a tiled fast-path for glReadPixels and glGetTexImage

On Tue, Jan 13, 2015 at 10:44 AM, Chad Versace wrote: > On 01/12/2015 10:22 AM, Jason Ekstrand wrote: > > From: Sisinty Sasmita Patra > > > > Added intel_readpixels_tiled_mempcpy and > intel_gettexsubimage_tiled_mempcpy > > functions. These are the fast paths for glReadPixels and glGetTexImage.

Re: [Mesa-dev] [mesa 8/9] glx/dri2: Move the wait after SwapBuffers into the next GetBuffers

On 01/19/2015 03:00 AM, Chris Wilson wrote: > As the SBC from the reply from SwapBuffers is not used immediately and > can be easily determined by counting the new of SwapBuffers requests > made by the client, we can defer the synchronisation point to the > pending GetBuffers round trip. (We force

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #12 from Timothy Arceri --- (In reply to Alberto Salvia Novella from comment #11) > Does fglrx depend on Mesa? No > How can I figure out if this is a bug in Mesa? Make sure you have completely removed fglrx (there are many guides o

Re: [Mesa-dev] [PATCH 0/5] NIR opcodes and constant folding

There's still some cleanups needed for 2/5. The rest is Reviewed-by: Jason Ekstrand On Fri, Jan 16, 2015 at 1:53 PM, Connor Abbott wrote: > Oh, and I forgot... the series is also available at > > https://github.com/cwabbott0/mesa nir-opcodes-cleanup > > On Fri, Jan 16, 2015 at 4:46 PM, Connor

Re: [Mesa-dev] [PATCH 3/5] nir: add new constant folding infrastructure

On Mon, Jan 19, 2015 at 5:01 PM, Connor Abbott wrote: > On Mon, Jan 19, 2015 at 4:04 PM, Jason Ekstrand > wrote: > > I've got some specific comments below, but I want to make some more > general > > comments here. I like this in principle: having all the opcodes > > self-documenting is wonderfu

Re: [Mesa-dev] [mesa 7/9] glx/dri2: Add DRI2GetParam()

On 01/19/2015 03:00 AM, Chris Wilson wrote: > Available since the inclusion of dri2proto 1.4 is a DRI2 request to > query and set certain parameters about the X/DDX configuration. This > implements the getter request. > > Signed-off-by: Chris Wilson This patch is Reviewed-by: Ian Romanick > -

Re: [Mesa-dev] [PATCH 11/11] mesa: fix error value in GetFramebufferAttachmentParameteriv for OpenGL ES 3.0

On 01/20/2015 10:57 AM, Anuj Phogat wrote: > On Mon, Jan 19, 2015 at 7:23 PM, Ian Romanick wrote: >> On 01/19/2015 03:32 AM, Eduardo Lima Mitev wrote: >>> From: Samuel Iglesias Gonsalvez >>> >>> Section 6.1.13 "Framebuffer Object Queries" of OpenGL ES 3.0 spec: >>> >>> "If the default framebuffe

Re: [Mesa-dev] [PATCH] glsl: do not allow interface block to have name already taken

On 01/20/2015 10:42 AM, Chris Forbes wrote: > Ian, > > That's what the -2 variation added by that commit does. Of course. :) Not sure how I overlooked that. > - Chris > > On Wed, Jan 21, 2015 at 7:29 AM, Ian Romanick wrote: >> On 01/19/2015 10:55 PM, Tapani Pälli wrote: >>> Fixes currently fa

Re: [Mesa-dev] [PATCH 11/11] mesa: fix error value in GetFramebufferAttachmentParameteriv for OpenGL ES 3.0

On Mon, Jan 19, 2015 at 7:23 PM, Ian Romanick wrote: > On 01/19/2015 03:32 AM, Eduardo Lima Mitev wrote: >> From: Samuel Iglesias Gonsalvez >> >> Section 6.1.13 "Framebuffer Object Queries" of OpenGL ES 3.0 spec: >> >> "If the default framebuffer is bound to target, then attachment must be >>

Re: [Mesa-dev] [PATCH] glsl: do not allow interface block to have name already taken

Ian, That's what the -2 variation added by that commit does. - Chris On Wed, Jan 21, 2015 at 7:29 AM, Ian Romanick wrote: > On 01/19/2015 10:55 PM, Tapani Pälli wrote: >> Fixes currently failing Piglit case >>interface-blocks-name-reused-globally.vert >> >> Signed-off-by: Tapani Pälli >> -

Re: [Mesa-dev] [PATCH] glsl: do not allow interface block to have name already taken

On 01/19/2015 10:55 PM, Tapani Pälli wrote: > Fixes currently failing Piglit case >interface-blocks-name-reused-globally.vert > > Signed-off-by: Tapani Pälli > --- > src/glsl/ast_to_hir.cpp | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/a

Re: [Mesa-dev] [PATCH 02/16] glsl: Add a foreach_in_list_reverse_safe macro.

On Tue, Jan 20, 2015 at 6:16 AM, Connor Abbott wrote: > Shouldn't the subject say "exec_list: Add a > foreach_in_list_reverse_safe macro."? Meh? Shortlog on this file shows glsl2, exec_list, glsl, glsl/list. ___ mesa-dev mailing list mesa-dev@lists.free

Re: [Mesa-dev] [PATCH 09/11 v2] mesa: Allow querying for GL_PRIMITIVE_RESTART_FIXED_INDEX under GLES 3

On 01/20/2015 04:58 AM, Eduardo Lima Mitev wrote: > GLES 3.0.0 spec introduces context state PRIMITIVE_RESTART_FIXED_INDEX > (2.8.1 Transferring Array Elements, page 26) which is not currently > possible to query using glGet*() funcs. > > Fixes 4 dEQP tests: > * > dEQP-GLES3.functional.state_quer

Re: [Mesa-dev] [PATCH 10/16] i965/fs: Eliminate null-dst instructions without side-effects.

On Tue, Jan 20, 2015 at 12:53 AM, Kenneth Graunke wrote: > On Monday, January 19, 2015 03:31:09 PM Matt Turner wrote: >> --- >> src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp | 11 +++ >> 1 file changed, 11 insertions(+) >> >> diff --git a/src/mesa/drivers/dri/i965/brw_fs_dead_c

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

https://bugs.freedesktop.org/show_bug.cgi?id=88536 --- Comment #11 from Alberto Salvia Novella --- Does fglrx depend on Mesa? How can I figure out if this is a bug in Mesa? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug.

Re: [Mesa-dev] [PATCH 09/16] i965/fs: Apply conditional mod specially to split MAD/LRP.

On Tue, Jan 20, 2015 at 12:32 AM, Kenneth Graunke wrote: > On Monday, January 19, 2015 03:31:08 PM Matt Turner wrote: >> Otherwise we'll apply the conditional mod to only one of SIMD8 >> instructions and trigger an assertion. >> >> NoDDClr/NoDDChk have the same problem but we never apply those to

[Mesa-dev] [Bug 88536] AMD graphics hardware hangs with an homogeneous coloured screen or blank screen, and with chirp coming from the graphics card

https://bugs.freedesktop.org/show_bug.cgi?id=88536 Alberto Salvia Novella changed: What|Removed |Added Component|Driver/AMDgpu |EGL Assignee|xorg-dri

Re: [Mesa-dev] [PATCH] nv50, nvc0: Report correct caps for pixel center integer

I've done some tests, after being confirmed that the 0.5 subtraction done in gallium nine is correct, I've tried to set raster half_pixel_center to 1 , and this way , with the 0.5 subtraction is fine like it is on radeon With half_pixel_center set to 0 instead the default behavior on shaders seems

Re: [Mesa-dev] [xf86-video-ati] dri2: Enable BufferAge support

On Mon, Jan 19, 2015 at 6:00 AM, Chris Wilson wrote: > For BufferAge support, we just have to guarrantee that we were not using > the DRI2Buffer->flags field for anything else (i.e. it is always 0) and > then to make sure that we exchange the flags field after buffer > exchanges. radeon does not s

[Mesa-dev] [Bug 67676] Transparent windows no longer work

https://bugs.freedesktop.org/show_bug.cgi?id=67676 Daniel Stone changed: What|Removed |Added CC||e...@anholt.net --- Comment #9 from Danie

[Mesa-dev] [Bug 82668] Can't set int attributes to certain values on 32-bit

https://bugs.freedesktop.org/show_bug.cgi?id=82668 marius predut changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |marius.pre...@intel.com

[Mesa-dev] [PATCH v2] glsl: Improve precision of mod(x,y)

Currently, Mesa uses the lowering pass MOD_TO_FRACT to implement mod(x,y) as y * fract(x/y). This implementation has a down side though: it introduces precision errors due to the fract() operation. Even worse, since the result of fract() is multiplied by y, the larger y gets the larger the precisio

[Mesa-dev] [PATCH v2] glsl: GLSL ES identifiers cannot exceed 1024 characters

v2 (Ian Romanick) - Move the check to the lexer before rallocing a copy of the large string. Fixes the following 2 dEQP tests: dEQP-GLES3.functional.shaders.keywords.invalid_identifiers.max_length_vertex dEQP-GLES3.functional.shaders.keywords.invalid_identifiers.max_length_fragment --- src/glsl/g

[Mesa-dev] [Bug 88275] [865G] Intel OpenGL rendering isn't starting

https://bugs.freedesktop.org/show_bug.cgi?id=88275 Eugene changed: What|Removed |Added Summary|[865G] Intel OpenGL |[865G] Intel OpenGL |renderin

Re: [Mesa-dev] [PATCH 02/16] glsl: Add a foreach_in_list_reverse_safe macro.

Shouldn't the subject say "exec_list: Add a foreach_in_list_reverse_safe macro."? On Mon, Jan 19, 2015 at 6:31 PM, Matt Turner wrote: > --- > src/glsl/list.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/glsl/list.h b/src/glsl/list.h > index 330c17e..85368a4 100644 > --- a/s

Re: [Mesa-dev] [PATCH] radeonsi: Enable VGPR spilling for all shader types v3

The problem with CPDMA (DMA_DATA and WRITE_DATA) is that the ordering of flushes must be correct. First, partial flushes must be done, so that the shaders are idle. Then you can use CP DMA to update the binary. After that, ICACHE should be invalidated. This is similar to how si_clear_buffer and si_

[Mesa-dev] [PATCH 09/11 v2] mesa: Allow querying for GL_PRIMITIVE_RESTART_FIXED_INDEX under GLES 3

GLES 3.0.0 spec introduces context state PRIMITIVE_RESTART_FIXED_INDEX (2.8.1 Transferring Array Elements, page 26) which is not currently possible to query using glGet*() funcs. Fixes 4 dEQP tests: * dEQP-GLES3.functional.state_query.boolean.primitive_restart_fixed_index_getboolean * dEQP-GLES3

Re: [Mesa-dev] [PATCH 07/11] glsl: error out on empty declarations

On Mon, 2015-01-19 at 19:03 -0800, Ian Romanick wrote: > On 01/19/2015 04:52 AM, Erik Faye-Lund wrote: > > On Mon, Jan 19, 2015 at 12:32 PM, Eduardo Lima Mitev > > wrote: > >> From: Iago Toral Quiroga > >> > >> So far we have only been emitting a warning. > >> > >> Fixes the following 2 dEQP tes

Re: [Mesa-dev] [PATCH 10/11] glsl: Improve precision of mod(x,y)

On Mon, 2015-01-19 at 19:10 -0800, Ian Romanick wrote: > On 01/19/2015 03:32 AM, Eduardo Lima Mitev wrote: > > From: Iago Toral Quiroga > > > > Currently, Mesa uses the lowering pass MOD_TO_FRACT to implement > > mod(x,y) as y * fract(x/y). This implementation has a down side though: > > it intro

Re: [Mesa-dev] [PATCH 01/11] mesa: Returns a GL_INVALID_VALUE error on several glGet* APIs when max length is negative

Thank you Erik and Ian for taking a look to the patch. On 01/20/2015 03:52 AM, Ian Romanick wrote: > On 01/19/2015 03:32 AM, Eduardo Lima Mitev wrote: >> The manual page for glGetAttachedShaders, glGetShaderSource, >> glGetActiveUniform and >> glGetActiveUniform state that a GL_INVALID_VALUE is r

Re: [Mesa-dev] [PATCH 08/11] glsl: GLSL ES identifiers cannot exceed 1024 characters

On Mon, 2015-01-19 at 19:25 -0800, Ian Romanick wrote: > On 01/19/2015 04:41 AM, Erik Faye-Lund wrote: > > On Mon, Jan 19, 2015 at 12:32 PM, Eduardo Lima Mitev > > wrote: > >> From: Iago Toral Quiroga > >> > >> Fixes the following 2 dEQP tests: > >> dEQP-GLES3.functional.shaders.keywords.invalid

Re: [Mesa-dev] [PATCH 02/11] glsl: Add link time checks for GLSL precision qualifiers

On Mon, 2015-01-19 at 19:39 -0800, Ian Romanick wrote: > On 01/19/2015 03:32 AM, Eduardo Lima Mitev wrote: > > From: Iago Toral Quiroga > > > > Currently, we only consider precision qualifiers at compile-time. This patch > > adds precision information to ir_variable so we can also do link time >

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon

https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #20 from Eero Tamminen --- Are you still getting INTEL_DEBUG=perf output from them? -> if you're still getting recompile messages, re-check you have latest Mesa -> if there are no perf warnings, check that: * your dmesg doesn't have

[Mesa-dev] [Bug 88618] opengles2: fix building without X11

https://bugs.freedesktop.org/show_bug.cgi?id=88618 Bug ID: 88618 Summary: opengles2: fix building without X11 Product: Mesa Version: git Hardware: Other OS: All Status: NEW Severity: normal Prior

Re: [Mesa-dev] [PATCH 10/16] i965/fs: Eliminate null-dst instructions without side-effects.

On Monday, January 19, 2015 03:31:09 PM Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_dead_code_eliminate.cpp > b/src/mesa/drivers/dri/i965/brw_fs_dead_cod

Re: [Mesa-dev] [PATCH 01/11] mesa: Returns a GL_INVALID_VALUE error on several glGet* APIs when max length is negative

On Tue, Jan 20, 2015 at 3:54 AM, Ian Romanick wrote: > On 01/19/2015 04:35 AM, Erik Faye-Lund wrote: >> On Mon, Jan 19, 2015 at 1:31 PM, Erik Faye-Lund wrote: >>> On Mon, Jan 19, 2015 at 12:32 PM, Eduardo Lima Mitev >>> wrote: The manual page for glGetAttachedShaders, glGetShaderSource, >

Re: [Mesa-dev] [PATCH 09/16] i965/fs: Apply conditional mod specially to split MAD/LRP.

On Monday, January 19, 2015 03:31:08 PM Matt Turner wrote: > Otherwise we'll apply the conditional mod to only one of SIMD8 > instructions and trigger an assertion. > > NoDDClr/NoDDChk have the same problem but we never apply those to these > instructions, so I'm leaving them for a later time. > -

Re: [Mesa-dev] [PATCH 08/16] i965/fs: Add a pass to fixup 3-src instructions that have a null dest.

On Monday, January 19, 2015 03:31:07 PM Matt Turner wrote: > 3-src instructions can only have GRF/MRF destinations. It's really > difficult to deal with that restriction in dead code elimination (that > wants to give instructions null destinations to show that their result > isn't used) while allow

Re: [Mesa-dev] [PATCH 07/16] i965: Add is_3src() to backend_instruction.

On Monday, January 19, 2015 03:31:06 PM Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_shader.cpp| 10 ++ > src/mesa/drivers/dri/i965/brw_shader.h | 1 + > src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp | 6 +- > 3 files changed, 12

Re: [Mesa-dev] [PATCH 06/16] i965: Add a brw_invert_cmod() function.

On Monday, January 19, 2015 03:31:05 PM Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_eu.c | 22 ++ > src/mesa/drivers/dri/i965/brw_eu.h | 1 + > 2 files changed, 23 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_eu.c > b/src/mesa/drivers/dri/i965/br

Re: [Mesa-dev] [PATCH 05/16] i965: Add backend_instruction::can_do_cmod().

On Monday, January 19, 2015 03:31:04 PM Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_shader.cpp | 45 > > src/mesa/drivers/dri/i965/brw_shader.h | 1 + > 2 files changed, 46 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp >