On 27.12.2014 03:45, Eric Anholt wrote:
> The callers all follow it with a flush of the context, and the flush of
> the context gives us more information about how things are being flushed.
> ---
> src/gallium/drivers/vc4/vc4_resource.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(
On 01/06/2015 07:39 PM, Chad Versace wrote:
On 11/25/2014 11:09 PM, Tapani Pälli wrote:
Patch enables ES2 extension that utilizes existing ES3 functionality.
Changes make all the subtests to run and pass in WebGL conformance
test 'webgl-draw-buffers' when running Chrome on OpenGL ES.
v2: remov
On 07.01.2015 10:44, Matt Turner wrote:
> On Tue, Jan 6, 2015 at 5:11 PM, Jason Ekstrand wrote:
>> On Tue, Jan 6, 2015 at 5:03 PM, Matt Turner wrote:
>>> On Tue, Jan 6, 2015 at 4:34 PM, Jason Ekstrand
>>> wrote:
This way the basics of the FNV-a1 hash can be reused to easily create
othe
On Tue, Jan 6, 2015 at 5:11 PM, Jason Ekstrand wrote:
> On Tue, Jan 6, 2015 at 5:03 PM, Matt Turner wrote:
>> On Tue, Jan 6, 2015 at 4:34 PM, Jason Ekstrand
>> wrote:
>> > This way the basics of the FNV-a1 hash can be reused to easily create
>> > other
>> > hashing functions.
>> >
>> > Cc: Eric
On Tuesday, January 06, 2015 04:49:04 PM Jason Ekstrand wrote:
> On Tue, Jan 6, 2015 at 4:35 PM, Dylan Baker wrote:
>
> > I have a couple of comments, but they're just suggestions.
> > On Monday, December 15, 2014 10:12:54 PM Jason Ekstrand wrote:
> > > This commit builds on the nir_search.h infa
start_ip and end_ip are inclusive.
Increases instruction counts in 64 shaders in shader-db, likely
indicative of them previously being misoptimized.
---
src/mesa/drivers/dri/i965/brw_cfg.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_cfg.cpp
On Tue, Jan 6, 2015 at 5:03 PM, Matt Turner wrote:
> On Tue, Jan 6, 2015 at 4:34 PM, Jason Ekstrand
> wrote:
> > This way the basics of the FNV-a1 hash can be reused to easily create
> other
> > hashing functions.
> >
> > Cc: Eric Anholt
>
> This didn't actually Cc him.
>
My e-mail says it did
On 07.01.2015 06:33, Tom Stellard wrote:
> On Wed, Dec 24, 2014 at 12:48:31PM +0900, Michel Dänzer wrote:
>> On 24.12.2014 02:49, Tom Stellard wrote:
>>> Rather than building a new one every compile. This should reduce some
>>> of the overhead of compiling shaders.
>>
>> Thanks, though unfortunate
On Sun, Jan 4, 2015 at 8:29 PM, Connor Abbott wrote:
> I'd also like to rename or at least note that this is a scalar-only thing
> for now... otherwise,
>
Sure, I'll add a note to the comment at the top of the file.
>
> Reviewed-by: Connor Abbott
>
> On Tue, Dec 16, 2014 at 1:11 AM, Jason Eks
On Sun, Jan 4, 2015 at 7:52 PM, Connor Abbott wrote:
>
>
> On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand
> wrote:
>
>> ---
>> src/glsl/Makefile.sources | 1 +
>> src/glsl/nir/nir.h | 2 +
>> src/glsl/nir/nir_lower_locals_to_regs.c | 313
>> ++
On Tue, Jan 6, 2015 at 4:34 PM, Jason Ekstrand wrote:
> This way the basics of the FNV-a1 hash can be reused to easily create other
> hashing functions.
>
> Cc: Eric Anholt
This didn't actually Cc him.
> ---
> src/util/hash_table.c | 17 -
> src/util/hash_table.h | 19 +
On Tue, Jan 6, 2015 at 4:34 PM, Jason Ekstrand wrote:
>
The subject is incomplete, so maybe
> nir/validate: Only build in debug mode.
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailm
Not mentioned in the original commit message, but this also switches the
hashing functions to use a loop rather than recursion.
--Jason
On Tue, Jan 6, 2015 at 4:34 PM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir_lower_locals_to_regs.c | 65
> src/glsl/nir/nir_lower_vari
On Sun, Jan 4, 2015 at 1:01 PM, Connor Abbott wrote:
> Ok, I'm going to try reviewing this again. I'm pasting the latest version
> of the file from review/nir-v1 and replying to that so that I won't get
> confused between all the various changes and reorganizing things. Here we
> go!
>
> > /*
> >
On Tue, Jan 6, 2015 at 4:35 PM, Dylan Baker wrote:
> I have a couple of comments, but they're just suggestions.
> On Monday, December 15, 2014 10:12:54 PM Jason Ekstrand wrote:
> > This commit builds on the nir_search.h infastructure by adds a bit of
> > python code that makes it stupid easy to w
I have a couple of comments, but they're just suggestions.
On Monday, December 15, 2014 10:12:54 PM Jason Ekstrand wrote:
> This commit builds on the nir_search.h infastructure by adds a bit of
> python code that makes it stupid easy to write an algebraic transformation
> pass. The nir_algebraic.p
---
src/glsl/nir/nir.h | 4
src/glsl/nir/nir_validate.c | 7 +++
2 files changed, 11 insertions(+)
diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h
index ab9383e..e681d85 100644
--- a/src/glsl/nir/nir.h
+++ b/src/glsl/nir/nir.h
@@ -1438,7 +1438,11 @@ void nir_index_blocks(ni
Additional description was added to a variety of places. Also, we no
longer use the term "leaf" to describe fully-qualified direct derefs.
Instead, we simply use the term "direct" or spell it out completely.
---
src/glsl/nir/nir_lower_variables.c | 103 +++--
1 fil
---
src/glsl/nir/nir_lower_locals_to_regs.c | 65
src/glsl/nir/nir_lower_variables.c | 101 +---
2 files changed, 79 insertions(+), 87 deletions(-)
diff --git a/src/glsl/nir/nir_lower_locals_to_regs.c
b/src/glsl/nir/nir_lower_locals_to_regs.
---
src/glsl/nir/nir_lower_variables.c | 111 +
1 file changed, 50 insertions(+), 61 deletions(-)
diff --git a/src/glsl/nir/nir_lower_variables.c
b/src/glsl/nir/nir_lower_variables.c
index 84cf85f..6c3e6cc 100644
--- a/src/glsl/nir/nir_lower_variables.c
+++ b/
This way the basics of the FNV-a1 hash can be reused to easily create other
hashing functions.
Cc: Eric Anholt
---
src/util/hash_table.c | 17 -
src/util/hash_table.h | 19 +++
2 files changed, 23 insertions(+), 13 deletions(-)
diff --git a/src/util/hash_table.c
On Wed, Jan 07, 2015 at 01:13:37AM +0100, Marek Olšák wrote:
> Neither. It's because we use DX10_CLAMP, which converts NaNs to 0.
>
Ok, could we add a dx10_clamp bit to si_shader and make this attribute
conditional on that bit. I'm concerned someone may remove DX10_CLAMP
and forget to also remov
Neither. It's because we use DX10_CLAMP, which converts NaNs to 0.
Marek
On Wed, Jan 7, 2015 at 12:51 AM, Tom Stellard wrote:
> On Mon, Jan 05, 2015 at 12:18:43AM +0100, Marek Olšák wrote:
>> From: Marek Olšák
>>
>> ---
>> src/gallium/drivers/radeon/radeon_llvm_emit.c | 1 +
>> 1 file changed,
On Mon, Jan 05, 2015 at 12:18:43AM +0100, Marek Olšák wrote:
> From: Marek Olšák
>
> ---
> src/gallium/drivers/radeon/radeon_llvm_emit.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c
> b/src/gallium/drivers/radeon/radeon_llvm_emit.c
> in
On Mon, Jan 5, 2015 at 10:45 PM, Connor Abbott wrote:
> I created nir_tex_src_sampler_index for exactly this purpose, which
> fits in with the "stick all the sources in an array so we can easily
> iterate over them" philosophy. If you decide to keep with this
> solution, though, at least remove t
On Sun, Jan 4, 2015 at 7:24 PM, Connor Abbott wrote:
>
>
> On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand
> wrote:
>
>> ---
>> src/glsl/Makefile.sources | 1 +
>> src/glsl/nir/nir.h| 2 +
>> src/glsl/nir/nir_lower_global_vars_to_local.c | 107
On Mon, Jan 5, 2015 at 10:24 PM, Connor Abbott wrote:
> On Tue, Dec 16, 2014 at 1:12 AM, Jason Ekstrand
> wrote:
> > ---
> > src/glsl/Makefile.sources| 1 +
> > src/glsl/nir/nir.h | 1 +
> > src/glsl/nir/nir_opt_constant_folding.c | 283
> +
On Mon, Jan 5, 2015 at 11:26 PM, Connor Abbott wrote:
> Can you make the fields lowercase to match the algebraic properties
> enum? Or did you make that uppercase? Lowercase feels better to me
> since it's an enum, but I don't really care too much.
>
I prefer upper-case for bitfields which is re
On Mon, Jan 5, 2015 at 11:38 PM, Matt Turner wrote:
> On Mon, Dec 15, 2014 at 10:12 PM, Jason Ekstrand
> wrote:
> > This pass uses the previously built algebraic transformations framework
> and
> > should act as an example for anyone else wanting to make an algebraic
> > transformation pass for
On Mon, Jan 5, 2015 at 10:12 PM, Connor Abbott wrote:
> On Tue, Dec 16, 2014 at 1:12 AM, Jason Ekstrand
> wrote:
> > This pass uses the previously built algebraic transformations framework
> and
> > should act as an example for anyone else wanting to make an algebraic
> > transformation pass for
Looks reasonable to me.
Reviewed-by: Chris Forbes
On Tue, Dec 16, 2014 at 7:13 PM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir_lower_samplers.cpp | 149
> ++--
> 1 file changed, 74 insertions(+), 75 deletions(-)
>
> diff --git a/src/glsl/nir/nir_lower_sample
On Tue, Jan 6, 2015 at 4:23 PM, Marek Olšák wrote:
> Having a different view type for writable shader resources sounds good.
>
> An alternative solution would be to have separate functions for images
> and buffers:
>
> - set_image_views - image views only, pipe_image_view should look
> similar to
On Mon, Jan 5, 2015 at 11:02 PM, Connor Abbott wrote:
> The commit message should probably say something like "nir: Make
> nir_ssa_undef_instr_create initialize the destination". That we now
> need to pass in the number of components is just a side effect.
>
Good point. Done.
>
> On Tue, Dec 1
Having a different view type for writable shader resources sounds good.
An alternative solution would be to have separate functions for images
and buffers:
- set_image_views - image views only, pipe_image_view should look
similar to pipe_surface
- set_shader_buffers - buffers only, untyped, no v
On Mon, Jan 5, 2015 at 10:00 PM, Jason Ekstrand
wrote:
>
>
> On Mon, Jan 5, 2015 at 9:12 PM, Connor Abbott wrote:
>
>> Hi,
>>
>> Was it your intention to not support non-per-component things like dot
>> product at all? I've made a few inline comments about how to do it,
>> and it doesn't seem li
On Tue, Jan 6, 2015 at 1:46 PM, Chris Forbes wrote:
> Worth pointing out that when tessellation gets ported to NIR, output
> reads are a real thing, and can't be lowered away like we do for other
> stages (they allow cross-invocation communication, so have to actually
> read back from the URB on
On Mon, Jan 5, 2015 at 10:00 PM, Connor Abbott wrote:
> On Tue, Dec 16, 2014 at 1:12 AM, Jason Ekstrand
> wrote:
> > This commit builds on the nir_search.h infastructure by adds a bit of
>
> adding
>
fixed.
>
> > python code that makes it stupid easy to write an algebraic
> transformation
> >
Worth pointing out that when tessellation gets ported to NIR, output
reads are a real thing, and can't be lowered away like we do for other
stages (they allow cross-invocation communication, so have to actually
read back from the URB on i965)
On Wed, Jan 7, 2015 at 10:43 AM, Jason Ekstrand wrote:
On Sun, Jan 4, 2015 at 8:48 PM, Connor Abbott wrote:
> I'm not so sure how I feel about checking that outputs are write-only...
> eventually we'll want to do lower_input_reads in NIR itself, at which point
> we'll need to remove that part from the validator. At the same time, for
> now this is so
On Wed, Dec 24, 2014 at 12:48:31PM +0900, Michel Dänzer wrote:
> On 24.12.2014 02:49, Tom Stellard wrote:
> > Rather than building a new one every compile. This should reduce some
> > of the overhead of compiling shaders.
>
> Thanks, though unfortunately it doesn't seem to make much difference fo
On Mon, Jan 5, 2015 at 11:28 PM, Connor Abbott wrote:
> Patches 100, 102-104, 106-109, 114-117, 121-146 are:
>
> Reviewed-by: Connor Abbott
>
Noted. I'm working on dealing with comments now.
--Jason
>
> Whew! I think I've looked through everything.
>
> On Tue, Dec 16, 2014 at 1:04 AM, Jason
Hi,
I lost this mail in the mail box.
I am sorry about patch related to pipe. My work is based on Ilia Mirkin
pipe commits. As per my previous mail, you can ignore pipe patch.
My current work is related to R600 backend.
On Tue, Jan 6, 2015 at 8:54 AM, Jose Fonseca wrote:
> Do we really need a n
Actually initially pipe_surface really was for "traditional" render
surface. There were even stand-alone surfaces (i.e. not based on
resources) for the non-fbo (system window) surfaces - this is why the
width/height fields are actually still in there in a pipe_surface (yes
with a XXX comment)...
So
Looks sensible to me.
Reviewed-by: Chris Forbes
On Tue, Dec 16, 2014 at 7:13 PM, Jason Ekstrand wrote:
> ---
> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 24 ++--
> 1 file changed, 22 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp
>
I ran gles3 conformance on your adsa-textures branch. Your patches
cause no regressions.
With all the comments fixed, and no piglit regressions, this series is
Reviewed-by: Anuj Phogat
On Tue, Dec 30, 2014 at 4:27 PM, Laura Ekstrand wrote:
> That is now fixed. Each added entry point in my his
Hi Emil,
I've put some 10.4 r600g fixes together can you pull them for next 10.4
Thanks,
Dave.
The following changes since commit fffe533f08d7c0cc61841195216e54587a1b77ad:
i965: Use safer pointer arithmetic in gather_oa_results()
(2015-01-04 21:39:10 +)
are available in the git repositor
Comments have been addressed:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-textures&id=9c55b528e24650753049a11b05f754ab02a0eba4
On Wed, Dec 31, 2014 at 11:27 AM, Anuj Phogat wrote:
> On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand
> wrote:
> > ---
> > src/mapi/glapi/gen/ARB_direct_st
I think you can squash all the patches fixing the white space issues.
Patch 09/41, 36/41 and 37/41.
On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand wrote:
> ---
> src/mesa/main/texstate.c | 18 +-
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/src/mesa/main/te
These comments have been addressed:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-textures&id=8309dd6981a4d3e007437a860e5a45a823bf04cf
Thanks.
Laura
On Tue, Dec 16, 2014 at 7:45 AM, Brian Paul wrote:
> On 12/15/2014 06:22 PM, Laura Ekstrand wrote:
>
>> ---
>> src/mapi/glapi/gen/ARB_
Ah, OK. I was interpreting sampler view as "all the things you need to
be able to sample from a resource", and surface as "all the things you
need to know where to write in a resource", including a render target.
But you guys have all been playing this game for much much longer than
me...
On Tue,
Oops, wrong link. Here it is:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-textures&id=c2b179fe7d50922d8dc01dbf833885e3f4615277
.
Laura
On Tue, Jan 6, 2015 at 10:41 AM, Laura Ekstrand
wrote:
> I taken your recommendation:
> http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-textu
These comments have been addressed:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-textures&id=7c419db487dc3b2f55a30dca137322baae72f16b
.
On Wed, Dec 31, 2014 at 11:37 AM, Anuj Phogat wrote:
> On Wed, Dec 31, 2014 at 11:21 AM, Anuj Phogat
> wrote:
> > On Mon, Dec 15, 2014 at 5:22 PM, La
Am 06.01.2015 um 18:54 schrieb Marek Olšák:
> I would just rename pipe_sampler_view to pipe_resource_view. I don't
> think "pipe_sampler_view" has a lot to do with samplers. It's just a
> universal view into textures and yes, buffers too. Of course, some
> fields don't apply to certain types and us
I taken your recommendation:
http://cgit.freedesktop.org/~ldeks/mesa/commit/?h=adsa-textures&id=c984a04159fa1febf6ec4a5e900961f88c06e84c
Thanks.
Laura
On Wed, Dec 31, 2014 at 10:45 AM, Anuj Phogat wrote:
> On Mon, Dec 15, 2014 at 5:22 PM, Laura Ekstrand
> wrote:
> > In implementing ARB_DIRECT
I thought pipe_surface was a render target view.
From the r600 point of view, writable resources are pretty much
"colorbuffers", because they share slots with colorbuffers and are set
up exactly like colorbuffers. So pipe_surface maps well to r600, and
using set_framebuffer_state for setting UAVs
I thought that a surface was basically a writable view into a
resource. What does sampler view have that surface doesn't (that
matters)? The only thing I can think of is levels, but does anything
actually support multi-level stuff? (ARB_shader_image_load_store
doesn't seem to.)
On Tue, Jan 6, 2015
https://bugs.freedesktop.org/show_bug.cgi?id=67676
Jonny Lamb changed:
What|Removed |Added
CC||jonny.l...@collabora.co.uk
--
You are rece
https://bugs.freedesktop.org/show_bug.cgi?id=67676
--- Comment #8 from Jonny Lamb ---
Created attachment 111864
--> https://bugs.freedesktop.org/attachment.cgi?id=111864&action=edit
EGL_MESA_transparent_alpha draft
Here is my initial draft for this extension. It's already been fixed after a
ro
https://bugs.freedesktop.org/show_bug.cgi?id=88079
Chad Versace changed:
What|Removed |Added
CC||el...@igalia.com,
|
I would just rename pipe_sampler_view to pipe_resource_view. I don't
think "pipe_sampler_view" has a lot to do with samplers. It's just a
universal view into textures and yes, buffers too. Of course, some
fields don't apply to certain types and use cases.
OMSetRenderTargetsAndUnorderedAccessViews
On 11/25/2014 11:09 PM, Tapani Pälli wrote:
> Patch enables ES2 extension that utilizes existing ES3 functionality.
>
> Changes make all the subtests to run and pass in WebGL conformance
> test 'webgl-draw-buffers' when running Chrome on OpenGL ES.
>
> v2: remove unused boolean (Ilia Mirkin)
>
>
You are quite right using pipe_surface seems like a bit of an abuse.
pipe_sampler_view wouldn't be quite right though neither, no samplers
are involved. Plus, the views here cannot have multiple mip levels
(which is presumably why pipe_surface was used - nevertheless
pipe_surface was intended only
Using set_shader_resources is preferable. I'd rather it used
pipe_sampler_view, not pipe_surface.
GL has a lot of shader resource types though:
- uniform buffers (load only)
- textures and texture buffers (sample+load only)
- storage buffers (load+store)
- atomic counter buffers (atomic only)
- im
On 05/01/15 00:05, Eric Anholt wrote:
v2: Instead of telling the driver that the window system ancillaries have
been invalidated (when the driver doesn't know which of its buffers
are the window system's!), introduce a method for invalidating
specific surfaces.
Thanks, much bette
On Tue, Jan 6, 2015 at 8:54 AM, Jose Fonseca wrote:
> Do we really need a new pipe_context::set_counter_buffer method? Shouldn't
> this case be covered by pipe_context::set_shader_resources ?
FWIW this is the approach I've taken in
https://github.com/imirkin/mesa/commits/atomic
I've mentioned t
Do we really need a new pipe_context::set_counter_buffer method?
Shouldn't this case be covered by pipe_context::set_shader_resources ?
If we really need new method, I'd like we have better names for them, so
we can clearly distinguish them.
IIUC GL_ARB_shader_atomic_counters correctly, this
The remaining 12 patches are
Reviewed-by: Michel Dänzer
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Mesa and X developer
___
mesa-dev mailing list
mesa-dev@lists.fre
67 matches
Mail list logo
