[Mesa-dev] [PATCH] i965: Micro-optimize swizzle_to_scs() and make it inlinable.

2015-01-02 Thread Kenneth Graunke
brw_swizzle_to_scs has been showing up in my CPU profiling, which is rather silly - it's a tiny amount of code. It really should be inlined, and can easily be implemented with fewer instructions. The enum translation is as follows: SWIZZLE_X, SWIZZLE_Y, SWIZZLE_Z, SWIZZLE_W, SWIZZLE_ZERO, SWIZZL

Re: [Mesa-dev] [PATCH] i965: Micro-optimize swizzle_to_scs() and make it inlinable.

2015-01-02 Thread Jason Ekstrand
On Jan 2, 2015 7:26 PM, "Kenneth Graunke" wrote: > > brw_swizzle_to_scs has been showing up in my CPU profiling, which is > rather silly - it's a tiny amount of code. It really should be inlined, > and can easily be implemented with fewer instructions. > > The enum translation is as follows: > >

[Mesa-dev] [PATCH] i965: Micro-optimize swizzle_to_scs() and make it inlinable.

2015-01-02 Thread Kenneth Graunke
brw_swizzle_to_scs has been showing up in my CPU profiling, which is rather silly - it's a tiny amount of code. It really should be inlined, and can easily be implemented with fewer instructions. The enum translation is as follows: SWIZZLE_X, SWIZZLE_Y, SWIZZLE_Z, SWIZZLE_W, SWIZZLE_ZERO, SWIZZL

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon on Source games

2015-01-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #8 from Stéphane Travostino --- Here's the apitrace with mesa-git and the 4 patches from comments #3 and #4: https://drive.google.com/file/d/0BwBQBTnr5Iv6WHBfeE50RUxvRUU/view?usp=sharing Warning: 290MB file, ~1GB uncompressed. The f

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon on Source games

2015-01-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #7 from Stéphane Travostino --- (In reply to Jason Ekstrand from comment #6) > Could you please also test with Ken's 4 patches. That will tell us if it > was just the recompiles or if there's something else we should be looking > for

[Mesa-dev] [PATCH 12/12] mesa: create, use new _mesa_texture_base_format() function

2015-01-02 Thread Brian Paul
--- src/mesa/main/ff_fragment_shader.cpp | 2 +- src/mesa/main/texobj.c | 14 ++ src/mesa/main/texobj.h | 3 +++ src/mesa/state_tracker/st_atom_sampler.c | 4 +--- src/mesa/state_tracker/st_atom_texture.c | 7 +++ src/mesa/swrast/s_texfil

[Mesa-dev] [PATCH 10/12] swrast: use new _mesa_base_tex_image() helper

2015-01-02 Thread Brian Paul
--- src/mesa/swrast/s_aaline.c | 1 + src/mesa/swrast/s_aalinetemp.h | 3 +- src/mesa/swrast/s_fragprog.c | 4 +-- src/mesa/swrast/s_span.c | 3 +- src/mesa/swrast/s_texfilter.c | 67 +- src/mesa/swrast/s_triangle.c | 11 +++ 6 files c

[Mesa-dev] [PATCH 11/12] mesa: remove unused ctx parameter for _mesa_select_tex_image()

2015-01-02 Thread Brian Paul
--- src/mesa/drivers/common/meta_blit.c| 2 +- src/mesa/drivers/common/meta_generate_mipmap.c | 6 +++--- src/mesa/main/copyimage.c | 2 +- src/mesa/main/fbobject.c | 2 +- src/mesa/main/genmipmap.c | 2 +- src/mesa/m

[Mesa-dev] [PATCH 08/12] mesa: add _mesa_base_tex_image() helper function

2015-01-02 Thread Brian Paul
--- src/mesa/main/teximage.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/mesa/main/teximage.h b/src/mesa/main/teximage.h index 4b27381..caca971 100644 --- a/src/mesa/main/teximage.h +++ b/src/mesa/main/teximage.h @@ -114,6 +114,16 @@ _mesa_get_tex_image(struct gl_context *c

[Mesa-dev] [PATCH 05/12] mesa: make _mesa_reference_shader_program() an inline function

2015-01-02 Thread Brian Paul
which wraps _mesa_reference_shader_program_(), similar to what we do for other reference-counted objects. --- src/mesa/main/shaderobj.c | 6 +++--- src/mesa/main/shaderobj.h | 13 - 2 files changed, 15 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/shaderobj.c b/src/mesa/ma

[Mesa-dev] [PATCH 04/12] mesa: update comment on delete_shader_program()

2015-01-02 Thread Brian Paul
--- src/mesa/main/shaderapi.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 8e49e30..43170b8 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -326,8 +326,9 @@ create_shader_program(struc

[Mesa-dev] [PATCH 02/12] mesa: fix error strings in shaderapi.c

2015-01-02 Thread Brian Paul
The _mesa_-prefixed function names should not appear in GL error messages. --- src/mesa/main/shaderapi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 6d831f7..b7c39ee 100644 --- a/src/mesa/main/shaderapi.c +++ b

[Mesa-dev] [PATCH 03/12] mesa: rearrange error handling in glProgramParameteri()

2015-01-02 Thread Brian Paul
--- src/mesa/main/shaderapi.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index b7c39ee..8e49e30 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -1755,12 +1755,7 @@

[Mesa-dev] [PATCH 07/12] mesa: simplify a conditional in detach_shader()

2015-01-02 Thread Brian Paul
--- src/mesa/main/shaderapi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index e38189c..e5e9cab 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -431,9 +431,7 @@ detach_shader(struct gl_conte

[Mesa-dev] [PATCH 01/12] glsl: use the is_gl_identifier() helper in a couple more places

2015-01-02 Thread Brian Paul
--- src/glsl/ir_validate.cpp| 2 +- src/glsl/opt_dead_builtin_variables.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/ir_validate.cpp b/src/glsl/ir_validate.cpp index 5a6f8bb..6d56339 100644 --- a/src/glsl/ir_validate.cpp +++ b/src/glsl/ir_vali

[Mesa-dev] [PATCH 06/12] mesa: minor whitespace fixes in shaderapi.c

2015-01-02 Thread Brian Paul
--- src/mesa/main/shaderapi.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c index 43170b8..e38189c 100644 --- a/src/mesa/main/shaderapi.c +++ b/src/mesa/main/shaderapi.c @@ -307,7 +307,7 @@ crea

[Mesa-dev] [PATCH 09/12] st/mesa: use new _mesa_base_tex_image() helper

2015-01-02 Thread Brian Paul
This involved adding a new st_texture_image_const() helper also. --- src/mesa/state_tracker/st_atom_sampler.c | 3 ++- src/mesa/state_tracker/st_atom_texture.c | 3 ++- src/mesa/state_tracker/st_cb_drawtex.c | 3 ++- src/mesa/state_tracker/st_cb_texture.c | 4 ++-- src/mesa/state_tracker/st_te

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon on Source games

2015-01-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #6 from Jason Ekstrand --- Could you please also test with Ken's 4 patches. That will tell us if it was just the recompiles or if there's something else we should be looking for. -- You are receiving this mail because: You are the

[Mesa-dev] [Bug 87886] constant fps drops with Intel and Radeon on Source games

2015-01-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87886 --- Comment #5 from Stéphane Travostino --- (In reply to Eero Tamminen from comment #1) > Has your performance regressed? This fall there have been some compiler > frontend improvements that allow e.g. more inlining to be done for some > shaders

Re: [Mesa-dev] [PATCH 1/2] mesa: Add support for the ARB_pipeline_statisticcs_Query extension

2015-01-02 Thread Ilia Mirkin
On Fri, Jan 2, 2015 at 4:43 PM, Ben Widawsky wrote: > This was originally part of a single patch which added the extension, and > implemented it for i965 classic. For information about the evolution of the > patch, please see the subsequent commit. > > One difference here as compared to the origin

[Mesa-dev] [PATCH 2/2] i965: implement ARB_pipeline_statistics_query

2015-01-02 Thread Ben Widawsky
NOTE: The implementation was initially one patch, this. All the history is kept here, even though all the core mesa changes were moved to the parent of this patch. This patch implements ARB_pipeline_statistics_query. This addition to GL does not add a new API. Instead, it adds new tokens to the ex

[Mesa-dev] [PATCH 1/2] mesa: Add support for the ARB_pipeline_statisticcs_Query extension

2015-01-02 Thread Ben Widawsky
This was originally part of a single patch which added the extension, and implemented it for i965 classic. For information about the evolution of the patch, please see the subsequent commit. One difference here as compared to the original mega patch is this does build support for the compute shade

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2015-01-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #15 from John --- I can confirm this patch allows me to be back on git as well. Since November or so I've been unable to use vdpau with mesa-git, but with this patch it works. -- You are receiving this mail because: You are the assi

Re: [Mesa-dev] [PATCH 2/4] mesa: add support for GL_EXT_polygon_offset_clamp

2015-01-02 Thread Ilia Mirkin
On Thu, Jan 1, 2015 at 4:58 AM, Ilia Mirkin wrote: > On Thu, Jan 1, 2015 at 4:44 AM, Kenneth Graunke wrote: >> On Wednesday, December 31, 2014 02:38:12 AM Ilia Mirkin wrote: >>> Nothing enables the extension yet, but the values are now available. >>> The spec calls for it to only be exposed for G

Re: [Mesa-dev] [PATCH] meta: init var to silence uninitialized variable warning

2015-01-02 Thread Brian Paul
On 01/02/2015 11:50 AM, Matt Turner wrote: On Fri, Jan 2, 2015 at 9:38 AM, Brian Paul wrote: On 12/20/2014 10:51 AM, Matt Turner wrote: On Sat, Dec 20, 2014 at 4:34 AM, Brian Paul wrote: --- src/mesa/drivers/common/meta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --g

Re: [Mesa-dev] [PATCH] meta: init var to silence uninitialized variable warning

2015-01-02 Thread Matt Turner
On Fri, Jan 2, 2015 at 9:38 AM, Brian Paul wrote: > On 12/20/2014 10:51 AM, Matt Turner wrote: >> >> On Sat, Dec 20, 2014 at 4:34 AM, Brian Paul wrote: >>> >>> --- >>> src/mesa/drivers/common/meta.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/src/mesa/drivers

Re: [Mesa-dev] [PATCH] meta: init var to silence uninitialized variable warning

2015-01-02 Thread Brian Paul
On 12/20/2014 10:51 AM, Matt Turner wrote: On Sat, Dec 20, 2014 at 4:34 AM, Brian Paul wrote: --- src/mesa/drivers/common/meta.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 87532c1..f479b1c 100644 -

Re: [Mesa-dev] [PATCH 4/4] st/mesa: add EXT_polygon_offset_clamp support

2015-01-02 Thread Eric Anholt
Ilia Mirkin writes: > On Wed, Dec 31, 2014 at 3:03 PM, Eric Anholt wrote: >> Ilia Mirkin writes: >> >>> Signed-off-by: Ilia Mirkin >> >> VC4 doesn't support this, so it shouldn't be enabled by default. > > VC4 also doesn't support core contexts. The extension is supposed to > only be enabled f

Re: [Mesa-dev] Mesa 10.4 still reports only OpenGL 3.0 on SNB

2015-01-02 Thread Clemens Eisserer
Hi Ki'Sak, > Tools like glxinfo should be giving you two lines that report what is > exposed, you should look for "OpenGL core profile version string:" as well > as "OpenGL version string:" And so it, no idea how I could have missed it: > OpenGL core profile version string: 3.3 (Core Profile) Mes

Re: [Mesa-dev] [PATCH 18/41] main: Added entry point for glTextureParameterf.

2015-01-02 Thread Brian Paul
On 12/30/2014 06:45 PM, Anuj Phogat wrote: On Tue, Dec 16, 2014 at 6:52 AM, Laura Ekstrand wrote: --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++ src/mesa/main/texparam.c | 52 +- src/mesa/main/texparam.h | 20

Re: [Mesa-dev] [PATCH] glsl_to_tgsi: fix a bug in copy propagation

2015-01-02 Thread Brian Paul
On 01/02/2015 06:16 AM, Marek Olšák wrote: From: Marek Olšák This fixes the new piglit test: arb_uniform_buffer_object/2-buffers-bug Cc: 10.2 10.3 10.4 --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracke

[Mesa-dev] Mesa 10.4 still reports only OpenGL 3.0 on SNB

2015-01-02 Thread Clemens Eisserer
Hi, I just noticed mesa 10.4 still only reports OpenGL 3.0 compatibility on my SNB notebook: > OpenGL version string: 3.0 Mesa 10.4.0 Is there something wrong with my setup or is OpenGL-3.0 the best I can get with Sandybridge for now? Thanks and best regards, Clemens ___

[Mesa-dev] [Bug 84023] GLSL compiler bug in uniform buffer load lowering or optimizations

2015-01-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84023 --- Comment #3 from Marek Olšák --- Fix: http://lists.freedesktop.org/archives/mesa-dev/2015-January/073510.html -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev

[Mesa-dev] [PATCH] glsl_to_tgsi: fix a bug in copy propagation

2015-01-02 Thread Marek Olšák
From: Marek Olšák This fixes the new piglit test: arb_uniform_buffer_object/2-buffers-bug Cc: 10.2 10.3 10.4 --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker

[Mesa-dev] [Bug 84023] GLSL compiler bug in uniform buffer load lowering or optimizations

2015-01-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84023 --- Comment #2 from Marek Olšák --- This bug seems to be Gallium-specific according to Chris Forbes. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list

Re: [Mesa-dev] [PATCH 1/2] i965: Make the precompile ignore DEPTH_TEXTURE_MODE on Gen7.5+.

2015-01-02 Thread Kenneth Graunke
On Thursday, January 01, 2015 11:16:17 PM Ian Romanick wrote: > On 01/01/2015 10:51 PM, Kenneth Graunke wrote: > > On Thursday, January 01, 2015 10:21:43 PM Ian Romanick wrote: > >> On 12/31/2014 08:04 PM, Kenneth Graunke wrote: > >>> Gen7.5+ platforms that support the "Shader Channel Select" featu