On Tuesday, November 18, 2014 09:11:26 PM Chad Versace wrote:
> This patch reduces the likelihood of pointer arithmetic overflow bugs in
> gather_oa_results(), like the one fixed by b69c7c5dac.
>
> I haven't yet encountered any overflow bugs in the wild along this
> patch's codepath. But I get ner
Reviewed-by: Connor Abbott
On Thu, Dec 18, 2014 at 9:44 PM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir.h | 53 +++--
> 1 file changed, 43 insertions(+), 10 deletions(-)
>
> diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h
> index 19781c1..
---
src/glsl/nir/nir.h | 53 +++--
1 file changed, 43 insertions(+), 10 deletions(-)
diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h
index 19781c1..dd1f3c7 100644
--- a/src/glsl/nir/nir.h
+++ b/src/glsl/nir/nir.h
@@ -98,7 +98,7 @@ typedef struc
On Dec 18, 2014 5:25 PM, "Connor Abbott" wrote:
>
> On Thu, Dec 18, 2014 at 8:15 PM, Jason Ekstrand
wrote:
> > ---
> > src/glsl/nir/nir.h | 43 +--
> > 1 file changed, 33 insertions(+), 10 deletions(-)
> >
> > diff --git a/src/glsl/nir/nir.h b/src/glsl/nir
On Thu, Dec 18, 2014 at 8:15 PM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir.h | 43 +--
> 1 file changed, 33 insertions(+), 10 deletions(-)
>
> diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h
> index 19781c1..aa128ad 100644
> --- a/src/glsl/nir/nir
---
src/glsl/nir/nir.h | 43 +--
1 file changed, 33 insertions(+), 10 deletions(-)
diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h
index 19781c1..aa128ad 100644
--- a/src/glsl/nir/nir.h
+++ b/src/glsl/nir/nir.h
@@ -98,7 +98,7 @@ typedef struct nir_cons
Previously, our variable renaming algorithm, while similar to the one in
the Cytron paper, was not the same. While I'm pretty sure it was correct,
it will be easier for readers of the code in the variable renaming pass if
it follows more closely. This commit removes the automatic stack popping
we
Pitch_bytes is in bytes, but pitch_tile_max is in multiples of 8
pixels. I think a proper conversion is needed, so that there's no
overallocation: fmask_pitch_bytes =
(color_pitch_bytes/(color_bpe*color_nsamples))*fmask_bpe*fmask_nsamples.
On the other hand, I think you can ignore that and just cop
https://bugs.freedesktop.org/show_bug.cgi?id=84186
--- Comment #14 from Wim Lewis ---
(In reply to Michel Dänzer from comment #12)
Well, the place it seemed to be going off the rails was in
dri2_lookup_egl_image() in dri2.c; the call to loader->lookupEGLImage() was
returning NULL. That pointed i
On Thu, Dec 18, 2014 at 5:01 PM, Jason Ekstrand wrote:
>
>
> On Wed, Dec 17, 2014 at 10:22 PM, Eric Anholt wrote:
>>
>> Jason Ekstrand writes:
>>
>> > From: Connor Abbott
>> >
>> > This is similar to ir_print_visitor.cpp.
>>
>>
>> > +static void
>> > +print_alu_src(nir_alu_src *src, FILE *fp)
>
Cc: Eric Anholt
---
src/glsl/nir/nir_print.c | 45 -
1 file changed, 12 insertions(+), 33 deletions(-)
diff --git a/src/glsl/nir/nir_print.c b/src/glsl/nir/nir_print.c
index e9d528f..001f933 100644
--- a/src/glsl/nir/nir_print.c
+++ b/src/glsl/nir/nir_
On Wed, Dec 17, 2014 at 10:22 PM, Eric Anholt wrote:
>
> Jason Ekstrand writes:
>
> > From: Connor Abbott
> >
> > This is similar to ir_print_visitor.cpp.
>
>
> > +static void
> > +print_alu_src(nir_alu_src *src, FILE *fp)
> > +{
> > + if (src->negate)
> > + fprintf(fp, "-");
> > + if (
This commit seeks to make the lower_variables pass much more clear by
adding a pile of comments and re-arranging a few things. There are no
functional or algorithmic changes.
---
src/glsl/nir/nir_lower_variables.c | 227 +++--
1 file changed, 170 insertions(+), 57
https://bugs.freedesktop.org/show_bug.cgi?id=84186
--- Comment #13 from Axel Davy ---
Looking at:
"
libEGL debug: dlopen(/usr/lib/x86_64-linux-gnu/egl/egl_gallium.so)
libEGL info: use DRM for display 0x7f80bda34720
libEGL debug: EGL user error 0x3001 (EGL_NOT_INITIALIZED) in eglInitialize(no
usa
On Thu, Dec 18, 2014 at 1:49 PM, Eric Anholt wrote:
> Connor Abbott writes:
>
>> On Thu, Dec 18, 2014 at 2:01 AM, Eric Anholt wrote:
>>> Jason Ekstrand writes:
>>>
From: Connor Abbott
This is similar to ir_validate.cpp.
v2: Jason Ekstrand :
whitespace fixes
>>>
After sending this review, I think it would be best (to avoid a gigantic
merge snarl) for me to send another patch where I manually merge this with
my patch "[PATCH 29/41] main: Added entry point for glGetTextureImage."
Laura
On Thu, Dec 18, 2014 at 10:07 AM, Laura Ekstrand
wrote:
>
> Brian,
>
>
I couldn't get your patches to apply on top of master. Can you rebase your
v2 on top of master? Or can you send a link to your repo so I can
cherry-pick the commits?
On Wed, Dec 17, 2014 at 11:40 AM, Brian Paul wrote:
>
> On 12/16/2014 12:56 PM, Laura Ekstrand wrote:
>
>>
>>
>> On Sat, Dec 13,
Connor Abbott writes:
> On Thu, Dec 18, 2014 at 2:01 AM, Eric Anholt wrote:
>> Jason Ekstrand writes:
>>
>>> From: Connor Abbott
>>>
>>> This is similar to ir_validate.cpp.
>>>
>>> v2: Jason Ekstrand :
>>>whitespace fixes
>>
>> I have again not reviewed the control flow bits. Couple of qu
Brian,
I dealt with a lot of the TEXTURE_CUBE_MAP stuff when I implemented
GetTextureImage (in my recent DSA textures patch series).
Ian and I have filed a bug on the spec for missing faces and mismatched
formats/sizes. Right now, I am saying if (texObj->NumLayers < 6), throw
invalid operation (n
https://bugs.freedesktop.org/show_bug.cgi?id=64045
Link Mauve changed:
What|Removed |Added
CC||b...@linkmauve.fr
--
You are receiving thi
H, if you convert to float you have a real problem: floats only
have 23 bits of mantissa, so if bit 31 or 32 is set bits 0-7 will be
lost. Converting directly won't change a thing there. Initing to 255
is definitively better it seems.
W.r.t clamping, in computer graphics clamping a value to
On Thu, Dec 18, 2014 at 2:01 AM, Eric Anholt wrote:
> Jason Ekstrand writes:
>
>> From: Connor Abbott
>>
>> This is similar to ir_validate.cpp.
>>
>> v2: Jason Ekstrand :
>>whitespace fixes
>
> I have again not reviewed the control flow bits. Couple of questions I
> had, though:
>
>> +stati
On Wed, Dec 17, 2014 at 8:42 PM, Connor Abbott wrote:
>
> On Wed, Dec 17, 2014 at 10:50 PM, Jason Ekstrand
> wrote:
> >
> >
> > On Wed, Dec 17, 2014 at 7:13 PM, Connor Abbott
> wrote:
> >>
> >> On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand
> >> wrote:
> >> > This pass analizes all of the load
On 12/17/2014 05:03 PM, Laura Ekstrand wrote:
On Sat, Dec 13, 2014 at 6:42 AM, Brian Paul mailto:bri...@vmware.com>> wrote:
One of the two new functions in GL_ARB_get_texture_sub_image.
---
src/mesa/main/texgetimage.c | 305
++--
s
This is a partial revert of c89306983c07e5a88c0d636267e5ccf263cb4213.
It split the {start,base}_vertex_location handling into several steps:
1. Set brw->draw.start_vertex_location = prim[i].start
and brw->draw.base_vertex_location = prim[i].basevertex.
(This happened once per _mesa_prim, in
On 12/18/2014 10:28 AM, Eduardo Lima Mitev wrote:
> On 12/18/2014 09:55 AM, Olivier Galibert wrote:
>> Something is not clear to me: In which way -1 is incorrect?
>>
>
> Hi Olivier,
>
> The values being queried are the front and back stencil masks. Masks are
> (conceptually?) an unsigned integer,
On 12/18/2014 09:55 AM, Olivier Galibert wrote:
> Something is not clear to me: In which way -1 is incorrect?
>
Hi Olivier,
The values being queried are the front and back stencil masks. Masks are
(conceptually?) an unsigned integer, AFAIU. Also, the test I'm trying to
fix fails precisely becaus
Hi,
Something is not clear to me: In which way -1 is incorrect?
Also, w.r.t comments, what you're doing is masking, not clamping,
which incidentally is a good thing since clamping would be severely
bad for stencil.
Best,
OG.
On Thu, Dec 11, 2014 at 11:34 PM, Eduardo Lima Mitev wrote:
> Ste
https://bugs.freedesktop.org/show_bug.cgi?id=84186
Michel Dänzer changed:
What|Removed |Added
CC||veb...@hotmail.fr
--- Comment #12 from M
29 matches
Mail list logo
