https://bugs.freedesktop.org/show_bug.cgi?id=84186
Wim Lewis changed:
What|Removed |Added
CC||w...@.org
--
You are receiving this mai
https://bugs.freedesktop.org/show_bug.cgi?id=84186
--- Comment #11 from Wim Lewis ---
Created attachment 110973
--> https://bugs.freedesktop.org/attachment.cgi?id=110973&action=edit
Backtraces from att_incomplete()
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=84186
--- Comment #10 from Wim Lewis ---
(Continuing this bug report from
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=767356)
I rebuilt with --enable-debug and got this output. I'm not sure what info is
useful, so I'm also attaching a file with
https://bugs.freedesktop.org/show_bug.cgi?id=86701
--- Comment #3 from Pekka Paalanen ---
Actually we seem to have an even older report of a similar thing: bug #64045
--
You are receiving this mail because:
You are the assignee for the bug.
___
mesa-d
Jason Ekstrand writes:
> From: Connor Abbott
>
> This is similar to ir_validate.cpp.
>
> v2: Jason Ekstrand :
>whitespace fixes
I have again not reviewed the control flow bits. Couple of questions I
had, though:
> +static void
> +validate_var_use(nir_variable *var, validate_state *state)
Jason Ekstrand writes:
> From: Connor Abbott
>
> This is similar to ir_print_visitor.cpp.
> +static void
> +print_alu_src(nir_alu_src *src, FILE *fp)
> +{
> + if (src->negate)
> + fprintf(fp, "-");
> + if (src->abs)
> + fprintf(fp, "abs(");
> +
> + print_src(&src->src, fp);
> +
Connor Abbott writes:
> On Tue, Dec 16, 2014 at 5:48 PM, Eric Anholt wrote:
>> Jason Ekstrand writes:
>>> +typedef struct {
>>> + nir_register *reg;
>>> + struct nir_src *indirect; /** < NULL for no indirect offset */
>>> + unsigned base_offset;
>>> +
>>> + /* TODO def-use chain goes he
On Wed, Dec 17, 2014 at 10:50 PM, Jason Ekstrand wrote:
>
>
> On Wed, Dec 17, 2014 at 7:13 PM, Connor Abbott wrote:
>>
>> On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand
>> wrote:
>> > This pass analizes all of the load/store operations and, when a variable
>> > is
>> > never aliased (potentiall
On Wed, Dec 17, 2014 at 7:13 PM, Connor Abbott wrote:
>
> On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand
> wrote:
> > This pass analizes all of the load/store operations and, when a variable
> is
> > never aliased (potentially used by an indirect operation), it is lowered
> > directly to an SSA
On Wed, Dec 17, 2014 at 1:59 AM, Connor Abbott wrote:
> Patches 23-26, 28, 30-35, 37-38, 40, (41 gets killed later so I didn't
> review it), 42-44 are
>
> Reviewed-by: Connor Abbott
>
> I'm going to bed now, but I'll try to do some more later.
Patches 47-48, 52-54, 56-58, 60-64, 66-70, 72-73, 76
On Wed, Dec 17, 2014 at 10:13 PM, Connor Abbott wrote:
> On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand wrote:
>> This pass analizes all of the load/store operations and, when a variable is
>> never aliased (potentially used by an indirect operation), it is lowered
>> directly to an SSA value.
On Wed, Dec 17, 2014 at 9:38 PM, Jason Ekstrand wrote:
>
>
> On Wed, Dec 17, 2014 at 6:01 PM, Connor Abbott wrote:
>>
>> > +
>> > +static nir_deref *
>> > +get_deref_tail(nir_deref *deref)
>> > +{
>> > + while (deref->child != NULL)
>> > + deref = deref->child;
>> > + return deref;
>> >
On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand wrote:
> This pass analizes all of the load/store operations and, when a variable is
> never aliased (potentially used by an indirect operation), it is lowered
> directly to an SSA value. This pass translates to SSA directly and does
> not require a
On Wed, Dec 17, 2014 at 6:01 PM, Connor Abbott wrote:
> > +
> > +static nir_deref *
> > +get_deref_tail(nir_deref *deref)
> > +{
> > + while (deref->child != NULL)
> > + deref = deref->child;
> > + return deref;
> > +}
>
> I think long-term, we should probably make dereferences exec list
On Fri, Dec 12, 2014 at 12:34 PM, Matt Turner wrote:
> On Thu, Dec 11, 2014 at 2:25 AM, Emil Velikov
> wrote:
>> * Let's drop "mesa: Remove tarballs/checksum rules." for now. Apart
>> from the mapi issue, vdpau and xvmc will need the uninstall-hook,
>> clean-local rules.
>
> Okay, I've committe
On Wed, Dec 17, 2014 at 8:41 PM, Jason Ekstrand wrote:
>
>
> On Wed, Dec 17, 2014 at 5:30 PM, Connor Abbott wrote:
>>
>> On Tue, Dec 16, 2014 at 1:05 AM, Jason Ekstrand
>> wrote:
>> > ---
>> > src/glsl/nir/nir_from_ssa.c | 40 -
>> > src/mesa/drivers/dri/i96
Nits fixed.
On Tue, Dec 16, 2014 at 7:45 AM, Brian Paul wrote:
>
> On 12/15/2014 06:22 PM, Laura Ekstrand wrote:
>
>> ---
>> src/mesa/drivers/dri/i965/intel_tex_copy.c | 1 +
>> src/mesa/drivers/dri/swrast/swrast.c | 1 +
>> src/mesa/main/texgetimage.c| 2 +-
>> src/
On Wed, Dec 17, 2014 at 8:48 PM, Jason Ekstrand wrote:
>
>
> On Wed, Dec 17, 2014 at 2:23 PM, Connor Abbott wrote:
>>
>> On Wed, Dec 17, 2014 at 5:11 PM, Jason Ekstrand
>> wrote:
>> > On Wed, Dec 17, 2014 at 1:52 PM, Connor Abbott
>> > wrote:
>> >>
>> >> I'm sure you're already aware, but there
On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand wrote:
> ---
> src/glsl/Makefile.sources | 1 +
> src/glsl/nir/nir.h | 2 +
> src/glsl/nir/nir_split_var_copies.c | 225
>
> 3 files changed, 228 insertions(+)
> create mode 10064
That makes sense. It's now
main: Added utility function _mesa_lookup_texture_err().
On Wed, Dec 17, 2014 at 3:47 AM, Anuj Phogat wrote:
>
> Keep the subject of commit message short (under 50 chars) and use present
> tense.
> Here you can use "mesa: Add utility function _mesa_lookup_texture_error
Sure. It's now
i965: blit_texture_to_pbo() now accepts TEXTURE_CUBE_MAP.
On Wed, Dec 17, 2014 at 4:20 AM, Anuj Phogat wrote:
>
> How about using below subject?
> i965: intel_get_tex_image() now accepts TEXTURE_CUBE_MAP as a valid target
>
> It's more specific than using a file name. I'll leave i
On Wed, Dec 17, 2014 at 2:23 PM, Connor Abbott wrote:
>
> On Wed, Dec 17, 2014 at 5:11 PM, Jason Ekstrand
> wrote:
> > On Wed, Dec 17, 2014 at 1:52 PM, Connor Abbott
> wrote:
> >>
> >> I'm sure you're already aware, but there are two things we could do to
> >> speed this up:
> >>
> >> 1. Pre-com
Can we move this right after patch 53 (nir: Automatically handle SSA
uses when an instruction is inserted), since they're doing similar
things?
On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir.c | 9 -
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> d
On Wed, Dec 17, 2014 at 5:39 PM, Connor Abbott wrote:
> Again, this looks pretty self-contained and pretty easy to squash.
>
Sure.
>
> On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand
> wrote:
> > ---
> > src/glsl/nir/nir.h | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > dif
On Wed, Dec 17, 2014 at 5:30 PM, Connor Abbott wrote:
>
> On Tue, Dec 16, 2014 at 1:05 AM, Jason Ekstrand
> wrote:
> > ---
> > src/glsl/nir/nir_from_ssa.c | 40 -
> > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 50
> +---
> > 2 file
Again, this looks pretty self-contained and pretty easy to squash.
On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h
> index b04a137..fc16cb5 100644
>
On Wed, Dec 17, 2014 at 5:13 PM, Connor Abbott wrote:
>
> Would it be possible to drop this patch since this all gets deleted later?
>
We could, but I'd rather leave it in the history.
--Jason
>
> On Tue, Dec 16, 2014 at 1:05 AM, Jason Ekstrand
> wrote:
> > ---
> > src/glsl/Makefile.sources
On Sat, Dec 13, 2014 at 6:42 AM, Brian Paul wrote:
>
> ---
> src/mesa/main/texgetimage.c | 440
> +---
> src/mesa/main/texgetimage.h | 7 +
> 2 files changed, 297 insertions(+), 150 deletions(-)
>
> diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main
On Tue, Dec 16, 2014 at 1:05 AM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir_from_ssa.c | 40 -
> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 50
> +---
> 2 files changed, 65 insertions(+), 25 deletions(-)
>
> diff --git a/src/gl
We shouldn't ever have global registers until we start dealing with
subroutines, so you don't need to handle them here.
On Tue, Dec 16, 2014 at 1:05 AM, Jason Ekstrand wrote:
> ---
> src/mesa/drivers/dri/i965/brw_fs.h | 4 +--
> src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 46
> +++
Would it be possible to drop this patch since this all gets deleted later?
On Tue, Dec 16, 2014 at 1:05 AM, Jason Ekstrand wrote:
> ---
> src/glsl/Makefile.sources| 1 +
> src/glsl/nir/nir.h | 1 +
> src/glsl/nir/nir_opcodes.h | 1 +
> sr
On Wed, Dec 17, 2014 at 8:00 PM, Jason Ekstrand wrote:
>
>
> On Wed, Dec 17, 2014 at 4:52 PM, Connor Abbott wrote:
>>
>> I think we're missing a few things:
>>
>> * Phi node sources
>
>
> Added
>
>>
>> * Parallel copy entries
>
>
> I don't think we're validating anything for parallel copies right
For my own sake as well of those reviewing things, I'm keeping both the
review/nir-v1 branch and
http://patchwork.freedesktop.org/bundle/jekstrand/nir-v1/ up-to-date as new
patches get sent out and reviewed-by's get added.
On Tue, Dec 16, 2014 at 10:59 PM, Connor Abbott wrote:
>
> Patches 23-26,
On Wed, Dec 17, 2014 at 2:35 PM, Connor Abbott wrote:
>
> On Tue, Dec 16, 2014 at 1:05 AM, Jason Ekstrand
> wrote:
> > ---
> > src/glsl/nir/nir.c | 45
> -
> > src/glsl/nir/nir.h | 23 +++
> > src/glsl/nir/nir_print.c |
parallel_copy_copy was a silly name. Also, things were getting long and
annoying, so I added a foreach macro. For historical reasons, several of
the original iterations over parallel copy entries in from_ssa used the
_safe variants of the loop. However, all of these no longer ever remove an
entr
Previously, we were doing a lazy creation of the parallel copy
instructions. This is confusing, hard to get right, and involves some
extra state tracking of the copies. This commit adds an extra walk over
the basic blocks to add the block-end parallel copies up front. This
should be much less co
On Wed, Dec 17, 2014 at 4:52 PM, Connor Abbott wrote:
>
> I think we're missing a few things:
>
> * Phi node sources
>
Added
> * Parallel copy entries
>
I don't think we're validating anything for parallel copies right now. It
would be nice to, but there's no real good way to do so since they
I think we're missing a few things:
* Phi node sources
* Parallel copy entries
Whether you care enough to validate those is up to you. Otherwise
Reviewed-by: Connor Abbott
On Tue, Dec 16, 2014 at 1:05 AM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir_validate.c | 13 +
> 1 file
On Wed, Dec 17, 2014 at 3:30 PM, Connor Abbott wrote:
>
> Whew! Other than a few minor things below,
>
> Reviewed-by: Connor Abbott
>
> I tried to understand it all as much as I could, but it is rather
> tricky... but I can't suggest anything to make it easier to
> understand, after all the paper
On 12/17/2014 12:51 PM, Timothy Arceri wrote:
> It turns out Mesa hasn't compiled on less
> then 4.2 for a while so update conf to
> reflect this.
This and patch 3 could probably be squashed, but meh.
Series is
Reviewed-by: Ian Romanick
> Signed-off-by: Timothy Arceri
> ---
> configure.ac |
On Sat, Dec 13, 2014 at 6:42 AM, Brian Paul wrote:
>
> One of the two new functions in GL_ARB_get_texture_sub_image.
> ---
> src/mesa/main/texgetimage.c | 305
> ++--
> src/mesa/main/texgetimage.h | 8 ++
> 2 files changed, 277 insertions(+), 36 deletions
On Wed, Dec 17, 2014 at 6:02 PM, Jason Ekstrand wrote:
>
>
> On Wed, Dec 17, 2014 at 2:26 PM, Connor Abbott wrote:
>>
>> On Wed, Dec 17, 2014 at 5:20 PM, Jason Ekstrand
>> wrote:
>> >
>> >
>> > On Wed, Dec 17, 2014 at 1:10 PM, Jason Ekstrand
>> > wrote:
>> >>
>> >>
>> >>
>> >> On Wed, Dec 17, 2
On Wed, Dec 17, 2014 at 5:59 PM, Jason Ekstrand wrote:
>
>
> On Wed, Dec 17, 2014 at 11:51 AM, Connor Abbott wrote:
>>
>> One thing I'm a little worried about is that passes might forget to
>> require the right metadata, and they'll just happen to work since the
>> pass before also requires the s
Whew! Other than a few minor things below,
Reviewed-by: Connor Abbott
I tried to understand it all as much as I could, but it is rather
tricky... but I can't suggest anything to make it easier to
understand, after all the paper itself is rather tricky and your
comments help a lot. If anyone has
On Wed, Dec 17, 2014 at 11:51 AM, Connor Abbott wrote:
> One thing I'm a little worried about is that passes might forget to
> require the right metadata, and they'll just happen to work since the
> pass before also requires the same metadata and preserves it. I think
> a good thing to do to comba
On Wed, Dec 17, 2014 at 2:26 PM, Connor Abbott wrote:
>
> On Wed, Dec 17, 2014 at 5:20 PM, Jason Ekstrand
> wrote:
> >
> >
> > On Wed, Dec 17, 2014 at 1:10 PM, Jason Ekstrand
> > wrote:
> >>
> >>
> >>
> >> On Wed, Dec 17, 2014 at 12:07 PM, Connor Abbott
> >> wrote:
> >>>
> >>> On Tue, Dec 16, 2
On Wed, Dec 17, 2014 at 11:51 AM, Connor Abbott wrote:
>
> One thing I'm a little worried about is that passes might forget to
> require the right metadata, and they'll just happen to work since the
> pass before also requires the same metadata and preserves it. I think
> a good thing to do to com
The new name is a little longer but less confusing.
---
src/glsl/nir/nir.c| 2 +-
src/glsl/nir/nir.h| 2 +-
src/glsl/nir/nir_from_ssa.c | 2 +-
src/glsl/nir/nir_live_variables.c | 2 +-
src/glsl/nir/nir_opt_dce.c| 2 +-
5 files changed, 5 insertions(+)
On Tue, Dec 16, 2014 at 1:05 AM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir.c | 45 -
> src/glsl/nir/nir.h | 23 +++
> src/glsl/nir/nir_print.c | 21 +
> 3 files changed, 88 insertions(+), 1 deleti
On Wed, Dec 17, 2014 at 5:20 PM, Jason Ekstrand wrote:
>
>
> On Wed, Dec 17, 2014 at 1:10 PM, Jason Ekstrand
> wrote:
>>
>>
>>
>> On Wed, Dec 17, 2014 at 12:07 PM, Connor Abbott
>> wrote:
>>>
>>> On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand
>>> wrote:
>>> > From: Connor Abbott
>>> >
>>> > -
On Wed, Dec 17, 2014 at 5:11 PM, Jason Ekstrand wrote:
> On Wed, Dec 17, 2014 at 1:52 PM, Connor Abbott wrote:
>>
>> I'm sure you're already aware, but there are two things we could do to
>> speed this up:
>>
>> 1. Pre-compute def/kill sets for each block similar to what i965 does.
>
>
> Sure, bu
On Wed, Dec 17, 2014 at 1:10 PM, Jason Ekstrand
wrote:
>
>
>
> On Wed, Dec 17, 2014 at 12:07 PM, Connor Abbott
> wrote:
>>
>> On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand
>> wrote:
>> > From: Connor Abbott
>> >
>> > ---
>> > src/glsl/Makefile.sources | 1 +
>> > src/glsl/nir/n
On Wed, Dec 17, 2014 at 1:52 PM, Connor Abbott wrote:
>
> I'm sure you're already aware, but there are two things we could do to
> speed this up:
>
> 1. Pre-compute def/kill sets for each block similar to what i965 does.
>
Sure, but we walk the instructions at most deepest block depth + 1 and the
On Wed, Dec 17, 2014 at 1:52 PM, Connor Abbott wrote:
>
> I'm sure you're already aware, but there are two things we could do to
> speed this up:
>
> 1. Pre-compute def/kill sets for each block similar to what i965 does.
> 2. Use a worklist + an array of flags for "this block is in the
> worklist"
On Thu, 2014-12-18 at 08:46 +1100, Timothy Arceri wrote:
> On Wed, 2014-12-17 at 13:15 -0800, Matt Turner wrote:
> > On Wed, Dec 17, 2014 at 12:51 PM, Timothy Arceri
> > wrote:
> > > It turns out Mesa hasn't compiled on less
> > > then 4.2 for a while so update conf to
> > > reflect this.
> >
>
I'm sure you're already aware, but there are two things we could do to
speed this up:
1. Pre-compute def/kill sets for each block similar to what i965 does.
2. Use a worklist + an array of flags for "this block is in the
worklist" rather than walking all the basic blocks in reverse to find
the few
On Wed, 2014-12-17 at 13:15 -0800, Matt Turner wrote:
> On Wed, Dec 17, 2014 at 12:51 PM, Timothy Arceri
> wrote:
> > It turns out Mesa hasn't compiled on less
> > then 4.2 for a while so update conf to
> > reflect this.
>
> The first two are:
>
> Reviewed-by: Matt Turner
>
> and the last is
This patch needs to get renamed, probably something like "nir: set
reg_alloc and ssa_alloc when indexing registers and SSA values"
On Tue, Dec 16, 2014 at 1:05 AM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir.c | 3 +++
> src/glsl/nir/nir.h | 4 ++--
> 2 files changed, 5 insertions(+), 2 delet
On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote:
> Since we don't actually have an "if" instruction, this is a very common
> pattern when iterating over instructions. This adds a helper function for
> it to make things a little less painful.
> ---
> src/glsl/nir/nir.c | 17 +++
On Wed, Dec 17, 2014 at 12:51 PM, Timothy Arceri wrote:
> It turns out Mesa hasn't compiled on less
> then 4.2 for a while so update conf to
> reflect this.
The first two are:
Reviewed-by: Matt Turner
and the last is
Acked-by: Matt Turner
By the way, you seem to be manually line wrapping yo
On Wed, Dec 17, 2014 at 12:07 PM, Connor Abbott wrote:
>
> On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand
> wrote:
> > From: Connor Abbott
> >
> > ---
> > src/glsl/Makefile.sources | 1 +
> > src/glsl/nir/nir.h| 3 +
> > src/glsl/nir/nir_opt_copy_propagate.c
Sure, I can try and remember to do that.
On Wed, Dec 17, 2014 at 11:33 AM, Connor Abbott wrote:
>
> Sorry to ask, but... this one is so trivial and touches code that no
> earlier patch touches, why don't we just squash it into the commit
> that adds nir.c?
>
> On Tue, Dec 16, 2014 at 1:04 AM, Jas
Before, we were emitting the full pile of setup instructions for sample_id
and sample_pos every time they were used. With this commit, we emit them
in their own pass once at the beginning of the shader and simply emit uses
later on. When it comes time for setting up VS, we can put setup for its
s
Signed-off-by: Timothy Arceri
---
docs/relnotes/10.5.0.html | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/docs/relnotes/10.5.0.html b/docs/relnotes/10.5.0.html
index ed62248..381e02a 100644
--- a/docs/relnotes/10.5.0.html
+++ b/docs/relnotes/10.5.0.html
@@ -59,7 +59,7 @@ TBD
Signed-off-by: Timothy Arceri
---
src/gallium/include/pipe/p_compiler.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/include/pipe/p_compiler.h
b/src/gallium/include/pipe/p_compiler.h
index 939fb06..fb018bf 100644
--- a/src/gallium/include/pipe/p_compiler.h
+++
It turns out Mesa hasn't compiled on less
then 4.2 for a while so update conf to
reflect this.
Signed-off-by: Timothy Arceri
---
configure.ac | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/configure.ac b/configure.ac
index fdb7676..c8723ef 100644
--- a/configure.ac
+++
https://bugs.freedesktop.org/show_bug.cgi?id=86594
Ian Romanick changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote:
> From: Connor Abbott
>
> ---
> src/glsl/Makefile.sources | 1 +
> src/glsl/nir/nir.h| 3 +
> src/glsl/nir/nir_opt_copy_propagate.c | 313
> ++
> 3 files changed, 317 inser
https://bugs.freedesktop.org/show_bug.cgi?id=86701
Link Mauve changed:
What|Removed |Added
Hardware|Other |All
Version|git
One thing I'm a little worried about is that passes might forget to
require the right metadata, and they'll just happen to work since the
pass before also requires the same metadata and preserves it. I think
a good thing to do to combat this is to have a debug mode that dirties
*all* the metadata i
Needed for GL_ARB_get_texture_sub_image. But at this point, the
offsets are always zero and the sizes match the whole texture image.
v2: Fixes, suggestions from Laura Ekstrand:
* Fix calls to ctx->Driver.UnmapTextureImage() to pass the correct
slice value.
* Added comments and assertions to che
On 12/16/2014 03:22 PM, Laura Ekstrand wrote:
On Sat, Dec 13, 2014 at 6:42 AM, Brian Paul mailto:bri...@vmware.com>> wrote:
Needed for GL_ARB_get_texture_sub_image. But at this point, the
offsets are always zero and the sizes match the whole texture image.
---
src/mesa/main/
On 12/16/2014 12:56 PM, Laura Ekstrand wrote:
On Sat, Dec 13, 2014 at 6:42 AM, Brian Paul mailto:bri...@vmware.com>> wrote:
In preparation for getting texture sub images.
---
src/mesa/drivers/common/meta.c | 88
+-
src/mesa/drivers
Sorry to ask, but... this one is so trivial and touches code that no
earlier patch touches, why don't we just squash it into the commit
that adds nir.c?
On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote:
> ---
> src/glsl/nir/nir.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/
https://bugs.freedesktop.org/show_bug.cgi?id=86944
Jason Ekstrand changed:
What|Removed |Added
CC|ja...@jlekstrand.net|
--
You are receiving this mail becaus
https://bugs.freedesktop.org/show_bug.cgi?id=86944
José Fonseca changed:
What|Removed |Added
Assignee|jfons...@vmware.com |mesa-dev@lists.freedesktop.
On 12/17/2014 12:45 PM, Eero Tamminen wrote:
Hi,
On 12/16/2014 08:30 PM, Mario Kleiner wrote:
On 12/16/2014 09:23 AM, Keith Packard wrote:
Mario Kleiner writes:
The 0 case is good for benchmarking.
Sure, but the current code does benchmarking just fine. In fact,
because
it doesn't copy qu
On Dec 17, 2014 4:52 AM, "Iago Toral" wrote:
>
> On Wed, 2014-12-17 at 03:51 -0800, Jason Ekstrand wrote:
> >
> >
> >
> >
> >
> > On Tue, Dec 16, 2014 at 11:37 PM, Iago Toral
> > wrote:
> > On Tue, 2014-12-16 at 10:54 -0800, Jason Ekstrand wrote:
> > >
> > >
> > >
On Dec 17, 2014 7:43 AM, "Connor Abbott" wrote:
>
> On Wed, Dec 17, 2014 at 6:52 AM, Jason Ekstrand
wrote:
> >
> >
> > On Tue, Dec 16, 2014 at 10:31 PM, Connor Abbott
wrote:
> >>
> >> As a future cleanup, would it be worth getting rid of fddx and fddy
> >> entirely and just generating the correc
Reviewed-by: Jason Ekstrand
On Dec 17, 2014 5:26 AM, "Matt Turner" wrote:
> Reviewed-by: Matt Turner
>
> Thanks Iago!
> ___
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>
___
On Wed, Dec 17, 2014 at 07:39:21AM -0800, Matt Turner wrote:
> On Wed, Dec 17, 2014 at 7:28 AM, Jonathan Gray wrote:
> > On Thu, Dec 18, 2014 at 12:26:10AM +1100, Timothy Arceri wrote:
> >> On Tue, 2014-12-16 at 22:58 -0800, Vinson Lee wrote:
> >> > On Mon, Dec 15, 2014 at 6:23 PM, Jonathan Gray
On Wed, Dec 17, 2014 at 7:04 AM, Jason Ekstrand wrote:
>
>
> On Tue, Dec 16, 2014 at 10:58 PM, Connor Abbott wrote:
>>
>> On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand
>> wrote:
>> > ---
>> > src/glsl/Makefile.sources| 1 +
>> > src/glsl/nir/nir.c | 19 +++-
>> > sr
On Wed, Dec 17, 2014 at 6:52 AM, Jason Ekstrand wrote:
>
>
> On Tue, Dec 16, 2014 at 10:31 PM, Connor Abbott wrote:
>>
>> As a future cleanup, would it be worth getting rid of fddx and fddy
>> entirely and just generating the correct variant based on the
>> glHint/drirc configuration?
>
>
> Nope.
On Wed, Dec 17, 2014 at 7:28 AM, Jonathan Gray wrote:
> On Thu, Dec 18, 2014 at 12:26:10AM +1100, Timothy Arceri wrote:
>> On Tue, 2014-12-16 at 22:58 -0800, Vinson Lee wrote:
>> > On Mon, Dec 15, 2014 at 6:23 PM, Jonathan Gray wrote:
>> > > On Sat, Dec 13, 2014 at 09:09:27PM +1100, Timothy Arcer
On Thu, Dec 18, 2014 at 12:26:10AM +1100, Timothy Arceri wrote:
> On Tue, 2014-12-16 at 22:58 -0800, Vinson Lee wrote:
> > On Mon, Dec 15, 2014 at 6:23 PM, Jonathan Gray wrote:
> > > On Sat, Dec 13, 2014 at 09:09:27PM +1100, Timothy Arceri wrote:
> > >> On Fri, 2014-12-12 at 07:01 -0600, kallisti5
On Wed, Dec 17, 2014 at 4:04 AM, Jason Ekstrand wrote:
> On Tue, Dec 16, 2014 at 10:58 PM, Connor Abbott wrote:
>> On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand
>> wrote:
>> > +/**
>> > + * Various bits of metadata that can may be created or required by
>> > + * optimization and analysis passe
On Tuesday 16 December 2014, Laura Ekstrand wrote:
> ---
> src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 ++
> src/mesa/main/texobj.c | 109
> +++--
> src/mesa/main/texobj.h | 2 +
> 3 files changed, 92 insertions(+), 27
Reviewed-by: Matt Turner
Thanks Iago!
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Tue, 2014-12-16 at 22:58 -0800, Vinson Lee wrote:
> On Mon, Dec 15, 2014 at 6:23 PM, Jonathan Gray wrote:
> > On Sat, Dec 13, 2014 at 09:09:27PM +1100, Timothy Arceri wrote:
> >> On Fri, 2014-12-12 at 07:01 -0600, kallisti5 wrote:
> >> > On 2014-12-12 05:46, Timothy Arceri wrote:
> >> > > Signe
Commit 0ae9ca12a8 put source modifiers out of the bitcast operations
by adding a MOV operation that would handle them separately. It missed
the case of ceil though: the implementation negates both its source and
destination operands. The source operand will be used for RNDD, which
we can handle nor
On Wed, 2014-12-17 at 04:19 -0800, Jason Ekstrand wrote:
> On Wed, Dec 17, 2014 at 1:24 AM, Iago Toral Quiroga
> wrote:
> Commit 0ae9ca12a8 put source modifiers out of the bitcast
> operations
> by adding a MOV operation that would handle them separately.
> It misse
On Wed, 2014-12-17 at 03:51 -0800, Jason Ekstrand wrote:
>
>
>
>
>
> On Tue, Dec 16, 2014 at 11:37 PM, Iago Toral
> wrote:
> On Tue, 2014-12-16 at 10:54 -0800, Jason Ekstrand wrote:
> >
> >
> > On Tue, Dec 16, 2014 at 4:01 AM, Iago Toral
> wrote:
>
How about using below subject?
i965: intel_get_tex_image() now accepts TEXTURE_CUBE_MAP as a valid target
It's more specific than using a file name. I'll leave it up to you if
you want to make this change.
On Tue, Dec 16, 2014 at 6:52 AM, Laura Ekstrand wrote:
> ARB_DIRECT_STATE_ACCESS permits t
On Wed, Dec 17, 2014 at 1:24 AM, Iago Toral Quiroga
wrote:
>
> Commit 0ae9ca12a8 put source modifiers out of the bitcast operations
> by adding a MOV operation that would handle them separately. It missed
> the case of ceil though, which negates both its source and destination
> operands.
>
> Fixe
On Tue, Dec 16, 2014 at 10:58 PM, Connor Abbott wrote:
>
> On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand
> wrote:
> > ---
> > src/glsl/Makefile.sources| 1 +
> > src/glsl/nir/nir.c | 19 +++-
> > src/glsl/nir/nir.h | 21 --
> > src/glsl/nir/
On Tue, Dec 16, 2014 at 10:31 PM, Connor Abbott wrote:
>
> As a future cleanup, would it be worth getting rid of fddx and fddy
> entirely and just generating the correct variant based on the
> glHint/drirc configuration?
>
Nope. https://www.opengl.org/registry/specs/ARB/derivative_control.txt
On Tue, Dec 16, 2014 at 11:37 PM, Iago Toral wrote:
>
> On Tue, 2014-12-16 at 10:54 -0800, Jason Ekstrand wrote:
> >
> >
> > On Tue, Dec 16, 2014 at 4:01 AM, Iago Toral wrote:
> > On Tue, 2014-12-16 at 08:29 +0100, Iago Toral wrote:
> > > On Mon, 2014-12-15 at 10:19 -0800, Jason E
Keep the subject of commit message short (under 50 chars) and use present tense.
Here you can use "mesa: Add utility function _mesa_lookup_texture_error()".
On Tue, Dec 16, 2014 at 6:52 AM, Laura Ekstrand wrote:
> Most ARB_DIRECT_STATE_ACCESS functions take an object's ID and use it to look
> up
Hi,
On 12/16/2014 08:30 PM, Mario Kleiner wrote:
On 12/16/2014 09:23 AM, Keith Packard wrote:
Mario Kleiner writes:
The 0 case is good for benchmarking.
Sure, but the current code does benchmarking just fine. In fact, because
it doesn't copy queued frames that aren't the most recent before
https://bugs.freedesktop.org/show_bug.cgi?id=87407
Andrés Gómez García changed:
What|Removed |Added
Status|NEW |ASSIGNED
CC|
1 - 100 of 103 matches
Mail list logo
