Re: [Mesa-dev] [PATCH v3 09/28] mesa: Add RGBA to Luminance conversion helpers

2014-12-16 Thread Iago Toral
On Tue, 2014-12-16 at 10:54 -0800, Jason Ekstrand wrote: > > > On Tue, Dec 16, 2014 at 4:01 AM, Iago Toral wrote: > On Tue, 2014-12-16 at 08:29 +0100, Iago Toral wrote: > > On Mon, 2014-12-15 at 10:19 -0800, Jason Ekstrand wrote: > > > > > > > > > On Mon,

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-12-16 Thread Mathias Fröhlich
Hi, On Tuesday, December 16, 2014 19:30:04 Mario Kleiner wrote: > Hmm. For benchmarking i think i'd consider that a mild form of cheating. > You get higher fps because you skip processing like the whole gpu blit > overhead and host processing overhead for queuing / validating / > processing th

Re: [Mesa-dev] [PATCH 000/123] Reintroducing NIR, a new IR for mesa

2014-12-16 Thread Connor Abbott
Patches 23-26, 28, 30-35, 37-38, 40, (41 gets killed later so I didn't review it), 42-44 are Reviewed-by: Connor Abbott I'm going to bed now, but I'll try to do some more later. On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote: > NIR (pronounced "ner") is a new IR (internal representation

Re: [Mesa-dev] [RFC 6/8] mesa: remove support for GCC older than 4.1.0

2014-12-16 Thread Vinson Lee
On Mon, Dec 15, 2014 at 6:23 PM, Jonathan Gray wrote: > On Sat, Dec 13, 2014 at 09:09:27PM +1100, Timothy Arceri wrote: >> On Fri, 2014-12-12 at 07:01 -0600, kallisti5 wrote: >> > On 2014-12-12 05:46, Timothy Arceri wrote: >> > > Signed-off-by: Timothy Arceri >> > > --- >> > > src/mesa/main/comp

Re: [Mesa-dev] [PATCH 045/133] nir: Add a basic metadata management system

2014-12-16 Thread Connor Abbott
On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote: > --- > src/glsl/Makefile.sources| 1 + > src/glsl/nir/nir.c | 19 +++- > src/glsl/nir/nir.h | 21 -- > src/glsl/nir/nir_dominance.c | 6 ++--- > src/glsl/nir/nir_metadata.c | 52 > +

Re: [Mesa-dev] [PATCH 037/133] nir: Add NIR_TRUE and NIR_FALSE constants and use them for boolean immediates

2014-12-16 Thread Connor Abbott
To be fully correct here, we should be plumbing through ctx->Const.NativeIntegers and setting it to 1.0f if that's false, but other things are already broken for hw without native integers so that can probably wait. Still, might be worth adding a TODO. In any case, Reviewed-by: Connor Abbott On

Re: [Mesa-dev] [PATCH 031/133] nir: Add fine and coarse derivative opcodes

2014-12-16 Thread Connor Abbott
As a future cleanup, would it be worth getting rid of fddx and fddy entirely and just generating the correct variant based on the glHint/drirc configuration? On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_opcodes.h | 4 > 1 file changed, 4 insertions(+) > >

Re: [Mesa-dev] [PATCH 029/133] i965/fs_nir: Add support for sample_pos and sample_id

2014-12-16 Thread Jason Ekstrand
On Dec 16, 2014 10:15 PM, "Connor Abbott" wrote: > > On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote: > > --- > > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 17 ++--- > > 1 file changed, 14 insertions(+), 3 deletions(-) > > > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.

Re: [Mesa-dev] [PATCH 029/133] i965/fs_nir: Add support for sample_pos and sample_id

2014-12-16 Thread Connor Abbott
On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 17 ++--- > 1 file changed, 14 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > b/src/mesa/drivers/dri/i965/brw_fs_nir.cpp > index 22f4c0

Re: [Mesa-dev] [PATCH 025/133] i965/fs_nir: Use the correct types for texture inputs

2014-12-16 Thread Connor Abbott
I know I had another solution to this problem, but... meh. I don't particularly care what solution gets chosen. Reviewed-by: Connor Abbott On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote: > --- > src/mesa/drivers/dri/i965/brw_fs_nir.cpp | 32 > +--- > 1 file

[Mesa-dev] [Bug 87371] brw_vec4_visitor.cpp:2435: undefined reference to `_mesa_get_sampler_uniform_value'

2014-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87371 Vinson Lee changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 000/123] Reintroducing NIR, a new IR for mesa

2014-12-16 Thread Connor Abbott
Oh, I forgot... patch 20 should probably get cherry-picked as well. On Tue, Dec 16, 2014 at 6:01 PM, Jason Ekstrand wrote: > > > On Tue, Dec 16, 2014 at 2:52 PM, Connor Abbott wrote: >> >> Hi, >> >> On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand >> wrote: >> > NIR (pronounced "ner") is a new I

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-12-16 Thread Mario Kleiner
On 12/17/2014 05:49 AM, Keith Packard wrote: Mario Kleiner writes: It's just that i need access to both, the old behaviour i described, and the new "drop frame" behaviour, and i need a way to select what i want at runtime via api without the need for easily overwhelmed and confused users to ch

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2014-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Alexandre Demers changed: What|Removed |Added CC||alexandre.f.dem...@gmail.co

Re: [Mesa-dev] [PATCH] glsl: fix stale comment

2014-12-16 Thread Kenneth Graunke
On Tuesday, December 16, 2014 10:32:21 PM Connor Abbott wrote: > Signed-off-by: Connor Abbott > --- > src/glsl/ir_function_can_inline.cpp | 9 - > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/src/glsl/ir_function_can_inline.cpp > b/src/glsl/ir_function_can_inline.cpp

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-12-16 Thread Keith Packard
Mario Kleiner writes: > It's just that i need access to both, the old behaviour i described, and > the new "drop frame" behaviour, and i need a way to select what i want > at runtime via api without the need for easily overwhelmed and confused > users to change config files or environment vari

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-12-16 Thread Mario Kleiner
On 12/17/2014 04:17 AM, Keith Packard wrote: Mario Kleiner writes: Hmm. For benchmarking i think i'd consider that a mild form of cheating. You get higher fps because you skip processing like the whole gpu blit overhead and host processing overhead for queuing / validating / processing the cop

[Mesa-dev] [PATCH] glsl: fix stale comment

2014-12-16 Thread Connor Abbott
Signed-off-by: Connor Abbott --- src/glsl/ir_function_can_inline.cpp | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/src/glsl/ir_function_can_inline.cpp b/src/glsl/ir_function_can_inline.cpp index 7b15d5d..3b1d15f 100644 --- a/src/glsl/ir_function_can_inline.cpp +++

[Mesa-dev] R600 atomics integration

2014-12-16 Thread Aditya Avinash
Hi, I am trying to integrate atomic counters to Mesa. I was able to do until pipes (with the help of Marek and Ilia). How to integrate them to R600? Thank you! -- Regards, *Aditya Atluri,* *USA.* ___ mesa-dev mailing list mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-12-16 Thread Keith Packard
Mario Kleiner writes: > Hmm. For benchmarking i think i'd consider that a mild form of cheating. > You get higher fps because you skip processing like the whole gpu blit > overhead and host processing overhead for queuing / validating / > processing the copy command in the command stream, so t

Re: [Mesa-dev] [PATCH 020/133] i965/fs: make emit_fragcoord_interpolation() more general

2014-12-16 Thread Jason Ekstrand
Sure On Dec 16, 2014 10:17 AM, "Connor Abbott" wrote: > When Ken rebased my texture patches, he changed the titles to say > "make thing() not take an ir_variable", which I like. Can you change > the title of this one too? > > On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand > wrote: > > From: Con

[Mesa-dev] [PATCH v2] glsl: Reduce memory consumption of copy propagation passes.

2014-12-16 Thread Kenneth Graunke
opt_copy_propagation and opt_copy_propagation_elements create new ACP and Kill sets each time they enter a new control flow block. For if blocks, they also copy the entire existing ACP set contents into the new set. When we exit the control flow block, we discard the new sets. However, we weren'

[Mesa-dev] [PATCH] glsl: Reduce memory consumption of opt_copy_propagation_elements().

2014-12-16 Thread Kenneth Graunke
opt_copy_propagation_elements creates new ACP and Kill sets each time it enters a new control flow block (if, loop, or function). For if blocks, it additionally copies the entire existing ACP set into the new one. We discard those sets when exiting the control flow block, but didn't actually free

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2014-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Chris Forbes changed: What|Removed |Added Depends on||87389 -- You are receiving this mail bec

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2014-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Bug 77449 depends on bug 83908, which changed state. Bug 83908 Summary: [i965] Incorrect icon colors in Steam Big Picture https://bugs.freedesktop.org/show_bug.cgi?id=83908 What|Removed |Added --

Re: [Mesa-dev] [PATCH 136/133] nir/opcodes: Remove the per_component info field

2014-12-16 Thread Connor Abbott
On Tue, Dec 16, 2014 at 5:53 PM, Jason Ekstrand wrote: > Originally, this field was intended for determining if the given > instruction acted per-component or if it had mismatching source and > destination sizes that would have to be interpreted specially. However, we > can easily derive this fro

Re: [Mesa-dev] [PATCH 005/133] nir: add core helper functions

2014-12-16 Thread Eric Anholt
Jason Ekstrand writes: > From: Connor Abbott > > These include functions for adding and removing various bits of IR and > helpers for iterating over all the sources and destinations of an > instruction. This is similar to ir.cpp. > +nir_function_overload * > +nir_function_overload_create(nir_fu

Re: [Mesa-dev] [PATCH 1/1] util: Silence signed-unsigned comparison warnings

2014-12-16 Thread Jan Vesely
On Fri, 2014-12-12 at 17:30 +, Jose Fonseca wrote: > On 11/12/14 20:05, Jan Vesely wrote: > > Signed-off-by: Jan Vesely > > --- > > src/util/register_allocate.c | 12 ++-- > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/src/util/register_allocate.c b/src/uti

Re: [Mesa-dev] [PATCH v2] i965: remove includes of sampler.h from extern "C" blocks

2014-12-16 Thread Ian Romanick
Tested-by: Ian Romanick On 12/16/2014 02:29 PM, Mark Janes wrote: > C linkage was removed from functions in program/sampler.cpp. However, > some cpp files include program/sampler.h within extern "C" blocks, > causing link errors for test_vec4_copy_propagation. > --- > src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH v2] i965: remove includes of sampler.h from extern "C" blocks

2014-12-16 Thread Brian Paul
On 12/16/2014 03:29 PM, Mark Janes wrote: C linkage was removed from functions in program/sampler.cpp. However, some cpp files include program/sampler.h within extern "C" blocks, causing link errors for test_vec4_copy_propagation. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- src

Re: [Mesa-dev] [PATCH 004/133] nir: add the core datastructures

2014-12-16 Thread Connor Abbott
On Tue, Dec 16, 2014 at 5:48 PM, Eric Anholt wrote: > Jason Ekstrand writes: > >> From: Connor Abbott >> >> This includes all the instructions, ifs, loops, functions, etc. This is >> similar to the information in ir.h. >> >> v2: Jason Ekstrand : >>Include ralloc and hash_table from the util

Re: [Mesa-dev] [PATCH 000/123] Reintroducing NIR, a new IR for mesa

2014-12-16 Thread Jason Ekstrand
On Tue, Dec 16, 2014 at 2:52 PM, Connor Abbott wrote: > > Hi, > > On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand > wrote: > > NIR (pronounced "ner") is a new IR (internal representation) for the Mesa > > shader compiler that will sit between the old IR (GLSL IR) and back-end > > compilers. The

Re: [Mesa-dev] [PATCH 059/133] glsl/list: Fix the exec_list_validate function

2014-12-16 Thread Jason Ekstrand
On Tue, Dec 16, 2014 at 2:49 PM, Connor Abbott wrote: > > On Tue, Dec 16, 2014 at 1:05 AM, Jason Ekstrand > wrote: > > Some time while refactoring things to make it look nicer before pushing > to > > master, I completely broke the function. This fixes it to be correct. > > Just goes to show you

[Mesa-dev] [PATCH 134/133] nir/opcodes: Add algebraic properties metadata

2014-12-16 Thread Jason Ekstrand
This commit adds some algebraic properties to the metadata of each opcode in NIR. In particular, you now know, just from the metadata, if a given opcode is commutative or associative. This will be useful for algebraic transformation passes that want to be able to match a + b as well as b + a in o

[Mesa-dev] [PATCH 135/133] nir/search: Use nir_op_infos to determine if an operation is commutative

2014-12-16 Thread Jason Ekstrand
Prior to this commit, we had a big switch statement for this. Now it's baked into the opcode metadata so we can just use that. --- src/glsl/nir/nir_search.c | 35 ++- 1 file changed, 2 insertions(+), 33 deletions(-) diff --git a/src/glsl/nir/nir_search.c b/src/gls

[Mesa-dev] [PATCH 136/133] nir/opcodes: Remove the per_component info field

2014-12-16 Thread Jason Ekstrand
Originally, this field was intended for determining if the given instruction acted per-component or if it had mismatching source and destination sizes that would have to be interpreted specially. However, we can easily derive this from output_size == 0, so it's not really that useful. Also, the v

Re: [Mesa-dev] [PATCH 000/123] Reintroducing NIR, a new IR for mesa

2014-12-16 Thread Connor Abbott
Hi, On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote: > NIR (pronounced "ner") is a new IR (internal representation) for the Mesa > shader compiler that will sit between the old IR (GLSL IR) and back-end > compilers. The primary purpose of NIR is to be more efficient for doing > optimizatio

Re: [Mesa-dev] [PATCH 059/133] glsl/list: Fix the exec_list_validate function

2014-12-16 Thread Connor Abbott
On Tue, Dec 16, 2014 at 1:05 AM, Jason Ekstrand wrote: > Some time while refactoring things to make it look nicer before pushing to > master, I completely broke the function. This fixes it to be correct. > Just goes to show you why you souldn't push code that has no users yet... > > Signed-off-by

Re: [Mesa-dev] [PATCH 004/133] nir: add the core datastructures

2014-12-16 Thread Eric Anholt
Jason Ekstrand writes: > From: Connor Abbott > > This includes all the instructions, ifs, loops, functions, etc. This is > similar to the information in ir.h. > > v2: Jason Ekstrand : >Include ralloc and hash_table from the util directory Just some comment comments. I've been happy with NI

Re: [Mesa-dev] [PATCH 065/133] glsl/list: Add a foreach_list_typed_safe_reverse macro

2014-12-16 Thread Connor Abbott
On Tue, Dec 16, 2014 at 1:05 AM, Jason Ekstrand wrote: > --- > src/glsl/list.h | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/glsl/list.h b/src/glsl/list.h > index 4774ccc..330c17e 100644 > --- a/src/glsl/list.h > +++ b/src/glsl/list.h > @@ -678,4 +678,13 @@ inline void exe

[Mesa-dev] Fixes to build Mesa 10.4 against LLVM 3.5 on windows

2014-12-16 Thread Rob Conde
I built Mesa 10.4 with LLVM 3.5 today and I had to make a couple of fixes to get it to work: 1. root\src\mesa\compiler.h After: #include "c99_compat.h" /* inline, __func__, etc. */ Add: #ifdef _MSC_VER #define __attribute__(a) #endif Otherwise you get a compile error in root\build\windo

Re: [Mesa-dev] [PATCH 022/133] i965/fs: add a NIR frontend

2014-12-16 Thread Connor Abbott
On Tue, Dec 16, 2014 at 5:22 PM, Jason Ekstrand wrote: > > > On Tue, Dec 16, 2014 at 1:28 PM, Connor Abbott wrote: >> >> On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand >> wrote: >> > From: Connor Abbott >> > >> > This is similar to the GLSL IR frontend, except consuming NIR. This lets >> > us

[Mesa-dev] [PATCH v2] i965: remove includes of sampler.h from extern "C" blocks

2014-12-16 Thread Mark Janes
C linkage was removed from functions in program/sampler.cpp. However, some cpp files include program/sampler.h within extern "C" blocks, causing link errors for test_vec4_copy_propagation. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 +- src/mesa/drivers/dri/i965/brw_fs.h |

Re: [Mesa-dev] [PATCH 04/11] mesa: plumb offset/size parameters through GetTexImage code

2014-12-16 Thread Laura Ekstrand
On Sat, Dec 13, 2014 at 6:42 AM, Brian Paul wrote: > > Needed for GL_ARB_get_texture_sub_image. But at this point, the > offsets are always zero and the sizes match the whole texture image. > --- > src/mesa/main/texgetimage.c | 105 > > 1 file changed

Re: [Mesa-dev] [PATCH 039/133] i965/fs: Don't take an ir_variable for emit_general_interpolation

2014-12-16 Thread Connor Abbott
On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote: > Previously, emit_general_interpolation took an ir_variable and pulled the > information it needed from that. This meant that in fs_fp, we were > constructing a dummy ir_variable just to pass into it. This commit makes > emit_general_interp

Re: [Mesa-dev] [PATCH 087/133] i965/fs_nir: Don't dump the shader.

2014-12-16 Thread Jason Ekstrand
On Tue, Dec 16, 2014 at 1:41 PM, Connor Abbott wrote: > > Can we squash this into wherever we introduced these print statements, > and instead port over Matt's i965 fs debugging infrastructure so we > can do this with an envvar enable, plus all the other goodies? > No, there isn't a single patch

Re: [Mesa-dev] [PATCH] program: use extern "C" where appropriate in sampler.cpp

2014-12-16 Thread Mark Janes
Brian Paul writes: > I don't think this is right. The functions in question are C++ > functions and they're only called from .cpp files. I don't see why > C-style linkage is desired. > > See https://bugs.freedesktop.org/show_bug.cgi?id=87371 for another > approach. Please test that patch if

Re: [Mesa-dev] [PATCH v2] mesa: Initializes the stencil value masks to 0xFF instead of ~0u

2014-12-16 Thread Ian Romanick
On 12/15/2014 11:58 PM, Eduardo Lima Mitev wrote: > On 12/15/2014 08:30 PM, Ian Romanick wrote: >> On 12/15/2014 08:04 AM, Eduardo Lima Mitev wrote: >>> >>> Since the maximum supported precision for stencil buffers is 8 bits, mask >>> values should be initialized to 2^8 - 1 = 0xFF. >>> >>> Currentl

Re: [Mesa-dev] [PATCH 087/133] i965/fs_nir: Don't dump the shader.

2014-12-16 Thread Connor Abbott
Can we squash this into wherever we introduced these print statements, and instead port over Matt's i965 fs debugging infrastructure so we can do this with an envvar enable, plus all the other goodies? On Tue, Dec 16, 2014 at 1:11 AM, Jason Ekstrand wrote: > This is killing piglit. I'll leave th

Re: [Mesa-dev] [PATCH] program: use extern "C" where appropriate in sampler.cpp

2014-12-16 Thread Brian Paul
On 12/16/2014 02:08 PM, Mark Janes wrote: `make check` fails to link test_vec4_copy_propagation after 6dac455e. --- src/mesa/program/sampler.cpp | 5 ++--- src/mesa/program/sampler.h | 7 +++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/sampler.cpp b/s

Re: [Mesa-dev] [PATCH 022/133] i965/fs: add a NIR frontend

2014-12-16 Thread Connor Abbott
On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote: > From: Connor Abbott > > This is similar to the GLSL IR frontend, except consuming NIR. This lets > us test NIR as part of an actual compiler. > > v2: Jason Ekstrand : >Make brw_fs_nir build again >Only use NIR of INTEL_USE_NIR is se

Re: [Mesa-dev] [PATCH 027/133] Fix what I think are a few NIR typos

2014-12-16 Thread Jason Ekstrand
On Dec 16, 2014 10:10 AM, "Connor Abbott" wrote: > > On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote: > > --- > > src/glsl/nir/nir_opcodes.h| 6 +++--- > > src/glsl/nir/nir_opt_copy_propagate.c | 2 +- > > 2 files changed, 4 insertions(+), 4 deletions(-) > > > > diff --git a/sr

[Mesa-dev] [PATCH] program: use extern "C" where appropriate in sampler.cpp

2014-12-16 Thread Mark Janes
`make check` fails to link test_vec4_copy_propagation after 6dac455e. --- src/mesa/program/sampler.cpp | 5 ++--- src/mesa/program/sampler.h | 7 +++ 2 files changed, 9 insertions(+), 3 deletions(-) diff --git a/src/mesa/program/sampler.cpp b/src/mesa/program/sampler.cpp index f8584c9..7754

Re: [Mesa-dev] [PATCH 01/11] meta: handle subimages in _mesa_meta_setup_texture_coords()

2014-12-16 Thread Laura Ekstrand
On Sat, Dec 13, 2014 at 6:42 AM, Brian Paul wrote: > > In preparation for getting texture sub images. > --- > src/mesa/drivers/common/meta.c | 88 > +- > src/mesa/drivers/common/meta.h | 4 ++ > src/mesa/drivers/common/meta_generate_mipmap.

Re: [Mesa-dev] [PATCH 01/11] meta: handle subimages in _mesa_meta_setup_texture_coords()

2014-12-16 Thread Laura Ekstrand
I will take a look soon. On Tue, Dec 16, 2014 at 7:52 AM, Brian Paul wrote: > > Ping. Could someone review this GL_ARB_get_texture_sub_image series? > > -Brian > > > On 12/13/2014 07:42 AM, Brian Paul wrote: > >> In preparation for getting texture sub images. >> --- >> src/mesa/drivers/common/

Re: [Mesa-dev] [PATCH 11/41] main: Added entry points for glTextureStorage*D.

2014-12-16 Thread Laura Ekstrand
This happens almost everywhere. I prefer to call _mesa_error(ctx, "glTex%sStorage" rather than _mesa_error(ctx, "%s" because it's more obvious when reading the code which API function you're in (texture storage rather than copy texture sub image, etc). Would this work better? const char

Re: [Mesa-dev] [PATCH v3 09/28] mesa: Add RGBA to Luminance conversion helpers

2014-12-16 Thread Jason Ekstrand
On Tue, Dec 16, 2014 at 4:01 AM, Iago Toral wrote: > > On Tue, 2014-12-16 at 08:29 +0100, Iago Toral wrote: > > On Mon, 2014-12-15 at 10:19 -0800, Jason Ekstrand wrote: > > > > > > > > > On Mon, Dec 15, 2014 at 3:12 AM, Iago Toral wrote: > > > On Fri, 2014-12-12 at 11:36 -0800, Jason Ekst

Re: [Mesa-dev] r600/sb loop issue

2014-12-16 Thread Vadim Girlin
On 12/16/2014 05:44 AM, Dave Airlie wrote: On 16 December 2014 at 08:59, Vadim Girlin wrote: On 12/16/2014 01:30 AM, Dave Airlie wrote: New patch is attached, the only difference is in the sb_sched.cpp (it disables copy coalescing for some "unsafe" cases, so it may leave more MOVs than prev

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-12-16 Thread Mario Kleiner
On 12/16/2014 09:23 AM, Keith Packard wrote: Mario Kleiner writes: The 0 case is good for benchmarking. Sure, but the current code does benchmarking just fine. In fact, because it doesn't copy queued frames that aren't the most recent before the vblank, benchmarks tend to run *faster* as a re

Re: [Mesa-dev] [PATCH 19/41] main: Added entry point for glTextureParameterfv.

2014-12-16 Thread Laura Ekstrand
No. I have a 78 column line highlight in my editor. On Tue, Dec 16, 2014 at 7:46 AM, Brian Paul wrote: > > On 12/15/2014 06:22 PM, Laura Ekstrand wrote: > >> --- >> src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++ >> src/mesa/main/texparam.c | 52 >> +

Re: [Mesa-dev] [PATCH 15/41] main: set_tex_parameteri now handles errors according to the OpenGL 4.5 Specification.

2014-12-16 Thread Laura Ekstrand
I discussed this with Ian Romanick, and he said to use the new OpenGL 4.3+ error behavior because it conforms and/or is generally consistent with the error behavior of OpenGL ES 3.1. This way, the driver will be prepared for upcoming OpenGL ES 3.1 conformance tests. Laura On Tue, Dec 16, 2014 at

Re: [Mesa-dev] [PATCH 020/133] i965/fs: make emit_fragcoord_interpolation() more general

2014-12-16 Thread Connor Abbott
When Ken rebased my texture patches, he changed the titles to say "make thing() not take an ir_variable", which I like. Can you change the title of this one too? On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote: > From: Connor Abbott > > --- > src/mesa/drivers/dri/i965/brw_fs.cpp |

Re: [Mesa-dev] [PATCH 027/133] Fix what I think are a few NIR typos

2014-12-16 Thread Connor Abbott
On Tue, Dec 16, 2014 at 1:04 AM, Jason Ekstrand wrote: > --- > src/glsl/nir/nir_opcodes.h| 6 +++--- > src/glsl/nir/nir_opt_copy_propagate.c | 2 +- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/glsl/nir/nir_opcodes.h b/src/glsl/nir/nir_opcodes.h > index 36a5

[Mesa-dev] [Bug 87371] brw_vec4_visitor.cpp:2435: undefined reference to `_mesa_get_sampler_uniform_value'

2014-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87371 Brian Paul changed: What|Removed |Added Attachment #110918|0 |1 is obsolete|

[Mesa-dev] [Bug 87371] brw_vec4_visitor.cpp:2435: undefined reference to `_mesa_get_sampler_uniform_value'

2014-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87371 --- Comment #1 from Brian Paul --- Created attachment 110918 --> https://bugs.freedesktop.org/attachment.cgi?id=110918&action=edit remove extern "C" stuff from brw_vec4_visitor.cpp Does this fix it, Vinson? -- You are receiving this mail bec

[Mesa-dev] [Bug 87371] brw_vec4_visitor.cpp:2435: undefined reference to `_mesa_get_sampler_uniform_value'

2014-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=87371 Bug ID: 87371 Summary: brw_vec4_visitor.cpp:2435: undefined reference to `_mesa_get_sampler_uniform_value' Product: Mesa Version: git Hardware: x86-64 (AMD64)

Re: [Mesa-dev] [PATCH 01/11] meta: handle subimages in _mesa_meta_setup_texture_coords()

2014-12-16 Thread Brian Paul
Ping. Could someone review this GL_ARB_get_texture_sub_image series? -Brian On 12/13/2014 07:42 AM, Brian Paul wrote: In preparation for getting texture sub images. --- src/mesa/drivers/common/meta.c | 88 +- src/mesa/drivers/common/meta.h

Re: [Mesa-dev] [PATCH 11/41] main: Added entry points for glTextureStorage*D.

2014-12-16 Thread Brian Paul
On 12/15/2014 06:22 PM, Laura Ekstrand wrote: --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 24 +++ src/mesa/main/texstorage.c | 205 +++-- src/mesa/main/texstorage.h | 31 3 files changed, 209 insertions(+), 51 deleti

Re: [Mesa-dev] [PATCH 14/41] main: Added entry point for BindTextureUnit.

2014-12-16 Thread Brian Paul
On 12/15/2014 06:22 PM, Laura Ekstrand wrote: The following preparations were made in texstate.c and texstate.h to better facilitate the BindTextureUnit function: Dylan Noblesmith: mesa: add _mesa_get_tex_unit() mesa: factor out _mesa_max_tex_unit() This is about to appear in a lot more places,

Re: [Mesa-dev] [PATCH 15/41] main: set_tex_parameteri now handles errors according to the OpenGL 4.5 Specification.

2014-12-16 Thread Brian Paul
On 12/15/2014 06:22 PM, Laura Ekstrand wrote: Beginning in the OpenGL 4.3 core specification, some error handling has changed. As an example, changing sampler states with a multisample target throws INVALID_ENUM rather than INVALID_OPERATION. So, does this effect any piglit tests? It seems a l

Re: [Mesa-dev] [PATCH 23/41] main: Added entry points for glGetTextureLevelParameteriv, fv.

2014-12-16 Thread Brian Paul
On 12/15/2014 06:22 PM, Laura Ekstrand wrote: --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 14 +++ src/mesa/main/texparam.c | 136 - src/mesa/main/texparam.h | 9 ++ 3 files changed, 131 insertions(+), 28 deletion

Re: [Mesa-dev] [PATCH 19/41] main: Added entry point for glTextureParameterfv.

2014-12-16 Thread Brian Paul
On 12/15/2014 06:22 PM, Laura Ekstrand wrote: --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++ src/mesa/main/texparam.c | 52 +++--- src/mesa/main/texparam.h | 8 3 files changed, 53 insertions(+), 13 deletions

Re: [Mesa-dev] [PATCH 04/41] main: Moved _mesa_lock_texture and _mesa_unlock_texture to texobj.h from teximage.h.

2014-12-16 Thread Brian Paul
On 12/15/2014 06:22 PM, Laura Ekstrand wrote: --- src/mesa/drivers/dri/i965/intel_tex_copy.c | 1 + src/mesa/drivers/dri/swrast/swrast.c | 1 + src/mesa/main/texgetimage.c| 2 +- src/mesa/main/teximage.h | 18 -- src/mesa/main/texob

Re: [Mesa-dev] [PATCH 27/41] main: Added entry points for CopyTextureSubImage*D.

2014-12-16 Thread Brian Paul
On 12/15/2014 06:22 PM, Laura Ekstrand wrote: --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 32 + src/mesa/main/teximage.c | 170 ++--- src/mesa/main/teximage.h | 21 +++ 3 files changed, 177 insertions(+), 46 delet

Re: [Mesa-dev] [PATCH 10/41] main: Added entry point for glCreateTextures.

2014-12-16 Thread Brian Paul
On 12/15/2014 06:22 PM, Laura Ekstrand wrote: --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 8 ++ src/mesa/main/texobj.c | 109 +++-- src/mesa/main/texobj.h | 2 + 3 files changed, 92 insertions(+), 27 deletions(-

Re: [Mesa-dev] [PATCH 18/41] main: Added entry point for glTextureParameterf.

2014-12-16 Thread Brian Paul
On 12/15/2014 06:22 PM, Laura Ekstrand wrote: --- src/mapi/glapi/gen/ARB_direct_state_access.xml | 6 +++ src/mesa/main/texparam.c | 52 +- src/mesa/main/texparam.h | 20 ++ 3 files changed, 68 insertions(+), 10 del

[Mesa-dev] [Bug 77449] Tracker bug for all bugs related to Steam titles

2014-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=77449 Neil Roberts changed: What|Removed |Added Depends on||87364 -- You are receiving this mail bec

Re: [Mesa-dev] [PATCH 01/11] mesa: put extern "C" in header files

2014-12-16 Thread Brian Paul
On 12/16/2014 04:57 AM, Jose Fonseca wrote: On 16/12/14 00:20, Brian Paul wrote: --- src/mesa/main/enums.h | 11 +++ src/mesa/main/samplerobj.h| 9 + src/mesa/main/texenvprogram.h | 11 +++ src/mesa/main/texobj.h| 10 ++ 4 files changed,

Re: [Mesa-dev] [PATCH v2] mesa: Initializes the stencil value masks to 0xFF instead of ~0u

2014-12-16 Thread Eduardo Lima Mitev
On 12/16/2014 01:18 PM, Olivier Galibert wrote: > Note that ~0U is perfectly correct w.r.t the GLES3 spec. It just > means that s=32, which happens to be greater or equal to 8. > True, it doesn't violate the spec. But since that causes the overflow (which is the original problem we are trying to

Re: [Mesa-dev] [PATCH v2] mesa: Initializes the stencil value masks to 0xFF instead of ~0u

2014-12-16 Thread Olivier Galibert
Note that ~0U is perfectly correct w.r.t the GLES3 spec. It just means that s=32, which happens to be greater or equal to 8. Best, OG. On Tue, Dec 16, 2014 at 8:58 AM, Eduardo Lima Mitev wrote: > On 12/15/2014 08:30 PM, Ian Romanick wrote: >> On 12/15/2014 08:04 AM, Eduardo Lima Mitev wrote

Re: [Mesa-dev] [PATCH v3 09/28] mesa: Add RGBA to Luminance conversion helpers

2014-12-16 Thread Iago Toral
On Tue, 2014-12-16 at 08:29 +0100, Iago Toral wrote: > On Mon, 2014-12-15 at 10:19 -0800, Jason Ekstrand wrote: > > > > > > On Mon, Dec 15, 2014 at 3:12 AM, Iago Toral wrote: > > On Fri, 2014-12-12 at 11:36 -0800, Jason Ekstrand wrote: > > > > > > > > > On Tue, De

Re: [Mesa-dev] [PATCH 01/11] mesa: put extern "C" in header files

2014-12-16 Thread Jose Fonseca
On 16/12/14 00:20, Brian Paul wrote: --- src/mesa/main/enums.h | 11 +++ src/mesa/main/samplerobj.h| 9 + src/mesa/main/texenvprogram.h | 11 +++ src/mesa/main/texobj.h| 10 ++ 4 files changed, 41 insertions(+) diff --git a/src/mesa/main

[Mesa-dev] [Bug 84186] X 1.16.1 RC 1 segfaults and reports "XXX fail to create fbo" with Radeon HD 7970.

2014-12-16 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=84186 --- Comment #9 from Michel Dänzer --- Do you get more information with the environment variable MESA_DEBUG=incomplete_fbo ? If not, make sure Mesa is built with --enable-debug. -- You are receiving this mail because: You are the assignee for th

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-12-16 Thread Keith Packard
Mario Kleiner writes: > The 0 case is good for benchmarking. Sure, but the current code does benchmarking just fine. In fact, because it doesn't copy queued frames that aren't the most recent before the vblank, benchmarks tend to run *faster* as a result, and people generally like that aspect of

[Mesa-dev] [PATCH] mesa: Returns correct error values from gl(Get)SamplerParameter*() on GL-ES 3.0+

2014-12-16 Thread Eduardo Lima Mitev
'3.8.2 Sampler Objects' section of the GL-ES 3.0 specification states: "An INVALID_OPERATION error is generated if sampler is not the name of a sampler object previously returned from a call to GenSamplers." In desktop GL, an GL_INVALID_VALUE is returned instead. Fixes 6 dEQP failing tes