Re: [Mesa-dev] [PATCH] mesa: use build flag to ensure stack is realigned on x86

2014-12-06 Thread Matt Turner
On Sat, Dec 6, 2014 at 8:52 PM, Timothy Arceri wrote: > Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but > that is an assumption OpenGL drivers (or any dynamic library for that matter) > can't afford to make as there are many closed- and open- source application > bina

Re: [Mesa-dev] [PATCH] i965/Gen6-7: Fix point sprites with PolygonMode(GL_POINT)

2014-12-06 Thread Kenneth Graunke
On Friday, December 05, 2014 07:43:13 PM Chris Forbes wrote: > This was an oversight in the original patch. When PolygonMode is > used, then front faces, back faces, or both may be rendered as > points and are affected by point sprite state. > > Note that SNB/IVB can't actually be fully conformant

[Mesa-dev] [PATCH] mesa: use build flag to ensure stack is realigned on x86

2014-12-06 Thread Timothy Arceri
Nowadays GCC assumes stack pointer is 16-byte aligned even on 32-bits, but that is an assumption OpenGL drivers (or any dynamic library for that matter) can't afford to make as there are many closed- and open- source application binaries out there that only assume 4-byte stack alignment. https:

Re: [Mesa-dev] [PATCH 1/2] i965: Add missing opcode names.

2014-12-06 Thread Chris Forbes
Both are: Reviewed-by: Chris Forbes On Sun, Dec 7, 2014 at 11:21 AM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_shader.cpp | 9 + > 1 file changed, 9 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp > b/src/mesa/drivers/dri/i965/brw_shader.cpp > in

Re: [Mesa-dev] [PATCH] i965/Gen6-7: Fix point sprites with PolygonMode(GL_POINT)

2014-12-06 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 1/2] i965: Add missing opcode names.

2014-12-06 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_shader.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index 8a41984..c0ca26b 100644 --- a/src/mesa/drivers/dri/i965/brw_shader.cpp +++ b/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH 2/2] i965: Remove default from brw_instruction_name switch to catch missing names.

2014-12-06 Thread Matt Turner
The case-range extension is available in clang and gcc at least back to 3.4.0. --- src/mesa/drivers/dri/i965/brw_shader.cpp | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp in

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2014-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 Kertesz Laszlo changed: What|Removed |Added CC||laszlo.kert...@gmail.com --- Comment #4

Re: [Mesa-dev] [PATCH] i965: Add opcode names for set_omask and set_sample_id.

2014-12-06 Thread Chris Forbes
Reviewed-by: Chris Forbes On Sun, Dec 7, 2014 at 10:34 AM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_shader.cpp | 4 > 1 file changed, 4 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp > b/src/mesa/drivers/dri/i965/brw_shader.cpp > index 183a4f1..098

[Mesa-dev] [PATCH] i965: Add opcode names for set_omask and set_sample_id.

2014-12-06 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_shader.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index 183a4f1..0980011 100644 --- a/src/mesa/drivers/dri/i965/brw_shader.cpp +++ b/src/mesa/drivers/dri/i965/brw

Re: [Mesa-dev] [PATCH 1/2] i965: Add opcode names for FS interpolation opcodes

2014-12-06 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 2/2] i965: Fix regs read for FS_OPCODE_INTERP_PER_SLOT_OFFSET

2014-12-06 Thread Jason Ekstrand
Both patches Reviewed-by: Jason Ekstrand On Sat, Dec 6, 2014 at 1:18 PM, Chris Forbes wrote: > Dead code elimination was eating the Y offset. > > Fixes the piglit test: > spec/ARB_gpu_shader5/arb_gpu_shader5-interpolateAtOffset-nonconst > > Signed-off-by: Chris Forbes > --- > src/mesa/drivers

[Mesa-dev] [PATCH 1/2] i965: Add opcode names for FS interpolation opcodes

2014-12-06 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_shader.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index 183a4f1..8f6a3de 100644 --- a/src/mesa/drivers/dri/i965/brw_shader.cpp +

[Mesa-dev] [PATCH 2/2] i965: Fix regs read for FS_OPCODE_INTERP_PER_SLOT_OFFSET

2014-12-06 Thread Chris Forbes
Dead code elimination was eating the Y offset. Fixes the piglit test: spec/ARB_gpu_shader5/arb_gpu_shader5-interpolateAtOffset-nonconst Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_fs.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp

Re: [Mesa-dev] [PATCH] tgsi/lowering: add support to lower TXP

2014-12-06 Thread Ilia Mirkin
On Sat, Dec 6, 2014 at 3:27 PM, Rob Clark wrote: > From: Rob Clark > > Signed-off-by: Rob Clark > --- > For adreno a4xx, we need to lower all TXP, for a3xx, we need to just > lower for certain texture types. Seems reasonable. Reviewed-by: Ilia Mirkin > > src/gallium/auxiliary/tgsi/tgsi_lower

[Mesa-dev] [PATCH] tgsi/lowering: add support to lower TXP

2014-12-06 Thread Rob Clark
From: Rob Clark Signed-off-by: Rob Clark --- For adreno a4xx, we need to lower all TXP, for a3xx, we need to just lower for certain texture types. src/gallium/auxiliary/tgsi/tgsi_lowering.c | 35 -- src/gallium/auxiliary/tgsi/tgsi_lowering.h | 3 +++ 2 files change

[Mesa-dev] [Bug 86788] (bisected) 32bit UrbanTerror 4.1 timedemo sse4.1 segfault...

2014-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86788 --- Comment #12 from smoki --- (In reply to Timothy Arceri from comment #11) > Created attachment 110506 [details] [review] > Realign via config/make > > Hi smoki, > > Are you able to give this patch a try against master? Yep quick tried UT4.

Re: [Mesa-dev] [PATCH 1/2] winsys/radeon: Always report at least 1 compute unit

2014-12-06 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sat, Dec 6, 2014 at 12:59 AM, Tom Stellard wrote: > All uses of this require that the value be at least one, so it's > easier to report at least one than having to wrap all uses > in MAX2(max_compute_units, 1). > --- > src/gallium/drivers/radeon/r600_pipe_comm

Re: [Mesa-dev] [PATCH] draw: implement TGSI_PROPERTY_VS_WINDOW_SPACE_POSITION

2014-12-06 Thread Marek Olšák
Ping. On Mon, Nov 17, 2014 at 10:43 PM, Marek Olšák wrote: > From: Marek Olšák > > Required by Nine. Tested with util_run_tests. > It's added to softpipe, llvmpipe, and r300g/swtcl. > --- > src/gallium/auxiliary/draw/draw_context.c | 40 > ++ > src/gallium/auxiliar

Re: [Mesa-dev] [PATCH] i965: Replace 'noann' debug flag with 'ann'.

2014-12-06 Thread Jason Ekstrand
I'm good with it. Reviewed-by: Jason Ekstrand On Dec 6, 2014 3:24 AM, "Kenneth Graunke" wrote: > On Friday, December 05, 2014 05:08:40 PM Matt Turner wrote: > > --- > > Eric was against making this the default when I first suggested a flag. > > Have opinions changed since then? I rarely use the

Re: [Mesa-dev] opengl fill modes

2014-12-06 Thread Brian Paul
On 12/05/2014 08:30 PM, Roland Scheidegger wrote: Hi, this might be a stupid question, but if you use opengl fill mode line / point are the shared edges/vertices in strip (or fan) primitives drawn multiple times? My pedantic reading of the spec would seem to say yes (because it essentially says

[Mesa-dev] [Bug 86788] (bisected) 32bit UrbanTerror 4.1 timedemo sse4.1 segfault...

2014-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86788 --- Comment #11 from Timothy Arceri --- Created attachment 110506 --> https://bugs.freedesktop.org/attachment.cgi?id=110506&action=edit Realign via config/make Hi smoki, Are you able to give this patch a try against master? -- You are recei

Re: [Mesa-dev] [PATCH] i965: Replace 'noann' debug flag with 'ann'.

2014-12-06 Thread Kenneth Graunke
On Friday, December 05, 2014 05:08:40 PM Matt Turner wrote: > --- > Eric was against making this the default when I first suggested a flag. > Have opinions changed since then? I rarely use the annotations, and they > do make the assembly harder to read, when the assembly is what you're > interested

[Mesa-dev] [Bug 86788] (bisected) 32bit UrbanTerror 4.1 timedemo sse4.1 segfault...

2014-12-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86788 --- Comment #10 from Timothy Arceri --- Hi Jose, Thanks for your fix and explanation of the problem. Your suggested solution did not fall on deaf ears, I still intend to implement a proper solution. I had a family member fall gravely ill over th