Re: [Mesa-dev] [PATCH] [v2] i965/skl: Fix SBE state upload code.

2014-11-30 Thread Kenneth Graunke
On Saturday, November 22, 2014 03:22:15 PM Ben Widawsky wrote: > The state upload code was incorrectly shifting the attribute swizzles. The > effect of this is we're likely to get the default swizzle values, which > disables > the component. > > This doesn't technically fix any bugs since Skylake

[Mesa-dev] [PATCH] i965: Remove "disable_derivative_optimization" driconf option.

2014-11-30 Thread Kenneth Graunke
This was added in September 2013 when we first implemented the fast (but lower quality) derivatives. A quick Google search didn't turn up anyone using or recommending the option, so I suspect no one does. Applications that want to control the quality of their derivatives can use the new GL_ARB_de

Re: [Mesa-dev] [PATCH 1/3] glsl: Disallow `pragma STDGL invariant(all)` in fragment shaders

2014-11-30 Thread Chris Forbes
Let's go with your version then. It's got a spec citation and everything :) Consider your patch: Reviewed-by: Chris Forbes On Mon, Dec 1, 2014 at 5:43 PM, Tapani wrote: > I sent this too when submitting the test :) > > http://patchwork.freedesktop.org/patch/36194/ > > > On 11/29/2014 10:54 PM,

Re: [Mesa-dev] [PATCH 1/3] glsl: Disallow `pragma STDGL invariant(all)` in fragment shaders

2014-11-30 Thread Tapani
I sent this too when submitting the test :) http://patchwork.freedesktop.org/patch/36194/ On 11/29/2014 10:54 PM, Chris Forbes wrote: Fixes the piglit test: spec/glsl-es-3.00/compiler/invariant_all.frag Signed-off-by: Chris Forbes --- src/glsl/glsl_parser.yy | 4 1 file changed, 4 ins

Re: [Mesa-dev] [PATCH 1/3] glsl: Disallow `pragma STDGL invariant(all)` in fragment shaders

2014-11-30 Thread Chris Forbes
Will do. On Mon, Dec 1, 2014 at 11:38 AM, Jordan Justen wrote: > Could you add spec references in comments or the commit messages? > > On 2014-11-29 12:54:58, Chris Forbes wrote: >> Fixes the piglit test: spec/glsl-es-3.00/compiler/invariant_all.frag >> >> Signed-off-by: Chris Forbes >> --- >>

Re: [Mesa-dev] [PATCH 1/3] glsl: Disallow `pragma STDGL invariant(all)` in fragment shaders

2014-11-30 Thread Jordan Justen
Could you add spec references in comments or the commit messages? On 2014-11-29 12:54:58, Chris Forbes wrote: > Fixes the piglit test: spec/glsl-es-3.00/compiler/invariant_all.frag > > Signed-off-by: Chris Forbes > --- > src/glsl/glsl_parser.yy | 4 > 1 file changed, 4 insertions(+) > > d

[Mesa-dev] [PATCH V2] glsl: check if implicitly sized arrays match explicitly sized arrays across the same stage

2014-11-30 Thread Timothy Arceri
V2: Improve error message. Signed-off-by: Timothy Arceri --- src/glsl/linker.cpp | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) I came across this when I was writting arrays of arrays piglit tests. This change fixes the new link error tests for single dimension ar

Re: [Mesa-dev] [PATCH] r600g/sb: fix issues cause by GLSL switching to loops for switch

2014-11-30 Thread Glenn Kennard
On Fri, 28 Nov 2014 04:36:42 +0100, Dave Airlie wrote: From: Dave Airlie Since 73dd50acf6d244979c2a657906aa56d3ac60d550 glsl: implement switch flow control using a loop The SB backend was falling over in an assert or crashing. Tracked this down to the loops having no repeats, but requiring

[Mesa-dev] [PATCH libdrm 1/1] Fix some gcc -Wextra warnings

2014-11-30 Thread Jan Vesely
Signed-off-by: Jan Vesely --- Two warning remain in my setup (radeon only): tests/modeprint/modeprint.c:127 (-Wempty-body) I'm not sure what should happen here, or why the if is even there. Didn't feel right to add {} to shut up gcc xf86drm.c:322 (-Wtype-limits) Not sure what the semantics of g

[Mesa-dev] [PATCH libdrm 1/1] random: Use unsigned long for seed

2014-11-30 Thread Jan Vesely
This is more consistent with the rest of the code, and avoids potential undefined behavior (signed overflow) in drmRandom() Signed-off-by: Jan Vesely --- The output of test program with RANDOM_MAIN is unchanged. xf86drmRandom.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2014-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #3 from Christian König --- Most likely we end up with the implementation with the dummy symbols loaded first (e.g. kodi loads OGL first the VDPAU). This results in a couple of problems when VDPAu tries to query the video capabilities

Re: [Mesa-dev] [PATCH] st/mesa: avoid exposing EXT_texture_integer for pre-GLSL 1.30

2014-11-30 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Sun, Nov 30, 2014 at 4:15 AM, Ilia Mirkin wrote: > For drivers building up to GL(ES)3, only expose the actual extension if > the API will let it be used (e.g. via overrides/debug flags that enable > higher versions). > > Signed-off-by: Ilia Mirkin > --- > > Te

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-11-30 Thread Mario Kleiner
On 11/25/2014 09:31 AM, Frank Binns wrote: Hi, I sent exactly the same patch back in April. Despite getting a review-by it was never merged. See: http://lists.freedesktop.org/archives/mesa-dev/2014-April/058347.html http://lists.freedesktop.org/archives/mesa-dev/2014-May/060432.html Thanks Fra

Re: [Mesa-dev] [PATCH 3/3] glx/dri3: Request non-vsynced Present for swapinterval zero.

2014-11-30 Thread Mario Kleiner
On 11/25/2014 07:52 AM, Axel Davy wrote: Hi, Sorry for the late reply, seems my e-mail filters hate me - i was already worried about the lack of replies. This patch removes the tripple buffering behaviour that the GLX implementation has with DRI3. I understand your concern for Medical sof

[Mesa-dev] [Bug 86837] kodi segfault since auxiliary/vl: rework the build of the VL code

2014-11-30 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=86837 --- Comment #2 from Emil Velikov --- Sigh... sorry for the break Andy. Seems that I should have tested with nv_vdpau_interop apps, which was never really worked with nouveau :( I'll take a look at this over the next few days. -- You are receivi