On Tue, 25 Nov 2014 16:22:25 +0100
Marek Olšák wrote:
> Hi Pekka,
>
> I explained in the introductory thread "[PATCH 0/2] Disable the EGL
> state tracker for Linux/DRI builds" that it may break swrast
> (llvmpipe) on Wayland. I also explained all the reasons why I was
> about to do it. Does it b
Patch enables ES2 extension that utilizes existing ES3 functionality.
Changes make all the subtests to run and pass in WebGL conformance
test 'webgl-draw-buffers' when running Chrome on OpenGL ES.
v2: remove unused boolean (Ilia Mirkin)
Signed-off-by: Tapani Pälli
---
src/glsl/glcpp/glcpp-pars
On 11/25/2014 03:56 PM, Ilia Mirkin wrote:
On Tue, Nov 25, 2014 at 6:23 AM, Tapani Pälli wrote:
Patch enables ES2 extension that utilizes existing ES3 functionality.
Changes make all the subtests to run and pass in WebGL conformance
test 'webgl-draw-buffers' when running Chrome on OpenGL ES.
On Tue, 2014-11-25 at 01:56 -0500, Connor Abbott wrote:
> On Tue, Nov 25, 2014 at 1:19 AM, Jason Ekstrand wrote:
> > Previously, the hash_table API required the user to do all of the hashing
> > of keys as it passed them in. Since the hashing function is intrinsicly
> > tied to the comparison fun
https://bugs.freedesktop.org/show_bug.cgi?id=85203
--- Comment #6 from Mario Kleiner ---
Also looking at the current ati-ddx, there have been changes to the logic since
i last touched that code a long time ago. Functions like
radeon_dri2_extrapolate_msc_delay() and radeon_get_interpolated_vblanks
https://bugs.freedesktop.org/show_bug.cgi?id=85203
--- Comment #5 from Mario Kleiner ---
(In reply to Michel Dänzer from comment #4)
> Mario, any ideas?
>
> These are possible scenarios I can think of where this could still happen:
>
> 1. The pflip interrupt triggers before the corresponding vb
On Mon, Nov 24, 2014 at 4:39 PM, Matt Turner wrote:
> I've got some thread-safety fixes queued up after this and thought I'd
> be a good Mesa citizen and pull some code into src/util.
>
> I did some clean ups like replacing INLINE (MSVC knows about "inline"
> these days, right?) and used stdbool.h
like how C11's stdatomic.h provides generic functions. GCC's __sync_*
builtins already take a variety of types, so that's simple.
MSVC and Sun Studio don't, but we can implement it with something that
looks a little crazy but is actually quite readable.
---
v2: - Squash in Jose's MSVC fixes
-
On Tue, Nov 25, 2014 at 3:40 PM, Eric Anholt wrote:
> Jason Ekstrand writes:
>
> > Previously, the hash_table API required the user to do all of the hashing
> > of keys as it passed them in. Since the hashing function is intrinsicly
> > tied to the comparison function, it makes sense for the ha
On Fri, Nov 14, 2014 at 4:08 PM, Kenneth Graunke wrote:
> On Thursday, November 13, 2014 04:28:20 PM Kristian Høgsberg wrote:
>> This patch uses the previous refactoring to add a new run_vs() method
>> that generates vertex shader code using the scalar visitor and
>> optimizer.
>>
>> Signed-off-by
Jason Ekstrand writes:
> Previously, the hash_table API required the user to do all of the hashing
> of keys as it passed them in. Since the hashing function is intrinsicly
> tied to the comparison function, it makes sense for the hash table to know
> about it. Also, it makes for a somewhat clu
Timothy Arceri writes:
> Signed-off-by: Timothy Arceri
Reviewed-by: Eric Anholt
and I've pushed the equivalent change with your name to the upstream
repo.
signature.asc
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedeskto
On Thu, Nov 13, 2014 at 8:49 PM, Matt Turner wrote:
> On Thu, Nov 13, 2014 at 4:28 PM, Kristian Høgsberg wrote:
>> The LOAD_PAYLOAD opcode can't saturate its sources, so skip
>> saturating MOVs. The register coalescing after lower_load_payload()
>> will clean up the extra MOVs.
>>
>> Signed-off-
On Tue, Nov 25, 2014 at 4:43 AM, Kenneth Graunke wrote:
> 4:43 AM
If I didn't see you a couple of times a week I'd wonder what timezone
you were in!
> Most of the dirty flags were listed in some arbitrary order. Some used
> bonus parenthesis. Some put multiple flags on one line, others put on
On Tue, Nov 25, 2014 at 4:43 AM, Kenneth Graunke wrote:
> BRW_CACHE_VS_PROG is more easily associated with program caches than
> plain BRW_VS_PROG.
>
> While we're at it, rename BRW_WM_PROG to BRW_CACHE_FS_PROG, to move away
> from the outdated Windowizer/Masker name.
>
> Signed-off-by: Kenneth Gr
On Tue, Nov 25, 2014 at 1:42 PM, Jose Fonseca wrote:
> On 25/11/14 21:04, Matt Turner wrote:
>>
>> On Tue, Nov 25, 2014 at 6:48 AM, Jose Fonseca wrote:
>>>
>>> On 25/11/14 00:39, Matt Turner wrote:
I've got some thread-safety fixes queued up after this and thought I'd
be a goo
On 25/11/14 21:04, Matt Turner wrote:
On Tue, Nov 25, 2014 at 6:48 AM, Jose Fonseca wrote:
On 25/11/14 00:39, Matt Turner wrote:
I've got some thread-safety fixes queued up after this and thought I'd
be a good Mesa citizen and pull some code into src/util.
Thanks for going the extra mile!
On Tue, Nov 25, 2014 at 6:48 AM, Jose Fonseca wrote:
> On 25/11/14 00:39, Matt Turner wrote:
>>
>> I've got some thread-safety fixes queued up after this and thought I'd
>> be a good Mesa citizen and pull some code into src/util.
>
>
> Thanks for going the extra mile!
>
>> I did some clean ups lik
Patches 3-6 are
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On Thu, Nov 13, 2014 at 9:03 PM, Matt Turner wrote:
> On Thu, Nov 13, 2014 at 4:28 PM, Kristian Høgsberg wrote:
>> @@ -3148,6 +3150,9 @@ fs_visitor::dump_instruction(backend_instruction
>> *be_inst, FILE *file)
>> case UNIFORM:
>>fprintf(file, "***u%d***", inst->dst.reg + inst->dst.r
On Thu, Nov 13, 2014 at 6:38 PM, Connor Abbott wrote:
> On Thu, Nov 13, 2014 at 7:28 PM, Kristian Høgsberg wrote:
>> This will be reused for the scalar VS pass.
>>
>> Signed-off-by: Kristian Høgsberg
>> ---
>> src/mesa/drivers/dri/i965/brw_fs.cpp | 132
>> +++
>>
Whoops I edited the wrong patch before sending this out it was meant to
be RFC and have the following comments attached:
I came across this when I was writting arrays of arrays piglit tests.
This change fixes the new link error single dimension array
tests I sent to the piglit list [1].
I've
Series Reviewed-by: Jordan Justen
On 2014-11-24 22:03:10, Kenneth Graunke wrote:
> brw->wm.prog_data is covered by CACHE_NEW_WM_PROG, not
> BRW_NEW_FRAGMENT_PROGRAM. So, we should listen to it.
>
> However, I believe that BRW_NEW_FRAGMENT_PROGRAM is sufficient to cover
> all the necessary cases
When restoring the current state in _mesa_meta_end it was previously trying to
copy the on-going sample count of the current occlusion query into the new
query after restarting it so that the driver will continue adding to the
previous value. This wouldn't work for two reasons. Firstly, the query m
On Tue, Nov 25, 2014 at 4:43 AM, Kenneth Graunke wrote:
> Hello,
>
> This series does some longstanding cleaning I've been meaning to do
> in the i965 state upload code. The distinction between BRW_NEW_* and
> CACHE_NEW_* flags has been pretty arbitrary for a while - 10/17 of
> them were for thin
https://bugs.freedesktop.org/show_bug.cgi?id=78914
José Fonseca changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Hi Pekka,
I explained in the introductory thread "[PATCH 0/2] Disable the EGL
state tracker for Linux/DRI builds" that it may break swrast
(llvmpipe) on Wayland. I also explained all the reasons why I was
about to do it. Does it break something not discussed before?
Marek
On Tue, Nov 25, 2014 at
On Tue, 4 Nov 2014 23:42:44 +0100
Marek Olšák wrote:
> From: Marek Olšák
Btw. would have been *really* nice if the commit message here explained
why you do this and what all things it intentionally breaks, before
pushing it.
Thanks,
pq
> ---
> configure.ac| 74
> +++--
On 25/11/14 00:39, Matt Turner wrote:
I've got some thread-safety fixes queued up after this and thought I'd
be a good Mesa citizen and pull some code into src/util.
Thanks for going the extra mile!
I did some clean ups like replacing INLINE (MSVC knows about "inline"
these days, right?) and
https://bugs.freedesktop.org/show_bug.cgi?id=86701
Javier Jardón changed:
What|Removed |Added
CC||e...@anholt.net,
|
On Tue, Nov 25, 2014 at 6:23 AM, Tapani Pälli wrote:
> Patch enables ES2 extension that utilizes existing ES3 functionality.
>
> Changes make all the subtests to run and pass in WebGL conformance
> test 'webgl-draw-buffers' when running Chrome on OpenGL ES.
>
> Signed-off-by: Tapani Pälli
> ---
>
https://bugs.freedesktop.org/show_bug.cgi?id=86701
--- Comment #1 from Pekka Paalanen ---
egl_gallium.so was able to use llvmpipe and direct that rendering to wl_shm
based buffers, and therefore does not need any EGL support from the compositor.
egl_dri2 does not implement that.
Could egl_dri2
https://bugs.freedesktop.org/show_bug.cgi?id=86701
Pekka Paalanen changed:
What|Removed |Added
CC||ppaala...@gmail.com
--
You are receivi
https://bugs.freedesktop.org/show_bug.cgi?id=86701
Bug ID: 86701
Summary: [regression] weston-simple-egl not running anymore
inside qemu
Product: Mesa
Version: git
Hardware: Other
OS: All
Status:
BRW_CACHE_VS_PROG is more easily associated with program caches than
plain BRW_VS_PROG.
While we're at it, rename BRW_WM_PROG to BRW_CACHE_FS_PROG, to move away
from the outdated Windowizer/Masker name.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_blorp_blit.cpp | 4 ++--
s
It's been merged into brw_state_flags::brw for simplicity and
efficiency.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_binding_tables.c | 2 --
src/mesa/drivers/dri/i965/brw_blorp.cpp| 1 -
src/mesa/drivers/dri/i965/brw_cc.c | 3 ---
src/mes
We've been streaming these out for ages, so they basically have nothing
to do with brw_state_cache.c.
Saves 6 * sizeof(void *) bytes per context, as we won't have useless
aux_compare/aux_free functions for them.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_cc.c
Most of the dirty flags were listed in some arbitrary order. Some used
bonus parenthesis. Some put multiple flags on one line, others put one
per line. Some used tabs instead of spaces...but only on some lines.
This patch settles on one flag per line, in alphabetical order, using
spaces instead
This flag signifies that we've emitted a new SAMPLER_STATE table.
Given that we haven't cached those in years, CACHE_NEW_SAMPLER isn't
a great name. Putting it in the BRW_NEW_* hierarchy would make more
sense; BRW_NEW_SAMPLER_STATE_TABLE better reflects its actual purpose.
When this flag is raise
Now that we've moved a bunch of CACHE_NEW_* bits to BRW_NEW_*, the only
ones that are left are legitimately related to the program cache. Yet,
it seems a bit wasteful to have an entire bitfield for only 7 bits.
State upload is one of the hottest paths in the driver. For each atom
in the list, we
Hello,
This series does some longstanding cleaning I've been meaning to do
in the i965 state upload code. The distinction between BRW_NEW_* and
CACHE_NEW_* flags has been pretty arbitrary for a while - 10/17 of
them were for things we stopped caching years ago. So, I moved
those to be BRW_NEW_*
Marking brw_stage_state::sampler_count as CACHE_NEW_SAMPLER is wrong.
The number of samplers used by each program is actually computed at
draw time (brw_try_draw_prims), based purely on the currently bound
shader programs (gl_program::SamplersUsed).
CACHE_NEW_SAMPLER means that we've emitted a ne
I put the BRW_NEW_*_PROG_DATA flags at the beginning so that
brw_state_cache.c can still continue using 1 << brw_cache_id.
I also added a comment explaining the difference between
BRW_NEW_*_PROG_DATA and BRW_NEW_*_PROGRAM, as it took me a long time
to remember it.
Non-mechanical changes:
- brw_st
On Gen4-5, unit state is specified as indirect state, rather than
commands. If any unit state changes, we upload it via brw_state_batch
and arrange for 3DSTATE_PIPELINED_POINTERS to be re-emitted, which
updates pointers to all unit state at once.
Since there's only one command and state atom (brw
These always happen together; the extra atom just means another item to
iterate through, flags to check, and a call through a function pointer.
Signed-off-by: Kenneth Graunke
---
src/mesa/drivers/dri/i965/brw_cc.c | 9 -
src/mesa/drivers/dri/i965/brw_state.h | 1
https://bugs.freedesktop.org/show_bug.cgi?id=86690
--- Comment #2 from Pekka Paalanen ---
(In reply to Alexandre Courbot from comment #1)
> Created attachment 109990 [details]
> Trace when running glmark2 with WAYLAND_DEBUG=client
>
> Attached the trace suggested by Pekka. The stuttering is visi
Signed-off-by: Timothy Arceri
---
src/glsl/linker.cpp | 19 ++-
1 file changed, 18 insertions(+), 1 deletion(-)
diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp
index de6b1fb..a3a43a0 100644
--- a/src/glsl/linker.cpp
+++ b/src/glsl/linker.cpp
@@ -732,8 +732,25 @@ cross_vali
BTW, radeon flushes in get_query_result even if wait is FALSE,
therefore this loop will always finish:
while (!get_query_result(...));
I think it's a requirement for OpenGL.
Marek
On Tue, Nov 25, 2014 at 12:42 PM, Marek Olšák wrote:
> Calling pipe->flush is unnecessary before get_query_result,
Calling pipe->flush is unnecessary before get_query_result, because
get_query_result flushes automatically if it has to (at least on
radeon).
Marek
On Sun, Nov 23, 2014 at 11:40 PM, David Heidelberg wrote:
> From: Axel Davy
>
> From this moment we should handle errors same way as Wine does.
>
>
Patch enables ES2 extension that utilizes existing ES3 functionality.
Changes make all the subtests to run and pass in WebGL conformance
test 'webgl-draw-buffers' when running Chrome on OpenGL ES.
Signed-off-by: Tapani Pälli
---
src/glsl/glcpp/glcpp-parse.y| 2 ++
src/glsl/glsl_parser_extra
On 25/11/14 09:43, Samuel Iglesias Gonsálvez wrote:
On 25/11/14 09:59, Michel Dänzer wrote:
On 21.11.2014 23:57, Samuel Iglesias Gonsálvez wrote:
On Wed, 2014-11-19 at 17:09 +0900, Michel Dänzer wrote:
On 18.11.2014 17:43, Iago Toral Quiroga wrote:
For software drivers we worked with a tri
Changes done and pushed.
On Tue, Nov 25, 2014 at 10:17 PM, Kenneth Graunke wrote:
> On Tuesday, November 25, 2014 10:05:18 PM Chris Forbes wrote:
>> Fixes broken rendering in Windows-based QtQuick2 apps run through Wine.
>> This library sets all texture units' GL_COORD_REPLACE, leaves point
>> sp
On 25/11/14 09:59, Michel Dänzer wrote:
> On 21.11.2014 23:57, Samuel Iglesias Gonsálvez wrote:
>> On Wed, 2014-11-19 at 17:09 +0900, Michel Dänzer wrote:
>>> On 18.11.2014 17:43, Iago Toral Quiroga wrote:
For software drivers we worked with a trimmed set of piglit tests
(related t
On Tuesday, November 25, 2014 10:05:18 PM Chris Forbes wrote:
> Fixes broken rendering in Windows-based QtQuick2 apps run through Wine.
> This library sets all texture units' GL_COORD_REPLACE, leaves point
> sprite mode enabled, and then draws a triangle fan.
>
> Will need a slightly different fix
Fixes broken rendering in Windows-based QtQuick2 apps run through Wine.
This library sets all texture units' GL_COORD_REPLACE, leaves point
sprite mode enabled, and then draws a triangle fan.
Will need a slightly different fix for Gen4-5, but I don't have my old
machines in a usable state currentl
On 21.11.2014 23:57, Samuel Iglesias Gonsálvez wrote:
On Wed, 2014-11-19 at 17:09 +0900, Michel Dänzer wrote:
On 18.11.2014 17:43, Iago Toral Quiroga wrote:
For software drivers we worked with a trimmed set of piglit tests (related to
format conversion), ~5700 tests selected with the following
On Monday, November 24, 2014 10:19:50 PM Jason Ekstrand wrote:
> Previously, the hash_table API required the user to do all of the hashing
> of keys as it passed them in. Since the hashing function is intrinsicly
> tied to the comparison function, it makes sense for the hash table to know
> about
Hi,
I sent exactly the same patch back in April. Despite getting a review-by
it was never merged. See:
http://lists.freedesktop.org/archives/mesa-dev/2014-April/058347.html
http://lists.freedesktop.org/archives/mesa-dev/2014-May/060432.html
Thanks
Frank
On 25/11/14 03:00, Mario Kleiner wrote:
https://bugs.freedesktop.org/show_bug.cgi?id=71199
--- Comment #8 from José Fonseca ---
Yes, I suspect that ideal MRD at near plane may never go below 2, because of
the the "near_1_far_infinity" perspective transformation applied.
We could experiment whether an orthogonal transformation would al
On Tue, 25 Nov 2014 17:04:36 +0900
Alexandre Courbot wrote:
> Hi Pekka,
>
> On 11/20/2014 08:41 PM, Pekka Paalanen wrote:
> > At this point, I think it would be best to open a bug report against
> > Mesa, and continue there. Such freezes obviously should not happen on
> > either EGL driver. Ple
https://bugs.freedesktop.org/show_bug.cgi?id=78914
--- Comment #21 from Florian Link ---
It is ok for me if you close this bug as WONTFIX, since I worked around the
depth fighting and I agree that it is a hard problem to do this with high
precision and speed at the same time.
--
You are receivi
https://bugs.freedesktop.org/show_bug.cgi?id=86690
--- Comment #1 from Alexandre Courbot ---
Created attachment 109990
--> https://bugs.freedesktop.org/attachment.cgi?id=109990&action=edit
Trace when running glmark2 with WAYLAND_DEBUG=client
Attached the trace suggested by Pekka. The stutterin
Hi Pekka,
On 11/20/2014 08:41 PM, Pekka Paalanen wrote:
On Thu, 20 Nov 2014 18:24:34 +0900
Alexandre Courbot wrote:
Hi Pekka,
On 11/19/2014 04:34 PM, Pekka Paalanen wrote:
On Wed, 19 Nov 2014 15:32:38 +0900
Alexandre Courbot wrote:
Some more information: CPU usage of the EGL app (glmark2
https://bugs.freedesktop.org/show_bug.cgi?id=86690
Bug ID: 86690
Summary: glmark2-es2-wayland shortly freezes on some frames
with egl_dri2 backend (Nouveau/GK20A)
Product: Mesa
Version: git
Hardware: ARM
OS:
64 matches
Mail list logo
