On Mon, Sep 29, 2014 at 8:33 PM, Emil Velikov wrote:
> On 29/09/14 17:24, Matt Turner wrote:
>> On Mon, Sep 29, 2014 at 9:16 AM, Emil Velikov
>> wrote:
>>> So all in all we have the following:
>>>
>>> Some distributions/people choose odd location of the modules. Which
>>> can lead to the system
On Wed, Oct 1, 2014 at 6:12 AM, Iago Toral Quiroga wrote:
> in_var calls the ir_variable constructor, which dups the variable name.
I just came across this too, and tested that your patch fixed it.
There has to be some better way of dealing with this, like making a
fixed-size char buffer on the s
On Wed, Oct 1, 2014 at 12:06 PM, Marek Olšák wrote:
> On Wed, Oct 1, 2014 at 11:02 AM, Chris Forbes wrote:
>> In the drivers, we occasionally want to reallocate the backing
>> store for a buffer object; often to avoid waiting for the GPU
>> to be finished with the previous contents.
>>
>> At the
Previously, we had a MAX_SAMPLER_MESSAGE_SIZE which we used instead.
However, some FB write messages can validly be longer than this so we need
something different. Since MAX_SAMPLER_MESSAGE_SIZE is validly useful on
its own, we leave it alone and add a new MAX_GRF_SIZE that's big enough for
FB wr
This didn't make any sense, but papered over the missing TexBO flagging
we've just fixed, in a bunch of cases.
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_wm_s
The existing code was not setting several fields, most importantly the
target, which is required on nv50/nvc0.
Signed-off-by: Ilia Mirkin
---
src/gallium/auxiliary/hud/hud_context.c | 9 +++--
1 file changed, 3 insertions(+), 6 deletions(-)
diff --git a/src/gallium/auxiliary/hud/hud_context
Adds a DRI extension which advertises that the driver can accept a new
__DRI_CTX_ATTRIB_RELEASE_BEHAVIOR attribute in the createContextAttribs
function. If the attribute is specified then it will be passed down to the
CreateContext function in the release_behavior member of
__DriverContextConfig. T
I think these are about the only remaining uses of camel-case in the i965
driver. Let's make things more consistent.
Signed-off-by: Jason Ekstrand
---
src/mesa/drivers/dri/i965/intel_blit.c | 108 -
src/mesa/drivers/dri/i965/intel_blit.h | 51 ++-
This fixes a bug where 1-wide operations don't properly translate down to
1-wide instructions.
Signed-off-by: Jason Ekstrand
---
src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 13 +
1 file changed, 13 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_generator.cpp
b/src
Signed-off-by: Chris Forbes
---
src/mesa/main/mtypes.h | 3 +++
src/mesa/main/teximage.c | 6 ++
2 files changed, 9 insertions(+)
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
index 9ac66fe..f040679 100644
--- a/src/mesa/main/mtypes.h
+++ b/src/mesa/main/mtypes.h
@@ -1469,6
https://bugs.freedesktop.org/show_bug.cgi?id=84566
Priority: medium
Bug ID: 84566
Assignee: mesa-dev@lists.freedesktop.org
Summary: Unify the format conversion code
Severity: enhancement
Classification: Unclassified
OS: All
Signed-off-by: Jason Ekstrand
---
src/mesa/drivers/dri/i965/intel_blit.c | 90 --
src/mesa/drivers/dri/i965/intel_blit.h | 10
2 files changed, 73 insertions(+), 27 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/intel_blit.c
b/src/mesa/drivers/dri/i965/
On Wed, Oct 1, 2014 at 11:02 AM, Chris Forbes wrote:
> In the drivers, we occasionally want to reallocate the backing
> store for a buffer object; often to avoid waiting for the GPU
> to be finished with the previous contents.
>
> At the point that happens, we don't have a good way of determining
This adds the framework for the GLX flush control extension. It is advertised
if the DRI driver implements the new __DRI2_FLUSH_CONTROL extension. The GLX
attributes are converted to the appropriate DRI attributes.
---
src/glx/dri2_glx.c | 19 +--
src/glx/dri3_glx.c | 15
Looks like some mail server ate patches 2,3,4,7. I've resent them.
What you're doing in r600_invalidate_buffer is exactly what I'm trying
to avoid doing. :)
-- Chris
On Thu, Oct 2, 2014 at 5:06 AM, Marek Olšák wrote:
> On Wed, Oct 1, 2014 at 11:02 AM, Chris Forbes wrote:
>> In the drivers, we
On Mon, Sep 29, 2014 at 12:30 PM, Liu, Leo wrote:
> Hi Emil,
>
> Thanks for the explanation.
> V4 has been sent, please review.
V4 is:
Reviewed-by: Alex Deucher
>
> Thanks,
> Leo
>
>>-Original Message-
>>From: Emil Velikov [mailto:emil.l.veli...@gmail.com]
>>Sent: Monday, September 29,
On Wed, Oct 1, 2014 at 4:13 PM, Grigori Goronzy wrote:
> On 30.09.2014 05:58, Michel Dänzer wrote:
>> diff --git a/src/gallium/drivers/radeonsi/si_dma.c
>> b/src/gallium/drivers/radeonsi/si_dma.c
>> index ff64722..643ce3f 100644
>> --- a/src/gallium/drivers/radeonsi/si_dma.c
>> +++ b/src/gallium/
This didn't make any sense, but papered over the missing TexBO flagging
we've just fixed, in a bunch of cases.
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_wm_s
https://bugs.freedesktop.org/show_bug.cgi?id=54080
--- Comment #4 from Adrian Negreanu ---
Would the same behaviour/bug be exposed by calling XGetGeometry on a drawable
created with glXCreatePixmap ?
--
You are receiving this mail because:
You are the assignee for the bug.
_
---
docs/GL3.txt| 2 +-
docs/relnotes/10.4.html | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/docs/GL3.txt b/docs/GL3.txt
index 5adc759..3ab4b40 100644
--- a/docs/GL3.txt
+++ b/docs/GL3.txt
@@ -195,7 +195,7 @@ GL 4.5, GLSL 4.50:
GL_ARB_get_texture_sub_image
On 01/10/14 14:00, Liu, Leo wrote:
> Hi Emil,
>
> Any comments on V4
>
It actually hurts me that I have to write the following:
Is it too unusual to ./configure (or perhaps even make) prior to this
email/sending out the patch? I realise that mesa is big and slow but
spending 10-20 seconds (confi
If scratch space is needed for a shader stage we try to reuse the last scratch
buffer bound to that stage. If we can't, we free the old scratch buffer and
allocate a new one. This means we always keep the last scratch buffer for a
particular shader stage around for the entire live span of the conte
For the series:
Reviewed-by: Chris Forbes
On Sat, Sep 27, 2014 at 11:09 AM, Kenneth Graunke wrote:
> This will keep INTEL_DEBUG=state working when we add BRW_NEW_* bits
> beyond 1 << 31. We missed doing this when widening the driver flags
> from uint32_t to uint64_t.
>
> Signed-off-by: Kenneth
From: Petri Latvala
Signed-off-by: Petri Latvala
---
src/glsl/tests/test_case_generator.py | 4
1 file changed, 4 insertions(+)
diff --git a/src/glsl/tests/test_case_generator.py
b/src/glsl/tests/test_case_generator.py
index 5df8420..6633702 100644
--- a/src/glsl/tests/test_case_generato
On 09/30/2014 05:24 PM, Dave Airlie wrote:
From: Dave Airlie
While running piglit in virgl, I hit an assert in intel driver.
"qemu-system-x86_64: intel_tex.c:219: intel_map_texture_image: Assertion
`tex_image->TexObject->Target != 0x8C18 || h == 1' failed."
Thanks to Eric and Ken for pointin
From: Petri Latvala
Original patch by Petri Latvala :
tests/minmax/create_test_cases.py generates the following tests:
multiple_min*.opt_test:
Construct a tree of min expressions for all permutations of a var_ref
and three constants. They should all optimize to a single min with
the variable
On Tue, Sep 30, 2014 at 4:24 PM, Matt Turner wrote:
> The compiler isn't privy to the knowledge that we're doing at least one
> framebuffer write.
> ---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
> b/src/me
From: Petri Latvala
Move the IR sexp builder helpers and test script creation parts of
tests/lower_jumps/create_test_cases.py into tests/test_case_generator.py
No functional changes.
Signed-off-by: Petri Latvala
---
src/glsl/tests/lower_jumps/create_test_cases.py | 336 +++
https://bugs.freedesktop.org/show_bug.cgi?id=83631
Simone Caronni changed:
What|Removed |Added
CC||negativ...@gmail.com
--
You are receiv
From: Petri Latvala
Already-existing and used declare_temp() and assign_x() functions can
then be implemented in terms of the general functions.
Signed-off-by: Petri Latvala
---
src/glsl/tests/test_case_generator.py | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
di
On Tue, Sep 30, 2014 at 8:09 PM, Keith Packard wrote:
> Instead of just segfaulting in the driver when a buffer allocation fails,
> report error messages indicating what went wrong so that we can debug things.
>
> As a simple example, chromium wraps Mesa in a sandbox which doesn't allow
> access t
On Sep 30, 2014 8:26 PM, "Matt Turner" wrote:
>
> On Tue, Sep 30, 2014 at 5:49 PM, Jason Ekstrand
wrote:
> > Signed-off-by: Jason Ekstrand
> > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84529
> > ---
> > src/mesa/drivers/dri/i965/brw_fs_fp.cpp | 2 +-
> > 1 file changed, 1 insertion
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/brw_context.h | 2 ++
src/mesa/drivers/dri/i965/brw_state_upload.c | 1 +
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 1 +
3 files changed, 4 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_context.h
b/src/me
When a buffer object is bound to one of the indexed uniform buffer
binding points, assume that from that point on it may be used as
a uniform buffer.
Signed-off-by: Chris Forbes
---
src/mesa/main/bufferobj.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/mesa/main/bufferobj.c b/sr
On Tue, Sep 30, 2014 at 5:18 PM, Jason Ekstrand wrote:
> Reviewed-by: Jason Ekstrand
The patch is wrong. See my reply.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Reviewed-by: Jason Ekstrand
On Tue, Sep 30, 2014 at 4:24 PM, Matt Turner wrote:
> The compiler isn't privy to the knowledge that we're doing at least one
> framebuffer write.
> ---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/mesa/drivers/
Signed-off-by: Chris Forbes
---
src/mesa/main/mtypes.h | 3 +++
src/mesa/main/teximage.c | 6 ++
2 files changed, 9 insertions(+)
diff --git a/src/mesa/main/mtypes.h b/src/mesa/main/mtypes.h
index 9ac66fe..f040679 100644
--- a/src/mesa/main/mtypes.h
+++ b/src/mesa/main/mtypes.h
@@ -1469,6
On 01.10.2014 06:38, Rob Clark wrote:
[...] up to the driver to manage it's own shader variants:
Spelling: 'its'
--
Earthling Michel Dänzer| http://www.amd.com
Libre software enthusiast |Mesa and X developer
__
From: Michel Dänzer
Based on the corresponding SI support.
Signed-off-by: Michel Dänzer
---
No piglit regressions[0], even with R600_DEBUG=forcedma.
[0] The arb_texture_multisample-sample-mask-execution tests are failing
randormly, but I can't get them to fail when run manually, and they
https://bugs.freedesktop.org/show_bug.cgi?id=84538
Priority: medium
Bug ID: 84538
Keywords: regression
Assignee: mesa-dev@lists.freedesktop.org
Summary: lp_test_format.c:226:4: error: too few arguments to
function ‘gallivm_cr
From: Michel Dänzer
Based on the corresponding SI support.
Signed-off-by: Michel Dänzer
---
v2: Remove fallback for liner->tiled copies which was accidentally left
over from debugging.
src/gallium/drivers/radeonsi/Makefile.sources | 1 +
src/gallium/drivers/radeonsi/cik_sdma.c |
Am 01.10.2014 16:56, schrieb Maarten Lankhorst:
> This fixes a crash when llvmpipe tries to use sse instructions,
> but llvm detects a cpu that doesn't support them.
>
> Fixes for example piglit/bin/amd_seamless_cubemap_per_texture -fbo -auto
> on i386 when run inside "qemu -cpu qemu32", which wou
On Wed, Oct 1, 2014 at 10:56 AM, Maarten Lankhorst
wrote:
> This fixes a crash when llvmpipe tries to use sse instructions,
> but llvm detects a cpu that doesn't support them.
>
> Fixes for example piglit/bin/amd_seamless_cubemap_per_texture -fbo -auto
> on i386 when run inside "qemu -cpu qemu32",
This fixes a crash when llvmpipe tries to use sse instructions,
but llvm detects a cpu that doesn't support them.
Fixes for example piglit/bin/amd_seamless_cubemap_per_texture -fbo -auto
on i386 when run inside "qemu -cpu qemu32", which would otherwise error with:
"LLVM ERROR: Do not know how to s
https://bugs.freedesktop.org/show_bug.cgi?id=84570
James Ausmus changed:
What|Removed |Added
CC||james.aus...@intel.com
--
You are receiv
https://bugs.freedesktop.org/show_bug.cgi?id=84570
Bug ID: 84570
Summary: Borderlands 2: Framerate drops dramatically with
dynamic lighting activated
Product: Mesa
Version: git
Hardware: x86-64 (AMD64)
OS: L
Most of the time, it doesn't make much of a difference whether we use the
blitter or the render pipeline. However, on the GpuTest triangle test from
~4000FPS to ~6000FPS on my HSW desktop. No, that is not a typo. We also
see improvement on several Bay Trail benchmarks.
Signed-off-by: Jason Ekst
https://bugs.freedesktop.org/show_bug.cgi?id=84566
Jason Ekstrand changed:
What|Removed |Added
CC||ja...@jlekstrand.net
--
You are receiv
https://bugs.freedesktop.org/show_bug.cgi?id=84566
--- Comment #1 from Jason Ekstrand ---
I've already started a lot of this work. I've got an implementation of an
array format enum and master conversion function in this branch:
http://cgit.freedesktop.org/~jekstrand/mesa/log/?h=wip/format-conv
https://bugs.freedesktop.org/show_bug.cgi?id=54080
--- Comment #5 from ajax at nwnk dot net ---
(In reply to comment #4)
> Would the same behaviour/bug be exposed by calling XGetGeometry on a
> drawable created with glXCreatePixmap ?
No, but you'd have a different problem there, which is that XG
Signed-off-by: Jason Ekstrand
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=84529
---
src/mesa/drivers/dri/i965/brw_fs_fp.cpp | 10 --
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs_fp.cpp
b/src/mesa/drivers/dri/i965/brw_fs_fp.cpp
---
glxtokens.h | 8
1 file changed, 8 insertions(+)
diff --git a/glxtokens.h b/glxtokens.h
index a95082e..68634ee 100644
--- a/glxtokens.h
+++ b/glxtokens.h
@@ -309,6 +309,14 @@ extern "C" {
#define GLX_CONTEXT_RESET_NOTIFICATION_STRATEGY_ARB 0x8256
#define GLX_NO_RESET_NOTIFICATION_A
This adds the server-side parts of GLX_ARB_context_flush_control. The
corresponding client-side parts in Mesa are posted to the mesa-dev
list here:
http://lists.freedesktop.org/archives/mesa-dev/2014-October/068914.html
There is also a patch needed for glproto which I will post here too.
Apologie
---
glx/extension_string.c | 1 +
glx/extension_string.h | 3 ++-
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/glx/extension_string.c b/glx/extension_string.c
index 4bef96f..e881d21 100644
--- a/glx/extension_string.c
+++ b/glx/extension_string.c
@@ -72,6 +72,7 @@ struct extension
The commit for adding the reset notification extension (90aa2486e) has
a note saying that we can assume that if the underlying provider
doesn't support the extension then it will generate BadMatch for these
attributes. This patch takes the same approach.
---
glx/createcontext.c | 15 ++
If the driver supports __DRI2_FLUSH_CONTROL then the
GLX_ARB_context_flush_control extension will now be enabled as well.
If the flush behavior attribute is passed to
glXCreateContextAttribsARB and the driver doesn't support
__DRI2_FLUSH_CONTROL then the driver should already generate the
correct e
It shouldn't be necessary to flush the context within the driver
implementation because the old context is explicitly flushed in
_mesa_make_current before the driver code is reached. It is useful to only
have a single place that flushes the context when switching contexts to make
it easier to later
Implementing the extension just involves copying the release behaviour value
from the context config to the GL context's constants. The upper layers of
Mesa handles the actual flushing.
---
src/mesa/drivers/dri/i965/brw_context.c | 20 +++-
src/mesa/drivers/dri/i965/intel_screen.c
Here's a series of patches to implement GL_KHR_flush_control and
GLX_ARB_flush_control. The idea of the extension is quite simple and
just makes it so that the GL doesn't implicitly flush the context when
the context is unbound. This should be a speed improvement for
applications that are using mul
The GL side of this extension just provides an accessor via glGetIntegerv for
the value of GL_CONTEXT_RELEASE_BEHAVIOR so it is trivial to implement. There
is a constant on the context for the value of the enum which is initialised to
GL_CONTEXT_RELEASE_BEHAVIOR_FLUSH. The extension is always enabl
Previously the CreateContext method of __DriverApiRec took a set of arguments
to describe the attribute values from the window system API's
CreateContextAttribs function. As more attributes get added this could quickly
get unworkable and every new attribute needs a modification for every driver.
T
The main incentive to do this is to get the defines for the
GL_KHR_context_flush_control extension.
---
include/GLES2/gl2ext.h | 313 -
1 file changed, 310 insertions(+), 3 deletions(-)
diff --git a/include/GLES2/gl2ext.h b/include/GLES2/gl2ext.h
in
Dave Airlie writes:
> From: Dave Airlie
>
> While running piglit in virgl, I hit an assert in intel driver.
>
> "qemu-system-x86_64: intel_tex.c:219: intel_map_texture_image: Assertion
> `tex_image->TexObject->Target != 0x8C18 || h == 1' failed."
>
> Thanks to Eric and Ken for pointing me in th
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/brw_context.h | 2 ++
src/mesa/drivers/dri/i965/brw_state_upload.c | 1 +
src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 1 +
3 files changed, 4 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_context.h
b/src/me
When a buffer object is bound to one of the indexed uniform buffer
binding points, assume that from that point on it may be used as
a uniform buffer.
Signed-off-by: Chris Forbes
---
src/mesa/main/bufferobj.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/src/mesa/main/bufferobj.c b/sr
https://bugs.freedesktop.org/show_bug.cgi?id=84538
Vinson Lee changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=54080
Adrian Negreanu changed:
What|Removed |Added
CC||adrian.m.negre...@intel.com
--
You ar
On 30.09.2014 05:58, Michel Dänzer wrote:
> diff --git a/src/gallium/drivers/radeonsi/si_dma.c
> b/src/gallium/drivers/radeonsi/si_dma.c
> index ff64722..643ce3f 100644
> --- a/src/gallium/drivers/radeonsi/si_dma.c
> +++ b/src/gallium/drivers/radeonsi/si_dma.c
> @@ -251,7 +251,9 @@ void si_dma_cop
On 30/09/14 23:32, Mathias Fröhlich wrote:
Hi all,
Thanks and pushed.
Good Night!
Mathias
Thanks Mathias!
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Hi Emil,
Any comments on V4
Thanks,
Leo
>-Original Message-
>From: mesa-dev [mailto:mesa-dev-boun...@lists.freedesktop.org] On Behalf Of
>Liu, Leo
>Sent: Monday, September 29, 2014 12:30 PM
>To: Emil Velikov
>Cc: mesa-dev@lists.freedesktop.org; Koenig, Christian
>Subject: Re: [Mesa-dev]
in_var calls the ir_variable constructor, which dups the variable name.
---
src/glsl/builtin_functions.cpp | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp
index 5a024cb..7d61fcc 100644
--- a/src/glsl/builti
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/intel_buffer_objects.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/intel_buffer_objects.c
b/src/mesa/drivers/dri/i965/intel_buffer_objects.c
index 0e19e46..3532de6 100644
--- a/src/mes
Signed-off-by: Chris Forbes
---
src/mesa/drivers/dri/i965/brw_state_upload.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/mesa/drivers/dri/i965/brw_state_upload.c
b/src/mesa/drivers/dri/i965/brw_state_upload.c
index 4ca7cb4..a691319 100644
--- a/src/mesa/drivers/dri/i965/brw_state_upl
In the drivers, we occasionally want to reallocate the backing
store for a buffer object; often to avoid waiting for the GPU
to be finished with the previous contents.
At the point that happens, we don't have a good way of determining
where else the buffer object may be bound, and so no good way o
This series fixes some problems with UBO and TexBO state flagging:
- glTexBuffer() and glTexBufferRange() never actually dirtied anything,
and so didn't work unless something else happened to dirty the correct
state (binding a UBO, or a non-buffer texture, or forcing a batch flush,.. )
- i965
---
Developers writing new tests probably want to know how to do this and be aware
of things like the fact that some binaries are linking Mesa libraries
statically. That certainly had me scratching my head for a while when I was
working on a fix for a unit test that insisted in failing even though
76 matches
Mail list logo
