Re: [Mesa-dev] [PATCH 28/37] i965/gen6/gs: implement transform feedback support in gen6_gs_visitor

2014-09-18 Thread Samuel Iglesias Gonsálvez
On Thu, 2014-09-18 at 16:05 -0700, Jordan Justen wrote: > On Thu, Aug 14, 2014 at 4:12 AM, Iago Toral Quiroga wrote: > > From: Samuel Iglesias Gonsalvez > > > > This takes care of generating code required to handle transform feedback. > > Notice that transform feedback isn't enabled yet, since th

Re: [Mesa-dev] [PATCH 28/37] i965/gen6/gs: implement transform feedback support in gen6_gs_visitor

2014-09-18 Thread Iago Toral Quiroga
On jue, 2014-09-18 at 16:05 -0700, Jordan Justen wrote: > On Thu, Aug 14, 2014 at 4:12 AM, Iago Toral Quiroga wrote: > > From: Samuel Iglesias Gonsalvez > > > > This takes care of generating code required to handle transform feedback. > > Notice that transform feedback isn't enabled yet, since th

[Mesa-dev] [PATCH 1/2] nv50, nvc0: add missing depth/stencil formats to tile flag selection

2014-09-18 Thread Ilia Mirkin
Reported-by: David Heidelberger Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv50/nv50_miptree.c | 4 src/gallium/drivers/nouveau/nvc0/nvc0_miptree.c | 4 2 files changed, 8 insertions(+) diff --git a/src/gallium/drivers/nouveau/nv50/nv50_miptree.c b/src/gallium/drivers

[Mesa-dev] [PATCH 2/2] nv50, nvc0: fix 3d blit logic for odd depth/stencil formats

2014-09-18 Thread Ilia Mirkin
Reported-by: David Heidelberger Signed-off-by: Ilia Mirkin --- src/gallium/drivers/nouveau/nv50/nv50_blit.h| 21 ++--- src/gallium/drivers/nouveau/nv50/nv50_surface.c | 4 2 files changed, 18 insertions(+), 7 deletions(-) diff --git a/src/gallium/drivers/nouveau/nv50/n

[Mesa-dev] [PATCH 0/2] nv50, nvc0: fix weirdo zs formats and their blits

2014-09-18 Thread Ilia Mirkin
There were reports of issues with gallium-nine. It's unclear whether mesa/st uses these, the patches did not produce any piglit changes. However they seem right... Ilia Mirkin (2): nv50,nvc0: add missing depth/stencil formats to tile flag selection nv50,nvc0: fix 3d blit logic for odd depth/st

Re: [Mesa-dev] [PATCH 30/37] i965/gen6/gs: Buffer PSIZ/flags vertex data in gen6_gs_visitor

2014-09-18 Thread Jordan Justen
Reviewed-by: Jordan Justen On Thu, Aug 14, 2014 at 4:12 AM, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Since geometry shaders can alter the value of varyings packed in the first > output VUE slot (PSIZ), we need to buffer it together with all the other > vertex data so we c

[Mesa-dev] [PATCH 1/5] mesa: Remove some dead helper functions.

2014-09-18 Thread Kenneth Graunke
Dead since the _MaxElement removal, but these functions seemed generally applicable, so I decided to remove them in a separate patch. Signed-off-by: Kenneth Graunke --- src/mesa/main/arrayobj.h | 26 -- 1 file changed, 26 deletions(-) diff --git a/src/mesa/main/arrayobj.

[Mesa-dev] [PATCH 5/5] mesa: Replace gl_client_array usage in _mesa_print_arrays()

2014-09-18 Thread Kenneth Graunke
For now, this prints out the same information as before - just using the newer/non-derived structures. Printing out each structure's fields separately might be more useful, but I've never used this code, so I'm not sure. Signed-off-by: Kenneth Graunke --- src/mesa/main/varray.c | 47 +++

[Mesa-dev] [PATCH 2/5] mesa: Use proper structure for glGet*(GL_TEXTURE_COORD_ARRAY*).

2014-09-18 Thread Kenneth Graunke
The code in get.c that handles this uses ctx->Array.VAO->VertexAttrib, which is a gl_vertex_attrib_array structure, not a gl_client_array. The offsets of all fields happened to be the same in both structures, at least on x86_64. "Size," "Type," and "Stride" are obviously the same: both structures

[Mesa-dev] [PATCH 4/5] mesa: Use VertexArray, not _VertexArray, in array size expressions.

2014-09-18 Thread Kenneth Graunke
Both sizes are VERT_ATTRIB_MAX, so this has no effect. But it drops a few trivial uses of the derived state. Signed-off-by: Kenneth Graunke --- src/mesa/main/arrayobj.c | 2 +- src/mesa/main/attrib.c | 2 +- src/mesa/main/varray.c | 8 3 files changed, 6 insertions(+), 6 deletions(

[Mesa-dev] [PATCH 3/5] mesa: Set correct array element in vbo_exec_vtx_init.

2014-09-18 Thread Kenneth Graunke
I'm not familiar with this code, but this sure appears to be a typo. It looks like the intent is to set each array element, not arrays[0] each time. Notably, the loop just below uses "array", not "arrays". Signed-off-by: Kenneth Graunke Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/vbo/vbo

Re: [Mesa-dev] [PATCH 29/37] i965/gen6/gs: Setup SOL surfaces for user-provided geometry shaders

2014-09-18 Thread Jordan Justen
On Thu, Aug 14, 2014 at 4:12 AM, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Update gen6_gs_binding_table and gen6_sol_surface to use user-provided > geometry program information when present. This is necessary to implement > transform feedback support. > > Signed-off-by: Samu

Re: [Mesa-dev] [PATCH 28/37] i965/gen6/gs: implement transform feedback support in gen6_gs_visitor

2014-09-18 Thread Jordan Justen
On Thu, Aug 14, 2014 at 4:12 AM, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > This takes care of generating code required to handle transform feedback. > Notice that transform feedback isn't enabled yet, since that requires > additional setups in other parts of the code that wi

Re: [Mesa-dev] [PATCH 2/3] radeon/winsys: keep track of the last CS a BO was used in

2014-09-18 Thread Marek Olšák
On Thu, Sep 18, 2014 at 5:34 PM, Christian König wrote: > From: Christian König > > Signed-off-by: Christian König > --- > src/gallium/winsys/radeon/drm/radeon_drm_bo.h | 3 +++ > src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 11 +-- > src/gallium/winsys/radeon/drm/radeon_drm_cs.h |

Re: [Mesa-dev] [PATCH 06/11] glsl: Check realloc return value in ir_function::matching_signature()

2014-09-18 Thread Anuj Phogat
On Thu, Sep 18, 2014 at 3:26 AM, Juha-Pekka Heikkila wrote: > On 10.09.2014 00:59, Anuj Phogat wrote: >> On Mon, Sep 8, 2014 at 11:53 PM, Juha-Pekka Heikkila >> wrote: >>> Signed-off-by: Juha-Pekka Heikkila >>> --- >>> src/glsl/ir_function.cpp | 11 +-- >>> 1 file changed, 9 insertions(

[Mesa-dev] [PATCH 2/2] st/xa: silence unused variable warning

2014-09-18 Thread Brian Paul
--- src/gallium/state_trackers/xa/xa_tracker.c |1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/state_trackers/xa/xa_tracker.c b/src/gallium/state_trackers/xa/xa_tracker.c index 268d56b..f69ac8e 100644 --- a/src/gallium/state_trackers/xa/xa_tracker.c +++ b/src/gallium/state_trac

[Mesa-dev] [PATCH 1/2] target-helpers: add inline qualifier on configuration_query()

2014-09-18 Thread Brian Paul
To silence unused function warnings. --- src/gallium/auxiliary/target-helpers/inline_drm_helper.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/target-helpers/inline_drm_helper.h b/src/gallium/auxiliary/target-helpers/inline_drm_helper.h index dd55a7

[Mesa-dev] [PATCH 3/3] radeon/winsys: explicitly sync BOs

2014-09-18 Thread Christian König
From: Christian König For now syncs all engines accessing a BO using the new kernel interface, older kernels should ignore the new chunk and maintain the old behavior. Signed-off-by: Christian König --- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 30 --- src/gallium

[Mesa-dev] [PATCH 1/3] radeon/winsys: always send the INFO chunk

2014-09-18 Thread Christian König
From: Christian König Old kernels that don't know the chunk should simply ignore it. Signed-off-by: Christian König --- src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_cs.

[Mesa-dev] [PATCH 2/3] radeon/winsys: keep track of the last CS a BO was used in

2014-09-18 Thread Christian König
From: Christian König Signed-off-by: Christian König --- src/gallium/winsys/radeon/drm/radeon_drm_bo.h | 3 +++ src/gallium/winsys/radeon/drm/radeon_drm_cs.c | 11 +-- src/gallium/winsys/radeon/drm/radeon_drm_cs.h | 2 +- 3 files changed, 13 insertions(+), 3 deletions(-) diff --git a

Re: [Mesa-dev] [PATCH] i965/fs: Implement SIMD16 dual source blending.

2014-09-18 Thread Iago Toral Quiroga
On jue, 2014-09-18 at 08:08 +0200, Iago Toral Quiroga wrote: > Hi Jason, > > On mié, 2014-09-17 at 11:39 -0700, Jason Ekstrand wrote: > > I haven't tested this yet, just looked it over. I've got a couple of > > inline comments below. One general comment though: I'm currently > > working on a bun

Re: [Mesa-dev] [PATCH 06/11] glsl: Check realloc return value in ir_function::matching_signature()

2014-09-18 Thread Juha-Pekka Heikkila
On 10.09.2014 00:59, Anuj Phogat wrote: > On Mon, Sep 8, 2014 at 11:53 PM, Juha-Pekka Heikkila > wrote: >> Signed-off-by: Juha-Pekka Heikkila >> --- >> src/glsl/ir_function.cpp | 11 +-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> diff --git a/src/glsl/ir_function.cpp b/src/

Re: [Mesa-dev] [PATCH 27/37] i965/gen6/gs: Add an additional parameter to the FF_SYNC opcode.

2014-09-18 Thread Samuel Iglesias Gonsálvez
On Thu, 2014-09-18 at 10:39 +0200, Iago Toral Quiroga wrote: > On jue, 2014-09-18 at 00:48 -0700, Jordan Justen wrote: > > On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga > > wrote: > > > From: Samuel Iglesias Gonsalvez > > > > > > We will use this parameter in later patches to provide infor

Re: [Mesa-dev] [PATCH 27/37] i965/gen6/gs: Add an additional parameter to the FF_SYNC opcode.

2014-09-18 Thread Iago Toral Quiroga
On jue, 2014-09-18 at 00:48 -0700, Jordan Justen wrote: > On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga wrote: > > From: Samuel Iglesias Gonsalvez > > > > We will use this parameter in later patches to provide information relevant > > to transform feedback that needs to be set as part of th

Re: [Mesa-dev] [PATCH 21/37] i965/gen6/gs: Implement support for gl_PrimitiveIdIn.

2014-09-18 Thread Iago Toral Quiroga
On jue, 2014-09-18 at 00:30 -0700, Jordan Justen wrote: > On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga wrote: > > For this we will need to move PrimitiveID information, delivered in the > > thread > > payload in r0.1, to a separate register (we use GS_OPCODE_SET_PRIMITIVE_ID > > for this),

Re: [Mesa-dev] [PATCH] replace file specific compileroptimizationwith inline attibute

2014-09-18 Thread Marc Dietrich
Hello Matt, Am Sonntag, 14. September 2014, 21:12:57 schrieb Matt Turner: > On Fri, Sep 12, 2014 at 1:02 AM, Marc Dietrich wrote: > > Am Donnerstag, 11. September 2014, 08:52:39 schrieb Matt Turner: > >> On Thu, Sep 11, 2014 at 6:58 AM, Marc Dietrich wrote: > >> > File specific optimization as u

[Mesa-dev] [PATCH v2] i965/fs: Implement SIMD16 dual source blending.

2014-09-18 Thread Iago Toral Quiroga
>From the SNB PRM, volume 4, part 1, page 193: "The dual source render target messages only have SIMD8 forms due to maximum message length limitations. SIMD16 pixel shaders must send two of these messages to cover all of the pixels. Each message contains two colors (4 channels each) for each pixel

Re: [Mesa-dev] [PATCH 27/37] i965/gen6/gs: Add an additional parameter to the FF_SYNC opcode.

2014-09-18 Thread Jordan Justen
On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > We will use this parameter in later patches to provide information relevant > to transform feedback that needs to be set as part of the FF_SYNC message. > > Signed-off-by: Samuel Iglesias Gonsalvez >

Re: [Mesa-dev] [PATCH 21/37] i965/gen6/gs: Implement support for gl_PrimitiveIdIn.

2014-09-18 Thread Jordan Justen
On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga wrote: > For this we will need to move PrimitiveID information, delivered in the thread > payload in r0.1, to a separate register (we use GS_OPCODE_SET_PRIMITIVE_ID > for this), then map the corresponding varying slot to that register in the > se