Re: [Mesa-dev] [PATCH] glsl: mark variable as loop constant when it is set read only

2014-09-09 Thread Francisco Jerez
Tapani Pälli writes: > Patch modifies is_loop_constant() to take advantage of 'read_only' bit > in ir_variable to detect a loop constant. Variables marked read-only > are loop constant like mentioned by a comment in the function. > > Signed-off-by: Tapani Pälli > Bugzilla: https://bugs.freedeskt

[Mesa-dev] [PATCH] configure.ac: unbreak the build with non gnu grep

2014-09-09 Thread Jonathan Gray
181581280bd430d122d416e308c1de82db82da04 changed the way the llvm-config version is read from sed to grep and introduced a requirement for gnu grep extension that treats BREs as EREs. Avoid this by calling egrep instead of grep which should be able to handle EREs everywhere. This allows Mesa to b

Re: [Mesa-dev] [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag

2014-09-09 Thread Michel Dänzer
On 10.09.2014 01:28, Alex Deucher wrote: On Mon, Sep 8, 2014 at 9:15 PM, Michel Dänzer wrote: On 09.09.2014 09:47, Michel Dänzer wrote: On 09.09.2014 02:36, Alex Deucher wrote: Updated version with comments integrated. [...] @@ -314,10 +314,12 @@ int radeon_bo_pin_restricted(struct radeo

Re: [Mesa-dev] [PATCH] R600/SI: radeonsi: Program RASTER_CONFIG for harvested GPUs v3

2014-09-09 Thread Michel Dänzer
On 10.09.2014 05:08, Tom Stellard wrote: v2: - Write RASTER_CONFIG for all SEs. v3: - Set GRBM_GFX_INDEX.INSTANCE_BROADCAST_WRITES bit. - Set GRBM_GFX_INFEX.SH_BROADCAST_WRITES bit when done setting PA_SC_RASTER_CONFIG. - Get num_se and num_sh_per_se from kernel. https://bugs.f

Re: [Mesa-dev] [Mesa-stable] [PATCH] Suppress any "libGL:..." warnings when LIBGL_DEBUG == "quiet"

2014-09-09 Thread Stefan Dirsch
On Mon, Sep 08, 2014 at 04:51:37PM +0100, Emil Velikov wrote: > Gents, > > Can anyone review this trivial patch ? > > Stefan, Johannes > Why do I need to register in order to view the bugreport ? Afaict it is not a > security issue, so I believe the bug should be publicly accessible. Sorry, the

Re: [Mesa-dev] [PATCH] Add support for NV_depth_buffer_float v2.

2014-09-09 Thread Ian Romanick
On 09/08/2014 09:39 AM, Mathias Fröhlich wrote: > > Hi, > > On Monday, September 08, 2014 13:16:27 Roland Scheidegger wrote: >>> Add support for the unclamped versions of glDepthRange >>> and relatives. Also starting with OpenGL 4.2 the traditional >>> functions for this should no longer clamp th

Re: [Mesa-dev] [PATCH] glsl: mark variable as loop constant when it is set read only

2014-09-09 Thread Anuj Phogat
On Tue, Sep 9, 2014 at 4:56 AM, Tapani Pälli wrote: > Patch modifies is_loop_constant() to take advantage of 'read_only' bit > in ir_variable to detect a loop constant. Variables marked read-only > are loop constant like mentioned by a comment in the function. > > Signed-off-by: Tapani Pälli > Bu

Re: [Mesa-dev] [PATCH 11/11] egl: extra null checks for get_xcb_screen() return values

2014-09-09 Thread Anuj Phogat
On Mon, Sep 8, 2014 at 11:53 PM, Juha-Pekka Heikkila wrote: > verify get_xcb_screen() returned pointer before using it. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/egl/drivers/dri2/platform_x11.c | 30 -- > 1 file changed, 24 insertions(+), 6 deletions(-) > > d

Re: [Mesa-dev] [PATCH 06/11] glsl: Check realloc return value in ir_function::matching_signature()

2014-09-09 Thread Anuj Phogat
On Mon, Sep 8, 2014 at 11:53 PM, Juha-Pekka Heikkila wrote: > Signed-off-by: Juha-Pekka Heikkila > --- > src/glsl/ir_function.cpp | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/src/glsl/ir_function.cpp b/src/glsl/ir_function.cpp > index 98bec45..2b2643c 1006

Re: [Mesa-dev] [PATCH 09/11] meta: Avoid null access on setup_glsl_msaa_blit_shader()

2014-09-09 Thread Anuj Phogat
On Mon, Sep 8, 2014 at 11:53 PM, Juha-Pekka Heikkila wrote: > On default fallback path there was null access on src_rb > > Signed-off-by: Juha-Pekka Heikkila > --- > src/mesa/drivers/common/meta_blit.c | 20 +++- > 1 file changed, 11 insertions(+), 9 deletions(-) > > diff --git a

Re: [Mesa-dev] [Mesa-stable] [PATCH] Suppress any "libGL:..." warnings when LIBGL_DEBUG == "quiet"

2014-09-09 Thread Emil Velikov
On 09/09/14 11:28, Stefan Dirsch wrote: > On Mon, Sep 08, 2014 at 04:51:37PM +0100, Emil Velikov wrote: >> Gents, >> >> Can anyone review this trivial patch ? >> >> Stefan, Johannes >> Why do I need to register in order to view the bugreport ? Afaict it is not a >> security issue, so I believe the

[Mesa-dev] [Bug 83669] fix build with gcc link time optimizer

2014-09-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83669 --- Comment #3 from Emil Velikov --- (In reply to comment #2) > Well, initially, debug and lto could be exclusive via configure options, > e.g. --enable-debug or --enable-lto. > Actually it's a bit more convoluted than that. Most distro prep -d

[Mesa-dev] [Bug 83679] [regression] build failure in Mesa 10.2 error: 'consts' undeclared (first use in this function)

2014-09-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83679 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 82539] vmw_screen_dri.lo In file included from vmw_screen_dri.c:41: vmwgfx_drm.h:32:17: error: drm.h: No such file or directory

2014-09-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82539 Emil Velikov changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] mesa: fix 10.2 build after commits 548fd6cd, af50ae73

2014-09-09 Thread Emil Velikov
On 09/09/14 20:45, Mark Janes wrote: > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83679 > > Cc: 10.2 > > Two patches which were meant for the 10.3 branch created errors in the > 10.2 branch: > > 548fd6cd2564fe1c4e72ca6b2752fd2584afc7e2 > af50ae73f01bebc312555c49e49e33cbfbaf56e3 >

[Mesa-dev] [Bug 79706] [TRACKER] Mesa regression tracker

2014-09-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79706 Bug 79706 depends on bug 83573, which changed state. Bug 83573 Summary: [swrast] piglit fs-op-not-bool-using-if regression https://bugs.freedesktop.org/show_bug.cgi?id=83573 What|Removed |Added

[Mesa-dev] [PATCH] R600/SI: radeonsi: Program RASTER_CONFIG for harvested GPUs v3

2014-09-09 Thread Tom Stellard
v2: - Write RASTER_CONFIG for all SEs. v3: - Set GRBM_GFX_INDEX.INSTANCE_BROADCAST_WRITES bit. - Set GRBM_GFX_INFEX.SH_BROADCAST_WRITES bit when done setting PA_SC_RASTER_CONFIG. - Get num_se and num_sh_per_se from kernel. https://bugs.freedesktop.org/show_bug.cgi?id=60879 CC: "10.3

[Mesa-dev] [Bug 83669] fix build with gcc link time optimizer

2014-09-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83669 --- Comment #2 from Marc Dietrich --- Well, initially, debug and lto could be exclusive via configure options, e.g. --enable-debug or --enable-lto. I checked a bit further and with my current setup (r600 gallium), it is only the error above and

Re: [Mesa-dev] Please clean your old patches out of Patchwork

2014-09-09 Thread Carl Worth
Emil Velikov writes: > Would appreciate admin access to clear up some of the patches that I've > committed on behalf of other people :) I just went to add this, but it looks like someone beat me to it already. Have fun! -Carl -- carl.d.wo...@intel.com pgp0S6c9mNLZn.pgp Description: PGP sign

[Mesa-dev] [PATCH] mesa: fix 10.2 build after commits 548fd6cd, af50ae73

2014-09-09 Thread Mark Janes
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83679 Cc: 10.2 Two patches which were meant for the 10.3 branch created errors in the 10.2 branch: 548fd6cd2564fe1c4e72ca6b2752fd2584afc7e2 af50ae73f01bebc312555c49e49e33cbfbaf56e3 In both cases, a parameter in 10.2 was converted to a gl

Re: [Mesa-dev] [PATCH 00/26] GLSL memory diet

2014-09-09 Thread Ian Romanick
On 09/04/2014 11:14 PM, Matt Turner wrote: > On Fri, Jul 18, 2014 at 4:35 PM, Matt Turner wrote: >> On Tue, Jul 15, 2014 at 10:37 AM, Matt Turner wrote: >>> On Mon, Jul 14, 2014 at 3:48 PM, Ian Romanick wrote: Most of these patches have been sent to the list already in one form or anot

Re: [Mesa-dev] [PATCH] glsl: Fix memory leak in glsl_lexer.ll

2014-09-09 Thread Ian Romanick
On 09/05/2014 06:22 AM, Juha-Pekka Heikkila wrote: > Running fast clear glClear with SNB caused Valgrind to > complain about this. > > v2: line 237 fixed glClear from leaking memory, other > strdups are also now changed to ralloc_strdups but I > don't know what effect those have. At least no chang

Re: [Mesa-dev] [PATCH] Linking fails when not writing gl_Position.

2014-09-09 Thread Ian Romanick
On 09/09/2014 11:54 AM, Marek Olšák wrote: > On Tue, Sep 9, 2014 at 8:26 PM, Kenneth Graunke wrote: >> On Tuesday, September 09, 2014 10:30:16 AM Ian Romanick wrote: >>> On 09/08/2014 01:10 AM, Tapani Pälli wrote: From: Kalyan Kondapally According to GLSL-ES Spec(i.e. 1.0, 3.0), gl

Re: [Mesa-dev] [Mesa-stable] [PATCH] configure.ac: strip _GNU_SOURCE from llvm-config output

2014-09-09 Thread Emil Velikov
On 06/09/14 04:10, Jonathan Gray wrote: > On Fri, Sep 05, 2014 at 09:00:55PM +0100, Emil Velikov wrote: >> On 05/09/14 16:44, Jonathan Gray wrote: >>> Mesa already defines _GNU_SOURCE for glibc based systems and defining >>> _GNU_SOURCE will break the Mesa build on other systems such as OpenBSD. >>

Re: [Mesa-dev] [PATCH] Linking fails when not writing gl_Position.

2014-09-09 Thread Marek Olšák
On Tue, Sep 9, 2014 at 8:26 PM, Kenneth Graunke wrote: > On Tuesday, September 09, 2014 10:30:16 AM Ian Romanick wrote: >> On 09/08/2014 01:10 AM, Tapani Pälli wrote: >> > From: Kalyan Kondapally >> > >> > According to GLSL-ES Spec(i.e. 1.0, 3.0), gl_Position value is undefined >> > after the ver

Re: [Mesa-dev] [PATCH] configure.ac: detect LLVM patch level when built via cmake

2014-09-09 Thread Emil Velikov
On 09/09/14 16:26, Tom Stellard wrote: > On Sat, Sep 06, 2014 at 01:43:55AM +1000, Jonathan Gray wrote: >> In LLVM 3.4.1 and 3.4.2 the patch level was only set in config.h when >> LLVM was built via autoconf and not when it was built with cmake. >> Fall back to retrieving the patch level from llvm-

Re: [Mesa-dev] [PATCH] Linking fails when not writing gl_Position.

2014-09-09 Thread Kenneth Graunke
On Tuesday, September 09, 2014 10:30:16 AM Ian Romanick wrote: > On 09/08/2014 01:10 AM, Tapani Pälli wrote: > > From: Kalyan Kondapally > > > > According to GLSL-ES Spec(i.e. 1.0, 3.0), gl_Position value is undefined > > after the vertex processing stage if we don't write gl_Position. However, >

Re: [Mesa-dev] [PATCH] Linking fails when not writing gl_Position.

2014-09-09 Thread Ian Romanick
On 09/08/2014 01:10 AM, Tapani Pälli wrote: > From: Kalyan Kondapally > > According to GLSL-ES Spec(i.e. 1.0, 3.0), gl_Position value is undefined > after the vertex processing stage if we don't write gl_Position. However, > GLSL 1.10 Spec mentions that writing to gl_Position is mandatory. In cas

Re: [Mesa-dev] [PATCH] drm/radeon: Add RADEON_GEM_CPU_ACCESS BO creation flag

2014-09-09 Thread Alex Deucher
On Mon, Sep 8, 2014 at 9:15 PM, Michel Dänzer wrote: > On 09.09.2014 09:47, Michel Dänzer wrote: >> On 09.09.2014 02:36, Alex Deucher wrote: >>> >>> Updated version with comments integrated. >> >> [...] >> >>> @@ -314,10 +314,12 @@ int radeon_bo_pin_restricted(struct radeon_bo >>> *bo, u32 domain,

[Mesa-dev] [PATCH] mesa: trim down some #includes

2014-09-09 Thread Brian Paul
--- src/mesa/main/buffers.c |1 - src/mesa/main/clear.c |1 - src/mesa/main/convolve.c |5 + src/mesa/main/eval.c |1 - src/mesa/main/feedback.c |1 - src/mesa/main/fog.c |1 - src/mesa/main/histogram.c |4 +--- 7 files changed, 2 insertions(+), 1

[Mesa-dev] [PATCH] st/mesa: handle failed context creation for core profile

2014-09-09 Thread Brian Paul
If the glx/wgl state tracker requested a core profile but the gallium driver did not support some feature of GL 3.1 or later, we were setting ctx->Version=0 and then failing the assertion in _mesa_initialize_exec_table(). With this change we check for ctx->Version=0 and tear down the context and r

[Mesa-dev] [Bug 83679] New: [regression] build failure in Mesa 10.2 error: 'consts' undeclared (first use in this function)

2014-09-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83679 Priority: medium Bug ID: 83679 Assignee: mesa-dev@lists.freedesktop.org Summary: [regression] build failure in Mesa 10.2 error: 'consts' undeclared (first use in this function)

[Mesa-dev] [Bug 83669] fix build with gcc link time optimizer

2014-09-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83669 --- Comment #1 from Emil Velikov --- I'm not sure if mesa is ready for LTO yet. The main obstacle being "Fix debug information for LTO programs" [1] the second one is that some symbols get stripped too early as you've noticed :) Any patches wou

Re: [Mesa-dev] [PATCH] configure.ac: detect LLVM patch level when built via cmake

2014-09-09 Thread Tom Stellard
On Sat, Sep 06, 2014 at 01:43:55AM +1000, Jonathan Gray wrote: > In LLVM 3.4.1 and 3.4.2 the patch level was only set in config.h when > LLVM was built via autoconf and not when it was built with cmake. > Fall back to retrieving the patch level from llvm-config --version to > handle this case. >

Re: [Mesa-dev] [PATCH 2/2] glsl: fix error message for redeclaring gl_PerVertex as output

2014-09-09 Thread Brian Paul
On 09/09/2014 01:55 AM, Chris Forbes wrote: --- src/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 897505c..62122b7 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -5455,7 +54

Re: [Mesa-dev] [PATCH v3 2/3] mesa/st: add ARB_texture_view support

2014-09-09 Thread Roland Scheidegger
Looks good to me if there's no piglit regressions. Reviewed-by: Roland Scheidegger Am 09.09.2014 02:59, schrieb Ilia Mirkin: > Signed-off-by: Ilia Mirkin > --- > > Roland, it was unclear to me whether you were happy with this change or not. > > v2 -> v3: > no change > > src/mesa/state_trac

[Mesa-dev] [Bug 83669] New: fix build with gcc link time optimizer

2014-09-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83669 Priority: medium Bug ID: 83669 Assignee: mesa-dev@lists.freedesktop.org Summary: fix build with gcc link time optimizer Severity: normal Classification: Unclassified OS: All

[Mesa-dev] [PATCH] glsl: mark variable as loop constant when it is set read only

2014-09-09 Thread Tapani Pälli
Patch modifies is_loop_constant() to take advantage of 'read_only' bit in ir_variable to detect a loop constant. Variables marked read-only are loop constant like mentioned by a comment in the function. Signed-off-by: Tapani Pälli Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82537 ---

Re: [Mesa-dev] [PATCH v3 1/3] gallium: add a texture target to sampler view and a CAP to use it

2014-09-09 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Sep 9, 2014 at 2:59 AM, Ilia Mirkin wrote: > This allows a sampler view to have a different texture target than the > underlying resource. This will be used to implement the type casting > between 2d arrays and cube maps as specified in ARB_texture_view. >

Re: [Mesa-dev] [PATCH] r600: Use DMA transfers in r600_copy_global_buffer

2014-09-09 Thread Niels Ole Salscheider
On Tuesday 09 September 2014, 11:40:49, Bruno Jimenez wrote: > On Mon, 2014-09-08 at 18:30 +0200, Niels Ole Salscheider wrote: > > On Monday 08 September 2014, 15:19:15, Bruno Jimenez wrote: > > > Hi, > > > > > > I'm not sure if this will work. Imagine this case: > > > > > > We have an item in t

Re: [Mesa-dev] [PATCH] r600g, radeonsi: Set RADEON_GEM_NO_CPU_ACCESS flag for tiled BOs

2014-09-09 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Sep 9, 2014 at 5:52 AM, Michel Dänzer wrote: > From: Michel Dänzer > > This lets the kernel know that such BOs can be pinned outside of the CPU > accessible part of VRAM. > > Signed-off-by: Michel Dänzer > --- > src/gallium/drivers/radeon/r600_buffer_co

Re: [Mesa-dev] [PATCH] r600: Use DMA transfers in r600_copy_global_buffer

2014-09-09 Thread Bruno Jimenez
On Mon, 2014-09-08 at 18:30 +0200, Niels Ole Salscheider wrote: > On Monday 08 September 2014, 15:19:15, Bruno Jimenez wrote: > > Hi, > > > > I'm not sure if this will work. Imagine this case: > > > > We have an item in the pool, and we want to use > > r600_resource_copy_region with it, for exam

[Mesa-dev] [Bug 38537] Can't find X headers during 'make'

2014-09-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38537 --- Comment #3 from David --- I quit using mesa when I bought a nvidia graphics card. Mesa and nvidia's drivers seemed to be mutually exclusive. Returning to college forced a change back to MS Windows. I will rebuild my Linux software again in a

[Mesa-dev] [PATCH] i965: add support for RGBA dma_buf imports.

2014-09-09 Thread Gwenole Beauchesne
This allows for importing foreign buffers in RGB32 native endian byte order, i.e. DRM_FORMAT_XBGR, and DRM_FORMAT_ABGR. Signed-off-by: Gwenole Beauchesne --- src/mesa/drivers/dri/i965/intel_screen.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/mesa/drivers/dri/i965/in

[Mesa-dev] [Bug 38537] Can't find X headers during 'make'

2014-09-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38537 --- Comment #2 from Emil Velikov --- Actually the bug can be almost anywhere. Here is some more info: Commit 1a7275de (from the 9.2 devel cycle) adds a MESA_EGL_NO_X11_HEADERS define which should avoid the X11/Xlib.h inclusion from include/EGL/e

[Mesa-dev] [PATCH 1/2] i965/vec4: slightly improve insn dumping with no srcs

2014-09-09 Thread Chris Forbes
Previously, we would get a trailing ', ' which looked strange. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/brw_vec4.cpp index cda

[Mesa-dev] [PATCH 2/2] glsl: fix error message for redeclaring gl_PerVertex as output

2014-09-09 Thread Chris Forbes
--- src/glsl/ast_to_hir.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 897505c..62122b7 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hir.cpp @@ -5455,7 +5455,7 @@ ast_interface_block::hir(exec_list *inst

[Mesa-dev] [Bug 38537] Can't find X headers during 'make'

2014-09-09 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=38537 Tapani Pälli changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---