Re: [Mesa-dev] [PATCH 02/37] i965/gen6/gs: refactor gen6_gs_state

2014-09-03 Thread Iago Toral Quiroga
On mié, 2014-09-03 at 18:51 -0700, Jordan Justen wrote: > Rather than: > i965/gen6/gs: refactor gen6_gs_state > > How about something like: > i965/gen6/gs: Skeleton for user GS program support Sure, that sounds good to me. > (more below) > > On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga

Re: [Mesa-dev] [PATCH 01/37] i965/gs: Use single dispatch mode as fallback to dual object mode when possible.

2014-09-03 Thread Iago Toral Quiroga
On mié, 2014-09-03 at 17:49 -0700, Jordan Justen wrote: > On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga wrote: > > Currently, when a geometry shader can't use dual object mode we fall back to > > dual instance mode, however, when invocations == 1, single dispatch mode is > > more performant

Re: [Mesa-dev] [PATCH] glsl: Fix memory leak in glsl_lexer.ll

2014-09-03 Thread Aras Pranckevicius
> > > --- a/src/glsl/glsl_lexer.ll > > +++ b/src/glsl/glsl_lexer.ll > > @@ -232,7 +232,8 @@ HASH^{SPC}#{SPC} > > [ \t\r]* { } > > : return COLON; > > [_a-zA-Z][_a-zA-Z0-9]* { > > - yylval->identifier

[Mesa-dev] [PATCH 4/5] i965: just avoid warnings with fp64

2014-09-03 Thread Dave Airlie
This just fills in some blanks to avoid warnings in the i965 driver. Signed-off-by: Dave Airlie --- src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 12 src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 13 + src/mesa/drivers/dri/i965/brw_shader.cpp

[Mesa-dev] [PATCH 2/5] glsl: support array constructors for double arrays

2014-09-03 Thread Dave Airlie
From: Tapani Pälli Arrays with double element type may be constructed using different type, patch adds implicit conversion. Signed-off-by: Tapani Pälli --- src/glsl/ast_function.cpp | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/glsl/ast_function.cpp b/s

[Mesa-dev] [PATCH 5/5] mesa/st: fp64 support is wip for st/mesa

2014-09-03 Thread Dave Airlie
From: Dave Airlie just avoid the warnings in the tree for now. Signed-off-by: Dave Airlie --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp ind

[Mesa-dev] [PATCH 1/5] glsl: support double in ir_binop_vector_extract

2014-09-03 Thread Dave Airlie
From: Tapani Pälli Patch makes following Piglit test pass: glsl-double-const-expr-vector-extract.shader_test Signed-off-by: Tapani Pälli --- src/glsl/ir_constant_expression.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/ir_constant_expression.cpp b/src/glsl/ir_constant

[Mesa-dev] [PATCH 3/5] glsl: support double when constructing matrix from scalar

2014-09-03 Thread Dave Airlie
From: Tapani Pälli Patch adds support for both const and non-const cases. Patch makes following Piglit test pass: glsl-double-conversion-constructor-01.shader_test Signed-off-by: Tapani Pälli --- src/glsl/ast_function.cpp | 17 +++-- src/glsl/ir.cpp | 13 ++---

[Mesa-dev] last 5 patches for fp64

2014-09-03 Thread Dave Airlie
ISP disliked me sending 20 patches in one session, so it ate 5. Also in my arb_gpu_shader_fp64-submit branch. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] arb_gpu_shader_fp64 core pieces

2014-09-03 Thread Ilia Mirkin
On Thu, Sep 4, 2014 at 12:15 AM, Dave Airlie wrote: > Hi, > > Second posting for this series, I think I've taken all the reviews on board, > I've also included Tapani's work so far in this series. > > I've talked to Tapani and we both agree we should probably merge the core > pieces of this first

[Mesa-dev] [PATCH 15/20] glsl: support double increment in ir_loop controls

2014-09-03 Thread Dave Airlie
From: Tapani Pälli Patch makes following Piglit test pass: arb_gpu_shader_fp64/compiler/double-loop-iterator.vert v2: make also sure that calculate_iterations handles double correctly, now the test *really* passes Signed-off-by: Tapani Pälli --- src/glsl/loop_controls.cpp | 19

[Mesa-dev] arb_gpu_shader_fp64 core pieces

2014-09-03 Thread Dave Airlie
Hi, Second posting for this series, I think I've taken all the reviews on board, I've also included Tapani's work so far in this series. I've talked to Tapani and we both agree we should probably merge the core pieces of this first so the Intel work can proceed without constant rebasing and I can

[Mesa-dev] [PATCH 11/20] glsl: lower double optional passes

2014-09-03 Thread Dave Airlie
These lowering passes are optional for the backend to request, currently the TGSI softpipe backend most likely the r600g backend would want to use these passes as is. They aim to hit the gallium opcodes from the standard rounding/truncation functions. Signed-off-by: Dave Airlie --- src/glsl/ir_o

[Mesa-dev] [PATCH 14/20] glsl: add double support to constant propagation pass

2014-09-03 Thread Dave Airlie
From: Tapani Pälli Signed-off-by: Tapani Pälli --- src/glsl/opt_constant_propagation.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/opt_constant_propagation.cpp b/src/glsl/opt_constant_propagation.cpp index c334e12..90cc0c8 100644 --- a/src/glsl/opt_constant_propagation.cp

[Mesa-dev] [PATCH 12/20] glsl: validate output types for shader stages

2014-09-03 Thread Dave Airlie
From: Tapani Pälli Patch fixes Piglit test: arb_gpu_shader_fp64/preprocessor/fs-output-double.frag and adds additional validation for shader outputs. Signed-off-by: Tapani Pälli Signed-off-by: Dave Airlie --- src/glsl/ast_to_hir.cpp | 47 +++ 1

[Mesa-dev] [PATCH 08/20] glsl: enable/disable certain lowering passes for doubles

2014-09-03 Thread Dave Airlie
We want to restrict some lowering passes to floats only, and enable other for doubles. Signed-off-by: Dave Airlie --- src/glsl/lower_instructions.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/glsl/lower_instructions.cpp b/src/glsl/lower_instructions.cpp index

[Mesa-dev] [PATCH 07/20] glsl: add double support

2014-09-03 Thread Dave Airlie
This adds the guts of the fp64 implementation to the GLSL compiler. - builtin double types - double constant support - lexer parsing for double types (lf, LF) - enforcing flat on double fs inputs - double operations (d2f,f2d, pack/unpack, frexp - in 2 parts) - ir builder bits. - double constant ex

[Mesa-dev] [PATCH 13/20] glsl: fixes to implicit conversions required by GL_ARB_gpu_shader_fp64

2014-09-03 Thread Dave Airlie
From: Tapani Pälli Patch makes following Piglit test pass: arb_gpu_shader_fp64/compiler/implicit-conversions.vert v2: fix issues in 'can_implicitly_convert_to' and take has_double() in use (Dave Airlie) Signed-off-by: Tapani Pälli --- src/glsl/ast_to_hir.cpp | 10 +

[Mesa-dev] [PATCH 01/20] glapi: add ARB_gpu_shader_fp64 (v2)

2014-09-03 Thread Dave Airlie
From: Dave Airlie Just add the xml file covering this extension, and dummy interface files in mesa, and fix up sanity tests. v2: Enable ProgramUniform*d* from ARB_separate_shader_objects (Ian) use 40 instead of 43 for dispatch_sanity.cpp (Chris) uncomment PU sanity tests. Signed-off-by: Dave Ai

[Mesa-dev] [PATCH 04/20] glsl: add double type

2014-09-03 Thread Dave Airlie
From: Dave Airlie This just adds a placeholder for the GLSL_TYPE_DOUBLE. This causes a lot of warnings about unchecked type in switch statements - fix them later. Signed-off-by: Dave Airlie --- src/glsl/glsl_types.h | 1 + 1 file changed, 1 insertion(+) diff --git a/src/glsl/glsl_types.h b/s

[Mesa-dev] [PATCH 09/20] glsl/lower_instructions: add double lowering passes

2014-09-03 Thread Dave Airlie
This lowers double dot product and lrp to fma. Signed-off-by: Dave Airlie --- src/glsl/lower_instructions.cpp | 83 + 1 file changed, 83 insertions(+) diff --git a/src/glsl/lower_instructions.cpp b/src/glsl/lower_instructions.cpp index 03df07f..556b607 10

[Mesa-dev] [PATCH 03/20] mesa: add mesa_type_is_double helper function (v2)

2014-09-03 Thread Dave Airlie
This is a helper to return if a type is based on a double. v2: GLboolean->bool (Ian) Reviewed-by: Ian Romanick Signed-off-by: Dave Airlie --- src/mesa/program/prog_parameter.h | 22 ++ 1 file changed, 22 insertions(+) diff --git a/src/mesa/program/prog_parameter.h b/src/m

[Mesa-dev] [PATCH 06/20] glsl: add ARB_gpu_shader_fp64 to the glsl extensions. (v2)

2014-09-03 Thread Dave Airlie
From: Dave Airlie v2: add define bit (Tapani Pälli) Patch makes following Piglit tests pass: arb_gpu_shader_fp64/preprocessor/define.vert arb_gpu_shader_fp64/preprocessor/define.frag Reviewed-by: Ian Romanick Signed-off-by: Dave Airlie --- src/glsl/glcpp/glcpp-parse.y| 3 +++ s

[Mesa-dev] [PATCH 05/20] mesa: add double uniform support. (v2)

2014-09-03 Thread Dave Airlie
From: Dave Airlie This adds support for the new uniform interfaces from ARB_gpu_shader_fp64. v2: support ARB_separate_shader_objects ProgramUniform*d* (Ian) don't allow boolean uniforms to be updated (issue 15) (Ian) Signed-off-by: Dave Airlie --- src/mesa/main/uniform_query.cpp | 52 +

[Mesa-dev] [PATCH 02/20] mesa: add ARB_gpu_shader_fp64 extension info (v2)

2014-09-03 Thread Dave Airlie
From: Dave Airlie This just adds the entries to extensions.c and mtypes.h v2: use core profile only (Ian) Signed-off-by: Dave Airlie --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/mai

[Mesa-dev] [PATCH 10/20] glsl: implement double builtin functions

2014-09-03 Thread Dave Airlie
This implements the bulk of the builtin functions for fp64 support. Signed-off-by: Dave Airlie --- src/glsl/builtin_functions.cpp | 751 +++-- 1 file changed, 492 insertions(+), 259 deletions(-) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_f

Re: [Mesa-dev] [PATCH 06/37] i965/gs: Reuse gen6 constant push buffers setup code in gen7+.

2014-09-03 Thread Jordan Justen
On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > The code required for gen6 and gen7+ is almost the same, so reuse it. I had a question in patch 5 related to this code, but: Reviewed-by: Jordan Justen > Signed-off-by: Samuel Iglesias Gonsalvez >

Re: [Mesa-dev] [PATCH 05/37] i965/gen6/gs: Setup constant push buffers for gen6 geometry shaders.

2014-09-03 Thread Jordan Justen
On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga wrote: > --- > src/mesa/drivers/dri/i965/brw_state.h| 1 + > src/mesa/drivers/dri/i965/brw_state_upload.c | 1 + > src/mesa/drivers/dri/i965/gen6_gs_state.c| 59 > ++-- > 3 files changed, 49 insertions(+),

Re: [Mesa-dev] [PATCH 03/37] i965/gen6/gs: use brw_gs_prog atom instead of brw_ff_gs_prog

2014-09-03 Thread Jordan Justen
Reviewed-by: Jordan Justen On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > This is needed to support user-provided geometry shaders, since the > brw_ff_gs_prog atom in gen6 only takes care of implementing transform feedback > for vertex shaders.

Re: [Mesa-dev] [PATCH 04/37] i965/gen6/gs: Set brw->gs.enabled to FALSE in gen6_blorp_emit_gs_disable()

2014-09-03 Thread Jordan Justen
On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > Reference 7dfb4b2d00ddb8e5ee24d4c58eb9415dc4ccc21c in commit message? Reviewed-by: Jordan Justen > Signed-off-by: Samuel Iglesias Gonsalvez > --- > src/mesa/drivers/dri/i965/gen6_blorp.cpp | 1 + >

Re: [Mesa-dev] [PATCH 02/37] i965/gen6/gs: refactor gen6_gs_state

2014-09-03 Thread Jordan Justen
Rather than: i965/gen6/gs: refactor gen6_gs_state How about something like: i965/gen6/gs: Skeleton for user GS program support (more below) On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga wrote: > From: Samuel Iglesias Gonsalvez > > Currently, gen6 only uses geometry shaders for transform

Re: [Mesa-dev] [PATCH 01/37] i965/gs: Use single dispatch mode as fallback to dual object mode when possible.

2014-09-03 Thread Jordan Justen
On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga wrote: > Currently, when a geometry shader can't use dual object mode we fall back to > dual instance mode, however, when invocations == 1, single dispatch mode is > more performant and equally efficient in terms of register pressure. > > Single

Re: [Mesa-dev] [PATCH 00/37] Geometry shader support in Sandy Bridge

2014-09-03 Thread Jordan Justen
On Wed, Aug 20, 2014 at 3:18 AM, Samuel Iglesias Gonsálvez wrote: > On Wed, 2014-08-20 at 11:16 +0200, Iago Toral wrote: >> El 2014-08-16 09:11, Jordan Justen escribió: >> > On Thu, Aug 14, 2014 at 4:11 AM, Iago Toral Quiroga >> > wrote: >> >> Hi, >> >> >> >> this series brings support for geomet

Re: [Mesa-dev] [PATCH 3/3] glsl: Report progress from opt_copy_propagation_elements().

2014-09-03 Thread Matt Turner
All three are Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] Please clean your old patches out of Patchwork

2014-09-03 Thread Matt Turner
On Wed, Sep 3, 2014 at 4:50 PM, Timothy Arceri wrote: > I've cleaned out my patches there is just one remaining from April for > which I'd still like to get a rb so I can push. > > glapi: Add KHR_debug functions to check_table test > > http://patchwork.freedesktop.org/patch/23628/ Oh, good. This

Re: [Mesa-dev] SandyBridge issue likely related to fast color clears using meta operations

2014-09-03 Thread Kenneth Graunke
On Wednesday, September 03, 2014 11:00:06 PM Kristian Høgsberg wrote: > On Wed, Sep 3, 2014 at 10:00 PM, Jordan Justen wrote: > > On 2014-09-03 10:41:02, Kenneth Graunke wrote: > >> On Tuesday, September 02, 2014 06:16:01 PM Samuel Iglesias Gonsálvez wrote: > >> > Hello, > >> > > >> > Two weeks ag

Re: [Mesa-dev] Please clean your old patches out of Patchwork

2014-09-03 Thread Timothy Arceri
I've cleaned out my patches there is just one remaining from April for which I'd still like to get a rb so I can push. glapi: Add KHR_debug functions to check_table test http://patchwork.freedesktop.org/patch/23628/ On Wed, 2014-09-03 at 15:21 -0700, Matt Turner wrote: > We're up to 16 pages of

Re: [Mesa-dev] [PATCH 1/2] Eliminate several cases of multiplication in arguments to calloc

2014-09-03 Thread Matt Turner
On Wed, Sep 3, 2014 at 4:09 PM, Carl Worth wrote: > In commit 32f2fd1c5d6088692551c80352b7d6fa35b0cd09, several calls to > _mesa_calloc(x) were replaced with calls to calloc(1, x). This is strictly > equivalent to what the code was doing previously. > > But for cases where "x" involves multiplicat

[Mesa-dev] [PATCH] i965/blorp: Pass image formats seperately from the miptree

2014-09-03 Thread Jason Ekstrand
When a texture is wrapped in a texture view, we can't trust the format in the miptree itself. This patch allows us to pass the format seperately through blorp so we can proprerly handled wrapped textures. It's worth noting here that we can use the miptree format directly for depth/stencil formats

[Mesa-dev] [PATCH 1/2] Eliminate several cases of multiplication in arguments to calloc

2014-09-03 Thread Carl Worth
In commit 32f2fd1c5d6088692551c80352b7d6fa35b0cd09, several calls to _mesa_calloc(x) were replaced with calls to calloc(1, x). This is strictly equivalent to what the code was doing previously. But for cases where "x" involves multiplication, now that we are explicitly using the two-argument callo

[Mesa-dev] [PATCH 2/2] egl: Restrict multiplication in calloc arguments to use compile-time constants

2014-09-03 Thread Carl Worth
As explained in the previous commit, we want to avoid the possibility of integer-multiplication overflow while allocating buffers. In these two cases, the final allocation size is the product of three values: one variable and two that are fixed constants at compile time. In this commit, we move t

[Mesa-dev] [Bug 83463] New: [swrast] piglit glsl-vs-clamp-1 regression

2014-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83463 Priority: medium Bug ID: 83463 Keywords: bisected, regression CC: i...@freedesktop.org, matts...@gmail.com, xynop...@gmail.com Assignee: mesa-dev@lists.freedesktop.org

Re: [Mesa-dev] SandyBridge issue likely related to fast color clears using meta operations

2014-09-03 Thread Kristian Høgsberg
On Wed, Sep 3, 2014 at 10:00 PM, Jordan Justen wrote: > On 2014-09-03 10:41:02, Kenneth Graunke wrote: >> On Tuesday, September 02, 2014 06:16:01 PM Samuel Iglesias Gonsálvez wrote: >> > Hello, >> > >> > Two weeks ago, Iago and myself sent a batch of patches that added >> > geometry shader support

[Mesa-dev] [Bug 83149] Syntax error in setup_glsl_blit_framebuffer() with VS2012

2014-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83149 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] glsl/glsl_parser_extras: Handle GLSL 4.50

2014-09-03 Thread Matt Turner
On Fri, Aug 22, 2014 at 1:29 AM, Olivier Galibert wrote: > Signed-off-by: Olivier Galibert > --- > src/glsl/glsl_parser_extras.cpp | 2 +- > src/glsl/glsl_parser_extras.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl

Re: [Mesa-dev] [PATCH] i965: Handle ir_triop_csel in emit_bool_to_cond_code().

2014-09-03 Thread Matt Turner
Thought I'd reviewed this already. Reviewed-by: Matt Turner I suppose it should be marked for 10.3. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] Please clean your old patches out of Patchwork

2014-09-03 Thread Matt Turner
We're up to 16 pages of patches. Please take a look at your patches and clear out the old ones. http://patchwork.freedesktop.org/project/mesa/list/ If you're not an administrator, I believe you can still manage your own patches. If you'd like to be an administrator, reply and someone will add you

Re: [Mesa-dev] [PATCH] mesa/program_cache: calloc the correct size for the cache.

2014-09-03 Thread Carl Worth
Carl Worth writes: > And here's another that isn't the same pattern, (no "1", so not part of > the same search/replace issue), but potentially still worth looking > at. Here, there are three things being multiplied. I haven't looked at ... > src/mesa/tnl/t_vertex.c: vtx->vertex_buf = _mesa_al

Re: [Mesa-dev] i965 CS state tracking

2014-09-03 Thread Jordan Justen
On 2014-09-03 12:20:49, Kenneth Graunke wrote: > On Wednesday, September 03, 2014 11:34:33 AM Jordan Justen wrote: > > Can we discuss and implement an alternative approach rather than > > reverting it? I don't think it is wrong, but maybe could (perhaps) be > > done better. > > There's clearly deb

[Mesa-dev] [PATCH] r600g, radeonsi: make sure there's enough CS space before resuming queries

2014-09-03 Thread Marek Olšák
From: Marek Olšák Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=83432 Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeon/r600_query.c | 28 1 file changed, 28 insertions(+) diff --git a/src/gallium/drivers/radeon/r600_query.c b/src/galli

Re: [Mesa-dev] SandyBridge issue likely related to fast color clears using meta operations

2014-09-03 Thread Jordan Justen
On 2014-09-03 10:41:02, Kenneth Graunke wrote: > On Tuesday, September 02, 2014 06:16:01 PM Samuel Iglesias Gonsálvez wrote: > > Hello, > > > > Two weeks ago, Iago and myself sent a batch of patches that added > > geometry shader support for SandyBridge [0]. > > > > Recently, we rebased our patch

Re: [Mesa-dev] [PATCH] i965: possible typo in ir_unop_f2b case.

2014-09-03 Thread Dave Airlie
On 4 September 2014 05:02, Matt Turner wrote: > On Mon, Sep 1, 2014 at 4:15 PM, Dave Airlie wrote: >> From: Dave Airlie >> >> Coverity reported this, I'm not sure this patch is correct, but I'm sure >> someone who knows can fix this or push my fix. >> >> Signed-off-by: Dave Airlie >> --- >> sr

Re: [Mesa-dev] i965 CS state tracking

2014-09-03 Thread Kenneth Graunke
On Thursday, September 04, 2014 07:30:27 AM Chris Forbes wrote: > On Thu, Sep 4, 2014 at 7:20 AM, Kenneth Graunke wrote: > > I know that you can link together VS/GS/FS/HS/DS and CS together in a > > single GLSL linked program, and it just uses the 3D shaders or the compute > > shader depending w

[Mesa-dev] [PATCH] state_tracker: Fix bug in conditional discards with native ints.

2014-09-03 Thread Eric Anholt
A bool is 0 or ~0, and KILL_IF takes a float arg that's <0 for discard or >= 0 for not. By negating it, we ended up doing a floating point subtract of (0 - ~0), which ended up as an inf. To make this actually work, we need to convert the bool to a float. --- src/mesa/state_tracker/st_glsl_to_tgs

Re: [Mesa-dev] [PATCH] i915: Fix black buffers when importing prime fds

2014-09-03 Thread Andreas Pokorny
Hi, I have to apologize again for the wrong tag. This fix is also needed on 10.3. regards Andreas On Wed, Aug 27, 2014 at 9:36 AM, Andreas Pokorny < andreas.poko...@canonical.com> wrote: > Width and Height of the imported image was never initialized from the > imported bo. > > Signed-off-by: An

Re: [Mesa-dev] [PATCH] mesa/program_cache: calloc the correct size for the cache.

2014-09-03 Thread Carl Worth
Matt Turner writes: > git blaming that turns up a sloppy search and replace commit that > replaced _mesa_calloc(x) (taking only one argument) with calloc(1, x), > even when x was a multiplication expression. Thanks for chasing that down. > If someone wants to fix these up: git grep 'calloc.* \*

[Mesa-dev] [PATCH 1/1] egl/drm: expose KHR_image_pixmap extension

2014-09-03 Thread Andreas Pokorny
This changes enables EGL_KHR_image_pixmap in the egl drm platform, which is implemented there but has not been advertised yet. Signed-off-by: Andreas Pokorny --- src/egl/drivers/dri2/platform_drm.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/egl/drivers/dri2/platform_drm.c b/src/e

Re: [Mesa-dev] [PATCH 4/4] i965/copy_image: Divide the x offsets by block width when using the blitter

2014-09-03 Thread Jason Ekstrand
On Wed, Sep 3, 2014 at 11:58 AM, Matt Turner wrote: > On Tue, Sep 2, 2014 at 3:49 PM, Jason Ekstrand > wrote: > > Signed-off-by: Jason Ekstrand > > --- > > src/mesa/drivers/dri/i965/intel_copy_image.c | 31 > +++- > > 1 file changed, 21 insertions(+), 10 deletions(-) >

Re: [Mesa-dev] i965 CS state tracking

2014-09-03 Thread Chris Forbes
On Thu, Sep 4, 2014 at 7:20 AM, Kenneth Graunke wrote: > I know that you can link together VS/GS/FS/HS/DS and CS together in a single > GLSL linked program, and it just uses the 3D shaders or the compute shader > depending whether you use glDraw* or glDispatchCompute. So, if you did that, > we

Re: [Mesa-dev] [PATCH 0/3] Pixman for Mesa

2014-09-03 Thread Juha-Pekka Heikkilä
On Wed, Sep 3, 2014 at 7:31 PM, Brian Paul wrote: > On 08/28/2014 06:51 AM, Juha-Pekka Heikkila wrote: >> >> Here is new version of my patch set for using Pixman in Mesa >> for texture format conversions, mostly complete rewrite after recent >> changes in src/mesa/main/texstore.c. This set does no

Re: [Mesa-dev] i965 CS state tracking

2014-09-03 Thread Kenneth Graunke
On Wednesday, September 03, 2014 11:34:33 AM Jordan Justen wrote: > On 2014-09-03 10:14:34, Kenneth Graunke wrote: > > On Wednesday, September 03, 2014 09:22:12 AM Jordan Justen wrote: > > > > 15:22:24 Kayden | jljusten: so how does the compute shader state upload > > > > work? > > > > 15:22:35 Ka

Re: [Mesa-dev] [PATCH] mesa/program_cache: calloc the correct size for the cache.

2014-09-03 Thread Matt Turner
On Mon, Sep 1, 2014 at 4:22 PM, Dave Airlie wrote: > From: Dave Airlie > > Coverity reported this, and I think this is the right solution, > since cache->items is struct cache_item ** not struct cache_item *, > we also realloc it using struct cache_item * at some point. > > Signed-off-by: Dave Ai

Re: [Mesa-dev] [PATCH] i965: possible typo in ir_unop_f2b case.

2014-09-03 Thread Matt Turner
On Mon, Sep 1, 2014 at 4:15 PM, Dave Airlie wrote: > From: Dave Airlie > > Coverity reported this, I'm not sure this patch is correct, but I'm sure > someone who knows can fix this or push my fix. > > Signed-off-by: Dave Airlie > --- > src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 +- > 1 fi

Re: [Mesa-dev] [PATCH 4/4] i965/copy_image: Divide the x offsets by block width when using the blitter

2014-09-03 Thread Matt Turner
On Tue, Sep 2, 2014 at 3:49 PM, Jason Ekstrand wrote: > Signed-off-by: Jason Ekstrand > --- > src/mesa/drivers/dri/i965/intel_copy_image.c | 31 > +++- > 1 file changed, 21 insertions(+), 10 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_copy_image.c > b/

Re: [Mesa-dev] i965 CS state tracking

2014-09-03 Thread Jordan Justen
On 2014-09-03 10:14:34, Kenneth Graunke wrote: > On Wednesday, September 03, 2014 09:22:12 AM Jordan Justen wrote: > > > 15:22:24 Kayden | jljusten: so how does the compute shader state upload > > > work? > > > 15:22:35 Kayden | I know you have to issue PIPELINE_SELECT to pick the > > >

Re: [Mesa-dev] [PATCH] glsl: Fix memory leak in glsl_lexer.ll

2014-09-03 Thread Matt Turner
On Wed, Sep 3, 2014 at 7:03 AM, Juha-Pekka Heikkila wrote: > Running fast clear glClear with SNB caused Valgrind to > complain about this. > > Signed-off-by: Juha-Pekka Heikkila > --- > src/glsl/glsl_lexer.ll | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/src/glsl/gls

Re: [Mesa-dev] SandyBridge issue likely related to fast color clears using meta operations

2014-09-03 Thread Kenneth Graunke
On Tuesday, September 02, 2014 06:16:01 PM Samuel Iglesias Gonsálvez wrote: > Hello, > > Two weeks ago, Iago and myself sent a batch of patches that added > geometry shader support for SandyBridge [0]. > > Recently, we rebased our patches against master [1] and found > that some things are not wo

Re: [Mesa-dev] i965 CS state tracking

2014-09-03 Thread Kenneth Graunke
On Wednesday, September 03, 2014 09:22:12 AM Jordan Justen wrote: > > 15:22:24 Kayden | jljusten: so how does the compute shader state upload > > work? > > 15:22:35 Kayden | I know you have to issue PIPELINE_SELECT to pick the > > | GPGPU pipe instead of 3D > > 15:22:53 Kayden | bu

Re: [Mesa-dev] [PATCH 0/3] Pixman for Mesa

2014-09-03 Thread Brian Paul
On 08/28/2014 06:51 AM, Juha-Pekka Heikkila wrote: Here is new version of my patch set for using Pixman in Mesa for texture format conversions, mostly complete rewrite after recent changes in src/mesa/main/texstore.c. This set does not cause regressions in Piglit quick set on SNB. Here are some

Re: [Mesa-dev] [PATCH] gallivm: Fix build against LLVM SVN >= r216982

2014-09-03 Thread Tom Stellard
On Wed, Sep 03, 2014 at 11:36:34AM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > Only MCJIT is available anymore. > Pushed, thanks. -Tom > Signed-off-by: Michel Dänzer > --- > src/gallium/auxiliary/gallivm/lp_bld_init.c | 9 + > src/gallium/auxiliary/gallivm/lp_bld_misc.cp

[Mesa-dev] [Bug 83445] New: eglSwapBuffers() crash on dri

2014-09-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=83445 Priority: medium Bug ID: 83445 Assignee: mesa-dev@lists.freedesktop.org Summary: eglSwapBuffers() crash on dri Severity: normal Classification: Unclassified OS: All

Re: [Mesa-dev] [PATCH] Fix assertion which fails for unsigned array indices.

2014-09-03 Thread Brian Paul
On 08/30/2014 12:30 PM, tiffany wrote: According to the GLSL 1.40 spec, section 5.7 Structure and Array Operations: "Array elements are accessed using an expression whose type is int or uint." --- src/glsl/lower_variable_index_to_cond_assign.cpp | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-09-03 Thread Tom Stellard
On Tue, Sep 02, 2014 at 12:55:44PM -0700, Eric Anholt wrote: > Tom Stellard writes: > > > On Wed, Aug 27, 2014 at 03:07:36PM -0700, Ian Romanick wrote: > >> On 08/27/2014 02:55 PM, Marek Olšák wrote: > >> > Our plan is to always require the latest released version of LLVM > >> > because of new fe

Re: [Mesa-dev] [PATCH] mesa: invalidate draw state in glPopClientAttrib

2014-09-03 Thread Brian Paul
On 09/01/2014 12:05 PM, Marek Olšák wrote: From: Marek Olšák Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=82538 Cc: mesa-sta...@lists.freedesktop.org --- src/mesa/main/attrib.c | 4 1 file changed, 4 insertions(+) diff --git a/src/mesa/main/attrib.c b/src/mesa/main/attrib.c

Re: [Mesa-dev] [PATCH] gallivm: Fix build against LLVM SVN >= r216982

2014-09-03 Thread Roland Scheidegger
Oh, interesting. The patch though is Reviewed-by: Roland Scheidegger Am 03.09.2014 04:36, schrieb Michel Dänzer: > From: Michel Dänzer > > Only MCJIT is available anymore. > > Signed-off-by: Michel Dänzer > --- > src/gallium/auxiliary/gallivm/lp_bld_init.c | 9 + > src/gallium/aux

[Mesa-dev] [PATCH] glsl: Fix memory leak in glsl_lexer.ll

2014-09-03 Thread Juha-Pekka Heikkila
Running fast clear glClear with SNB caused Valgrind to complain about this. Signed-off-by: Juha-Pekka Heikkila --- src/glsl/glsl_lexer.ll | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/glsl_lexer.ll b/src/glsl/glsl_lexer.ll index b7c4aad..a9274a3 100644 --- a/src/