Re: [Mesa-dev] [PATCH] glcpp: Don't use alternation in the lookahead for empty pragmas.

2014-08-18 Thread Kenneth Graunke
On Monday, August 18, 2014 11:49:13 AM Carl Worth wrote: > We've found that there's a buffer overrun bug in flex that's triggered by > using alternation in a lookahead pattern. > > Fortunately, we don't need to match the exact {NEWLINE} expression to detect > an empty pragma. It suffices to verify

Re: [Mesa-dev] [PATCH 1/3] i965: Flush the RC and TC before doing a fast clear resolve

2014-08-18 Thread Kristian Høgsberg
On Mon, Aug 18, 2014 at 5:23 PM, Chris Forbes wrote: > Also fixes gears! ;) ... and how could I break glxgears. For the record, though, I had no piglit regressions with this series and I didn't see the glxgears artifacts on mv IVB laptop or BDW machine. Thanks for verifying. Kristian > Review

Re: [Mesa-dev] [PATCH] gallium/radeon: Do not use u_upload_mgr for buffer downloads

2014-08-18 Thread Michel Dänzer
On 15.08.2014 03:22, Niels Ole Salscheider wrote: > Instead create a staging texture with pipe_buffer_create and > PIPE_USAGE_STAGING. > > u_upload_mgr sets the usage of its staging buffer to PIPE_USAGE_STREAM. > But since 150ac07b855b5c5f879bf6ce9ca421ccd1a6c938 CPU -> GPU streaming > buffers >

Re: [Mesa-dev] [PATCH 3/6] radeonsi: don't set CB_SHADER_MASK=1 if there are no color outputs

2014-08-18 Thread Michel Dänzer
On 19.08.2014 06:52, Marek Olšák wrote: > From: Marek Olšák > > This hack isn't needed anymore because of the previous u_blitter commit. The radeonsi changes are Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast

[Mesa-dev] [PATCH] r300g: Fix path to test programs for out-of-tree builds

2014-08-18 Thread Michel Dänzer
From: Michel Dänzer Fixes make check in that case. Signed-off-by: Michel Dänzer --- src/gallium/drivers/r300/Makefile.am | 1 + src/gallium/drivers/r300/compiler/tests/rc_test_helpers.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drive

Re: [Mesa-dev] [PATCH 1/4] radeonsi: set IA_MULTI_VGT_PARAM on SI the same as on CIK (v2)

2014-08-18 Thread Michel Dänzer
The series is Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer| http://www.amd.com Libre software enthusiast |Mesa and X developer ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org ht

Re: [Mesa-dev] [PATCH 1/4] radeonsi: set IA_MULTI_VGT_PARAM on SI the same as on CIK (v2)

2014-08-18 Thread Alex Deucher
On Mon, Aug 18, 2014 at 5:55 PM, Marek Olšák wrote: > From: Marek Olšák > > Nothing's changed for CIK here. For the series: Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_state.c | 6 -- > src/gallium/drivers/radeonsi/si_state_draw.c | 90 > +++--

[Mesa-dev] [Bug 82538] Super Maryo Chronicles fails with st/mesa assertion failure

2014-08-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82538 Michel Dänzer changed: What|Removed |Added CC||laszlo.kertesz@infobenefic.

Re: [Mesa-dev] [PATCH 2/7] i965: Update JIP/UIP compaction code to operate on bytes.

2014-08-18 Thread Matt Turner
On Mon, Aug 18, 2014 at 2:47 PM, Kenneth Graunke wrote: > On Monday, August 18, 2014 11:19:48 AM Matt Turner wrote: >> JIP/UIP were previously in units of compacted instructions. On Gen8 >> they're in units of bytes. >> --- >> src/mesa/drivers/dri/i965/brw_eu_compact.c | 10 ++ >> 1 file

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-18 Thread Michel Dänzer
On 19.08.2014 01:28, Connor Abbott wrote: > On Mon, Aug 18, 2014 at 4:32 AM, Michel Dänzer wrote: >> On 16.08.2014 09:12, Connor Abbott wrote: >>> I know what you might be thinking right now. "Wait, *another* IR? Don't >>> we already have like 5 of those, not counting all the driver-specific >>> o

[Mesa-dev] [PATCH 2/2] i965: Remove redundant discard jumps.

2014-08-18 Thread Kenneth Graunke
With the previous optimization in place, some shaders wind up with multiple discard jumps in a row, or jumps directly to the next instruction. We can remove those. total instructions in shared programs: 5122144 -> 5121604 (-0.01%) instructions in affected programs: 11928 -> 11388 (-4.53%) Si

[Mesa-dev] [PATCH 1/2] i965/fs: Optimize conditional discards.

2014-08-18 Thread Kenneth Graunke
Almost all uses of discard in GLSL take the form: if (some_condition) discard; This generates the following assembly: cmp.condition.f0.0 src0 src1 /* generate some condition */ IF (+f0.1) cmp.ne.f0.1 g0 g0 /* figure out enabled channels */ (-f0.1.anyNh) halt

Re: [Mesa-dev] [PATCH 1/3] i965: Flush the RC and TC before doing a fast clear resolve

2014-08-18 Thread Chris Forbes
Also fixes gears! ;) Reviewed-by: Chris Forbes On Tue, Aug 19, 2014 at 12:20 PM, Kristian Høgsberg wrote: > The docs say "When performing a render target resolve, PIPE_CONTROL with end > of pipe sync must be delivered.", which doesn't actually tell us whether we > need to do it before or after.

[Mesa-dev] [PATCH 1/3] i965: Flush the RC and TC before doing a fast clear resolve

2014-08-18 Thread Kristian Høgsberg
The docs say "When performing a render target resolve, PIPE_CONTROL with end of pipe sync must be delivered.", which doesn't actually tell us whether we need to do it before or after. Blorp did it before and after, and doing it before certainly makes sense. The resolve operation needs to read fro

[Mesa-dev] [PATCH 3/3] i965, meta: Stop unlocking the texture to try and prevent deadlocks.

2014-08-18 Thread Kristian Høgsberg
From: Kenneth Graunke Unlocking the texture is not safe: another thread could come in and grab it. Now that we use a recursive mutex, this should work. This also fixes texture lock deadlocks in the new meta fast clear path. Signed-off-by: Kenneth Graunke Reviewed-by: Kristian Høgsberg Cc: Br

Re: [Mesa-dev] [PATCH 1/2] i965/vec4: Add a pass to reduce swizzles.

2014-08-18 Thread Kenneth Graunke
On Monday, August 18, 2014 12:24:14 PM Matt Turner wrote: > total instructions in shared programs: 4344280 -> 4288033 (-1.29%) > instructions in affected programs: 397468 -> 341221 (-14.15%) > --- > Suggestions for a better name are welcome. I like the name. > > src/mesa/drivers/dri/i965/br

[Mesa-dev] [PATCH 2/3] mesa: Use a recursive mutex for the texture lock.

2014-08-18 Thread Kristian Høgsberg
From: Kenneth Graunke This avoids problems with things like meta operations calling functions that want to take the lock while the lock is already held. Basically, the point is to guard against API reentrancy across threads...not to guard against ourselves. Signed-off-by: Kenneth Graunke Revie

Re: [Mesa-dev] [PATCH 05/22] winsys/radeon: move radeon_cs_dump.h to drm

2014-08-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Aug 19, 2014 at 1:20 AM, Emil Velikov wrote: > ... to ease packaging (make dist). > Update it to fetch libdrm's include/libs via pkg-config. > > Cc: Marek Olšák > Cc: Michel Dänzer > Signed-off-by: Emil Velikov > --- > src/gallium/winsys/radeon/drm/rad

Re: [Mesa-dev] [PATCH 3/6] rbug: implement streamout context functions

2014-08-18 Thread Roland Scheidegger
Am 19.08.2014 01:43, schrieb Marek Olšák: > On Tue, Aug 19, 2014 at 1:12 AM, Roland Scheidegger > wrote: >> Am 18.08.2014 23:24, schrieb Marek Olšák: >>> From: Marek Olšák >>> >>> --- >>> src/gallium/drivers/rbug/rbug_context.c | 46 >>> + >>> 1 file changed, 46

Re: [Mesa-dev] [PATCH 04/22] gallium/radeon: cleanup header inclusion

2014-08-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Tue, Aug 19, 2014 at 1:20 AM, Emil Velikov wrote: > - Add top_srcdir/src/gallium/winsys to GALLIUM_DRIVER_C{XXFLAGS}. > - Remove top_srcdir/src/gallium/drivers/radeon from the includes. > > As a result: > - Common radeon headers are already prefixed with 'ra

Re: [Mesa-dev] [PATCH 2/6] rbug: fix crash in set_vertex_buffers

2014-08-18 Thread Roland Scheidegger
Am 19.08.2014 01:35, schrieb Marek Olšák: > On Tue, Aug 19, 2014 at 1:10 AM, Roland Scheidegger > wrote: >> Am 18.08.2014 23:24, schrieb Marek Olšák: >>> From: Marek Olšák >>> >>> --- >>> src/gallium/drivers/rbug/rbug_context.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> d

[Mesa-dev] [PATCH] fixup! i965/fs: Optimize emit_bool_to_cond_code for logical exprs.

2014-08-18 Thread Matt Turner
--- I'm going to squash this into the commit, to resolve some bools on platforms where Const.UniformBooleanTrue == 1. Fixes some piglit failures on GM45. src/mesa/drivherers/dri/i965/brw_fs_visitor.cpp | 33 +++- 1 file changed, 27 insertions(+), 6 deletions(-) diff --gi

Re: [Mesa-dev] [PATCH v4 1/6] mesa: add ARB_conditional_render_inverted flags

2014-08-18 Thread Roland Scheidegger
Series looks good to me too, just one minor nitpick below, otherwise 1-4, and 6 are Reviewed-by: Roland Scheidegger Am 19.08.2014 00:06, schrieb Tobias Klausmann: > Also add an extension bit so we can safely enable > > Signed-off-by: Tobias Klausmann > --- > src/mesa/main/condrender.c | 10 +++

Re: [Mesa-dev] [PATCH 3/6] rbug: implement streamout context functions

2014-08-18 Thread Marek Olšák
On Tue, Aug 19, 2014 at 1:12 AM, Roland Scheidegger wrote: > Am 18.08.2014 23:24, schrieb Marek Olšák: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/rbug/rbug_context.c | 46 >> + >> 1 file changed, 46 insertions(+) >> >> diff --git a/src/gallium/drivers/

Re: [Mesa-dev] [PATCH 2/6] gallium/u_blitter: don't use an empty fragment shader if there's a colorbuffer

2014-08-18 Thread Roland Scheidegger
Am 18.08.2014 23:52, schrieb Marek Olšák: > From: Marek Olšák > > This is custom code used by some drivers. > --- > src/gallium/auxiliary/util/u_blitter.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/auxiliary/util/u_blitter.c > b/src/gallium/auxiliary/u

[Mesa-dev] [Bug 82327] FAIL: glcpp/tests/glcpp-test-cr-lf

2014-08-18 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=82327 --- Comment #5 from Carl Worth --- Patch sent to mesa-dev: http://lists.freedesktop.org/archives/mesa-dev/2014-August/066111.html Testing and feedback will be most appreciated. -Carl (I wrote this and tested on Mac OS X and also verified ther

Re: [Mesa-dev] [PATCH 2/6] rbug: fix crash in set_vertex_buffers

2014-08-18 Thread Marek Olšák
On Tue, Aug 19, 2014 at 1:10 AM, Roland Scheidegger wrote: > Am 18.08.2014 23:24, schrieb Marek Olšák: >> From: Marek Olšák >> >> --- >> src/gallium/drivers/rbug/rbug_context.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/src/gallium/drivers/rbug/rbug_context.c >>

[Mesa-dev] [PATCH 1/2] glcpp: Use printf instead of "echo -n" in glcpp-test

2014-08-18 Thread Carl Worth
I noticed that with /bin/sh on Mac OS X, "echo -n" does not work as desired, (it actually prints "-n" rather than suppressing the final newline). There is a /bin/echo that could be used (it actually works) instead of the builtin echo. But I decided it's more robust to just use printf rather than h

[Mesa-dev] [PATCH 2/2] glcpp: Fix glcpp-test-cr-lf "make check" test for Mac OS X

2014-08-18 Thread Carl Worth
There were two problems with the way this script used sed on OS X: 1. The OS X sed doesn't interpret "\r" in a replacement list as a carriage-return character, (instead it was inserting a literal 'r' character). We fix this by putting an actual ^M character into the source of

Re: [Mesa-dev] [PATCH 6/6] rbug: only add textures to the list

2014-08-18 Thread Roland Scheidegger
Am 18.08.2014 23:24, schrieb Marek Olšák: > From: Marek Olšák > > rbug-gui cannot display buffers, so it's pointless to add them. > --- > src/gallium/drivers/rbug/rbug_objects.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/src/gallium/drivers/rbug/rbug_objects

[Mesa-dev] [PATCH 18/22] st/omx: use makefile.sources to handle sources lists

2014-08-18 Thread Emil Velikov
... and add the headers so that 'make check' is happy. Cc: Christian König Signed-off-by: Emil Velikov --- src/gallium/state_trackers/omx/Makefile.am | 8 ++-- src/gallium/state_trackers/omx/Makefile.sources | 9 + 2 files changed, 11 insertions(+), 6 deletions(-) create mode

[Mesa-dev] [PATCH 15/22] st/vega: add headers and SConscript in the tarball

2014-08-18 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/state_trackers/vega/Makefile.am | 2 ++ src/gallium/state_trackers/vega/Makefile.sources | 24 +++- 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/vega/Makefile.am b/src/gallium/state

[Mesa-dev] [PATCH 12/22] Revert "configure: Disable xvmc by default"

2014-08-18 Thread Emil Velikov
This reverts commit 6a19bb56e09e841553ad1295f74fa21bfbbe752a. The above commit disabled the default build of xvmc as the xvmc tests were failing. As pointed out by Ilia, the tests are "broken by design" as they do not test the object that is build but the one that is installed and setup on the wor

[Mesa-dev] [PATCH 22/22] st/egl: ship all the files in the tarball

2014-08-18 Thread Emil Velikov
Namely we were missing the headers and the Android/SCons buildscripts. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/egl/Makefile.am | 2 ++ src/gallium/state_trackers/egl/Makefile.sources | 31 ++--- 2 files changed, 25 insertions(+), 8 deletions(-) diff

[Mesa-dev] [PATCH 20/22] st/gbm: include the header in the sources list

2014-08-18 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/state_trackers/gbm/Makefile.sources | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/gbm/Makefile.sources b/src/gallium/state_trackers/gbm/Makefile.sources index 41e2790..1ab961c 100644 --- a/src/gallium/

[Mesa-dev] [PATCH 04/22] gallium/radeon: cleanup header inclusion

2014-08-18 Thread Emil Velikov
- Add top_srcdir/src/gallium/winsys to GALLIUM_DRIVER_C{XXFLAGS}. - Remove top_srcdir/src/gallium/drivers/radeon from the includes. As a result: - Common radeon headers are already prefixed with 'radeon/' - Winsys header inclusion is prefixed 'radeon/drm' Cc: Marek Olšák Cc: Michel Dänzer S

[Mesa-dev] [PATCH 05/22] winsys/radeon: move radeon_cs_dump.h to drm

2014-08-18 Thread Emil Velikov
... to ease packaging (make dist). Update it to fetch libdrm's include/libs via pkg-config. Cc: Marek Olšák Cc: Michel Dänzer Signed-off-by: Emil Velikov --- src/gallium/winsys/radeon/drm/radeon_ctx.h | 205 + src/gallium/winsys/radeon/drm/radeon_drm_cs_dump.c | 4

[Mesa-dev] [PATCH 17/22] st/vdpau: pickup/ship the private header

2014-08-18 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/state_trackers/vdpau/Makefile.sources | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/src/gallium/state_trackers/vdpau/Makefile.sources b/src/gallium/state_trackers/vdpau/Makefile.sources index d90a870..dfe0bcd 100

[Mesa-dev] [PATCH 11/22] st/xvmc: automake: move tests to noinst

2014-08-18 Thread Emil Velikov
All the test require and installed and setup XvMC, and as such are not a good candidate for 'make check'. Keep them around as the user might want to actually test the implementation post installation/setup. Cc: Ilia Mirkin Cc: Tom Stellard Cc: Christian König Signed-off-by: Emil Velikov --- s

[Mesa-dev] [PATCH 19/22] st/xlib: Include the headers in the sources list.

2014-08-18 Thread Emil Velikov
Yet another step towards a working 'make dist'. Cc: José Fonseca Signed-off-by: Emil Velikov --- src/gallium/state_trackers/glx/xlib/Makefile.sources | 5 - src/gallium/state_trackers/glx/xlib/SConscript | 1 - 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 21/22] st/clover: sort the sources list

2014-08-18 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/state_trackers/clover/Makefile.am | 6 +- src/gallium/state_trackers/clover/Makefile.sources | 94 -- 2 files changed, 52 insertions(+), 48 deletions(-) diff --git a/src/gallium/state_trackers/clover/Makefile.am b/src/gallium

[Mesa-dev] [PATCH 13/22] st/xvmc: include the header in the sources list

2014-08-18 Thread Emil Velikov
- Will allow autotools to pick it up in the tarball. - Sort the list alphabetically. Signed-off-by: Emil Velikov S#igned-off-by: Emil Velikov --- src/gallium/state_trackers/xvmc/Makefile.am | 2 ++ src/gallium/state_trackers/xvmc/Makefile.sources | 5 +++-- 2 files changed, 5 insertions

[Mesa-dev] [PATCH 16/22] st/vdpau: remove obsolete define VL_HANDLES

2014-08-18 Thread Emil Velikov
This define is always set and it had no real purpose according to git log. Seems like it is a leftover from the vl/vdpau prototype stage. Cc: Christian König Signed-off-by: Emil Velikov --- src/gallium/state_trackers/vdpau/htab.c | 25 +--- src/gallium/state_tracker

[Mesa-dev] [PATCH 14/22] st/xa: add remaining files in the tarball

2014-08-18 Thread Emil Velikov
Namely - the private header (xa_priv.h) - README and - xa-indent Sort the sources list while we're here. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/xa/Makefile.am | 2 ++ src/gallium/state_trackers/xa/Makefile.sources | 7 --- 2 files changed, 6 insertions(+), 3 dele

[Mesa-dev] [PATCH 09/22] winsys/sw: automake: consistently use Makefile.sources

2014-08-18 Thread Emil Velikov
- Include the headers within. - Update scons to use them. - Drop useless include (gallium/drivers) from scons. Signed-off-by: Emil Velikov --- src/gallium/winsys/sw/dri/Makefile.am | 3 ++- src/gallium/winsys/sw/dri/Makefile.sources | 3 +++ src/gallium/winsys/sw/dri/SConscript

[Mesa-dev] [PATCH 10/22] winsys/sw: add the final files to the tarball

2014-08-18 Thread Emil Velikov
Add the final remaining files into the tarball (make dist), namely: - SConscripts - Non-autotool'd winsys' - android, gdi and hgl. Signed-off-by: Emil Velikov --- src/gallium/Makefile.am | 9 + src/gallium/winsys/sw/dri/Makefile.am | 2 ++ src/gallium/winsys/sw/fb

[Mesa-dev] [PATCH 08/22] winsys/$(hw): ship the Android/SCons scripts in the tarball

2014-08-18 Thread Emil Velikov
Signed-off-by: Emil Velikov --- src/gallium/winsys/freedreno/drm/Makefile.am | 2 ++ src/gallium/winsys/i915/drm/Makefile.am | 2 ++ src/gallium/winsys/intel/drm/Makefile.am | 2 ++ src/gallium/winsys/nouveau/drm/Makefile.am | 2 ++ src/gallium/winsys/radeon/drm/Makefile.am| 2 +-

[Mesa-dev] [PATCH 06/22] st/egl: cleanup sw winsys header inclusions

2014-08-18 Thread Emil Velikov
- Drop duplicate include compiler directives. - Leave the sw/ prefix for all the software winsys headers. Signed-off-by: Emil Velikov --- src/gallium/state_trackers/egl/Android.mk | 2 +- src/gallium/state_trackers/egl/Makefile.am| 9 ++--- src/gallium/state

[Mesa-dev] [PATCH 03/22] winsys/svga: build: cleanup the includes

2014-08-18 Thread Emil Velikov
gallium/drivers is already part fo GALLIUM_WINSYS_CFLAGS. Signed-off-by: Emil Velikov --- src/gallium/winsys/svga/drm/Makefile.am | 1 - src/gallium/winsys/svga/drm/SConscript | 6 +- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/src/gallium/winsys/svga/drm/Makefile.am b/sr

[Mesa-dev] [PATCH 02/22] winsys/i915: remove the software winsys

2014-08-18 Thread Emil Velikov
We stopped building it recently as it was unused and not tested. Good bye, it's been nice knowing you :) Cc: Stephane Marchesin Signed-off-by: Emil Velikov --- src/gallium/winsys/i915/sw/Makefile.am | 33 - src/gallium/winsys/i915/sw/Makefile.sources | 5 - src/gallium/win

[Mesa-dev] [PATCH 01/22] gallium/ilo: cleanup intel_winsys.h

2014-08-18 Thread Emil Velikov
Make the header location, inclusion and contents more common with its i915,r* and nouveau counterparts: - Move the header within intel/drm. - Separate out intel_winsys_create_for_fd into 'drm_public' header. - Cleanup the compiler includes. Cc: Chia-I Wu Signed-off-by: Emil Velikov --- .../

[Mesa-dev] [PATCH 07/22] winsys/$(hw): include headers in Makefile.sources

2014-08-18 Thread Emil Velikov
Otherwise 'make dist' will not pick them up :'( Signed-off-by: Emil Velikov --- src/gallium/winsys/freedreno/drm/Makefile.sources | 1 + src/gallium/winsys/i915/drm/Makefile.sources | 4 ++- src/gallium/winsys/intel/drm/Makefile.sources | 4 ++- src/gallium/winsys/nouveau/drm/Makefil

Re: [Mesa-dev] [PATCH 3/6] rbug: implement streamout context functions

2014-08-18 Thread Roland Scheidegger
Am 18.08.2014 23:24, schrieb Marek Olšák: > From: Marek Olšák > > --- > src/gallium/drivers/rbug/rbug_context.c | 46 > + > 1 file changed, 46 insertions(+) > > diff --git a/src/gallium/drivers/rbug/rbug_context.c > b/src/gallium/drivers/rbug/rbug_context.c > i

Re: [Mesa-dev] [PATCH 2/6] rbug: fix crash in set_vertex_buffers

2014-08-18 Thread Roland Scheidegger
Am 18.08.2014 23:24, schrieb Marek Olšák: > From: Marek Olšák > > --- > src/gallium/drivers/rbug/rbug_context.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/rbug/rbug_context.c > b/src/gallium/drivers/rbug/rbug_context.c > index ca94590..d6fca2e

Re: [Mesa-dev] [PATCH 5/6] rbug: fix a crash in sampler_view_destroy caused by incorrect context

2014-08-18 Thread Roland Scheidegger
Am 18.08.2014 23:24, schrieb Marek Olšák: > From: Marek Olšák > > --- > src/gallium/drivers/rbug/rbug_objects.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/rbug/rbug_objects.c > b/src/gallium/drivers/rbug/rbug_objects.c > index c64b14c..2d80164

Re: [Mesa-dev] [PATCH v4 0/6] Implement ARB_conditional_render_inverted

2014-08-18 Thread Ilia Mirkin
Series is Reviewed-by: Ilia Mirkin Might be nice for someone more experienced than myself to also take a look. On Mon, Aug 18, 2014 at 6:06 PM, Tobias Klausmann wrote: > This patch series adds support for ARB_conditional_render_inverted to nvc0, > softpipe and llvmpipe. > > V2: > - Add missin

Re: [Mesa-dev] [PATCH 5/7] i965: Add support for compacting 1- and 2-src instructions on Gen8.

2014-08-18 Thread Kenneth Graunke
On Monday, August 18, 2014 11:19:51 AM Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_eu_compact.c | 48 > ++ > 1 file changed, 35 insertions(+), 13 deletions(-) Patches 4-5 are: Reviewed-by: Kenneth Graunke Patch 3 is: Acked-by: Kenneth Graunke signatur

Re: [Mesa-dev] [PATCH 6/7] i965: Add support for compacting 3-src instructions on Gen8.

2014-08-18 Thread Kenneth Graunke
On Monday, August 18, 2014 11:19:52 AM Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_eu_compact.c | 189 > + > 1 file changed, 189 insertions(+) > > diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c > b/src/mesa/drivers/dri/i965/brw_eu_compact.c > in

[Mesa-dev] [PATCH v4 6/6] docs: Update status of ARB_conditional_render_inverted

2014-08-18 Thread Tobias Klausmann
Done for: nvc0, softpipe and llvmpipe Signed-off-by: Tobias Klausmann --- docs/GL3.txt| 2 +- docs/relnotes/10.3.html | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index b38e42c..5549b30 100644 --- a/docs/GL3.txt +++ b/docs/GL3.tx

[Mesa-dev] [PATCH v4 5/6] llvmpipe/softpipe: enable ARB_conditional_render_inverted

2014-08-18 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/drivers/llvmpipe/lp_screen.c | 3 ++- src/gallium/drivers/softpipe/sp_screen.c | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c index 08597fa.

[Mesa-dev] [PATCH v4 0/6] Implement ARB_conditional_render_inverted

2014-08-18 Thread Tobias Klausmann
This patch series adds support for ARB_conditional_render_inverted to nvc0, softpipe and llvmpipe. V2: - Add missing _mesa_BeginConditionalRender() parts to series - Fix nvc0 blit and inverted rendering - Fix relnotes - Enable for softpipe and llvmpipe - Rebase on top of current HEAD V3: - O

[Mesa-dev] [PATCH v4 2/6] gallium: Add and handle PIPE_CAP_CONDITIONAL_RENDER_INVERTED

2014-08-18 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c | 1 + src/gallium/drivers/llvmpipe/lp_scre

[Mesa-dev] [PATCH v4 3/6] mesa/st: Support ARB_conditional_render_inverted modes

2014-08-18 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/mesa/state_tracker/st_cb_condrender.c | 20 +++- src/mesa/state_tracker/st_extensions.c| 1 + 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_cb_condrender.c b/src/mesa/state_tracker/st_cb_condr

[Mesa-dev] [PATCH v4 4/6] nvc0: Handle ARB_conditional_render_inverted and enable it

2014-08-18 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/nvc0/nvc0_context.h | 3 +- src/gallium/drivers/nouveau/nvc0/nvc0_query.c | 61 + src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 3 +- src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 3 +- 4 files ch

[Mesa-dev] [PATCH v4 1/6] mesa: add ARB_conditional_render_inverted flags

2014-08-18 Thread Tobias Klausmann
Also add an extension bit so we can safely enable Signed-off-by: Tobias Klausmann --- src/mesa/main/condrender.c | 10 -- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/condrender.c b/src

[Mesa-dev] [PATCH 4/4] r600g: copy IA_MULTI_VGT_PARAM programming from radeonsi for Cayman

2014-08-18 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/r600/evergreen_state.c | 2 -- src/gallium/drivers/r600/r600_pipe.h | 2 +- src/gallium/drivers/r600/r600_state_common.c | 24 src/gallium/drivers/r600/r600d.h | 11 +++ 4 files changed, 36 inserti

[Mesa-dev] [PATCH 2/4] radeonsi: set PARTIAL_VS_WAVE(0) when appropriate

2014-08-18 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_draw.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 2e999f6..f5d6550 100644 --- a/src/gallium/drivers/radeon

[Mesa-dev] [PATCH 1/4] radeonsi: set IA_MULTI_VGT_PARAM on SI the same as on CIK (v2)

2014-08-18 Thread Marek Olšák
From: Marek Olšák Nothing's changed for CIK here. --- src/gallium/drivers/radeonsi/si_state.c | 6 -- src/gallium/drivers/radeonsi/si_state_draw.c | 90 +++- 2 files changed, 50 insertions(+), 46 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state.c b/

[Mesa-dev] [PATCH 3/4] radeonsi: bump PRIMGROUP_SIZE for some cases

2014-08-18 Thread Marek Olšák
From: Marek Olšák Recommended by hw people. --- src/gallium/drivers/radeonsi/si_state_draw.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index f5d6550..0f700a8 100644 --- a/sr

[Mesa-dev] [PATCH 1/6] gallium/util: handle PIPE_BUFFER in util_pipe_tex_to_tgsi_tex

2014-08-18 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_inlines.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/util/u_inlines.h b/src/gallium/auxiliary/util/u_inlines.h index e952615..c80ec48 100644 --- a/src/gallium/auxiliary/util/u_inlines.h +++ b/src/gallium/auxili

[Mesa-dev] [PATCH 6/6] radeonsi: simplify si_num_banks function

2014-08-18 Thread Marek Olšák
From: Marek Olšák This makes it easier to use. --- src/gallium/drivers/radeonsi/si_dma.c | 6 ++ src/gallium/drivers/radeonsi/si_state.c | 19 ++- src/gallium/drivers/radeonsi/si_state.h | 3 +-- 3 files changed, 13 insertions(+), 15 deletions(-) diff --git a/src/gallium

[Mesa-dev] [PATCH 4/6] radeonsi: save scissor state and sample mask for u_blitter

2014-08-18 Thread Marek Olšák
From: Marek Olšák Cc: mesa-sta...@lists.freedesktop.org --- src/gallium/drivers/radeonsi/si_blit.c | 7 +++ src/gallium/drivers/radeonsi/si_state.c | 16 ++-- src/gallium/drivers/radeonsi/si_state.h | 14 -- 3 files changed, 29 insertions(+), 8 deletions(-) diff --

[Mesa-dev] [PATCH 3/6] radeonsi: don't set CB_SHADER_MASK=1 if there are no color outputs

2014-08-18 Thread Marek Olšák
From: Marek Olšák This hack isn't needed anymore because of the previous u_blitter commit. --- src/gallium/drivers/radeonsi/si_shader.c | 4 1 file changed, 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 3fcd314..08ba8

[Mesa-dev] [PATCH 2/6] gallium/u_blitter: don't use an empty fragment shader if there's a colorbuffer

2014-08-18 Thread Marek Olšák
From: Marek Olšák This is custom code used by some drivers. --- src/gallium/auxiliary/util/u_blitter.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index 20fbd80..609e02f 100644 --- a/src/gall

[Mesa-dev] [PATCH 5/6] radeonsi: use r600_draw_rectangle from r600g

2014-08-18 Thread Marek Olšák
From: Marek Olšák Rectangles are easier than triangles for the rasterizer. --- src/gallium/drivers/r600/r600_blit.c | 1 - src/gallium/drivers/r600/r600_pipe.c | 1 - src/gallium/drivers/r600/r600_pipe.h | 4 -- src/gallium/drivers/r600/r600_state_common.c | 64 ---

Re: [Mesa-dev] [PATCH 1/7] i965: Reverse condition ordering to let us support other gens.

2014-08-18 Thread Kenneth Graunke
On Monday, August 18, 2014 11:19:47 AM Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_eu_compact.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c > b/src/mesa/drivers/dri/i965/brw_eu_compact.c > index 625cfbb..2

Re: [Mesa-dev] [PATCH 7/7] i965: Enable instruction compaction on Gen8+.

2014-08-18 Thread Kenneth Graunke
On Monday, August 18, 2014 11:19:53 AM Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_eu_compact.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c > b/src/mesa/drivers/dri/i965/brw_eu_compact.c > index 727fef5..280d7f7

Re: [Mesa-dev] [PATCH 2/7] i965: Update JIP/UIP compaction code to operate on bytes.

2014-08-18 Thread Kenneth Graunke
On Monday, August 18, 2014 11:19:48 AM Matt Turner wrote: > JIP/UIP were previously in units of compacted instructions. On Gen8 > they're in units of bytes. > --- > src/mesa/drivers/dri/i965/brw_eu_compact.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/src/m

Re: [Mesa-dev] [PATCH 12/12] i965: Implement fast color clears using meta operations

2014-08-18 Thread Chris Forbes
Ken, It would be nice to get that patch [1] in fairly soon -- master is currently unusable. [1] http://cgit.freedesktop.org/~kwg/mesa/commit/?h=texturelock&id=51b6879849f1efcfb28a45a63c2230ad0b2292e7 Consider it: Reviewed-and-tested-by: Chris Forbes On Mon, Aug 18, 2014 at 9:36 AM, Chris Fo

Re: [Mesa-dev] [PATCH 7/7] i965: Enable instruction compaction on Gen8+.

2014-08-18 Thread Chris Forbes
s/Gen8+/Gen8/ in the commit message, since it's still disabled for future gens. On Tue, Aug 19, 2014 at 6:19 AM, Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_eu_compact.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact

[Mesa-dev] [PATCH 1/6] rbug: remove contexts from the list properly

2014-08-18 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/rbug/rbug_context.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/rbug/rbug_context.c b/src/gallium/drivers/rbug/rbug_context.c index 62fe543..ca94590 100644 --- a/src/gallium/drivers/rbug/rbug_context.c +++

[Mesa-dev] [PATCH 2/6] rbug: fix crash in set_vertex_buffers

2014-08-18 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/rbug/rbug_context.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/rbug/rbug_context.c b/src/gallium/drivers/rbug/rbug_context.c index ca94590..d6fca2e 100644 --- a/src/gallium/drivers/rbug/rbug_context.c +++ b/s

[Mesa-dev] [PATCH 4/6] rbug: send the actual number of layers to the client

2014-08-18 Thread Marek Olšák
From: Marek Olšák This sends the correct value for array textures. --- src/gallium/drivers/rbug/rbug_core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/rbug/rbug_core.c b/src/gallium/drivers/rbug/rbug_core.c index c5b26b8..ece5e2f 100644 --- a/src

[Mesa-dev] [PATCH 3/6] rbug: implement streamout context functions

2014-08-18 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/rbug/rbug_context.c | 46 + 1 file changed, 46 insertions(+) diff --git a/src/gallium/drivers/rbug/rbug_context.c b/src/gallium/drivers/rbug/rbug_context.c index d6fca2e..71bc216 100644 --- a/src/gallium/drivers/rbug/rbu

[Mesa-dev] [PATCH 6/6] rbug: only add textures to the list

2014-08-18 Thread Marek Olšák
From: Marek Olšák rbug-gui cannot display buffers, so it's pointless to add them. --- src/gallium/drivers/rbug/rbug_objects.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/rbug/rbug_objects.c b/src/gallium/drivers/rbug/rbug_objects.c index 2d8016

[Mesa-dev] [PATCH 5/6] rbug: fix a crash in sampler_view_destroy caused by incorrect context

2014-08-18 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/rbug/rbug_objects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/rbug/rbug_objects.c b/src/gallium/drivers/rbug/rbug_objects.c index c64b14c..2d80164 100644 --- a/src/gallium/drivers/rbug/rbug_objects.c +++ b/s

Re: [Mesa-dev] [PATCH] Fix surf->bankh init by default value when surf->tile_split == 0

2014-08-18 Thread Maks Naumov
I don't have access to git. > Reviewed-by: Marek Olšák > > Do you have commit access? > > Marek > > On Mon, Aug 18, 2014 at 9:59 PM, Maks Naumov wrote: > > Signed-off-by: Maks Naumov > > --- > > radeon/radeon_surface.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff

Re: [Mesa-dev] [PATCH] Fix surf->bankh init by default value when surf->tile_split == 0

2014-08-18 Thread Marek Olšák
Reviewed-by: Marek Olšák Do you have commit access? Marek On Mon, Aug 18, 2014 at 9:59 PM, Maks Naumov wrote: > Signed-off-by: Maks Naumov > --- > radeon/radeon_surface.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/radeon/radeon_surface.c b/radeon/radeon_surf

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-18 Thread Alex Deucher
On Mon, Aug 18, 2014 at 1:38 PM, Roland Scheidegger wrote: > Am 18.08.2014 19:05, schrieb Connor Abbott: >> On Mon, Aug 18, 2014 at 12:38 PM, Ilia Mirkin wrote: >>> On Mon, Aug 18, 2014 at 12:25 PM, Connor Abbott wrote: On Mon, Aug 18, 2014 at 11:47 AM, Jose Fonseca wrote: > On 18/08/1

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-18 Thread Connor Abbott
On Mon, Aug 18, 2014 at 12:20 PM, Thomas Helland wrote: > Hi Connor! > > I've been scrolling through your github-repo a bit the latest weeks, > and I have to say, this seems quite promising. > > I've got some questions that I haven't really been able to answer > myself with the quick glimpse I've

[Mesa-dev] [PATCH] Fix surf->bankh init by default value when surf->tile_split == 0

2014-08-18 Thread Maks Naumov
Signed-off-by: Maks Naumov --- radeon/radeon_surface.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/radeon/radeon_surface.c b/radeon/radeon_surface.c index e056ed4..40a544a 100644 --- a/radeon/radeon_surface.c +++ b/radeon/radeon_surface.c @@ -1311,7 +1311,7 @@ static i

Re: [Mesa-dev] [PATCH 10/19] auxiliary/os: introduce os_get_total_physical_memory helper function

2014-08-18 Thread Alexander von Gluck IV
On , Emil Velikov wrote: Cc: Alexander von Gluck IV Signed-off-by: Emil Velikov --- src/gallium/auxiliary/os/os_misc.c | 64 ++ src/gallium/auxiliary/os/os_misc.h | 7 + 2 files changed, 71 insertions(+) The Haiku portion of this patch looks good bt

[Mesa-dev] [PATCH 2/2] i965/vec4: Allow reswizzling writemasks when swizzle is single-valued.

2014-08-18 Thread Matt Turner
total instructions in shared programs: 4288033 -> 4266151 (-0.51%) instructions in affected programs: 930915 -> 909033 (-2.35%) --- View under git show -w. Really just rearranging code. src/mesa/drivers/dri/i965/brw_vec4.cpp | 60 +++--- 1 file changed, 33 insertio

[Mesa-dev] [PATCH 1/2] i965/vec4: Add a pass to reduce swizzles.

2014-08-18 Thread Matt Turner
total instructions in shared programs: 4344280 -> 4288033 (-1.29%) instructions in affected programs: 397468 -> 341221 (-14.15%) --- Suggestions for a better name are welcome. src/mesa/drivers/dri/i965/brw_vec4.cpp | 98 ++ src/mesa/drivers/dri/i965/brw_vec4.h

Re: [Mesa-dev] [RFC PATCH 00/16] A new IR for Mesa

2014-08-18 Thread Thomas Helland
Hi Connor! I've been scrolling through your github-repo a bit the latest weeks, and I have to say, this seems quite promising. I've got some questions that I haven't really been able to answer myself with the quick glimpse I've had over the codebase: Since we're in large making a mathematical gr

[Mesa-dev] [PATCH] glcpp: Don't use alternation in the lookahead for empty pragmas.

2014-08-18 Thread Carl Worth
We've found that there's a buffer overrun bug in flex that's triggered by using alternation in a lookahead pattern. Fortunately, we don't need to match the exact {NEWLINE} expression to detect an empty pragma. It suffices to verify that there are no non-space characters before any newline characte

[Mesa-dev] [PATCH 5/7] i965: Add support for compacting 1- and 2-src instructions on Gen8.

2014-08-18 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_eu_compact.c | 48 ++ 1 file changed, 35 insertions(+), 13 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c b/src/mesa/drivers/dri/i965/brw_eu_compact.c index 1f30366..07faff4 100644 --- a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 2/7] i965: Update JIP/UIP compaction code to operate on bytes.

2014-08-18 Thread Matt Turner
JIP/UIP were previously in units of compacted instructions. On Gen8 they're in units of bytes. --- src/mesa/drivers/dri/i965/brw_eu_compact.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c b/src/mesa/drivers/dri/i965/brw_e

[Mesa-dev] [PATCH 0/7] i965: Broadwell/Cherryview instruction compaction

2014-08-18 Thread Matt Turner
Available from git://people.freedesktop.org/~mattst88/mesa gen8compact (The branch is based on master before krh's fast clear series) Cherryview's instruction compaction is slightly different, and is yet untested. ___ mesa-dev mailing list mesa-dev

[Mesa-dev] [PATCH 1/7] i965: Reverse condition ordering to let us support other gens.

2014-08-18 Thread Matt Turner
--- src/mesa/drivers/dri/i965/brw_eu_compact.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c b/src/mesa/drivers/dri/i965/brw_eu_compact.c index 625cfbb..25a96e7 100644 --- a/src/mesa/drivers/dri/i965/brw_eu_compact.c +++ b/src

  1   2   >