[Mesa-dev] [PATCH] glsl: Fix clang mismatched-tags warnings with glsl_type.

2014-06-14 Thread Vinson Lee
Fix clang mismatched-tags warnings introduced with commit 4f5445a45d3ed02e00a061b10c943c0b079c6020. ./glsl_symbol_table.h:37:1: warning: class 'glsl_type' was previously declared as a struct [-Wmismatched-tags] class glsl_type; ^ ./glsl_types.h:86:8: note: previous use is here struct glsl_type {

Re: [Mesa-dev] [PATCH] i965/vec4: Use the sampler for pull constant loads on Broadwell.

2014-06-14 Thread Ben Widawsky
On Sat, Jun 14, 2014 at 12:58:03PM -0700, Kenneth Graunke wrote: > We've used the LD sampler message for pull constant loads on earlier > hardware for some time, and also were already using it for the FS on > Broadwell. This patch makes us use it for Broadwell VS/GS as well. > > I believe that wh

Re: [Mesa-dev] [PATCH 11/19] i965: Convert brw_eu_compact.c to the new brw_inst API.

2014-06-14 Thread Kenneth Graunke
On Saturday, June 14, 2014 05:41:37 PM Matt Turner wrote: > On Sat, Jun 14, 2014 at 12:54 PM, Kenneth Graunke wrote: > >> - uint16_t compacted, uncompacted = 0; > >> - > >> - uncompacted |= (src->bits2.ud >> 13) & 0xfff; > >> + uint16_t compacted; > >> + uint16_t uncompacted =

[Mesa-dev] [PATCH] glsl: Treat an interface block specifier as a level of struct nesting

2014-06-14 Thread Chris Forbes
Fixes the piglit test: spec/glsl-1.50/compiler/interface-blocks-structs-defined-within-block-instanced.vert Signed-off-by: Chris Forbes --- src/glsl/ast_to_hir.cpp | 8 1 file changed, 8 insertions(+) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 8facf1b..ee

Re: [Mesa-dev] [PATCH 11/19] i965: Convert brw_eu_compact.c to the new brw_inst API.

2014-06-14 Thread Matt Turner
On Sat, Jun 14, 2014 at 12:54 PM, Kenneth Graunke wrote: >> - uint16_t compacted, uncompacted = 0; >> - >> - uncompacted |= (src->bits2.ud >> 13) & 0xfff; >> + uint16_t compacted; >> + uint16_t uncompacted = /* 12b */ >> + (brw_inst_src0_vstride(brw, src)

Re: [Mesa-dev] [PATCH] i965/vec4: Use the sampler for pull constant loads on Broadwell.

2014-06-14 Thread Jordan Justen
Reviewed-by: Jordan Justen On Sat, Jun 14, 2014 at 12:58 PM, Kenneth Graunke wrote: > We've used the LD sampler message for pull constant loads on earlier > hardware for some time, and also were already using it for the FS on > Broadwell. This patch makes us use it for Broadwell VS/GS as well.

[Mesa-dev] [Bug 80034] compile error eglGetSyncValuesCHROMIUM undeclared

2014-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80034 --- Comment #1 from Emil Velikov --- (In reply to comment #0) > Created attachment 101063 [details] > mesa build log > Which version of mesa is this ? Is this a regression ? > mesa compile error: > > eglapi.c:1097:48: error: 'eglGetSyncValues

Re: [Mesa-dev] [PATCH] i965/vec4: Use the sampler for pull constant loads on Broadwell.

2014-06-14 Thread Matt Turner
On Sat, Jun 14, 2014 at 12:58 PM, Kenneth Graunke wrote: > We've used the LD sampler message for pull constant loads on earlier > hardware for some time, and also were already using it for the FS on > Broadwell. This patch makes us use it for Broadwell VS/GS as well. > > I believe that when I wro

[Mesa-dev] [Bug 79949] [DRI3] GTK+ Programs Not Updating Correctly

2014-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79949 Mike Lothian changed: What|Removed |Added CC||m...@fireburn.co.uk --- Comment #6 from M

[Mesa-dev] [Bug 80034] New: compile error eglGetSyncValuesCHROMIUM undeclared

2014-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=80034 Priority: medium Bug ID: 80034 Assignee: mesa-dev@lists.freedesktop.org Summary: compile error eglGetSyncValuesCHROMIUM undeclared Severity: normal Classification: Unclassified

[Mesa-dev] [PATCH] i965/vec4: Use the sampler for pull constant loads on Broadwell.

2014-06-14 Thread Kenneth Graunke
We've used the LD sampler message for pull constant loads on earlier hardware for some time, and also were already using it for the FS on Broadwell. This patch makes us use it for Broadwell VS/GS as well. I believe that when I wrote this code in 2012, we still used the data port in some cases, an

Re: [Mesa-dev] [PATCH 11/19] i965: Convert brw_eu_compact.c to the new brw_inst API.

2014-06-14 Thread Kenneth Graunke
On Friday, June 13, 2014 11:14:12 PM Matt Turner wrote: > --- > src/mesa/drivers/dri/i965/brw_eu_compact.c | 269 + > 1 file changed, 161 insertions(+), 108 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_eu_compact.c b/src/mesa/drivers/dri/i965/brw_eu_co

[Mesa-dev] [Bug 79949] [DRI3] GTK+ Programs Not Updating Correctly

2014-06-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=79949 --- Comment #5 from Joseph Booker --- As an update, this also happens with mesa 10.2.1 with the following configure options: --enable-dri --enable-glx --enable-shared-glapi --enable-texture-float --disable-debug --enable-dri3 --enable-egl --enabl

Re: [Mesa-dev] [PATCH 2/2] i965/vec4: Fix dead code elimination for VGRFs of size > 1.

2014-06-14 Thread Matt Turner
On Sat, Jun 14, 2014 at 4:10 AM, Kenneth Graunke wrote: > When faced with code such as: > > mov vgrf31.0:UD, 960D > mov vgrf31.1:UD, vgrf30.:UD > > The dead code eliminator brilliantly decided that the second instruction > was writing to the same register as the first one, so the first

Re: [Mesa-dev] [PATCH 1/3] i965: Add missing MOCS setup for 3DSTATE_INDEX_BUFFER on Broadwell.

2014-06-14 Thread Matt Turner
Series Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/3] ARB_viewport_array for nvc0

2014-06-14 Thread Ilia Mirkin
Review comments sent; you should also add a separate patch that marks off ARB_viewport_array in GL3.txt and adds it to relnotes for 10.3. On Sat, Jun 14, 2014 at 10:41 AM, Tobias Klausmann wrote: > This patch-series implements the ARB_viewport_array for nvc0 and does > a little house-cleanig afte

Re: [Mesa-dev] [PATCH 1/3] nvc0: implement multiple viewports/scissors, enable ARB_viewport_array

2014-06-14 Thread Ilia Mirkin
On Sat, Jun 14, 2014 at 10:41 AM, Tobias Klausmann wrote: > Signed-off-by: Tobias Klausmann > --- > src/gallium/drivers/nouveau/nvc0/nvc0_context.h| 7 +- > src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 2 +- > src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 20 ++-- > src/g

Re: [Mesa-dev] [PATCH 3/3] nv50/ir: Remove NV50_SEMANTIC_VIEWPORTINDEX and its last consumer

2014-06-14 Thread Ilia Mirkin
On Sat, Jun 14, 2014 at 10:41 AM, Tobias Klausmann wrote: > We use TGSI_SEMANTIC_VIEWPORT_INDEX for nvc0 now as well. > > Signed-off-by: Tobias Klausmann > --- > src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h| 1 - > src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp | 1 -

Re: [Mesa-dev] [PATCH 2/3] nvc0: mark scissor in nvc0_clear_{}

2014-06-14 Thread Ilia Mirkin
On Sat, Jun 14, 2014 at 10:41 AM, Tobias Klausmann wrote: > Signed-off-by: Tobias Klausmann > --- > src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c > b/src/gallium/drivers/nouveau/nvc0/nv

[Mesa-dev] [PATCH 3/3] nv50/ir: Remove NV50_SEMANTIC_VIEWPORTINDEX and its last consumer

2014-06-14 Thread Tobias Klausmann
We use TGSI_SEMANTIC_VIEWPORT_INDEX for nvc0 now as well. Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/codegen/nv50_ir_driver.h| 1 - src/gallium/drivers/nouveau/codegen/nv50_ir_target_nv50.cpp | 1 - 2 files changed, 2 deletions(-) diff --git a/src/gallium/drivers/no

[Mesa-dev] [PATCH 0/3] ARB_viewport_array for nvc0

2014-06-14 Thread Tobias Klausmann
This patch-series implements the ARB_viewport_array for nvc0 and does a little house-cleanig afterwords. Tobias Klausmann (3): nvc0: implement multiple viewports/scissors, enable ARB_viewport_array nvc0: mark scissor in nvc0_clear_{} nv50/ir: Remove NV50_SEMANTIC_VIEWPORTINDEX and its last c

[Mesa-dev] [PATCH 2/3] nvc0: mark scissor in nvc0_clear_{}

2014-06-14 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/nvc0/nvc0_surface.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c b/src/gallium/drivers/nouveau/nvc0/nvc0_surface.c index c28ec6d..72227b8 100644 --- a/src/gallium/drivers/nou

[Mesa-dev] [PATCH 1/3] nvc0: implement multiple viewports/scissors, enable ARB_viewport_array

2014-06-14 Thread Tobias Klausmann
Signed-off-by: Tobias Klausmann --- src/gallium/drivers/nouveau/nvc0/nvc0_context.h| 7 +- src/gallium/drivers/nouveau/nvc0/nvc0_program.c| 2 +- src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 20 ++-- src/gallium/drivers/nouveau/nvc0/nvc0_screen.h | 3 + src/gallium/driv

[Mesa-dev] [PATCH 2/2] i965/vec4: Fix dead code elimination for VGRFs of size > 1.

2014-06-14 Thread Kenneth Graunke
When faced with code such as: mov vgrf31.0:UD, 960D mov vgrf31.1:UD, vgrf30.:UD The dead code eliminator brilliantly decided that the second instruction was writing to the same register as the first one, so the first one could be eliminated. Except that they're not the same register

[Mesa-dev] [PATCH 1/2] i965: Add SHADER_OPCODE_SHADER_TIME_ADD to dump_instructions() decode.

2014-06-14 Thread Kenneth Graunke
"shader_time_add" is a lot more informative than "op152". Signed-off-by: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_shader.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp index 6ad0ff4..687356b

Re: [Mesa-dev] [PATCH] radeonsi: fixup sizes of shader resource and sampler arrays

2014-06-14 Thread Christian König
Am 14.06.2014 03:46, schrieb Marek Olšák: From: Marek Olšák This was wrong for a very long time. I wonder if the array size has any effect on anything. We only do a bit of GEP pointer arithmetic with them and so probably ignore range limits anyway. Nevertheless it's obviously wrong and sho

[Mesa-dev] [PATCH 1/3] i965: Add missing MOCS setup for 3DSTATE_INDEX_BUFFER on Broadwell.

2014-06-14 Thread Kenneth Graunke
Somehow I missed this when adding all of the other MOCS values. Signed-off-by: Kenneth Graunke Cc: "10.2" --- src/mesa/drivers/dri/i965/gen8_draw_upload.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen8_draw_upload.c b/src/mesa/drivers/dri/

[Mesa-dev] [PATCH 2/3] i965: Drop Broadwell perf_debugs about missing MOCS that aren't missing.

2014-06-14 Thread Kenneth Graunke
I actually added MOCS support for these things, but forgot to delete the corresponding perf_debug() warnings. Signed-off-by: Kenneth Graunke Cc: "10.2" --- src/mesa/drivers/dri/i965/gen8_draw_upload.c | 2 -- src/mesa/drivers/dri/i965/gen8_misc_state.c | 2 -- 2 files changed, 4 deletions(-)

[Mesa-dev] [PATCH 3/3] i965: Add missing newlines to a few perf_debug messages.

2014-06-14 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke Cc: "10.2" --- src/mesa/drivers/dri/i965/gen6_clip_state.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_clip_state.c b/src/mesa/drivers/dri/i965/gen6_clip_state.c index 0ba190e..25dfb60 100644 --- a/src/mes

Re: [Mesa-dev] [PATCH 02/19] i965: Introduce a new brw_inst API.

2014-06-14 Thread Kenneth Graunke
On Friday, June 13, 2014 11:14:03 PM Matt Turner wrote: > From: Kenneth Graunke > > This is similar to gen8_instruction, and will replace it > > For now nothing uses this, but we can incrementally convert. > The new API takes the existing brw_instruction pointers to ease > conversion; when done,