[Mesa-dev] [PATCH 2/2] meta: Drop ctx->API checks.

2014-02-26 Thread Kenneth Graunke
API is always API_OPENGL_COMPAT (since commit 4e4a537ad55f61a25, "meta: Push into desktop GL mode when doing meta operations."), so most of these checks do nothing. We could instead check save->API to only bother setting/restoring relevant GL state, but I'm not sure saving a few _mesa_set_enable c

[Mesa-dev] [PATCH 1/2] meta: Restore API at the end of _mesa_meta_end(), not the start.

2014-02-26 Thread Kenneth Graunke
In _mesa_meta_begin(), we switch to API_OPENGL_COMPAT, then munge a lot of state (including some that doesn't exist in the actual API - like PolygonStipple in API_OPENGL_CORE). It seems reasonable that in _mesa_meta_end(), we should restore it, then switch back to the original API. This at least

Re: [Mesa-dev] Piglit - GL/GLSL tests - GSoC 2014

2014-02-26 Thread Kenneth Graunke
On 02/25/2014 09:47 AM, Chirag Agrawal wrote: > Hey! > > I am Chirag. I am currently part of a dual degree program (5yr) at Birla > Institute of Technology & Science, Pilani - Goa Campus, India. I am in > my 4th year as a candidate for a master’s degree in Mathematics and a > bachelor’s degree in

Re: [Mesa-dev] [PATCHv4 2/3] glx_pbuffer: Refactor GetDrawableAttribute

2014-02-26 Thread Jason Wood
On 02/26/2014 06:55 PM, Ian Romanick wrote: > On 02/26/2014 05:22 PM, Jason Wood wrote: >> On 02/26/2014 04:27 PM, Adel Gadllah wrote: >>> Move the pdraw != NULL check out so that they don't >>> have to be duplicated. >>> >>> Signed-off-by: Adel Gadllah >>> Reviewed-by: Ian Romanick >>> --- >>>

Re: [Mesa-dev] [PATCHv4 2/3] glx_pbuffer: Refactor GetDrawableAttribute

2014-02-26 Thread Ian Romanick
On 02/26/2014 05:22 PM, Jason Wood wrote: On 02/26/2014 04:27 PM, Adel Gadllah wrote: Move the pdraw != NULL check out so that they don't have to be duplicated. Signed-off-by: Adel Gadllah Reviewed-by: Ian Romanick --- src/glx/glx_pbuffer.c | 11 ++- 1 file changed, 6 insertions(+)

Re: [Mesa-dev] Piglit - GL/GLSL tests - GSoC 2014

2014-02-26 Thread Anuj Phogat
On Tue, Feb 25, 2014 at 9:47 AM, Chirag Agrawal wrote: > Hey! > > I am Chirag. I am currently part of a dual degree program (5yr) at Birla > Institute of Technology & Science, Pilani - Goa Campus, India. I am in my > 4th year as a candidate for a master's degree in Mathematics and a > bachelor's d

Re: [Mesa-dev] [PATCHv4 2/3] glx_pbuffer: Refactor GetDrawableAttribute

2014-02-26 Thread Jason Wood
On 02/26/2014 04:27 PM, Adel Gadllah wrote: > Move the pdraw != NULL check out so that they don't > have to be duplicated. > > Signed-off-by: Adel Gadllah > Reviewed-by: Ian Romanick > --- > src/glx/glx_pbuffer.c | 11 ++- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git

[Mesa-dev] Student interested in gsoc

2014-02-26 Thread lazaro E Lespes
Hello All, I'm a PhD candidate at CIMAT(www.cimat.mx) . I'm interested in participate as a student in the gsoc in some of your project. In special, I'd like to develop for the project "GL/GLSL test for GL 4.0 and newer". That's way I worked with OpenGL 4.2/GLSL for my master thesis degree finished

[Mesa-dev] [Bug 75549] Ubuntu window title bars corrupted

2014-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75549 Rui Salvaterra changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |i...@freedesktop.org

[Mesa-dev] [PATCHv4 3/3] dri3: Add GLX_EXT_buffer_age support

2014-02-26 Thread Adel Gadllah
Signed-off-by: Adel Gadllah Reviewed-by: Robert Bragg --- src/glx/dri2_glx.c | 1 + src/glx/dri3_glx.c | 19 +++ src/glx/dri3_priv.h | 2 ++ src/glx/glx_pbuffer.c | 33 ++--- src/glx/glxclient.h | 1 + src/glx/glxextensions.c |

[Mesa-dev] [PATCHv4 2/3] glx_pbuffer: Refactor GetDrawableAttribute

2014-02-26 Thread Adel Gadllah
Move the pdraw != NULL check out so that they don't have to be duplicated. Signed-off-by: Adel Gadllah Reviewed-by: Ian Romanick --- src/glx/glx_pbuffer.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/glx/glx_pbuffer.c b/src/glx/glx_pbuffer.c index 411d6e5.

[Mesa-dev] [PATCHv4 1/3] glx: Update glxext.h to revision 25407

2014-02-26 Thread Adel Gadllah
Signed-off-by: Adel Gadllah Reviewed-by: Ian Romanick --- include/GL/glxext.h | 32 +--- 1 file changed, 29 insertions(+), 3 deletions(-) diff --git a/include/GL/glxext.h b/include/GL/glxext.h index 8c642f3..826fda5 100644 --- a/include/GL/glxext.h +++ b/include/GL/g

[Mesa-dev] [PATCHv4 0/3] dri3: Add GLX_EXT_buffer_age support

2014-02-26 Thread Adel Gadllah
Hi, First two patches are unmodified (can someone with commit access please push them?). The buffer_age patch itself now initalizes swap_count to 1 to fix the problem found by Eric (buffer age is 0 after first swap). Adel Gadllah (3): glx: Update glxext.h to revision 25407 glx_pbuffer: Refa

[Mesa-dev] [Bug 63717] Poor performance in games with Intel 965GM

2014-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=63717 Ian Romanick changed: What|Removed |Added Assignee|i...@freedesktop.org |mesa-dev@lists.freedesktop.

Re: [Mesa-dev] [PATCH 2/2] i965: Assert array index on access to vec4_visitor's arrays.

2014-02-26 Thread Ian Romanick
Did you piglit run this? I applied it on current master, and about 2,700 piglit tests assert. On 12/30/2013 01:44 AM, Petri Latvala wrote: Signed-off-by: Petri Latvala --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 2 ++ src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 6 ++ 2 f

[Mesa-dev] [Bug 75549] New: Ubuntu window title bars corrupted

2014-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75549 Priority: medium Bug ID: 75549 Assignee: mesa-dev@lists.freedesktop.org Summary: Ubuntu window title bars corrupted Severity: normal Classification: Unclassified OS: Linux (A

[Mesa-dev] [PATCH 1/2] i915: Only allow 8 vertex texture units

2014-02-26 Thread Ian Romanick
From: Ian Romanick There's no reason to have more vertex texture units than fragment texture units on this hardware. Since increasing the default maximum number of texture units from 16 to 32, this has triggered some segfault in i915 driver. There's probably some array or bitfield that isn't pr

[Mesa-dev] [PATCH 2/2] i915: Allocate the sys_buffer using _mesa_align_malloc

2014-02-26 Thread Ian Romanick
From: Ian Romanick Though it won't matter on Linux, use _mesa_align_free to release it. Since i965 doesn't have sys_buffer, I overlooked this in the GL_ARB_map_buffer_alignment work a few months ago. Fixes i915 (and presumably i830) regressions in ARB_map_buffer_range tests and the failure in ar

[Mesa-dev] [Bug 60216] Mesa Gallium can’t build without X

2014-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60216 Quentin "Sardem FF7" Glidic changed: What|Removed |Added Status|NEW |RESOLVED Resolutio

[Mesa-dev] [Bug 75528] export gbm_device_is_format_supported

2014-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75528 --- Comment #1 from Emil Velikov --- Very nice catch there Marek. Please send the patch to the mesa-dev mailing list for other dev that way be interested. The patch looks great imho, and unless someone objects I'll commit it by the end of the we

[Mesa-dev] [Bug 75545] New: Blitting a partial region to the front buffer produces corrupted display

2014-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75545 Priority: medium Bug ID: 75545 Assignee: mesa-dev@lists.freedesktop.org Summary: Blitting a partial region to the front buffer produces corrupted display Severity: normal

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/4] i965/vec4: Handle ir_triop_lrp on Gen4-5 as well.

2014-02-26 Thread Matt Turner
On Wed, Feb 26, 2014 at 11:26 AM, Kenneth Graunke wrote: > On 02/26/2014 08:35 AM, Ian Romanick wrote: >> On 02/25/2014 05:06 PM, Kenneth Graunke wrote: >>> On 02/25/2014 09:38 AM, Eric Anholt wrote: Matt Turner writes: > On Mon, Feb 24, 2014 at 10:15 AM, Eric Anholt wrote: >>

[Mesa-dev] [PATCH v2 1/5] mesa: Add GL_NV_non_square_matrices for OpenGL ES 2.x.

2014-02-26 Thread Rafal Mielniczuk
v2: Add NV_non_square_matrices to API_XML in Makefile.am Fixup convoluted path in NV_non_square_matrices.xml Fix extension number in es_EXT.xml comment es2api ABI-check was also updated to prevent make check failures in searching for NV suffixed function names. Signed-off-by: Rafal Mielni

Re: [Mesa-dev] [PATCH 1/2] glsl: Fix build warning of unhandled case in switch

2014-02-26 Thread Anuj Phogat
Brian Paul had a patch on mailing list to fix this. So, this patch is no more required. On Tue, Feb 25, 2014 at 6:32 PM, Anuj Phogat wrote: > Signed-off-by: Anuj Phogat > --- > src/glsl/ast_to_hir.cpp | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/src/glsl/ast_to_hir.cpp b/src/gl

Re: [Mesa-dev] [PATCH] glsl: add switch case for MESA_SHADER_COMPUTE

2014-02-26 Thread Anuj Phogat
On Tue, Feb 25, 2014 at 11:39 AM, Brian Paul wrote: > To fix warning about unhandled enum value. > --- > src/glsl/ast_to_hir.cpp |3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp > index f06baeb..8f6e901 100644 > --- a/src/glsl/ast_to

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/4] i965/vec4: Handle ir_triop_lrp on Gen4-5 as well.

2014-02-26 Thread Kenneth Graunke
On 02/26/2014 08:35 AM, Ian Romanick wrote: > On 02/25/2014 05:06 PM, Kenneth Graunke wrote: >> On 02/25/2014 09:38 AM, Eric Anholt wrote: >>> Matt Turner writes: >>> On Mon, Feb 24, 2014 at 10:15 AM, Eric Anholt wrote: > I think we would do better by emitting > ADD(y_minus_x, y, neg

[Mesa-dev] [Bug 74085] [Counter Strike: Source] Blue smoke in very specific places (nv50, r600g)

2014-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74085 Benjamin Bellec changed: What|Removed |Added Summary|[Counter Strike: Source]|[Counter Strike: Source]

[Mesa-dev] [Bug 74085] [Counter Strike: Source] Blue smoke in very specific places (nv50, r600g) (cannot bisect)

2014-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74085 Benjamin Bellec changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH 1/5] mesa: Add GL_NV_non_square_matrices for OpenGL ES 2.x.

2014-02-26 Thread Fabian Bieler
On 2014-02-26 19:34, Rafal Mielniczuk wrote: es2api ABI-check was also updated to prevent make check failures in searching for NV suffixed function names. Signed-off-by: Rafal Mielniczuk --- src/mapi/es2api/ABI-check | 6 +++ src/mapi/glapi/gen/NV_non_square_matrices.xml

[Mesa-dev] [Bug 75543] OSMesa Gallium OSMesaMakeCurrent

2014-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75543 nacho...@gmail.com changed: What|Removed |Added CC||nacho...@gmail.com -- You are recei

[Mesa-dev] [Bug 75543] New: OSMesa Gallium OSMesaMakeCurrent

2014-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75543 Priority: medium Bug ID: 75543 Assignee: mesa-dev@lists.freedesktop.org Summary: OSMesa Gallium OSMesaMakeCurrent Severity: normal Classification: Unclassified OS: Linux (All

[Mesa-dev] [PATCH 2/5] glsl: Define GL_NV_non_square_matrices in an OpenGL ES shader

2014-02-26 Thread Rafal Mielniczuk
Signed-off-by: Rafal Mielniczuk --- src/glsl/glcpp/glcpp-parse.y | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index bdc598f..da89046 100644 --- a/src/glsl/glcpp/glcpp-parse.y +++ b/src/glsl/glcpp/glcpp-parse.y @@

Re: [Mesa-dev] [PATCH] mesa: add bounds checking to eliminate buffer overrun

2014-02-26 Thread Ian Romanick
On 02/17/2014 09:43 AM, Courtney Goeltzenleuchter wrote: Thanks for the feedback. I've updated the patch to integrate Ian's comments. Did the updated patch ever land? Courtney On Fri, Feb 14, 2014 at 2:00 PM, Ian Romanick mailto:i...@freedesktop.org>> wrote: On 02/14/2014 07:52 AM, Co

[Mesa-dev] [PATCH 1/5] mesa: Add GL_NV_non_square_matrices for OpenGL ES 2.x.

2014-02-26 Thread Rafal Mielniczuk
es2api ABI-check was also updated to prevent make check failures in searching for NV suffixed function names. Signed-off-by: Rafal Mielniczuk --- src/mapi/es2api/ABI-check | 6 +++ src/mapi/glapi/gen/NV_non_square_matrices.xml | 59 +++ src/mapi/glapi

[Mesa-dev] [PATCH 0/5] Enable GL_NV_non_square_matrices extension

2014-02-26 Thread Rafal Mielniczuk
Hello, This series enable GL_NV_non_square_matrices from newbie projects wiki. Piglit tests have already been sent to piglit dev list. Rafal Rafal Mielniczuk (5): mesa: Add GL_NV_non_square_matrices for OpenGL ES 2.x. glsl: Define GL_NV_non_square_matrices in an OpenGL ES shader glsl: Add

Re: [Mesa-dev] [PATCH] i965: Widen sampler key bitfields for 32 samplers

2014-02-26 Thread Kenneth Graunke
On 02/26/2014 10:28 AM, Chris Forbes wrote: > Previously the `high` 16 samplers on Haswell+ would not get sampler > workarounds applied. > > Don't bother widening YUV fields, since they're ignored and going away > soon anyway. > > Signed-off-by: Chris Forbes > Cc: "10.1" Reviewed-by: Kenneth G

Re: [Mesa-dev] Mesa (master): i965/vec4: Handle ir_triop_lrp on Gen4-5 as well.

2014-02-26 Thread Kenneth Graunke
On 02/26/2014 09:29 AM, Ian Romanick wrote: > On 02/26/2014 02:25 AM, Kenneth Graunke wrote: >> Module: Mesa >> Branch: master >> Commit: 56879a7ac41b8c7513a97cc02921f76a2ec8407c >> URL: >> http://cgit.freedesktop.org/mesa/mesa/commit/?id=56879a7ac41b8c7513a97cc02921f76a2ec8407c >> >> Author: K

[Mesa-dev] [PATCH 3/5] glsl: Add supported extensions entry for for GL_NV_non_square_matrices

2014-02-26 Thread Rafal Mielniczuk
Signed-off-by: Rafal Mielniczuk --- src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index 416acb9..5840311 100644 --- a/src/glsl/glsl_parser_extras.cpp +

[Mesa-dev] [PATCH 5/5] mesa: Enable NV_non_square_matrices in ES2 context

2014-02-26 Thread Rafal Mielniczuk
Signed-off-by: Rafal Mielniczuk --- src/mesa/main/extensions.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index bc63b26..c2c8a52 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -339,6 +339,7 @@ static con

[Mesa-dev] [PATCH 4/5] glsl: Enable NV_non_square_matrices types

2014-02-26 Thread Rafal Mielniczuk
Signed-off-by: Rafal Mielniczuk --- src/glsl/builtin_types.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/glsl/builtin_types.cpp b/src/glsl/builtin_types.cpp index dd42ecb..bb260b8 100644 --- a/src/glsl/builtin_types.cpp +++ b/src/glsl/builtin_types.cpp @@ -360,5 +360,14 @@

[Mesa-dev] [PATCH] i965: Widen sampler key bitfields for 32 samplers

2014-02-26 Thread Chris Forbes
Previously the `high` 16 samplers on Haswell+ would not get sampler workarounds applied. Don't bother widening YUV fields, since they're ignored and going away soon anyway. Signed-off-by: Chris Forbes Cc: "10.1" Cc: Kenneth Graunke --- src/mesa/drivers/dri/i965/brw_program.h | 6 +++--- 1 fil

Re: [Mesa-dev] [PATCH 1/2] i965: Only emit VS state pipe control workaround on IVB and BYT.

2014-02-26 Thread Eric Anholt
Kenneth Graunke writes: > According to the BSpec's 3D workarounds page, this is unnecessary on > shipping Haswell hardware, and was never necessary on Broadwell. It > unfortunately doesn't say anything about Baytrail. > > The workaround database confirms those results for Ivybridge, Haswell, > a

Re: [Mesa-dev] Mesa (master): i965/vec4: Handle ir_triop_lrp on Gen4-5 as well.

2014-02-26 Thread Ian Romanick
On 02/26/2014 02:25 AM, Kenneth Graunke wrote: > Module: Mesa > Branch: master > Commit: 56879a7ac41b8c7513a97cc02921f76a2ec8407c > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=56879a7ac41b8c7513a97cc02921f76a2ec8407c > > Author: Kenneth Graunke > Date: Sun Feb 23 16:29:46 2014 -

Re: [Mesa-dev] [PATCH 6/8] mesa: add missing null checks in _tnl_register_fastpath()

2014-02-26 Thread Ian Romanick
On 02/25/2014 06:41 AM, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila --- src/mesa/tnl/t_vertex.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/mesa/tnl/t_vertex.c b/src/mesa/tnl/t_vertex.c index b3deac0..b3e70d3 100644 --- a/src/mes

Re: [Mesa-dev] [PATCH 7/8] mesa: add extra null checks in vbo_rebase_prims()

2014-02-26 Thread Brian Paul
On 02/25/2014 07:41 AM, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila --- src/mesa/vbo/vbo_rebase.c | 28 +--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/src/mesa/vbo/vbo_rebase.c b/src/mesa/vbo/vbo_rebase.c index c700621..dd754e2 10

Re: [Mesa-dev] [PATCH 4/8] mesa: Add missing null check in _mesa_parse_arb_program()

2014-02-26 Thread Brian Paul
On 02/25/2014 07:41 AM, Juha-Pekka Heikkila wrote: Add missing null check in program_parse.tab.c through program_parse.y Signed-off-by: Juha-Pekka Heikkila --- src/mesa/program/program_parse.y | 5 + 1 file changed, 5 insertions(+) diff --git a/src/mesa/program/program_parse.y b/src/mes

Re: [Mesa-dev] [PATCH 6/8] mesa: add missing null checks in _tnl_register_fastpath()

2014-02-26 Thread Brian Paul
On 02/25/2014 07:41 AM, Juha-Pekka Heikkila wrote: Signed-off-by: Juha-Pekka Heikkila --- src/mesa/tnl/t_vertex.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/src/mesa/tnl/t_vertex.c b/src/mesa/tnl/t_vertex.c index b3deac0..b3e70d3 100644 --- a/src/mes

Re: [Mesa-dev] [PATCH v3 2/2] R600/SI: Optimize SI_KILL for constant operands

2014-02-26 Thread Tom Stellard
On Wed, Feb 26, 2014 at 01:48:39PM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > If the SI_KILL operand is constant, we can either clear the exec mask if > the operand is negative, or do nothing otherwise. > > Signed-off-by: Michel Dänzer Reviewed-by: Tom Stellard > --- > > v3: > *

[Mesa-dev] [Bug 74717] r600g: 'invalid read' linking geometry shader

2014-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74717 --- Comment #11 from Michel Dänzer --- (In reply to comment #10) > warning: failed to translate tgsi opcode EMIT to LLVM <<<=== !!! The r600g LLVM shader compiler doesn't support geometry shaders yet. I generally advise against compiling Me

[Mesa-dev] [Bug 74717] r600g: 'invalid read' linking geometry shader

2014-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74717 --- Comment #10 from Dieter Nützel --- Addendum: 3.14.0-rc4 + drm-radeon-fix-missing-bo-reservation.patch Mesa 10.2.0-devel (git-54df6a0) LLVM 3.4 stable RV730 AGP With R600_DEBUG=nosb I get this (from time to time): /opt/ogl-samples> ./build/

[Mesa-dev] [Bug 75528] New: export gbm_device_is_format_supported

2014-02-26 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=75528 Priority: medium Bug ID: 75528 Assignee: mesa-dev@lists.freedesktop.org Summary: export gbm_device_is_format_supported Severity: normal Classification: Unclassified OS: Linux