Re: [Mesa-dev] [PATCH 10/12] i965: Enable ARB_fragment_shader_viewport for Gen7+ core.

2014-01-24 Thread Chris Forbes
Oops-- silly mistake in subject line. s/shader/layer/ On Sat, Jan 25, 2014 at 7:51 PM, Chris Forbes wrote: > This requires both GS and ARB_viewport_array, so we can only enable it > in core contexts for Gen7+ for now. > > Signed-off-by: Chris Forbes > --- > src/mesa/drivers/dri/i965/intel_exten

[Mesa-dev] [PATCH 05/12] glsl: Add extension plumbing for ARB_fragment_layer_viewport

2014-01-24 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/glsl/glsl_parser_extras.cpp | 1 + src/glsl/glsl_parser_extras.h | 2 ++ src/glsl/standalone_scaffolding.cpp | 1 + 3 files changed, 4 insertions(+) diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp index 87784ed..13dcacb

[Mesa-dev] [PATCH 09/12] i965/fs: Add support for gl_ViewportIndex input

2014-01-24 Thread Chris Forbes
Same idea as gl_Layer -- this is delivered in part of R0.0. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_fs.cpp | 22 ++ src/mesa/drivers/dri/i965/brw_fs.h | 1 + src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 2 ++ 3 files changed, 25 ins

[Mesa-dev] [PATCH 12/12] docs: Note that ARB_fragment_layer_viewport is done in 10.1 relnotes

2014-01-24 Thread Chris Forbes
Signed-off-by: Chris Forbes --- docs/relnotes/10.1.html | 1 + 1 file changed, 1 insertion(+) diff --git a/docs/relnotes/10.1.html b/docs/relnotes/10.1.html index 14b635f..4b83f7c 100644 --- a/docs/relnotes/10.1.html +++ b/docs/relnotes/10.1.html @@ -49,6 +49,7 @@ Note: some of the new features

[Mesa-dev] [PATCH 08/12] i965/fs: Add support for gl_Layer input

2014-01-24 Thread Chris Forbes
This is a bit unusual -- we want to treat it as an input on the GLSL side rather than a `system value` oddball. However, it doesn't get a real slot in the VUE layout -- earlier shader stages write it into the vertex header, and it appears in the FS payload packed into some R0.0 bits. Signed-off-by

[Mesa-dev] [PATCH 07/12] glsl: Add gl_Layer and gl_ViewportIndex builtins to fragment shader

2014-01-24 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/glsl/builtin_variables.cpp | 5 + 1 file changed, 5 insertions(+) diff --git a/src/glsl/builtin_variables.cpp b/src/glsl/builtin_variables.cpp index d6bc3c0..bb499fa 100644 --- a/src/glsl/builtin_variables.cpp +++ b/src/glsl/builtin_variables.cpp @@ -864,6

[Mesa-dev] [PATCH 10/12] i965: Enable ARB_fragment_shader_viewport for Gen7+ core.

2014-01-24 Thread Chris Forbes
This requires both GS and ARB_viewport_array, so we can only enable it in core contexts for Gen7+ for now. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/intel_extensions.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/intel_extension

[Mesa-dev] [PATCH 11/12] docs: Mark ARB_fragment_layer_viewport as done on i965.

2014-01-24 Thread Chris Forbes
Signed-off-by: Chris Forbes --- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 799db4b..c8cb917 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -149,7 +149,7 @@ GL 4.3: GL_ARB_copy_imagenot

[Mesa-dev] [PATCH 03/12] glapi: Add (empty) api section for ARB_fragment_layer_viewport

2014-01-24 Thread Chris Forbes
This extension is purely GLSL -- there are no new GL API elements. Signed-off-by: Chris Forbes --- src/mapi/glapi/gen/gl_API.xml | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 42df1ad..bd0a2a7 100644

[Mesa-dev] [PATCH 04/12] mesa: Add extension plumbing for ARB_fragment_layer_viewport

2014-01-24 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 0676f1e..3239268 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.

[Mesa-dev] [PATCH 06/12] glsl: Add builtin define for ARB_fragment_layer_viewport

2014-01-24 Thread Chris Forbes
The spec doesn't actually mention adding this, but this is the usual pattern so I'm assuming it's a spec bug. Signed-off-by: Chris Forbes --- src/glsl/glcpp/glcpp-parse.y | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y index 184e

[Mesa-dev] [PATCH 02/12] i965/vs: Fix typo in brw_compute_vue_map

2014-01-24 Thread Chris Forbes
--- src/mesa/drivers/dri/i965/brw_vs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_vs.c b/src/mesa/drivers/dri/i965/brw_vs.c index a4f2ac6..092d53a 100644 --- a/src/mesa/drivers/dri/i965/brw_vs.c +++ b/src/mesa/drivers/dri/i965/brw_vs.c @@ -61

[Mesa-dev] [PATCH 01/12] glapi: Note apparent gap in numbering from ARB_multi_draw_indirect

2014-01-24 Thread Chris Forbes
This is defined in the same included file as ARB_draw_indirect. Signed-off-by: Chris Forbes --- src/mapi/glapi/gen/gl_API.xml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml index 193ee37..42df1ad 100644 --- a/src/mapi/glapi/ge

[Mesa-dev] [PATCH 00/12] ARB_fragment_layer_viewport for i965

2014-01-24 Thread Chris Forbes
This series adds support for ARB_fragment_layer_viewport on i965 Gen7, in core contexts [the same conditions as for ARB_viewport_array being exposed]. This is another tiny piece of GL4.3, allowing the GS- [or with AMD_vertex_shader_*, VS- ] written values of gl_Layer and gl_ViewportIndex to be rea

[Mesa-dev] Help requested with drisw bug

2014-01-24 Thread Federico Mena Quintero
Hi, I've been looking for this bug for a couple of months now, and I don't feel like I'm making much progress. Attached is a piglit test that exposes the bug. Run this with software rendering: export LIBGL_ALWAYS_SOFTWARE=1 The bug is very obvious if you run Clutter programs with that, e.g.

Re: [Mesa-dev] [PATCH 05/18] glapi: Add infrastructure for ARB_multi_bind

2014-01-24 Thread Matt Turner
On Tue, Jan 21, 2014 at 3:35 PM, Fredrik Höglund wrote > xmlns:xi="http://www.w3.org/2001/XInclude"/> > > + Should be #142...#146. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 02/16] radeonsi: Initial geometry shader support

2014-01-24 Thread Marek Olšák
On Fri, Jan 24, 2014 at 10:19 PM, Marek Olšák wrote: > 1) Do we really have to have so much code inside #if...#endif? Can we > always compile everything and just not set the pipe_context functions > if LLVM < 3.5 and the same for get_(shader_)param? You can even do it > without the preprocessor, e

Re: [Mesa-dev] [PATCH 3/8] mesa: Validate internalFormat with target in glTexStorage paths

2014-01-24 Thread Ian Romanick
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 01/24/2014 02:44 PM, Kenneth Graunke wrote: > On 01/24/2014 02:18 PM, Ian Romanick wrote: >> From: Ian Romanick >> >> Fixes the glTexStorage3D failure in >> ext_packed_depth_stencil-depth-stencil-texture and >> oes_packed_depth_stencil-depth-ste

[Mesa-dev] [PATCH] glsl: Set proper swizzle when a channel is missing in vectorizing.

2014-01-24 Thread Matt Turner
Previously, for example if the x channel was missing from a series of assignments we were attempting to vectorize, the wrong swizzle mask would be applied. a.y = b.y; a.z = b.z; a.w = b.w; would be incorrectly transformed into a.yzw = b.xyz; Fixes two transform feedback tests in the

Re: [Mesa-dev] [PATCH 14/16] radeonsi: We don't support indirect addressing of shader inputs/outputs

2014-01-24 Thread Marek Olšák
Please can this be done for the geometry shader only? Marek On Fri, Jan 24, 2014 at 10:33 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes piglit spec/glsl-1.50/execution/geometry/dynamic_input_array_index > > Signed-off-by: Michel Dänzer > --- > src/gallium/drivers/radeonsi/si_pipe.c

Re: [Mesa-dev] [PATCH libdrm] modeprint: pretty print connector names

2014-01-24 Thread Alex Deucher
On Fri, Jan 24, 2014 at 9:17 AM, Alex Deucher wrote: > On Fri, Jan 17, 2014 at 6:19 AM, Lucas Stach wrote: >> Use same names as the kernel, makes it easier to identify >> connectors in the common case. >> >> Signed-off-by: Lucas Stach > > Reviewed-by: Alex Deucher > > If there are no other comm

Re: [Mesa-dev] [PATCH 2/8] mesa: Refactor internalFormat / target checks to a separate function

2014-01-24 Thread Brian Paul
On 01/24/2014 03:18 PM, Ian Romanick wrote: From: Ian Romanick We need almost identical code in the glTexStorage path. Signed-off-by: Ian Romanick --- src/mesa/main/teximage.c | 110 ++- src/mesa/main/teximage.h | 8 2 files changed, 78 i

Re: [Mesa-dev] [PATCH 4/8] radeon / r200: Pass the API into _mesa_initialize_context

2014-01-24 Thread Alex Deucher
On Fri, Jan 24, 2014 at 5:18 PM, Ian Romanick wrote: > From: Ian Romanick > > Otherwise an application that requested an OpenGL ES 1.x context would > actually get a desktop OpenGL context. > > Signed-off-by: Ian Romanick > Cc: "9.1 9.2 10.0" patches 4-7 are: Reviewed-by: Alex Deucher > ---

Re: [Mesa-dev] [PATCH 3/8] mesa: Validate internalFormat with target in glTexStorage paths

2014-01-24 Thread Kenneth Graunke
On 01/24/2014 02:18 PM, Ian Romanick wrote: > From: Ian Romanick > > Fixes the glTexStorage3D failure in > ext_packed_depth_stencil-depth-stencil-texture and > oes_packed_depth_stencil-depth-stencil-texture_gles2. > > Signed-off-by: Ian Romanick > --- > src/mesa/main/teximage.c | 4 +++- > s

Re: [Mesa-dev] [PATCH 05/18] glapi: Add infrastructure for ARB_multi_bind

2014-01-24 Thread Ian Romanick
On 01/22/2014 09:00 AM, Brian Paul wrote: > On 01/21/2014 03:35 PM, Fredrik Höglund wrote: >> --- >> src/mapi/glapi/gen/ARB_multi_bind.xml | 53 >> +++ >> src/mapi/glapi/gen/Makefile.am |1 + >> src/mapi/glapi/gen/gl_API.xml |4 +++ >>

[Mesa-dev] [PATCH 5/8] r200: Enable GL_EXT_framebuffer_blit

2014-01-24 Thread Ian Romanick
From: Ian Romanick The dd_function_table::BlitFramebuffer is already initialized to _mesa_meta_BlitFramebuffer, so it should just work. Tested on a FireGL 8800 (OpenGL renderer string: Mesa DRI R200 (R200 5148) TCL DRI). Signed-off-by: Ian Romanick --- docs/relnotes/10.1.html

[Mesa-dev] [PATCH 8/8] mesa: Clean up bad code formatting left from previous commit

2014-01-24 Thread Ian Romanick
From: Ian Romanick Also s/_EXT// on enums that are now part of core. Signed-off-by: Ian Romanick --- src/mesa/main/fbobject.c | 23 ++- 1 file changed, 10 insertions(+), 13 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 38b2727..4f510ee

[Mesa-dev] [PATCH 4/8] radeon / r200: Pass the API into _mesa_initialize_context

2014-01-24 Thread Ian Romanick
From: Ian Romanick Otherwise an application that requested an OpenGL ES 1.x context would actually get a desktop OpenGL context. Signed-off-by: Ian Romanick Cc: "9.1 9.2 10.0" --- src/mesa/drivers/dri/r200/r200_context.c| 2 +- src/mesa/drivers/dri/radeon/radeon_common_context.c |

[Mesa-dev] [PATCH 6/8] radeon: Enable GL_EXT_framebuffer_blit

2014-01-24 Thread Ian Romanick
From: Ian Romanick The dd_function_table::BlitFramebuffer is already initialized to _mesa_meta_BlitFramebuffer, so it should just work. Tested on a Radeon 7500 (OpenGL renderer string: Mesa DRI R100 (RV200 5157) TCL DRI2). I couldn't do a full piglit run because it would tank the system with or

[Mesa-dev] [PATCH 2/8] mesa: Refactor internalFormat / target checks to a separate function

2014-01-24 Thread Ian Romanick
From: Ian Romanick We need almost identical code in the glTexStorage path. Signed-off-by: Ian Romanick --- src/mesa/main/teximage.c | 110 ++- src/mesa/main/teximage.h | 8 2 files changed, 78 insertions(+), 40 deletions(-) diff --git a/src/m

[Mesa-dev] [PATCH 1/8] mesa: Generate the correct error for a depth format with a 3D texture

2014-01-24 Thread Ian Romanick
From: Ian Romanick All versions of the OpenGL spec are quite clear that GL_INVALID_OPERATION should be generated. I added a quotation from the 3.3 core profile spec. Fixes the glTexImage3D subcases of ext_packed_depth_stencil-depth-stencil-texture and oes_packed_depth_stencil-depth-stencil-text

[Mesa-dev] [PATCH 7/8] mesa: GL_EXT_framebuffer_blit is not optional

2014-01-24 Thread Ian Romanick
From: Ian Romanick Every driver supports it. All current and future Gallium drivers always support it, and all existing classic drivers support it. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i915/intel_extensions.c | 1 - src/mesa/drivers/dri/i965/intel_extensions.c | 1 - src

[Mesa-dev] [PATCH 3/8] mesa: Validate internalFormat with target in glTexStorage paths

2014-01-24 Thread Ian Romanick
From: Ian Romanick Fixes the glTexStorage3D failure in ext_packed_depth_stencil-depth-stencil-texture and oes_packed_depth_stencil-depth-stencil-texture_gles2. Signed-off-by: Ian Romanick --- src/mesa/main/teximage.c | 4 +++- src/mesa/main/texstorage.c | 5 + 2 files changed, 8 insertio

Re: [Mesa-dev] [Mesa-stable] [PATCH 2/2] glsl: Fix chained assignments of vector channels.

2014-01-24 Thread Ian Romanick
On 01/24/2014 11:48 AM, Kenneth Graunke wrote: > Simple shaders such as: > > void splat(vec2 v, float f) { > v[0] = v[1] = f; > } > > failed to compile with the following error: > error: value of type vec2 cannot be assigned to variable of type float > > First, we would process v

[Mesa-dev] [PATCH 2/2] i965: Limit depth in surface_state according to NumLayers

2014-01-24 Thread Chris Forbes
Previously it was possible to sample off the end of the view, out to the full extent of the data store. Now we get correct clamping behavior. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --g

[Mesa-dev] [PATCH 0/2] ARB_texture_view clamping behavior tidy-ups.

2014-01-24 Thread Chris Forbes
These two patches correct issues with level and layer clamping with texture views. With the main series + this, Jon's rendering-levels and rendering-layers tests behave correctly. I'll fit these into the appropriate points in the main series, but didn't feel it was necessary to send out the who

[Mesa-dev] [PATCH 1/2] mesa: Adjust _MaxLevel computation to account for views

2014-01-24 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/main/texobj.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 3c64c437..9cb46cd 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -557,6 +557,13 @@ _mesa_test_texobj_complet

Re: [Mesa-dev] [PATCH] glcpp: Make sure GL_AMD_shader_trinary_minmax is defined

2014-01-24 Thread Kenneth Graunke
On 01/24/2014 01:33 PM, Ian Romanick wrote: > From: Ian Romanick > > The define was only available if > gl_extensions::AMD_shader_trinary_minmax was set, but no driver set it. > Since the extension is advertised by default, remove that field too. > > Signed-off-by: Ian Romanick > Cc: Maxence Le

Re: [Mesa-dev] [PATCH 2/2] glsl: Fix chained assignments of vector channels.

2014-01-24 Thread Matt Turner
Cool. Both are Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH] glcpp: Make sure GL_AMD_shader_trinary_minmax is defined

2014-01-24 Thread Matt Turner
Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] glcpp: Make sure GL_AMD_shader_trinary_minmax is defined

2014-01-24 Thread Ian Romanick
From: Ian Romanick The define was only available if gl_extensions::AMD_shader_trinary_minmax was set, but no driver set it. Since the extension is advertised by default, remove that field too. Signed-off-by: Ian Romanick Cc: Maxence Le Doré CC: Kenneth Graunke --- src/glsl/glcpp/glcpp-parse.

Re: [Mesa-dev] R600/SI: New intrinsics for radeonsi geometry shaders

2014-01-24 Thread Tom Stellard
On Fri, Jan 24, 2014 at 03:17:04PM +0900, Michel Dänzer wrote: > > The attached patches add two intrinsics to the R600 backend which are > necessary for geometry shader support in the radeonsi driver. > Patch 1 and v2 of Patch 2 are: Reviewed-by: Tom Stellard -Tom > > -- > Earthling Michel

[Mesa-dev] [PATCH 2/2] glsl: Fix chained assignments of vector channels.

2014-01-24 Thread Kenneth Graunke
Simple shaders such as: void splat(vec2 v, float f) { v[0] = v[1] = f; } failed to compile with the following error: error: value of type vec2 cannot be assigned to variable of type float First, we would process v[1] = f, and transform: LHS: (expression float vector_extract (var_

[Mesa-dev] [PATCH 1/2] glsl: Rename "expr" to "lhs_expr" in vector_extract munging code.

2014-01-24 Thread Kenneth Graunke
When processing assignments, we have both an LHS and RHS. At a glance, "lhs_expr" clearly refers to the LHS, while a generic name like "expr" is ambiguous. Cc: i...@freedesktop.org Cc: mesa-sta...@lists.freedesktop.org Signed-off-by: Kenneth Graunke --- src/glsl/ast_to_hir.cpp | 12 ++--

[Mesa-dev] [Bug 74010] mesa-10.0.2: z-buffer issue with opengl 3.3 context on intel

2014-01-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74010 Matt Turner changed: What|Removed |Added Attachment #92717|text/plain |application/x-tgz mime type|

[Mesa-dev] [PATCH v3] EGL/Wayland: DRI_PRIME support

2014-01-24 Thread Axel Davy
Implements DRI_PRIME support. Signed-off-by: Axel Davy --- v3: add a check in dri2_create_wayland_buffer_from_image_wl to fail if we are on a different device than the compositor, and then can't use tiling. This is in the spec. The patch has been rebased. v2: bug fix src/egl/drivers/dri2/egl_dri

Re: [Mesa-dev] [PATCH] R600/SI: Add pattern for truncating i32 to i1

2014-01-24 Thread Tom Stellard
On Fri, Jan 24, 2014 at 01:27:00PM +0900, Michel Dänzer wrote: > From: Michel Dänzer > > Fixes half a dozen piglit tests with radeonsi. > > Signed-off-by: Michel Dänzer > --- > lib/Target/R600/SIInstructions.td | 5 + > test/CodeGen/R600/trunc.ll| 10 ++ > 2 files changed,

[Mesa-dev] [PATCH mesa] wayland: Fix the logic in disabling the prime capability

2014-01-24 Thread Neil Roberts
It looks like this bit of code is trying to disable the prime capability if the driver doesn't support createImageFromFds. However the logic looks a bit broken and what it would actually do is disable all other capabilities apart from prime. This patch fixes it to actually disable prime. --- src/e

Re: [Mesa-dev] [PATCH libdrm] modeprint: pretty print connector names

2014-01-24 Thread Rob Clark
On Fri, Jan 17, 2014 at 6:19 AM, Lucas Stach wrote: > Use same names as the kernel, makes it easier to identify > connectors in the common case. > > Signed-off-by: Lucas Stach Reviewed-by: Rob Clark > --- > tests/modeprint/modeprint.c | 28 +++- > 1 file changed, 27 in

Re: [Mesa-dev] [PATCH libdrm] modeprint: pretty print connector names

2014-01-24 Thread Alex Deucher
On Fri, Jan 17, 2014 at 6:19 AM, Lucas Stach wrote: > Use same names as the kernel, makes it easier to identify > connectors in the common case. > > Signed-off-by: Lucas Stach Reviewed-by: Alex Deucher If there are no other comments, I'll apply this later today. > --- > tests/modeprint/modep

[Mesa-dev] [Bug 74010] mesa-10.0.2: z-buffer issue with opengl 3.3 context on intel

2014-01-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74010 --- Comment #4 from Evgeny Bobkin --- Well, it should be noted, that test case is a OpenGL-cpp.tar.gz file and the mentioned above video is a .webm file This test sample runs fine as well when started with $ optirun ./tutorial4 on configure

[Mesa-dev] What use do swap interval > 1 and OML_sync_control divisor and remainder have?

2014-01-24 Thread Pekka Paalanen
Hi, I am investigating what kind of Wayland protocol extensions would be needed to support proper presentation timing. Looking at existing works, I am wondering about two things whether they have any real use. Where is swap interval (e.g. eglSwapInterval) greater than one useful? Intervals 0 and

Re: [Mesa-dev] [PATCH 3/3] st/mesa: add a simple sanity check assertion in st_validate_attachment()

2014-01-24 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Fri, Jan 24, 2014 at 2:20 AM, Brian Paul wrote: > --- > src/mesa/state_tracker/st_cb_fbo.c |6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/mesa/state_tracker/st_cb_fbo.c > b/src/mesa/state_tracker/st_cb_fbo.c > index eca04b8..7801484 100

Re: [Mesa-dev] [V4 PATCH 0/7] mesa: Naming MESA_FORMATs to a specification

2014-01-24 Thread Marek Olšák
On Thu, Jan 23, 2014 at 8:36 PM, Kenneth Graunke wrote: > On 01/23/2014 11:19 AM, Mark Mueller wrote: >> That works for sRGB, but what about other color spaces that may be added in >> the future? I'm fine with leaving that to another day and with using the >> _SRGB decoration, as you say. > > Oy.

Re: [Mesa-dev] [PATCH libdrm] modeprint: pretty print connector names

2014-01-24 Thread Lucas Stach
Ping. Can someone please take a look and if there are no objections commit this for me? I don't have commit access myself. Am Freitag, den 17.01.2014, 12:19 +0100 schrieb Lucas Stach: > Use same names as the kernel, makes it easier to identify > connectors in the common case. > > Signed-off-by:

[Mesa-dev] [PATCH 06/16] radeonsi: Handle adjacency primitives

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_state_draw.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index 2185f16..f326261 10064

[Mesa-dev] [PATCH 00/16] radeonsi: OpenGL 3.3 support

2014-01-24 Thread Michel Dänzer
This patch series adds GLSL 1.50 geometry shader support and thus OpenGL 3.3 support to the radeonsi driver. It depends on two patches to the LLVM R600 backend I posted earlier today. Only 5 driver specific piglit tests enabled by this series are still failing. [PATCH 01/16] radeonsi: Refactor sh

[Mesa-dev] [PATCH 12/16] radeonsi: Fix streamout from geometry shader

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_shader.c | 37 +++- 1 file changed, 27 insertions(+), 10 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeonsi/si_shader.c index 1d93d8b

[Mesa-dev] [PATCH 09/16] radeonsi: Really dump TGSI code before any TGSI->LLVM conversion attempt

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer While we're at it, use the local variable 'sel'. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_shader.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/r

[Mesa-dev] [PATCH 13/16] radeonsi: Pass VS resource descriptors to the HW ES shader stage as well

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer This makes sure constants and samplers work in the vertex shader even when a geometry shader is active. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_descriptors.c | 21 +++--- src/gallium/drivers/radeonsi/si_pipe.h| 7 +- src/gal

[Mesa-dev] [PATCH 03/16] radeonsi: Fix handling of geometry shader output vertex ID

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer It needs to increment at shader runtime, not at shader compile time, as the geometry shader can emit vertices in loops. LLVM automagically converts the ID back to an immediate value if its value can be determined at compile time. Signed-off-by: Michel Dänzer --- src/gallium

[Mesa-dev] [PATCH 10/16] radeonsi: Properly match ES outputs to GS inputs

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer Fixes piglit vs-gs-arrays-within-blocks-pass. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_shader.c | 21 - 1 file changed, 16 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers

[Mesa-dev] [PATCH 16/16] radeonsi: Enable OpenGL 3.3

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_pipe.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pipe.c index dab1180..2c1966b 100644 --- a/src/g

[Mesa-dev] [PATCH 05/16] radeonsi: Handle TGSI_SEMANTIC_PRIMID

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_shader.c | 15 ++- src/gallium/drivers/radeonsi/si_shader.h | 1 + src/gallium/drivers/radeonsi/si_state_draw.c | 2 +- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/src/

[Mesa-dev] [PATCH 15/16] radeonsi: Geometry shader micro-optimizations

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer Move parameter loads out of loops, and use the instruction offset instead of a VGPR for the vertex attribute offset when writing to the ESGS ring buffer. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_shader.c | 22 ++ 1 file changed, 1

[Mesa-dev] [PATCH 14/16] radeonsi: We don't support indirect addressing of shader inputs/outputs

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer Fixes piglit spec/glsl-1.50/execution/geometry/dynamic_input_array_index Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_pipe.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/si_pipe.c b/src/gallium/drivers/radeonsi/si_pip

[Mesa-dev] [PATCH 07/16] radeonsi: Take GS into account for VS state in more places

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_shader.c | 4 src/gallium/drivers/radeonsi/si_shader.h | 8 src/gallium/drivers/radeonsi/si_state_draw.c | 4 ++-- 3 files changed, 14 insertions(+), 2 deletions(-) diff --git a/src/galli

[Mesa-dev] [PATCH 08/16] radeonsi: Also export clip distances with geometry shader

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_shader.c | 1 + src/gallium/drivers/radeonsi/si_state.c | 13 - 2 files changed, 9 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/src/gallium/drivers/radeo

[Mesa-dev] [PATCH 01/16] radeonsi: Refactor shader input / output handling code

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer In preparation for adding geometry shader support. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_shader.c | 486 +-- 1 file changed, 268 insertions(+), 218 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_shader.c b/

[Mesa-dev] [PATCH 11/16] radeonsi: Simplify shader PM4 state handling

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer Just always bind the current states before drawing. Besides the simplification, as a bonus this makes sure the VS hardware shader stage always uses the GS copy shader when a geometry shader is active, fixing a number of GS related piglit tests. Signed-off-by: Michel Dänzer

[Mesa-dev] [PATCH 04/16] radeonsi: Generalize counting of shader parameters

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer Now it covers ES->GS as well as VS->PS. Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/si_shader.c | 82 src/gallium/drivers/radeonsi/si_shader.h | 2 +- src/gallium/drivers/radeonsi/si_state_draw.c | 2 +- 3 files chang

[Mesa-dev] [Bug 74010] mesa-10.0.2: z-buffer issue with opengl 3.3 context on intel

2014-01-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74010 --- Comment #3 from Evgeny Bobkin --- another issue is that if there two lines glGenVertexArrays (1, &vao_id); glBindVertexArray (vao_id); from lines 46-47 are removed and the cube is drawn with glEnableVertexAttribArray (position_

[Mesa-dev] [Bug 74010] mesa-10.0.2: z-buffer issue with opengl 3.3 context on intel

2014-01-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74010 --- Comment #2 from Evgeny Bobkin --- another issue is that if glGenVertexArrays (1, &vao_id); glBindVertexArray (vao_id); from lines 46-47 are not used and the is drawn with glEnableVertexAttribArray (position_id); glBindBuff

[Mesa-dev] [Bug 74010] mesa-10.0.2: z-buffer issue with opengl 3.3 context on intel

2014-01-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74010 --- Comment #1 from Evgeny Bobkin --- Created attachment 92718 --> https://bugs.freedesktop.org/attachment.cgi?id=92718&action=edit video demonstrating the issue -- You are receiving this mail because: You are the assignee for the bug. __

[Mesa-dev] [Bug 74010] mesa-10.0.2: z-buffer issue with opengl 3.3 context on intel

2014-01-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74010 Evgeny Bobkin changed: What|Removed |Added Hardware|Other |x86-64 (AMD64) OS|All

[Mesa-dev] [Bug 74010] New: mesa-10.0.2: z-buffer issue with opengl 3.3 context on intel

2014-01-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=74010 Priority: medium Bug ID: 74010 Assignee: mesa-dev@lists.freedesktop.org Summary: mesa-10.0.2: z-buffer issue with opengl 3.3 context on intel Severity: normal Classificat

[Mesa-dev] [PATCH v2 2/2] R600/SI: Add intrinsic for BUFFER_LOAD_DWORD* instructions

2014-01-24 Thread Michel Dänzer
From: Michel Dänzer Signed-off-by: Michel Dänzer --- v2: I've confirmed in the meantime that the instruction offset is ignored when the offen bit is enabled. lib/Target/R600/SIInstrInfo.td | 60 ++--- lib/Target/R600/SIInstructions.td | 48 ++