[Mesa-dev] [Bug 69101] prime: black window

2014-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69101 --- Comment #5 from jack --- > And without DRI_PRIME=1 everything works everywhere, with or without > compositing, windowed or fullscreen. I would imagine this is because you're not offloading anything at that point and running it on the IGP. >

[Mesa-dev] [Bug 73136] [BISECTED] commit "mesa: Dynamically allocate the storage for program local parameters." crashes Awesomenauts

2014-01-03 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=73136 Alexandre Demers changed: What|Removed |Added CC||e...@anholt.net -- You are receiving

Re: [Mesa-dev] [PATCH] i965: set size of txf_mcs payload vgrf properly

2014-01-03 Thread Kenneth Graunke
On 01/03/2014 06:44 PM, Chris Forbes wrote: > Previously we left the size of this vgrf as 1, which caused register > allocation to be subtly broken. If we were lucky we would explode in > the post-alloc instruction scheduler; if we were unlucky we'd just stomp > on someone else and get broken rende

[Mesa-dev] [PATCH] i965: set size of txf_mcs payload vgrf properly

2014-01-03 Thread Chris Forbes
Previously we left the size of this vgrf as 1, which caused register allocation to be subtly broken. If we were lucky we would explode in the post-alloc instruction scheduler; if we were unlucky we'd just stomp on someone else and get broken rendering. Fixes crash when running `tesseract` with the

[Mesa-dev] [PATCH 2/3] i915: Ensure that intel_bufferobj_map_range meets alignment guarantees

2014-01-03 Thread Ian Romanick
From: Ian Romanick Not actually tested, but the changes are identical to the i965 changes that are tested. Signed-off-by: Ian Romanick Cc: Eric Anholt Cc: Siavash Eliasi --- src/mesa/drivers/dri/i915/intel_buffer_objects.c | 28 ++-- 1 file changed, 21 insertions(+), 7 de

[Mesa-dev] [PATCH 1/3] i965: Ensure that intel_bufferobj_map_range meets alignment guarantees

2014-01-03 Thread Ian Romanick
From: Ian Romanick No piglit regressions on IVB. With minor tweaks to the arb_map_buffer_alignment-map-invalidate-range test (disable the extension check, set alignment to 64 instead of querying), the i965 driver would fail the test without this patch (as predicted by Eric). With this patch, it

[Mesa-dev] [PATCH 3/3] i915: Silence warning: unused parameter warning in intel_bufferobj_buffer

2014-01-03 Thread Ian Romanick
From: Ian Romanick intel_buffer_objects.c: In function 'old_intel_bufferobj_buffer': intel_buffer_objects.c:471:17: warning: unused parameter 'flag' [-Wunused-parameter] The parameter hasn't been used since the i915 and i965 drivers had their breakup. i965 got the flags, and i915 got to cry it

[Mesa-dev] [PATCH 3/5] Add more NULL checks

2014-01-03 Thread Bruno Jiménez
In this case, NULL checks are added to compute_memory_grow_pool, so it returns -1 when it fails. This makes necesary to handle such cases in compute_memory_finalize_pending when it is needed to grow the pool --- src/gallium/drivers/r600/compute_memory_pool.c | 30 -- src/ga

[Mesa-dev] Cleaning compute_memory_pool from gallium/drivers/r600

2014-01-03 Thread Bruno Jiménez
Hi, I have cleaned a bit compute_memory_pool.c, added some NULL checks to the code, corrected a typo and removed an unneeded decraration of a function. Sorry if I got something wrong, this is the first time I contribute to a project. Thanks in advance! [PATCH 1/5] Fixing a typo and some ind

[Mesa-dev] [PATCH 4/5] Tidy a bit compute_memory_finalize_pending

2014-01-03 Thread Bruno Jiménez
--- src/gallium/drivers/r600/compute_memory_pool.c | 18 +++--- 1 file changed, 7 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium/drivers/r600/compute_memory_pool.c index 5374a48..954c890 100644 --- a/src/gallium/drivers/r600/c

[Mesa-dev] [PATCH 5/5] Remove compute_memory_defrag declaration

2014-01-03 Thread Bruno Jiménez
It seems to be unimplemented. I think that this function would have been the one that solves the problem with fragmentation that compute_memory_finalize_pending has. --- src/gallium/drivers/r600/compute_memory_pool.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/r600/comp

[Mesa-dev] [PATCH 1/5] Fixing a typo and some indentation

2014-01-03 Thread Bruno Jiménez
--- src/gallium/drivers/r600/compute_memory_pool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium/drivers/r600/compute_memory_pool.c index fd3a04c..7a7b057 100644 --- a/src/gallium/drivers/r600/compute_memory_po

[Mesa-dev] [PATCH 2/5] Adding checks for NULL after CALLOC

2014-01-03 Thread Bruno Jiménez
--- src/gallium/drivers/r600/compute_memory_pool.c | 8 1 file changed, 8 insertions(+) diff --git a/src/gallium/drivers/r600/compute_memory_pool.c b/src/gallium/drivers/r600/compute_memory_pool.c index 7a7b057..62d1a5c 100644 --- a/src/gallium/drivers/r600/compute_memory_pool.c +++ b/s

[Mesa-dev] [PATCH] docs: gratuitous spelling pass

2014-01-03 Thread Nathan Kidd
From: Nathan Kidd Fixed what I noticed; no warranty for exhaustiveness. Signed-off-by: Nathan Kidd --- docs/conform.html|2 +- docs/devinfo.html|2 +- docs/dispatch.html | 10 +- docs/egl.html|8 docs/envvars.html|6 +++--- docs/faq.html

Re: [Mesa-dev] [Mesa-stable] [PATCH 7/7] i965: Fix handling of MESA_pack_invert in blit (PBO) readpixels.

2014-01-03 Thread Anuj Phogat
On Mon, Dec 23, 2013 at 4:08 PM, Eric Anholt wrote: > Fixes piglit GL_MESA_pack_invert/readpixels and GPU hangs with glamor and > cairo-gl. > > Cc: 10.0 9.2 > --- > src/mesa/drivers/dri/i965/intel_pixel_read.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/d

Re: [Mesa-dev] [PATCH 15/18] gallium: Add __DRIimageDriverExtension support to gallium

2014-01-03 Thread Marek Olšák
On Fri, Dec 27, 2013 at 9:27 PM, Keith Packard wrote: > Marek Olšák writes: > >> Some of the code seems to be copy-pasted from >> dri2_drawable_process_buffers. The MSAA color and depth-stencil >> texture allocation could be moved to a common function. > > It's either that or plan on moving DRI2

Re: [Mesa-dev] [PATCH 25/25] i965/gen7: Expose ARB_shader_image_load_store.

2014-01-03 Thread Paul Berry
On 2 December 2013 11:42, Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/intel_extensions.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > What's the status of piglit testing for this feature? The implementation is complex enough (especially the brw_surface_visitor clas

Re: [Mesa-dev] [PATCH 22/25] i965/gen6+: Factor out PIPE_CONTROL submission from intel_batchbuffer_emit_mi_flush.

2014-01-03 Thread Paul Berry
On 2 December 2013 11:42, Francisco Jerez wrote: > --- > src/mesa/drivers/dri/i965/intel_batchbuffer.c | 54 > --- > src/mesa/drivers/dri/i965/intel_batchbuffer.h | 2 + > 2 files changed, 34 insertions(+), 22 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel

Re: [Mesa-dev] [PATCH 18/25] i965: Import surface lowering code.

2014-01-03 Thread Paul Berry
On 2 December 2013 11:39, Francisco Jerez wrote: > diff --git a/src/mesa/drivers/dri/i965/brw_vec4_surface_visitor.cpp > b/src/mesa/drivers/dri/i965/brw_vec4_surface_visitor.cpp > new file mode 100644 > index 000..3528bbe > --- /dev/null > +++ b/src/mesa/drivers/dri/i965/brw_vec4_surface_visi

Re: [Mesa-dev] [PATCH 2/7] i965: Don't call the blitter on addresses it can't handle.

2014-01-03 Thread Anuj Phogat
On Mon, Dec 23, 2013 at 4:08 PM, Eric Anholt wrote: > Noticed by tex3d-maxsize on my next commit to check that our addresses > don't overflow. > --- > src/mesa/drivers/dri/i965/intel_blit.c| 20 > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 23

Re: [Mesa-dev] [PATCH V3 02/13] glapi: add plumbing for GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect

2014-01-03 Thread Kenneth Graunke
On 01/03/2014 09:50 AM, Mark Mueller wrote: > As a precautionary note, one using auto tools may want to remove > auto-generated source files with git clean -dxf when switching to or > from an old branch with this change to make sure the auto-generated > source files are regenerated. None of the exi

Re: [Mesa-dev] [PATCH V3 02/13] glapi: add plumbing for GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect

2014-01-03 Thread Mark Mueller
As a precautionary note, one using auto tools may want to remove auto-generated source files with git clean -dxf when switching to or from an old branch with this change to make sure the auto-generated source files are regenerated. None of the existing make clean targets remove the autogenerated so

Re: [Mesa-dev] [PATCH 2/4] radeon: Add bo statistics dumping support

2014-01-03 Thread Lauri Kasanen
On Fri, 3 Jan 2014 17:37:15 +0100 Erik Faye-Lund wrote: > On Fri, Jan 3, 2014 at 4:49 PM, Lauri Kasanen wrote: > > + fprintf(rscreen->ws->bo_stats_file, "Started at > > %llu\n", > > + stats_time_get(ws)); > > Another nit: the other stats seem

Re: [Mesa-dev] [PATCH 5/7] mesa: add support for AMD_blend_minmax_factor

2014-01-03 Thread Roland Scheidegger
Am 03.01.2014 16:22, schrieb Roland Scheidegger: > Am 03.01.2014 02:18, schrieb Maxence Le Doré: >> --- >> src/mesa/main/blend.c | 3 +++ >> src/mesa/main/extensions.c | 1 + >> src/mesa/main/mtypes.h | 1 + >> 3 files changed, 5 insertions(+) >> >> diff --git a/src/mesa/main/blend.c b/sr

Re: [Mesa-dev] [PATCH 5/7] mesa: add support for AMD_blend_minmax_factor

2014-01-03 Thread Roland Scheidegger
Am 03.01.2014 16:51, schrieb Maxence Le Doré: > - You're right ! I've just checked spec and initial draft is from > march 2010. 2009 is a mistake. Thanks. > - You're the third one to request piglit tests. I'll have to do it. Or > I could not complain if some devs become angry against me for sending

Re: [Mesa-dev] [PATCH 2/4] radeon: Add bo statistics dumping support

2014-01-03 Thread Erik Faye-Lund
On Fri, Jan 3, 2014 at 4:49 PM, Lauri Kasanen wrote: > No measurable overhead when off (glxgears within 0.5%). > > Signed-off-by: Lauri Kasanen > --- > src/gallium/drivers/radeon/r600_pipe_common.c | 32 > +++ > src/gallium/drivers/radeon/r600_pipe_common.h | 1 + > src

Re: [Mesa-dev] [PATCH 5/7] mesa: add support for AMD_blend_minmax_factor

2014-01-03 Thread Maxence Le Doré
- You're right ! I've just checked spec and initial draft is from march 2010. 2009 is a mistake. Thanks. - You're the third one to request piglit tests. I'll have to do it. Or I could not complain if some devs become angry against me for sending patches and never with at least a pinch of according

[Mesa-dev] [PATCH 4/4] radeon: Determine the bo priority (MSAA, depth, UVD are high)

2014-01-03 Thread Lauri Kasanen
Signed-off-by: Lauri Kasanen --- src/gallium/drivers/radeon/r600_buffer_common.c | 8 src/gallium/drivers/radeon/radeon_uvd.c | 4 ++-- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 4 src/gallium/winsys/radeon/drm/radeon_drm_bo.h | 1 + src/gallium/winsys/radeon/drm/r

[Mesa-dev] [PATCH 3/4] winsys/radeon: Keep bo statistics

2014-01-03 Thread Lauri Kasanen
These will be used later on for optimizing the VRAM placement. No measurable overhead (glxgears). Signed-off-by: Lauri Kasanen --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 3 +++ src/gallium/winsys/radeon/drm/radeon_drm_bo.h | 16 src/gallium/winsys/radeon/drm/radeon_dr

[Mesa-dev] [PATCH 2/4] radeon: Add bo statistics dumping support

2014-01-03 Thread Lauri Kasanen
No measurable overhead when off (glxgears within 0.5%). Signed-off-by: Lauri Kasanen --- src/gallium/drivers/radeon/r600_pipe_common.c | 32 +++ src/gallium/drivers/radeon/r600_pipe_common.h | 1 + src/gallium/winsys/radeon/drm/radeon_drm_bo.c | 17 ++ src/ga

[Mesa-dev] [PATCH 1/4] winsys/radeon: Add a millisecond time function

2014-01-03 Thread Lauri Kasanen
v2: Move to a timing thread to minimize overhead. Signed-off-by: Lauri Kasanen --- src/gallium/winsys/radeon/drm/radeon_drm_winsys.c | 25 +++ src/gallium/winsys/radeon/drm/radeon_drm_winsys.h | 12 +++ 2 files changed, 37 insertions(+) diff --git a/src/gallium/winsy

Re: [Mesa-dev] [PATCH 5/7] mesa: add support for AMD_blend_minmax_factor

2014-01-03 Thread Roland Scheidegger
Am 03.01.2014 02:18, schrieb Maxence Le Doré: > --- > src/mesa/main/blend.c | 3 +++ > src/mesa/main/extensions.c | 1 + > src/mesa/main/mtypes.h | 1 + > 3 files changed, 5 insertions(+) > > diff --git a/src/mesa/main/blend.c b/src/mesa/main/blend.c > index 9e11ca7..4995143 100644 > ---

Re: [Mesa-dev] [PATCH 1/7] mesa: implement glBindBuffersBase() and gl BindBuffersRange()

2014-01-03 Thread servuswiegehtz
when you create the patches with git, you can add --cover-letter to the command line. then you get a PATCH 0/X file with an overview over all changes and a central place where you can describe what you've done in general/which extension etc. On 03.01.2014 01:27, Maxence Le Doré wrote: > --- > src

Re: [Mesa-dev] [PATCH 2/4] st/dri: prevent leak of dri option default values

2014-01-03 Thread Marek Olšák
Please don't use the "//" comments in C files. Other than that, the series is: Reviewed-by: Marek Olšák Marek On Thu, Jan 2, 2014 at 7:38 PM, Aaron Watry wrote: > CC: "10.0" > --- > src/gallium/state_trackers/dri/common/dri_screen.c | 4 > 1 file changed, 4 insertions(+) > > diff --git

Re: [Mesa-dev] [PATCH 6/7] mesa: enable ARB_blend_minmax_factor

2014-01-03 Thread Marek Olšák
I'd like to see a piglit test for this extension. Every driver where the extension is enabled should be tested to make sure the extension works as expected. Marek On Fri, Jan 3, 2014 at 2:18 AM, Maxence Le Doré wrote: > ... where it can be. > --- > src/mesa/drivers/dri/i915/intel_extensions.c |

Re: [Mesa-dev] [PATCH 3/7] mesa: implement glBindTextures()

2014-01-03 Thread Marek Olšák
On Fri, Jan 3, 2014 at 2:04 PM, Marek Olšák wrote: > On Fri, Jan 3, 2014 at 1:27 AM, Maxence Le Doré > wrote: >> --- >> src/mesa/main/texobj.c | 52 >> ++ >> src/mesa/main/texobj.h | 3 +++ >> 2 files changed, 55 insertions(+) >> >> diff --git a/

Re: [Mesa-dev] [PATCH 3/7] mesa: implement glBindTextures()

2014-01-03 Thread Marek Olšák
On Fri, Jan 3, 2014 at 1:27 AM, Maxence Le Doré wrote: > --- > src/mesa/main/texobj.c | 52 > ++ > src/mesa/main/texobj.h | 3 +++ > 2 files changed, 55 insertions(+) > > diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c > index bddbc50

[Mesa-dev] [PATCH 0/2] More null checks into glx

2014-01-03 Thread Juha-Pekka Heikkila
Still Klocwork related patches. Juha-Pekka Heikkila (2): glx: Add missing null check in __glXNewIndirectAPI() glx: check memory allocations in __glXInitVertexArrayState() src/glx/indirect_vertex_array.c | 27 +++ src/mapi/glapi/gen/glX_proto_send.py | 2 ++ 2 fi

[Mesa-dev] [PATCH 2/2] glx: check memory allocations in __glXInitVertexArrayState()

2014-01-03 Thread Juha-Pekka Heikkila
Signed-off-by: Juha-Pekka Heikkila --- src/glx/indirect_vertex_array.c | 27 +++ 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/src/glx/indirect_vertex_array.c b/src/glx/indirect_vertex_array.c index 1d26c5e..0025cbb 100644 --- a/src/glx/indirect_vertex_arr

[Mesa-dev] [PATCH 1/2] glx: Add missing null check in __glXNewIndirectAPI()

2014-01-03 Thread Juha-Pekka Heikkila
Add extra null check in auto generated indirect_init.c via src/mapi/glapi/gen/glX_proto_send.py Signed-off-by: Juha-Pekka Heikkila --- src/mapi/glapi/gen/glX_proto_send.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mapi/glapi/gen/glX_proto_send.py b/src/mapi/glapi/gen/glX_proto_s

Re: [Mesa-dev] [PATCH 4/4] radeon: Determine the bo priority (MSAA, depth, UVD are high)

2014-01-03 Thread Lauri Kasanen
On Fri, 03 Jan 2014 01:37:22 +0100 Andreas Hartmetz wrote: > > This boolean is just one component to be used in the final score (for > > the plan, see github.com/clbr/jamkthesis). It passes down information > > that's otherwise unavailable, ie whether the buffer's type means it > > should be more

Re: [Mesa-dev] [PATCH 2/4] radeon: Add bo statistics dumping support

2014-01-03 Thread Lauri Kasanen
On Fri, 3 Jan 2014 03:54:01 +0100 Erik Faye-Lund wrote: > On Wed, Jan 1, 2014 at 3:57 PM, Lauri Kasanen wrote: > > + fprintf(rscreen->ws->bo_stats_file, "Started at > > %llu\n", > > + (unsigned long long) os_time_get_nano() / > > 100); >