Re: [Mesa-dev] [Mesa-stable] [PATCH v3] egl: add HAVE_LIBDRM define, fix EGL X11 platform

2013-12-05 Thread Tapani
On 12/05/2013 07:22 PM, Ian Romanick wrote: On 12/01/2013 01:53 AM, Tapani Pälli wrote: Commit a594cec broke EGL X11 backend by adding dependency between X11 and DRM backends requiring HAVE_EGL_PLATFORM_DRM defined for X11. This patch fixes the issue by adding additional define for libdrm detec

[Mesa-dev] [v2 1/2] glsl: introduce data section to ir_variable

2013-12-05 Thread Tapani Pälli
Data section helps serialization and cloning of a ir_variable. This patch includes the helper bits used for read only ir_variables. Signed-off-by: Tapani Pälli Reviewed-by: Paul Berry --- src/glsl/ast_function.cpp | 2 +- src/glsl/ast_to_hir.cpp | 26 +

[Mesa-dev] [0/2] fixes to ir_variable data container set

2013-12-05 Thread Tapani Pälli
Hello; I'm sending here v2 of the patches that still produced compilation errors on 'ir_variable data container' set I sent earlier: http://lists.freedesktop.org/archives/mesa-dev/2013-December/049652.html I've rebased my branch and checked each patch with make and make check, this time also wi

Re: [Mesa-dev] [PATCH 00/11] Core mesa changes for ARB_shader_image_load_store.

2013-12-05 Thread Paul Berry
On 24 November 2013 21:00, Francisco Jerez wrote: > This is the first of three patch series enabling basic support for > ARB_shader_image_load_store on Intel Gen7 (and Gen7.5) hardware. Most > of the necessary core mesa changes are part of this batch (except the > one patch that depends on GLSL

Re: [Mesa-dev] [PATCH 4/5] radeonsi: fix binding the dummy pixel shader

2013-12-05 Thread Michel Dänzer
On Don, 2013-12-05 at 18:43 +0100, Marek Olšák wrote: > From: Marek Olšák > > This fixes valgrind errors in glxinfo. [...] > diff --git a/src/gallium/drivers/radeonsi/si_state.c > b/src/gallium/drivers/radeonsi/si_state.c > index 9831fd8..b644d56 100644 > --- a/src/gallium/drivers/radeonsi/si_

[Mesa-dev] [PATCH] nvc0: make sure nvd7 gets NVC8_3D_CLASS

2013-12-05 Thread Ilia Mirkin
Signed-off-by: Ilia Mirkin --- It has the NVC8 class, at least according to the kernel driver's setup code. src/gallium/drivers/nouveau/nvc0/nvc0_screen.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_screen.c b/src/gallium/drivers/

Re: [Mesa-dev] [PATCH 7/9] mesa: Fill out ARB_texture_view entry points

2013-12-05 Thread Brian Paul
In _mesa_test_texobj_completeness() we check if BaseLevel is negative. If so, we mark the texture object as 'incomplete'. Down in the drivers, we should never sample from a texture that's incomplete. In gallium, for example, we use a dummy/fallback texture instead. -Brian On 12/05/2013 10

Re: [Mesa-dev] [PATCH] glsl: Don't emit empty declaration warning for a struct specifier

2013-12-05 Thread Kenneth Graunke
On 11/27/2013 12:50 PM, Ian Romanick wrote: > From: Ian Romanick > > The intention is that things like > >int; > > will generate a warning. However, we were also accidentally emitting > the same warning for things like > > struct Foo { int x; }; > > Signed-off-by: Ian Romanick > Bugzi

Re: [Mesa-dev] [PATCH 5/6] st/mesa: set correct PIPE_CLEAR_COLORn flags

2013-12-05 Thread Marek Olšák
We'll probably use clear_render_target for GL_ARB_clear_texture (GL 4.4), so it will be useful finally. Marek On Thu, Dec 5, 2013 at 10:49 PM, Roland Scheidegger wrote: > Am 05.12.2013 18:53, schrieb Marek Olšák: >> From: Marek Olšák >> >> This also fixes the clear_with_quad function for glClea

Re: [Mesa-dev] [PATCH 4/4] glsl: In loop analysis, handle unconditional second assignment.

2013-12-05 Thread Jordan Justen
Series Reviewed-by: Jordan Justen On Thu, Nov 28, 2013 at 11:41 AM, Paul Berry wrote: > Previously, loop analysis would set > this->conditional_or_nested_assignment based on the most recently > visited assignment to the variable. As a result, if a vaiable was > assigned to more than once in a l

Re: [Mesa-dev] [PATCH 5/6] st/mesa: set correct PIPE_CLEAR_COLORn flags

2013-12-05 Thread Roland Scheidegger
Am 05.12.2013 18:53, schrieb Marek Olšák: > From: Marek Olšák > > This also fixes the clear_with_quad function for glClearBuffer. > --- > src/mesa/state_tracker/st_cb_clear.c | 37 > +--- > 1 file changed, 26 insertions(+), 11 deletions(-) > > diff --git a/src/m

Re: [Mesa-dev] [PATCH 4/6] gallium: allow choosing which colorbuffers to clear

2013-12-05 Thread Roland Scheidegger
Am 05.12.2013 22:42, schrieb Roland Scheidegger: > Am 05.12.2013 18:53, schrieb Marek Olšák: >> From: Marek Olšák >> >> Required for glClearBuffer, which only clears one colorbuffer attachment. >> >> Example: >>If the first colorbuffer is float and the second one is int: >> pipe->clear(p

Re: [Mesa-dev] [PATCH 4/6] gallium: allow choosing which colorbuffers to clear

2013-12-05 Thread Roland Scheidegger
Am 05.12.2013 18:53, schrieb Marek Olšák: > From: Marek Olšák > > Required for glClearBuffer, which only clears one colorbuffer attachment. > > Example: >If the first colorbuffer is float and the second one is int: > pipe->clear(pipe, PIPE_CLEAR_COLOR0, float_clear_color, ...); >

Re: [Mesa-dev] [PATCH 2/5] glsl: move variables in to ir_variable::data, part I

2013-12-05 Thread Paul Berry
On 4 December 2013 04:16, Tapani Pälli wrote: > This patch moves following bitfields in to the data structure: > > used, assigned, how_declared, mode, interpolation, > origin_upper_left, pixel_center_integer > > Signed-off-by: Tapani Pälli > --- > src/glsl/ast_array_index.cpp

Re: [Mesa-dev] [PATCH 1/5] glsl: introduce data section to ir_variable

2013-12-05 Thread Paul Berry
On 4 December 2013 04:16, Tapani Pälli wrote: > Data section helps serialization and cloning of a ir_variable. This > patch includes the helper bits used for read only ir_variables. > > Signed-off-by: Tapani Pälli > I tried to build this patch (using commit 4d6cdb8 from your published tree), an

Re: [Mesa-dev] Nesa-dev now integrated with patchwork

2013-12-05 Thread Carl Worth
Carl Worth writes: > So, you should all expect to see these hook messages now: > >> remote: I: patch # updated using rev . > ... >> remote: E: failed to find patch for rev . For anyone who has pushed patches for the past couple of days, you likely only saw the "failed to find patch" mes

Re: [Mesa-dev] [PATCH] glsl: Remove unreachable error message

2013-12-05 Thread Ian Romanick
On 12/04/2013 10:32 PM, Timothy Arceri wrote: > On Wed, 2013-12-04 at 14:32 -0800, Ian Romanick wrote: >> On 11/20/2013 03:41 AM, Timothy Arceri wrote: >>> Left over from bug #34376. >> >> I think this shader hits this error message: >> >> #version 120 >> >> int x[]; >> >> void foo() {

Re: [Mesa-dev] [PATCH] glx: Use struct xshmfence* instead of int32_t*.

2013-12-05 Thread Ian Romanick
On 12/05/2013 10:14 AM, Matt Turner wrote: > On Thu, Dec 5, 2013 at 2:23 AM, Chí-Thanh Christopher Nguyễn > wrote: >> You possibly need to require xshmfence >= 1.1 for this. > > It'll work with 1.0 (the libxshmfence change is not an ABI change), it > will just cause compiler warnings. I'm okay wi

Re: [Mesa-dev] [RFC PATCH 02/10] glsl/loops: replace loop controls with a normative bound.

2013-12-05 Thread Jordan Justen
1 & 2 Reviewed-by: Jordan Justen On Sat, Nov 30, 2013 at 8:38 AM, Paul Berry wrote: > This patch replaces the ir_loop fields "from", "to", "increment", > "counter", and "cmp" with a single integer ("normative_bound") that > serves the same purpose. > > I've used the name "normative_bound" to emp

Re: [Mesa-dev] [PATCH] i965/blorp: Improve fast color clear comment.

2013-12-05 Thread Kenneth Graunke
On 12/05/2013 04:47 AM, Paul Berry wrote: > Clarify the fact that we only optimize full buffer clears using fast > color clear, and why. > --- > src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 13 - > 1 file changed, 12 insertions(+), 1 deletion(-) > > diff --git a/src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH 7/7] i965/gen7+: Implement fast color clears for MSAA buffers.

2013-12-05 Thread Anuj Phogat
On Thu, Dec 5, 2013 at 4:36 AM, Paul Berry wrote: > On 4 December 2013 15:07, Chad Versace wrote: >> >> >> bugget, verticeally, and vestically! oh my! > > > Wow, I wish I could say I did all those typos on purpose. Those are > hilarious! > > They're all fixed now. > >> >> >> Patches 1-6 are >> R

Re: [Mesa-dev] [PATCH] glx: Use struct xshmfence* instead of int32_t*.

2013-12-05 Thread Matt Turner
On Thu, Dec 5, 2013 at 2:23 AM, Chí-Thanh Christopher Nguyễn wrote: > You possibly need to require xshmfence >= 1.1 for this. It'll work with 1.0 (the libxshmfence change is not an ABI change), it will just cause compiler warnings. I'm okay with that. _

[Mesa-dev] [PATCH 4/6] gallium: allow choosing which colorbuffers to clear

2013-12-05 Thread Marek Olšák
From: Marek Olšák Required for glClearBuffer, which only clears one colorbuffer attachment. Example: If the first colorbuffer is float and the second one is int: pipe->clear(pipe, PIPE_CLEAR_COLOR0, float_clear_color, ...); pipe->clear(pipe, PIPE_CLEAR_COLOR1, int_clear_color, ...

[Mesa-dev] [PATCH 6/6] gallium/util: implement new color clear API in u_blitter

2013-12-05 Thread Marek Olšák
From: Marek Olšák --- src/gallium/auxiliary/util/u_blitter.c | 45 +++--- 1 file changed, 42 insertions(+), 3 deletions(-) diff --git a/src/gallium/auxiliary/util/u_blitter.c b/src/gallium/auxiliary/util/u_blitter.c index bb1920a..710a728 100644 --- a/src/gallium/au

[Mesa-dev] [PATCH 3/6] st/mesa: fix glClear with multiple colorbuffers and different formats

2013-12-05 Thread Marek Olšák
From: Marek Olšák Cc: 10.0 9.2 9.1 --- src/mesa/state_tracker/st_cb_clear.c | 33 + 1 file changed, 9 insertions(+), 24 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_clear.c b/src/mesa/state_tracker/st_cb_clear.c index 274cc47..5a7a00c 100644 --- a/src

[Mesa-dev] [PATCH 1/6] docs/GL3: better documentation of GL 3.0

2013-12-05 Thread Marek Olšák
From: Marek Olšák --- docs/GL3.txt | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 059ae98..f98a54a 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -30,14 +30,15 @@ GL 3.0 --- all DONE: i965, nv50, nvc0, r600, radeonsi GL_EXT_

[Mesa-dev] [PATCH 5/6] st/mesa: set correct PIPE_CLEAR_COLORn flags

2013-12-05 Thread Marek Olšák
From: Marek Olšák This also fixes the clear_with_quad function for glClearBuffer. --- src/mesa/state_tracker/st_cb_clear.c | 37 +--- 1 file changed, 26 insertions(+), 11 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_clear.c b/src/mesa/state_tracker/st_

[Mesa-dev] [PATCH 2/6] mesa: fix interpretation of glClearBuffer(drawbuffer)

2013-12-05 Thread Marek Olšák
From: Marek Olšák This corresponding piglit tests supported this incorrect behavior instead of pointing at it. See the GL 4.4 spec if the GL 3.0 spec is not clear enough. Cc: 10.0 9.2 9.1 --- src/mesa/main/clear.c | 17 +++-- 1 file changed, 11 insertions(+), 6 deletions(-) diff

[Mesa-dev] [PATCH 5/5] r600g, radeonsi: fix initialized buffer range tracking for DMA, add comments

2013-12-05 Thread Marek Olšák
From: Marek Olšák The DMA functions modify dst_offset and size and util_range_add gets wrong values. --- src/gallium/drivers/r600/evergreen_hw_context.c | 18 -- src/gallium/drivers/r600/r600_hw_context.c | 18 -- src/gallium/drivers/radeonsi/si_descriptors.c

[Mesa-dev] [PATCH 2/5] radeonsi: use the colorbuffer count from the shader key

2013-12-05 Thread Marek Olšák
From: Marek Olšák As a result, the initialization of write_all must be done before the compilation. --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 6 ++ src/gallium/drivers/radeonsi/radeonsi_shader.h | 1 - src/gallium/drivers/radeonsi/si_state.c| 16 +--- 3 files

[Mesa-dev] [PATCH 1/5] radeonsi: remove unused variable in si_pipe_shader_ps

2013-12-05 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/si_state_draw.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c b/src/gallium/drivers/radeonsi/si_state_draw.c index be5a5c8..f0716f3 100644 --- a/src/gallium/drivers/rade

[Mesa-dev] [PATCH 3/5] radeonsi: fix FS_COLOR0_WRITES_ALL_CBUFS with mixed colorbuffer formats

2013-12-05 Thread Marek Olšák
From: Marek Olšák The 16bpc packing must be done separately for each render target. --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 40 ++ 1 file changed, 15 insertions(+), 25 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/dr

[Mesa-dev] [PATCH 4/5] radeonsi: fix binding the dummy pixel shader

2013-12-05 Thread Marek Olšák
From: Marek Olšák This fixes valgrind errors in glxinfo. --- src/gallium/drivers/radeonsi/radeonsi_pipe.h | 2 +- src/gallium/drivers/radeonsi/si_state.c | 23 +-- src/gallium/drivers/radeonsi/si_state_draw.c | 10 +- 3 files changed, 11 insertions(+), 24 deleti

Re: [Mesa-dev] [Mesa-stable] [PATCH v3] egl: add HAVE_LIBDRM define, fix EGL X11 platform

2013-12-05 Thread Ian Romanick
On 12/01/2013 01:53 AM, Tapani Pälli wrote: > Commit a594cec broke EGL X11 backend by adding dependency between > X11 and DRM backends requiring HAVE_EGL_PLATFORM_DRM defined for X11. > > This patch fixes the issue by adding additional define for libdrm > detection independent of which backend is

Re: [Mesa-dev] [PATCH 4/4] radeonsi: Write htile state to SI hardware.

2013-12-05 Thread Marek Olšák
On Tue, Dec 3, 2013 at 9:33 PM, Andreas Hartmetz wrote: > --- > src/gallium/drivers/radeonsi/si_state.c | 28 +++- > 1 file changed, 27 insertions(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeonsi/si_state.c > b/src/gallium/drivers/radeonsi/si_state.c > inde

Re: [Mesa-dev] [PATCH 7/9] mesa: Fill out ARB_texture_view entry points

2013-12-05 Thread Courtney Goeltzenleuchter
Browsing the code a little, it's not clear that drivers are using the texture object's BaseLevel in a "safe" manner. Some example uses of BaseLevel: [intel driver] const struct gl_texture_image *img = t->Image[0][t->BaseLevel]; // Without conditioning, this could lead to memory access error. Ma

Re: [Mesa-dev] [PATCH 7/9] mesa: Fill out ARB_texture_view entry points

2013-12-05 Thread Courtney Goeltzenleuchter
Okay, that makes it easier. Should this change be conditional based on the type of context created? Courtney On Thu, Dec 5, 2013 at 8:52 AM, Brian Paul wrote: > On 12/04/2013 03:46 PM, Courtney Goeltzenleuchter wrote: > >> It's come to my attention that Mesa's handling of GL_TEXTURE_BASE_LEVE

[Mesa-dev] [Bug 70250] weston-terminal rendering corrupted with output transform 90 and 270

2013-12-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70250 U. Artie Eoff changed: What|Removed |Added Status|RESOLVED|VERIFIED QA Contact|

Re: [Mesa-dev] [PATCH] i965/blorp: Improve fast color clear comment.

2013-12-05 Thread Chad Versace
On 12/05/2013 04:47 AM, Paul Berry wrote: Clarify the fact that we only optimize full buffer clears using fast color clear, and why. --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw

Re: [Mesa-dev] [PATCH 7/7] i965/gen7+: Implement fast color clears for MSAA buffers.

2013-12-05 Thread Chad Versace
On 12/05/2013 04:36 AM, Paul Berry wrote: On 4 December 2013 15:07, Chad Versace mailto:chad.vers...@linux.intel.com>> wrote: bugget, verticeally, and vestically! oh my! Wow, I wish I could say I did all those typos on purpose. Those are hilarious! They're all fixed now. Patches 1

Re: [Mesa-dev] [PATCH 7/9] mesa: Fill out ARB_texture_view entry points

2013-12-05 Thread Brian Paul
On 12/04/2013 03:46 PM, Courtney Goeltzenleuchter wrote: It's come to my attention that Mesa's handling of GL_TEXTURE_BASE_LEVEL and GL_TEXTURE_MAX_LEVEL in glTexParameter and glGetTexParameter may be incorrect. The issue happens with the following sequence: glTexStorage2D(GL_TEXTURE_2D, 4, GL_R

Re: [Mesa-dev] [PATCH] swrast: fix readback regression since inversion fix

2013-12-05 Thread Brian Paul
On 12/04/2013 08:30 PM, Dave Airlie wrote: From: Dave Airlie This readback from the frontbuffer with swrast was broken, that bug just made it more obviously broken, this fixes it by inverting the sub image gets. Also fixes a few other piglits. Fixes: https://bugs.freedesktop.org/show_bug.cgi?i

[Mesa-dev] [Bug 72335] Requesting git commit access to mesa

2013-12-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=72335 Brian Paul changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |sitewranglers@lists.freedes

[Mesa-dev] [PATCH] i965/blorp: Improve fast color clear comment.

2013-12-05 Thread Paul Berry
Clarify the fact that we only optimize full buffer clears using fast color clear, and why. --- src/mesa/drivers/dri/i965/brw_blorp_clear.cpp | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_blorp_clear.cpp b/src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH 7/7] i965/gen7+: Implement fast color clears for MSAA buffers.

2013-12-05 Thread Paul Berry
On 4 December 2013 15:07, Chad Versace wrote: > > bugget, verticeally, and vestically! oh my! > Wow, I wish I could say I did all those typos on purpose. Those are hilarious! They're all fixed now. > > Patches 1-6 are > Reviewed-by: Chad Versace > > But this patch 7... If the user specifies

[Mesa-dev] [Bug 71591] Second Life shaders fail to compile (extension declared in middle of shader)

2013-12-05 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=71591 --- Comment #8 from Eero Tamminen --- Kevin has a patch to allow extensions anywhere in shader: http://patchwork.freedesktop.org/patch/16221/ Apparently that's not going in as-is, but you could try it to see whether it allows the programs curr

Re: [Mesa-dev] [PATCH] glx: Use struct xshmfence* instead of int32_t*.

2013-12-05 Thread Chí-Thanh Christopher Nguyễn
Matt Turner schrieb: > --- > src/glx/dri3_glx.c | 4 ++-- > src/glx/dri3_priv.h | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/src/glx/dri3_glx.c b/src/glx/dri3_glx.c > index b047cc8..1834c6d 100644 > --- a/src/glx/dri3_glx.c > +++ b/src/glx/dri3_glx.c > @@ -676,7 +67