Re: [Mesa-dev] [PATCH 3/9] gallium/dri2: Set winsys_handle type to KMS for stride query.

2013-11-24 Thread Thomas Hellstrom
On 11/25/2013 05:06 AM, Christopher James Halse Rogers wrote: On Thu, 2013-11-21 at 14:12 +0100, Thomas Hellstrom wrote: On 11/21/2013 05:11 AM, christopher.halse.rog...@canonical.com wrote: From: Christopher James Halse Rogers Otherwise the default is TYPE_SHARED, which will flink the bo. Th

Re: [Mesa-dev] [PATCH 00/11] Core mesa changes for ARB_shader_image_load_store.

2013-11-24 Thread Chris Forbes
Patches 1-4, 8-11 are: Reviewed-by: Chris Forbes With the bounds checks fixed, patch 5 is also: Reviewed-by: Chris Forbes I haven't had time to read 6-7 carefully enough to convince myself they are correct, but you can consider them Acked-by: Chris Forbes The various other bits of feedback

Re: [Mesa-dev] [PATCH 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-24 Thread Chris Forbes
It would be good to fold the fixes into the patches they belong in. I'd wait until you collect review comments on the whole series, then incorporate all the review you get and send out a new version at that point. -- Chris On Mon, Nov 25, 2013 at 8:29 PM, Siavash Eliasi wrote: > On 11/25/2013 1

Re: [Mesa-dev] [PATCH 10/11] mesa: Validate image units when the texture state changes.

2013-11-24 Thread Chris Forbes
It would be nice not to have to touch this memory when the extension is unused|unsupported, but that might be a problem for another patch... -- Chris On Mon, Nov 25, 2013 at 6:00 PM, Francisco Jerez wrote: > --- > src/mesa/main/shaderimage.c | 11 +++ > src/mesa/main/shaderimage.h | 9

Re: [Mesa-dev] [PATCH 05/11] mesa: Add image parameter queries for ARB_shader_image_load_store.

2013-11-24 Thread Chris Forbes
+ if (index > ctx->Const.MaxImageUnits) + goto invalid_value; Image unit indices are zero-based, so I think you want >= in all these cases. -- Chris On Mon, Nov 25, 2013 at 6:00 PM, Francisco Jerez wrote: > --- > src/mesa/main/get.c | 70 > +++

Re: [Mesa-dev] [PATCH 03/11] mesa: Add state data structures requried for ARB_shader_image_load_store.

2013-11-24 Thread Chris Forbes
In the commit message, s/requried/required/ Does holding onto the whole texture object make things easier? I had assumed you could get by just referencing the right gl_texture_image, but maybe that doesn't work out. On Mon, Nov 25, 2013 at 6:00 PM, Francisco Jerez wrote: > --- > src/mesa/main/c

Re: [Mesa-dev] [PATCH 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-24 Thread Siavash Eliasi
On 11/25/2013 10:50 AM, Chris Forbes wrote: Ah, I see you have a follow-up that fixes this already. Looks good, sorry for the noise. -- Chris I'm pretty new here and I'm not used to mailing lists, sorry if patches aren't showing up in correct place. Should I send all of patches again (and p

Re: [Mesa-dev] [PATCH 02/11] mesa: Add ARB_shader_image_load_store to the extension table.

2013-11-24 Thread Chris Forbes
Does this want to be enabled in compatibility? I had assumed we wouldn't, for the same reasons we don't enable texbo there. On Mon, Nov 25, 2013 at 6:00 PM, Francisco Jerez wrote: > --- > src/mesa/main/extensions.c | 1 + > src/mesa/main/mtypes.h | 1 + > 2 files changed, 2 insertions(+) > >

Re: [Mesa-dev] [PATCH 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-24 Thread Chris Forbes
Ah, I see you have a follow-up that fixes this already. Looks good, sorry for the noise. -- Chris On Mon, Nov 25, 2013 at 8:19 PM, Chris Forbes wrote: > Tim's correct -- in this case you probably want to move the > PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT case up above the big 'this cap is > unsupport

Re: [Mesa-dev] [PATCH 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-24 Thread Chris Forbes
Tim's correct -- in this case you probably want to move the PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT case up above the big 'this cap is unsupported' catch-all. -- Chris On Mon, Nov 25, 2013 at 7:07 PM, Timothy Arceri wrote: > I've only had a very quick scan over your patches but I think you need > to r

Re: [Mesa-dev] [PATCH 14/17] Modified i915 intel_bufferobj_data to use _mesa_align_malloc instead of malloc.

2013-11-24 Thread Chris Forbes
I'm not convinced that just using _mesa_align_malloc() is sufficient here. Issue 2 from the ARB_map_buffer_alignment spec says: 2) What alignment should be used for MapBufferRange when is non-zero? RESOLVED: The pointer returned should be consistent with the base of the buffer b

[Mesa-dev] [PATCH] Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT incorrectly.

2013-11-24 Thread Siavash Eliasi
Thanks to Timothy Arceri for pointing that out! --- src/gallium/drivers/i915/i915_screen.c | 4 ++-- src/gallium/drivers/llvmpipe/lp_screen.c | 4 ++-- src/gallium/drivers/softpipe/sp_screen.c | 1 + src/gallium/drivers/svga/svga_screen.c | 4 ++-- 4 files changed, 7 insertions(+), 6 deletions

Re: [Mesa-dev] [PATCH] i965: Bump number of supported atomic counter buffers.

2013-11-24 Thread Kenneth Graunke
On 11/24/2013 05:39 PM, Francisco Jerez wrote: > Now that we have dynamic binding tables there's no good reason anymore > to expose so few atomic counter buffers. Increase it to 16. > --- > src/mesa/drivers/dri/i965/brw_context.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -

[Mesa-dev] [PATCH] Fixed setting switch cases prior to PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT incorrectly.

2013-11-24 Thread Siavash Eliasi
Thanks to Timothy Arceri for pointing that out! --- src/gallium/drivers/i915/i915_screen.c | 4 ++-- src/gallium/drivers/llvmpipe/lp_screen.c | 4 ++-- src/gallium/drivers/softpipe/sp_screen.c | 1 + src/gallium/drivers/svga/svga_screen.c | 4 ++-- 4 files changed, 7 insertions(+), 6 deletions

Re: [Mesa-dev] [PATCH 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-24 Thread Timothy Arceri
I've only had a very quick scan over your patches but I think you need to redo your patches that edit case statements as you are not just changing the value of the intended case statement but also all of the cases above it as they do not break or return they just fall through for example: --- a/sr

[Mesa-dev] [PATCH 10/17] Modified _mesa_init_constants to set ctx->Const.MinMapBufferAlignment to 64.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/main/context.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 87a4a35..9c516a2 100644 --- a/src/mesa/main/context.c +++ b/src/mesa/main/context.c @@ -586,6 +586,7 @@ _mesa_init_constants(struct gl_context *ctx) ctx->Cons

[Mesa-dev] [PATCH 11/17] Modified _mesa_buffer_data to use _mesa_align_malloc.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/main/bufferobj.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index b27f592..5581a5d 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -416,9 +416,9 @@ _mesa_buffer_data( struct gl

[Mesa-dev] [PATCH 15/17] Modified brw_initialize_context_constants to set ctx->Const.MinMapBufferAlignment to 4096.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/drivers/dri/i965/brw_context.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 6e09077..679ec0e 100644 --- a/src/mesa/drivers/dri/i965/brw_context.c +++ b/src/mesa/drivers/dri/i965/brw_conte

[Mesa-dev] [PATCH 13/17] Modified nouveau_bufferobj_data to pass ctx->Const.MinMapBufferAlignment as the alignment value to nouveau_bo_new.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/drivers/dri/nouveau/nouveau_bufferobj.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/nouveau/nouveau_bufferobj.c b/src/mesa/drivers/dri/nouveau/nouveau_bufferobj.c index 717c0b8..dc16585 100644 --- a/src/mesa/drivers/dri/nouveau/nouveau_b

[Mesa-dev] [PATCH 14/17] Modified i915 intel_bufferobj_data to use _mesa_align_malloc instead of malloc.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/drivers/dri/i915/intel_buffer_objects.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i915/intel_buffer_objects.c b/src/mesa/drivers/dri/i915/intel_buffer_objects.c index bc58c70..4fbf954 100644 --- a/src/mesa/drivers/dri/i915/intel_buff

[Mesa-dev] [PATCH 16/17] Modified extensions table to use o(dummy_true) instead of o(ARB_map_buffer_alignment).

2013-11-24 Thread Siavash Eliasi
--- src/mesa/main/extensions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 104618c..6f73694 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -107,7 +107,7 @@ static const struct extensi

[Mesa-dev] [PATCH 12/17] Modified radeonBufferData to pass ctx->Const.MinMapBufferAlignment as the alignment value to radeon_bo_open.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/drivers/dri/radeon/radeon_buffer_objects.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/radeon/radeon_buffer_objects.c b/src/mesa/drivers/dri/radeon/radeon_buffer_objects.c index 40a16c3..ba7ab37 100644 --- a/src/mesa/drivers/dri/radeon/rad

[Mesa-dev] [PATCH 06/17] Modified i915g to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/i915/i915_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/i915/i915_screen.c b/src/gallium/drivers/i915/i915_screen.c index 77607d0..3bc6ecf 100644 --- a/src/gallium/drivers/i915/i915_screen.c +++ b/src/gallium/drivers/i915/i915_screen.c @@

[Mesa-dev] [PATCH 09/17] Modified Mesa state tracker to unconditionally enable ARB_map_buffer_alignment.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/state_tracker/st_extensions.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index e8d0902..4707447 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/src/mesa/state_trac

[Mesa-dev] [PATCH 17/17] Deleted gl_extensions::ARB_map_buffer_alignment and all of its use cases.

2013-11-24 Thread Siavash Eliasi
--- src/mesa/main/get.c| 1 - src/mesa/main/get_hash_params.py | 2 +- src/mesa/main/mtypes.h | 1 - src/mesa/state_tracker/st_extensions.c | 2 -- 4 files changed, 1 insertion(+), 5 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c inde

[Mesa-dev] [PATCH 00/17] Newbie Project : Enable ARB_map_buffer_alignment in all drivers

2013-11-24 Thread Siavash Eliasi
Hello, this is a series of patches to accomplish *Enable ARB_map_buffer_alignment in all drivers* newbie project suggested by Ian Romanick. *Note* that I don't have write access, please merge them upstream after review process. Best Regards, Siavash Eliasi. Siavash Eliasi (17): Modified al

[Mesa-dev] [PATCH 08/17] Modified ilo to return 4096 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/ilo/ilo_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/ilo/ilo_screen.c b/src/gallium/drivers/ilo/ilo_screen.c index a345b70..466b21c 100644 --- a/src/gallium/drivers/ilo/ilo_screen.c +++ b/src/gallium/drivers/ilo/ilo_scree

[Mesa-dev] [PATCH 05/17] Modified i915_buffer_create to use memory allocation alignment of 64 instead of 16.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/i915/i915_resource_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/i915/i915_resource_buffer.c b/src/gallium/drivers/i915/i915_resource_buffer.c index 80ec43a..fd29524 100644 --- a/src/gallium/drivers/i915/i915_resource_buff

[Mesa-dev] [PATCH 07/17] Modified svga to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/svga/svga_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/svga/svga_screen.c b/src/gallium/drivers/svga/svga_screen.c index c16be16..9e67aa0 100644 --- a/src/gallium/drivers/svga/svga_screen.c +++ b/src/gallium/drivers/svga/svga_screen.c @@

[Mesa-dev] [PATCH 03/17] Modified allocation routines to use alignment of 64 instead of 16.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/llvmpipe/lp_texture.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/llvmpipe/lp_texture.c b/src/gallium/drivers/llvmpipe/lp_texture.c index 0088b6a..d1ebeda 100644 --- a/src/gallium/drivers/llvmpipe/lp_texture.c +++ b/src/galli

[Mesa-dev] [PATCH 02/17] Modified softpipe to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/softpipe/sp_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_screen.c b/src/gallium/drivers/softpipe/sp_screen.c index 47ef20e..022b5bf 100644 --- a/src/gallium/drivers/softpipe/sp_screen.c +++ b/src/gallium/drive

[Mesa-dev] [PATCH 04/17] Modified llvmpipe to return 64 in case of PIPE_CAP_MIN_MAP_BUFFER_ALIGNMENT.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/llvmpipe/lp_screen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/llvmpipe/lp_screen.c b/src/gallium/drivers/llvmpipe/lp_screen.c index f61df98..8be1779 100644 --- a/src/gallium/drivers/llvmpipe/lp_screen.c +++ b/src/gallium/drivers/llvmpipe/lp_s

[Mesa-dev] [PATCH 01/17] Modified allocation routine to use alignment of 64 instead of 16.

2013-11-24 Thread Siavash Eliasi
--- src/gallium/drivers/softpipe/sp_texture.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/softpipe/sp_texture.c b/src/gallium/drivers/softpipe/sp_texture.c index 370f2b4..fb20748 100644 --- a/src/gallium/drivers/softpipe/sp_texture.c +++ b/src/gallium/d

[Mesa-dev] [PATCH 02/11] mesa: Add ARB_shader_image_load_store to the extension table.

2013-11-24 Thread Francisco Jerez
--- src/mesa/main/extensions.c | 1 + src/mesa/main/mtypes.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 104618c..19cf34d 100644 --- a/src/mesa/main/extensions.c +++ b/src/mesa/main/extensions.c @@ -123,6 +123,7 @@ static

[Mesa-dev] [PATCH 09/11] mesa: Unbind deleted textures from the shader image units.

2013-11-24 Thread Francisco Jerez
>From ARB_shader_image_load_store: If a texture object bound to one or more image units is deleted by DeleteTextures, it is detached from each such image unit, as though BindImageTexture were called with identifying the image unit and set to zero. --- src/mesa/main/texobj.c | 25 +++

[Mesa-dev] [PATCH 01/11] glapi: Update dispatch XML files for ARB_shader_image_load_store.

2013-11-24 Thread Francisco Jerez
And uncomment the relevant lines of the dispatch sanity test. --- src/mapi/glapi/gen/ARB_shader_image_load_store.xml | 89 ++ src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml | 2 + src/mesa/main/tests/dispatch_sanit

[Mesa-dev] [PATCH 05/11] mesa: Add image parameter queries for ARB_shader_image_load_store.

2013-11-24 Thread Francisco Jerez
--- src/mesa/main/get.c | 70 src/mesa/main/get_hash_params.py | 9 ++ src/mesa/main/texparam.c | 6 3 files changed, 85 insertions(+) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index eee8550..db77a65 100644 ---

[Mesa-dev] [PATCH 11/11] docs: Mark ARB_shader_image_load_store as work in progress.

2013-11-24 Thread Francisco Jerez
--- docs/GL3.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 5f6fa7e..d6a1a1e 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -130,7 +130,7 @@ GL 4.2: GL_ARB_texture_storage DONE (all drivers) GL_ARB_tran

[Mesa-dev] [PATCH 08/11] mesa: Implement the GL entry points defined by ARB_shader_image_load_store.

2013-11-24 Thread Francisco Jerez
--- src/mapi/glapi/gen/gl_genexec.py | 1 + src/mesa/Makefile.sources| 1 + src/mesa/main/shaderimage.c | 457 +++ src/mesa/main/shaderimage.h | 42 4 files changed, 501 insertions(+) create mode 100644 src/mesa/main/shaderimage.c c

[Mesa-dev] [PATCH 04/11] mesa: Add driver interface for ARB_shader_image_load_store.

2013-11-24 Thread Francisco Jerez
--- src/mesa/main/dd.h | 13 + 1 file changed, 13 insertions(+) diff --git a/src/mesa/main/dd.h b/src/mesa/main/dd.h index 648062f..7a4c0a7 100644 --- a/src/mesa/main/dd.h +++ b/src/mesa/main/dd.h @@ -900,6 +900,19 @@ struct dd_function_table { * non-zero status should be returne

[Mesa-dev] [PATCH 06/11] mesa: Add MESA_FORMAT_ABGR2101010.

2013-11-24 Thread Francisco Jerez
Including pack/unpack and texstore code. This texture format is a requirement for ARB_shader_image_load_store. --- src/mesa/main/format_pack.c | 29 +++ src/mesa/main/format_unpack.c | 32 ++ src/mesa/main/formats.c | 19

[Mesa-dev] [PATCH 07/11] mesa: Add MESA_FORMAT_SIGNED_RG88 and _RG1616.

2013-11-24 Thread Francisco Jerez
Including pack/unpack and texstore code. ARB_shader_image_load_store requires support for the GL_RG8_SNORM and GL_RG16_SNORM formats, which map to MESA_FORMAT_SIGNED_GR88 and MESA_FORMAT_SIGNED_GR1616 on little-endian hosts, and MESA_FORMAT_SIGNED_RG88 and MESA_FORMAT_SIGNED_RG1616 respectively on

[Mesa-dev] [PATCH 10/11] mesa: Validate image units when the texture state changes.

2013-11-24 Thread Francisco Jerez
--- src/mesa/main/shaderimage.c | 11 +++ src/mesa/main/shaderimage.h | 9 + src/mesa/main/texstate.c| 3 +++ 3 files changed, 23 insertions(+) diff --git a/src/mesa/main/shaderimage.c b/src/mesa/main/shaderimage.c index 627366b..3a59409 100644 --- a/src/mesa/main/shaderimag

[Mesa-dev] [PATCH 03/11] mesa: Add state data structures requried for ARB_shader_image_load_store.

2013-11-24 Thread Francisco Jerez
--- src/mesa/main/config.h | 1 + src/mesa/main/dd.h | 1 + src/mesa/main/mtypes.h | 100 + src/mesa/main/texobj.c | 1 + 4 files changed, 103 insertions(+) diff --git a/src/mesa/main/config.h b/src/mesa/main/config.h index 22bbfa0..8bd976

[Mesa-dev] [PATCH 00/11] Core mesa changes for ARB_shader_image_load_store.

2013-11-24 Thread Francisco Jerez
This is the first of three patch series enabling basic support for ARB_shader_image_load_store on Intel Gen7 (and Gen7.5) hardware. Most of the necessary core mesa changes are part of this batch (except the one patch that depends on GLSL changes). I'll be sending a second batch with the GLSL comp

Re: [Mesa-dev] [PATCH] gallium/dri: Support DRI Image extension version 7 (v3)

2013-11-24 Thread Christopher James Halse Rogers
On Mon, 2013-11-25 at 14:38 +1000, Ben Skeggs wrote: > On Mon, Nov 25, 2013 at 1:57 PM, > wrote: > > From: Christopher James Halse Rogers > > > http://cgit.freedesktop.org/~keithp/mesa/log/?h=dri3 > Sure, why not? I don't really mind which series goes in - although I think my patch series is m

Re: [Mesa-dev] [PATCH] gallium/dri: Support DRI Image extension version 7 (v3)

2013-11-24 Thread Ben Skeggs
On Mon, Nov 25, 2013 at 1:57 PM, wrote: > From: Christopher James Halse Rogers http://cgit.freedesktop.org/~keithp/mesa/log/?h=dri3 > > v2: Fix up queryImage return for ATTRIB_FD > Use driver_descriptor.configuration to determine whether the driver > supports DMA-BUF import/export. > v3:

Re: [Mesa-dev] [PATCH 3/9] gallium/dri2: Set winsys_handle type to KMS for stride query.

2013-11-24 Thread Christopher James Halse Rogers
On Thu, 2013-11-21 at 14:12 +0100, Thomas Hellstrom wrote: > On 11/21/2013 05:11 AM, christopher.halse.rog...@canonical.com wrote: > > From: Christopher James Halse Rogers > > > > Otherwise the default is TYPE_SHARED, which will flink the bo. This seems > > rather unnecessary for a simple stride q

[Mesa-dev] [PATCH] gallium/radeon: Implement hooks for DRI Image 7 (v2)

2013-11-24 Thread christopher . halse . rogers
From: Christopher James Halse Rogers v2: Fix transliteration of lseek arguments Ignore busy return from RADEON_GEM_BUSY ioctl; we're only after the domain --- src/gallium/targets/r300/common/drm_target.c | 27 +- src/gallium/targets/r600/common/drm_target.c | 16 src/galli

[Mesa-dev] [PATCH] gallium/dri: Support DRI Image extension version 7 (v3)

2013-11-24 Thread christopher . halse . rogers
From: Christopher James Halse Rogers v2: Fix up queryImage return for ATTRIB_FD Use driver_descriptor.configuration to determine whether the driver supports DMA-BUF import/export. v3: Really, truly, fix up queryImage return for ATTRIB_FD --- src/gallium/include/state_tracker/drm_driver.h

[Mesa-dev] [PATCH] gallium/dri: Support DRI Image extension version 6 (v2)

2013-11-24 Thread christopher . halse . rogers
From: Christopher James Halse Rogers v2: Pick out the correct gl_context pointer; now passes associated piglit --- src/gallium/state_trackers/dri/drm/dri2.c | 72 ++- 1 file changed, 71 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/dri/drm/dri2

Re: [Mesa-dev] [PATCH 1/8] mesa: expose AMD_vertex_shader_layer in the core profile only

2013-11-24 Thread Jordan Justen
On Sun, Nov 24, 2013 at 2:55 AM, Marek Olšák wrote: > From: Marek Olšák > > It needs glFramebufferTexture, which isn't available in the compatibility > profile. > --- > src/mesa/main/extensions.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/extensions.c

Re: [Mesa-dev] [PATCH 2/8] st/mesa: allow GLSL 1.50 and 3.30 to be exposed

2013-11-24 Thread Dave Airlie
I actually had a change for this reviewed already I'll push it. Dave. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965: Bump number of supported atomic counter buffers.

2013-11-24 Thread Francisco Jerez
Now that we have dynamic binding tables there's no good reason anymore to expose so few atomic counter buffers. Increase it to 16. --- src/mesa/drivers/dri/i965/brw_context.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.h b/src/mesa/dr

Re: [Mesa-dev] Anonymous structure in uniform question

2013-11-24 Thread Grigori Goronzy
On 21.11.2013 21:50, f.jo...@email.cz wrote: The problem is, that each anonymous structure gets its own unique type, without checking if such type already exists. It seems to me, that such code is somewhat in the gray area - the rest of OpenGL implementations doesn't seem to have a problem with t

Re: [Mesa-dev] [PATCH 0/3] Implement DRI_PRIME support for Wayland

2013-11-24 Thread Alex Deucher
On Fri, Nov 22, 2013 at 8:52 AM, Axel Davy wrote: > On 11/22/2013 01:16 AM, Kristian Høgsberg wrote: >> I'm not sold on the nested compositor for this use case. It >> introduces another context switch between the game and the main >> compositor and more input and output lag. Instead I think we n

Re: [Mesa-dev] [PATCH 3/5] radeon: change last instance of DEBUG_IOCTL to use RADEON_IOCTL

2013-11-24 Thread Alex Deucher
On Sun, Nov 24, 2013 at 12:13 AM, Chris Forbes wrote: > DEBUG_IOCTL comes from i965, and is about to be removed. Both defines > have the same value (4). > > Signed-off-by: Chris Forbes Reviewed-by: Alex Deucher > --- > src/mesa/drivers/dri/radeon/radeon_ioctl.c | 2 +- > 1 file changed, 1 ins

[Mesa-dev] [PATCH] mesa: reduce memory used for short display lists

2013-11-24 Thread Brian Paul
From: Brian Paul Display lists allocate memory in chunks of 256 tokens (1KB) at a time. If an app creates many short display lists or uses glXUseXFont() this can waste quite a bit of memory. This patch uses realloc() to trim short lists and reduce the memory used. Also, null/zero-out some list

[Mesa-dev] More projects for newbies

2013-11-24 Thread Klemen Košir
Hello! I'll try to implement AMD_shader_trinary_minmax. This is my first "project", so I hope I'll be able to do it (correctly). It shouldn't take me too long. - Klemen Košir ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesk

Re: [Mesa-dev] [PATCH 5/5] docs: describe the INTEL_* envvars that do exist

2013-11-24 Thread Kenneth Graunke
On 11/23/2013 09:13 PM, Chris Forbes wrote: > Signed-off-by: Chris Forbes > --- > docs/envvars.html | 32 > 1 file changed, 32 insertions(+) > > diff --git a/docs/envvars.html b/docs/envvars.html > index 81e74e6..d831826 100644 > --- a/docs/envvars.html > +++ b/d

[Mesa-dev] Request for support of GL_AMD_pinned_memory and GL_ARB_buffer_storage extensions

2013-11-24 Thread Tony Wasserka
Hello everyone, I was told on IRC that my question would get most attention around here - so bear with me if this is the wrong place to ask I'm one of the developers of the GC/Wii emulator Dolphin. We recently rewrote our OpenGL renderer to use modern OpenGL 3 features, however one thing that

[Mesa-dev] [PATCH 8/8] st/mesa: implement layered framebuffer clear for the clear_with_quad fallback

2013-11-24 Thread Marek Olšák
From: Marek Olšák Same approach as in u_blitter. --- src/gallium/auxiliary/cso_cache/cso_context.c | 20 + src/gallium/auxiliary/cso_cache/cso_context.h | 5 +++ src/mesa/state_tracker/st_cb_clear.c | 58 +++ src/mesa/state_tracker/st_context.h

[Mesa-dev] [PATCH 7/8] gallium/util: implement layered framebuffer clear in u_blitter

2013-11-24 Thread Marek Olšák
From: Marek Olšák All bound layers (from first_layer to last_layer) should be cleared. This uses a vertex shader which outputs gl_Layer = gl_InstanceID, so each instance goes to a different layer. By rendering a quad and setting the instance count to the number of layers, it will trivially clear

[Mesa-dev] [PATCH 2/8] st/mesa: allow GLSL 1.50 and 3.30 to be exposed

2013-11-24 Thread Marek Olšák
From: Marek Olšák --- src/mesa/state_tracker/st_extensions.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c index e8d0902..28171d9 100644 --- a/src/mesa/state_tracker/st_extensions.c +++ b/

[Mesa-dev] [PATCH 4/8] radeonsi: implement OpenGL edge flags

2013-11-24 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 52 +++--- src/gallium/drivers/radeonsi/radeonsi_shader.h | 1 + src/gallium/drivers/radeonsi/si_state_draw.c | 1 + 3 files changed, 48 insertions(+), 6 deletions(-) diff --git a/src/gallium/drivers/

[Mesa-dev] [PATCH 5/8] radeonsi: add driver support for layered rendering and AMD_vertex_shader_layer

2013-11-24 Thread Marek Olšák
From: Marek Olšák --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 14 +- src/gallium/drivers/radeonsi/radeonsi_shader.h | 1 + src/gallium/drivers/radeonsi/si_state.c| 23 --- src/gallium/drivers/radeonsi/si_state_draw.c | 1 + 4 files changed, 27

[Mesa-dev] [PATCH 1/8] mesa: expose AMD_vertex_shader_layer in the core profile only

2013-11-24 Thread Marek Olšák
From: Marek Olšák It needs glFramebufferTexture, which isn't available in the compatibility profile. --- src/mesa/main/extensions.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c index 104618c..f7e7e4d 100644 --- a/src/

[Mesa-dev] [PATCH 3/8] st/mesa: add support for layered framebuffers and consolidate code

2013-11-24 Thread Marek Olšák
From: Marek Olšák This is a subset of geometry shaders. It's all about setting first_layer and last_layer correctly. Also some code between st_render_texture and update_framebuffer_state is consolidated. It doesn't use rtt_level and derives the level from dimensions instead as the code in st_ato

[Mesa-dev] [PATCH 6/8] gallium: add support for AMD_vertex_shader_layer

2013-11-24 Thread Marek Olšák
From: Marek Olšák --- src/gallium/docs/source/screen.rst | 2 ++ src/gallium/drivers/freedreno/freedreno_screen.c | 1 + src/gallium/drivers/i915/i915_screen.c | 1 + src/gallium/drivers/ilo/ilo_screen.c | 2 ++ src/gallium/drivers/llvmpipe/lp_screen.c