Fixes "Missing break in switch" defect reported by Coverity.
Signed-off-by: Vinson Lee
---
src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/mesa/drivers/dri/i965/brw_schedule_instructions.cpp
b/src/mesa/drivers/dri/i965/brw_schedu
I think you mentioned that you've merged Chris's d2573509 into this
already. With that change,
Reviewed-by: Jordan Justen
On Thu, Nov 7, 2013 at 1:58 PM, Eric Anholt wrote:
> I want to reuse them in opt_algebraic.
> ---
> src/glsl/Makefile.sources | 1 +
> src/glsl/ir.h | 22
v2: Don't go to extra work to avoid extraneous flushes. (Previous
experiments in the kernel have suggested that flushing the pipeline
when it is already empty is extremely cheap).
Cc: "10.0"
---
src/mesa/drivers/dri/i965/brw_context.c | 1 +
src/mesa/drivers/dri/i965/brw_context.h
On Thu, Nov 14, 2013 at 5:39 PM, Mark Mueller wrote:
> On Thu, Nov 14, 2013 at 5:18 PM, Chris Forbes wrote:
>> Why does this affect that piglit test?
>
> Oh wait, it was patch 1/2 that fixed that test. Do I still need to answer
> the question? :)
>
> 1/2 made no significant functional changes so
On Thu, Nov 14, 2013 at 5:18 PM, Chris Forbes wrote:
> Why does this affect that piglit test?
>
Oh wait, it was patch 1/2 that fixed that test. Do I still need to answer
the question? :)
1/2 made no significant functional changes so I don't have an explanation,
but I will do some checking and g
Why does this affect that piglit test?
-- Chris
On Fri, Nov 15, 2013 at 2:01 PM, Mark Mueller wrote:
> fixed subject line
>
>
> On Thu, Nov 14, 2013 at 4:15 PM, Mark Mueller
> wrote:
>>
>> This patch consolidates the decision about formats that blorp_blt does and
>> does not support to blorp in
fixed subject line
On Thu, Nov 14, 2013 at 4:15 PM, Mark Mueller wrote:
> This patch consolidates the decision about formats that blorp_blt does and
> does not support to blorp instead of leaving that decision to callers. This
> opens the door to adding more functionality to blorp, including sup
This patch consolidates the decision about formats that blorp_blt does and
does not support to blorp instead of leaving that decision to callers. This
opens the door to adding more functionality to blorp, including support for
using GPU acceleration of processing and loading textures.
This patch f
This and the subsequent patch are the first steps in adding support to load
textures
via GPU instead of CPU. This patch expands Mesa's gl_formats such that all
GLUser
format/type combinations are represented and thus can be communicated to lower
levels
within dri drivers. The new formats are sou
On Wed, Nov 13, 2013 at 03:13:55PM -0500, Alex Deucher wrote:
> On Wed, Nov 13, 2013 at 1:12 PM, Tom Stellard wrote:
> > On Wed, Nov 13, 2013 at 12:27:05PM -0500, Alex Deucher wrote:
> >> Signed-off-by: Alex Deucher
> >
> > Reviewed-by: Tom Stellard
> >
> > Now that we have compute support for S
This patch is : reviewed-by: Vincent Lejeune
- Mail original -
> De : Tom Stellard
> À : Vincent Lejeune
> Cc : "mesa-dev@lists.freedesktop.org" ;
> "llvm-comm...@cs.uiuc.edu" ; Tom Stellard
>
> Envoyé le : Jeudi 14 novembre 2013 1h53
> Objet : Re: [PATCH] R600: Make sure OQAP defs
On 11/14/2013 04:14 PM, Ian Romanick wrote:
On 11/13/2013 10:38 AM, Brian Paul wrote:
To trim down the varray.c file so it's just vertex array functions.
Is that the only motivation?
For now, yes. I'm just trying to de-clutter varray.[ch]
This will prevent us from optimizing the
Reviewed-by: Eric Anholt
pgpf66DHKGzLM.pgp
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 11/13/2013 10:38 AM, Brian Paul wrote:
> To trim down the varray.c file so it's just vertex array functions.
Is that the only motivation? This will prevent us from optimizing the
implementation of, say, _mesa_MultiDrawArrays. It also seems weird that
_mesa_MultiDrawModeDrawArraysIBM a
Patches 6, 7, 8, and 9 are
Reviewed-by: Ian Romanick
On 11/13/2013 05:52 PM, Kenneth Graunke wrote:
> Being able to print monitor->Name is really useful for debugging.
>
> Signed-off-by: Kenneth Graunke
> Cc: Eric Anholt
> Cc: Carl Worth
> Cc: Juha-Pekka Heikkilä
> ---
> src/mesa/main/mtyp
On 11/13/2013 03:11 PM, Eric Anholt wrote:
> Notably, ENV and LOCAL aren't used any more (replaced by STATE_VAR), but
> apparently CONSTANT is.
Good times.
Reviewed-by: Ian Romanick
> ---
> src/mesa/program/program_parser.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --gi
Reviewed-by: Jordan Justen
On Wed, Oct 30, 2013 at 4:33 PM, Paul Berry wrote:
> Previously, when doing intrastage and interstage interface block
> linking, we only checked the interface type; this prevented us from
> catching some link errors.
>
> We now check the following additional constraint
On 11/14/2013 01:19 PM, Eric Anholt wrote:
> Petri Latvala writes:
>
>> vec4_visitor's uniform_size and uniform_vector_size arrays contain
>> information about uniforms. Their size should be the number of uniform
>> components (MAX_UNIFORMS * 4) instead of number of uniform vec4s
>> (MAX_UNIFORMS
On 11/11/2013 11:19 AM, Ian Romanick wrote:
> From: Ian Romanick
>
> Systems with little physical memory installed will report less than
> 2GiB, and some systems may (hypothetically?) have a larger address space
> for the GPU. My IVB still reports 1534.
>
> Signed-off-by: Ian Romanick
> Cc: Da
Man... linkers are the most complex pieces of software. :( I only have
one significant comment (the second below) and three nits / questions.
With at least the first one resolved, this patch is
Reviewed-by: Ian Romanick
On 10/30/2013 04:33 PM, Paul Berry wrote:
> Previously, when doing intrasta
On 11/04/2013 08:10 PM, Paul Berry wrote:
> ---
> src/mesa/drivers/dri/i965/brw_context.h | 44
> +++
> src/mesa/drivers/dri/i965/gen7_blorp.cpp | 8 +
> src/mesa/drivers/dri/i965/gen7_gs_state.c | 18 +++
> src/mesa/drivers/dri/i965/gen7_urb.c
After we blit/copy to a dest texture image we need to mark it as
being defined. This fixes broken mipmap generation for quite a
few texture formats. Mipgen involves making texture views and
svga_texture_view_surface() skips texture images that are undefined.
---
src/gallium/drivers/svga/svga_pip
For DX9-level shaders, there's only limited support for indirect
indexing of registers (with the loop counter register, not the
general address register.)
---
src/gallium/drivers/svga/svga_tgsi_insn.c |4
1 file changed, 4 insertions(+)
diff --git a/src/gallium/drivers/svga/svga_tgsi_ins
Petri Latvala writes:
> vec4_visitor's uniform_size and uniform_vector_size arrays contain
> information about uniforms. Their size should be the number of uniform
> components (MAX_UNIFORMS * 4) instead of number of uniform vec4s
> (MAX_UNIFORMS).
Instead of making our giant static arrays even
On 11/14/2013 10:42 AM, Matt Turner wrote:
> ---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++--
> src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 4 ++--
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
> b/src/mesa/drivers/dri
---
src/mesa/drivers/dri/i965/brw_fs.cpp | 4 ++--
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp
b/src/mesa/drivers/dri/i965/brw_fs.cpp
index 292eeb3..2cc1da5 100644
--- a/src/
Alexander von Gluck IV writes:
> * Inherit gl_context so we always have access to it
> * Thanks curro for the idea.
> * Last Haiku cannidate for 10.0.0
If you remove the redundant 'if (!this) {...}', this patch is:
Reviewed-by: Francisco Jerez
> ---
> src/mesa/drivers/haiku/swrast/SoftwareRa
radeon_llvm_compile allocates memory for binary.code, binary.config,
or neither depending on what's being done.
We need to make sure to free that memory after it's no longer needed.
v2: Don't bother checking for null before FREE()
---
src/gallium/drivers/r600/r600_llvm.c | 3 +++
1 file changed,
use memset to initialize to 0's... otherwise code_size and config_size
could be uninitialized when read later in this method.
It's also hard to do NULL checks on uninitialized pointers.
Reviewed-by: Tom Stellard
v2: Fix indentation
---
src/gallium/drivers/r600/r600_llvm.c | 1 +
1 file changed
With the 3 attached patches and a previous series of 6 patches, I can
now launch glxgears on Evergreen without any definite memory leaks according
to: valgrind --leak-check=full glxgears
I've run this through piglit/tests/quick.tests without any regressions.
I don't have commit access (yet), so f
Prevents a memory leak.
v2: Remove null check
---
src/gallium/drivers/radeon/radeon_llvm_emit.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c
b/src/gallium/drivers/radeon/radeon_llvm_emit.c
index d2e5642..92e7dbc 100644
--- a/src/gallium/driver
On Thu, Nov 14, 2013 at 11:38:06AM -0600, Aaron Watry wrote:
> On Thu, Nov 14, 2013 at 10:29 AM, Tom Stellard wrote:
> > From: Tom Stellard
> >
> > We need to do this until function calls are supported.
> >
> > https://bugs.freedesktop.org/show_bug.cgi?id=64225
> >
> > CC: "10.0"
> > ---
> > sr
On Thu, Nov 14, 2013 at 10:29 AM, Tom Stellard wrote:
> From: Tom Stellard
>
> We need to do this until function calls are supported.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=64225
>
> CC: "10.0"
> ---
> src/gallium/drivers/radeon/radeon_llvm_util.c | 24 ++--
> 1 fi
Tom Stellard writes:
> From: Tom Stellard
>
> v2:
> - Use clGetDeviceIDs to query devices.
>
> CC: "10.0"
Thank you, this patch is:
Reviewed-by: Francisco Jerez
> ---
> src/gallium/state_trackers/clover/api/context.cpp | 12 +---
> 1 file changed, 9 insertions(+), 3 deletions(-)
https://bugs.freedesktop.org/show_bug.cgi?id=71591
José Fonseca changed:
What|Removed |Added
CC||bri...@vmware.com,
|
From: Tom Stellard
We need to do this until function calls are supported.
https://bugs.freedesktop.org/show_bug.cgi?id=64225
CC: "10.0"
---
src/gallium/drivers/radeon/radeon_llvm_util.c | 24 ++--
1 file changed, 22 insertions(+), 2 deletions(-)
diff --git a/src/gallium/d
From: Tom Stellard
v2:
- Use clGetDeviceIDs to query devices.
CC: "10.0"
---
src/gallium/state_trackers/clover/api/context.cpp | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/gallium/state_trackers/clover/api/context.cpp
b/src/gallium/state_trackers/clov
On 11/13/2013 04:11 PM, Eric Anholt wrote:
Notably, ENV and LOCAL aren't used any more (replaced by STATE_VAR), but
apparently CONSTANT is.
---
src/mesa/program/program_parser.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/mesa/program/program_parser.h
b/src/mesa/pr
On Wed, Nov 13, 2013 at 09:05:48PM -0800, Kenneth Graunke wrote:
> We need to start OA at the beginning of each batch where monitors are
> active. OACONTROL isn't part of the hardware context, so to avoid
> leaving counters enabled for other applications, we turn them off at the
> end of the batch
https://bugs.freedesktop.org/show_bug.cgi?id=71591
--- Comment #2 from MirceaKitsune ---
I understand. Still strange that proprietary drivers compile them while Mesa
does not. Even if they're written poorly, I imagine Mesa could add
compatibility support to avoid situations like this. Since Linde
Vincent Lejeune wrote:
---
src/gallium/drivers/r600/r600_llvm.c | 119 +++
src/gallium/drivers/r600/r600_shader.c | 1 +
src/gallium/drivers/radeon/radeon_llvm.h | 1 +
3 files changed, 121 insertions(+)
Looks like this or whatever version went in to m
41 matches
Mail list logo
