Re: [Mesa-dev] [PATCH] glx: conditionaly build dri3 and present loader (v3)

On 11/09/2013 01:15 AM, Ian Romanick wrote: > On 11/08/2013 03:06 PM, Armin K wrote: >> This patch makes it possible to disable DRI3 if desired. > > Should we squash this with Jose's patch? > Yes, that would be nice. They do the same thing but for different build systems. >> v2: >> >> Incorpora

Re: [Mesa-dev] [PATCH] glx: conditionaly build dri3 and present loader (v3)

On 11/08/2013 03:06 PM, Armin K wrote: > This patch makes it possible to disable DRI3 if desired. Should we squash this with Jose's patch? > v2: > > Incorporated changes from Ian Romanick and Aaron Watry > Unified libudev check and made libGL link to it only > when DRI3 was enabled. > > v3: >

Re: [Mesa-dev] [PATCH] glx: conditionaly build dri3 and present loader (v3)

On Fri, Nov 8, 2013 at 3:06 PM, Armin K wrote: > This patch makes it possible to disable DRI3 if desired. Reviewed-by: Matt Turner Unless non-Linux users still need to be able to disable DRI3, by the time Mesa 10.0 is released I think we want to require these bits for DRI builds. I'll plan to r

Re: [Mesa-dev] [PATCH] glx: Fix scons build.

On Fri, Nov 8, 2013 at 9:55 AM, wrote: > From: José Fonseca > > By disabling DRI3 support for the time being. > > I'll add DRI3 support to scons build when the DRI3 dependencies become > more widely available (as now there is no convenient way of testing it > except building dependencies from so

[Mesa-dev] [PATCH] glx: conditionaly build dri3 and present loader (v3)

This patch makes it possible to disable DRI3 if desired. v2: Incorporated changes from Ian Romanick and Aaron Watry Unified libudev check and made libGL link to it only when DRI3 was enabled. v3: Correct misspelled Ian's last name in commit message. Adding Brian Paul to CC since he asked if DR

[Mesa-dev] [PATCH] glx: conditionaly build dri3 and present loader (v2)

This patch makes it possible to disable DRI3 if desired. v2: Incorporated changes from Ian Rommnick and Aaron Watry Unified libudev check and made libGL link to it only when DRI3 was enabled. Adding Brian Paul to CC since he asked if DRI3 stuff can be put behind some sort of config option. Test

Re: [Mesa-dev] rules for merging patches to libdrm

On 11/08/2013 02:32 PM, Matt Turner wrote: > On Fri, Nov 8, 2013 at 11:29 AM, Dave Airlie wrote: >> Since we seemed to have some confusion over this I'll state it clearly here. >> >> You should not merge kernel interface and ioctls to libdrm until they >> have appeared in a git commit upstream wit

Re: [Mesa-dev] rules for merging patches to libdrm

On Fri, Nov 8, 2013 at 11:29 AM, Dave Airlie wrote: > Since we seemed to have some confusion over this I'll state it clearly here. > > You should not merge kernel interface and ioctls to libdrm until they > have appeared in a git commit upstream with a stable id, this > generally means drm-next, b

Re: [Mesa-dev] [PATCH] i965: Make the driver compile until a proper libdrm can be released.

On 11/08/2013 10:49 AM, Eric Anholt wrote: > No depending on unreleased code. > --- > src/mesa/drivers/dri/i965/brw_context.c | 8 +++- > src/mesa/drivers/dri/i965/brw_reset.c | 7 +++ > 2 files changed, 10 insertions(+), 5 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_co

[Mesa-dev] [Bug 71397] [llvmpipe] configure: error: Package requirements (dri3proto >= 1.0) were not met

https://bugs.freedesktop.org/show_bug.cgi?id=71397 --- Comment #2 from Aaron Watry --- Created attachment 88912 --> https://bugs.freedesktop.org/attachment.cgi?id=88912&action=edit v2 --disable-dri3 Patch I had to use the modified version of the original that I attached here. -- You are rece

Re: [Mesa-dev] [PATCH] glx: conditionaly build dri3 and present loader

On 11/08/2013 01:38 PM, Armin K wrote: > This patch makes it possible to disable dri3 if desired. > > I am not sure if first set of changes for src/glx/glxext.c > was necessary. Feel free to modify it as you may please. > > Tested with: > > ./configure --disable-dri3 --with-dri-drivers=i965 \ >

Re: [Mesa-dev] [PATCH] i965: Remove some tiny dead code from intel_miptree_map_movntdqa

On Fri, Nov 8, 2013 at 1:55 PM, Chad Versace wrote: > CC: Matt Turner > Signed-off-by: Chad Versace > --- > src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c > b/src/mesa/drivers/dri/i965/intel

Re: [Mesa-dev] [PATCH] glx/dri: fix assorted compiler warnings/errors

On 11/07/2013 07:04 PM, Brian Paul wrote: > From: Brian Paul > > To fix fall-out from recent commits. /me puts a paper bag on his head I only built i915 and i965 before pushing. Sorry about that. With the issue below fixed, Reviewed-by: Ian Romanick I'll pick the fixes over to the 10.0 bra

[Mesa-dev] [PATCH] i965: Remove some tiny dead code from intel_miptree_map_movntdqa

CC: Matt Turner Signed-off-by: Chad Versace --- src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c index 3f56086..bb986bd 100644 --- a/src/mesa/drivers/

Re: [Mesa-dev] [PATCH] i965: Make the driver compile until a proper libdrm can be released.

On 11/08/2013 10:49 AM, Eric Anholt wrote: > No depending on unreleased code. > --- > src/mesa/drivers/dri/i965/brw_context.c | 8 +++- > src/mesa/drivers/dri/i965/brw_reset.c | 7 +++ > 2 files changed, 10 insertions(+), 5 deletions(-) Reviewed-by: Kenneth Graunke ___

Re: [Mesa-dev] [PATCH] i965: Make the driver compile until a proper libdrm can be released.

On 11/08/2013 07:49 PM, Eric Anholt wrote: > No depending on unreleased code. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=71391 > --- > src/mesa/drivers/dri/i965/brw_context.c | 8 +++- > src/mesa/drivers/dri/i965/brw_reset.c | 7 +++ > 2 files changed, 10 insertions(+), 5 d

[Mesa-dev] [Bug 71397] [llvmpipe] configure: error: Package requirements (dri3proto >= 1.0) were not met

https://bugs.freedesktop.org/show_bug.cgi?id=71397 --- Comment #1 from Armin K --- Does http://lists.freedesktop.org/archives/mesa-dev/2013-November/048072.html fix your issue? Note that you have to use --disable-dri3 -- You are receiving this mail because: You are the assignee for the bug. ___

[Mesa-dev] [PATCH] glx: conditionaly build dri3 and present loader

This patch makes it possible to disable dri3 if desired. I am not sure if first set of changes for src/glx/glxext.c was necessary. Feel free to modify it as you may please. Tested with: ./configure --disable-dri3 --with-dri-drivers=i965 \ --with-gallium-drivers= --disable-vdpau --disable-egl \ -

Re: [Mesa-dev] Batchbuffer question

On 11/08/2013 04:49 AM, Rogovin, Kevin wrote: > Hi all, > > As I was poking into the magicks for the batchbuffer, I saw the > following logical bits of code, that make sense by themselves but get > me paranoid together. Firstly in intel_batchbuffer_begin() [ > intel_batchbuffer.h, and this is what

[Mesa-dev] [PATCH] glx: Fix scons build.

From: José Fonseca By disabling DRI3 support for the time being. I'll add DRI3 support to scons build when the DRI3 dependencies become more widely available (as now there is no convenient way of testing it except building dependencies from source). --- src/glx/SConscript | 6 ++ src/glx/gl

Re: [Mesa-dev] [PATCH demos 2/3] Perf: Add test to measure texture upload

enh = enhanced Suggestions on something more descriptive? teximage2? bench_teximage? teximage_perf? Thanks for the feedback. On Thu, Nov 7, 2013 at 5:49 PM, Brian Paul wrote: > On 11/07/2013 02:16 PM, Courtney Goeltzenleuchter wrote: > >> Needed test to measure texture upload speed under a va

[Mesa-dev] rules for merging patches to libdrm

Since we seemed to have some confusion over this I'll state it clearly here. You should not merge kernel interface and ioctls to libdrm until they have appeared in a git commit upstream with a stable id, this generally means drm-next, but can also mean drm-intel-next. You shouldn't assume that st

Re: [Mesa-dev] dri3proto requirement (Was: Add DRI3+Present loader)

Jose Fonseca writes: > This change seems makes dri3proto a hard requirement to build with > automake. Is that strictly necessary? I tried to find ubuntu > packages for it to install on my build slave, but it doesn't seem they > exist yet. Well, we could build more build infrastructure for not

[Mesa-dev] [PATCH] i965: Make the driver compile until a proper libdrm can be released.

No depending on unreleased code. --- src/mesa/drivers/dri/i965/brw_context.c | 8 +++- src/mesa/drivers/dri/i965/brw_reset.c | 7 +++ 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index a

[Mesa-dev] [Bug 71363] line rendering with --with-osmesa-bits=32

https://bugs.freedesktop.org/show_bug.cgi?id=71363 --- Comment #8 from burlen --- The bug can be reproduced using VTK built against OSMesa. The following shows how I configured Mesa and VTK. # Mesa config ./configure CXXFLAGS="-O2 -g" CFLAGS="-O2 -g" --disable-xvmc --disable-glx --disable-dri -

[Mesa-dev] [PATCH] glx: change query_renderer_integer() value param to unsigned

From: Brian Paul Not sure if this is supposed to be signed or unsigned. It's not consistent as-is. --- src/glx/glxclient.h |2 +- src/glx/query_renderer.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glx/glxclient.h b/src/glx/glxclient.h index e26a83e..

Re: [Mesa-dev] [PATCH demos 3/3] Perf: teximage_enh Add command line options

Hi Brian, Oops, I meant to get rid of that. Is unnecessary now that the perf framework has command line arguments. Courtney On Thu, Nov 7, 2013 at 5:49 PM, Brian Paul wrote: > On 11/07/2013 02:16 PM, Courtney Goeltzenleuchter wrote: > >> texture_enh allows the user to specify source, internal

[Mesa-dev] [PATCH 2/2] i965: Enhance tiled_memcpy to support all levels

Support all levels of a supported texture format. Using 1024x1024, RGBA source, mipmap <> internal-format Before (MB/sec) XRGB (MB/sec) mipmap (MB/sec) GL_RGBA 628.15 627.15 615.90 GL_RGB

Re: [Mesa-dev] [PATCH] i965/fs: Don't perform CSE on inst HW_REG dests (unless it's null)

Matt Turner writes: > Commit b16b3c87 began performing CSE on CMP instructions with null > destinations. I relaxed the restrictions a bit too much, thereby > allowing CSE to be performed on instructions with, for instance, an > explicit accumulator destination. > > This broke the arb_gpu_shader5/

Re: [Mesa-dev] [PATCH demos 2/3] Perf: Add test to measure texture upload

On 11/08/2013 08:49 AM, Courtney Goeltzenleuchter wrote: enh = enhanced Suggestions on something more descriptive? teximage2? bench_teximage? teximage_perf? Thanks for the feedback. Does the existing teximage test do anything that your new test doesn't do? If the old teximage test is obsole

[Mesa-dev] [Bug 71363] line rendering with --with-osmesa-bits=32

https://bugs.freedesktop.org/show_bug.cgi?id=71363 --- Comment #7 from burlen --- Created attachment 88901 --> https://bugs.freedesktop.org/attachment.cgi?id=88901&action=edit apitrace from the failing bar chart test The apitrace developers shared a patch that allows the tool to work with OSMe

[Mesa-dev] [Bug 71363] line rendering with --with-osmesa-bits=32

https://bugs.freedesktop.org/show_bug.cgi?id=71363 --- Comment #6 from burlen --- Comment on attachment 88866 --> https://bugs.freedesktop.org/attachment.cgi?id=88866 osmesa patch to test Review of attachment 88866: - The patch m

[Mesa-dev] [Bug 71397] New: [llvmpipe] configure: error: Package requirements (dri3proto >= 1.0) were not met

https://bugs.freedesktop.org/show_bug.cgi?id=71397 Priority: medium Bug ID: 71397 Keywords: regression CC: e...@anholt.net, kei...@keithp.com, k...@bitplanet.net Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] config

Re: [Mesa-dev] Batchbuffer question

On 8 November 2013 04:49, Rogovin, Kevin wrote: > Hi all, > > As I was poking into the magicks for the batchbuffer, I saw the following > logical bits of code, that make sense by themselves but get me paranoid > together. Firstly in intel_batchbuffer_begin() [ intel_batchbuffer.h, and > this is

Re: [Mesa-dev] [PATCH] glx/dri: fix assorted compiler warnings/errors

On 11/08/2013 07:10 AM, Jose Fonseca wrote: Looks good to me AFAICT. I had independently pushed a fix similar to the first chunk in your patch. I think it matches your's verbatim so there should be no conflict when you rebase. I'll push the swrast dri_create_context() patch. But for the q

Re: [Mesa-dev] [PATCH] glx: Fix scons build.

On 11/08/2013 10:55 AM, jfons...@vmware.com wrote: From: José Fonseca By disabling DRI3 support for the time being. I'll add DRI3 support to scons build when the DRI3 dependencies become more widely available (as now there is no convenient way of testing it except building dependencies from so

Re: [Mesa-dev] dri3proto requirement (Was: Add DRI3+Present loader)

On 11/08/2013 05:25 AM, Jose Fonseca wrote: This change seems makes dri3proto a hard requirement to build with automake. Is that strictly necessary? I tried to find ubuntu packages for it to install on my build slave, but it doesn't seem they exist yet. There's also a dependency on a new l

Re: [Mesa-dev] [PATCH] glx/dri: fix assorted compiler warnings/errors

Looks good to me AFAICT. I had independently pushed a fix similar to the first chunk in your patch. I think it matches your's verbatim so there should be no conflict when you rebase. Jose - Original Message - > From: Brian Paul > > To fix fall-out from recent commits. > --- > .../st

Re: [Mesa-dev] [v2 4/6] glsl: ir_deserializer class for the shader cache

On 11/05/2013 10:16 PM, Paul Berry wrote: On 1 November 2013 02:16, Tapani Pälli > wrote: ir_deserializer can create a gl_shader structure out of binary data from ir_serializer, will be used by OES_get_program_binary implementation. Signed-off-by:

[Mesa-dev] [PATCH 1/2] Increase array sizes to what they should be.

vec4_visitor's uniform_size and uniform_vector_size arrays contain information about uniforms. Their size should be the number of uniform components (MAX_UNIFORMS * 4) instead of number of uniform vec4s (MAX_UNIFORMS). Signed-off-by: Petri Latvala --- src/mesa/drivers/dri/i965/brw_vec4.h | 4 ++-

[Mesa-dev] Batchbuffer question

Hi all, As I was poking into the magicks for the batchbuffer, I saw the following logical bits of code, that make sense by themselves but get me paranoid together. Firstly in intel_batchbuffer_begin() [ intel_batchbuffer.h, and this is what BEGIN_BATCH maps to] there is a intel_batchbuffer_req

[Mesa-dev] [PATCH 0/2] Fix array overrun on too many uniforms

https://bugs.freedesktop.org/show_bug.cgi?id=71254 vec4_visitor has two arrays, uniform_size and uniform_vector_size. Their size is set to MAX_UNIFORMS, which is the number of uniform vec4s. The size should be the number of uniform components instead. When testing this fix (testcase shader attach

Re: [Mesa-dev] [PATCH 2/2 v3] i965: Enhance tiled_memcpy to support all levels

On 07.11.2013 23:01, Courtney Goeltzenleuchter wrote: > Support all levels of a supported texture format. > > Using 1024x1024, RGBA source, mipmap > <> > internal-format Before (MB/sec) XRGB (MB/sec) mipmap (MB/sec) > GL_RGBA

[Mesa-dev] [PATCH 2/2] Check access to vec4_visitor's arrays

Protect access to vec4_visitor's uniform_size and uniform_vector_size arrays by asserting the index used. Signed-off-by: Petri Latvala --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 3 +++ src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 6 ++ src/mesa/drivers/dri/i965/brw_vec4_vp.cpp

[Mesa-dev] CACHED_BATCH questions

Hi all, I am trying to get my head around CACHED_BATCH() which is just a macro for intel_batchbuffer_cached_advance(), and when I dig into that code it leaves me some head scratching. I am guessing it checks if the current contents of the batch buffer already have command and if so, to skip

[Mesa-dev] Request for fedback

Hello all, I have been going through the Mesa source code, generating doxy-text with the goal to make getting started in Mesa faster. Chad has setup a public site so that anyone can see the doxygen generated content at: http://people.freedesktop.org/~chadversary/mesa/doxygen/kevin-rogovin/

Re: [Mesa-dev] [PATCH 08/18] i965: Wire up initial support for DRI_RENDERER_QUERY extension

On Thu, Nov 07, 2013 at 04:23:12PM -0800, Ian Romanick wrote: > On 11/07/2013 01:33 PM, Daniel Vetter wrote: > > On Sat, Oct 12, 2013 at 12:10 AM, Ian Romanick wrote: > >> + /* Once a batch uses more than 75% of the maximum mappable size, we > >> + * assume that there's some fragmentati

[Mesa-dev] brw_context::upload questions

Hi all, I was poking through the code tracking what is happening to brw_context::upload.bo, and it left me scrathing me head. As Paul Berry told me, I see that is used to just store client side index and vertex buffers (copied to it essentially be copy_array_to_vbo_array() and brw_upload_ind

Re: [Mesa-dev] [PATCH 1/5] glsl: Move the CSE equality functions to the ir class.

On Thu, Nov 07, 2013 at 01:58:57PM -0800, Eric Anholt wrote: > I want to reuse them in opt_algebraic. > --- > src/glsl/Makefile.sources | 1 + > src/glsl/ir.h | 22 ++ > src/glsl/ir_equals.cpp| 196 > ++ > src/glsl/opt_cse.cpp

[Mesa-dev] dri3proto requirement (Was: Add DRI3+Present loader)

This change seems makes dri3proto a hard requirement to build with automake. Is that strictly necessary? I tried to find ubuntu packages for it to install on my build slave, but it doesn't seem they exist yet. Jose - Original Message - > Module: Mesa > Branch: master > Commit: 2d94601