Re: [Mesa-dev] [PATCH 3/3] i965/fs: Try a different pre-scheduling heuristic if the first spills.

Eric Anholt writes: > Since LIFO fails on some shaders in one particular way, and non-LIFO > systematically fails in another way on different kinds of shaders, try > them both. and pick whichever one successfully register allocates first. > Slightly prefer non-LIFO in case we produce extra depend

[Mesa-dev] [PATCH V2 05/15] mesa: Add validation helpers for new indirect draws

Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. Signed-off-by: Chris Forbes --- src/mesa/main/api_validate.c | 163 +++ src/mesa/main/api_validate.h | 26 +++ 2 files changed, 189 insertions(+) diff --git a/src/mesa/main/ap

[Mesa-dev] [PATCH V2 03/15] mesa: Add extension scaffolding for ARB_draw_indirect

We will reuse the same extension flag for ARB_multi_draw_indirect since it can always be supported by looping. Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. Signed-off-by: Chris Forbes --- src/mesa/main/extensions.c | 2 ++ src/mesa/main/get.c| 1 + src/mesa

[Mesa-dev] [PATCH V2 15/15] i965: Enable ARB_draw_indirect (and ARB_multi_draw_indirect) on Gen7+

.. and mark them off on the extensions list as done. V2: Enable only if pipelined register writes work. V3: Also update relnotes Signed-off-by: Chris Forbes Reviewed-by: Ian Romanick --- docs/GL3.txt | 4 ++-- docs/relnotes/10.0.html | 1 +

[Mesa-dev] [PATCH V2 11/15] i965: implement indirect drawing for Gen7

Just prior to emitting the 3DPRIMITIVE command, we load each of the indirect registers. The values loaded are either from offsets into the current indirect BO, or constant zero if the parameter is not used for this draw. Enabling use of the indirect registers is done by turning on a bit in the fir

[Mesa-dev] [PATCH V2 14/15] vbo: map indirect buffer and extract params if doing sw primitive restart

V2: Check for mapping failure (thanks Brian) Signed-off-by: Chris Forbes --- src/mesa/vbo/vbo_primitive_restart.c | 33 + 1 file changed, 33 insertions(+) diff --git a/src/mesa/vbo/vbo_primitive_restart.c b/src/mesa/vbo/vbo_primitive_restart.c index 48d04e1..ee8

[Mesa-dev] [PATCH V2 12/15] i965: pass indirect buffer to primitive restart check

--- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- src/mesa/drivers/dri/i965/brw_draw.h | 3 ++- src/mesa/drivers/dri/i965/brw_primitive_restart.c | 5 +++-- 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/driv

[Mesa-dev] [PATCH V2 09/15] i965: add state atom for indirect buffer

Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_context.h | 10 + src/mesa/drivers/dri/i965/brw_draw_upload.c | 32 src/mesa/drivers/dri/i965/brw_state.h| 1 + src/mesa/drivers/dri/i965/brw_state_upload.c | 2 ++ 4 files changed,

[Mesa-dev] [PATCH V2 13/15] mesa: pass indirect buffer to sw primitive restart

--- src/mesa/drivers/dri/i965/brw_primitive_restart.c | 2 +- src/mesa/vbo/vbo.h| 3 ++- src/mesa/vbo/vbo_exec_array.c | 2 +- src/mesa/vbo/vbo_primitive_restart.c | 3 ++- 4 files changed, 6 insertions(+), 4 deletions(-) diff --git

[Mesa-dev] [PATCH V2 08/15] i965: Add new defines for indirect draws

- MMIO registers for draw parameters - New bit in 3DPRIMITIVE command to enable indirection Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_defines.h | 1 + src/mesa/drivers/dri/i965/intel_reg.h | 8 2 files changed, 9 insertions(+) diff --git a/src/mesa/drivers/dri/i96

[Mesa-dev] [PATCH V2 02/15] glapi: add plumbing for GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect

Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. Signed-off-by: Chris Forbes --- src/mapi/glapi/gen/ARB_draw_indirect.xml | 45 src/mapi/glapi/gen/Makefile.am | 1 + src/mapi/glapi/gen/gl_API.xml| 4 ++- src/mesa/

[Mesa-dev] [PATCH V2 07/15] mesa: add is_indirect to _mesa_prim

Signed-off-by: Chris Forbes --- src/mesa/vbo/vbo.h| 3 ++- src/mesa/vbo/vbo_exec_array.c | 5 + 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h index 113374a..942b34a 100644 --- a/src/mesa/vbo/vbo.h +++ b/src/mesa/vbo/vbo.h @@

[Mesa-dev] [PATCH V2 04/15] mesa: Add binding point for indirect buffer

Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. Signed-off-by: Chris Forbes --- src/mesa/main/bufferobj.c| 14 ++ src/mesa/main/get.c | 4 src/mesa/main/get_hash_params.py | 2 ++ src/mesa/main/mtypes.h | 2 ++ 4 files

[Mesa-dev] [PATCH V2 06/15] vbo: Flesh out implementation of indirect draws

Based on part of Patch 2 of Christoph Bumiller's ARB_draw_indirect series. Signed-off-by: Chris Forbes --- src/mesa/vbo/vbo_exec_array.c | 216 ++ 1 file changed, 216 insertions(+) diff --git a/src/mesa/vbo/vbo_exec_array.c b/src/mesa/vbo/vbo_exec_array.c

[Mesa-dev] [PATCH V2 10/15] i965: flag new indirect buffer in brw_try_draw_prims

Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_draw.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index e6c3508..9f8ad45 100644 --- a/src/mesa/drivers/dri/i965/brw_draw.c ++

[Mesa-dev] [PATCH V2 01/15] mesa: add indirect drawing buffer parameter to draw functions

From: Christoph Bumiller Split from patch implementing ARB_draw_indirect. v2: Const-qualify the struct gl_buffer_object *indirect argument. v3: Fix up some more draw calls for new argument. v4: Fix up rebase conflicts in i965. --- src/mesa/drivers/dri/i965/brw_draw.c | 3 ++- src/

[Mesa-dev] [PATCH V2 00/15] ARB_draw_indirect for i965

This series adds ARB_draw_indirect and ARB_multi_draw_indirect for i965 Gen7+. Big changes from V1: - Split up the old 2/11 into some more sensible pieces - Discarded all the unused dlist stuff; this was a carryover from when draws were handled by the vtxfmt vtable rather than in the main dispa

[Mesa-dev] [PATCH 1/3] xorg-i915: Delete.

Acked-by: Jakob Bornecrantz Acked-by: Stéphane Marchesin --- configure.ac | 3 +- src/gallium/SConscript | 5 - src/gallium/targets/Makefile.am | 4 - src/gallium/targets/xorg-i915/Makefile.am| 76 -- src/g

[Mesa-dev] [PATCH 3/3] st/xorg: Delete.

--- Deleted files diff removed. configure.ac | 56 +- src/gallium/SConscript |3 - src/gallium/state_trackers/Makefile.am |4 - src/gallium/state_trackers/xorg/Makefile.am | 43 - src/gallium/state_trackers/x

[Mesa-dev] [PATCH 2/3] xorg-nouveau: Delete.

--- configure.ac | 3 +- src/gallium/targets/Makefile.am | 4 - src/gallium/targets/xorg-nouveau/Makefile.am | 68 src/gallium/targets/xorg-nouveau/nouveau_target.c | 20 --- src/gallium/targets/xorg-nouveau/nouveau_xorg.c

Re: [Mesa-dev] [v2 3/6] glsl: ir_serializer class for the shader cache

On 11/06/2013 10:55 PM, Paul Berry wrote: On 5 November 2013 23:45, Tapani Pälli > wrote: On 11/05/2013 07:36 PM, Paul Berry wrote: On 1 November 2013 02:16, Tapani Pälli mailto:tapani.pa...@intel.com>> wrote: + +/** + * Function

[Mesa-dev] [Bug 67672] 9.2 git, Test failure in src/gallium/drivers/llvmpipe

https://bugs.freedesktop.org/show_bug.cgi?id=67672 --- Comment #15 from James Cook --- I can reproduce the problem on my machine. I'm using the tarball at ftp://ftp.freedesktop.org/pub/mesa/${version}/MesaLib-${version}.tar.bz2 , where version is 9.2.2, with some distribution-specific patches an

Re: [Mesa-dev] [PATCH] Add DRM_MODE_PAGE_FLIP_ASYNC define

Eric Anholt writes: > Keith Packard writes: > >> This exposes the kernel API for performing asynchronous flips >> >> Signed-off-by: Keith Packard > > Reviewed-by: Eric Anholt I've pushed this to master. -- keith.pack...@intel.com pgprKBc6E8y8b.pgp Description: PGP signature __

Re: [Mesa-dev] Dropping the xorg state tracker

On Thu, Nov 7, 2013 at 3:30 AM, Stéphane Marchesin wrote: > On Wed, Nov 6, 2013 at 5:43 PM, Matt Turner wrote: >> With the removal of the r600 and radeonsi xorg targets, the only ones >> left are i915 and nouveau. Does anyone have a compelling reason to >> keep them (and the state tracker code it

[Mesa-dev] [PATCH 1/3] i965/fs: Ignore actual latency pre-reg-alloc.

We care about depth-until-program-end, as a proxy for "make sure I schedule those early instructions that open up the other things that can make progress while keeping register pressure low", not actual latency (since we're relying on the post-register-alloc scheduling to actually schedule for the

[Mesa-dev] [PATCH 3/3] i965/fs: Try a different pre-scheduling heuristic if the first spills.

Since LIFO fails on some shaders in one particular way, and non-LIFO systematically fails in another way on different kinds of shaders, try them both. and pick whichever one successfully register allocates first. Slightly prefer non-LIFO in case we produce extra dependencies in register allocation,

[Mesa-dev] [PATCH 2/3] i965/fs: Do instruction pre-scheduling just before register allocation.

Long ago, the HW_REG usage in assign_curb/urb_setup() were scheduling barriers, so we had to run scheduler before them in order for it to be able to do basically anything. Now that that's fixed, we can delay the scheduling until we go to allocate (which will make the next change less scary). ---

Re: [Mesa-dev] Dropping the xorg state tracker

On Wed, Nov 6, 2013 at 5:43 PM, Matt Turner wrote: > With the removal of the r600 and radeonsi xorg targets, the only ones > left are i915 and nouveau. Does anyone have a compelling reason to > keep them (and the state tracker code itself) around anymore? > I'm fine with removing the xorg target

[Mesa-dev] Dropping the xorg state tracker

With the removal of the r600 and radeonsi xorg targets, the only ones left are i915 and nouveau. Does anyone have a compelling reason to keep them (and the state tracker code itself) around anymore? Seems like VMware uses XA, which Rob might also use for freedreno. I'd be happy to delete them tom

Re: [Mesa-dev] [PATCH 02/11] mesa: implement GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect

On 6 November 2013 17:06, Chris Forbes wrote: > I'm hoping I don't need the save_ stuff at all, if I only enable this > in core contexts. Is that OK? > Oh, yeah, I didn't think of that. Yeah, that sounds reasonable to me. ___ mesa-dev mailing list mes

Re: [Mesa-dev] Fwd: Bug#728053: [PATCH] mesa: FTBFS: invalid alignment assumptions

On Wed, Nov 6, 2013 at 10:19 AM, Thorsten Glaser wrote: > Hi everyone, > > here’s a bugfix to make implicit alignment and padding > assumptions explicit, please apply. [sarcasm]How well does NV84 video decoding work on m68k these days anyway?[/sarcasm]

Re: [Mesa-dev] [PATCH 02/11] mesa: implement GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect

I'm hoping I don't need the save_ stuff at all, if I only enable this in core contexts. Is that OK? On Thu, Nov 7, 2013 at 1:44 PM, Paul Berry wrote: > On 4 November 2013 06:57, Brian Paul wrote: >> >> On 11/04/2013 02:09 AM, Chris Forbes wrote: >>> >>> From: Christoph Bumiller >>> >>> >>> diff

Re: [Mesa-dev] [PATCH 1/2] mesa: Add a streaming load memcpy implementation.

On 11/06/2013 02:44 PM, Eric Anholt wrote: Matt Turner writes: Uses SSE 4.1's MOVNTDQA instruction (streaming load) to read from uncached memory without polluting the cache. --- We should add runtime detection support later. I'd really like to see runtime detection with this. Effectively no

[Mesa-dev] Fwd: Bug#728053: [PATCH] mesa: FTBFS: invalid alignment assumptions

Hi everyone, here’s a bugfix to make implicit alignment and padding assumptions explicit, please apply. Thanks, //mirabilos -- 21:26⎜ cool cool, pitch ist zu hoch 21:26⎜ eingebauter chipmunk modus in dragonfly bsd │ I luv it ^^ 21:31⎜«yofuh» ich glaube ich wuerde den rechner aussm fenster werfen

Re: [Mesa-dev] [PATCH] configure.ac: Drop no-out-of-tree notice.

Hi Matt, thanks for the CC! On Tue, 2013-11-05 at 15:14 -0800, Matt Turner wrote: > We do support out of tree builds now. Indeed, I added this patch on top of the 9.2 branch and ran it through gnome-continuous, appears to build and work OK. Tested-By: Colin Walters ___

Re: [Mesa-dev] [PATCH 2/2] i965: Add an implementation of intel_miptree_map using streaming loads.

On 11/05/2013 01:35 PM, Matt Turner wrote: --- Chad has benchmark numbers, I think. Put this in the commit message: Improves performance of RoboHornet's 2D Canvas toDataURL benchmark [http://www.robohornet.org/#e=canvastodataurl] by approximately 5x on Baytrail on ChromiumOS. src/me

Re: [Mesa-dev] [PATCH 02/11] mesa: implement GL_ARB_draw_indirect and GL_ARB_multi_draw_indirect

On 4 November 2013 06:57, Brian Paul wrote: > On 11/04/2013 02:09 AM, Chris Forbes wrote: > >> From: Christoph Bumiller >> >> >> diff --git a/src/mapi/glapi/gen/ARB_draw_indirect.xml >> b/src/mapi/glapi/gen/ARB_draw_indirect.xml >> new file mode 100644 >> index 000..7de03cd >> --- /dev/null

Re: [Mesa-dev] [PATCH] Add DRM_MODE_PAGE_FLIP_ASYNC define

Keith Packard writes: > This exposes the kernel API for performing asynchronous flips > > Signed-off-by: Keith Packard Reviewed-by: Eric Anholt pgpWaOc6OxPM4.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org ht

[Mesa-dev] [PATCH] Add DRM_MODE_PAGE_FLIP_ASYNC define

This exposes the kernel API for performing asynchronous flips Signed-off-by: Keith Packard --- include/drm/drm.h | 1 + include/drm/drm_mode.h | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/include/drm/drm.h b/include/drm/drm.h index 725bf51..f0b4c16 100644 --- a/in

Re: [Mesa-dev] DEFAULT_SOFTWARE_DEPTH_BITS=31

On 11/06/2013 12:58 PM, Brian Paul wrote: On 11/06/2013 12:34 PM, burlen wrote: When I build osmesa with --with-osmesa-bits=32 I notice that I get 31 bits by way of the compile line define -DDEFAULT_SOFTWARE_DEPTH_BITS=31. What's the story with the number 31? Is 31 bits really better than 32?

Re: [Mesa-dev] [PATCH] i965: Use has_surface_tile_offset in depth/stencil alignment workaround.

Kenneth Graunke writes: > Currently, has_surface_tile_offset is equivalent to gen == 4 && !is_g4x. > > We already use it for related checks in brw_wm_surface_state.c, so it > makes sense to use it here too. It's simpler and more future-proof. > > Broadwell also lacks surface tile offsets. With

[Mesa-dev] [PATCH 3/6] radeon/llvm: Free created llvm memory buffer

v2: Fix indentation Reviewed-by: Tom Stellard --- src/gallium/drivers/radeon/radeon_llvm_util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/radeon_llvm_util.c b/src/gallium/drivers/radeon/radeon_llvm_util.c index 7192dee..f2b3e13 100644 --- a/src/gallium/drive

[Mesa-dev] [PATCH 5/6] radeonsi/compute: Dispose of LLVM module after compiling kernels

v2: Fix indentation Reviewed-by: Tom Stellard --- src/gallium/drivers/radeonsi/radeonsi_compute.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/radeonsi_compute.c b/src/gallium/drivers/radeonsi/radeonsi_compute.c index 32d2487..fff9b76 100644 --- a/src/gallium

[Mesa-dev] [PATCH 4/6] radeonsi/compute: Free program and program.kernels on shutdown

v2: Fix indentation Reviewed-by: Tom Stellard --- src/gallium/drivers/radeonsi/radeonsi_compute.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_compute.c b/src/gallium/drivers/radeonsi/radeonsi_compute.c index 265dbd7.

[Mesa-dev] [PATCH 6/6] gallium/pipe_loader: un-reference udev resources when we're done with them.

Reviewed-by: Tom Stellard --- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c index 339d7bf..927fb24 100644 --- a/src/gallium/auxil

[Mesa-dev] [PATCH 2/6] radeon/llvm: Free libelf resources

v2: Fix indentation Reviewed-by: Tom Stellard --- src/gallium/drivers/radeon/radeon_llvm_emit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c b/src/gallium/drivers/radeon/radeon_llvm_emit.c index 8bf278b..d2e5642 100644 --- a/src/gallium/dr

[Mesa-dev] [PATCH 1/6] radeon/llvm: fix spelling error

Reviewed-by: Tom Stellard --- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c index 286ccdd..57026bf 100644 --- a/src/

[Mesa-dev] [PATCH 0/6 v2] radeon: Plug some memory leaks

Turns out that I don't have commit access to Mesa, just piglit. Feel free to push if they look good. I decided to have some fun and hooked valgrind up to my SI while running a few OpenCL tests in piglit. This is the first batch of fixes. Aaron Watry (6): radeon/llvm: fix spelling error radeo

Re: [Mesa-dev] [PATCH 1/2] mesa: Add a streaming load memcpy implementation.

Matt Turner writes: > Uses SSE 4.1's MOVNTDQA instruction (streaming load) to read from > uncached memory without polluting the cache. > --- > We should add runtime detection support later. I'd really like to see runtime detection with this. Effectively not supporting this on 32-bit sucks, and

Re: [Mesa-dev] [PATCH 00/11] Implement GL_ARB_vertex_attrib_binding

Fredrik Höglund writes: > So here's ARB_vertex_attrib_binding, take two. > > This incorporates all the feedback from Eric and Ian. > > Patches 6, 7, and 8 in the previous series have now been squashed into > patch 5. This is unfortunate, since patch 5 was already larger than > I would have liked

Re: [Mesa-dev] [PATCH] gallivm: deduplicate some indirect register address code

Looks good. Reviewed-by: Zack Rusin - Original Message - > From: Roland Scheidegger > > There's only one minor functional change, for immediates the pixel offsets > are no longer added since the values are all the same for all elements in > any case (it might be better if those weren't

Re: [Mesa-dev] [PATCH 0/7] Add ARB_texture_view

Patches 1-4, 6 are: Reviewed-by: Chris Forbes With the changes discussed for teximagemultisample and pulling the view parameter setting out into a helper function, patch 5 is also: Reviewed-by: Chris Forbes On Wed, Nov 6, 2013 at 11:59 AM, Courtney Goeltzenleuchter wrote: > The following pat

Re: [Mesa-dev] [PATCH 5/7] mesa: Update TexStorage to support ARB_texture_view

The usual way is you send out a complete new series marked V2 after incorporating all the review comments etc. On Thu, Nov 7, 2013 at 11:04 AM, Courtney Goeltzenleuchter < court...@lunarg.com> wrote: > Okay, making that change, the commit's flow better if patches 5,6,7 become > new 5,6,7,8. > >

Re: [Mesa-dev] [PATCH 5/7] mesa: Update TexStorage to support ARB_texture_view

Okay, making that change, the commit's flow better if patches 5,6,7 become new 5,6,7,8. What's the recommended process for superseding the previous patches for these new ones? Courtney On Wed, Nov 6, 2013 at 2:04 PM, Courtney Goeltzenleuchter < court...@lunarg.com> wrote: > Ah, I get it, the s

Re: [Mesa-dev] [PATCH 3/4] mesa: fix build on kFreeBSD

Thanks, I've pushed all 4 patches. 2013/11/6 Fabio Pedretti : > Done, I also improved commit message of patches 3 and 4. Updated patches > follow. > >>I think we could simplify this a bit. >> >>2013/11/5 Fabio Pedretti : >>> From: Aurelien Jarno >>> From: Cyril Brulebois >>> >>> mesa fails to bu

Re: [Mesa-dev] [PATCH 5/7] mesa: Update TexStorage to support ARB_texture_view

Ah, I get it, the switch statement after. Yeah, that could make sense as a helper wouldn't it. I'll look at that. On Wed, Nov 6, 2013 at 1:42 PM, Chris Forbes wrote: > Your change to teximagemultisample just has a bunch of spurious stuff for > other targets. not harmful -- it will never get rea

Re: [Mesa-dev] DEFAULT_SOFTWARE_DEPTH_BITS=31

On 11/06/2013 12:34 PM, burlen wrote: When I build osmesa with --with-osmesa-bits=32 I notice that I get 31 bits by way of the compile line define -DDEFAULT_SOFTWARE_DEPTH_BITS=31. What's the story with the number 31? Is 31 bits really better than 32? IIRC, 32 bit Z never worked properly becaus

Re: [Mesa-dev] [v2 3/6] glsl: ir_serializer class for the shader cache

On 5 November 2013 23:45, Tapani Pälli wrote: > On 11/05/2013 07:36 PM, Paul Berry wrote: > > On 1 November 2013 02:16, Tapani Pälli wrote: > >> >> + >> +/** >> + * Function to create an unique string for a ir_variable. This is >> + * used by variable dereferences to indicate the exact ir_varia

Re: [Mesa-dev] [PATCH 11/37] scons: build mesa/program as a convinience library

On 02/11/13 19:00, Emil Velikov wrote: > * Demangle the large and complex mesa/SConscript. > * Make use of source file lists in Makefile.sources. > * Makes the build systems symmetric. > > Signed-off-by: Emil Velikov Planning to drop this patch and revisit the idea of sharing the sources list at

Re: [Mesa-dev] [PATCH 5/7] mesa: Update TexStorage to support ARB_texture_view

Your change to teximagemultisample just has a bunch of spurious stuff for other targets. not harmful -- it will never get reached -- but spurious. It might be worth pulling both blocks out into a shared helper. On Thu, Nov 7, 2013 at 9:32 AM, Courtney Goeltzenleuchter < court...@lunarg.com> wr

Re: [Mesa-dev] [PATCH 20/37] targets/r600: move drm_target.c to a common folder

On 06/11/13 20:26, Adrian M Negreanu wrote: > On Sat, Nov 2, 2013 at 9:00 PM, Emil Velikov wrote: >> ... and symlink to each target. >> Make automake's subdir-objects work for r600. > I think r600 and r300 were removed from the tree[1]. > git am complains about missing dirs >error: src/gallium

Re: [Mesa-dev] [v2 5/6] glsl: functions to serialize gl_shader and gl_shader_program

On 6 November 2013 00:59, Tapani Pälli wrote: > On 11/06/2013 12:02 AM, Paul Berry wrote: > > On 1 November 2013 02:16, Tapani Pälli wrote: > >> +static void >> +calc_item(const void *key, void *data, void *closure) >> > > How about "increment_count" for the name of this function? > > > ok > >

Re: [Mesa-dev] [PATCH 5/7] mesa: Update TexStorage to support ARB_texture_view

Correct and I check_multisample_target checks for that. And we never get to this code if using a PROXY target. Or did I miss something? On Wed, Nov 6, 2013 at 1:14 PM, Chris Forbes wrote: > The only interesting targets in teximagemultisample are > GL_TEXTURE_2D_MULTISAMPLE and GL_TEXTURE_2D_MUL

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

On Wed, Nov 6, 2013 at 9:19 PM, Paul Berry wrote: > On 6 November 2013 11:24, Erik Faye-Lund wrote: >> >> On Wed, Nov 6, 2013 at 7:49 PM, Paul Berry >> wrote: >> > On 6 November 2013 09:35, Erik Faye-Lund wrote: >> >> >> >> Sorry for the late reply. >> >> >> >> On Fri, Nov 1, 2013 at 4:14 PM, T

Re: [Mesa-dev] [PATCH 20/37] targets/r600: move drm_target.c to a common folder

On Sat, Nov 2, 2013 at 9:00 PM, Emil Velikov wrote: > ... and symlink to each target. > Make automake's subdir-objects work for r600. I think r600 and r300 were removed from the tree[1]. git am complains about missing dirs error: src/gallium/targets/r600/xorg/Makefile.am: does not exist in inde

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

On 6 November 2013 11:24, Erik Faye-Lund wrote: > On Wed, Nov 6, 2013 at 7:49 PM, Paul Berry > wrote: > > On 6 November 2013 09:35, Erik Faye-Lund wrote: > >> > >> Sorry for the late reply. > >> > >> On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote: > >> > On 11/01/2013 03:31 PM, Erik Faye-Lund wr

Re: [Mesa-dev] [PATCH 5/7] mesa: Update TexStorage to support ARB_texture_view

The only interesting targets in teximagemultisample are GL_TEXTURE_2D_MULTISAMPLE and GL_TEXTURE_2D_MULTISAMPLE_ARRAY. On Thu, Nov 7, 2013 at 8:55 AM, Courtney Goeltzenleuchter wrote: > TexStorage and TexStorageMultisample updates texture object > state needed by ARB_texture_view extension. > > S

[Mesa-dev] [PATCH 5/7] mesa: Update TexStorage to support ARB_texture_view

TexStorage and TexStorageMultisample updates texture object state needed by ARB_texture_view extension. Set appropriate TextureView state in texture object. mesa: Add ARB_texture_view Signed-off-by: Courtney Goeltzenleuchter --- src/mesa/main/teximage.c | 38 +

[Mesa-dev] [PATCH] gallivm: deduplicate some indirect register address code

From: Roland Scheidegger There's only one minor functional change, for immediates the pixel offsets are no longer added since the values are all the same for all elements in any case (it might be better if those weren't stored as soa vectors in the first place maybe). --- src/gallium/auxiliary/g

[Mesa-dev] DEFAULT_SOFTWARE_DEPTH_BITS=31

When I build osmesa with --with-osmesa-bits=32 I notice that I get 31 bits by way of the compile line define -DDEFAULT_SOFTWARE_DEPTH_BITS=31. What's the story with the number 31? Is 31 bits really better than 32? ___ mesa-dev mailing list mesa-dev@lis

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

On 6 November 2013 11:24, Erik Faye-Lund wrote: > On Wed, Nov 6, 2013 at 7:49 PM, Paul Berry > wrote: > > On 6 November 2013 09:35, Erik Faye-Lund wrote: > >> > >> Sorry for the late reply. > >> > >> On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote: > >> > On 11/01/2013 03:31 PM, Erik Faye-Lund wr

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

On Wed, Nov 6, 2013 at 7:49 PM, Paul Berry wrote: > On 6 November 2013 09:35, Erik Faye-Lund wrote: >> >> Sorry for the late reply. >> >> On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote: >> > On 11/01/2013 03:31 PM, Erik Faye-Lund wrote: >> >> >> >> >> >> Won't using the git-sha1 as a compatibility

Re: [Mesa-dev] [PATCH 0/6] radeon: Plug some memory leaks

On Wed, Nov 06, 2013 at 12:59:09PM -0600, Aaron Watry wrote: > On Wed, Nov 6, 2013 at 12:15 PM, Tom Stellard wrote: > > These look good, but the indentation seems wrong in patches 2 through 6. > > An artifact of expanding tabs to 4 spaces in the IDE... Although I'd > argue that patch 6 is correc

Re: [Mesa-dev] [PATCH 0/6] radeon: Plug some memory leaks

On Wed, Nov 6, 2013 at 12:15 PM, Tom Stellard wrote: > These look good, but the indentation seems wrong in patches 2 through 6. An artifact of expanding tabs to 4 spaces in the IDE... Although I'd argue that patch 6 is correct given that the portion of the file affected already uses tabs for spa

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

On 6 November 2013 09:35, Erik Faye-Lund wrote: > Sorry for the late reply. > > On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote: > > On 11/01/2013 03:31 PM, Erik Faye-Lund wrote: > >> > >> > >> Won't using the git-sha1 as a compatibility-criteria cause issues for > >> developers with local changes?

Re: [Mesa-dev] [PATCH 0/6] radeon: Plug some memory leaks

These look good, but the indentation seems wrong in patches 2 through 6. -Tom On Wed, Nov 06, 2013 at 10:36:49AM -0600, Aaron Watry wrote: > I decided to have some fun and hooked valgrind up to my 7850 while running > a few OpenCL tests in piglit. This is the first batch of fixes. > > Aaron Watr

Re: [Mesa-dev] [PATCH 2/6] radeon/llvm: Free libelf resources

On Wed, Nov 06, 2013 at 10:36:51AM -0600, Aaron Watry wrote: > --- > src/gallium/drivers/radeon/radeon_llvm_emit.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c > b/src/gallium/drivers/radeon/radeon_llvm_emit.c > index 8bf278b..20b3206

Re: [Mesa-dev] [PATCH 1/6] glsl: Implement parser support for atomic counters.

On Tue, Oct 29, 2013 at 4:37 PM, Francisco Jerez wrote: > v2: Mark atomic counters as read-only variables. Move offset overlap > code to the linker. Use the contains_atomic() convenience method. > v3: Use pointer to integer instead of non-const reference. Add > comment so we remember to

Re: [Mesa-dev] [v2 6/6] mesa: OES_get_program_binary functionality

Sorry for the late reply. On Fri, Nov 1, 2013 at 4:14 PM, Tapani wrote: > On 11/01/2013 03:31 PM, Erik Faye-Lund wrote: >> >> >> Won't using the git-sha1 as a compatibility-criteria cause issues for >> developers with local changes? I'm not so worried about this for >> OES_get_program_binary itse

Re: [Mesa-dev] Fix crashes with static LLVM

Dear Tom, Tom Stellard schrieb am 06.11.2013 01:24: > On Wed, Oct 23, 2013 at 04:26:18PM -0400, Tom Stellard wrote: >> The attached patches introduce linker scripts to the pipe-loader and >> egl-static targets. The linker scripts prevents these targets from >> exporting LLVM (and other) symbols th

Re: [Mesa-dev] 9.2.2 OSMesa classic 80 new regressions in VTK

On 11/05/2013 09:42 AM, Ian Romanick wrote: On 11/05/2013 09:32 AM, burlen wrote: Upgrading from 9.2.0 to 9.2.2 with OSMesa classic I'm seeing 80 new regressions in VTK. http://open.cdash.org/viewTest.php?onlyfailed&buildid=3087854 click "Failed" to see an image diff. Maybe related to line rende

[Mesa-dev] [PATCH] vl: use a separate context for shader based decode v2

From: Christian König This makes VDPAU thread save again. v2: fix some memory leaks reported by Aaron Watry. Signed-off-by: Christian König --- src/gallium/auxiliary/vl/vl_mpeg12_decoder.c | 184 ++- src/gallium/auxiliary/vl/vl_mpeg12_decoder.h | 1 + 2 files changed

[Mesa-dev] [PATCH 4/6] pipe-loader: add freedreno platform IDs

Signed-off-by: Lucas Stach --- include/platform_ids/platform_driver_map.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/platform_ids/platform_driver_map.h b/include/platform_ids/platform_driver_map.h index c428b81349e6..68595ef0a2f7 100644 --- a/include/platform_ids/platform_d

[Mesa-dev] [PATCH 1/6] gbm: Support non-PCI devices

From: Thierry Reding When probing non-PCI DRM devices, such as those found in a lot of SoCs, GBM errors out because it expects the device to have an associated PCI ID which can be used to lookup the driver name in a table. This patch removes this restriction by using the driver name from the drm

[Mesa-dev] [PATCH 4/6] radeonsi/compute: Free program and program.kernels on shutdown

--- src/gallium/drivers/radeonsi/radeonsi_compute.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_compute.c b/src/gallium/drivers/radeonsi/radeonsi_compute.c index 265dbd7..28a3f17 100644 --- a/src/gallium/drivers/radeon

[Mesa-dev] [PATCH 2/6] radeon/llvm: Free libelf resources

--- src/gallium/drivers/radeon/radeon_llvm_emit.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/drivers/radeon/radeon_llvm_emit.c b/src/gallium/drivers/radeon/radeon_llvm_emit.c index 8bf278b..20b3206 100644 --- a/src/gallium/drivers/radeon/radeon_llvm_emit.c +++ b/src/galliu

[Mesa-dev] [PATCH 6/6] gallium/pipe_loader: un-reference udev resources when we're done with them.

--- src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c b/src/gallium/auxiliary/pipe-loader/pipe_loader_drm.c index 339d7bf..927fb24 100644 --- a/src/gallium/auxiliary/pipe-loader/pipe_loade

[Mesa-dev] [PATCH 3/6] radeon/llvm: Free created llvm memory buffer

--- src/gallium/drivers/radeon/radeon_llvm_util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeon/radeon_llvm_util.c b/src/gallium/drivers/radeon/radeon_llvm_util.c index 7192dee..aec5d67 100644 --- a/src/gallium/drivers/radeon/radeon_llvm_util.c +++ b/src/gallium/d

[Mesa-dev] [PATCH 1/6] radeon/llvm: fix spelling error

--- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c b/src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c index 286ccdd..57026bf 100644 --- a/src/gallium/drivers/radeon/rade

[Mesa-dev] [PATCH 5/6] radeonsi/compute: Dispose of LLVM module after compiling kernels

--- src/gallium/drivers/radeonsi/radeonsi_compute.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/radeonsi/radeonsi_compute.c b/src/gallium/drivers/radeonsi/radeonsi_compute.c index 28a3f17..6531bcd 100644 --- a/src/gallium/drivers/radeonsi/radeonsi_compute.c +++ b/src/g

[Mesa-dev] [PATCH 0/6] radeon: Plug some memory leaks

I decided to have some fun and hooked valgrind up to my 7850 while running a few OpenCL tests in piglit. This is the first batch of fixes. Aaron Watry (6): radeon/llvm: fix spelling error radeon/llvm: Free libelf resources radeon/llvm: Free created llvm memory buffer radeonsi/compute: Free

[Mesa-dev] [PATCH 5/6] gallium: gbm/egl: support GBM surface extensions on DRM

Let's applications like Weston create EGL onscreen-surfaces on bare DRM devices. Signed-off-by: Lucas Stach --- src/gallium/state_trackers/egl/drm/native_drm.c| 11 ++ src/gallium/state_trackers/gbm/gbm_drm.c | 44 ++ .../state_trackers/gbm/gbm_gallium_drmin

[Mesa-dev] [PATCH 2/6] gallium/targets: build freedreno pipe

Signed-off-by: Lucas Stach --- src/gallium/targets/pipe-loader/Makefile.am | 16 src/gallium/targets/pipe-loader/pipe_freedreno.c | 21 + 2 files changed, 37 insertions(+) create mode 100644 src/gallium/targets/pipe-loader/pipe_freedreno.c diff --git a/

[Mesa-dev] [PATCH 3/6] gallium: pipe-loader: make aware of platform DRM devices

Allows to load gallium pipes for ARM DRM drivers. Signed-off-by: Lucas Stach --- include/platform_ids/platform_driver_map.h | 18 src/gallium/auxiliary/pipe-loader/pipe_loader.h| 1 + .../auxiliary/pipe-loader/pipe_loader_drm.c| 53 ++ 3 files ch

[Mesa-dev] [PATCH 6/6] st/egl: fix drm surface size init

Signed-off-by: Lucas Stach --- src/gallium/state_trackers/egl/drm/modeset.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/gallium/state_trackers/egl/drm/modeset.c b/src/gallium/state_trackers/egl/drm/modeset.c index dc71a761053b..11b6db1949c6 100644 --- a/src/gallium/

[Mesa-dev] Problem getting a 32-bit X11 visual when porting from GLX to EGL

Hello all, I'm attempting to port our GLX based code to EGL/X11, as a first step towards being ready for Wayland, and I've hit a snag. We use an X11 compositor to get translucent windows blending one atop the other, and I carefully select a 32 bit RGBA visual (ID 0x64 on my system) instead of a

Re: [Mesa-dev] [PATCH] vl: use a separate context for shader based decode

On Wed, Nov 6, 2013 at 8:13 AM, Christian König wrote: > From: Christian König > > This makes VDPAU thread save again. > > Signed-off-by: Christian König > --- > src/gallium/auxiliary/vl/vl_mpeg12_decoder.c | 180 > ++- > src/gallium/auxiliary/vl/vl_mpeg12_decoder.h |

Re: [Mesa-dev] [PATCH] vl: use a separate context for shader based decode

I haven't looked in-depth at the rest of the patch, but I don't see anywhere in vl_mpeg12_destroy that you are actually destroying the context that you create in vl_create_mpeg12_decoder. Would I be correct in assuming that this is leaked memory? --Aaron On Wed, Nov 6, 2013 at 8:13 AM, Christian

Re: [Mesa-dev] [PATCH] mesa: for GLSL_DUMP_ON_ERROR, also dump the info log

LGTM. Jose - Original Message - > Since it's helpful to know why the shader did not compile. > Also, call fflush() for Windows. > --- > src/mesa/main/shaderapi.c |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c > index 7

Re: [Mesa-dev] [PATCH] gallivm: fix indirect addressing of inputs

Looks good. Though I thought we had fixed this once before. Could you double check there are no similar issues with the remaining register files (output, etc)? Jose - Original Message - > From: Roland Scheidegger > > We weren't adding the soa offsets when constructing the indices > f

  1   2   >