Re: [Mesa-dev] [PATCH] i965: Fast texture upload now supports all levels

2013-10-11 Thread Chad Versace
On 10/11/2013 10:17 AM, Courtney Goeltzenleuchter wrote: Support all levels of a supported texture format. --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/intel_tex_subimage.c b/src

Re: [Mesa-dev] [PATCH 10/15] nouveau: Build the driver into the shared mesa_dri_drivers.so.

2013-10-11 Thread Emil Velikov
On 12/10/13 02:03, Eric Anholt wrote: > v2: drop dridir now that it's unused. > v3: Consistently put spaces around += in the updated Makefile.am block. > v4: Set a global driverAPI variable so loaders don't have to update to > createNewScreen2() (though they may want to for thread safety). > >

Re: [Mesa-dev] [PATCH] i965: add XRGB to fast texture upload

2013-10-11 Thread Chad Versace
On 10/11/2013 10:16 AM, Courtney Goeltzenleuchter wrote: MESA_FORMAT_XRGB is equivalent to MESA_FORMAT_ARGB in terms of storage on the device, so okay to use this optimized copy routine. --- src/mesa/drivers/dri/i965/intel_tex_subimage.c | 3 ++- 1 file changed, 2 insertions(+), 1 dele

Re: [Mesa-dev] [PATCH 09/15] i965: Build the driver into a shared mesa_dri_drivers.so .

2013-10-11 Thread Emil Velikov
On 12/10/13 02:03, Eric Anholt wrote: > Previously, we've split things such that mesa core is in libdricore, > exposing the whole Mesa core interface in the global namespace, and the > i965_dri.so code all links against that. Along with polluting application > namespace terribly, it requires extra

Re: [Mesa-dev] [PATCH 07/15] dri: Pass in the dlsym()ed driver extension to screen creation.

2013-10-11 Thread Emil Velikov
On 12/10/13 02:03, Eric Anholt wrote: > This will allow a megadrivers build to reference the actual driver being > loaded from the shared dri_util screen creation code. > > Reviewed-by: Matt Turner > --- > include/GL/internal/dri_interface.h| 27 +++-- > src/egl/drivers/dri2/

[Mesa-dev] [PATCH] glsl: Use more portable bash invocation construct.

2013-10-11 Thread Vinson Lee
Fixes 'make check' on distros where bash is not at /bin/bash. Signed-off-by: Vinson Lee --- src/glsl/tests/lower_jumps/create_test_cases.py | 2 +- src/glsl/tests/lower_jumps/lower_breaks_1.opt_test | 2 +- src/glsl/tests/lower_jumps/lower_breaks_2.op

Re: [Mesa-dev] EXT_image_dma_buf_import FD ownership

2013-10-11 Thread Chad Versace
On 10/11/2013 06:06 PM, John Sheu wrote: On Fri, Oct 11, 2013 at 5:54 PM, Chad Versace wrote: Yes. Let's update the spec to have a saner interface before we lose a handle on all the consumers. Sweet. To my knowledge, there exists only two implementations. ARM ships an implementation for An

Re: [Mesa-dev] [PATCH] glsl: Add new GLSL 1.50 constants.

2013-10-11 Thread Paul Berry
On 11 October 2013 17:53, Matt Turner wrote: > On Fri, Oct 11, 2013 at 5:29 PM, Paul Berry > wrote: > > This patch populates the following built-in GLSL 1.50 variables based > > on constants stored in ctx->Const: > > > > - gl_MaxVertexOutputComponents > > - gl_MaxGeometryInputComponents > > - gl

[Mesa-dev] [PATCH 15/15] mesa: Remove dricore from the build.

2013-10-11 Thread Eric Anholt
No driver uses it any more, and it's been replaced by megadrivers. Reviewed-by: Matt Turner --- configure.ac | 11 - src/mesa/Makefile.am | 6 +-- src/mesa/drivers/dri/Makefile.am | 2 +- src/mesa/drivers/dri/i965/Makefile.am | 2 +- src/mesa

[Mesa-dev] [PATCH 04/15] glx: Add an optional function call for getting the DRI driver interface.

2013-10-11 Thread Eric Anholt
The previous interface relied on a static struct, which meant that the driver didn't get a chance to edit the struct before the struct got used. For megadrivers, I want struct specific to the driver being loaded. v2: Fix the prototype in the docs (caught by Marek). Since the driver name was i

[Mesa-dev] [PATCH 14/15] swrast: Build the driver into the shared mesa_dri_drivers.so.

2013-10-11 Thread Eric Anholt
v2: drop dridir now that it's unused. v3: Fix linking after rebase when building just swrast from classic but a drm-using gallium driver. v4: Consistently put spaces around += in the updated Makefile.am block. v5: Set a global driverAPI variable so loaders don't have to update to createNewS

[Mesa-dev] [PATCH 13/15] radeon: Build the driver into the shared mesa_dri_drivers.so.

2013-10-11 Thread Eric Anholt
This required some reordering of headers to ensure that the symbol name redefines happened before any prototypes. v2: drop dridir now that it's unused. v3: Consistently put spaces around += in the updated Makefile.am blocks. v4: Set a global driverAPI variable so loaders don't have to update to

[Mesa-dev] [PATCH 12/15] i915: Build the driver into the shared mesa_dri_drivers.so.

2013-10-11 Thread Eric Anholt
i915 has symbols for formerly-shared code that conflict with i965, so we define them away using gen-symbol-redefs.py. Options considered: - This option. Downsides: The symbols in profiling and debugging don't match the source. The symbol list may change in the future and we won't notice wit

[Mesa-dev] [PATCH 08/15] dri: Implement a DRI vtable extension to replace the global driDriverAPI.

2013-10-11 Thread Eric Anholt
As we move to megadrivers, we are unable to build multiple drivers with the same public global symbol per driver (Think an X Server with an intel and a nouveau driver, and the X Server implementing indirect for both -- we have to actually talk to the right driver). By slipping the driDriverAPI vta

[Mesa-dev] [PATCH 09/15] i965: Build the driver into a shared mesa_dri_drivers.so .

2013-10-11 Thread Eric Anholt
Previously, we've split things such that mesa core is in libdricore, exposing the whole Mesa core interface in the global namespace, and the i965_dri.so code all links against that. Along with polluting application namespace terribly, it requires extra PLT indirections and prevents LTO. Instead,

[Mesa-dev] [PATCH 11/15] dri: Add a tool for generating #defines to namespace driver global symbols.

2013-10-11 Thread Eric Anholt
Acked-by: Matt Turner --- src/mesa/drivers/dri/gen-symbol-redefs.py | 68 +++ 1 file changed, 68 insertions(+) create mode 100755 src/mesa/drivers/dri/gen-symbol-redefs.py diff --git a/src/mesa/drivers/dri/gen-symbol-redefs.py b/src/mesa/drivers/dri/gen-symbol-redef

[Mesa-dev] [PATCH 07/15] dri: Pass in the dlsym()ed driver extension to screen creation.

2013-10-11 Thread Eric Anholt
This will allow a megadrivers build to reference the actual driver being loaded from the shared dri_util screen creation code. Reviewed-by: Matt Turner --- include/GL/internal/dri_interface.h| 27 +++-- src/egl/drivers/dri2/egl_dri2.c| 27 + src/eg

[Mesa-dev] [PATCH 10/15] nouveau: Build the driver into the shared mesa_dri_drivers.so.

2013-10-11 Thread Eric Anholt
v2: drop dridir now that it's unused. v3: Consistently put spaces around += in the updated Makefile.am block. v4: Set a global driverAPI variable so loaders don't have to update to createNewScreen2() (though they may want to for thread safety). Reviewed-by: Matt Turner (v2) --- configure.ac

[Mesa-dev] [PATCH 06/15] gbm: Add support for the new __driDriverGetExtensions interface.

2013-10-11 Thread Eric Anholt
--- src/gbm/backends/dri/gbm_dri.c | 15 ++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/src/gbm/backends/dri/gbm_dri.c b/src/gbm/backends/dri/gbm_dri.c index f7da79c..0cab549 100644 --- a/src/gbm/backends/dri/gbm_dri.c +++ b/src/gbm/backends/dri/gbm_dri.c @@ -171,6 +

[Mesa-dev] [PATCH 05/15] egl: Add an optional function call for getting the DRI driver interface.

2013-10-11 Thread Eric Anholt
v2: Fix asprintf error checking. Reviewed-by: Matt Turner (v1) --- src/egl/drivers/dri2/egl_dri2.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c index 04ab564..2c01323 100644 --- a/src/e

[Mesa-dev] [PATCH 03/15] dri: Move driver config options to dri driver extensions.

2013-10-11 Thread Eric Anholt
This way they aren't all sitting in the global namespace (with the same name per driver). Reviewed-by: Matt Turner --- src/gallium/state_trackers/dri/common/dri_screen.c | 10 +++--- src/gallium/state_trackers/dri/common/dri_screen.h | 2 ++ src/gallium/state_trackers/dri/drm/dri2.c

[Mesa-dev] [PATCH 02/15] dri: Allow config options to be passed to the loader through extensions.

2013-10-11 Thread Eric Anholt
Turns out already we have this nice mechanism for providing optional things from the driver to the loader, and I was going to have to rename the public global symbol to avoid conflicts when doing megadrivers. While the former __driConfigOptions is technically loader interface, this is the only loa

[Mesa-dev] [PATCH 01/15] glx: Move the driver extension-loading to a helper function.

2013-10-11 Thread Eric Anholt
I'm planning on doing driver extension parsing from 3 places, and making the extension loading step a bit longer. Reviewed-by: Matt Turner --- src/glx/dri2_glx.c | 6 ++ src/glx/dri_common.c | 14 ++ src/glx/dri_common.h | 2 ++ 3 files changed, 18 insertions(+), 4 deletions(

[Mesa-dev] Updated megadrivers series (megadrivers-6)

2013-10-11 Thread Eric Anholt
I've also updated the set of driver changes to set a global variable so that the loader doesn't *have* to update to createNewScreen2. This in particular makes the change for the X Server that I just sent out backportable, since the new structs in dri_interface.h meant that you'd need a new Mesa (o

Re: [Mesa-dev] EXT_image_dma_buf_import FD ownership

2013-10-11 Thread Chad Versace
On 10/11/2013 03:29 PM, John Sheu wrote: Hello folks: About the ownership of dmabuf file descriptors that are passed into EGL. I'm looking in particular at this blurb from the spec: * If is EGL_LINUX_DMA_BUF_EXT and eglCreateImageKHR fails, EGL does not retain ownership of

Re: [Mesa-dev] [PATCH] glsl: Add new GLSL 1.50 constants.

2013-10-11 Thread Matt Turner
On Fri, Oct 11, 2013 at 5:29 PM, Paul Berry wrote: > This patch populates the following built-in GLSL 1.50 variables based > on constants stored in ctx->Const: > > - gl_MaxVertexOutputComponents > - gl_MaxGeometryInputComponents > - gl_MaxGeometryOutputComponents > - gl_MaxFragmentInputComponents

Re: [Mesa-dev] [PATCH] nv50: report only 16 texure_samplers

2013-10-11 Thread Emil Velikov
On 12/10/13 01:25, Roland Scheidegger wrote: > Am 12.10.2013 02:02, schrieb Brian Paul: >> On 10/11/2013 10:44 AM, Emil Velikov wrote: >>> Current mesa code(cso and drivers) expect and use only up-to 16 >>> texture samplers. >>> >>> Verbatum copy from the nvc0 driver. >>> >>> Cc "9.1" >>> Cc "9.2"

[Mesa-dev] [PATCH] glsl: Add new GLSL 1.50 constants.

2013-10-11 Thread Paul Berry
This patch populates the following built-in GLSL 1.50 variables based on constants stored in ctx->Const: - gl_MaxVertexOutputComponents - gl_MaxGeometryInputComponents - gl_MaxGeometryOutputComponents - gl_MaxFragmentInputComponents - gl_MaxGeometryTextureImageUnits - gl_MaxGeometryOutputVertices

Re: [Mesa-dev] [PATCH] nv50: report only 16 texure_samplers

2013-10-11 Thread Roland Scheidegger
Am 12.10.2013 02:02, schrieb Brian Paul: > On 10/11/2013 10:44 AM, Emil Velikov wrote: >> Current mesa code(cso and drivers) expect and use only up-to 16 >> texture samplers. >> >> Verbatum copy from the nvc0 driver. >> >> Cc "9.1" >> Cc "9.2" >> Bugzilla: https://bugs.freedesktop.org/show_bug.cg

[Mesa-dev] [PATCH 4/4] i965: Add lowering pass for splitting textureGatherOffsets

2013-10-11 Thread Chris Forbes
Rewrites textureGatherOffsets(s, p, offsets) into gvec4( textureGatherOffset(s, p, offsets[0]).w, textureGatherOffset(s, p, offsets[1]).w, textureGatherOffset(s, p, offsets[2]).w, textureGatherOffset(s, p, offsets[3]).w ) Signed-off-by: Chris Forbes --- src/mesa

[Mesa-dev] [PATCH 3/4] i965: Add asserts to ensure that ir_tg4 offset arrays are lowered

2013-10-11 Thread Chris Forbes
We don't have a message that does 4 independent offsets; a lowering pass needs to lower it to 4 normal gather4s before reaching this point. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 +++ src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 3 +++ 2 files chan

[Mesa-dev] [PATCH 2/4] glsl: add signatures for textureGatherOffsets()

2013-10-11 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/glsl/builtin_functions.cpp | 30 ++ 1 file changed, 30 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index 1b23677..45fff4c 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/glsl/buil

[Mesa-dev] [PATCH 1/4] glsl: add support for texture functions with offset arrays

2013-10-11 Thread Chris Forbes
This is needed for textureGatherOffsets() Signed-off-by: Chris Forbes --- src/glsl/builtin_functions.cpp | 9 + 1 file changed, 9 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index deedddb..1b23677 100644 --- a/src/glsl/builtin_functions.cpp

[Mesa-dev] [PATCH 0/4] ARB_gpu_shader5 textureGather*, Part 4

2013-10-11 Thread Chris Forbes
This series adds support for textureGatherOffsets, by splitting it into four textureGatherOffset operations and collecting the w component of each result. This is necessary because the hardware has no message that can do this directly. ___ mesa-dev mai

Re: [Mesa-dev] [PATCH] nv50: report only 16 texure_samplers

2013-10-11 Thread Brian Paul
On 10/11/2013 10:44 AM, Emil Velikov wrote: Current mesa code(cso and drivers) expect and use only up-to 16 texture samplers. Verbatum copy from the nvc0 driver. Cc "9.1" Cc "9.2" Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=70212 Reported-by: Aaron Watry Signed-off-by: Emil Veliko

Re: [Mesa-dev] EXT_image_dma_buf_import FD ownership

2013-10-11 Thread Eric Anholt
John Sheu writes: > Hello folks: > > About the ownership of dmabuf file descriptors that are passed into EGL. > I'm looking in particular at this blurb from the spec: > >* If is EGL_LINUX_DMA_BUF_EXT and eglCreateImageKHR fails, > EGL does not retain ownership of the file descr

[Mesa-dev] [PATCH] configure.ac: drop obsolete variable HAVE_COMMON_DRI

2013-10-11 Thread Emil Velikov
The original intent of the variable was to prevent adding libdrm dependency for non drm drivers (swrast). This is already handled with __NOT_HAVE_DRM_H, and with the recent merge of the dri_util and drisw_util code this variable has started causing build issues. Eg. the following will fail $ ./aut

Re: [Mesa-dev] [PATCH] i965/fs: Remove bogus field prog_data->dispatch_width.

2013-10-11 Thread Eric Anholt
Paul Berry writes: > Despite the name, this field wasn't being set to the dispatch width at > all; it was always 8. The only place it was used was that the > constant buffer read length was aligned to it, and as far as I can > tell from the docs, there is no need to align this value to the > dis

[Mesa-dev] [Bug 69437] Composite Bypass no longer works

2013-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=69437 Kristian Høgsberg changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH 2/2] configure.ac: Don't check for awk, grep, nm.

2013-10-11 Thread Matt Turner
Not used since d53901c6. --- configure.ac | 12 1 file changed, 12 deletions(-) diff --git a/configure.ac b/configure.ac index 5faae97..c68e14b 100644 --- a/configure.ac +++ b/configure.ac @@ -1256,19 +1256,7 @@ dnl dnl XA configuration dnl if test "x$enable_xa" = xyes; then -AC_P

[Mesa-dev] [PATCH 1/2] configure.ac: Don't check for cross compiling.

2013-10-11 Thread Matt Turner
Dead since c845140a. --- configure.ac | 2 -- 1 file changed, 2 deletions(-) diff --git a/configure.ac b/configure.ac index 0d082d2..5faae97 100644 --- a/configure.ac +++ b/configure.ac @@ -1959,8 +1959,6 @@ AM_CONDITIONAL(HAVE_X86_ASM, echo "$DEFINES" | grep 'X86_ASM' >/dev/null 2>&1) AM_CONDI

[Mesa-dev] [PATCH 18/18] glx/tests: Add unit tests for the DRI2 part of GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
From: Ian Romanick After adding $(DEFINES) to AM_CPPFLAGS, the __glXGetCurrentContext wrapper function is no longer needed and causes compile errors. Using the correct defines causes it to be a macro! Signed-off-by: Ian Romanick --- src/glx/tests/Makefile.am | 4 +

[Mesa-dev] [PATCH 17/18] glx/tests: Add unit tests for the GLX part of GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
From: Ian Romanick These tests primarilly ensure that the functions added by this extension don't abuse other interfaces (e.g., glx_screen::query_renderer_integer) when provided bad data. These tests helped me find a couple small bugs in the initial implementation. Signed-off-by: Ian Romanick

[Mesa-dev] [PATCH 16/18] glx/tests: Add GetGLXScreenConfigs_called flag

2013-10-11 Thread Ian Romanick
From: Ian Romanick Tests for the GLX_MESA_query_context extension will use this flag. Signed-off-by: Ian Romanick --- src/glx/tests/create_context_unittest.cpp | 4 1 file changed, 4 insertions(+) diff --git a/src/glx/tests/create_context_unittest.cpp b/src/glx/tests/create_context_unit

[Mesa-dev] [PATCH 14/18] glx/dri2: Add DRI2 support for GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
From: Ian Romanick The new functions for this extension were added to a separate file (dri2_query_renderer.c) to facilitate unit testing. I tried putting them in dri2_glx.c, and it resulting in an unending chain of dependencies. It was the proverbial threading hanging from a sweater. Signed-of

[Mesa-dev] [PATCH 15/18] docs: Import extension spec for GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
From: Ian Romanick The enumerated values are currently allocated from Intel's range. Signed-off-by: Ian Romanick --- docs/MESA_query_renderer.spec | 381 ++ 1 file changed, 381 insertions(+) create mode 100644 docs/MESA_query_renderer.spec diff --git a

[Mesa-dev] [PATCH 12/18] glx/tests: Silence warnings after adding fields to glx_screen_vtable

2013-10-11 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glx/tests/fake_glx_screen.cpp | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/glx/tests/fake_glx_screen.cpp b/src/glx/tests/fake_glx_screen.cpp index 845084f..7ee9b82 100644 --- a/src/glx/tests/fake_glx_scre

[Mesa-dev] [PATCH 13/18] glx/dri2: Pull some internal structures out to a separate header file

2013-10-11 Thread Ian Romanick
From: Ian Romanick This structures will be accessed by internal functions that will be added in a file separate from dri2_glx.c. The new code will be added to a new file to facilitate unit testing. Signed-off-by: Ian Romanick --- src/glx/dri2_glx.c | 21 + src/glx/dri2_pr

[Mesa-dev] [PATCH 11/18] glx: Add functions and GLX plumbing for GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glx/Makefile.am | 1 + src/glx/glxclient.h | 7 +- src/glx/glxcmds.c| 6 ++ src/glx/query_renderer.c | 173 +++ 4 files changed, 186 insertions(+), 1 deletion(-) create mo

[Mesa-dev] [PATCH 10/18] glx: Add GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
From: Ian Romanick THESE ARE JUST PLACEHOLDER VALUES. DO NOT SHIP!!! Signed-off-by: Ian Romanick --- include/GL/glx.h | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/include/GL/glx.h b/include/GL/glx.h index 87c31fd..234abc0 100644 --- a/include

[Mesa-dev] [PATCH 09/18] glx: Add extension tracking GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/glx/glxextensions.c | 1 + src/glx/glxextensions.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/glx/glxextensions.c b/src/glx/glxextensions.c index 7b00a9e..f186c13 100644 --- a/src/glx/glxextensions.c +++ b/src/glx/glxextensio

[Mesa-dev] [PATCH 08/18] i965: Wire up initial support for DRI_RENDERER_QUERY extension

2013-10-11 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/intel_screen.c | 81 1 file changed, 81 insertions(+) diff --git a/src/mesa/drivers/dri/i965/intel_screen.c b/src/mesa/drivers/dri/i965/intel_screen.c index b6b4275..e8a0323 100644 --

[Mesa-dev] [PATCH 07/18] i915: Wire up initial support for DRI_RENDERER_QUERY extension

2013-10-11 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i915/intel_screen.c | 79 1 file changed, 79 insertions(+) diff --git a/src/mesa/drivers/dri/i915/intel_screen.c b/src/mesa/drivers/dri/i915/intel_screen.c index 4f8c342..fa4fdc0 100644 --

[Mesa-dev] [PATCH 06/18] dri: Add function to implement queries common to all Mesa drivers

2013-10-11 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/common/utils.c | 62 + src/mesa/drivers/dri/common/utils.h | 3 ++ 2 files changed, 65 insertions(+) diff --git a/src/mesa/drivers/dri/common/utils.c b/src/mesa/drivers/dri/common/util

[Mesa-dev] [PATCH 04/18] i915: Refactor the renderer string creation out of intelGetString

2013-10-11 Thread Ian Romanick
From: Ian Romanick This will soon be used in intel_screen.c from a function that doesn't have a gl_context. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i915/intel_context.c | 34 +++ src/mesa/drivers/dri/i915/intel_context.h | 2 ++ 2 files changed, 23 ins

[Mesa-dev] [PATCH 05/18] i965: Refactor the renderer string creation out of intelGetString

2013-10-11 Thread Ian Romanick
From: Ian Romanick This will soon be used in intel_screen.c from a function that doesn't have a gl_context. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/intel_context.c | 37 +++ src/mesa/drivers/dri/i965/intel_context.h | 2 ++ 2 files changed, 25 ins

[Mesa-dev] [PATCH 02/18] i915: Refactor the vendor string out of intelGetString

2013-10-11 Thread Ian Romanick
From: Ian Romanick This will soon be used in intel_screen.c from a function that doesn't have a gl_context. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i915/intel_context.c | 3 ++- src/mesa/drivers/dri/i915/intel_context.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 03/18] i965: Refactor the vendor string out of intelGetString

2013-10-11 Thread Ian Romanick
From: Ian Romanick This will soon be used in intel_screen.c from a function that doesn't have a gl_context. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/intel_context.c | 3 ++- src/mesa/drivers/dri/i965/intel_context.h | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff

[Mesa-dev] [PATCH 01/18] dri: Add interface definition for DRI_RENDERER_QUERY extension

2013-10-11 Thread Ian Romanick
From: Ian Romanick This will be used to let apps query hardware and driver limits before creating a GL context. Signed-off-by: Ian Romanick --- include/GL/internal/dri_interface.h | 29 + 1 file changed, 29 insertions(+) diff --git a/include/GL/internal/dri_interfa

[Mesa-dev] [PATCH 00/18] Implement GLX_MESA_query_renderer

2013-10-11 Thread Ian Romanick
This is the completion of some work that I started back in February after FOSDEM. *blush* http://www.paranormal-entertainment.com/idr/blog/posts/2013-02-07T22:42:53Z-FOSDEM2013_Presentation/ Basically, this add a method for applications to query various aspects of the GL implementation *before* c

[Mesa-dev] Doxygen published online, updated every 4 hours

2013-10-11 Thread Chad Versace
Tom asked me to do this, and it should also help Kevin. I am building Mesa's Doxygen from master every four hours and publishing it here: http://people.freedesktop.org/~chadversary/mesa/doxygen/ It doesn't look very nice. It's incomplete. It's not cross-referenced as well as it should be. If it

Re: [Mesa-dev] [PATCH 1/3] just change doxy-directory

2013-10-11 Thread Chad Versace
On 10/07/2013 11:00 PM, Kevin Rogovin wrote: really change the doxygen files swrast, tnl and tnl_dd added In the commit message, please explain what the patch is tries to accomplish and how it accomplishes it. Also, each patch should do just one thing. This patch should be separated into one t

[Mesa-dev] [PATCH] r600g: fix tgsi_op2_s with trans-only instructions

2013-10-11 Thread Vadim Girlin
This fixes the issue when dst and src is the same reg and operation on one channel overwrites the source for other channels, e.g.: UMUL TEMP[2].xyz, TEMP[0].xyzz, TEMP[2]. In this example the result of the operation on channel x is written in TEMP[2].x and then used as a second source operand

Re: [Mesa-dev] [PATCH 1/2] mesa: Define introspection macro to determine whether a type is trivially destructible.

2013-10-11 Thread Ian Romanick
The minor nit in both patches: The closing */ of a multiline comment should go on its own line. I'd like to hear some feedback from Paul and / or Ken before committing, but this series is Reviewed-by: Ian Romanick On 10/09/2013 11:20 AM, Francisco Jerez wrote: > Only implemented on GCC and Cla

Re: [Mesa-dev] [PATCH] i965/gs: Set the REORDER bit in 3DSTATE_GS.

2013-10-11 Thread Paul Berry
On 11 October 2013 14:13, Matt Turner wrote: > On Fri, Oct 11, 2013 at 1:27 PM, Paul Berry > wrote: > > Ivy Bridge's "reorder enable" bit gives us a binary choice for the > > order in which vertices from triangle strips are delivered to the > > geometry shader. Neither choice follows the OpenGL

Re: [Mesa-dev] Documentation plan: request for comments

2013-10-11 Thread Chad Versace
On 10/10/2013 01:38 AM, Rogovin, Kevin wrote: Hello all, My current goal is to add documentation to Mesa so that the ramp up time of Mesa goes down a great deal. I support that goal. When I see other projects that publish good Doxygen documentation, like http://llvm.org/doxygen/modules.ht

Re: [Mesa-dev] [glsl] indvar in ir_loop

2013-10-11 Thread Ian Romanick
On 10/10/2013 11:14 PM, Liu Xin wrote: > Hi, Mesa developers, > > According to glsl v1.0, we have loop construct: > for (for-init-statement; condition(opt); expression) > statement-no-new-scope > > Variables declared in for-init-statement or condition are only in scope > until the end of the > st

Re: [Mesa-dev] [PATCH 7/7] automake: properly handle non-default expat installation

2013-10-11 Thread Emil Velikov
On 11/10/13 20:44, Tom Stellard wrote: > On Fri, Oct 11, 2013 at 02:09:57PM +0100, Emil Velikov wrote: >> On 07/10/13 18:53, Emil Velikov wrote: >>> On 07/10/13 16:48, Tom Stellard wrote: On Sat, Sep 28, 2013 at 03:46:21PM +0100, Emil Velikov wrote: > Use PKG_CHECK_MODULE over requesting t

Re: [Mesa-dev] [PATCH] i965/gs: Set the REORDER bit in 3DSTATE_GS.

2013-10-11 Thread Matt Turner
On Fri, Oct 11, 2013 at 1:27 PM, Paul Berry wrote: > Ivy Bridge's "reorder enable" bit gives us a binary choice for the > order in which vertices from triangle strips are delivered to the > geometry shader. Neither choice follows the OpenGL spec, but setting > the bit is better, because it gets t

Re: [Mesa-dev] [PATCH 7/7] automake: properly handle non-default expat installation

2013-10-11 Thread Emil Velikov
On 11/10/13 20:09, Matt Turner wrote: > On Sat, Sep 28, 2013 at 7:46 AM, Emil Velikov > wrote: >> Use PKG_CHECK_MODULE over requesting the user to setup the >> option at configure time. Drop unused EXPAT_INCLUDE and add >> EXPAT_CFLAGS to all classic/dri and gallium/dri targets. >> >> Signed-off-

[Mesa-dev] [PATCHv2 7/7] automake: properly handle non-default expat installation

2013-10-11 Thread Emil Velikov
Use PKG_CHECK_MODULE over requesting the user to setup the option at configure time. Drop unused EXPAT_INCLUDE and update all targets. NOTE: This commit removes the --with-expat configure option. One should ensure that the expat they wish to use has expat.pc file accessible by pkg-config. v2: * A

[Mesa-dev] [PATCH] i965/fs: Remove bogus field prog_data->dispatch_width.

2013-10-11 Thread Paul Berry
Despite the name, this field wasn't being set to the dispatch width at all; it was always 8. The only place it was used was that the constant buffer read length was aligned to it, and as far as I can tell from the docs, there is no need to align this value to the dispatch width; aligning it to a m

[Mesa-dev] [PATCH 2/2] i965/gs: Fix gl_PrimitiveIDIn when using SW primitive restart.

2013-10-11 Thread Paul Berry
Ivy Bridge hardware doesn't support primitve restart under all circumstances--when it doesn't, we emulate it in software by splitting up each logical draw operation into multiple 3DPRIMITIVE commands. This causes the hardware's primitive ID counter to be reset to 0, producing incorrect values for g

[Mesa-dev] [PATCH 1/2] vbo: Make vbo_sw_primitive_restart optionally count primitives.

2013-10-11 Thread Paul Berry
This will be necessary in order to get the i965 back-end to produce the correct value of gl_PrimitiveIDIn when using software primitive restart. --- src/mesa/drivers/dri/i965/brw_primitive_restart.c | 2 +- src/mesa/vbo/vbo.h| 3 ++- src/mesa/vbo/vbo_exec_array.c

Re: [Mesa-dev] [PATCH] glcpp: error on multiple #else directives

2013-10-11 Thread Ian Romanick
Carl, Can you look at this patch and Erik's follow-up patch? You (still) know the glcpp much better than any of the rest of us. (Carl is currently out of town, so I know his response will be slow...) Thanks. On 09/23/2013 01:35 PM, Erik Faye-Lund wrote: > The preprocessor currently eats multip

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-11 Thread Chad Versace
Paul, nice work! ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH] i965/gs: Set the REORDER bit in 3DSTATE_GS.

2013-10-11 Thread Paul Berry
Ivy Bridge's "reorder enable" bit gives us a binary choice for the order in which vertices from triangle strips are delivered to the geometry shader. Neither choice follows the OpenGL spec, but setting the bit is better, because it gets triangle orientation correct. Haswell replaces the "reorder

[Mesa-dev] [Bug 70378] fatal error: xmlpool/options.h: No such file or directory

2013-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70378 Emil Velikov changed: What|Removed |Added Attachment #87471|0 |1 is obsolete|

Re: [Mesa-dev] [PATCH 09/14] nouveau: Build the driver into the shared mesa_dri_drivers.so.

2013-10-11 Thread Eric Anholt
Matt Turner writes: > On Mon, Sep 30, 2013 at 1:44 PM, Eric Anholt wrote: >> diff --git a/src/mesa/drivers/dri/Makefile.am >> b/src/mesa/drivers/dri/Makefile.am >> index 9d15c43..6152fcc 100644 >> --- a/src/mesa/drivers/dri/Makefile.am >> +++ b/src/mesa/drivers/dri/Makefile.am >> @@ -27,6 +27,8

Re: [Mesa-dev] [PATCH 04/14] glx: Add an optional function call for getting the DRI driver interface.

2013-10-11 Thread Eric Anholt
Matt Turner writes: > On Mon, Sep 30, 2013 at 1:44 PM, Eric Anholt wrote: >> The previous interface relied on a static struct, which meant tha the >> driver didn't get a chance to edit the struct before the struct got used. >> For megadrivers, I want to return a variable struct based on what dri

Re: [Mesa-dev] [PATCH 7/7] automake: properly handle non-default expat installation

2013-10-11 Thread Tom Stellard
On Fri, Oct 11, 2013 at 02:09:57PM +0100, Emil Velikov wrote: > On 07/10/13 18:53, Emil Velikov wrote: > > On 07/10/13 16:48, Tom Stellard wrote: > >> On Sat, Sep 28, 2013 at 03:46:21PM +0100, Emil Velikov wrote: > >>> Use PKG_CHECK_MODULE over requesting the user to setup the > >>> option at confi

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-11 Thread Jordan Justen
On Fri, Oct 11, 2013 at 11:04 AM, Paul Berry wrote: > On 11 October 2013 05:43, Mike Lothian wrote: >> >> Well done on getting this enabled >> >> Out of interest how far is SandyBridge from 3.2? > > I believe geometry shaders are all we would have to implement for Sandy > Bridge. Unfortunately,

Re: [Mesa-dev] [PATCH] configure: set HAVE_COMMON_DRI when building plain classic swrast

2013-10-11 Thread Matt Turner
On Fri, Oct 11, 2013 at 12:25 PM, Emil Velikov wrote: > On 11/10/13 19:59, Matt Turner wrote: >> I think now that xf86drm.h's include is protected by __NOT_HAVE_DRM_H >> we can now just drop HAVE_COMMON_DRI entirely. Right? >> > Sounds like a plan, with a minor side effect that you'll be building

[Mesa-dev] [Bug 70378] fatal error: xmlpool/options.h: No such file or directory

2013-10-11 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70378 --- Comment #5 from Emil Velikov --- I have to admit that build log was a bit too "inspiring" for me. I got bored half way though the list of downloading and installing all the dependencies :) Anywho, the issue reported seems different from the

Re: [Mesa-dev] [PATCH] configure: set HAVE_COMMON_DRI when building plain classic swrast

2013-10-11 Thread Emil Velikov
On 11/10/13 19:59, Matt Turner wrote: > On Fri, Oct 11, 2013 at 9:19 AM, Emil Velikov > wrote: >> Commit d81632fb1(dri: Merge drisw_util.c into dri_util.c) unified the >> dri and drisw util code, but forgot to set HAVE_COMMON_DRI. Thus the >> translations for driconf (that drisw now depends on) w

Re: [Mesa-dev] RFC: LLVM, -fno-rtti, and Haiku

2013-10-11 Thread Francisco Jerez
Kenneth Graunke writes: > On 10/11/2013 11:45 AM, Francisco Jerez wrote: >> Kenneth Graunke writes: >> >>> On 10/11/2013 09:50 AM, Francisco Jerez wrote: Kenneth Graunke writes: > On 10/10/2013 04:27 PM, Alexander von Gluck IV wrote: >> >> In llvm.py -fno-rtti is always a

Re: [Mesa-dev] Mesa (master): i965/fs: Convert gen7 to using GRFs for texture messages.

2013-10-11 Thread Eric Anholt
Chia-I Wu writes: > Hi Eric, > The frame rate of Unigine Tropics (with low shader quality) dropped > from 40.8 to 23.5 after this change. Thanks for the note. I see the regression as well, and I see a shader that's started spilling. It looks like we can drop the regs_written <= 1 check on gen7

Re: [Mesa-dev] [PATCH 7/7] automake: properly handle non-default expat installation

2013-10-11 Thread Matt Turner
On Sat, Sep 28, 2013 at 7:46 AM, Emil Velikov wrote: > Use PKG_CHECK_MODULE over requesting the user to setup the > option at configure time. Drop unused EXPAT_INCLUDE and add > EXPAT_CFLAGS to all classic/dri and gallium/dri targets. > > Signed-off-by: Emil Velikov > --- > configure.ac

Re: [Mesa-dev] [PATCH] configure: set HAVE_COMMON_DRI when building plain classic swrast

2013-10-11 Thread Matt Turner
On Fri, Oct 11, 2013 at 9:19 AM, Emil Velikov wrote: > Commit d81632fb1(dri: Merge drisw_util.c into dri_util.c) unified the > dri and drisw util code, but forgot to set HAVE_COMMON_DRI. Thus the > translations for driconf (that drisw now depends on) were not built, > leading to a build errors. >

Re: [Mesa-dev] RFC: LLVM, -fno-rtti, and Haiku

2013-10-11 Thread Kenneth Graunke
On 10/11/2013 11:45 AM, Francisco Jerez wrote: > Kenneth Graunke writes: > >> On 10/11/2013 09:50 AM, Francisco Jerez wrote: >>> Kenneth Graunke writes: >>> On 10/10/2013 04:27 PM, Alexander von Gluck IV wrote: > > In llvm.py -fno-rtti is always a build flag if LLVM present >= 3.2 >

Re: [Mesa-dev] RFC: LLVM, -fno-rtti, and Haiku

2013-10-11 Thread Francisco Jerez
Alexander von Gluck IV writes: > On Fri, 11 Oct 2013 09:50:08 -0700 > Francisco Jerez wrote: > >> Kenneth Graunke writes: >> >> > On 10/10/2013 04:27 PM, Alexander von Gluck IV wrote: >> >> >> >> In llvm.py -fno-rtti is always a build flag if LLVM present >= 3.2 >> >> >> >> This breaks every

Re: [Mesa-dev] RFC: LLVM, -fno-rtti, and Haiku

2013-10-11 Thread Francisco Jerez
Kenneth Graunke writes: > On 10/11/2013 09:50 AM, Francisco Jerez wrote: >> Kenneth Graunke writes: >> >>> On 10/10/2013 04:27 PM, Alexander von Gluck IV wrote: In llvm.py -fno-rtti is always a build flag if LLVM present >= 3.2 This breaks everything on our end (missing rtti

Re: [Mesa-dev] [PATCH] mesa: fix transform feedback when a geometry shader is active.

2013-10-11 Thread Kenneth Graunke
On 10/11/2013 11:28 AM, Paul Berry wrote: > From: Bryan Cain > > When a geometry shader is active, the transform feedback primitive > type ("mode") needs to be validated against the geometry shader output > primitive type, not the primitive type passed to the glDraw*() > function. Reviewed-by: K

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-11 Thread Eric Anholt
Abdiel Janulgue writes: > On Thursday, October 10, 2013 01:04:08 PM Eric Anholt wrote: >> >> My basic comment on resource streamer: We need performance data showing >> that it is a win before we commit it. I'm not planning on reviewing the >> changes until we get that data. > > At it's current

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-11 Thread Ian Romanick
Series is Reviewed-by: Ian Romanick On 10/10/2013 09:27 PM, Paul Berry wrote: > It's been a long and rocky road, but geometry shader support in Mesa's > i965/gen7 driver has finally reached a point I'm willing to call > "feature complete". Since geometry shaders were the last remaining > featur

[Mesa-dev] [PATCH 6/6] glsl: Simplify the interface to link_invalidate_variable_locations

2013-10-11 Thread Ian Romanick
From: Ian Romanick The unit tests added in the previous commits prove some things about the state of some internal data structures. The most important of these is that all built-in input and output variables have explicit_location set. This means that link_invalidate_variable_locations doesn't

[Mesa-dev] [PATCH 3/6] glsl/tests: Verify fragment shader built-ins generated by _mesa_glsl_initialize_variables

2013-10-11 Thread Ian Romanick
From: Ian Romanick Checks that the variables generated meet certain criteria. - Fragment shader inputs have an explicit location. - Fragment shader outputs have an explicit location. - Vertex / geometry shader-only varying locations are not used. - Fragment shader uniforms and system valu

[Mesa-dev] [PATCH 4/6] glsl/tests: Verify geometry shader built-ins generated by _mesa_glsl_initialize_variables

2013-10-11 Thread Ian Romanick
From: Ian Romanick Checks that the variables generated meet certain criteria. - Geometry shader inputs have an explicit location. - Geometry shader outputs have an explicit location. - Fragment shader-only varying locations are not used. - Geometry shader uniforms and system values don't

[Mesa-dev] [PATCH 5/6] glsl/tests: Unit test vertex shader in / out with link_invalidate_variable_locations

2013-10-11 Thread Ian Romanick
From: Ian Romanick This required fixing the out-of-date prototype in linker.h. While making that change, further change the prototype to make unit testing a bit easier. Validates: - ir_variable::explicit_location should not be modified. - If ir_variable::location is not a generic location

[Mesa-dev] [PATCH] mesa: fix transform feedback when a geometry shader is active.

2013-10-11 Thread Paul Berry
From: Bryan Cain When a geometry shader is active, the transform feedback primitive type ("mode") needs to be validated against the geometry shader output primitive type, not the primitive type passed to the glDraw*() function. Fixes the following piglit tests: - glsl-1.50-geometry-primitive-typ

  1   2   >