Re: [Mesa-dev] [PATCH 1/5] glsl: Add support for separate reference Z for shadow samplers

2013-10-10 Thread Kenneth Graunke
On 10/10/2013 12:21 AM, Chris Forbes wrote: > ARB_gpu_shader5's textureGather*() functions which take shadow samplers > have a separate `refz` parameter rather than adding it to the > coordinate. > > Signed-off-by: Chris Forbes > --- > src/glsl/builtin_functions.cpp | 20 +++- >

Re: [Mesa-dev] megadrivers series

2013-10-10 Thread Matt Turner
On Mon, Sep 30, 2013 at 1:44 PM, Eric Anholt wrote: > Here are the megadrivers changes, after the prep series I posted earlier. > A few tiny updates to the prep series are available in my tree as > "megadriver-prep" and this series is available as "megadrivers-5" > > FPS improvement on GLB2.7 with

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-10 Thread Chris Forbes
Great to see this enabled! For the series: Reviewed-by: Chris Forbes On Fri, Oct 11, 2013 at 7:12 PM, Kenneth Graunke wrote: > On 10/10/2013 09:33 PM, Dave Airlie wrote: >> On Fri, Oct 11, 2013 at 2:27 PM, Paul Berry wrote: >>> It's been a long and rocky road, but geometry shader support in M

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-10 Thread Kenneth Graunke
On 10/10/2013 09:27 PM, Paul Berry wrote: > It's been a long and rocky road, but geometry shader support in Mesa's > i965/gen7 driver has finally reached a point I'm willing to call > "feature complete". Since geometry shaders were the last remaining > feature needed for GL 3.2, it's time to turn

Re: [Mesa-dev] RFC: LLVM, -fno-rtti, and Haiku

2013-10-10 Thread Kenneth Graunke
On 10/10/2013 04:27 PM, Alexander von Gluck IV wrote: > > In llvm.py -fno-rtti is always a build flag if LLVM present >= 3.2 > > This breaks everything on our end (missing rtti related symbols) in our > C++ libGL.so as Haiku uses dynamic casts. > > We build our LLVM packages with rtti (REQUIRES_

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-10 Thread Kenneth Graunke
On 10/10/2013 09:33 PM, Dave Airlie wrote: > On Fri, Oct 11, 2013 at 2:27 PM, Paul Berry wrote: >> It's been a long and rocky road, but geometry shader support in Mesa's >> i965/gen7 driver has finally reached a point I'm willing to call >> "feature complete". Since geometry shaders were the last

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-10 Thread Abdiel Janulgue
On Thursday, October 10, 2013 01:04:08 PM Eric Anholt wrote: > > My basic comment on resource streamer: We need performance data showing > that it is a win before we commit it. I'm not planning on reviewing the > changes until we get that data. At it's current form, I don't expect that much perf

Re: [Mesa-dev] [PATCH 09/14] nouveau: Build the driver into the shared mesa_dri_drivers.so.

2013-10-10 Thread Matt Turner
On Mon, Sep 30, 2013 at 1:44 PM, Eric Anholt wrote: > --- > configure.ac | 2 +- > src/mesa/drivers/dri/Makefile.am | 2 ++ > src/mesa/drivers/dri/nouveau/Makefile.am | 23 ++- > src/mesa/drivers/dri/nouveau/nouveau_screen.c

Re: [Mesa-dev] [PATCH 04/14] glx: Add an optional function call for getting the DRI driver interface.

2013-10-10 Thread Matt Turner
On Mon, Sep 30, 2013 at 1:44 PM, Eric Anholt wrote: > The previous interface relied on a static struct, which meant tha the > driver didn't get a chance to edit the struct before the struct got used. > For megadrivers, I want to return a variable struct based on what driver > is getting loaded. >

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-10 Thread Matt Turner
Awesome work, Paul! Series is: Reviewed-by: Matt Turner ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

Re: [Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-10 Thread Dave Airlie
On Fri, Oct 11, 2013 at 2:27 PM, Paul Berry wrote: > It's been a long and rocky road, but geometry shader support in Mesa's > i965/gen7 driver has finally reached a point I'm willing to call > "feature complete". Since geometry shaders were the last remaining > feature needed for GL 3.2, it's tim

[Mesa-dev] [PATCH 3/3] mesa: Bump version to 10.0.0.

2013-10-10 Thread Paul Berry
Mesa now supports OpenGL 3.2 and GLSL 1.50, so bump the Mesa major version from 9 to 10 to reflect this. --- VERSION | 2 +- docs/relnotes.html | 2 +- docs/relnotes/10.0.html | 65 + docs/relnotes/9.3.html | 65 --

[Mesa-dev] [PATCH 2/3] mesa: Remove warning that geometry shader support is experimental.

2013-10-10 Thread Paul Berry
Geometry shader support is now working well, and adequately piglit tested. There are just a few piglit failures left to fix. So there's no need for an "experimental" warning anymore. --- src/mesa/main/shaderapi.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/src/mesa/main/shaderapi.c

[Mesa-dev] [PATCH 1/3] i965: Turn on GLSL 1.50 and GL 3.2 support for i965 gen7.

2013-10-10 Thread Paul Berry
Geometry shaders were the last thing we needed to finish before turning on GLSL 1.50 and GL 3.2 support. They are now working well, with just a few piglit failures left to fix. --- src/mesa/drivers/dri/i965/intel_extensions.c | 4 +++- src/mesa/drivers/dri/i965/intel_screen.c | 2 +- 2 files

[Mesa-dev] [PATCH 0/3] Enable GL 3.2 support for i965, bump Mesa version.

2013-10-10 Thread Paul Berry
It's been a long and rocky road, but geometry shader support in Mesa's i965/gen7 driver has finally reached a point I'm willing to call "feature complete". Since geometry shaders were the last remaining feature needed for GL 3.2, it's time to turn on GL 3.2 support. Here is a short patch series t

[Mesa-dev] [Bug 70359] [llvmpipe] piglit arb_shader_texture_lod-texgrad regression

2013-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70359 --- Comment #1 from Roland Scheidegger --- The test isn't really valid. Note that passing it before was just an "accident" as the test verifies that results using implicit and explicit gradients for cube maps are the same, and the driver _ignored

[Mesa-dev] [Bug 70359] New: [llvmpipe] piglit arb_shader_texture_lod-texgrad regression

2013-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70359 Priority: medium Bug ID: 70359 Keywords: regression CC: srol...@vmware.com Assignee: mesa-dev@lists.freedesktop.org Summary: [llvmpipe] piglit arb_shader_texture_lod-texgrad

[Mesa-dev] [PATCH] glapi: Do not include dlfcn.h on Windows.

2013-10-10 Thread Vinson Lee
This patch fixes this MinGW build error. CC glapi_gentable.lo glapi_gentable.c:47:19: fatal error: dlfcn.h: No such file or directory Signed-off-by: Vinson Lee --- src/mapi/glapi/gen/gl_gentable.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mapi/glapi/gen/gl_gentable.py b/

Re: [Mesa-dev] [PATCH v2] i965: extend fast texture upload

2013-10-10 Thread Chad Versace
On 10/07/2013 06:17 PM, Frank Henigman wrote: Extend the fast texture upload from BGRA X-tiled to include RGBA, Alpha/Luminance, and Y-tiled. Speed improvements, measured with mesa demos teximage program, on 256 x 256 texture, in MB/s, on a Sandy Bridge (Ivy is comparable): befor

[Mesa-dev] [PATCH] radeon/llvm: show LLVM disassembly when available

2013-10-10 Thread Jay Cornwall
With code dump enabled LLVM may generate disassembly during compilation. Show this disassembly when available and prefer it to SI bytecode dump. Signed-off-by: Jay Cornwall --- src/gallium/drivers/radeon/radeon_llvm_emit.c | 7 +++ src/gallium/drivers/radeon/radeon_llvm_emit.h | 1 + src/g

[Mesa-dev] [PATCH 13/14 v3] swrast: Build the driver into the shared mesa_dri_drivers.so.

2013-10-10 Thread Eric Anholt
v2: drop dridir now that it's unused. v3: Fix linking after rebase when building just swrast from classic but a drm-using gallium driver. --- Emil, does this fix your concern? It means that if you build r200c (for example) plus softpipe, you'll get softpipe's swrast_dri.so linked against libd

Re: [Mesa-dev] [PATCH 0/3] translate, rtasm fixes for 64-bit Cygwin

2013-10-10 Thread Brian Paul
On 10/10/2013 08:01 AM, Jon TURNEY wrote: Since 64-bit Cygwin is now a thing, fix translate_sse for it. (It's unclear that it's ever worked on the Windows 64-bit target. Commit c2da8e77023325f46dde2009def2947b1a687c7b "translate_sse: major rewrite (v5)" adds untested support for 64-bit Windows,

Re: [Mesa-dev] [PATCH] softpipe: fix seamless cube filtering

2013-10-10 Thread Roland Scheidegger
Am 10.10.2013 23:12, schrieb Brian Paul: > On 10/10/2013 11:37 AM, srol...@vmware.com wrote: >> From: Roland Scheidegger >> >> Fix coord wrapping (and face selection too) in case of edges. >> Unfortunately, the coord wrapping is way more complicated than what >> the code did, as it depends on the

[Mesa-dev] RFC: LLVM, -fno-rtti, and Haiku

2013-10-10 Thread Alexander von Gluck IV
In llvm.py -fno-rtti is always a build flag if LLVM present >= 3.2 This breaks everything on our end (missing rtti related symbols) in our C++ libGL.so as Haiku uses dynamic casts. We build our LLVM packages with rtti (REQUIRES_RTTI=1). Not 100% sure why we're forcing no-rtti if LLVM >= 3.2. "l

[Mesa-dev] [PATCH] r600g: fix crash in set_framebuffer_state

2013-10-10 Thread Grigori Goronzy
We should be able to safely set the framebuffer state without a fragment shader bound. bind_ps_state will take care of updating the necessary state bits later. v2: check in update_db_shader_control --- src/gallium/drivers/r600/evergreen_state.c | 23 +++ src/gallium/drivers/r6

Re: [Mesa-dev] [PATCH] radeonsi: pass alpha_ref value to PS in the user sgpr

2013-10-10 Thread Marek Olšák
On Thu, Oct 10, 2013 at 6:38 PM, Vadim Girlin wrote: > On 10/10/2013 08:10 PM, Christian König wrote: >> >> Am 10.10.2013 18:02, schrieb Vadim Girlin: >>> >>> On 10/10/2013 02:11 PM, Michel Dänzer wrote: On Don, 2013-10-10 at 12:49 +0400, Vadim Girlin wrote: > > Currently it's ha

Re: [Mesa-dev] [PATCH] r600g: fix crash in set_framebuffer_state

2013-10-10 Thread Marek Olšák
It would be safer to check ps_shader in update_db_shader_control instead. This is not the only place where update_db_shader_control is called. Marek On Thu, Oct 10, 2013 at 7:17 PM, Grigori Goronzy wrote: > We should be able to safely set the framebuffer state without a > fragment shader bound.

Re: [Mesa-dev] [PATCH] llvmpipe: We don't use the draw pipeline for offset_point/line.

2013-10-10 Thread Brian Paul
On 10/09/2013 06:01 PM, jfons...@vmware.com wrote: From: José Fonseca Unless the polygon fill mode is different PIPE_POLYGON_MODE_FILL, so checking the the polygon mode is sufficient. Testing done: no regression in polygon-mode-offset --- src/gallium/drivers/llvmpipe/lp_state_rasterizer.c |

Re: [Mesa-dev] [PATCH 2/2] haiku: Fix llvmpipe and clean up tracing

2013-10-10 Thread Brian Paul
The subject says llvmpipe but the changes appear to be for softpipe. And it looks like this would ideally be split into two separate commits. Anyway, for 1 and 2: Acked-by: Brian Paul On 10/09/2013 05:47 PM, Alexander von Gluck IV wrote: * Fix LLVM library and defines * Only enable tracing w

[Mesa-dev] [PATCH 16/16] i965/gen7.5: Flush on-chip binding table to pool

2013-10-10 Thread Abdiel Janulgue
Normally, the CS will will just consume the binding table pointer commands as pipelined state. When the RS is enabled however, the RS flushes whatever edited surface state entries of our on-chip binding table to the binding table pool before passing the command on to the CS. Note that the the bind

Re: [Mesa-dev] [PATCH 5/5] i965/fs: Add support for shadow comparitors with gather4

2013-10-10 Thread Chris Forbes
Yes; fortunately we don't have to support offset and shadow together on them. On Fri, Oct 11, 2013 at 10:13 AM, Eric Anholt wrote: > Chris Forbes writes: > >> The 1D array case doesn't actually exist -- there is no 1D texture >> support for gather. >> >> For 2D arrays, the array index lands in t

[Mesa-dev] [PATCH 11/16] i965/gen7.5: Update surface entries for pull constants and VS UBO surfaces.

2013-10-10 Thread Abdiel Janulgue
When surface_state pointing to pull constant surfaces are changed, update on-chip binding table. Same with VS ubo surface states. v3: Include support for geometry shaders constant buffers in brw_upload_vec4_pull_constants. The previous patch failed to address this. Cc: Paul Berry Cc: Ken

[Mesa-dev] [PATCH 06/16] i965/gen7.5: Enable hardware-generated binding tables on render path.

2013-10-10 Thread Abdiel Janulgue
This patch implements the binding table enable command which is also used to allocate a binding table pool where where hardware-generated binding table entries are flushed into. Each binding table offset in the binding table pool is unique per each shader stage that are enabled within a batch. In

Re: [Mesa-dev] [PATCH 4/5] i965/vs: Add support for shadow comparitors with gather4

2013-10-10 Thread Chris Forbes
You're right, that looks completely bogus. I only have compiler tests and eyeballs for the shadow variants at this point -- I'll sort that out :) -- Chris On Fri, Oct 11, 2013 at 9:33 AM, Eric Anholt wrote: > Chris Forbes writes: > >> gather4_c's argument layout is straightforward -- refz just

Re: [Mesa-dev] [PATCH 5/5] i965/fs: Add support for shadow comparitors with gather4

2013-10-10 Thread Eric Anholt
Chris Forbes writes: > The 1D array case doesn't actually exist -- there is no 1D texture > support for gather. > > For 2D arrays, the array index lands in the `r` slot of the message. I guess cube arrays are the hard one. pgp7mUeeXniiX.pgp Description: PGP signature __

[Mesa-dev] [PATCH 03/16] i965/gen7.5: Pass resource streamer enable flags on batchbuffer start

2013-10-10 Thread Abdiel Janulgue
This is passed on the kernel to enable the resource streamer enable bit on MI_BATCHBUFFER_START v3: Use I915_EXEC_RESOURCE_STREAMER. Previous patch didn't build. Cc: Paul Berry Cc: Kenneth Graunke Cc: Chad Versace Cc: Eric Anholt Signed-off-by: Abdiel Janulgue --- src/mesa/drivers/dri/i965/

Re: [Mesa-dev] [PATCH] softpipe: fix seamless cube filtering

2013-10-10 Thread Brian Paul
On 10/10/2013 11:37 AM, srol...@vmware.com wrote: From: Roland Scheidegger Fix coord wrapping (and face selection too) in case of edges. Unfortunately, the coord wrapping is way more complicated than what the code did, as it depends on the face and the direction where the texel falls off the fa

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Prepare register spilling for reads of more than 1 reg.

2013-10-10 Thread Kenneth Graunke
On 10/09/2013 09:38 PM, Eric Anholt wrote: > When we introduce texture-from-GRF, we'll have instructions where a src > means more than one virtual grf is being read. Rearrange things to allow > src accesses to unspill like partial dst accesses do (which already had to > do reading more than one vg

Re: [Mesa-dev] [PATCH 5/5] i965/fs: Add support for shadow comparitors with gather4

2013-10-10 Thread Chris Forbes
The 1D array case doesn't actually exist -- there is no 1D texture support for gather. For 2D arrays, the array index lands in the `r` slot of the message. On Fri, Oct 11, 2013 at 9:25 AM, Eric Anholt wrote: > Chris Forbes writes: > >> Note that gather4_po_c's parameters are too long for SIMD16

[Mesa-dev] [Bug 70331] u_math.h:167:15: error: ‘long int lrint(double)’ was declared ‘extern’ and later ‘static’ [-fpermissive]

2013-10-10 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=70331 José Fonseca changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] glsl: Remove extraneous .dir-locals.el

2013-10-10 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > This was overriding the top-level .dir-locals.el causing some settings > (like forcing spaces instead of tabs!) to be lost. > > Signed-off-by: Ian Romanick Reviewed-by: Eric Anholt pgpGHdum77cgC.pgp Description: PGP signature ___

Re: [Mesa-dev] [PATCH 0/5] ARB_gpu_shader5 textureGather*, Part 3

2013-10-10 Thread Eric Anholt
Chris Forbes writes: > ... in which support for shadow samplers is added. Patches 1-3 are: Reviewed-by: Eric Anholt pgp_Mu2ck0xTx.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/m

Re: [Mesa-dev] [PATCH 4/5] i965/vs: Add support for shadow comparitors with gather4

2013-10-10 Thread Eric Anholt
Chris Forbes writes: > gather4_c's argument layout is straightforward -- refz just goes on the > end. > > gather4_po_c's layout however -- the array index is replaced with refz. > > Signed-off-by: Chris Forbes > diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp > b/src/mesa/drivers/d

[Mesa-dev] [PATCH] glsl: Remove extraneous .dir-locals.el

2013-10-10 Thread Ian Romanick
From: Ian Romanick This was overriding the top-level .dir-locals.el causing some settings (like forcing spaces instead of tabs!) to be lost. Signed-off-by: Ian Romanick --- This is the reason so many of my compiler patches have mixed tabs and spaces. src/glsl/.dir-locals.el | 3 --- 1 file ch

Re: [Mesa-dev] [PATCH 5/5] i965/fs: Add support for shadow comparitors with gather4

2013-10-10 Thread Eric Anholt
Chris Forbes writes: > Note that gather4_po_c's parameters are too long for SIMD16. It might be > worth emitting 2xSIMD8 messages in this case at some point. So, what happens for sampler messages that need an array index (1d/2d array), but we don't have that slot in gather4_po? Do we just drop

Re: [Mesa-dev] RFC: Haswell resource streamer/hw-generated binding tables (v2)

2013-10-10 Thread Eric Anholt
Abdiel Janulgue writes: > Prerequisites: > > - Kernel patches: [1] > (do 'make headers_install' and update libdrm headers after compiling > the kernel) > - Mesa patch: [2] > > This is an update from my previous RFC patches [3]. Most notable > change is that the resource streamer is a

Re: [Mesa-dev] [PATCH] main: Allow external textures to use fallback (0, 0, 0, 1)

2013-10-10 Thread Eric Anholt
Topi Pohjolainen writes: > Fixes GL2ExtensionTests/egl_image_external/TestSimpleUnassociated.test > which is part of gles2/3 conformance suite. Here image external > textures are switched to be treated the same as 2D textures. These > can be associated with the fallback texture providing fixed sa

Re: [Mesa-dev] PATCH: R600 + SI Private memory fixes; Use more SALU instructions on SI

2013-10-10 Thread Matt Arsenault
On 10/10/2013 10:55 AM, Tom Stellard wrote: Hi, The attached patches simplify the handling of OpenCL private memory space for VLIW4/VLIW5 GPUs and should fix a crash with pyrit on r600g. Also included in the series is private memory support on SI as well as an optimization to prefer selecting SA

Re: [Mesa-dev] PATCH: R600 + SI Private memory fixes; Use more SALU instructions on SI

2013-10-10 Thread Tom Stellard
On Thu, Oct 10, 2013 at 11:29:17AM -0700, Matt Arsenault wrote: > On 10/10/2013 10:55 AM, Tom Stellard wrote: > > Hi, > > > > The attached patches simplify the handling of OpenCL private memory > > space for VLIW4/VLIW5 GPUs and should fix a crash with pyrit on r600g. > > Also included in the serie

Re: [Mesa-dev] [PATCH 13/14] swrast: Build the driver into the shared mesa_dri_drivers.so.

2013-10-10 Thread Matt Turner
On Mon, Sep 30, 2013 at 1:44 PM, Eric Anholt wrote: > --- > configure.ac | 26 +++--- > src/mesa/drivers/dri/Makefile.am | 2 ++ > src/mesa/drivers/dri/swrast/Makefile.am | 18 +++--- > src/mesa/drivers/dri/swrast/M

Re: [Mesa-dev] i965: Last bits of texture-grf

2013-10-10 Thread Eric Anholt
Eric Anholt writes: > Thanks to Ken and Matt for a bunch of nasty rebasing work, texture-grf is > working again. And this time, I've produced some reasonably solid > performance numbers indicating that it's a win, so I think we're ready to > commit. > > Ken and Matt indicated that they were tire

[Mesa-dev] [PATCH] softpipe: fix seamless cube filtering

2013-10-10 Thread sroland
From: Roland Scheidegger Fix coord wrapping (and face selection too) in case of edges. Unfortunately, the coord wrapping is way more complicated than what the code did, as it depends on the face and the direction where the texel falls off the face (the logic needed to get this right in fact seems

[Mesa-dev] [PATCH] r600g: fix crash in set_framebuffer_state

2013-10-10 Thread Grigori Goronzy
We should be able to safely set the framebuffer state without a fragment shader bound. bind_ps_state will take care of updating the necessary state bits later. --- src/gallium/drivers/r600/evergreen_state.c | 4 +++- src/gallium/drivers/r600/r600_state.c | 4 +++- 2 files changed, 6 insertion

Re: [Mesa-dev] [PATCH] radeonsi: pass alpha_ref value to PS in the user sgpr

2013-10-10 Thread Vadim Girlin
On 10/10/2013 08:10 PM, Christian König wrote: Am 10.10.2013 18:02, schrieb Vadim Girlin: On 10/10/2013 02:11 PM, Michel Dänzer wrote: On Don, 2013-10-10 at 12:49 +0400, Vadim Girlin wrote: Currently it's hardcoded in the shader, so every change requires compilation of the shader variant, kill

Re: [Mesa-dev] [RFC PATCH 0/5] Safer way to ralloc C++ objects.

2013-10-10 Thread Francisco Jerez
Francisco Jerez writes: > This patch series tries out a different approach to allocating C++ > objects from an ralloc context. It's independent to the last series I > sent earlier today [1] -- which probably makes sense on its own > because it's a more incremental improvement and is likely to ta

Re: [Mesa-dev] [PATCH] radeonsi: pass alpha_ref value to PS in the user sgpr

2013-10-10 Thread Christian König
Am 10.10.2013 18:02, schrieb Vadim Girlin: On 10/10/2013 02:11 PM, Michel Dänzer wrote: On Don, 2013-10-10 at 12:49 +0400, Vadim Girlin wrote: Currently it's hardcoded in the shader, so every change requires compilation of the shader variant, killing the performance in Serious Sam 3 and probabl

Re: [Mesa-dev] [PATCH] radeonsi: pass alpha_ref value to PS in the user sgpr

2013-10-10 Thread Vadim Girlin
On 10/10/2013 02:11 PM, Michel Dänzer wrote: On Don, 2013-10-10 at 12:49 +0400, Vadim Girlin wrote: Currently it's hardcoded in the shader, so every change requires compilation of the shader variant, killing the performance in Serious Sam 3 and probably other apps. This patch passes alpha_ref i

Re: [Mesa-dev] [PATCH] R600/SI: Support byval arguments

2013-10-10 Thread Vincent Lejeune
llvm does not allow function attribute to flagged byval and inreg at the same time. It works currently because we don't verify our module in mesa, as our "byval inreg" arguments are considered byval by the sinking pass, and inreg by ISel pass. The patch : http://lists.freedesktop.org/archives

[Mesa-dev] [PATCH 3/3] traslate_sse: Fix generated code argument handling for msabi on x86_64

2013-10-10 Thread Jon TURNEY
translate_sse.c contains code for msabi on x86_64, but it appears to be untested. Currently arguments 1 and 2 passed to the generated code are moved as 32-bit quantities into the registers used by sysvabi, irrespective of the architecture. Since these may be pointers, they must be moved as 64-bit

[Mesa-dev] [PATCH 2/3] rtasm: Cygwin uses the msabi calling convention on x86_64

2013-10-10 Thread Jon TURNEY
Cygwin also uses the msabi calling convention on x86_64, not the sysvabi calling convention Signed-off-by: Jon TURNEY --- src/gallium/auxiliary/rtasm/rtasm_x86sse.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/rtasm/rtasm_x86sse.h b/src/gallium/auxil

[Mesa-dev] [PATCH 1/3] rtasm: The heap is NX on 64-bit Cygwin, so use the rtasm_exec_malloc() implementation which uses mmap()

2013-10-10 Thread Jon TURNEY
The heap is NX on 64-bit Cygwin, so use the rtasm_exec_malloc() implementation which uses mmap() to allocate an anonymous page with execute permission, rather than the one which just uses malloc(). Signed-off-by: Jon TURNEY --- src/gallium/auxiliary/rtasm/rtasm_execmem.c | 2 +- 1 file changed,

[Mesa-dev] [PATCH 0/3] translate, rtasm fixes for 64-bit Cygwin

2013-10-10 Thread Jon TURNEY
Since 64-bit Cygwin is now a thing, fix translate_sse for it. (It's unclear that it's ever worked on the Windows 64-bit target. Commit c2da8e77023325f46dde2009def2947b1a687c7b "translate_sse: major rewrite (v5)" adds untested support for 64-bit Windows, and then commit f4dd0991719ef3e2606920c510

Re: [Mesa-dev] [PATCH] R600/SI: Support byval arguments

2013-10-10 Thread Tom Stellard
On Thu, Oct 10, 2013 at 12:04:16AM +0200, Vincent Lejeune wrote: What is the purpose of this change? -Tom > --- > lib/Target/R600/AMDGPUCallingConv.td | 7 ++- > lib/Target/R600/SIISelLowering.cpp | 3 ++- > 2 files changed, 8 insertions(+), 2 deletions(-) > > diff --git a/lib/Target/R60

Re: [Mesa-dev] [PATCH 3/3] doxy-text files added

2013-10-10 Thread Rogovin, Kevin
> If patch two was applied and this (patch three) wasn't, then mesa would > contain > less documentation than before. Idea is that every commit on its own makes > things better and never worse. Hence the addition in this patch (number three) > would need to go together with the removal done in pa

Re: [Mesa-dev] [PATCH] radeonsi: Do not set both inreg and byval

2013-10-10 Thread Marek Olšák
Will the byval function arguments break the driver with LLVM 3.3? Marek On Thu, Oct 10, 2013 at 12:34 AM, Vincent Lejeune wrote: > --- > src/gallium/drivers/radeonsi/radeonsi_shader.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/ra

Re: [Mesa-dev] [PATCH 6/7] radeon: Rename bo_handles hashtable to match its actual contents.

2013-10-10 Thread Marek Olšák
Fair enough. Nevermind then. This patch looks good to me, but I'd like somebody who understands DRI image 7 to take a look at the whole series. Marek On Thu, Oct 10, 2013 at 3:11 AM, Christopher James Halse Rogers wrote: > On Wed, Oct 9, 2013 at 8:40 PM, Marek Olšák wrote: >> >> bo_handles_mut

Re: [Mesa-dev] [PATCH 1/2] r600/uvd: fix mapping of UVD surfaces for readback

2013-10-10 Thread Grigori Goronzy
On 10.10.2013 11:41, Christian König wrote: Am 09.10.2013 22:19, schrieb Grigori Goronzy: R600_RESOURCE_FLAG_TRANSFER forces direct mapping, and reading from VRAM is simply too slow. VDPAU GetBitsYCbCr is unusuable. Change to the new PIPE_BIND_LINEAR and adjust r600_transfer_map so that it uses

Re: [Mesa-dev] [PATCH] radeonsi: pass alpha_ref value to PS in the user sgpr

2013-10-10 Thread Michel Dänzer
On Don, 2013-10-10 at 12:49 +0400, Vadim Girlin wrote: > Currently it's hardcoded in the shader, so every change requires > compilation of the shader variant, killing the performance > in Serious Sam 3 and probably other apps. > > This patch passes alpha_ref in the user sgpr and removes it from >

Re: [Mesa-dev] [PATCH 1/2] r600/uvd: fix mapping of UVD surfaces for readback

2013-10-10 Thread Christian König
Am 09.10.2013 22:19, schrieb Grigori Goronzy: R600_RESOURCE_FLAG_TRANSFER forces direct mapping, and reading from VRAM is simply too slow. VDPAU GetBitsYCbCr is unusuable. Change to the new PIPE_BIND_LINEAR and adjust r600_transfer_map so that it uses a staging texture. Looks good on the first

[Mesa-dev] [PATCH] radeonsi: pass alpha_ref value to PS in the user sgpr

2013-10-10 Thread Vadim Girlin
Currently it's hardcoded in the shader, so every change requires compilation of the shader variant, killing the performance in Serious Sam 3 and probably other apps. This patch passes alpha_ref in the user sgpr and removes it from the shader key. Signed-off-by: Vadim Girlin --- src/gallium/driv

[Mesa-dev] Documentation plan: request for comments

2013-10-10 Thread Rogovin, Kevin
Hello all, My current goal is to add documentation to Mesa so that the ramp up time of Mesa goes down a great deal. In addition I wish to create an index of files and data structures keyed by subjects. The use case of such an index is of the form "How does Mesa does functionality foo? Where a

Re: [Mesa-dev] [PATCH 1/3] i965/fs: Allocate more register classes on gen7.

2013-10-10 Thread Kenneth Graunke
On 10/09/2013 09:38 PM, Eric Anholt wrote: > For texturing from GRFs, we now have payloads of arbitrary sizes up to the > message length limit. > > v2 (Kenneth Graunke): Rebase on intel_context -> brw_context change. > v3: Add some comment text. > > Acked-by: Kenneth Graunke > Acked-by: Matt Tur

Re: [Mesa-dev] [PATCH 3/3] doxy-text files added

2013-10-10 Thread Pohjolainen, Topi
On Tue, Oct 08, 2013 at 09:00:33AM +0300, Kevin Rogovin wrote: > --- > doxygen/all.doxy | 1 + > src/gbm/gbm.doxy_text| 15 ++ > src/mesa/drivers/dri/i965/i965.doxy_text | 176 + > src/mesa/main/main.doxy_text | 257 >

[Mesa-dev] [PATCH 5/5] i965/fs: Add support for shadow comparitors with gather4

2013-10-10 Thread Chris Forbes
Note that gather4_po_c's parameters are too long for SIMD16. It might be worth emitting 2xSIMD8 messages in this case at some point. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_fs_generator.cpp | 15 --- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 3 +++ 2 fil

[Mesa-dev] [PATCH 4/5] i965/vs: Add support for shadow comparitors with gather4

2013-10-10 Thread Chris Forbes
gather4_c's argument layout is straightforward -- refz just goes on the end. gather4_po_c's layout however -- the array index is replaced with refz. Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_vec4_generator.cpp | 12 ++-- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp

[Mesa-dev] [PATCH 3/5] i965: Add Gen7 gather4_c and gather4_po_c message types

2013-10-10 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/mesa/drivers/dri/i965/brw_defines.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/mesa/drivers/dri/i965/brw_defines.h b/src/mesa/drivers/dri/i965/brw_defines.h index f1ea736..c0caba6 100644 --- a/src/mesa/drivers/dri/i965/brw_defines.h +++ b/src/me

[Mesa-dev] [PATCH 2/5] glsl: Add new textureGathe[Offset]() overloads for shadow samplers

2013-10-10 Thread Chris Forbes
Signed-off-by: Chris Forbes --- src/glsl/builtin_functions.cpp | 10 ++ 1 file changed, 10 insertions(+) diff --git a/src/glsl/builtin_functions.cpp b/src/glsl/builtin_functions.cpp index ef8b7bb..deedddb 100644 --- a/src/glsl/builtin_functions.cpp +++ b/src/glsl/builtin_functions.cpp @@

[Mesa-dev] [PATCH 1/5] glsl: Add support for separate reference Z for shadow samplers

2013-10-10 Thread Chris Forbes
ARB_gpu_shader5's textureGather*() functions which take shadow samplers have a separate `refz` parameter rather than adding it to the coordinate. Signed-off-by: Chris Forbes --- src/glsl/builtin_functions.cpp | 20 +++- 1 file changed, 15 insertions(+), 5 deletions(-) diff --git

[Mesa-dev] [PATCH 0/5] ARB_gpu_shader5 textureGather*, Part 3

2013-10-10 Thread Chris Forbes
... in which support for shadow samplers is added. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] LLVM at FOSDEM 2014 - Call for papers and participation

2013-10-10 Thread Sylvestre Ledru
Since Mesa is using LLVM, some developers might be interested by the following message (and a talk about Mesa itself would be much appreciated). CALL FOR PAPERS / PARTICIPATION At FOSDEM 2014, LLVM will for the first time participate with a dedicated devroom. Complementing the u

Re: [Mesa-dev] [PATCH 5/6] st/vdpau: add new formats to OutputSurface rendering

2013-10-10 Thread gurketsky
On 09.10.2013 02:23, Grigori Goronzy wrote: +static inline enum pipe_video_chroma_format +FormatYCBCRToPipeChroma(VdpYCbCrFormat vdpau_format) +{ + switch (vdpau_format) { + case VDP_YCBCR_FORMAT_NV12: + return PIPE_VIDEO_CHROMA_FORMAT_420; + case VDP_YCBCR_FORMAT_YV12: +