On 08/30/2013 03:34 PM, Kenneth Graunke wrote:
> On 08/30/2013 02:35 PM, Ian Romanick wrote:
>> From: Ian Romanick
>>
>> Changes to the grammar for GL_ARB_shading_language_420pack (commit
>> 6eec502) moved precision qualifiers out of the type_specifier production
>> chain. This caused declaration
From: Ian Romanick
It looks like commit 53febac removed the last user of that parameter.
Signed-off-by: Ian Romanick
Cc: Paul Berry
---
src/glsl/link_varyings.cpp | 6 +++---
src/glsl/link_varyings.h | 3 +--
2 files changed, 4 insertions(+), 5 deletions(-)
diff --git a/src/glsl/link_varyi
From: Ian Romanick
The vertex shader color outputs (gl_FrontColor, gl_BackColor,
gl_FrontSecondaryColor, and gl_BackSecondaryColor) don't have the same
names as the matching fragment shader color inputs (gl_Color and
gl_SecondaryColor). As a result, the qualifiers on them were not being
properly
From: Ian Romanick
Nothing currently relies on this, but one of the next patches will.
Signed-off-by: Ian Romanick
---
src/glsl/ir_clone.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/glsl/ir_clone.cpp b/src/glsl/ir_clone.cpp
index 9d4178d..a75b3b7 100644
--- a/src/glsl/ir_clone
From: Ian Romanick
The new function, cross_validate_types_and_qualifiers, will have
multiple callers from this file in future commits.
Signed-off-by: Ian Romanick
---
src/glsl/link_varyings.cpp | 171 +
1 file changed, 94 insertions(+), 77 deletions(
On 08/30/2013 02:35 PM, Ian Romanick wrote:
From: Ian Romanick
Changes to the grammar for GL_ARB_shading_language_420pack (commit
6eec502) moved precision qualifiers out of the type_specifier production
chain. This caused declarations such as:
struct S {
lowp float f;
};
t
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
The Gallium changes look good to me.
Marek
On Thu, Aug 15, 2013 at 12:47 PM, Axel Davy wrote:
> Signed-off-by: Axel Davy
> ---
> include/GL/internal/dri_interface.h | 1 +
> src/gallium/drivers/i915/i915_resource.c| 8 ++--
> src/gallium/drivers/ilo/ilo_resource.c | 2 +-
>
From: Ian Romanick
Changes to the grammar for GL_ARB_shading_language_420pack (commit
6eec502) moved precision qualifiers out of the type_specifier production
chain. This caused declarations such as:
struct S {
lowp float f;
};
to generate parse errors. Section 4.1.8 (Structur
Reviewed-by: Marek Olšák
Sorry that my email addresses in reviewed-by's aren't consistent. Old
habits die hard. You can use this one for both patches.
Marek
On Fri, Aug 30, 2013 at 5:48 PM, Michel Dänzer wrote:
> From: Michel Dänzer
>
> Fixes 20 piglit tests with MESA_GL_VERSION_OVERRIDE=3.0.
Reviewed-by: Marek Olšák
Marek
On Fri, Aug 30, 2013 at 5:48 PM, Michel Dänzer wrote:
> From: Michel Dänzer
>
> Fixes assertion failues in 24 piglit tests with
> MESA_GL_VERSION_OVERRIDE=3.0, 12 of which are now passing.
>
> Signed-off-by: Michel Dänzer
> ---
> src/gallium/drivers/radeonsi/r6
On 28 August 2013 16:49, Kenneth Graunke wrote:
> Some drawing functions take a single _mesa_prim object, while others
> take an array of primitives. Both kinds of functions used a parameter
> called "prim" (the singular form), which was confusing.
>
> Using the plural form, "prims," clearly com
On 28 August 2013 16:49, Kenneth Graunke wrote:
> The main GL context's swtnl_im field is the VBO module's vbo_context
> structure. Using the name "swtnl" in the name is confusing since
> some drivers use hardware texturing and lighting, but still rely on the
> VBO module for drawing.
>
> v2: Fo
On 30 August 2013 10:36, Eric Anholt wrote:
> Kenneth Graunke writes:
>
> > can_cut_index_handle_prims() was passed an array of _mesa_prim objects
> > and a count, and runs a loop for that many iterations. However, it
> > treats the array like a pointer, repeatedly checking the first element.
>
On 28 August 2013 16:49, Kenneth Graunke wrote:
> These functions have almost identical code; the only difference is that
> a few of the bits moved around. Adding a few trivial conditionals
> allows the same function to work on all generations, and the resulting
> code is still quite readable.
>
All but patch 4 are:
Reviewed-by: Eric Anholt
pgpQctwfJftck.pgp
Description: PGP signature
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
Kenneth Graunke writes:
> can_cut_index_handle_prims() was passed an array of _mesa_prim objects
> and a count, and runs a loop for that many iterations. However, it
> treats the array like a pointer, repeatedly checking the first element.
>
> This is wasteful and bizarre.
>
> The VBO module wil
Kenneth Graunke writes:
> On 08/29/2013 04:06 PM, Eric Anholt wrote:
>> emit_constants(3DSTATE_CONSTANT_VS, &brw->vs.stage_state);
>
> I'm fine with putting the constant emission into a helper function.
> Although it's simple code, it's quite a few lines, so factoring it out
> would make th
From: Roland Scheidegger
No idea if this is working right but copied straight from llvmpipe.
(Not only does this check the so_target but also use buffer->data instead
of buffer for the mapping.)
Just trying to get rid of a segfault testing something else...
---
src/gallium/drivers/softpipe/sp_dr
On 28 August 2013 05:26, Aras Pranckevicius wrote:
> Hi,
>
> Looking at the code, is there a potential memory leak in GLSL parser wrt
> extension statements?
>
> glsl_lexer.ll has:
> [_a-zA-Z][_a-zA-Z0-9]* {
> yylval->identifier = strdup(yytext);
> return IDENTIFIER;
> }
>
> i
From: Michel Dänzer
Fixes 20 piglit tests with MESA_GL_VERSION_OVERRIDE=3.0.
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/si_state.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeons
From: Michel Dänzer
Fixes assertion failues in 24 piglit tests with
MESA_GL_VERSION_OVERRIDE=3.0, 12 of which are now passing.
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/r600_blit.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/gallium/drivers/rad
Same here.
- Original Message -
> Series LGTM.
>
> Jose
>
> - Original Message -
> > From: Roland Scheidegger
> >
> > Turns out we don't need to do much extra work for detecting this case,
> > since we are guaranteed to get a empty static texture state in this case,
> > hence j
Looks good.
Reviewed-by: Zack Rusin
- Original Message -
> From: Roland Scheidegger
>
> pstipple/aaline stages used PIPE_MAX_SAMPLER instead of
> PIPE_MAX_SHADER_SAMPLER_VIEWS when dealing with sampler views.
> Now these stages can't actually handle sampler_unit != texture_unit anyway
From: Roland Scheidegger
pstipple/aaline stages used PIPE_MAX_SAMPLER instead of
PIPE_MAX_SHADER_SAMPLER_VIEWS when dealing with sampler views.
Now these stages can't actually handle sampler_unit != texture_unit anyway
(they cannot work with d3d10 shaders at all due to using tex not sample
opcode
From: Roland Scheidegger
Turns out we don't need to do much extra work for detecting this case,
since we are guaranteed to get a empty static texture state in this case,
hence just rely on format being 0 and return all zero then.
Previously needed dummy textures (would just have crashed on format
From: Roland Scheidegger
Instead of crashing just return all zero.
---
src/gallium/auxiliary/tgsi/tgsi_exec.c |1 +
src/gallium/drivers/softpipe/sp_tex_sample.c | 30 +-
2 files changed, 26 insertions(+), 5 deletions(-)
diff --git a/src/gallium/auxiliary/tgsi
Series LGTM.
Jose
- Original Message -
> From: Roland Scheidegger
>
> Turns out we don't need to do much extra work for detecting this case,
> since we are guaranteed to get a empty static texture state in this case,
> hence just rely on format being 0 and return all zero then.
> Previo
Series looks good to me.
Jose
- Original Message -
> From: Roland Scheidegger
>
> The only reason this was needed was because the fetch texel function had to
> get the (dynamic) border color, but this is now done much earlier.
> ---
> src/gallium/auxiliary/gallivm/lp_bld_sample_soa.c |
29 matches
Mail list logo
