Commit 53e20b8b introduced the use of a template to initialize some
common fields. Move this copying of fields to before the common vp3
fields are initialized.
Reported-by: Martin Peres
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/nv50/nv98_video.c | 2 +-
src/gallium/drivers/nvc0/nvc0_vi
Currently llvm backend always exports at least one color in pixel
shader even if no color buffers are enabled. With depth/stencil exports
this can result in the following code:
EXPORT PIXEL 0 R0.xyzw VPM
EXPORT PIXEL 61R1.x___ VPM
EXPORT_DONEPIXEL 61R0
https://bugs.freedesktop.org/show_bug.cgi?id=68493
Matt Turner changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
https://bugs.freedesktop.org/show_bug.cgi?id=68493
Priority: medium
Bug ID: 68493
Keywords: regression
CC: i...@freedesktop.org
Assignee: mesa-dev@lists.freedesktop.org
Summary: piglit ARB_uniform_buffer_object compiler
https://bugs.freedesktop.org/show_bug.cgi?id=50482
Henry changed:
What|Removed |Added
OS|All |Solaris
--
You are receiving this mail because:
On Fri, Aug 23, 2013 at 9:02 AM, Paul Berry wrote:
> Shouldn't we make a similar change to brw_vec4_copy_propagation.cpp?
Yes, thanks.
I've folded this change into the patch:
--- a/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.cpp
+++ b/src/mesa/drivers/dri/i965/brw_vec4_copy_propagation.
On Fri, Aug 23, 2013 at 8:57 AM, Paul Berry wrote:
> On 22 August 2013 16:08, Matt Turner wrote:
> Unfortunately, this patch breaks "make check", because
> src/glsl/tests/optimization-test does a strict character-by-character diff
> between the expected and actual output of optimization passes (I
On Fri, Aug 23, 2013 at 8:27 AM, Paul Berry wrote:
> On 22 August 2013 16:08, Matt Turner wrote:
>>
>> ---
>> src/mesa/drivers/dri/i965/brw_fs.cpp | 1 +
>> src/mesa/drivers/dri/i965/brw_fs.h | 1 +
>> src/mesa/drivers/dri/i965/brw_fs_channel_expressions
On Fri, Aug 23, 2013 at 4:57 PM, Kenneth Graunke wrote:
> These are necessary in order to compile the built-in functions.
>
> Signed-off-by: Kenneth Graunke
> ---
Both are Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.o
On Fri, Aug 09, 2013 at 11:59:25AM +0200, Niels Ole Salscheider wrote:
I've pushed the radeonsi patches, I think Francisco is still trying to
review the clover patches.
-Tom
> Signed-off-by: Niels Ole Salscheider
> ---
> src/gallium/state_trackers/clover/api/event.cpp | 26 -
> src/galli
On 08/23/2013 02:05 PM, Paul Berry wrote:
On 23 August 2013 13:55, Brian Paul wrote:
On 08/23/2013 02:39 PM, Matt Turner wrote:
On Fri, Aug 23, 2013 at 1:24 PM, Brian Paul wrote:
In that case, let's fix it by initializing limit to 0 at its declaration.
That way we will get a (helpful) co
On 08/23/2013 11:50 AM, Paul Berry wrote:
If brwNewProgram is asked to create a program for an unrecognized
target, don't bother falling back on _mesa_new_program(). That just
hides bugs.
---
src/mesa/drivers/dri/i965/brw_program.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Me
On 08/23/2013 02:18 PM, Paul Berry wrote:
The disadvantages are that (a) we need an explicit enum value for 0,
and (b) we can't use related operators like |= unless we define
additional overloads.
Disadvantage (a) is trivial, not really a problem.
Disadvantage (b) can be made painless with th
330.frag is a direct copy of 150.frag.
330.glsl is 150.glsl combined with ARB_shader_bit_encoding.glsl.
Signed-off-by: Kenneth Graunke
---
src/glsl/builtins/profiles/330.frag | 140 +
src/glsl/builtins/profiles/330.glsl | 1029 +++
2 files changed, 1169 inser
These are necessary in order to compile the built-in functions.
Signed-off-by: Kenneth Graunke
---
src/glsl/builtins/tools/generate_builtins.py | 4 ++--
src/glsl/main.cpp| 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/src/glsl/builtins/tools/ge
On 08/23/2013 11:50 AM, Paul Berry wrote:
If brwNewProgram is asked to create a program for an unrecognized
target, don't bother falling back on _mesa_new_program(). That just
hides bugs.
---
src/mesa/drivers/dri/i965/brw_program.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff
This is a nice improvement over the explicit cast, which is how I've always
done it in the past - which is the ugly part of an otherwise great method
for flags. Also I use & a lot with enum for clearing bits.
On Fri, Aug 23, 2013 at 3:18 PM, Paul Berry wrote:
> (From a suggestion by Francisco J
On 08/23/2013 02:35 PM, Matt Turner wrote:
On Fri, Aug 23, 2013 at 1:20 PM, Brian Paul wrote:
I don't normally do a 'make install' when I'm working, but I'm trying to do
that now on a 64-bit fedora 19 system.
I want libGL.so*, etc to go into /usr/lib64/ so I configured like this:
./configure
(From a suggestion by Francisco Jerez)
If an enum represents a bitfield of flags, e.g.:
enum E {
A = 1,
B = 2,
C = 4,
D = 8,
};
then C++ normally prohibits statements like this:
enum E x = A | B;
because A and B are implicitly converted to ints before OR-ing them,
and an int can't be s
On 23 August 2013 14:12, Brian Paul wrote:
> ---
> src/glsl/ast_to_hir.cpp |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
> index feff586..0db6b45 100644
> --- a/src/glsl/ast_to_hir.cpp
> +++ b/src/glsl/ast_to_hir.cpp
---
src/glsl/ast_to_hir.cpp |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index feff586..0db6b45 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -1922,7 +1922,7 @@ validate_binding_qualifier(struct _me
From: Roland Scheidegger
In particular noone is interested in the vertex count, so drop that,
and also drop the duplicated num_primitives_generated /
so.primitives_storage_needed variables in drivers. I am unable for now to figure
out if primitives_storage_needed in SO stats (used for d3d10) shou
From: Roland Scheidegger
There's just no way resetting the counters is working with nested/overlapping
queries.
---
src/gallium/drivers/llvmpipe/lp_query.c | 35 ++
src/gallium/drivers/llvmpipe/lp_query.h |1 -
src/gallium/drivers/llvmpipe/lp_setup_vbuf.c
From: Roland Scheidegger
There's just no way resetting the counters is working with nested/overlapping
queries.
---
src/gallium/drivers/softpipe/sp_prim_vbuf.c |2 +-
src/gallium/drivers/softpipe/sp_query.c | 33 +--
2 files changed, 17 insertions(+), 18 deletio
On 23 August 2013 13:55, Brian Paul wrote:
> On 08/23/2013 02:39 PM, Matt Turner wrote:
>
>> On Fri, Aug 23, 2013 at 1:24 PM, Brian Paul wrote:
>>
>>> ---
>>> src/glsl/ast_to_hir.cpp |3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to
On 23 August 2013 13:19, Matt Turner wrote:
> On Fri, Aug 23, 2013 at 8:55 AM, Paul Berry
> wrote:
> > On 22 August 2013 16:08, Matt Turner wrote:
> >>
> >> ---
> >> src/glsl/builtins/ir/frexp.ir | 25
> >> +
> >> src/glsl/builtins/ir/ldexp.ir
On 08/23/2013 02:39 PM, Matt Turner wrote:
On Fri, Aug 23, 2013 at 1:24 PM, Brian Paul wrote:
---
src/glsl/ast_to_hir.cpp |3 +++
1 file changed, 3 insertions(+)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index feff586..24efec6 100644
--- a/src/glsl/ast_to_hir.cpp
++
On Fri, Aug 23, 2013 at 1:24 PM, Brian Paul wrote:
> ---
> src/glsl/ast_to_hir.cpp |3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
> index feff586..24efec6 100644
> --- a/src/glsl/ast_to_hir.cpp
> +++ b/src/glsl/ast_to_hir.cpp
> @@
On Fri, Aug 23, 2013 at 1:20 PM, Brian Paul wrote:
>
> I don't normally do a 'make install' when I'm working, but I'm trying to do
> that now on a 64-bit fedora 19 system.
>
> I want libGL.so*, etc to go into /usr/lib64/ so I configured like this:
>
> ./configure --prefix=/usr --libdir=/usr/lib64
---
src/glsl/ast_to_hir.cpp |3 +++
1 file changed, 3 insertions(+)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index feff586..24efec6 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -1933,6 +1933,9 @@ validate_binding_qualifier(struct _mesa_glsl_parse
I don't normally do a 'make install' when I'm working, but I'm trying to
do that now on a 64-bit fedora 19 system.
I want libGL.so*, etc to go into /usr/lib64/ so I configured like this:
./configure --prefix=/usr --libdir=/usr/lib64
--with-gallium-drivers=svga --with-dri-drivers=swrast --ena
On Fri, Aug 23, 2013 at 8:55 AM, Paul Berry wrote:
> On 22 August 2013 16:08, Matt Turner wrote:
>>
>> ---
>> src/glsl/builtins/ir/frexp.ir | 25
>> +
>> src/glsl/builtins/ir/ldexp.ir | 25
>> +
>> src/glsl/built
All three are
Reviewed-by: Matt Turner
I've committed them to master and will pick them to 9.2 before the release.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
On 08/23/2013 10:40 AM, Kenneth Graunke wrote:
glIsQuery is supposed to return false for names returned by glGenQueries
until their first use. BeginQuery is a use, but QueryCounter is also a
use.
Fixes Piglit's spec/ARB_timer_query/query-lifetime.
Signed-off-by: Kenneth Graunke
Cc: mesa-sta..
On Fri, Aug 23, 2013 at 11:50 AM, Paul Berry wrote:
> If brwNewProgram is asked to create a program for an unrecognized
> target, don't bother falling back on _mesa_new_program(). That just
> hides bugs.
> ---
> src/mesa/drivers/dri/i965/brw_program.c | 3 ++-
> 1 file changed, 2 insertions(+),
Reviewed-by: Matt Turner
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
If brwNewProgram is asked to create a program for an unrecognized
target, don't bother falling back on _mesa_new_program(). That just
hides bugs.
---
src/mesa/drivers/dri/i965/brw_program.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/mesa/drivers/dri/i965/brw_program
On 08/23/2013 10:40 AM, Kenneth Graunke wrote:
glIsQuery is supposed to return false for names returned by glGenQueries
until their first use. BeginQuery is a use, but QueryCounter is also a
use.
Fixes Piglit's spec/ARB_timer_query/query-lifetime.
Signed-off-by: Kenneth Graunke
Cc: mesa-sta..
On 08/23/2013 10:30 AM, Clemens Eisserer wrote:
Hi,
I have verified building from the .tar.bz2 file by doing:
tar -xjf Mesa-9.2.0-rc1.tar.bz2
cd Mesa-9.2.0-rc1
./configure --enable-gallium-llvm --with-llvm-shared-libs
make -j6
I tried to compile it on Fedora-19 + updates-testing with:
./c
glIsQuery is supposed to return false for names returned by glGenQueries
until their first use. BeginQuery is a use, but QueryCounter is also a
use.
Fixes Piglit's spec/ARB_timer_query/query-lifetime.
Signed-off-by: Kenneth Graunke
Cc: mesa-sta...@lists.freedesktop.org
---
src/mesa/main/queryo
After performing "autoreconf -fi" I get a bit further:
/usr/bin/ld: .libs/entry.o: relocation R_X86_64_32S against
`_glapi_Dispatch' can not be used when making a shared object;
recompile with -fPIC
.libs/entry.o: could not read symbols: Bad value
collect2: error: ld returned 1 exit status
gmake[4
Hi,
> I have verified building from the .tar.bz2 file by doing:
>
> tar -xjf Mesa-9.2.0-rc1.tar.bz2
> cd Mesa-9.2.0-rc1
> ./configure --enable-gallium-llvm --with-llvm-shared-libs
> make -j6
I tried to compile it on Fedora-19 + updates-testing with:
./configure --with-dri-drivers=i965 --with-ga
On 08/23/2013 08:06 AM, Brian Paul wrote:
On 08/23/2013 05:13 AM, ZhiLi wrote:
Hi every one,
I am trying to compile Mesa Library version 9.0.3. There is an error,
../../../src/mapi/mapi/stub.c: error: ‘MAPI_TABLE_NUM_STATIC’
undeclared here (not in a function)
I trace the source code, and
On Fri, Aug 23, 2013 at 8:02 AM, Ian Romanick wrote:
> Constant folding support?
Oh, looks like I forgot to rebase in my fixup:
+ case ir_triop_fma:
+ assert(op[0]->type->base_type == GLSL_TYPE_FLOAT);
+ assert(op[1]->type->base_type == GLSL_TYPE_FLOAT);
+ assert(op[2]->type->ba
On Thu, Aug 22, 2013 at 8:35 AM, Paul Berry wrote:
> Ian gave his review to patches 1-22, assuming the noted changes are made.
> If anyone else would like to be mentioned in "Reviewed-by" tags, let me
> know.
On second thought, you can put my Reviewed-by on 1-22 as well.
Thanks Paul!
Matt
__
On 22 August 2013 16:08, Matt Turner wrote:
> ---
> src/glsl/ir_optimization.h | 1 +
> src/glsl/lower_instructions.cpp | 106
>
> 2 files changed, 107 insertions(+)
>
Depending on how we decide to resolve the "ir_expression writing to one of
its
On 22 August 2013 16:08, Matt Turner wrote:
> ---
> src/glsl/ir_optimization.h | 1 +
> src/glsl/lower_instructions.cpp | 128
>
> 2 files changed, 129 insertions(+)
>
> diff --git a/src/glsl/ir_optimization.h b/src/glsl/ir_optimization.h
> index b
On 22 August 2013 16:08, Matt Turner wrote:
> ---
> src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 1 +
> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 6 ++
> src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 6 ++
> 3 files changed, 13 insertions(+)
>
On 22 August 2013 16:08, Matt Turner wrote:
> It's a ?: that operates per-component on vectors. Will be used in
> upcoming lowering passes for frexp and ldexp.
>
Should we modify the boolean variants of mix() in src/glsl/builtins/ir/
mix.ir to make use of this new IR operation?
> ---
> src/gl
On 22 August 2013 16:08, Matt Turner wrote:
> These instructions will be used with immediate arguments in the upcoming
> frexp and ldexp lowering passes.
> ---
> src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/src/mesa/d
On 22 August 2013 16:08, Matt Turner wrote:
> ---
> src/glsl/ir_print_visitor.cpp | 12 +++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/src/glsl/ir_print_visitor.cpp b/src/glsl/ir_print_visitor.cpp
> index 541231a..b518310 100644
> --- a/src/glsl/ir_print_visitor.
On 22 August 2013 16:08, Matt Turner wrote:
> ---
> src/glsl/builtins/ir/frexp.ir | 25
> +
> src/glsl/builtins/ir/ldexp.ir | 25
> +
> src/glsl/builtins/profiles/ARB_gpu_shader5.glsl | 10 ++
> 3 files c
On 22 August 2013 16:08, Matt Turner wrote:
> ---
> src/mesa/drivers/dri/i965/brw_fs.cpp | 1 +
> src/mesa/drivers/dri/i965/brw_fs.h | 1 +
> src/mesa/drivers/dri/i965/brw_fs_channel_expressions.cpp | 1 +
> src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
On 08/23/2013 05:13 AM, ZhiLi wrote:
Hi every one,
I am trying to compile Mesa Library version 9.0.3. There is an error,
../../../src/mapi/mapi/stub.c: error: ‘MAPI_TABLE_NUM_STATIC’
undeclared here (not in a function)
I trace the source code, and find it is not defined.
Did this happen to
From: Michel Dänzer
The stencil values come out wrong without this for some reason.
50 more little piglits.
Cc: mesa-sta...@lists.freedesktop.org
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/radeonsi_shader.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --g
Constant folding support?
On 08/22/2013 04:08 PM, Matt Turner wrote:
---
src/glsl/ir.cpp| 1 +
src/glsl/ir.h | 7 +++
src/glsl/ir_validate.cpp | 1 +
src/mesa/program/ir_to_mesa.cpp| 1 +
src/mesa/st
On 08/22/2013 05:23 PM, Paul Berry wrote:
We never noticed that this field was uninitialized because it is only
used in an error path that reports internal Mesa errors.
But it's silly to have it around anyway because &brw->ctx is
equivalent.
Should fix Coverity defect CID 1063351: Uninitialized
On 08/22/2013 05:33 PM, Timothy Arceri wrote:
Hi guys,
As I'm yet to receive feedback I thought I'd explain more thoroughly what my
patch does to make reviewing it easier.
Currently glDebugMessageControlARB() ALWAYS throws an assertion whenever the
count parameter it set to anything greater t
Just like all other mesa libraries...
CC: "9.2"
---
src/gallium/targets/osmesa/Makefile.am |2 +-
1 fil ändrad, 1 tillägg(+), 1 borttagning(-)
diff --git a/src/gallium/targets/osmesa/Makefile.am
b/src/gallium/targets/osmesa/Makefile.am
index 25fee6f4..8e6aff6c 100644
--- a/src/gallium/targ
As of "2f142d59 build: Add --enable-gallium-osmesa flag." the pkgconfig
file from classic osmesa is no longer installed when building gallium
osmesa, so copy it to gallium osmesa and install the copy instead.
CC: "9.2"
---
configure.ac|1 +
src/gallium/targets/osm
Just like all other gallium targets...
CC: "9.2"
---
src/gallium/targets/osmesa/Makefile.am | 11 ++-
1 fil ändrad, 2 tillägg(+), 9 borttagningar(-)
diff --git a/src/gallium/targets/osmesa/Makefile.am
b/src/gallium/targets/osmesa/Makefile.am
index de78d8cc..25fee6f4 100644
--- a/src/
Hi every one,
I am trying to compile Mesa Library version 9.0.3. There is an error,
../../../src/mapi/mapi/stub.c: error: ‘MAPI_TABLE_NUM_STATIC’> undeclared here
(not in a function)I trace the source code, and find it is not defined.Did this
happen to anyone? Can anyone give me some help?Thanks
Am 22.08.2013 18:20, schrieb Vadim Girlin:
Signed-off-by: Vadim Girlin
Sounds good if it's stable enough.
Reviewed-by: Christian König
---
src/gallium/drivers/r600/r600_asm.c| 3 ++-
src/gallium/drivers/r600/r600_pipe.c | 4 ++--
src/gallium/drivers/r600/r600_pipe.h | 2 +-
sr
2013/8/23 Ian Romanick :
> Mesa 9.2 release candidate 2 is now available for testing.
>
> The tag in the GIT repository for Mesa 9.2-rc2 is 'mesa-9.2-rc2'.
>
> Mesa 9.2 release candidate 2 is available for download at
> ftp://freedesktop.org/pub/mesa/9.2/
>
> md5sums:
>
> 4cde5bbe49658431951e6f5181
64 matches
Mail list logo
