On Mon, Jul 29, 2013 at 8:44 PM, Nikita Malyavin
wrote:
> Kenneth, maybe it's better to mark _mesa_glsl_lex as inline?
The compiler will figure it out.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinf
On Die, 2013-07-30 at 03:45 +0200, Marek Olšák wrote:
> This fixes the F2U opcode for the Mesa driver.
>
> Signed-off-by: Marek Olšák
Reviewed-by: Michel Dänzer
Do you have LLVM SVN write access?
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enth
Kenneth, maybe it's better to mark _mesa_glsl_lex as inline?
2013/7/30 Kenneth Graunke
> YYLEX_PARAM is no longer supported as of Bison 3.0. Instead, the Bison
> developers recommend using %lex-param.
>
> %lex-param takes a type and variable name, similar to %parse-param,
> so you can't pass a
Previously, the piglit test ARB_vertex_array_bgra/api-errors failed because
update_array did not check if normalized == GL_FALSE, and error if so.
Signed-off-by: Corey Richardson
---
src/mesa/main/varray.c | 8
1 file changed, 8 insertions(+)
diff --git a/src/mesa/main/varray.c b/src/m
first i will suggest you to follow these steps
- Update your system
- Start game without Autoconfig option
- Launch game with safe options and so on...
I also have found a presentation tutorial that will resolve your problem You
are only required to follow the steps mentioned in the tutoria
Fixes "Resource leak" defects reported by coverity.
Signed-off-by: Vinson Lee
---
src/mesa/drivers/dri/i915/intel_mipmap_tree.c | 4 +++-
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 +++-
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/src/mesa/drivers/dri/i915/intel_mipmap_
On Mon, Jul 29, 2013 at 11:59:08AM -0700, Chad Versace wrote:
> On 07/25/2013 11:17 PM, Topi Pohjolainen wrote:
> >v2:
> >- upon success close the given file descriptors
> >
> >v3:
> >- use specific entry for dma buffers instead of the basic for
> > primes, and enable the extension bas
On 07/29/2013 12:05 PM, Chris Forbes wrote:
This was never visible before due to the bogus sampler state pointer.
Fixes remaining vertex texturing breakage on Gen4.
Signed-off-by: Chris Forbes
Cc: mesa-sta...@lists.freedesktop.org
---
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 2 +-
1
https://bugs.freedesktop.org/show_bug.cgi?id=67516
--- Comment #3 from Mikko Juola ---
Created attachment 83262
--> https://bugs.freedesktop.org/attachment.cgi?id=83262&action=edit
patch 3/3
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=67516
--- Comment #2 from Mikko Juola ---
Created attachment 83261
--> https://bugs.freedesktop.org/attachment.cgi?id=83261&action=edit
patch 2/3
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=67516
--- Comment #1 from Mikko Juola ---
Created attachment 83260
--> https://bugs.freedesktop.org/attachment.cgi?id=83260&action=edit
patch 1/3
--
You are receiving this mail because:
You are the assignee for the bug.
https://bugs.freedesktop.org/show_bug.cgi?id=67516
Priority: medium
Bug ID: 67516
Assignee: mesa-dev@lists.freedesktop.org
Summary: glTexStorage*() functions don't work properly with
proxy textures
Severity: normal
Classi
This fixes the F2U opcode for the Mesa driver.
Signed-off-by: Marek Olšák
---
lib/Target/R600/SIInstructions.td | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/lib/Target/R600/SIInstructions.td
b/lib/Target/R600/SIInstructions.td
index 0d50c5d..c392238 100644
--- a/lib/Ta
This also allows people who don't want to install the binary blobs
required for VP2 to still get MPEG decoding.
Signed-off-by: Ilia Mirkin
---
v1 -> v2:
- switched to using debug_get_bool_option and NOUVEAU prefix, for which
there is some precedent
src/gallium/drivers/nv50/nv50_context.
Hi,
The attached patches add support for 64-bit loads and stores as well as
64-bit kernel arguments.
-Tom
>From c4c7d934e951e73f72d998a9f1af0a523d83bbed Mon Sep 17 00:00:00 2001
From: Tom Stellard
Date: Tue, 23 Jul 2013 07:52:50 -0700
Subject: [PATCH 1/2] R600: Use 64-bit alignment for 64-bit ke
On Mon, Jul 29, 2013 at 4:07 PM, Kenneth Graunke wrote:
> Bison 3.0 removes the YYLEX_PARAM macro. In preparation for handling
> this using %lex-param, the parser needs a wrapper function for the
> actual Flex lex() function.
Series is Reviewed-by: Matt Turner
__
This also allows people who don't want to install the binary blobs
required for VP2 to still get MPEG decoding.
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/nv50/nv50_context.c | 2 +-
src/gallium/drivers/nv50/nv50_screen.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --
It seems as though at least the NV44 expects the same format as VP2
does. But NV96 expects the format as currently done.
Signed-off-by: Ilia Mirkin
---
src/gallium/drivers/nouveau/nouveau_video.c | 43 +
src/gallium/drivers/nouveau/nouveau_video.h | 2 ++
src/gallium
We are now using functions that operate on the renderbuffer
attachment to handle layered rendering.
Signed-off-by: Jordan Justen
---
src/mesa/drivers/dri/i965/intel_fbo.c | 20
src/mesa/drivers/dri/i965/intel_fbo.h |6 --
2 files changed, 26 deletions(-)
diff --gi
Previously we would mark a renderbuffer as needing a depth resolve.
But, to support layered rendering, we need to look at the attachment
instead, since the attachment knows if layered rendering is being
used.
Signed-off-by: Jordan Justen
---
src/mesa/drivers/dri/i965/brw_clear.c |3 ++-
src/
This function is needed to support layered rendering. With
layered rendering, the attachment stores the state of whether
layered rendering is being used.
Signed-off-by: Jordan Justen
---
src/mesa/drivers/dri/i965/intel_fbo.c | 15 +++
src/mesa/drivers/dri/i965/intel_fbo.h |3 ++
This function marks all slices of a renderbuffer at a particular
level as needing a depth resolve.
Signed-off-by: Jordan Justen
---
src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 12
src/mesa/drivers/dri/i965/intel_mipmap_tree.h |4
2 files changed, 16 insertions(+)
dif
How does this sub-series look as an alternative to
"[PATCH v2 12/13] intel_mipmap_tree: all layers need hiz resolves
with layered rendering"
Jordan Justen (4):
i965: add intel_miptree_set_all_slices_need_depth_resolve
i965: add intel_renderbuffer_att_set_needs_depth_resolve
i965 clear/draw:
Bison 3.0 removes the YYLEX_PARAM macro. In preparation for handling
this using %lex-param, the parser needs a wrapper function for the
actual Flex lex() function.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67354
Signed-off-by: Kenneth Graunke
Cc: mesa-sta...@lists.freedesktop.org
Cc
YYLEX_PARAM is no longer supported as of Bison 3.0. Instead, the Bison
developers recommend using %lex-param.
%lex-param takes a type and variable name, similar to %parse-param,
so you can't pass an arbitrary expression like state->scanner. But Flex
insists on passing the actual scanner object,
YYLEX_PARAM is no longer supported as of Bison 3.0. Instead, the Bison
developers recommend using %lex-param.
%lex-param takes a type and variable name, similar to %parse-param,
so you can't pass an arbitrary expression like state->scanner. But Flex
insists on passing the actual scanner object,
Bison 3.0 removes the YYLEX_PARAM macro. In preparation for handling
this using %lex-param, the parser needs a wrapper function for the
actual Flex lex() function.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=67354
Signed-off-by: Kenneth Graunke
Cc: mesa-sta...@lists.freedesktop.org
Cc
Carl Worth writes:
> I looked closer at the patch and it seems that it's fairly easy to
> backport to the 9.1 branch as seen below.
And looking at the mesa-stable@ list, I see that you already sent an
identical backport. So I'll definitely apply that for now.
-Carl
pgpkZNXMjEbNh.pgp
Descriptio
Carl Worth writes:
> I'm reviewing commits on the mesa master branch that are marked as
> candidates for the stable branch, but have not been applied yet.
>
> The patch below (da33f9b919039442e9ab51f9b1d1c83a73607133) does not
> currently apply cleanly to the 9.1 branch.
>
> If a similar patch is
On Mon, Jul 29, 2013 at 10:55 AM, Kenneth Graunke wrote:
> Fixes Piglit tests glslparsertest/glsl2/draw_buffers-05.vert and
> ARB_draw_instanced/preprocessor/feature-macro-enabled.frag.
Let's delete these tests too. I don't think they're useful.
___
mes
On 07/29/2013 10:55 AM, Kenneth Graunke wrote:
Certain extensions only add functionality to particular shader stages.
(For example, ARB_draw_instanced only adds variables to the vertex
shader stage.)
Previously, we only allowed such extensions to be enabled in the shader
stages where they're use
On 07/25/2013 03:45 PM, Emil Velikov wrote:
Rather than having to keep track of all the build systems and their respecitve
definition of the mesa version, use a single top file VERSION. Every build
system is responsible for reading/parsing the file and using it
v2:
* remove useless bulletpoint f
On Thu, Jul 25, 2013 at 11:31 AM, Kenneth Graunke wrote:
> We already skip this for API_OPENGL_CORE; ES2+ is very similar.
> The primary user of the swrast context is GL_SELECT and GL_FEEDBACK,
> which have never existed in ES.
>
> This saves approximately 18MB of memory in GLBenchmark 2.7 Egypt (
On 07/29/2013 11:57 AM, Chad Versace wrote:
CC'ing Ken.
Ken, these Archlinux users ran into the Bison problem.
A quick and ugly hack is to do:
#define YYLEX_PARAM state->scanner
to
#define scanner state->scanner
I'm looking into how to do %lex-param properly. Looks like glcpp does
it right
This was never visible before due to the bogus sampler state pointer.
Fixes remaining vertex texturing breakage on Gen4.
Signed-off-by: Chris Forbes
Cc: mesa-sta...@lists.freedesktop.org
---
src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
dif
On 07/25/2013 11:17 PM, Topi Pohjolainen wrote:
v2:
- upon success close the given file descriptors
v3:
- use specific entry for dma buffers instead of the basic for
primes, and enable the extension based on the availability
of the hook
v4 (Chad):
- use ARRAY_SIZE
-
CC'ing Ken.
Ken, these Archlinux users ran into the Bison problem.
On 07/29/2013 12:23 AM, Laurent Carlier wrote:
Le samedi 27 juillet 2013 18:03:44 Sandeep a écrit :
Hi,
When I try to build 32 bit Mesa on Arch Linux, I get the following error:
/usr/bin/mkdir -p ../../src/glsl/glcpp
/usr/bin
On 07/25/2013 03:45 PM, Emil Velikov wrote:
Rather than having to keep track of all the build systems and their respecitve
definition of the mesa version, use a single top file VERSION. Every build
system is responsible for reading/parsing the file and using it
v2:
* remove useless bulletpoint f
On 07/28/2013 11:03 PM, Paul Berry wrote:
Previously, we assumed that the only way Mesa would expose geometry
shader support was via the ARB_geometry_shader4 extension. But this
extension has some extra complications over GL 3.2 (interactions with
compatibility-only features, and link-time initi
That looks wrong to me as well. What would make get_indirect_index different in
this case?
- Original Message -
> From: Fabian Bieler
>
> ---
> src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/src/gallium/auxiliary/gallivm/lp_
That looks wrong to me. We already account for the "other fields" in the
vertex_size.
- Original Message -
> From: Bryan Cain
>
> Before, it accounted for the size of the vertices but not the other fields
> in the vertex_header struct, which caused memory corruption.
> ---
> src/galliu
On 07/28/2013 11:03 PM, Paul Berry wrote:
---
src/glsl/builtins/profiles/EXT_texture_array.geom | 12
1 file changed, 12 insertions(+)
create mode 100644 src/glsl/builtins/profiles/EXT_texture_array.geom
diff --git a/src/glsl/builtins/profiles/EXT_texture_array.geom
b/src/glsl
On 29 July 2013 10:55, Kenneth Graunke wrote:
> Certain extensions only add functionality to particular shader stages.
> (For example, ARB_draw_instanced only adds variables to the vertex
> shader stage.)
>
> Previously, we only allowed such extensions to be enabled in the shader
> stages where t
Certain extensions only add functionality to particular shader stages.
(For example, ARB_draw_instanced only adds variables to the vertex
shader stage.)
Previously, we only allowed such extensions to be enabled in the shader
stages where they're useful. However, I've never found any text which
ma
On 19 July 2013 17:32, Jordan Justen wrote:
> git://people.freedesktop.org/~jljusten/mesa ivb-full-depth-buffer-v2
>
> This series converts DEPTH_BUFFER to use the LOD and
> minimum array element fields and always points the
> depth, hiz and stencil buffers at the top of the
> miptree surface.
>
On 07/29/2013 02:34 AM, Chris Forbes wrote:
Fixes broken filter and lod selection for vertex texturing.
(txs/txf only worked properly because they ignore the sampler state
completely)
Signed-off-by: Chris Forbes
Cc: mesa-sta...@lists.freedesktop.org
---
src/mesa/drivers/dri/i965/brw_vs_state.
On 19 July 2013 17:32, Jordan Justen wrote:
> In intel_miptree_slice_set_needs_(depth|hiz)_resolve, if layered
> rendering is being used, then we need to mark all layers as
> needing depth or hiz resolves.
>
I think only intel_miptree_slice_set_needs_depth_resolve() needs to have
this behaviour,
On 19 July 2013 17:32, Jordan Justen wrote:
> For gen >= 7, we will use the lod/minimum-array-element fields to
> support layered rendering. This means that we must restrict
> the depth & stencil attachments to match in various more retrictive
> ways. (Now the width, height, depth, LOD and layer
CTG is still broken even with this patch -- but ILK is fixed.
___
mesa-dev mailing list
mesa-dev@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/mesa-dev
https://bugs.freedesktop.org/show_bug.cgi?id=67411
Roland Scheidegger changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
Fixes broken filter and lod selection for vertex texturing.
(txs/txf only worked properly because they ignore the sampler state
completely)
Signed-off-by: Chris Forbes
Cc: mesa-sta...@lists.freedesktop.org
---
src/mesa/drivers/dri/i965/brw_vs_state.c | 27 +--
1 file chan
https://bugs.freedesktop.org/show_bug.cgi?id=63435
post+...@ralfj.de changed:
What|Removed |Added
Component|Other |EGL
--- Comment #9 from post+...@ralf
Le samedi 27 juillet 2013 18:03:44 Sandeep a écrit :
> Hi,
>
> When I try to build 32 bit Mesa on Arch Linux, I get the following error:
>
> /usr/bin/mkdir -p ../../src/glsl/glcpp
> /usr/bin/mkdir -p ../../src/glsl/glcpp
> YACC glcpp/glcpp-parse.c
> LEX glsl_lexer.cpp
> YACC gl
Hi, check this out:
https://bugs.freedesktop.org/show_bug.cgi?id=67398
A solution is to downgrade to bison 2.7.
--
Bruno
- Mail original -
De: "Sandeep"
À: mesa-dev@lists.freedesktop.org
Envoyé: Dimanche 28 Juillet 2013 03:03:44
Objet: [Mesa-dev] Error building Mesa 32 bit version on A
---
src/glsl/ast.h | 24
src/glsl/ast_to_hir.cpp | 31 +--
src/glsl/glsl_parser.yy | 11 ---
3 files changed, 49 insertions(+), 17 deletions(-)
diff --git a/src/glsl/ast.h b/src/glsl/ast.h
index 3ef9913..a40bbc0 100644
--- a/sr
Section 4.3.8.1 (Input Layout Qualifiers) of the GLSL 1.50 spec
contains some tricky rules for how the sizes of geometry shader input
arrays are related to the input layout specification. In essence,
those rules boil down to the following:
- If an input array declaration does not specify a size,
>From the GLSL ES 3.00 spec:
"All indexes used to index a uniform block array must be constant
integral expressions."
Similar text exists in GLSL specs since 1.50.
When we implemented this, the only type of interface block supported
by Mesa was uniform blocks, so we required all indexes
Geometry shader support in the Mesa front end is still fairly
preliminary. Many features are untested, and the following things are
known not to work:
- The gl_in interface block
- The gl_ClipDistance input
- Transform feedback of geometry shader outputs
- Constants that are new in GLSL 1.50 (e.g
From: Eric Anholt
This gets piglit's geometry-basic test running.
TODO: Still need to validate that the GS layout qualifiers don't get used
in places they shouldn't (like an interface block, or a particular shader
input or output)
---
src/glsl/linker.cpp | 96 +++
From: Eric Anholt
Next step is to validate them at link time.
v2 (Paul Berry ): Don't attempt to export the
layout qualifiers in the event of a compile error, since some of them
are set up by ast_to_hir(), and ast_to_hir() isn't guaranteed to have
run in the event of a compile error.
---
src/gl
From: Eric Anholt
We do some tests of qualifiers using a union containing an int and the
struct full of bitfields, so make sure the bitfields don't spill
outside the int.
---
src/glsl/ast_to_hir.cpp | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_h
From: Eric Anholt
Limited semantic checking (compatibility between declarations, checking
that they're in the right shader target, etc.) is done.
v2: Remove stray debug printfs.
v3 (Paul Berry ): Process input layout
qualifiers at ast_to_hir time rather than at parse time, since certain
error c
From: Fabian Bieler
>From the ARB_geometry_shader4 spec (section Geometry Shader outputs):
"The built-in special variable gl_Position is intended to hold the
homogeneous vertex position. Writing gl_Position is optional."
---
src/mesa/state_tracker/st_program.c | 2 --
1 file changed, 2 deletions
From: Fabian Bieler
The shader interprets the value as an integer.
---
src/gallium/auxiliary/draw/draw_gs.c | 18 ++
1 file changed, 10 insertions(+), 8 deletions(-)
diff --git a/src/gallium/auxiliary/draw/draw_gs.c
b/src/gallium/auxiliary/draw/draw_gs.c
index 78727c6..917f028
From: Bryan Cain
v2 (Bryan Cain ): fix 2D array indexing order.
---
src/mesa/state_tracker/st_glsl_to_tgsi.cpp | 101 ++-
src/mesa/state_tracker/st_program.c| 107 +
2 files changed, 163 insertions(+), 45 deletions(-)
diff --git a/src/
From: Fabian Bieler
---
src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
b/src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c
index c199385..1d27e81 100644
--- a/src/gallium/auxiliary/gallivm/lp_b
From: Fabian Bieler
Reviewed-by: Paul Berry
---
src/mesa/main/api_validate.c | 68
1 file changed, 68 insertions(+)
diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c
index 8a2ec7b..7d4a4c1 100644
--- a/src/mesa/main/api_valida
From: Fabian Bieler
>From section 2.15 (Geometry Shaders) the OpenGL 3.2 spec:
A program object that includes a geometry shader must also include
a vertex shader; otherwise a link error will occur.
Reviewed-by: Paul Berry
---
src/glsl/linker.cpp | 8
1 file changed, 8 inserti
In geometry shaders, outputs are consumed at the time of a call to
EmitVertex() (as opposed to all other shader types, where outputs are
consumed when the shader exits). Therefore, when packing geometry
shader output varyings using lower_packed_varyings, we need to do the
packing at the time of th
From: Fabian Bieler
ARB_geometry_shader4 spec Errors:
"The error INVALID_VALUE is generated by ProgramParameteriARB if
is GEOMETRY_VERTICES_OUT_ARB and is negative."
Reviewed-by: Paul Berry
---
src/mesa/main/shaderapi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/
Since geometry shader inputs are arrays (where the array index
indicates which vertex is being examined), varying packing needs to
treat them differently.
---
src/glsl/ir_optimization.h | 2 +-
src/glsl/link_varyings.cpp | 10 ++-
src/glsl/link_varyings.h | 3 +-
src
This patch modifies lower_packed_varyings to store the packing code it
generates in a temporary exec_list, and then splice that list into the
shader's main() function when it's done. This paves the way for
supporting geometry shader outputs, where we'll have to splice a clone
of the packing code b
>From section 4.3.4 (Inputs) of the GLSL 1.50 spec:
Geometry shader input variables get the per-vertex values written
out by vertex shader output variables of the same names. Since a
geometry shader operates on a set of vertices, each input varying
variable (or input block, see int
---
src/glsl/ast_to_hir.cpp | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
index 431a13d..1d80e6b 100644
--- a/src/glsl/ast_to_hir.cpp
+++ b/src/glsl/ast_to_hir.cpp
@@ -2817,7 +2817,20 @@ ast_declarator_list::hi
The documentation for gl_shader_program.Geom and gl_geometry_program
says that the former is copied to the latter at link time, but this
wasn't happening. This patch causes _mesa_ir_link_shader() to perform
the copy, and updates comment accordingly.
---
src/mesa/main/mtypes.h| 5 -
src/me
From: Bryan Cain
These correspond to the EmitVertex and EndPrimitive functions in GLSL.
v2 (Paul Berry ): Add stub implementations of
new pure visitor functions to i965's vec4_visitor and fs_visitor
classes.
---
src/glsl/ir.h | 51 ++
src
From: Bryan Cain
v2 (Paul Berry ): Account for rework of
builtin_variables.cpp. Use INTERP_QUALIFIER_FLAT for gl_PrimitiveID
so that it will obey provoking vertex conventions. Convert to GLSL
1.50 style geometry shaders.
---
src/glsl/builtin_variables.cpp | 11 +--
src/gl
From: Bryan Cain
v2 (Paul Berry : Split out to separate patch
(previously this was part of "glsl: add builtins for geometry
shaders.")
---
src/mesa/state_tracker/st_program.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/src/mesa/state_tracker/st_program.c
b/src/mesa/state_tracker/
This patch creates a single function to copy the the UsesClipDistance
flag from gl_shader_program.Vert to gl_vertex_program. Previously
this logic was duplicated in the i965-specific function
brw_link_shader() and the core mesa function _mesa_ir_link_shader().
This logic will have to be expanded
From: Bryan Cain
This commit adds all of the parsing and semantics for GLSL 150 style
geometry shaders.
v2 (Paul Berry ): Adjust i965's
brw_link_shader() to pass the new is_geometry_shader argument to
do_set_program_inouts. Add a few missing calls to
get_pipeline_stage(). Fix some signed/unsig
80 matches
Mail list logo
