Fixes uninitialized pointer field defect reported by Coverity.
Signed-off-by: Vinson Lee
---
src/glsl/glsl_parser_extras.cpp | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/src/glsl/glsl_parser_extras.cpp b/src/glsl/glsl_parser_extras.cpp
index f4087df..9690a6d 100644
--- a
On 07/03/2013 06:01 PM, Carl Worth wrote:
[snip]
I can guess a few items:
* Patches must be bug fixes only, not feature work.
Essentially, no new GL features - but hardware enabling is okay. For
example, backporting basic Bay Trail support would be OK.
Performance patches are also generall
On 07/03/2013 10:50 AM, Paul Berry wrote:
driver->ProgramStringNotify is only called for ARB programs, fixed
function vertex programs, and ir_to_mesa (which isn't used by the i965
back-end). Therefore, even after geometry shaders are added,
brwProgramStringNotify should only ever be called with
On 07/03/2013 06:01 PM, Carl Worth wrote:
Ian Romanick writes:
1. Carl Worth is taking over stable releases from me, so I'd like to
increase the rate of stable releases from (nominally) monthly to every
two weeks.
Thanks. I'm happy to help here. So I'll plan to release 9.1.5 on July
15, (just
On 06/29/2013 07:43 PM, Matt Turner wrote:
---
src/glsl/ast_function.cpp | 108 +-
1 file changed, 60 insertions(+), 48 deletions(-)
diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_function.cpp
index bbc607a..53bf2b1 100644
--- a/src/glsl/ast_
On 07/03/2013 03:36 PM, Matt Turner wrote:
On Wed, Jul 3, 2013 at 3:13 PM, Chad Versace
wrote:
However, I don't know how you're using this in future patches, so it's
your call.
I actually am making a copy of an ast_struct_specifier from a pointer
to an ast_struct_specifier. (in 14/14)
new(ct
Patches 1-6 (patch 4 w/Ken & Chad's suggestions) are:
Reviewed-by: Ian Romanick
On 06/29/2013 07:43 PM, Matt Turner wrote:
---
src/glsl/ast_function.cpp | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/src/glsl/ast_function.cpp b/src/glsl/ast_functio
Ian Romanick writes:
> 1. Carl Worth is taking over stable releases from me, so I'd like to
> increase the rate of stable releases from (nominally) monthly to every
> two weeks.
Thanks. I'm happy to help here. So I'll plan to release 9.1.5 on July
15, (just 1.5 weeks away now).
> Instead of th
Dave Airlie writes:
> There should be a reason for doing 2, btw just stating I'd like to do
> this doesn't give us any advantages over what we have now. Whats the
> point, stopping hackers? etc.
If md5sums are to be used to verify that the release tar files have not
been modified, then users need
Series looks good AFAICT.
Reviewed-by: Jose Fonseca
- Original Message -
> The semantics for overflow detection are a bit tricky with
> indexed rendering. If the base index in the elements array
> overflows, then the index of the first element should be used,
> if the index with bias ov
> On 07/03/2013 02:33 PM, Zack Rusin wrote:
> > - Original Message -
> >> The code looks good AFAICT. Just a few style nits below.
> >>
> >> For both: Reviewed-by: Brian Paul
> >
> > Thanks a lot for the review.
> >
> >
> >>>#define DRAW_GET_IDX(_elts, _i) \
> >>> -
On Wed, Jul 3, 2013 at 3:13 PM, Chad Versace
wrote:
> However, I don't know how you're using this in future patches, so it's
> your call.
I actually am making a copy of an ast_struct_specifier from a pointer
to an ast_struct_specifier. (in 14/14)
new(ctx) ast_struct_specifier(*struct_type->struc
On Wed, Jul 3, 2013 at 2:52 PM, Chad Versace
wrote:
> On 07/03/2013 12:01 PM, Matt Turner wrote:
>>
>> ---
>> src/glsl/ast.h | 16
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/src/glsl/ast.h b/src/glsl/ast.h
>> index b86f97b..3bb33c5 100644
>> --- a/src/glsl/ast.h
>>
On 07/03/2013 02:33 PM, Zack Rusin wrote:
- Original Message -
The code looks good AFAICT. Just a few style nits below.
For both: Reviewed-by: Brian Paul
Thanks a lot for the review.
#define DRAW_GET_IDX(_elts, _i) \
- (((_i) >= draw->pt.user.eltMax) ? 0 :
On 07/03/2013 12:03 PM, Matt Turner wrote:
---
src/glsl/ast.h | 12
1 file changed, 12 insertions(+)
diff --git a/src/glsl/ast.h b/src/glsl/ast.h
index 3bb33c5..f00ef3a 100644
--- a/src/glsl/ast.h
+++ b/src/glsl/ast.h
@@ -453,6 +453,18 @@ class ast_declarator_list;
class ast_s
Am 03.07.2013 07:42, schrieb Zack Rusin:
> The semantics for overflow detection are a bit tricky with
> indexed rendering. If the base index in the elements array
> overflows, then the index of the first element should be used,
> if the index with bias overflows then it should be treated
> like a n
On 07/03/2013 12:01 PM, Matt Turner wrote:
---
src/glsl/ast.h | 16
1 file changed, 16 insertions(+)
diff --git a/src/glsl/ast.h b/src/glsl/ast.h
index b86f97b..3bb33c5 100644
--- a/src/glsl/ast.h
+++ b/src/glsl/ast.h
@@ -469,6 +469,22 @@ public:
class ast_type_specifier :
Required by GL_ARB_shading_language_420pack.
Parts based on work done by Todd Previte and Ken Graunke, implementing
basic support for C-style initializers of arrays.
---
src/glsl/ast.h | 5 ++
src/glsl/ast_to_hir.cpp | 14 +++-
src/glsl/glsl_parser.yy | 57 +++
- Original Message -
> The code looks good AFAICT. Just a few style nits below.
>
> For both: Reviewed-by: Brian Paul
Thanks a lot for the review.
> > #define DRAW_GET_IDX(_elts, _i) \
> > - (((_i) >= draw->pt.user.eltMax) ? 0 : (_elts)[_i])
> > + (((_i) >= dr
https://bugs.freedesktop.org/show_bug.cgi?id=66559
Alex Deucher changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop. |sitewranglers@lists.freedes
https://bugs.freedesktop.org/show_bug.cgi?id=66559
--- Comment #1 from Laurent Pinchart ---
Created attachment 81977
--> https://bugs.freedesktop.org/attachment.cgi?id=81977&action=edit
GPG public key
--
You are receiving this mail because:
You are the assignee for the bug.
__
https://bugs.freedesktop.org/show_bug.cgi?id=66559
Priority: medium
Bug ID: 66559
Assignee: mesa-dev@lists.freedesktop.org
Summary: Account request with git commit access to mesa/drm
Severity: normal
Classification: Unclassified
---
src/glsl/ast.h | 12
1 file changed, 12 insertions(+)
diff --git a/src/glsl/ast.h b/src/glsl/ast.h
index 3bb33c5..f00ef3a 100644
--- a/src/glsl/ast.h
+++ b/src/glsl/ast.h
@@ -453,6 +453,18 @@ class ast_declarator_list;
class ast_struct_specifier : public ast_node {
public:
+
---
src/glsl/ast.h | 16
1 file changed, 16 insertions(+)
diff --git a/src/glsl/ast.h b/src/glsl/ast.h
index b86f97b..3bb33c5 100644
--- a/src/glsl/ast.h
+++ b/src/glsl/ast.h
@@ -469,6 +469,22 @@ public:
class ast_type_specifier : public ast_node {
public:
+ /**
+* \bri
driver->ProgramStringNotify is only called for ARB programs, fixed
function vertex programs, and ir_to_mesa (which isn't used by the i965
back-end). Therefore, even after geometry shaders are added,
brwProgramStringNotify should only ever be called with a target of
GL_VERTEX_PROGRAM_ARB or GL_FRAG
The code looks good AFAICT. Just a few style nits below.
For both: Reviewed-by: Brian Paul
On 07/02/2013 11:42 PM, Zack Rusin wrote:
The semantics for overflow detection are a bit tricky with
indexed rendering. If the base index in the elements array
overflows, then the index of the first e
Am 03.07.2013 17:28, schrieb Jose Fonseca:
> I don't fully grasp every detail (many paths), but looks good in principle.
>
> Where do the 16xf32 vectors come from?
Those are the size vectors. Normally (except for 1d case) these contain
width/height/depth/_ (or just width/height for 2d texture).
So
https://bugs.freedesktop.org/show_bug.cgi?id=66552
Chad Versace changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop. |chad.vers...@linux.intel.co
https://bugs.freedesktop.org/show_bug.cgi?id=66552
Priority: medium
Bug ID: 66552
Assignee: mesa-dev@lists.freedesktop.org
Summary: Binding GL vs GLES API should affect only
eglCreateContext
Severity: minor
Classification
The semantics for overflow detection are a bit tricky with
indexed rendering. If the base index in the elements array
overflows, then the index of the first element should be used,
if the index with bias overflows then it should be treated
like a normal overflow. Also overflows need to be checked f
The comparison, incorrectly, was greater-than-or-equal to
elt max.
Signed-off-by: Zack Rusin
---
src/gallium/auxiliary/draw/draw_llvm.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/auxiliary/draw/draw_llvm.c
b/src/gallium/auxiliary/draw/draw_llvm.c
index f9
https://bugs.freedesktop.org/show_bug.cgi?id=66476
José Fonseca changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|---
I don't fully grasp every detail (many paths), but looks good in principle.
Where do the 16xf32 vectors come from?
Also, please add a comment somewhere summarizing all the code paths for lod
handling:
- AVX vs non AVX
- SOA vs AOS
- scalar lod vs stamp lod
But I couldn't spot anything wrong
https://bugs.freedesktop.org/show_bug.cgi?id=66476
--- Comment #1 from Brian Paul ---
Vinson, I'm not seeing that error here with current git (559adef2).
Retest?
--
You are receiving this mail because:
You are the assignee for the bug.
___
mesa-dev ma
https://bugs.freedesktop.org/show_bug.cgi?id=66357
Brian Paul changed:
What|Removed |Added
Assignee|mesa-dev@lists.freedesktop. |matts...@gmail.com
|org
From: Roland Scheidegger
d3d10 requires per-pixel lod calculations for explicit lod, lod bias and
explicit derivatives, and we should probably do it for OpenGL too - at least
if they are used from vertex or geometry shaders (so doesn't apply to lod
bias) this doesn't just affect neighboring pixel
On 06/28/2013 01:31 AM, Tom Stellard wrote:
From: Chih-Wei Huang
Add the sb CXX files to the Android Makefile and also stop using some
c++11 features.
---
src/gallium/drivers/r600/Android.mk | 5 +++--
src/gallium/drivers/r600/sb/sb_bc.h | 4 ++--
src/gallium/drivers/r600/sb
On 06/29/2013 07:43 PM, Matt Turner wrote:
---
src/glsl/ast.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/src/glsl/ast.h b/src/glsl/ast.h
index df2a21f..af7fcd9 100644
--- a/src/glsl/ast.h
+++ b/src/glsl/ast.h
@@ -526,6 +526,7 @@ public:
struct _mesa_glsl_pars
38 matches
Mail list logo
