Re: [Mesa-dev] [PATCH 1/2] r600g/llvm: use native encode for tex

For the series: Reviewed-by: Tom Stellard When you commit these can you update drivers/radeon/LLVM_REVISION.txt with the revision number of the llvm commits these patches depend on? Thanks, Tom On Thu, Mar 28, 2013 at 12:40:52AM +0100, Vincent Lejeune wrote: > --- > src/gallium/drivers/r600/r

Re: [Mesa-dev] [PATCH 2/2] R600: Emit CF_ALU and use true kcache register.

On Thu, Mar 28, 2013 at 12:40:19AM +0100, Vincent Lejeune wrote: > --- Thanks for working on this, it is a very nice improvement. See my comments inline. > lib/Target/R600/AMDGPU.h | 1 + > lib/Target/R600/AMDGPUTargetMachine.cpp| 1 + > lib/Target/R600

Re: [Mesa-dev] [PATCH 1/2] R600: Emit native instructions for tex

On Thu, Mar 28, 2013 at 12:40:18AM +0100, Vincent Lejeune wrote: > --- Just a few style issues, with those changes, this patch is: Reviewed-by: Tom Stellard > lib/Target/R600/MCTargetDesc/R600MCCodeEmitter.cpp | 169 > + > lib/Target/R600/R600Instructions.td

[Mesa-dev] [PATCH] gallivm: cleanup the gs interface

Instead of void pointers use a base interface. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_llvm.c | 77 --- src/gallium/auxiliary/gallivm/lp_bld_tgsi.h | 25 src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 31 - 3 files

Re: [Mesa-dev] [PATCH 0/6] Gallivm GS and related cleanups

> Wow, that's a lot of code to digest, but it looks good AFAICT (without > spending hours on it). I just found some minor nits. > > Nice work! > > Reviewed-by: Brian Paul Thanks Brian! I'm sorry about the large patch, it was one of those "just sit down and do it" types of coding sessions and b

[Mesa-dev] [PATCH] docs: add a new page documenting known application issues

Let's try to update this when we find other broken applications... --- docs/application-issues.html | 83 ++ docs/contents.html |1 + 2 files changed, 84 insertions(+), 0 deletions(-) create mode 100644 docs/application-issues.html diff --g

[Mesa-dev] [PATCH] intel: add and use the always_have_depth_buffer DRI config option

When set to true, create all GLX visual configs with a depth buffer. Used to allow apps such as Topogun to work properly on Linux. This is just like the option recently added for gallium DRI drivers. -- Note: I only compile-tested this. It would be great if an Intel developer could test. A free

[Mesa-dev] [PATCH 2/2] r600g/llvm: Add support for cf_alu native encode

--- src/gallium/drivers/r600/r600_asm.c| 2 +- src/gallium/drivers/r600/r600_asm.h| 1 + src/gallium/drivers/r600/r600_shader.c | 14 ++ 3 files changed, 16 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_asm.c b/src/gallium/drivers/r600/r600_asm.c i

[Mesa-dev] [PATCH 1/2] r600g/llvm: use native encode for tex

--- src/gallium/drivers/r600/r600_shader.c | 50 ++ 1 file changed, 27 insertions(+), 23 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 29facf7..1e21559 100644 --- a/src/gallium/drivers/r600/r600_sha

[Mesa-dev] [PATCH 2/2] R600: Emit CF_ALU and use true kcache register.

--- lib/Target/R600/AMDGPU.h | 1 + lib/Target/R600/AMDGPUTargetMachine.cpp| 1 + lib/Target/R600/MCTargetDesc/R600MCCodeEmitter.cpp | 10 +- lib/Target/R600/R600EmitClauseMarkers.cpp | 243 + lib/Target/R600/R600Instructions.

[Mesa-dev] [PATCH 1/2] R600: Emit native instructions for tex

--- lib/Target/R600/MCTargetDesc/R600MCCodeEmitter.cpp | 169 + lib/Target/R600/R600Instructions.td| 156 +++ 2 files changed, 196 insertions(+), 129 deletions(-) diff --git a/lib/Target/R600/MCTargetDesc/R600MCCodeEmitter.cpp b/lib/Target/R600

Re: [Mesa-dev] [PATCH 2/3] i965/fs: Generate LOD sampler message from ir_lod.

On 03/19/2013 11:51 AM, Matt Turner wrote: --- src/mesa/drivers/dri/i965/brw_defines.h|2 ++ src/mesa/drivers/dri/i965/brw_fs.cpp |4 +++- src/mesa/drivers/dri/i965/brw_fs_emit.cpp |6 ++ src/mesa/drivers/dri/i965/brw_fs_visitor.cpp |9 +

Re: [Mesa-dev] [PATCH 4/4] glsl: Generated masked write instead of vector array index for UBO lowering

On 03/27/2013 09:30 AM, Ian Romanick wrote: From: Ian Romanick When reading a column from a row-major matrix, we would slot the single value read into the vector using an ir_dereference_array of the vector with a constant index. This will (eventually) get optimized to a masked-write, so just g

[Mesa-dev] [Bug 61364] LLVM assertion when starting X11

https://bugs.freedesktop.org/show_bug.cgi?id=61364 Darxus changed: What|Removed |Added CC||dar...@chaosreigns.com -- You are receiving th

Re: [Mesa-dev] Haiku using the Wayland state_tracker?

On 03/27/2013 2:37 am, Pekka Paalanen wrote: On Tue, 26 Mar 2013 16:47:15 -0500 Alexander von Gluck IV wrote: I've been hitting several brick walls working on the Haiku GL stuff. (mostly due to things being too complex for the time I have available) Given all the recent publicity for Waylan

Re: [Mesa-dev] [PATCH 1/4] glsl: Add missing bool case in glsl_type::get_scalar_type

On Wed, Mar 27, 2013 at 9:30 AM, Ian Romanick wrote: > From: Ian Romanick > > Since the case was missing bec4->get_scalar_type() would return bvec4, bvec4. Series is Reviewed-by: Matt Turner > but vec4->get_scalar_type() would return float. > > NOTE: This is a candidate for stable branches. >

[Mesa-dev] [PATCH] r600g: fix range handling for tgsi input/output declarations

Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_shader.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/r600/r600_shader.c b/src/gallium/drivers/r600/r600_shader.c index 29facf7..d4c9c03 100644 --- a/src/gallium/drivers/

[Mesa-dev] [PATCH] radeonsi: remove sampler writemask

From: Christian König Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_shader.c b/src/gallium/drivers/radeonsi/radeonsi_shader.c index

[Mesa-dev] [PATCH 2/4] glsl: Replace constant-index vector array accesses with swizzles

From: Ian Romanick Search and replace: ][0] -> ].x ][1] -> ].y ][2] -> ].z ][3] -> ].w Fixes piglit tests inverse-mat[234].{vert,frag}. These tests call the inverse function with constant parameters and expect proper constant folding to happen. My suspicion is that this patch

[Mesa-dev] [PATCH 3/4] glsl: Replace open-coded dot-product with dot

From: Ian Romanick Signed-off-by: Ian Romanick Cc: Eric Anholt Cc: Paul Berry --- src/glsl/builtins/glsl/determinant.glsl | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/glsl/builtins/glsl/determinant.glsl b/src/glsl/builtins/glsl/determinant.glsl index 78751

[Mesa-dev] [PATCH 4/4] glsl: Generated masked write instead of vector array index for UBO lowering

From: Ian Romanick When reading a column from a row-major matrix, we would slot the single value read into the vector using an ir_dereference_array of the vector with a constant index. This will (eventually) get optimized to a masked-write, so just generate the masked write in the first place.

[Mesa-dev] [PATCH 1/4] glsl: Add missing bool case in glsl_type::get_scalar_type

From: Ian Romanick Since the case was missing bec4->get_scalar_type() would return bvec4, but vec4->get_scalar_type() would return float. NOTE: This is a candidate for stable branches. Signed-off-by: Ian Romanick --- src/glsl/glsl_types.cpp | 2 ++ 1 file changed, 2 insertions(+) diff --git

[Mesa-dev] [PATCH 0/4] Begin some ir_dereference_array-of-a-vector rework

This is the first of three patch series that I'm going to send related to reworking ir_dereference_array of vectors. The final series end with ir_dereference_array of vectors being completely removed from the IR. The first series is a set of fixes for bugs that I discovered along the way. The fi

[Mesa-dev] [PATCH] winsys/radeon: add command stream replay dump for faulty lockup v2

From: Jerome Glisse Build time option, set RADEON_CS_DUMP_ON_LOCKUP to 1 in radeon_drm_cs.h to enable it. When enabled after each cs submission the code will try to detect lockup by waiting on one of the buffer of the cs to become idle, after a timeout it will consider that the cs triggered a lo

Re: [Mesa-dev] [PATCH] winsys/radeon: add command stream replay dump for faulty lockup

On Wed, Mar 27, 2013 at 4:38 PM, Jerome Glisse wrote: > On Wed, Mar 27, 2013 at 11:27 AM, wrote: >> From: Jerome Glisse >> >> Build time option, set RADEON_CS_DUMP_ON_LOCKUP to 1 in radeon_drm_cs.h to >> enable it. >> >> When enabled after each cs submission the code will try to detect lockup b

Re: [Mesa-dev] [PATCH] winsys/radeon: add command stream replay dump for faulty lockup

On Wed, Mar 27, 2013 at 11:27 AM, wrote: > From: Jerome Glisse > > Build time option, set RADEON_CS_DUMP_ON_LOCKUP to 1 in radeon_drm_cs.h to > enable it. > > When enabled after each cs submission the code will try to detect lockup by > waiting on one of the buffer of the cs to become idle, afte

[Mesa-dev] [PATCH 4/4] radeonsi: add instance divisor support v3

From: Christian König v2: reduce key size, don't copy key around to much. v3: remove key size reduction Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 67 +++- src/gallium/drivers/radeonsi/radeonsi_shader.h | 24 + src/galliu

[Mesa-dev] [PATCH 2/4] radeonsi: add instanceid support

From: Christian König Signed-off-by: Christian König Reviewed-by: Michel Dänzer Tested-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_pipe.c |2 +- src/gallium/drivers/radeonsi/radeonsi_shader.c | 35 ++-- src/gallium/drivers/radeonsi/radeonsi_shader.h

[Mesa-dev] [PATCH 1/4] radeon/llvm: move system value fetching to common code

From: Christian König This should be used by both SI and R600. Signed-off-by: Christian König Reviewed-by: Michel Dänzer Tested-by: Michel Dänzer --- src/gallium/drivers/r600/r600_llvm.c | 12 .../drivers/radeon/radeon_setup_tgsi_llvm.c| 12

[Mesa-dev] [PATCH 3/4] radeonsi: add start instance support

From: Christian König This works different than on R600, we need to add the start instance manually. Signed-off-by: Christian König Reviewed-by: Michel Dänzer Tested-by: Michel Dänzer --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 13 - src/gallium/drivers/radeonsi/radeon

[Mesa-dev] [PATCH] winsys/radeon: add command stream replay dump for faulty lockup

From: Jerome Glisse Build time option, set RADEON_CS_DUMP_ON_LOCKUP to 1 in radeon_drm_cs.h to enable it. When enabled after each cs submission the code will try to detect lockup by waiting on one of the buffer of the cs to become idle, after a timeout it will consider that the cs triggered a lo

Re: [Mesa-dev] [PATCH 3/3] llvmpipe/draw: Fix texture sampling in geometry shaders

On 03/26/2013 06:56 PM, Zack Rusin wrote: We weren't correctly propagating the samplers and sampler views when they were related to geometry shaders. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_context.c |4 +- src/gallium/auxiliary/draw/draw_llvm.c | 83

Re: [Mesa-dev] [PATCH 0/6] Gallivm GS and related cleanups

On 03/26/2013 10:38 AM, Zack Rusin wrote: This set implements code generation of geometry shaders in the LLVM paths. There are some cleanups that will follow (e.g. changing the input array to handle lp_native vectors and not TGSI_NUM_CHANNELS) but all the simple examples are working and as far as

Re: [Mesa-dev] [PATCH 6/6] gallivm: implement breakc and implicit primitive flushing

On 03/26/2013 10:38 AM, Zack Rusin wrote: we were missing implementation of the breakc instruction and our TGSI semantics currently require an implicit endprim at the end of GS if none is present - this implements both. Maybe I'm dense, but off-hand I don't see the relationship between endprim

Re: [Mesa-dev] [PATCH 5/6] gallium/llvm: implement geometry shaders in the llvm paths

On 03/26/2013 10:38 AM, Zack Rusin wrote: This commits implements code generation of the geometry shaders in the SOA paths. All the code is there but bugs are likely present. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_context.c | 17 +- src/gallium/auxiliary/draw

Re: [Mesa-dev] [PATCH 4/6] draw/gs: Fetch more than one primitive per invocation

On 03/26/2013 10:38 AM, Zack Rusin wrote: Allows executing gs on up to 4 primitives at a time. Will also be required by the llvm code because there we definitely don't want to flush with just a single primitive. Signed-off-by: Zack Rusin --- src/gallium/auxiliary/draw/draw_gs.c | 54

Re: [Mesa-dev] [PATCH] radeonsi: add cs tracing v2

On Wed, Mar 27, 2013 at 4:45 AM, Christian König wrote: > Am 27.03.2013 01:43, schrieb Jerome Glisse: > >> On Tue, Mar 26, 2013 at 6:45 PM, Dave Airlie wrote: >> >> correctly). But Marek is quite right that this only counts for state >> objects >> and makes no sense for set_* and

Re: [Mesa-dev] [PATCH 4/4] radeonsi: add instance divisor support

On Wed, Mar 27, 2013 at 1:43 PM, Alex Deucher wrote: > On Wed, Mar 27, 2013 at 7:25 AM, Michel Dänzer wrote: >> On Mit, 2013-03-27 at 12:02 +0100, Christian König wrote: >>> Am 26.03.2013 18:03, schrieb Michel Dänzer: >>> > On Die, 2013-03-26 at 17:37 +0100, Christian König wrote: >>> >> Am 26.03

Re: [Mesa-dev] [PATCH 4/4] radeonsi: add instance divisor support

On Wed, Mar 27, 2013 at 7:25 AM, Michel Dänzer wrote: > On Mit, 2013-03-27 at 12:02 +0100, Christian König wrote: >> Am 26.03.2013 18:03, schrieb Michel Dänzer: >> > On Die, 2013-03-26 at 17:37 +0100, Christian König wrote: >> >> Am 26.03.2013 15:56, schrieb Michel Dänzer: >> >>> On Die, 2013-03-2

Re: [Mesa-dev] [PATCH] radeonsi: Handle arbitrary 2-byte formats in resource_copy_region

Am 27.03.2013 12:44, schrieb Michel Dänzer: From: Michel Dänzer Fixes mplayer -vo vdpau OSD. Reported-by: Igor Vagulin Signed-off-by: Michel Dänzer Reviewed-by: Christian König Tested-by: Christian König --- src/gallium/drivers/radeonsi/r600_blit.c | 6 ++ 1 file changed, 6 inse

[Mesa-dev] [PATCH] radeonsi: Handle arbitrary 2-byte formats in resource_copy_region

From: Michel Dänzer Fixes mplayer -vo vdpau OSD. Reported-by: Igor Vagulin Signed-off-by: Michel Dänzer --- src/gallium/drivers/radeonsi/r600_blit.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/src/gallium/drivers/radeonsi/r600_blit.c b/src/gallium/drivers/radeonsi/r600_blit.c i

Re: [Mesa-dev] [PATCH 4/4] radeonsi: add instance divisor support

On Mit, 2013-03-27 at 12:02 +0100, Christian König wrote: > Am 26.03.2013 18:03, schrieb Michel Dänzer: > > On Die, 2013-03-26 at 17:37 +0100, Christian König wrote: > >> Am 26.03.2013 15:56, schrieb Michel Dänzer: > >>> On Die, 2013-03-26 at 14:51 +0100, Christian König wrote: > From: Christ

Re: [Mesa-dev] [PATCH 4/4] radeonsi: add instance divisor support

Am 27.03.2013 12:02, schrieb Christian König: Am 26.03.2013 18:03, schrieb Michel Dänzer: On Die, 2013-03-26 at 17:37 +0100, Christian König wrote: Am 26.03.2013 15:56, schrieb Michel Dänzer: On Die, 2013-03-26 at 14:51 +0100, Christian König wrote: From: Christian König Signed-off-by: Chri

Re: [Mesa-dev] [PATCH 4/4] radeonsi: add instance divisor support

Am 26.03.2013 18:03, schrieb Michel Dänzer: On Die, 2013-03-26 at 17:37 +0100, Christian König wrote: Am 26.03.2013 15:56, schrieb Michel Dänzer: On Die, 2013-03-26 at 14:51 +0100, Christian König wrote: From: Christian König Signed-off-by: Christian König [...] diff --git a/src/gallium/dri

[Mesa-dev] [PATCH] radeonsi: add instance divisor support v2

From: Christian König v2: reduce key size, don't copy key around to much. Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/radeonsi_shader.c | 67 +++- src/gallium/drivers/radeonsi/radeonsi_shader.h | 24 + src/gallium/drivers/radeonsi/si_state.c

Re: [Mesa-dev] [PATCH] radeonsi: add cs tracing v2

Am 27.03.2013 01:43, schrieb Jerome Glisse: On Tue, Mar 26, 2013 at 6:45 PM, Dave Airlie wrote: correctly). But Marek is quite right that this only counts for state objects and makes no sense for set_* and draw_* calls (and I'm currently thinking how to avoid that and can't come up with a prope

Re: [Mesa-dev] [PATCH] radeonsi: add cs tracing v2

Am 27.03.2013 00:30, schrieb Dave Airlie: On 27 Mar 2013 08:45, "Dave Airlie" wrote: correctly). But Marek is quite right that this only counts for state objects and makes no sense for set_* and draw_* calls (and I'm currently thinking how to avoid that and can't come up with a proper solution)

Re: [Mesa-dev] Haiku using the Wayland state_tracker?

On Tue, 26 Mar 2013 16:47:15 -0500 Alexander von Gluck IV wrote: > I've been hitting several brick walls working on the Haiku GL stuff. > (mostly due to things being too complex for the time I have available) > > Given all the recent publicity for Wayland, I decided to look into the > wl_shm s