[Mesa-dev] [Bug 57121] corrupted GLSL built-in function results when using Uniform Buffer contents as arguments

2013-02-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=57121 Markus Wick changed: What|Removed |Added Assignee|mesa-dev@lists.freedesktop. |i...@freedesktop.org |or

[Mesa-dev] [PATCH] DRI2: Don't disable GLX_INTEL_swap_event unconditionally

2013-02-14 Thread Zack Rusin
GLX_INTEL_swap_event is broken on the server side, where it's currently unconditionally enabled. This completely breaks systems running on drivers which don't support that extension. There's no way to test for its presence on this side, so instead of disabling it uncondtionally, just disable it for

Re: [Mesa-dev] [PATCH 2/3] gallivm: fix src modifier fetching with non-float types.

2013-02-14 Thread Roland Scheidegger
Am 15.02.2013 04:41, schrieb Dave Airlie: >> From: Roland Scheidegger >> >> Need to take the type into account. Also, if we want to allow >> mov's with modifiers we need to pick a type (assume float). > > Just FYI, the r600g hw all ignores modifiers on non-floating types from > memory. It looks

Re: [Mesa-dev] [PATCH 2/3] gallivm: fix src modifier fetching with non-float types.

2013-02-14 Thread Dave Airlie
> From: Roland Scheidegger > > Need to take the type into account. Also, if we want to allow > mov's with modifiers we need to pick a type (assume float). Just FYI, the r600g hw all ignores modifiers on non-floating types from memory. Dave. ___ mesa-de

Re: [Mesa-dev] [PATCH 3/3] gallivm/tgsi: fix issues with sample opcodes

2013-02-14 Thread Roland Scheidegger
This is actually really a RFC. Another solution would be to also encode the target (either with or without shadow information) in the instruction too though it seems a bit unnatural for these instructions. Or to not encode them as Texture instructions (so as before) but then some other method is ne

[Mesa-dev] [PATCH 3/3] gallivm/tgsi: fix issues with sample opcodes

2013-02-14 Thread sroland
From: Roland Scheidegger We need to encode them as Texture instructions since the NumOffsets field is encoded there. However, we don't encode the actual target in there, this is derived from the sampler view src later. --- src/gallium/auxiliary/gallivm/lp_bld_tgsi.h |2 + src/gallium/au

[Mesa-dev] [PATCH 2/3] gallivm: fix src modifier fetching with non-float types.

2013-02-14 Thread sroland
From: Roland Scheidegger Need to take the type into account. Also, if we want to allow mov's with modifiers we need to pick a type (assume float). --- src/gallium/auxiliary/gallivm/lp_bld_tgsi.c | 54 ++- 1 file changed, 52 insertions(+), 2 deletions(-) diff --git a/sr

[Mesa-dev] [PATCH 1/3] gallivm: DIV shouldn't be deprecated.

2013-02-14 Thread sroland
From: Roland Scheidegger (Though it looks glsl won't emit it.) --- src/gallium/auxiliary/gallivm/lp_bld_tgsi.c |1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/auxiliary/gallivm/lp_bld_tgsi.c b/src/gallium/auxiliary/gallivm/lp_bld_tgsi.c index a4fea7d..53c81bd 100644 --- a/src/

[Mesa-dev] [Bug 59187] [Steam] Black screen but audio song On TF2 (Intel HM 55/ Ironlake Mobile)

2013-02-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=59187 Benjamin Berg changed: What|Removed |Added CC||benja...@sipsolutions.net -- You are re

Re: [Mesa-dev] [PATCH] st/mesa: fix format query for GL_ARB_texture_rg

2013-02-14 Thread Marek Olšák
Reviewed-by: Marek Olšák Marek On Thu, Feb 14, 2013 at 8:26 PM, Brian Paul wrote: > The GL_ARB_texture_rg spec says that we need to support both texturing > and rendering for the GL_RED and GL_RG formats. So move the format > check up into the rendertarget_mapping[] list. Also, add > PIPE_FOR

Re: [Mesa-dev] [PATCH 1/7] st/mesa: factor out code for determining blit.mask from CopyTexSubImage

2013-02-14 Thread Marek Olšák
On Thu, Feb 14, 2013 at 9:23 PM, Brian Paul wrote: > On 02/14/2013 07:53 AM, Marek Olšák wrote: >> >> I'll need this later. >> --- >> src/mesa/state_tracker/st_cb_texture.c | 108 >> +++- >> 1 file changed, 66 insertions(+), 42 deletions(-) >> > > The series looks g

Re: [Mesa-dev] gl.h: Version mumbo-jumbo and Copyright?

2013-02-14 Thread Sedat Dilek
On Thu, Feb 14, 2013 at 9:26 PM, Brian Paul wrote: > On 02/14/2013 01:10 PM, Sedat Dilek wrote: >> >> Hi, >> >> noticed when polishing up my build-scripts fot libdrm | mesa | >> xf86-video-intel (last one requires gl.h). >> >> /* >> * Mesa 3-D graphics library >> * Version: 7.6<--- ??? > > >

Re: [Mesa-dev] r600g: status of my work on the shader optimization

2013-02-14 Thread Vadim Girlin
On 02/14/2013 08:53 PM, Stefan Seifert wrote: Hi! Amazing work! I see some 50 % speed ups in FlightGear and even more. While normally 3D clouds tear performance down to an unflyable stutter, with your branch I can fly in densly clouded conditions at usable framerates. I can now turn all shaders

Re: [Mesa-dev] [PATCH 3/6] i965/fs: Do a general SEND dependency workaround for the original 965.

2013-02-14 Thread Ian Romanick
On 02/13/2013 07:07 PM, Kenneth Graunke wrote: On 02/06/2013 05:29 PM, Eric Anholt wrote: We'd been ad-hoc inserting instructions in some SEND messages with no knowledge of when it was required (so extra instructions), but not all SENDs (so not often enough). This should do much better than tha

Re: [Mesa-dev] gl.h: Version mumbo-jumbo and Copyright?

2013-02-14 Thread Ian Romanick
On 02/14/2013 12:29 PM, Sedat Dilek wrote: On Thu, Feb 14, 2013 at 9:26 PM, Brian Paul wrote: On 02/14/2013 01:10 PM, Sedat Dilek wrote: Hi, noticed when polishing up my build-scripts fot libdrm | mesa | xf86-video-intel (last one requires gl.h). /* * Mesa 3-D graphics library * Versi

Re: [Mesa-dev] [PATCH] i965/gen7: Set up all samplers even if samplers are sparsely used.

2013-02-14 Thread Kenneth Graunke
On 02/14/2013 09:08 AM, Eric Anholt wrote: In GLSL, sampler indices are allocated contiguously from 0. But in the case of ARB_fragment_program (and possibly fixed function), an app that uses texture 0 and 2 will use sampler indices 0 and 2, so we were only allocating space for samplers 0 and 1 a

Re: [Mesa-dev] gl.h: Version mumbo-jumbo and Copyright?

2013-02-14 Thread Brian Paul
On 02/14/2013 01:10 PM, Sedat Dilek wrote: Hi, noticed when polishing up my build-scripts fot libdrm | mesa | xf86-video-intel (last one requires gl.h). /* * Mesa 3-D graphics library * Version: 7.6<--- ??? I could remove that obsolete line. * * Copyright (C) 1999-2006 Brian Paul

[Mesa-dev] gl.h: Version mumbo-jumbo and Copyright?

2013-02-14 Thread Sedat Dilek
Hi, noticed when polishing up my build-scripts fot libdrm | mesa | xf86-video-intel (last one requires gl.h). /* * Mesa 3-D graphics library * Version: 7.6 <--- ??? * * Copyright (C) 1999-2006 Brian Paul All Rights Reserved. <--- ??? * Copyright (C) 2009 VMware, Inc. All Rights Reserve

Re: [Mesa-dev] [PATCH 1/7] st/mesa: factor out code for determining blit.mask from CopyTexSubImage

2013-02-14 Thread Brian Paul
On 02/14/2013 07:53 AM, Marek Olšák wrote: I'll need this later. --- src/mesa/state_tracker/st_cb_texture.c | 108 +++- 1 file changed, 66 insertions(+), 42 deletions(-) The series looks good to me. Regarding patch 4 (the blit-based Tex[Sub]Image change), under

Re: [Mesa-dev] r600g: status of my work on the shader optimization

2013-02-14 Thread Vadim Girlin
On 02/14/2013 08:53 PM, Stefan Seifert wrote: Hi! Amazing work! I see some 50 % speed ups in FlightGear and even more. While normally 3D clouds tear performance down to an unflyable stutter, with your branch I can fly in densly clouded conditions at usable framerates. I can now turn all shaders

[Mesa-dev] [PATCH] st/mesa: fix format query for GL_ARB_texture_rg

2013-02-14 Thread Brian Paul
The GL_ARB_texture_rg spec says that we need to support both texturing and rendering for the GL_RED and GL_RG formats. So move the format check up into the rendertarget_mapping[] list. Also, add PIPE_FORMAT_R8_UNORM to the list of formats required. Note: This is a candidate for the stable branch

[Mesa-dev] [Bug 60737] In GLSL ES, a missing FS precision qualifier does not generate an error

2013-02-14 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=60737 Paul Berry changed: What|Removed |Added Priority|medium |low --- Comment #2 from Paul Berry --- (In

Re: [Mesa-dev] [PATCH 1/4] r600g/llvm: Add support for UBO

2013-02-14 Thread Tom Stellard
On Thu, Feb 14, 2013 at 05:48:33PM +0100, Vincent Lejeune wrote: For the series: Reviewed-by: Tom Stellard > NOTE: This is a candidate for the Mesa stable branch. > --- > src/gallium/drivers/r600/r600_llvm.c| 6 +- > src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 17

Re: [Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-14 Thread Tom Stellard
On Thu, Feb 14, 2013 at 06:34:14PM +0100, Christian König wrote: > From: Christian König > > Signed-off-by: Christian König For the series: Reviewed-by: Tom Stellard Don't forget to mark these as candidates for the stable branch. > --- > lib/Target/R600/AMDGPUStructurizeCFG.cpp | 66 >

Re: [Mesa-dev] [PATCH v3] R600/SI: Fix int_SI_fs_interp_constant

2013-02-14 Thread Tom Stellard
On Thu, Feb 14, 2013 at 07:38:04PM +0100, Christian König wrote: > Am 14.02.2013 19:30, schrieb Michel Dänzer: > > From: Michel Dänzer > > > > The important fix is that the constant interpolation value is stored in the > > parameter slot P0, which is encoded as 2. > > > > In addition, drop the SI_

Re: [Mesa-dev] [PATCH 2/2] R600: Support for TBO

2013-02-14 Thread Tom Stellard
On Thu, Feb 14, 2013 at 05:47:12PM +0100, Vincent Lejeune wrote: Reviewed-by: Tom Stellard > NOTE: This is a candidate for the Mesa stable branch. > --- > lib/Target/R600/MCTargetDesc/R600MCCodeEmitter.cpp | 3 +- > lib/Target/R600/R600Instructions.td| 54 > +++

Re: [Mesa-dev] [PATCH 1/2] R600: Increase number of ArrayBase Reg to 32

2013-02-14 Thread Tom Stellard
On Thu, Feb 14, 2013 at 05:47:11PM +0100, Vincent Lejeune wrote: Reviewed-by: Tom Stellard > --- > lib/Target/R600/R600RegisterInfo.td | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/Target/R600/R600RegisterInfo.td > b/lib/Target/R600/R600RegisterInfo.td > inde

Re: [Mesa-dev] [PATCH v3] R600/SI: Fix int_SI_fs_interp_constant

2013-02-14 Thread Christian König
Am 14.02.2013 19:30, schrieb Michel Dänzer: From: Michel Dänzer The important fix is that the constant interpolation value is stored in the parameter slot P0, which is encoded as 2. In addition, drop the SI_INTERP_CONST pseudo instruction, pass the parameter slot as an operand to V_INTERP_MOV_

[Mesa-dev] [PATCH v3] R600/SI: Fix int_SI_fs_interp_constant

2013-02-14 Thread Michel Dänzer
From: Michel Dänzer The important fix is that the constant interpolation value is stored in the parameter slot P0, which is encoded as 2. In addition, drop the SI_INTERP_CONST pseudo instruction, pass the parameter slot as an operand to V_INTERP_MOV_F32 instead of hardcoding it there, and add a

[Mesa-dev] [PATCH 12/12] R600/SI: Add pattern to simplify i64 loading

2013-02-14 Thread Christian König
From: Christian König Signed-off-by: Christian König --- lib/Target/R600/SIInstrInfo.td|4 lib/Target/R600/SIInstructions.td |5 + 2 files changed, 9 insertions(+) diff --git a/lib/Target/R600/SIInstrInfo.td b/lib/Target/R600/SIInstrInfo.td index efc6015..8c4e5af 100644 --

[Mesa-dev] [PATCH 11/12] R600/SI: nuke SReg_1 v3

2013-02-14 Thread Christian König
From: Christian König It's completely unnecessary and can be replace with proper SReg_64 handling instead. This actually fixes a piglit test on SI. v2: use correct register class in addRegisterClass, set special classes as not allocatable v3: revert setting special classes as not allocateab

[Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling v3

2013-02-14 Thread Christian König
From: Christian König Seems to be allot simpler, and also paves the way for further improvements. v2: rebased on master, use 0 in BUFFER_LOAD_FORMAT_XYZW, use VGPR0 in dummy EXP, avoid compiler warning, break after encoding the first literal. v3: correctly use V_ADD_F32_e64 Signed-off-b

[Mesa-dev] [PATCH 09/12] R600/SI: replace AllReg_* with [SV]Src_* v2

2013-02-14 Thread Christian König
From: Christian König Mark all the operands that can also have an immediate. v2: SOFFSET is also an SSrc_32 operand Signed-off-by: Christian König --- lib/Target/R600/SIInstrFormats.td | 36 +-- lib/Target/R600/SIInstructions.td | 128 ++--- lib/Targ

[Mesa-dev] [PATCH 08/12] R600/SI: fix VOPC encoding v2

2013-02-14 Thread Christian König
From: Christian König Previously it only worked because of coincident. v2: fix 64bit versions, use 0x80 (inline 0) instead of SGPR0 for the unused SRC2 Signed-off-by: Christian König --- lib/Target/R600/SIInstrFormats.td | 53 +++-- 1 file changed, 16 ins

[Mesa-dev] [PATCH 07/12] R600/SI: move *_Helper definitions to SIInstrFormat.td

2013-02-14 Thread Christian König
From: Christian König Signed-off-by: Christian König --- lib/Target/R600/SIInstrFormats.td | 66 + lib/Target/R600/SIInstrInfo.td| 66 - 2 files changed, 66 insertions(+), 66 deletions(-) diff --git a/lib/Target/R6

[Mesa-dev] [PATCH 06/12] R600/SI: remove some more unused code

2013-02-14 Thread Christian König
From: Christian König Signed-off-by: Christian König --- lib/Target/R600/AMDGPUCodeEmitter.h| 45 lib/Target/R600/MCTargetDesc/AMDGPUMCCodeEmitter.h |7 --- 2 files changed, 52 deletions(-) delete mode 100644 lib/Target/R600/AMDGPUCodeEmitter.h diff

[Mesa-dev] [PATCH 05/12] R600/structurizer: improve inverting conditions

2013-02-14 Thread Christian König
From: Christian König Stop adding more instructions than necessary. Signed-off-by: Christian König --- lib/Target/R600/AMDGPUStructurizeCFG.cpp | 40 +- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/lib/Target/R600/AMDGPUStructurizeCFG.cpp b/lib/T

[Mesa-dev] [PATCH 04/12] R600/structurizer: improve loop handling

2013-02-14 Thread Christian König
From: Christian König Generate more than one loop if it seems to make sense. Signed-off-by: Christian König --- lib/Target/R600/AMDGPUStructurizeCFG.cpp | 344 +- 1 file changed, 148 insertions(+), 196 deletions(-) diff --git a/lib/Target/R600/AMDGPUStructurizeCFG

[Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-14 Thread Christian König
From: Christian König Signed-off-by: Christian König --- lib/Target/R600/AMDGPUStructurizeCFG.cpp | 66 ++ 1 file changed, 66 insertions(+) diff --git a/lib/Target/R600/AMDGPUStructurizeCFG.cpp b/lib/Target/R600/AMDGPUStructurizeCFG.cpp index c4c9762..86cb04a 100

[Mesa-dev] [PATCH 02/12] R600/structurizer: improve PHI value finding

2013-02-14 Thread Christian König
From: Christian König Using the new NearestCommonDominator class. Signed-off-by: Christian König --- lib/Target/R600/AMDGPUStructurizeCFG.cpp |6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/Target/R600/AMDGPUStructurizeCFG.cpp b/lib/Target/R600/AMDGPUStructurizeCFG.cpp index

[Mesa-dev] [PATCH 03/12] R600/structurizer: improve finding condition values

2013-02-14 Thread Christian König
From: Christian König Using the new NearestCommonDominator class. Signed-off-by: Christian König --- lib/Target/R600/AMDGPUStructurizeCFG.cpp | 31 +- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/lib/Target/R600/AMDGPUStructurizeCFG.cpp b/lib/Ta

Re: [Mesa-dev] [PATCH v2] R600/SI: Fix INTERP_CONST.

2013-02-14 Thread Tom Stellard
On Thu, Feb 14, 2013 at 06:07:16PM +0100, Michel Dänzer wrote: > On Mit, 2013-02-13 at 17:51 +0100, Christian König wrote: > > Am 13.02.2013 17:07, schrieb Michel Dänzer: > > > From: Michel Dänzer > > > > > > The important fix is that the constant interpolation value is stored in > > > the > > >

[Mesa-dev] [PATCH] i965/gen7: Set up all samplers even if samplers are sparsely used.

2013-02-14 Thread Eric Anholt
In GLSL, sampler indices are allocated contiguously from 0. But in the case of ARB_fragment_program (and possibly fixed function), an app that uses texture 0 and 2 will use sampler indices 0 and 2, so we were only allocating space for samplers 0 and 1 and setting up sampler 0. We would read garba

Re: [Mesa-dev] [PATCH v2] R600/SI: Fix INTERP_CONST.

2013-02-14 Thread Michel Dänzer
On Mit, 2013-02-13 at 17:51 +0100, Christian König wrote: > Am 13.02.2013 17:07, schrieb Michel Dänzer: > > From: Michel Dänzer > > > > The important fix is that the constant interpolation value is stored in the > > parameter slot P0, which is encoded as 2. > > > > In addition, pass the parameter

Re: [Mesa-dev] r600g: status of my work on the shader optimization

2013-02-14 Thread Stefan Seifert
Hi! Amazing work! I see some 50 % speed ups in FlightGear and even more. While normally 3D clouds tear performance down to an unflyable stutter, with your branch I can fly in densly clouded conditions at usable framerates. I can now turn all shaders to maximum and enjoy the view. This makes a h

Re: [Mesa-dev] [PATCH 3/6] i965/fs: Do a general SEND dependency workaround for the original 965.

2013-02-14 Thread Eric Anholt
Kenneth Graunke writes: > On 02/06/2013 05:29 PM, Eric Anholt wrote: >> We'd been ad-hoc inserting instructions in some SEND messages with no >> knowledge of when it was required (so extra instructions), but not all SENDs >> (so not often enough). This should do much better than that, though it'

[Mesa-dev] [PATCH 4/4] r600g/llvm: Support for TBO

2013-02-14 Thread Vincent Lejeune
--- src/gallium/drivers/r600/r600_llvm.c | 29 + 1 file changed, 29 insertions(+) diff --git a/src/gallium/drivers/r600/r600_llvm.c b/src/gallium/drivers/r600/r600_llvm.c index 59047e7..89bcb79 100644 --- a/src/gallium/drivers/r600/r600_llvm.c +++ b/src/gallium/driver

[Mesa-dev] [PATCH 3/4] r600g/llvm: Set Inputs/Outputs count to 32 (api reported value)

2013-02-14 Thread Vincent Lejeune
--- src/gallium/drivers/radeon/radeon_llvm.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/radeon_llvm.h b/src/gallium/drivers/radeon/radeon_llvm.h index bfeacb5..b1e025b 100644 --- a/src/gallium/drivers/radeon/radeon_llvm.h +++ b/src/gallium/d

[Mesa-dev] [PATCH 2/4] r600g/llvm: Fix alpha_to_one piglit tests

2013-02-14 Thread Vincent Lejeune
--- src/gallium/drivers/r600/r600_llvm.c | 2 ++ src/gallium/drivers/r600/r600_shader.c | 1 + src/gallium/drivers/radeon/radeon_llvm.h | 1 + 3 files changed, 4 insertions(+) diff --git a/src/gallium/drivers/r600/r600_llvm.c b/src/gallium/drivers/r600/r600_llvm.c index 7a41688..59047e7 10

[Mesa-dev] [PATCH 1/4] r600g/llvm: Add support for UBO

2013-02-14 Thread Vincent Lejeune
NOTE: This is a candidate for the Mesa stable branch. --- src/gallium/drivers/r600/r600_llvm.c| 6 +- src/gallium/drivers/radeon/radeon_setup_tgsi_llvm.c | 17 + 2 files changed, 22 insertions(+), 1 deletion(-) diff --git a/src/gallium/drivers/r600/r600_llvm.c

[Mesa-dev] [PATCH 2/2] R600: Support for TBO

2013-02-14 Thread Vincent Lejeune
NOTE: This is a candidate for the Mesa stable branch. --- lib/Target/R600/MCTargetDesc/R600MCCodeEmitter.cpp | 3 +- lib/Target/R600/R600Instructions.td| 54 ++ lib/Target/R600/R600Intrinsics.td | 2 + 3 files changed, 58 insertions(+), 1 dele

[Mesa-dev] [PATCH 1/2] R600: Increase number of ArrayBase Reg to 32

2013-02-14 Thread Vincent Lejeune
--- lib/Target/R600/R600RegisterInfo.td | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Target/R600/R600RegisterInfo.td b/lib/Target/R600/R600RegisterInfo.td index 3812eb7..0718854 100644 --- a/lib/Target/R600/R600RegisterInfo.td +++ b/lib/Target/R600/R600RegisterInfo.

Re: [Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling v2

2013-02-14 Thread Michel Dänzer
On Don, 2013-02-14 at 16:20 +0100, Christian König wrote: > Am 14.02.2013 15:14, schrieb Michel Dänzer: > > On Don, 2013-02-14 at 14:35 +0100, Michel Dänzer wrote: > >> On Don, 2013-02-14 at 11:43 +0100, Christian König wrote: > >>> +// Only one literal allowed > >>> +break; > >> The same

Re: [Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling v2

2013-02-14 Thread Christian König
Am 14.02.2013 15:14, schrieb Michel Dänzer: On Don, 2013-02-14 at 14:35 +0100, Michel Dänzer wrote: On Don, 2013-02-14 at 11:43 +0100, Christian König wrote: +// Only one literal allowed +break; The same literal could be used for several operands though. :) Basically, it seems like we

Re: [Mesa-dev] [PATCH 2/3] i965: Don't record a WAW dependency between implicit MRF operations.

2013-02-14 Thread Paul Berry
On 13 February 2013 21:11, Eric Anholt wrote: > Kenneth Graunke writes: > > > On 02/13/2013 06:31 PM, Eric Anholt wrote: > >> Kenneth Graunke writes: > >> > >>> Meta-instructions that implicitly write then read/consume a MRF value > >>> don't pose write-after-write conflicts with each other, si

[Mesa-dev] [PATCH 7/7] st/mesa: remove what is left from u_blit

2013-02-14 Thread Marek Olšák
--- src/mesa/state_tracker/st_cb_blit.c| 16 src/mesa/state_tracker/st_cb_blit.h|7 --- src/mesa/state_tracker/st_cb_flush.c |1 - src/mesa/state_tracker/st_cb_texture.c |1 - src/mesa/state_tracker/st_context.c|2 -- src/mesa/state_tracker/st_c

[Mesa-dev] [PATCH 6/7] st/mesa: simplify and improve CopyTexSubImage

2013-02-14 Thread Marek Olšák
It has become a bit messy. Changes: - finally correct checking for transfer ops depending on the base format - making sure the base internal format and the texture format match (we were ignoring it, but it's important for correctness) - the way-too-strict rule that both src and dst base forma

[Mesa-dev] [PATCH 5/7] st/mesa: don't do sRGB conversion in CopyTexSubImage

2013-02-14 Thread Marek Olšák
Assuming I understand EXT_texture_sRGB correctly. NOTE: This is a candidate for the stable branches. --- src/mesa/state_tracker/st_cb_texture.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture

[Mesa-dev] [PATCH 4/7] st/mesa: implement blit-based TexImage and TexSubImage

2013-02-14 Thread Marek Olšák
A temporary texture is created such that it matches the format and type combination and pixels are copied to it using memcpy. Then the blit is used to copy the temporary texture to the texture image being modified by TexImage or TexSubImage. The blit takes care of the format and type conversion and

[Mesa-dev] [PATCH 3/7] st/mesa: fix blit-based GetTexImage for 1D array textures

2013-02-14 Thread Marek Olšák
This is not easy to hit, because we have 3 code paths now (tried in this order): - memcpy-based (skips the blit) -> _mesa_tex_getimage - blit-based - slow pixel packing -> _mesa_tex_getimage The main difference later in the code is the parameters of _mesa_image_address3d. --- src/mesa/state_track

[Mesa-dev] [PATCH 2/7] st/mesa: fix blit-based GetTexImage for depth/stencil formats

2013-02-14 Thread Marek Olšák
BTW, we have 0 tests for glGetTexImage(format=GL_DEPTH*). --- src/mesa/state_tracker/st_cb_texture.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index 5b3d2ab..b0d4ea5 100644 --- a/src/mesa/

[Mesa-dev] [PATCH 1/7] st/mesa: factor out code for determining blit.mask from CopyTexSubImage

2013-02-14 Thread Marek Olšák
I'll need this later. --- src/mesa/state_tracker/st_cb_texture.c | 108 +++- 1 file changed, 66 insertions(+), 42 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index f8ff024..5b3d2ab 100644 --- a/src/mesa/st

Re: [Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling v2

2013-02-14 Thread Michel Dänzer
On Don, 2013-02-14 at 15:14 +0100, Michel Dänzer wrote: > On Don, 2013-02-14 at 14:35 +0100, Michel Dänzer wrote: > > On Don, 2013-02-14 at 11:43 +0100, Christian König wrote: > > > > > > +// Only one literal allowed > > > +break; > > > > The same literal could be used for several oper

Re: [Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling v2

2013-02-14 Thread Michel Dänzer
On Don, 2013-02-14 at 14:35 +0100, Michel Dänzer wrote: > On Don, 2013-02-14 at 11:43 +0100, Christian König wrote: > > > > +// Only one literal allowed > > +break; > > The same literal could be used for several operands though. :) Basically, it seems like we're pretty close to allowin

Re: [Mesa-dev] [PATCH 1/3] R600/SI: Add pattern for sign extension of i1 to i32.

2013-02-14 Thread Tom Stellard
On Wed, Feb 13, 2013 at 06:54:45PM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > 16 more little piglits with radeonsi. > > NOTE: This is a candidate for the Mesa stable branch. > > Signed-off-by: Michel Dänzer It would be great if you could add some lit tests for these. For the serie

Re: [Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling v2

2013-02-14 Thread Michel Dänzer
On Don, 2013-02-14 at 11:43 +0100, Christian König wrote: > From: Christian König > > Seems to be allot simpler, and also paves the > way for further improvements. > > v2: rebased on master, use 0 in BUFFER_LOAD_FORMAT_XYZW, > use VGPR0 in dummy EXP, avoid compiler warning, break > afte

Re: [Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-14 Thread Christian König
Please ignore this version of the patchset, it was send accidentally from the wrong machine and so doesn't contain the correct patches. Christian. Am 14.02.2013 11:42, schrieb Christian König: From: Christian König Signed-off-by: Christian König --- lib/Target/R600/AMDGPUStructurizeCFG.cp

[Mesa-dev] Thank you! I love it!

2013-02-14 Thread Martin Steigerwald
Dear developers and testers of Mesa (oh, that would included myself a bit:), thank you for working on this great piece of software! I love it! Special thanks to Kenneth Graunke for bettering my Planeshift gaming experience to such a huge extent. Best, -- Martin ___

Re: [Mesa-dev] r600g: status of my work on the shader optimization

2013-02-14 Thread Henri Verbeet
On 14 February 2013 12:28, Christian König wrote: > Well apart from a bit strange coding style and the use of SVN, I can't > really see any problems that are related to using LLVM as it is. > Well, for one, I don't think LLVM believes in stable APIs or shared libraries, and I think some of the bui

Re: [Mesa-dev] r600g: status of my work on the shader optimization

2013-02-14 Thread Christian König
Am 14.02.2013 12:05, schrieb Henri Verbeet: On 14 February 2013 11:42, Christian König wrote: nice work, I think you've made quite a progress here, but on the other hand it should be clear that the LLVM backend is the future and we should concentrate on that. I'm not sure that's really true.

Re: [Mesa-dev] r600g: status of my work on the shader optimization

2013-02-14 Thread Henri Verbeet
On 14 February 2013 11:42, Christian König wrote: > nice work, I think you've made quite a progress here, but on the other hand > it should be clear that the LLVM backend is the future and we should > concentrate on that. > I'm not sure that's really true. My impression is that LLVM has a number o

[Mesa-dev] [PATCH 12/12] R600/SI: Add pattern to simplify i64 loading

2013-02-14 Thread Christian König
From: Christian König Signed-off-by: Christian König --- lib/Target/R600/SIInstrInfo.td|4 lib/Target/R600/SIInstructions.td |5 + 2 files changed, 9 insertions(+) diff --git a/lib/Target/R600/SIInstrInfo.td b/lib/Target/R600/SIInstrInfo.td index efc6015..8c4e5af 100644 --

[Mesa-dev] [PATCH 11/12] R600/SI: nuke SReg_1 v2

2013-02-14 Thread Christian König
From: Christian König It's completely unnecessary and can be replace with proper SReg_64 handling instead. This actually fixes a piglit test on SI. v2: use correct register class in addRegisterClass, set special classes as not allocatable Signed-off-by: Christian König --- lib/Target/R60

[Mesa-dev] [PATCH 10/12] R600/SI: cleanup literal handling v2

2013-02-14 Thread Christian König
From: Christian König Seems to be allot simpler, and also paves the way for further improvements. v2: rebased on master, use 0 in BUFFER_LOAD_FORMAT_XYZW, use VGPR0 in dummy EXP, avoid compiler warning, break after encoding the first literal. Signed-off-by: Christian König --- lib/Tar

[Mesa-dev] [PATCH 09/12] R600/SI: replace AllReg_* with [SV]Src_* v2

2013-02-14 Thread Christian König
From: Christian König Mark all the operands that can also have an immediate. v2: SOFFSET is also an SSrc_32 operand Signed-off-by: Christian König --- lib/Target/R600/SIInstrFormats.td | 36 +-- lib/Target/R600/SIInstructions.td | 128 ++--- lib/Targ

[Mesa-dev] [PATCH 08/12] R600/SI: fix VOPC encoding v2

2013-02-14 Thread Christian König
From: Christian König Previously it only worked because of coincident. v2: fix 64bit versions, use 0x80 (inline 0) instead of SGPR0 for the unused SRC2 Signed-off-by: Christian König --- lib/Target/R600/SIInstrFormats.td | 53 +++-- 1 file changed, 16 ins

[Mesa-dev] [PATCH 07/12] R600/SI: move *_Helper definitions to SIInstrFormat.td

2013-02-14 Thread Christian König
From: Christian König Signed-off-by: Christian König --- lib/Target/R600/SIInstrFormats.td | 66 + lib/Target/R600/SIInstrInfo.td| 66 - 2 files changed, 66 insertions(+), 66 deletions(-) diff --git a/lib/Target/R6

[Mesa-dev] [PATCH 06/12] R600/SI: remove some more unused code

2013-02-14 Thread Christian König
From: Christian König Signed-off-by: Christian König --- lib/Target/R600/AMDGPUCodeEmitter.h| 45 lib/Target/R600/MCTargetDesc/AMDGPUMCCodeEmitter.h |7 --- 2 files changed, 52 deletions(-) delete mode 100644 lib/Target/R600/AMDGPUCodeEmitter.h diff

[Mesa-dev] [PATCH 05/12] R600/structurizer: improve inverting conditions

2013-02-14 Thread Christian König
From: Christian König Stop adding more instructions than necessary. Signed-off-by: Christian König --- lib/Target/R600/AMDGPUStructurizeCFG.cpp | 40 +- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/lib/Target/R600/AMDGPUStructurizeCFG.cpp b/lib/T

[Mesa-dev] [PATCH 04/12] R600/structurizer: improve loop handling

2013-02-14 Thread Christian König
From: Christian König Generate more than one loop if it seems to make sense. Signed-off-by: Christian König --- lib/Target/R600/AMDGPUStructurizeCFG.cpp | 344 +- 1 file changed, 148 insertions(+), 196 deletions(-) diff --git a/lib/Target/R600/AMDGPUStructurizeCFG

[Mesa-dev] [PATCH 03/12] R600/structurizer: improve finding condition values

2013-02-14 Thread Christian König
From: Christian König Using the new NearestCommonDominator class. Signed-off-by: Christian König --- lib/Target/R600/AMDGPUStructurizeCFG.cpp | 31 +- 1 file changed, 22 insertions(+), 9 deletions(-) diff --git a/lib/Target/R600/AMDGPUStructurizeCFG.cpp b/lib/Ta

[Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-14 Thread Christian König
From: Christian König Signed-off-by: Christian König --- lib/Target/R600/AMDGPUStructurizeCFG.cpp | 66 ++ 1 file changed, 66 insertions(+) diff --git a/lib/Target/R600/AMDGPUStructurizeCFG.cpp b/lib/Target/R600/AMDGPUStructurizeCFG.cpp index c4c9762..86cb04a 100

[Mesa-dev] [PATCH 02/12] R600/structurizer: improve PHI value finding

2013-02-14 Thread Christian König
From: Christian König Using the new NearestCommonDominator class. Signed-off-by: Christian König --- lib/Target/R600/AMDGPUStructurizeCFG.cpp |6 ++ 1 file changed, 6 insertions(+) diff --git a/lib/Target/R600/AMDGPUStructurizeCFG.cpp b/lib/Target/R600/AMDGPUStructurizeCFG.cpp index

Re: [Mesa-dev] r600g: status of my work on the shader optimization

2013-02-14 Thread Christian König
Hi Vadim, nice work, I think you've made quite a progress here, but on the other hand it should be clear that the LLVM backend is the future and we should concentrate on that. To sum it up I'm not sure what we should do with this branch :) As Dragomir already wrote even if the code won't be

Re: [Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-14 Thread Michel Dänzer
On Don, 2013-02-14 at 11:32 +0100, Christian König wrote: > Am 13.02.2013 18:22, schrieb Michel Dänzer: > > On Mit, 2013-02-13 at 18:17 +0100, Christian König wrote: > >> Am 13.02.2013 18:11, schrieb Michel Dänzer: > >>> On Mit, 2013-02-13 at 11:34 -0500, Tom Stellard wrote: > There's just th

Re: [Mesa-dev] [PATCH 01/12] R600/structurizer: add class to find the Nearest Common Dominator

2013-02-14 Thread Christian König
Am 13.02.2013 18:22, schrieb Michel Dänzer: On Mit, 2013-02-13 at 18:17 +0100, Christian König wrote: Am 13.02.2013 18:11, schrieb Michel Dänzer: On Mit, 2013-02-13 at 11:34 -0500, Tom Stellard wrote: There's just the one cleanup on patch 10 that you mentioned, but otherwise the series looks g

Re: [Mesa-dev] r600g: status of my work on the shader optimization

2013-02-14 Thread Dragomir Ivanov
Greetings, I hope that, even if you work will be short-lived, e.g. until LLVM bytecode compiler takes off, the know-how is still very useful. On Thu, Feb 14, 2013 at 4:04 AM, Vadim Girlin wrote: > Hi, > > Last month I finally found the time to work on the rewrite of my previous > shader optimiz

Re: [Mesa-dev] [PATCH] R600: Add lit tests for texture sampling instruction selection.

2013-02-14 Thread Christian König
Am 14.02.2013 09:20, schrieb Michel Dänzer: On Die, 2013-02-12 at 15:22 +0100, Tom Stellard wrote: Reviewed-by: Tom Stellard Thanks, committed as revision 175138. Unfortunately, I only noticed afterwards that the new SI test failed an assertion on trunk, see below. I committed revision 175139

Re: [Mesa-dev] [PATCH] R600: Add lit tests for texture sampling instruction selection.

2013-02-14 Thread Michel Dänzer
On Die, 2013-02-12 at 15:22 +0100, Tom Stellard wrote: > > Reviewed-by: Tom Stellard Thanks, committed as revision 175138. Unfortunately, I only noticed afterwards that the new SI test failed an assertion on trunk, see below. I committed revision 175139 to fix that, but it might just be a banda