[Mesa-dev] [PATCH] mesa: Support EXT_framebuffer_blit targets in ES 3.0 as well.

2012-11-17 Thread Kenneth Graunke
GL_READ_FRAMEBUFFER and GL_DRAW_FRAMEBUFFER are valid targets in ES 3. Fixes 23 es3conform framebuffer_blit tests. Two more go from fail to crash, but that appears to be because they actually run now. --- src/mesa/main/fbobject.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) di

[Mesa-dev] [PATCH] mesa: Use GL_RED for DEPTH_TEXTURE_MODE for everything but legacy GL.

2012-11-17 Thread Kenneth Graunke
According to page 163 of the ES 3.0 spec: "Texture lookups involving textures with depth component data generate a texture base color C_b either using depth data directly or by performing a comparison with the D_ref value used to perform the lookup, as described in section 3.8.15. The resultin

Re: [Mesa-dev] [PATCH] mesa: Fix default value of BUFFER_ACCESS_FLAGS.

2012-11-17 Thread Kenneth Graunke
On 11/17/2012 10:07 PM, Kenneth Graunke wrote: [snip] Fixes es3conform's copy_buffer_defaults test. ...and pixel_buffer_object_default_parameters. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/m

Re: [Mesa-dev] [PATCH] mesa: Mark GetBufferParameteri64v as implemented.

2012-11-17 Thread Kenneth Graunke
On 11/17/2012 09:13 PM, Matt Turner wrote: On Sat, Nov 17, 2012 at 8:55 PM, Kenneth Graunke wrote: Apparently this was accidentally marked as unimplemented, and thus not put in the dispatch table. Fixes es3conform's copy_buffer_parameters, copy_buffer_data, and copy_buffer_usage tests. Cc: Pa

[Mesa-dev] [PATCH] mesa: Fix default value of BUFFER_ACCESS_FLAGS.

2012-11-17 Thread Kenneth Graunke
According to both the GL 3.0 and ES 3.0 specifications (table 2.7 for GL and table 2.8 for ES), the default value of BUFFER_ACCESS_FLAGS is supposed to be zero. Note that there are two related quantities: the obsolete BUFFER_ACCESS enum and the new BUFFER_ACCESS_FLAGS bitfield. BUFFER_ACCESS can

Re: [Mesa-dev] [PATCH] mesa: Mark GetBufferParameteri64v as implemented.

2012-11-17 Thread Matt Turner
On Sat, Nov 17, 2012 at 8:55 PM, Kenneth Graunke wrote: > Apparently this was accidentally marked as unimplemented, and thus not > put in the dispatch table. > > Fixes es3conform's copy_buffer_parameters, copy_buffer_data, > and copy_buffer_usage tests. > > Cc: Paul Berry > --- The reason it was

[Mesa-dev] [PATCH] mesa: Require gen'd names in glBeginQuery on ES 3.0.

2012-11-17 Thread Kenneth Graunke
Only legacy OpenGL allows the use of non-gen'd names. Core profiles and ES 3 both require the use of glGenQueries(). Note that BeginQuery doesn't exist in ES 1 or ES 2. Fixes es3conform's occlusion_query_invalid_beginquery test. --- src/mesa/main/queryobj.c | 2 +- 1 file changed, 1 insertion(+

[Mesa-dev] [PATCH] mesa: Mark GetBufferParameteri64v as implemented.

2012-11-17 Thread Kenneth Graunke
Apparently this was accidentally marked as unimplemented, and thus not put in the dispatch table. Fixes es3conform's copy_buffer_parameters, copy_buffer_data, and copy_buffer_usage tests. Cc: Paul Berry --- src/mapi/glapi/gen/GL3x.xml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) dif

Re: [Mesa-dev] [PATCH 2/2] intel: Choose MESA_FORMAT_SIGNED_{R16, GR1616} for ETC2 signed-{r11, rg11} formats

2012-11-17 Thread Kenneth Graunke
On 11/15/2012 12:17 PM, Anuj Phogat wrote: This fix makes both signed format tests in gles3 conformance pass. Signed-off-by: Anuj Phogat --- src/mesa/drivers/dri/intel/intel_mipmap_tree.c |8 ++-- 1 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/int

Re: [Mesa-dev] [PATCH 1/2] mesa: Fix a decoding bug in ETC2 signed-{r11, rg11} formats

2012-11-17 Thread Matt Turner
On Thu, Nov 15, 2012 at 12:17 PM, Anuj Phogat wrote: > This patch fixes two issues in decoding signed formats: > 1. Handle a corner case when base code word value is -128. As per > OpenGL ES 3.0 specification -128 is not an allowed value and should > be truncated to -127. > 2. Converting a decoded

Re: [Mesa-dev] GLES3 merges coming

2012-11-17 Thread Kenneth Graunke
On 11/16/2012 03:20 PM, Ian Romanick wrote: All, Starting next week I'm going to reorder, clean-up, and post patches from the gles3 branch to the list for review and merging to master. A lot of the work has been stable for some time, so I think it makes sense to start merging it. We're passing

Re: [Mesa-dev] [PATCH 7/9] i965/fs: Restrict optimization that would fail for gen7's SENDs from GRFs

2012-11-17 Thread Kenneth Graunke
On 11/12/2012 10:53 AM, Eric Anholt wrote: --- src/mesa/drivers/dri/i965/brw_fs.cpp | 28 src/mesa/drivers/dri/i965/brw_fs.h |3 +++ .../drivers/dri/i965/brw_fs_copy_propagation.cpp |5 ++-- 3 files changed, 28 insertions(+), 8 d

[Mesa-dev] [PATCH v2? 1-2/9] i965/fs: Add fs_reg::is_zero() and is_one(); use for opt_algebraic().

2012-11-17 Thread Kenneth Graunke
These helper macros save you from writing nasty expressions like: if ((inst->src[1].type == BRW_REGISTER_TYPE_F && inst->src[1].imm.f == 1.0) || ((inst->src[1].type == BRW_REGISTER_TYPE_D || inst->src[1].type == BRW_REGISTER_TYPE_UD) && inst->src[1].imm.u ==

Re: [Mesa-dev] [PATCH 1/2] i965: Validate requested GLES context version in brwCreateContext

2012-11-17 Thread Kenneth Graunke
On 11/09/2012 02:06 PM, Chad Versace wrote: For GLES1 and GLES2, brwCreateContext neglected to validate the requested context version received from the DRI layer. If DRI requested an OpenGL ES2 context with version 3.9, we provided it one. Before this fix, the switch statement that validated the

Re: [Mesa-dev] [PATCH 2/2] i965/fs: Add helper functions for IF and CMP and use them.

2012-11-17 Thread Kenneth Graunke
On 11/09/2012 01:34 PM, Eric Anholt wrote: --- src/mesa/drivers/dri/i965/brw_fs.cpp | 62 -- src/mesa/drivers/dri/i965/brw_fs.h |3 +- src/mesa/drivers/dri/i965/brw_fs_fp.cpp | 23 +++ src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 87

Re: [Mesa-dev] [PATCH 2/2] meta: Remove redundant code in _mesa_meta_GenerateMipmap

2012-11-17 Thread Kenneth Graunke
On 11/02/2012 11:31 AM, Anuj Phogat wrote: Integer textures generate invalid operation in glGenerateMipmap. So, the code related to integer textures is now redundant. Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta.c | 65 ++- 1 files changed

Re: [Mesa-dev] [PATCH 0/2] First attempt at asynchronous SwapBuffers

2012-11-17 Thread Marek Olšák
On Sat, Nov 17, 2012 at 10:28 PM, Dave Airlie wrote: >> The thread offloading has been implemented in the radeon driver for >> more than a year. We just can't fully use it because of what I've >> written above. I'm not inventing anything here. >> >> I wasn't at XDC and I don't really know much abo

Re: [Mesa-dev] [PATCH 0/2] First attempt at asynchronous SwapBuffers

2012-11-17 Thread Dave Airlie
> The thread offloading has been implemented in the radeon driver for > more than a year. We just can't fully use it because of what I've > written above. I'm not inventing anything here. > > I wasn't at XDC and I don't really know much about the protocol and > why there are roundtrips. All I want

Re: [Mesa-dev] [PATCH 0/2] First attempt at asynchronous SwapBuffers

2012-11-17 Thread Marek Olšák
On Sat, Nov 17, 2012 at 5:25 PM, Mathias Fröhlich wrote: > > Hi, > > On Thursday, November 15, 2012 19:04:51 Marek Olšák wrote: >> Yes, that's what I am looking for, though I'd like to have a solution >> that works with current DRI2 as well. >> >> The triple flush is unrelated to DRI2, it's actual

Re: [Mesa-dev] [PATCH 0/2] First attempt at asynchronous SwapBuffers

2012-11-17 Thread Mathias Fröhlich
Hi, On Thursday, November 15, 2012 19:04:51 Marek Olšák wrote: > Yes, that's what I am looking for, though I'd like to have a solution > that works with current DRI2 as well. > > The triple flush is unrelated to DRI2, it's actually an internal issue > with libGL and can be fixed easily. So may b