Re: [Mesa-dev] [PATCH] radeon/llvm: support for f32, v2f32, v3f32 store/load

2012-11-11 Thread Matthew W.S. Bell
On Sun, 2012-11-11 at 22:22 +0100, Vincent Lejeune wrote: > --- > lib/Target/AMDGPU/AMDILDevice.cpp | 4 +- > lib/Target/AMDGPU/R600ISelLowering.cpp | 69 > -- > lib/Target/AMDGPU/R600Instructions.td | 4 +- > 3 files changed, 54 insertions(+), 23 deletions

Re: [Mesa-dev] [PATCH 1/6] mesa: add MaxNumLevels to gl_texture_image, remove MaxLog2

2012-11-11 Thread Marek Olšák
AFAIK, r600g has been immune to some of these bugs. You can set last_level to any large value and it will just work. Christoph B. told me he had had a problem with last_level being too large and I decided to review all the other related places in mesa/main and st/mesa and came up with this series j

Re: [Mesa-dev] [PATCH 1/6] mesa: add MaxNumLevels to gl_texture_image, remove MaxLog2

2012-11-11 Thread Dave Airlie
> MaxLog2 led to bugs, because it didn't work well with 1D and 3D textures. They all look good to me, but I suppose Brian might want to check them over, Any ideas for a piglit test to show any of this or is it mostly just internal bugs at the driver interfaces? Reviewed-by: Dave Airlie Dave. __

[Mesa-dev] [PATCH] radeon/llvm: support for f32, v2f32, v3f32 store/load

2012-11-11 Thread Vincent Lejeune
--- lib/Target/AMDGPU/AMDILDevice.cpp | 4 +- lib/Target/AMDGPU/R600ISelLowering.cpp | 69 -- lib/Target/AMDGPU/R600Instructions.td | 4 +- 3 files changed, 54 insertions(+), 23 deletions(-) diff --git a/lib/Target/AMDGPU/AMDILDevice.cpp b/lib/Target/AMDGP

[Mesa-dev] [PATCH 6/6] st/mesa: fix computation of last_level in GenerateMipmap

2012-11-11 Thread Marek Olšák
Array textures were broken. NOTE: This is a candidate for the stable branches. --- src/mesa/state_tracker/st_gen_mipmap.c | 28 +++- 1 file changed, 7 insertions(+), 21 deletions(-) diff --git a/src/mesa/state_tracker/st_gen_mipmap.c b/src/mesa/state_tracker/st_gen_mip

[Mesa-dev] [PATCH 5/6] st/mesa: fix computation of last_level during texture creation

2012-11-11 Thread Marek Olšák
Array textures were broken. NOTE: This is a candidate for the stable branches. --- src/mesa/state_tracker/st_cb_texture.c |6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_texture.c b/src/mesa/state_tracker/st_cb_texture.c index 9619dd2..f0

[Mesa-dev] [PATCH 4/6] st/mesa: fix guessing the base level size

2012-11-11 Thread Marek Olšák
It was pretty broken with array textures, where the array size (height or depth depending on the target) shouldn't be magnified. The guessing also doesn't fail for 1D and cube textures. (I guess the problem was only with non-square or non-cube textures, right?) NOTE: This is a candidate for the s

[Mesa-dev] [PATCH 3/6] mesa: fix error checking of TexStorage(levels) for array and rect textures

2012-11-11 Thread Marek Olšák
NOTE: This is a candidate for the stable branches. --- src/mesa/main/texstorage.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c index 9e0b543..00f19ba 100644 --- a/src/mesa/main/texstorage.c +++ b/src/mesa/main/tex

[Mesa-dev] [PATCH 2/6] mesa: use MaxNumlevels in _mesa_test_texobj_completeness

2012-11-11 Thread Marek Olšák
--- src/mesa/main/texobj.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index c083c72..d650c75 100644 --- a/src/mesa/main/texobj.c +++ b/src/mesa/main/texobj.c @@ -445,7 +445,7 @@ _mesa_test_texobj_completenes

[Mesa-dev] [PATCH 1/6] mesa: add MaxNumLevels to gl_texture_image, remove MaxLog2

2012-11-11 Thread Marek Olšák
MaxLog2 led to bugs, because it didn't work well with 1D and 3D textures. NOTE: This is a candidate for the stable branches. --- src/mesa/drivers/dri/nouveau/nouveau_texture.c |2 +- src/mesa/drivers/dri/radeon/radeon_mipmap_tree.c |6 ++-- src/mesa/main/mtypes.h

Re: [Mesa-dev] how to run gallium/tests/trivial/compute.c on r600

2012-11-11 Thread Liu Xin
Hi, Tom, now i want to try out the new features of gallium/clover. I notice you have updated your wiki page for installation. with your new instruction, i can not build clang any more :( xliu@xliu-desktop:~/Development/llvm-tstellar/tools/clang$ make make[1]: Entering directory `/home/xliu/Devel

Re: [Mesa-dev] [PATCH] st/mesa: fix computation of last_level for array textures

2012-11-11 Thread Marek Olšák
Please ignore this patch, I'll send a new one. Marek On Sun, Nov 11, 2012 at 2:01 PM, Marek Olšák wrote: > NOTE: This is a candidate for the stable branches. > --- > src/mesa/state_tracker/st_gen_mipmap.c | 20 ++-- > 1 file changed, 18 insertions(+), 2 deletions(-) > > diff -

[Mesa-dev] [PATCH] st/mesa: fix computation of last_level for array textures

2012-11-11 Thread Marek Olšák
NOTE: This is a candidate for the stable branches. --- src/mesa/state_tracker/st_gen_mipmap.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/src/mesa/state_tracker/st_gen_mipmap.c b/src/mesa/state_tracker/st_gen_mipmap.c index 8892006..7e97edd 100644 -