[Mesa-dev] [PATCH 18/18] mesa: assert that key->fragprog_inputs_read value isn't too large

2012-11-04 Thread Brian Paul
fragprog_inputs_read is a 12-bit bitfield so check the assigned value. MSVC warns on the assignment. Not easy to fix but let's do a sanity check. --- src/mesa/main/ffvertex_prog.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/ffvertex_prog.c b/src/mesa/ma

[Mesa-dev] [PATCH 17/18] mesa: fix MSVC signed/unsigned warnings in context.c

2012-11-04 Thread Brian Paul
--- src/mesa/main/context.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index a4dedee..0508378 100644 --- a/src/mesa/main/context.c +++ b/src/mesa/main/context.c @@ -706,9 +706,9 @@ check_context_limits(struct gl_con

[Mesa-dev] [PATCH 16/18] mesa: fix MSVC signed/unsigned warnings in transformfeedback.c

2012-11-04 Thread Brian Paul
--- src/mesa/main/transformfeedback.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/transformfeedback.c b/src/mesa/main/transformfeedback.c index 1afc0dc..1e3a7ea 100644 --- a/src/mesa/main/transformfeedback.c +++ b/src/mesa/main/transformfeedback.c @@

[Mesa-dev] [PATCH 15/18] swrast: fix MSVC signed/unsigned warnings

2012-11-04 Thread Brian Paul
--- src/mesa/swrast/s_zoom.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/swrast/s_zoom.c b/src/mesa/swrast/s_zoom.c index 24bfa22..828374f 100644 --- a/src/mesa/swrast/s_zoom.c +++ b/src/mesa/swrast/s_zoom.c @@ -234,7 +234,7 @@ zoom_span( struct gl_context

[Mesa-dev] [PATCH 14/18] tnl: fix MSVC signed/unsigned warnings

2012-11-04 Thread Brian Paul
--- src/mesa/tnl/t_draw.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/src/mesa/tnl/t_draw.c b/src/mesa/tnl/t_draw.c index 6a3c966..0631eb1 100644 --- a/src/mesa/tnl/t_draw.c +++ b/src/mesa/tnl/t_draw.c @@ -141,7 +141,8 @@ convert_fixed_to_float(const struct gl_client

[Mesa-dev] [PATCH 13/18] mesa: silence MSVC signed/unsigned warning in texgetmage.c

2012-11-04 Thread Brian Paul
--- src/mesa/main/texgetimage.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/texgetimage.c b/src/mesa/main/texgetimage.c index a372069..554c68b 100644 --- a/src/mesa/main/texgetimage.c +++ b/src/mesa/main/texgetimage.c @@ -892,7 +892,7 @@ getcompressedtex

[Mesa-dev] [PATCH 12/18] mesa: silence MSVC signed/unsigned warning in texstorage.c

2012-11-04 Thread Brian Paul
--- src/mesa/main/texstorage.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/texstorage.c b/src/mesa/main/texstorage.c index 283aefa..968f6f9 100644 --- a/src/mesa/main/texstorage.c +++ b/src/mesa/main/texstorage.c @@ -292,7 +292,7 @@ tex_storage_error_che

[Mesa-dev] [PATCH 10/18] mesa: fix signed/unsigned MSVC warnings in fbobject.c

2012-11-04 Thread Brian Paul
--- src/mesa/main/fbobject.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index fc5681c..d54f6a9 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -2059,7 +2059,8 @@ framebuffer_texture(struct

[Mesa-dev] [PATCH 11/18] vbo: use GLuint for numInstances to silence MSVC warnings

2012-11-04 Thread Brian Paul
--- src/mesa/vbo/vbo.h|2 +- src/mesa/vbo/vbo_exec_array.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/vbo/vbo.h b/src/mesa/vbo/vbo.h index e058497..04930b9 100644 --- a/src/mesa/vbo/vbo.h +++ b/src/mesa/vbo/vbo.h @@ -50,7 +50,7 @@ struct _mes

[Mesa-dev] [PATCH 09/18] mesa: s/GLint/GLuint/ in matrix.c to silence MSVC warnings

2012-11-04 Thread Brian Paul
--- src/mesa/main/matrix.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/matrix.c b/src/mesa/main/matrix.c index 28c4e2b..3c5968c 100644 --- a/src/mesa/main/matrix.c +++ b/src/mesa/main/matrix.c @@ -746,7 +746,7 @@ void _mesa_free_matrix_data( struct gl_co

[Mesa-dev] [PATCH 08/18] mesa: s/int/GLuint/ in get.c to silence MSVC warnings

2012-11-04 Thread Brian Paul
--- src/mesa/main/get.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index c34d873..fccad67 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -1480,7 +1480,7 @@ _mesa_GetDoublev(GLenum pname, GLdouble *params) }

[Mesa-dev] [PATCH 07/18] mesa: fix assorted MSVC conversion warnings in format_pack.c

2012-11-04 Thread Brian Paul
--- src/mesa/main/format_pack.c | 20 ++-- 1 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/mesa/main/format_pack.c b/src/mesa/main/format_pack.c index be6c026..051fb40 100644 --- a/src/mesa/main/format_pack.c +++ b/src/mesa/main/format_pack.c @@ -2248,7 +2248

[Mesa-dev] [PATCH 06/18] st/mesa: change glsl_to_tgsi_visitor from class to struct

2012-11-04 Thread Brian Paul
To match the declaration in the .h file and silence an MSVC warning. --- src/mesa/state_tracker/st_glsl_to_tgsi.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/state_tracker/st_glsl_to_tgsi.cpp b/src/mesa/state_tracker/st_glsl_to_tgsi.cpp index 14b72dc..a70a

[Mesa-dev] [PATCH 05/18] st/mesa: add int cast to silence warning

2012-11-04 Thread Brian Paul
MSVC warns that negating an unsigned value yields an unsigned value. --- src/mesa/state_tracker/st_cb_fbo.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/state_tracker/st_cb_fbo.c b/src/mesa/state_tracker/st_cb_fbo.c index 882fb37..adee00b 100644 --- a/src/mes

[Mesa-dev] [PATCH 04/18] glsl: fix signed/unsigned comparision warnings on MSVC

2012-11-04 Thread Brian Paul
--- src/glsl/lower_mat_op_to_vec.cpp|8 src/glsl/lower_vec_index_to_cond_assign.cpp |4 ++-- src/glsl/lower_vec_index_to_swizzle.cpp |2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/glsl/lower_mat_op_to_vec.cpp b/src/glsl/lower_mat_op_t

[Mesa-dev] [PATCH 03/18] glsl: remove incorrect 'struct' keyword

2012-11-04 Thread Brian Paul
ir_variable is a class, not a struct. Fixes an MSVC warning. --- src/glsl/ast_to_hir.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp index 5157661..d450aa1 100644 --- a/src/glsl/ast_to_hir.cpp +++ b/src/glsl/ast_to_hi

[Mesa-dev] [PATCH 02/18] glsl: add 'f' suffix to floats to silence MSVC warnings

2012-11-04 Thread Brian Paul
--- src/glsl/ir.cpp |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/glsl/ir.cpp b/src/glsl/ir.cpp index 1c7aada..7b0a487 100644 --- a/src/glsl/ir.cpp +++ b/src/glsl/ir.cpp @@ -780,7 +780,7 @@ ir_constant::get_float_component(unsigned i) const case GLSL_TYPE_UINT:

[Mesa-dev] [PATCH 01/18] glsl: change int->unsigned to silence MSVC warnings

2012-11-04 Thread Brian Paul
--- src/glsl/ir_builder.cpp |2 +- src/glsl/ir_builder.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/ir_builder.cpp b/src/glsl/ir_builder.cpp index d96e25c..c62f0b1 100644 --- a/src/glsl/ir_builder.cpp +++ b/src/glsl/ir_builder.cpp @@ -77,7 +77,7 @@ swi

Re: [Mesa-dev] to _ARB or not to _ARB

2012-11-04 Thread Brian Paul
On 11/04/2012 11:25 AM, Kenneth Graunke wrote: On 11/03/2012 11:59 PM, Dave Airlie wrote: So in my slow but steady pursuit of ARB_texture_cube_map_array, I've been reviewing my patch queue and noticed I'm a bit inconsistent on using _ARB variants of the enums or not. So do we have a rule on thi

Re: [Mesa-dev] [PATCH 4/5] mesa: Convert the hash table for GL object ids to the open-addressing hash.

2012-11-04 Thread Brian Paul
On 10/25/2012 10:13 AM, Eric Anholt wrote: The previous 1023-entry chaining hash table never resized, so it was very inefficient when there were many objects live. While one could have an even more efficient implementation than this (keep an array for genned names with packed IDs, or take advant

Re: [Mesa-dev] [PATCH 3/5] mesa: Import a copy of the open-addressing hash table code I wrote.

2012-11-04 Thread Brian Paul
On 10/25/2012 10:13 AM, Eric Anholt wrote: Mesa's chaining hash table for object names is slow, and this should be much faster. I namespaced the functions under _mesa_*, to avoid visibility troubles that we may have had before with hash_table_* functions. The hash_table.c file unfortunately liv

Re: [Mesa-dev] [PATCH] i965/fs: Eliminate pointless self-moves.

2012-11-04 Thread Eric Anholt
Matt Turner writes: > On Sat, Nov 3, 2012 at 8:44 PM, Kenneth Graunke wrote: >> We sometimes generate these, and they're so easy to remove... >> >> shader-db results: >> total instructions in shared programs: 1394522 -> 1394500 (-0.00%) >> instructions in affected programs: 6533 -> 6511 (-0.

Re: [Mesa-dev] to _ARB or not to _ARB

2012-11-04 Thread Kenneth Graunke
On 11/03/2012 11:59 PM, Dave Airlie wrote: So in my slow but steady pursuit of ARB_texture_cube_map_array, I've been reviewing my patch queue and noticed I'm a bit inconsistent on using _ARB variants of the enums or not. So do we have a rule on this? and also what should in the ARB_texture_cube_

Re: [Mesa-dev] [PATCH 10/17] glapi: Annotate XML with function name suffix anomalies.

2012-11-04 Thread Eric Anholt
Kenneth Graunke writes: > On 11/02/2012 05:13 PM, Ian Romanick wrote: >> On 11/02/2012 03:01 PM, Paul Berry wrote: >>> On 2 November 2012 14:11, Ian Romanick >> Oh yuck! Why not just fix the names of the Mesa functions? That >>> seems much better than carrying the work-around in the cod

[Mesa-dev] [Bug 56741] New: Software rendering and Wayland clients no longer work

2012-11-04 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56741 Priority: medium Bug ID: 56741 Assignee: mesa-dev@lists.freedesktop.org Summary: Software rendering and Wayland clients no longer work Severity: normal Classification: Unclassified

[Mesa-dev] to _ARB or not to _ARB

2012-11-04 Thread Dave Airlie
So in my slow but steady pursuit of ARB_texture_cube_map_array, I've been reviewing my patch queue and noticed I'm a bit inconsistent on using _ARB variants of the enums or not. So do we have a rule on this? and also what should in the ARB_texture_cube_map_array.xml file? if the non-ARB ones don't