Re: [Mesa-dev] [PATCH 2/2] mesa: use the EXT_texture_compression_s3tc enable flag for all S3TC extensions

2012-11-02 Thread Henri Verbeet
On 2 November 2012 22:22, Marek Olšák wrote: > Yeah. However as far as I know, the desktop GL doesn't have a (good) > S3TC extension which doesn't require on-line compression. With what > you say, it looks like such an extension would be useful for us. Don't > you think it would be nice if the Ope

Re: [Mesa-dev] [PATCH 10/17] glapi: Annotate XML with function name suffix anomalies.

2012-11-02 Thread Kenneth Graunke
On 11/02/2012 05:13 PM, Ian Romanick wrote: On 11/02/2012 03:01 PM, Paul Berry wrote: On 2 November 2012 14:11, Ian Romanick mailto:i...@freedesktop.org>> wrote: On 11/01/2012 03:19 PM, Paul Berry wrote: When the XML lists one or more GL api functions as aliases for another

Re: [Mesa-dev] [PATCH] mesa api_exec: disable StencilFuncSeparateATI for API_OPENGL_CORE

2012-11-02 Thread Paul Berry
On 2 November 2012 16:18, Jordan Justen wrote: > This was mistakenly enabled in a21116f. > > Signed-off-by: Jordan Justen > Cc: Paul Berry > --- > src/mesa/main/api_exec.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/mesa/main/api_exec.c b/src/mesa/main/api_e

Re: [Mesa-dev] [PATCH 10/17] glapi: Annotate XML with function name suffix anomalies.

2012-11-02 Thread Ian Romanick
On 11/02/2012 03:01 PM, Paul Berry wrote: On 2 November 2012 14:11, Ian Romanick mailto:i...@freedesktop.org>> wrote: On 11/01/2012 03:19 PM, Paul Berry wrote: When the XML lists one or more GL api functions as aliases for another GL function, the mesa function that

Re: [Mesa-dev] [PATCH 08/17] glapi: Annotate XML with exec="{es, check}" for special GLES1 functions.

2012-11-02 Thread Ian Romanick
On 11/02/2012 02:58 PM, Paul Berry wrote: On 2 November 2012 14:09, Ian Romanick mailto:i...@freedesktop.org>> wrote: On 11/01/2012 03:19 PM, Paul Berry wrote: Future patches will use this annotation when code generating _mesa_create_exec_table(), to determine which function

[Mesa-dev] [PATCH] mesa api_exec: disable StencilFuncSeparateATI for API_OPENGL_CORE

2012-11-02 Thread Jordan Justen
This was mistakenly enabled in a21116f. Signed-off-by: Jordan Justen Cc: Paul Berry --- src/mesa/main/api_exec.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/main/api_exec.c b/src/mesa/main/api_exec.c index 2df70a1..e92eb0e 100644 --- a/src/mesa/main/api_exec.

Re: [Mesa-dev] [PATCH 10/17] glapi: Annotate XML with function name suffix anomalies.

2012-11-02 Thread Paul Berry
On 2 November 2012 14:11, Ian Romanick wrote: > On 11/01/2012 03:19 PM, Paul Berry wrote: > >> When the XML lists one or more GL api functions as aliases for another >> GL function, the mesa function that implements the functionality is >> usually named after the canonical version of the function

Re: [Mesa-dev] [PATCH 08/17] glapi: Annotate XML with exec="{es, check}" for special GLES1 functions.

2012-11-02 Thread Paul Berry
On 2 November 2012 14:09, Ian Romanick wrote: > On 11/01/2012 03:19 PM, Paul Berry wrote: > >> Future patches will use this annotation when code generating >> _mesa_create_exec_table(), to determine which functions should be >> dispatched to ES-specific implementations. exec="es" indicates that

Re: [Mesa-dev] [PATCH 2/2] mesa: use the EXT_texture_compression_s3tc enable flag for all S3TC extensions

2012-11-02 Thread Marek Olšák
On Mon, Oct 29, 2012 at 7:36 PM, Ian Romanick wrote: > On 10/29/2012 02:47 AM, Philipp Klaus Krause wrote: >> >> Am 28.10.2012 20:51, schrieb Kenneth Graunke: >> >>> This makes sense to me. The original reason for splitting out the ANGLE >>> vs. EXT bits was that the ANGLE extension only requires

Re: [Mesa-dev] [PATCH] i965/fs: Compact the virtual GRF arrays.

2012-11-02 Thread Eric Anholt
Kenneth Graunke writes: > During code generation, we create tons of temporary variables, many of > which get immediately killed and are never used. Later optimization and > analysis passes, such as compute_live_intervals, loop over all the > virtual GRFs. By compacting them, we can save a lot o

Re: [Mesa-dev] [PATCH 3/6] i965: Generalize GL_FIXED VS w/a support

2012-11-02 Thread Eric Anholt
Kenneth Graunke writes: > On 10/22/2012 10:21 AM, Eric Anholt wrote: >> Chris Forbes writes: >> >>> Next few patches build on this to add other workarounds >>> for packed formats. >> >>> diff --git a/src/mesa/drivers/dri/i965/brw_vs.h >>> b/src/mesa/drivers/dri/i965/brw_vs.h >>> index adeff7f..

Re: [Mesa-dev] [PATCH 10/17] glapi: Annotate XML with function name suffix anomalies.

2012-11-02 Thread Ian Romanick
On 11/01/2012 03:19 PM, Paul Berry wrote: When the XML lists one or more GL api functions as aliases for another GL function, the mesa function that implements the functionality is usually named after the canonical version of the function (the one that is the target of the aliases). For example,

Re: [Mesa-dev] [PATCH 08/17] glapi: Annotate XML with exec="{es, check}" for special GLES1 functions.

2012-11-02 Thread Ian Romanick
On 11/01/2012 03:19 PM, Paul Berry wrote: Future patches will use this annotation when code generating _mesa_create_exec_table(), to determine which functions should be dispatched to ES-specific implementations. exec="es" indicates that the ES-specific implementation has a name beginning with "_

Re: [Mesa-dev] [PATCH] mesa: add bounds checking for uniform array access

2012-11-02 Thread Ian Romanick
On 11/02/2012 01:12 PM, Frank Henigman wrote: validate_uniform_parameters now checks that the array index is valid. This means if an index is out of bounds, glGetUniform* now fails with GL_INVALID_OPERATION, as it should. _mesa_uniform and _mesa_uniform_matrix also call validate_uniform_paramete

[Mesa-dev] [PATCH] mesa: add bounds checking for uniform array access

2012-11-02 Thread Frank Henigman
validate_uniform_parameters now checks that the array index is valid. This means if an index is out of bounds, glGetUniform* now fails with GL_INVALID_OPERATION, as it should. _mesa_uniform and _mesa_uniform_matrix also call validate_uniform_parameters so the bounds checks there became redundant a

Re: [Mesa-dev] [PATCH v2 00/13] GL 3.1 CORE dispatch_sanity test

2012-11-02 Thread Paul Berry
On 30 October 2012 11:25, Jordan Justen wrote: > v2: > * Keep functions for various extensions still enabled in GL CORE >profiles, and add the extension functions to >dispatch_sanity.cpp:gl_core_functions_possible. > * Cleanup glapi for ARB_geometry_shader4.xml > * Disable unneeded ARB

Re: [Mesa-dev] [PATCH v2 10/13] dispatch_sanity test: pass ctx to validate_functions/nops

2012-11-02 Thread Paul Berry
On 30 October 2012 11:25, Jordan Justen wrote: > This will allow validate_functions to access ctx->Version. > > Signed-off-by: Jordan Justen > --- > src/mesa/main/tests/dispatch_sanity.cpp | 32 > +-- > 1 file changed, 22 insertions(+), 10 deletions(-) > > diff --g

Re: [Mesa-dev] [PATCH v2 06/13] mesa: disable ProgramParameteri until ARB_geometry_shader4 is supported

2012-11-02 Thread Paul Berry
On 30 October 2012 11:25, Jordan Justen wrote: > Signed-off-by: Jordan Justen > --- > src/mesa/main/shaderapi.c |4 > 1 file changed, 4 deletions(-) > > diff --git a/src/mesa/main/shaderapi.c b/src/mesa/main/shaderapi.c > index 04cdfba..a8be5c5 100644 > --- a/src/mesa/main/shaderapi.c

[Mesa-dev] [PATCH] glsl/builtin_compiler/Makefile.am: Make sure GLSL_SRCDIR is defined before AM_CFLAGS.

2012-11-02 Thread Johannes Obermayr
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=56685 --- src/glsl/builtin_compiler/Makefile.am |4 ++-- 1 Datei geändert, 2 Zeilen hinzugefügt(+), 2 Zeilen entfernt(-) diff --git a/src/glsl/builtin_compiler/Makefile.am b/src/glsl/builtin_compiler/Makefile.am index 72032b5..22ccf60 10

Re: [Mesa-dev] [PATCH 00/17] dispatch: code generate _mesa_create_exec_table.

2012-11-02 Thread Jordan Justen
On Fri, Nov 2, 2012 at 12:19 PM, Paul Berry wrote: > On 2 November 2012 12:16, Paul Berry wrote: >> >> On 2 November 2012 09:24, Paul Berry wrote: >>> >>> On 1 November 2012 21:55, Jordan Justen wrote: Excellent Paul! I didn't realize you were so close to having this ready. It ma

Re: [Mesa-dev] [PATCH 00/17] dispatch: code generate _mesa_create_exec_table.

2012-11-02 Thread Paul Berry
On 2 November 2012 12:16, Paul Berry wrote: > On 2 November 2012 09:24, Paul Berry wrote: > >> On 1 November 2012 21:55, Jordan Justen wrote: >> >>> Excellent Paul! I didn't realize you were so close to having this >>> ready. It makes a good portion of my GL Core dispatch sanity v2 series >>> u

Re: [Mesa-dev] [PATCH 00/17] dispatch: code generate _mesa_create_exec_table.

2012-11-02 Thread Paul Berry
On 2 November 2012 09:24, Paul Berry wrote: > On 1 November 2012 21:55, Jordan Justen wrote: > >> Excellent Paul! I didn't realize you were so close to having this >> ready. It makes a good portion of my GL Core dispatch sanity v2 series >> unnecessary. >> > I don't think it makes your series un

Re: [Mesa-dev] Mesa-9.0: generate_builtins.py hangs and uses 100% CPU when generating from *.glsl files

2012-11-02 Thread Kenneth Graunke
On 10/21/2012 07:50 PM, Stephan Raue wrote: Hi, i try to (cross)compile Mesa-9.0. builtin_compiler is compiled for host with a second hostbuild before i build Mesa for target. if i build Mesa for target the buildprocess hangs at: python2 ./builtins/tools/generate_builtins.py /home/stephan/proj

Re: [Mesa-dev] [PATCH 1/2] mesa: Generate invalid operation in glGenerateMipMap for integer textures

2012-11-02 Thread Brian Paul
On 11/02/2012 12:29 PM, Anuj Phogat wrote: Khronos has reached a conclusion and disallowed following texture formats in glGenerateMipMap(): (a) ASTC textures (b) integer internal formats (e.g., RGBA8UI, RG16I) (c) textures with stencil formats (e.g., STENCIL_INDEX8) (d) textures with pack

[Mesa-dev] [PATCH 2/2] meta: Remove redundant code in _mesa_meta_GenerateMipmap

2012-11-02 Thread Anuj Phogat
Integer textures generate invalid operation in glGenerateMipmap. So, the code related to integer textures is now redundant. Signed-off-by: Anuj Phogat --- src/mesa/drivers/common/meta.c | 65 ++- 1 files changed, 4 insertions(+), 61 deletions(-) diff --git

[Mesa-dev] [PATCH 1/2] mesa: Generate invalid operation in glGenerateMipMap for integer textures

2012-11-02 Thread Anuj Phogat
Khronos has reached a conclusion and disallowed following texture formats in glGenerateMipMap(): (a) ASTC textures (b) integer internal formats (e.g., RGBA8UI, RG16I) (c) textures with stencil formats (e.g., STENCIL_INDEX8) (d) textures with packed depth/stencil formats (e.g, DEPTH24_STENCIL8)

[Mesa-dev] [Bug 56653] Source `src/glsl/builtin_stubs.cpp' not found, needed by target `build/linux-x86_64-debug/glsl/builtin_stubs.o'.

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56653 Kenneth Graunke changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [PATCH] build: Drop BUILTIN_COMPILER_* variables

2012-11-02 Thread Kenneth Graunke
From: Thierry Reding The BUILTIN_COMPILER_CXX_FILES variable is unused and can be dropped. Files listed in BUILTIN_COMPILER_GENERATED_CXX_FILES are no longer generated for the builtin compiler but for the GLSL compiler. The variable is renamed to GLSL_COMPILER_GENERATED_CXX_FILES for consistency.

[Mesa-dev] [Bug 29513] Kwin crash when i change the decoration.

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29513 almos changed: What|Removed |Added Status|NEEDINFO|RESOLVED Resolution|---

[Mesa-dev] [Bug 56653] Source `src/glsl/builtin_stubs.cpp' not found, needed by target `build/linux-x86_64-debug/glsl/builtin_stubs.o'.

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56653 --- Comment #8 from Tapani Pälli --- yep, build on android broke the same way as scons but gets fixed with Thierry's patch in comment #4 --- 8< --- i686-linux-g++: error: external/mesa/src/glsl/./builtin_stubs.cpp: No such file or directory --

[Mesa-dev] [Bug 56653] Source `src/glsl/builtin_stubs.cpp' not found, needed by target `build/linux-x86_64-debug/glsl/builtin_stubs.o'.

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56653 --- Comment #7 from Tapani Pälli --- (In reply to comment #6) > Tapani, could you take a look at the Android build? (Or ask someone else > to?) Thanks! (and sorry for the trouble...) Sure, no problem -- You are receiving this mail because: Y

Re: [Mesa-dev] [PATCH 00/17] dispatch: code generate _mesa_create_exec_table.

2012-11-02 Thread Paul Berry
On 1 November 2012 21:55, Jordan Justen wrote: > Excellent Paul! I didn't realize you were so close to having this > ready. It makes a good portion of my GL Core dispatch sanity v2 series > unnecessary. > > Anyway, I rebased my 5 dispatch-sanity changes onto your branch, and > it reported that th

[Mesa-dev] [Bug 29513] Kwin crash when i change the decoration.

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=29513 Andreas Boll changed: What|Removed |Added Status|NEW |NEEDINFO --- Comment #4 from Andreas Boll

[Mesa-dev] [Bug 56685] New: [recent build error] glsl_parser.h: No such file or directory

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56685 Priority: medium Bug ID: 56685 Assignee: mesa-dev@lists.freedesktop.org Summary: [recent build error] glsl_parser.h: No such file or directory Severity: normal Classifica

[Mesa-dev] [Bug 56651] src/mapi/glapi/glapitable.h:771:35: error: unknown type name ‘GLfixed’

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56651 --- Comment #2 from Paul Berry --- Thanks for taking care of this, Brian. -- You are receiving this mail because: You are the assignee for the bug. ___ mesa-dev mailing list mesa-dev@lists.freedesktop

[Mesa-dev] [Bug 56664] [recent build error] fatal error: GL/gl.h: No such file or directory

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56664 Johannes Obermayr changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Mesa-dev] [PATCH] glsl/builtin_compiler: Fix build by -I $(top_srcdir)/include.

2012-11-02 Thread Kenneth Graunke
On 11/02/2012 04:30 AM, Johannes Obermayr wrote: BUG: 56664 --- src/glsl/builtin_compiler/Makefile.am |1 + 1 Datei geändert, 1 Zeile hinzugefügt(+) diff --git a/src/glsl/builtin_compiler/Makefile.am b/src/glsl/builtin_compiler/Makefile.am index eeac424..72032b5 100644 --- a/src/glsl/bui

[Mesa-dev] [Bug 56653] Source `src/glsl/builtin_stubs.cpp' not found, needed by target `build/linux-x86_64-debug/glsl/builtin_stubs.o'.

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56653 Kenneth Graunke changed: What|Removed |Added CC||lem...@gmail.com --- Comment #6 from K

Re: [Mesa-dev] [PATCH] configure.ac: Prevent build of radeon llvm backend with llvm < 3.2

2012-11-02 Thread Tom Stellard
On Fri, Nov 02, 2012 at 03:46:20PM +0100, Vincent Lejeune wrote: > --- Reviewed-by: Tom Stellard > configure.ac | 18 +- > 1 file changed, 13 insertions(+), 5 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 6b97a26..45d1510 100644 > --- a/configure.ac > +++ b/c

[Mesa-dev] [PATCH] configure.ac: Prevent build of radeon llvm backend with llvm < 3.2

2012-11-02 Thread Vincent Lejeune
--- configure.ac | 18 +- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 6b97a26..45d1510 100644 --- a/configure.ac +++ b/configure.ac @@ -1748,15 +1748,23 @@ gallium_require_drm_loader() { } radeon_llvm_check() { -LLVM_VERS

Re: [Mesa-dev] [PATCH] r300/compiler: Avoid generating MOV instructions for invalid IMM swizzles v2

2012-11-02 Thread son_of_the_osiris
If an instruction reads from a constant register that contains immediates using an invalid swizzle, we can avoid generating MOV instructions to fix up the swizzle by loading the immediates into a different constant register that can be read using a valid swizzle. This only affects r300 and r400 c

[Mesa-dev] [Bug 56552] src/gallium/auxiliary/draw/draw_vertex.h:130:draw_emit_vertex_attr: Assertion `n < 32' failed.

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56552 Andreas Boll changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

[Mesa-dev] [Bug 56653] Source `src/glsl/builtin_stubs.cpp' not found, needed by target `build/linux-x86_64-debug/glsl/builtin_stubs.o'.

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56653 --- Comment #5 from Thierry Reding --- Created attachment 69429 --> https://bugs.freedesktop.org/attachment.cgi?id=69429&action=edit build: Drop BUILTIN_COMPILER_* variables The BUILTIN_COMPILER_CXX_FILES variable is unused and can be dropped.

[Mesa-dev] [Bug 56653] Source `src/glsl/builtin_stubs.cpp' not found, needed by target `build/linux-x86_64-debug/glsl/builtin_stubs.o'.

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56653 --- Comment #4 from Thierry Reding --- Created attachment 69427 --> https://bugs.freedesktop.org/attachment.cgi?id=69427&action=edit android: Update for builtin_stubs.cpp move This is a similar fix to the one José posted for SCons. I haven't t

[Mesa-dev] [PATCH] glsl/builtin_compiler: Fix build by -I $(top_srcdir)/include.

2012-11-02 Thread Johannes Obermayr
BUG: 56664 --- src/glsl/builtin_compiler/Makefile.am |1 + 1 Datei geändert, 1 Zeile hinzugefügt(+) diff --git a/src/glsl/builtin_compiler/Makefile.am b/src/glsl/builtin_compiler/Makefile.am index eeac424..72032b5 100644 --- a/src/glsl/builtin_compiler/Makefile.am +++ b/src/glsl/builtin_comp

[Mesa-dev] [Bug 56653] Source `src/glsl/builtin_stubs.cpp' not found, needed by target `build/linux-x86_64-debug/glsl/builtin_stubs.o'.

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56653 --- Comment #3 from José Fonseca --- Scons should be fixed with: commit 8ac4b82699ad0a59ae6ae6d3415702eaa5d4fe3b Author: José Fonseca Date: Fri Nov 2 09:42:13 2012 + scons: Update for builtin_stubs.cpp Note this by itself is not

[Mesa-dev] [Bug 56664] New: [recent build error] fatal error: GL/gl.h: No such file or directory

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56664 Priority: medium Bug ID: 56664 Assignee: mesa-dev@lists.freedesktop.org Summary: [recent build error] fatal error: GL/gl.h: No such file or directory Severity: normal Cla

[Mesa-dev] [Bug 56653] Source `src/glsl/builtin_stubs.cpp' not found, needed by target `build/linux-x86_64-debug/glsl/builtin_stubs.o'.

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56653 --- Comment #2 from Thierry Reding --- Darn, I completely forgot to check the SCons and Android builds. I'll take a look and see if I can come up with something that works for all three methods. -- You are receiving this mail because: You are t

Re: [Mesa-dev] [PATCH v2] build: Don't cross-compile GLSL builtin compiler

2012-11-02 Thread Thierry Reding
On Thu, Nov 01, 2012 at 06:20:46PM -0700, Kenneth Graunke wrote: > On 10/19/2012 05:03 AM, Thierry Reding wrote: > >The builtin_compiler binary is used during the build process to generate > >code for the builtin GLSL functions. Since this binary needs to be run > >on the build host, it must not be

[Mesa-dev] [PATCH] i965/fs: Compact the virtual GRF arrays.

2012-11-02 Thread Kenneth Graunke
During code generation, we create tons of temporary variables, many of which get immediately killed and are never used. Later optimization and analysis passes, such as compute_live_intervals, loop over all the virtual GRFs. By compacting them, we can save a lot of overhead. Reduces compilation t

[Mesa-dev] [Bug 56653] Source `src/glsl/builtin_stubs.cpp' not found, needed by target `build/linux-x86_64-debug/glsl/builtin_stubs.o'.

2012-11-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56653 --- Comment #1 from Kenneth Graunke --- Created attachment 69412 --> https://bugs.freedesktop.org/attachment.cgi?id=69412&action=edit patch to fix the SCons build by copying the file builtin_stubs.cpp has been moved to a subfolder, which broke

Re: [Mesa-dev] [PATCH 00/17] dispatch: code generate _mesa_create_exec_table.

2012-11-02 Thread Jordan Justen
Excellent Paul! I didn't realize you were so close to having this ready. It makes a good portion of my GL Core dispatch sanity v2 series unnecessary. Anyway, I rebased my 5 dispatch-sanity changes onto your branch, and it reported that these functions should be nop in GL Core profiles: * ActivePro