Re: [Mesa-dev] [PATCH] i965/gen4: Fix assertion failures in depthstencil piglit tests.

2012-10-31 Thread Kenneth Graunke
On 10/31/2012 07:25 PM, Eric Anholt wrote: Don't forget to set depth_mt even if !hiz_mt. --- src/mesa/drivers/dri/i965/brw_misc_state.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_mi

[Mesa-dev] [PATCH] i965/gen4: Fix assertion failures in depthstencil piglit tests.

2012-10-31 Thread Eric Anholt
Don't forget to set depth_mt even if !hiz_mt. --- src/mesa/drivers/dri/i965/brw_misc_state.c |9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_misc_state.c b/src/mesa/drivers/dri/i965/brw_misc_state.c index ce23fa0..d4b4c75 100644 --- a/

Re: [Mesa-dev] [PATCH] r600g: fix abysmal performance in Reaction Quake

2012-10-31 Thread Marek Olšák
On Thu, Nov 1, 2012 at 2:13 AM, Alex Deucher wrote: > On Wed, Oct 31, 2012 at 8:05 PM, Marek Olšák wrote: >> The problem was we set VRAM|GTT for relocations of STATIC resources. >> Setting just VRAM increases the framerate 4 times on my machine. >> >> I rewrote the switch statement and adjusted t

Re: [Mesa-dev] [PATCH 2/3] i965: Set dirty state for brw_draw_upload.c when num_instances changes.

2012-10-31 Thread Kenneth Graunke
On 10/31/2012 06:13 PM, Eric Anholt wrote: Kenneth Graunke writes: On 10/31/2012 02:26 PM, Eric Anholt wrote: Otherwise, if we had a set of prims passed in with a num_instances varying between them, we wouldn't upload enough (or too much!) from user vertex arrays. --- src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH] r600g: fix abysmal performance in Reaction Quake

2012-10-31 Thread Jerome Glisse
On Wed, Oct 31, 2012 at 8:05 PM, Marek Olšák wrote: > The problem was we set VRAM|GTT for relocations of STATIC resources. > Setting just VRAM increases the framerate 4 times on my machine. > > I rewrote the switch statement and adjusted the domains for window > framebuffers too. Reviewed-by: Jer

[Mesa-dev] [PATCH 2/3] mesa: Fix core GL genned-name handling for glBeginQuery().

2012-10-31 Thread Eric Anholt
Fixes piglit gl-3.1/genned-names. --- src/mesa/main/queryobj.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/queryobj.c b/src/mesa/main/queryobj.c index d216913..2a39176 100644 --- a/src/mesa/main/queryobj.c +++ b/src/mesa/main/queryobj.c @@ -

[Mesa-dev] [PATCH 3/3] mesa: Use "non-gen name" more consistently as an error message in GL core.

2012-10-31 Thread Eric Anholt
I used this to help verify that my test was actually testing the paths I wanted to. --- src/mesa/main/arrayobj.c |2 +- src/mesa/main/texobj.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/arrayobj.c b/src/mesa/main/arrayobj.c index 5959260..926c753

[Mesa-dev] [PATCH 1/3] mesa: Fix the core GL genned-name handling for glBindBufferBase()/Range().

2012-10-31 Thread Eric Anholt
This is part of fixing gl-3.1/genned-names. --- src/mesa/main/bufferobj.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index ac58c99..2f43eb0 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/m

Re: [Mesa-dev] [PATCH] r600g: fix abysmal performance in Reaction Quake

2012-10-31 Thread Alex Deucher
On Wed, Oct 31, 2012 at 8:05 PM, Marek Olšák wrote: > The problem was we set VRAM|GTT for relocations of STATIC resources. > Setting just VRAM increases the framerate 4 times on my machine. > > I rewrote the switch statement and adjusted the domains for window > framebuffers too. Reviewed-by: Ale

Re: [Mesa-dev] [PATCH 1/3] i965: Remove the vbo_rebase_prims() path.

2012-10-31 Thread Eric Anholt
Kenneth Graunke writes: > On 10/31/2012 02:26 PM, Eric Anholt wrote: >> The brw_draw_upload.c start_vertex_bias code has support for doing the rebase >> without rewriting the index buffer by applying a basevertex. It looks like >> vbo_rebase_prims() is not equipped to handle basevertex. >> --- >

Re: [Mesa-dev] [PATCH 2/3] i965: Set dirty state for brw_draw_upload.c when num_instances changes.

2012-10-31 Thread Eric Anholt
Kenneth Graunke writes: > On 10/31/2012 02:26 PM, Eric Anholt wrote: >> Otherwise, if we had a set of prims passed in with a num_instances varying >> between them, we wouldn't upload enough (or too much!) from user vertex >> arrays. >> --- >> src/mesa/drivers/dri/i965/brw_draw.c |5 - >>

Re: [Mesa-dev] [PATCH 6/9] dispatch: Make a header to go along with querymatrix.c.

2012-10-31 Thread Paul Berry
On 31 October 2012 15:27, Chad Versace wrote: > On 10/30/2012 10:42 AM, Paul Berry wrote: > > This patch creates a header querymatrix.h, to allow functions defined > > in querymatrix.c to be used from other .c files. It also switches > > from the nonstandard GL_APIENTRY to GLAPIENTRY. > > --- >

[Mesa-dev] [PATCH v2] dispatch: Include GLES1-only functions in dispatch table.

2012-10-31 Thread Paul Berry
Previously dispatch table-related code was generated from gl_API.xml, so it did not include slots for GLES1-only functions (such as those taking fixed-point arguments). This patch generates dispatch table-related code from gl_and_es_API.xml, so that GLES1-only functions are included. This paves t

[Mesa-dev] [PATCH] r600g: fix abysmal performance in Reaction Quake

2012-10-31 Thread Marek Olšák
The problem was we set VRAM|GTT for relocations of STATIC resources. Setting just VRAM increases the framerate 4 times on my machine. I rewrote the switch statement and adjusted the domains for window framebuffers too. --- src/gallium/drivers/r600/r600_buffer.c | 42 ---

Re: [Mesa-dev] [PATCH 1/3] i965: Remove the vbo_rebase_prims() path.

2012-10-31 Thread Kenneth Graunke
On 10/31/2012 02:26 PM, Eric Anholt wrote: The brw_draw_upload.c start_vertex_bias code has support for doing the rebase without rewriting the index buffer by applying a basevertex. It looks like vbo_rebase_prims() is not equipped to handle basevertex. --- src/mesa/drivers/dri/i965/brw_draw.c

Re: [Mesa-dev] [PATCH 2/3] i965: Set dirty state for brw_draw_upload.c when num_instances changes.

2012-10-31 Thread Kenneth Graunke
On 10/31/2012 02:26 PM, Eric Anholt wrote: Otherwise, if we had a set of prims passed in with a num_instances varying between them, we wouldn't upload enough (or too much!) from user vertex arrays. --- src/mesa/drivers/dri/i965/brw_draw.c |5 - 1 file changed, 4 insertions(+), 1 deleti

Re: [Mesa-dev] GL 3.1 on Radeon HD 4670?

2012-10-31 Thread Dave Airlie
On Thu, Nov 1, 2012 at 8:11 AM, Marek Olšák wrote: > The missing features for GL 3.1 are just UBOs and TBOs. Dave Airlie > has been working on TBOs. Nobody is working on UBOs as far as I know. > Both features need changes in the driver and in the common code (st/mesa). I should probably push the

Re: [Mesa-dev] [PATCH 4/9] dispatch: Include GLES1-only functions in dispatch table.

2012-10-31 Thread Paul Berry
On 31 October 2012 15:21, Chad Versace wrote: > Tapani, see the bottom of the message. > > On 10/30/2012 10:42 AM, Paul Berry wrote: > > Previously dispatch table-related code was generated from gl_API.xml, > > so it did not include slots for GLES1-only functions (such as those > > taking fixed-p

[Mesa-dev] [Bug 55998] Pretty huge slowdown in mesa 9.0

2012-10-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=55998 --- Comment #28 from ValdikSS --- For me, this fixes slowdown which I wrote in the first message. There is 2 other bugs: screen corruption with gles and incorrect screen repainting with gl. And I don't know if it's MESA or KDE bugs. -- You are

Re: [Mesa-dev] [PATCH 6/9] dispatch: Make a header to go along with querymatrix.c.

2012-10-31 Thread Chad Versace
On 10/30/2012 10:42 AM, Paul Berry wrote: > This patch creates a header querymatrix.h, to allow functions defined > in querymatrix.c to be used from other .c files. It also switches > from the nonstandard GL_APIENTRY to GLAPIENTRY. > --- > src/mesa/main/querymatrix.c | 12 +--- > src/mesa

Re: [Mesa-dev] [PATCH 4/9] dispatch: Include GLES1-only functions in dispatch table.

2012-10-31 Thread Chad Versace
Tapani, see the bottom of the message. On 10/30/2012 10:42 AM, Paul Berry wrote: > Previously dispatch table-related code was generated from gl_API.xml, > so it did not include slots for GLES1-only functions (such as those > taking fixed-point arguments). > > This patch generates dispatch table-r

[Mesa-dev] [Bug 55998] Pretty huge slowdown in mesa 9.0

2012-10-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=55998 --- Comment #27 from dw...@tormail.org --- Okay, Arch Linux has now put out... kdebase-workspace 4.9.2-6 Which I guess has this patch applied. My system is now all up-to-date and there are no more Artifacts or slow down. However, the Tarring lin

Re: [Mesa-dev] GL 3.1 on Radeon HD 4670?

2012-10-31 Thread Marek Olšák
The missing features for GL 3.1 are just UBOs and TBOs. Dave Airlie has been working on TBOs. Nobody is working on UBOs as far as I know. Both features need changes in the driver and in the common code (st/mesa). Marek On Wed, Oct 31, 2012 at 7:34 PM, Patrick Baggett wrote: > DOH. I'm sorry, I r

Re: [Mesa-dev] [PATCH 1/2] mesa/vbo: Fix scaling issue in 10-bit signed normalized packing.

2012-10-31 Thread Marek Olšák
On Wed, Oct 31, 2012 at 7:45 PM, Kenneth Graunke wrote: > On 10/15/2012 09:45 AM, Ian Romanick wrote: >> >> On 10/14/2012 12:02 PM, Kenneth Graunke wrote: >>> >>> For the 10-bit components, the divisor was incorrect. A 10-bit signed >>> integer can represent -2^9 through 2^9 - 1, which leads to t

Re: [Mesa-dev] [PATCH 3/9] dispatch: properly handle parameter name mismatches in glapitemp.h.

2012-10-31 Thread Chad Versace
On 10/30/2012 10:42 AM, Paul Berry wrote: > Previously, when code-generating aliased functions in glapitemp.h, we > weren't consistent about which function alias we used to obtain the > parameter names, with the risk that we would generate incorrect code > like this: > > KEYWORD1 void KEYWORD2 N

Re: [Mesa-dev] [PATCH 2/9] dispatch: Include glheader.h in dispatch-related files.

2012-10-31 Thread Chad Versace
On 10/30/2012 10:42 AM, Paul Berry wrote: > This ensures that GLES1-only typedefs are available in these files. > In a future patch, this will allow us to expand the dispatch table to > include GLES1-only functions. > --- > src/glx/tests/indirect_api.cpp | 2 +- > src/mapi/glapi/gen/g

Re: [Mesa-dev] [PATCH 1/9] dispatch: Update check_table.cpp to reflect recent aliasing changes.

2012-10-31 Thread Chad Versace
On 10/30/2012 10:42 AM, Paul Berry wrote: > In commits bad96f6 and e7dd2e5 I added the following aliases: > - ClampColor -> ClampColorARB > - VertexAttribDivisor -> VertexAttribDivisorARB > > But I neglected to update check_table.cpp, causing "make check" to > fail for non-shared-glapi builds. >

Re: [Mesa-dev] R600 tiling halves the frame rate

2012-10-31 Thread Tzvetan Mikov
On 10/31/2012 07:41 AM, Jerome Glisse wrote: For it to look right we need mesa to call into the kernel to tell the kernel what is the bo tiling format. We should do that for scanout buffer. This will fix your issue and you probably want 2d tiled not 1d for scanout. Anyway, since I do need this,

[Mesa-dev] [PATCH 3/3] i965: Fix uploading user vertex arrays with basevertex set.

2012-10-31 Thread Eric Anholt
If the index buffer is full of values like "0 1 2 3", but basevertex is 4, we need to upload at least vertex data for elements 4 5 6 7. Whether we also upload 0 1 2 3 is a question of whether there are VBOs present or not -- see the code setting start_vertex_bias in brw_draw_upload.c. Fixes pigli

[Mesa-dev] [PATCH 1/3] i965: Remove the vbo_rebase_prims() path.

2012-10-31 Thread Eric Anholt
The brw_draw_upload.c start_vertex_bias code has support for doing the rebase without rewriting the index buffer by applying a basevertex. It looks like vbo_rebase_prims() is not equipped to handle basevertex. --- src/mesa/drivers/dri/i965/brw_draw.c | 21 ++--- 1 file changed,

[Mesa-dev] Fix draw_elements_base_vertex with user vertex arrays

2012-10-31 Thread Eric Anholt
Note that this patch series sits on top of Ken's stride == 0 changes, otherwise the piglit tests trip the assert. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/mesa-dev

[Mesa-dev] [PATCH 2/3] i965: Set dirty state for brw_draw_upload.c when num_instances changes.

2012-10-31 Thread Eric Anholt
Otherwise, if we had a set of prims passed in with a num_instances varying between them, we wouldn't upload enough (or too much!) from user vertex arrays. --- src/mesa/drivers/dri/i965/brw_draw.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH] configure.ac: Prevent build of radeon llvm backend with llvm < 3.2

2012-10-31 Thread Vincent Lejeune
--- configure.ac | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 6b97a26..b916b38 100644 --- a/configure.ac +++ b/configure.ac @@ -1748,15 +1748,19 @@ gallium_require_drm_loader() { } radeon_llvm_check() { -LLVM_VERSION_M

Re: [Mesa-dev] [PATCH 1/2] mesa/vbo: Fix scaling issue in 10-bit signed normalized packing.

2012-10-31 Thread Kenneth Graunke
On 10/15/2012 09:45 AM, Ian Romanick wrote: On 10/14/2012 12:02 PM, Kenneth Graunke wrote: For the 10-bit components, the divisor was incorrect. A 10-bit signed integer can represent -2^9 through 2^9 - 1, which leads to the following ranges: (float)value.x -> [ -512, 511] 2.0

Re: [Mesa-dev] GL 3.1 on Radeon HD 4670?

2012-10-31 Thread Patrick Baggett
DOH. I'm sorry, I read that Mesa supported GL 3.1 and somehow I generalized that to all drivers. Thanks for that TODO list. I guess I need to start reading about the R700 architecture... Patrick On Wed, Oct 31, 2012 at 1:28 PM, Alex Deucher wrote: > On Wed, Oct 31, 2012 at 1:11 PM, Patrick Bagg

Re: [Mesa-dev] [PATCH 3/5] mesa: Import a copy of the open-addressing hash table code I wrote.

2012-10-31 Thread Chad Versace
I look forward to seeing this improved hash table land. Great that it includes tests. I failed to find a test that artificially constructed collisions and verified that they were handled correctly. Maybe I'll submit a test for that. Comments below. Everything looked correct, so my review mostly a

Re: [Mesa-dev] GL 3.1 on Radeon HD 4670?

2012-10-31 Thread Alex Deucher
On Wed, Oct 31, 2012 at 1:11 PM, Patrick Baggett wrote: > Hi all, > > I've got a really weird duck of system: an Itanium2 system running Linux > 3.7.0-rc3 with the newest libdrm and mesa git from yesterday. I configured > it with --enable-texture-float and the radeon DRI driver. When I use > glxin

[Mesa-dev] GL 3.1 on Radeon HD 4670?

2012-10-31 Thread Patrick Baggett
Hi all, I've got a really weird duck of system: an Itanium2 system running Linux 3.7.0-rc3 with the newest libdrm and mesa git from yesterday. I configured it with --enable-texture-float and the radeon DRI driver. When I use glxinfo, I see that it is Mesa 9.1-devel but only OpenGL 3.0. Is that bec

Re: [Mesa-dev] [PATCH] AMDGPU: Don't allow using SI SGPRs 102 and 103 directly.

2012-10-31 Thread Tom Stellard
On Wed, Oct 31, 2012 at 05:00:04PM +0100, Michel Dänzer wrote: > From: Michel Dänzer > > Two SGPRs are used for VCC, so it's not possible to use these and VCC > together. > Reviewed-by: Tom Stellard > Signed-off-by: Michel Dänzer > --- > lib/Target/AMDGPU/SIRegisterInfo.td |4 ++-- > 1

Re: [Mesa-dev] [PATCH] AMDGPU: Only allow SGPR for the first operand of SI VOP3 instructions.

2012-10-31 Thread Alex Deucher
On Tue, Oct 30, 2012 at 12:48 PM, Michel Dänzer wrote: > From: Michel Dänzer > > This is technically too strict: While a VOP3 instruction can only use one > SGPR, > it can be used for any operand, even for several operands at the same. But for > now this is a simple solution which fixes the prob

[Mesa-dev] [PATCH] AMDGPU: Don't allow using SI SGPRs 102 and 103 directly.

2012-10-31 Thread Michel Dänzer
From: Michel Dänzer Two SGPRs are used for VCC, so it's not possible to use these and VCC together. Signed-off-by: Michel Dänzer --- lib/Target/AMDGPU/SIRegisterInfo.td |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/Target/AMDGPU/SIRegisterInfo.td b/lib/Target/

[Mesa-dev] [PATCH] nv50,nvc0: expose ARB_map_buffer_alignment

2012-10-31 Thread Lucas Stach
All HW buffers (also suballocated ones) are already aligned. Just make sure that also the initial sysram buffers have proper alignment. --- Passes the ARB_map_buffer_alignment piglit test on nv50. Not tested on nvc0. --- src/gallium/drivers/nouveau/nouveau_buffer.c | 6 +++--- src/gallium/drivers/

Re: [Mesa-dev] [PATCH] vbo: fix glVertexAttribI* functions

2012-10-31 Thread Brian Paul
On 10/30/2012 04:32 PM, Marek Olšák wrote: The functions were broken, because they converted ints to floats. Now we can finally advertise OpenGL 3.0. ;) In this commit, the vbo module also tracks the type for each attrib in addition to the size. It can be one of FLOAT, INT, UNSIGNED_INT. The li

Re: [Mesa-dev] R600 tiling halves the frame rate

2012-10-31 Thread Jerome Glisse
On Tue, Oct 30, 2012 at 8:49 PM, Tzvetan Mikov wrote: > On 10/30/2012 05:20 PM, Tzvetan Mikov wrote: >> >> Thanks a lot! I reproduced the same results here and I think I have >> figured out what the problem is. The frame buffer is always created in >> linear mode. The temporary hack included below

[Mesa-dev] [Bug 56605] [build error when building without --enable-debug] /usr/bin/ld: ../../auxiliary//libgallium.a(u_dl.o): undefined reference to symbol 'dlopen@@GLIBC_2.1'

2012-10-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56605 Fabio Pedretti changed: What|Removed |Added Summary|[regression - build error] |[build error when building

[Mesa-dev] [Bug 56605] New: [regression - build error] /usr/bin/ld: ../../auxiliary//libgallium.a(u_dl.o): undefined reference to symbol 'dlopen@@GLIBC_2.1'

2012-10-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=56605 Priority: medium Bug ID: 56605 Assignee: mesa-dev@lists.freedesktop.org Summary: [regression - build error] /usr/bin/ld: ../../auxiliary//libgallium.a(u_dl.o): undefined