Re: [Mesa-dev] Intel build failure with 9.0

2012-10-12 Thread Ian Romanick
On 10/10/2012 11:32 AM, Paul Seidler wrote: On Wed, 10 Oct 2012 10:27:04 -0700, Ian Romanick wrote: On 10/09/2012 10:00 AM, Paul Seidler wrote: Hello, please cherry-pick 7cb8764ca39cb7f325d6da10a8b11bf24adf2ae0 ("intel: Add missing #include ", [1]) in the 9.0 branch. The original commit me

[Mesa-dev] [PATCH 5/5] i965: Fix rendering to small mipmaps of depth/stencil buffers using a temp mt.

2012-10-12 Thread Eric Anholt
Fixes 51 piglit tests (fbo-clear-formats, and most of the remaining failures in depthstencil). --- src/mesa/drivers/dri/i965/brw_context.h |1 + src/mesa/drivers/dri/i965/brw_draw.c|5 + src/mesa/drivers/dri/i965/brw_misc_state.c | 187 ++- src/mesa/dr

[Mesa-dev] [PATCH 4/5] i965: Share the draw x/y offset masking code between main/blorp and all gens.

2012-10-12 Thread Eric Anholt
This code is twisty, and the comment before most of the blocks was actually giving me the opposite impression from its intention: We want to apply as much of our offset as possible through coarse tile-aligned adjustment, since we can do so independently per buffer, and apply the minimum we can thro

[Mesa-dev] [PATCH 3/5] i965: Make a helper function for the renderbuffer temporary mt workaround.

2012-10-12 Thread Eric Anholt
We now have a case of wanting to do that on gen6+ as well, so make this logic usable elsewhere. --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 23 +-- src/mesa/drivers/dri/intel/intel_fbo.c | 26 ++ src/mesa/drivers/dri/intel/intel_fbo.h

[Mesa-dev] [PATCH 2/5] i965: Warn on a couple of workarounds in blending.

2012-10-12 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/gen6_cc.c | 17 +++-- 1 file changed, 15 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/gen6_cc.c b/src/mesa/drivers/dri/i965/gen6_cc.c index e9c7f50..b61a816c 100644 --- a/src/mesa/drivers/dri/i965/gen6_cc.c +++ b/src/mesa/driver

[Mesa-dev] [PATCH 1/5] intel: Add a macro for printing a debug warning once.

2012-10-12 Thread Eric Anholt
There are a number of places where some obscure piece of the code is not currently worth fixing, and we have some workaround behavior available. It's nicer for users to do some lame workaround than to just assert, but without asserts we never knew when the workaround was at fault. This should giv

Re: [Mesa-dev] [PATCH 4/6] i965/fs: Reduce the interference between payload regs and virtual GRFs.

2012-10-12 Thread Kenneth Graunke
On 10/02/2012 07:52 PM, Eric Anholt wrote: Improves performance of the Lightsmark penumbra shadows scene by 15.7% +/- 1.0% (n=15), by eliminating register spilling. (tested by smashing the list of scenes to have all other scenes have 0 duration -- includes additional rendering of scene descriptio

[Mesa-dev] [PATCH 10/10] glapi: Delete gles_api.py, since it is no longer used.

2012-10-12 Thread Paul Berry
--- src/mapi/glapi/gen/gl_and_es_API.xml | 5 - src/mapi/glapi/gen/gles_api.py | 461 --- 2 files changed, 466 deletions(-) delete mode 100644 src/mapi/glapi/gen/gles_api.py diff --git a/src/mapi/glapi/gen/gl_and_es_API.xml b/src/mapi/glapi/gen/gl_and_es_

[Mesa-dev] [PATCH 09/10] mapi_abi: Use GLES information from XML rather than gles_api.py.

2012-10-12 Thread Paul Berry
Note: mapi_abi can consume API information from either XML or a .csv file. A side effect of this change is that the ES1 and ES2 API printers can only be used with XML input now. That's ok, since the .csv input format is only used for the OpenVG API. --- src/mapi/mapi/mapi_abi.py | 16 +++

[Mesa-dev] [PATCH 08/10] mapi_abi: Override 'hidden' and 'handcode' attributes using polymorphism.

2012-10-12 Thread Paul Berry
Previously, the ES1, ES2, and shared GLAPI printers passed a list of function names to the base class constructor, which was used by the _override_for_api() function to loop over all the API functions and adjust their 'hidden' and 'handcode' attributes as appropriate for the API flavour being code-

[Mesa-dev] [PATCH 07/10] mapi_abi: Get rid of unnecessary copy.

2012-10-12 Thread Paul Berry
Previously, _get_api_entries() would make a deep copy of each element in the entries table before modifying the 'hidden' and 'handcode' attributes. This was unnecessary, since the entries aren't used again after this function. Removing the copy simplifies the code, because it is no longer necessa

[Mesa-dev] [PATCH 06/10] mapi_abi: Remove sanity check that all GLES functions are present.

2012-10-12 Thread Paul Berry
Currently mapi_abi.py uses hardcoded lists of function names (in gles_api.py) to determine which functions need to be included in the GLES 1 or GLES 2 API. This patch removes a sanity check which verified that all GLES functions listed in the hardcoded lists were actually present in the XML. Late

[Mesa-dev] [PATCH 05/10] mapi_abi: Collect all imports at top of file.

2012-10-12 Thread Paul Berry
--- src/mapi/mapi/mapi_abi.py | 13 + 1 file changed, 5 insertions(+), 8 deletions(-) diff --git a/src/mapi/mapi/mapi_abi.py b/src/mapi/mapi/mapi_abi.py index c18dd82..4fd1582 100644 --- a/src/mapi/mapi/mapi_abi.py +++ b/src/mapi/mapi/mapi_abi.py @@ -34,6 +34,11 @@ sys.path.append(GLA

[Mesa-dev] [PATCH 04/10] glapi: Use GLES information from XML rather than gles_api.py.

2012-10-12 Thread Paul Berry
--- src/mapi/glapi/gen/gl_table.py | 9 + src/mapi/glapi/gen/remap_helper.py | 9 + 2 files changed, 2 insertions(+), 16 deletions(-) diff --git a/src/mapi/glapi/gen/gl_table.py b/src/mapi/glapi/gen/gl_table.py index 856aedb..382eaaf 100644 --- a/src/mapi/glapi/gen/gl_table.py

[Mesa-dev] [PATCH 03/10] glapi: Read GLES information from XML.

2012-10-12 Thread Paul Berry
--- src/mapi/glapi/gen/gl_XML.py | 48 1 file changed, 48 insertions(+) diff --git a/src/mapi/glapi/gen/gl_XML.py b/src/mapi/glapi/gen/gl_XML.py index f956730..ef7ed51 100644 --- a/src/mapi/glapi/gen/gl_XML.py +++ b/src/mapi/glapi/gen/gl_XML.py @@ -25,

[Mesa-dev] [PATCH 02/10] glapi: Add es1 and es2 attributes to XML.

2012-10-12 Thread Paul Berry
Currently, the set of functions which exist in GLES1 or GLES2 is determined by hardcoded lists of function names in gles_api.py. This patch encodes that information into the XML files using new attributes, es1 and es2. The es1 attribute denotes the first version of GLES 1 in which the function ex

[Mesa-dev] [PATCH 01/10] glapi: use new-style Python classes.

2012-10-12 Thread Paul Berry
An unfortunate quirk of Python 2 is that there are two types of classes: "classic" classes (which are backward compatible with some unfortunate design decisions made early in Python's history), and "new-style" classes. Classic classes have a number of limitations (for example they don't support su

[Mesa-dev] [PATCH 00/10] glapi: Get rid of gles_api.py file.

2012-10-12 Thread Paul Berry
This patch series gets rid of the file src/mapi/glapi/gen/gles_api.py (which previously contained a list of the functions exposed in GLES 1 and GLES 2). This information is now stored in the XML files in src/mapi/glapi/gen/, using the XML attributes "es1" and "es2". Patch 01 does some preliminary

[Mesa-dev] [Bug 55817] Torchlight: Texture renders as garbage

2012-10-12 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=55817 --- Comment #4 from Sven Arvidsson --- Actually, I'm on Redwood, not Juniper, but the problem doesn't seem to be hardware specific, llvmpipe shows a similar problem. Anyway, I'm not quite up to speed with apitrace or OpenGL in general to track d

[Mesa-dev] [PATCH] intel: Skip texsubimage fastpath for more pixel unpack state

2012-10-12 Thread Chad Versace
Fixes piglit tests "unpack-teximage2d --pbo=* --format=GL_BGRA" on Sandybridge+. The fastpath was checking an incomplete set of pixel unpack state. This patch adds checks for all the fields of gl_pixelstore_attrib that affect 2D texture uploads. Also, it begins permitting the case where GL_UNPACK

Re: [Mesa-dev] [PATCH 1/2] mesa: Add functions _mesa_[un]pack_is_default()

2012-10-12 Thread Chad Versace
On 10/12/2012 07:56 AM, Brian Paul wrote: > On 10/12/2012 05:31 AM, Neil Roberts wrote: >> Chad Versace writes: >> >>> +bool >>> +_mesa_pack_is_default(struct gl_context *ctx) >>> +{ >>> + return memcmp(&ctx->Pack,&ctx->DefaultPacking, >>> + sizeof(struct gl_pixelstore_attrib)) =

[Mesa-dev] [PATCH] r600g: implement texturing with 8x MSAA compressed surfaces for Evergreen

2012-10-12 Thread Marek Olšák
The 2x and 4x cases are completely broken. The lfdptr instruction returns garbage there. The 8x case is broken on Cayman, though at least the result looks somewhat correct. I think we're missing some info. Anyway, at least one case works. --- src/gallium/auxiliary/util/u_blitter.c |8 +

Re: [Mesa-dev] [PATCH 1/6] i965: add missing BRW_SURFACEFORMAT constants from Ivybridge PRM

2012-10-12 Thread Kenneth Graunke
On 10/11/2012 10:48 PM, Matt Turner wrote: On Tue, Oct 9, 2012 at 2:33 AM, Chris Forbes wrote: From the master surface formats list in the Sampler Engine chapter. The relevant formats for 2_10_10_10 are mentioned in the Sandybridge PRM as vertex attribute types, but the 0x1b*- encodings are mi

Re: [Mesa-dev] [Mesa-users] Missing file in 9.0?

2012-10-12 Thread Brian Paul
[cc'ing the mesa-dev list on this / originally posted to mesa-users] On 10/11/2012 11:40 AM, Lo, Li-Ta wrote: Hi, It looks like the 9.0 release is missing some important script files, configure failed like this: [ollie@taco Mesa-9.0]$ ./configure configure: error: cannot find install-sh, insta

Re: [Mesa-dev] [PATCH 1/2] u_format_s3tc.c: Don't call getenv() twice

2012-10-12 Thread Brian Paul
On 10/11/2012 02:56 PM, Matt Turner wrote: --- src/gallium/auxiliary/util/u_format_s3tc.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/auxiliary/util/u_format_s3tc.c b/src/gallium/auxiliary/util/u_format_s3tc.c index d8a7c0d..4a9dc22 100644 --- a/sr

Re: [Mesa-dev] [PATCH 1/2] mesa: Add functions _mesa_[un]pack_is_default()

2012-10-12 Thread Brian Paul
On 10/12/2012 05:31 AM, Neil Roberts wrote: Chad Versace writes: +bool +_mesa_pack_is_default(struct gl_context *ctx) +{ + return memcmp(&ctx->Pack,&ctx->DefaultPacking, + sizeof(struct gl_pixelstore_attrib)) == 0; +} It seems like a shame that this wouldn't catch the cases

Re: [Mesa-dev] Fix a crash in update_texture_state() when requesting a fallback for external texture target

2012-10-12 Thread Brian Paul
On 10/12/2012 02:42 AM, Abdiel Janulgue wrote: On Wednesday, October 10, 2012 08:33:08 AM Brian Paul wrote: On 10/10/2012 05:42 AM, Abdiel Janulgue wrote: I found a crash where updating the texture unit states ends up requesting a fallback texture for a GL_TEXTURE_EXTERNAL_OES target and sets

Re: [Mesa-dev] [PATCH 1/2] mesa: Add functions _mesa_[un]pack_is_default()

2012-10-12 Thread Neil Roberts
Chad Versace writes: > +bool > +_mesa_pack_is_default(struct gl_context *ctx) > +{ > + return memcmp(&ctx->Pack, &ctx->DefaultPacking, > + sizeof(struct gl_pixelstore_attrib)) == 0; > +} It seems like a shame that this wouldn't catch the cases where the row length and alignment

Re: [Mesa-dev] [PATCH 2/2] Make envvars set to zero actually be false

2012-10-12 Thread Jose Fonseca
- Original Message - > On Thu, Oct 11, 2012 at 2:04 PM, Jose Fonseca > wrote: > > - Original Message - > >> Previously, LIBGL_ALWAYS_SOFTWARE=0 glxgears would still run > >> swrast. > >> This is not what people expect. > >> --- > >> Please check my logic. The Apple code checks th

Re: [Mesa-dev] [PATCH 2/2] Make envvars set to zero actually be false

2012-10-12 Thread Jose Fonseca
- Original Message - > On Thu, Oct 11, 2012 at 8:53 PM, Matt Turner > wrote: > > On Thu, Oct 11, 2012 at 2:12 PM, Dave Airlie > > wrote: > >>> Previously, LIBGL_ALWAYS_SOFTWARE=0 glxgears would still run > >>> swrast. > >>> This is not what people expect. > >> > >> Is it documented eith

Re: [Mesa-dev] Fix a crash in update_texture_state() when requesting a fallback for external texture target

2012-10-12 Thread Abdiel Janulgue
mesa: Fix a crash in update_texture_state() when requesting a fallback for an external texture target. NOTE: This is a candidate for the stable branch. Signed-off-by: Abdiel diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index 513f3bb..224d8a8 100644 ---

Re: [Mesa-dev] Fix a crash in update_texture_state() when requesting a fallback for external texture target

2012-10-12 Thread Abdiel Janulgue
On Wednesday, October 10, 2012 08:33:08 AM Brian Paul wrote: > On 10/10/2012 05:42 AM, Abdiel Janulgue wrote: > > I found a crash where updating the texture unit states ends up requesting > > a > > fallback texture for a GL_TEXTURE_EXTERNAL_OES target and sets a null > > current texture object for

Re: [Mesa-dev] [PATCH 08/14] r600g: initialize SQ_VTX_SEMANTIC_* in the start_cs command buffer

2012-10-12 Thread Andre Maasikas
On Sun, Oct 7, 2012 at 9:08 PM, Marek Olšák wrote: > + r600_store_context_reg_seq(cb, R_028380_SQ_VTX_SEMANTIC_0, 34); > + r600_store_value(cb, 0); /* R_028380_SQ_VTX_SEMANTIC_0 */ .. > + r600_store_value(cb, 0); /* R_0283FC_SQ_VTX_SEMANTIC_31 */ Btw there's also a SQ_VTX_SEMAN