On Tue, Sep 11, 2012 at 03:58:16AM +0200, Marek Olšák wrote:
> This looks good to me.
>
> I guess rc_class_list should be static, right?
>
Yes, I'll fix that.
> Just FYI: I see that you moved it out of the function. The issue with
> putting such a large non-static array into a function is that t
This looks good to me.
I guess rc_class_list should be static, right?
Just FYI: I see that you moved it out of the function. The issue with
putting such a large non-static array into a function is that the
whole array is re-initialized on the stack everytime the function is
re-entered. The "stati
On Mon, Sep 10, 2012 at 4:46 PM, Anuj Phogat wrote:
> Brian, Did you get a chance to look at my other patch as well:
> ([PATCH 2/2] _mesa_meta_GenerateMipmap: Generate
> separate shaders for glsl 120 / 130) ?
> Any more thoughts on including the code for 3D textures and
> integer-textures ? I pos
A couple minor things below.
On Tue, Sep 4, 2012 at 8:43 PM, Anuj Phogat wrote:
> glsl version of _mesa_meta_GenerateMipmap() would require separate
> shaders for glsl 120 and 130.
>
> NOTE: This is a candidate for stable branches.
>
> Signed-off-by: Anuj Phogat
> ---
> src/mesa/drivers/common/
On Mon, Sep 10, 2012 at 3:16 PM, Anuj Phogat wrote:
> On Thu, Mar 8, 2012 at 7:19 PM, Brian Paul wrote:
>> There are several cases in which we need to explicity "rebase" colors
>> (ex: set G=B=0) when getting GL_LUMINANCE textures:
>> 1. If the luminance texture is actually stored as rgba
>> 2. I
On 31 August 2012 16:04, Kenneth Graunke wrote:
> According to the GLSL 4.30 specification, this is a compile time error.
> Earlier specifications don't specify a behavior, but since 0 and 1 are
> the only valid indices for dual source blending, it makes sense to
> generate the error.
>
> Fixes (
---
src/gallium/drivers/r600/evergreen_hw_context.c | 16 ---
src/gallium/drivers/r600/r600.h |7 -
src/gallium/drivers/r600/r600_hw_context.c | 15 ++
src/gallium/drivers/r600/r600_hw_context_priv.h |2 +-
src/gallium/drivers/r600/r600_pipe.h
---
src/gallium/drivers/r600/evergreen_hw_context.c | 15 +-
src/gallium/drivers/r600/r600_hw_context.c |6 +--
src/gallium/drivers/r600/r600_hw_context_priv.h |2 +-
src/gallium/drivers/r600/r600_pipe.h|3 ++
src/gallium/drivers/r600/r600_state_common.c| 6
---
src/gallium/drivers/r600/evergreen_hw_context.c |4 ---
src/gallium/drivers/r600/evergreen_state.c |1 +
src/gallium/drivers/r600/r600_hw_context.c |3 +-
src/gallium/drivers/r600/r600_pipe.h| 13 ++--
src/gallium/drivers/r600/r600_shader.c |
---
src/gallium/drivers/r600/r600_hw_context.c | 15 ++-
src/gallium/drivers/r600/r600_hw_context_priv.h |3 ++-
2 files changed, 12 insertions(+), 6 deletions(-)
diff --git a/src/gallium/drivers/r600/r600_hw_context.c
b/src/gallium/drivers/r600/r600_hw_context.c
index 7cf
---
src/gallium/drivers/r600/evergreen_state.c |2 +-
src/gallium/drivers/r600/r600_state.c |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/r600/evergreen_state.c
b/src/gallium/drivers/r600/evergreen_state.c
index 902707c..c299b2e 100644
---
---
src/gallium/drivers/r600/evergreen_hw_context.c | 49 ---
src/gallium/drivers/r600/evergreen_state.c | 42 +++
src/gallium/drivers/r600/r600_hw_context.c | 25 +---
src/gallium/drivers/r600/r600_pipe.h| 10 +++--
src/gal
---
src/gallium/drivers/r600/evergreen_hw_context.c |8
src/gallium/drivers/r600/evergreen_state.c |3 ++-
src/gallium/drivers/r600/r600_hw_context.c |5 +
src/gallium/drivers/r600/r600_pipe.h| 10 --
src/gallium/drivers/r600/r600_state.c
---
src/gallium/drivers/r600/evergreen_hw_context.c | 12 -
src/gallium/drivers/r600/evergreen_state.c |1 +
src/gallium/drivers/r600/r600_blit.c|4 +--
src/gallium/drivers/r600/r600_hw_context.c |7 +
src/gallium/drivers/r600/r600_pipe.h
---
src/gallium/drivers/r600/evergreen_hw_context.c |4 --
src/gallium/drivers/r600/evergreen_state.c |1 +
src/gallium/drivers/r600/r600_blit.c|4 +-
src/gallium/drivers/r600/r600_hw_context.c |7 ++--
src/gallium/drivers/r600/r600_pipe.h| 45 ++
---
src/gallium/drivers/r600/r600_pipe.h |8
1 file changed, 8 deletions(-)
diff --git a/src/gallium/drivers/r600/r600_pipe.h
b/src/gallium/drivers/r600/r600_pipe.h
index 7e703a6..59fc592 100644
--- a/src/gallium/drivers/r600/r600_pipe.h
+++ b/src/gallium/drivers/r600/r600_pipe.h
@@
by reusing the CS initialization in r600_context_flush.
---
src/gallium/drivers/r600/evergreen_state.c |6 --
src/gallium/drivers/r600/r600.h|1 +
src/gallium/drivers/r600/r600_hw_context.c | 29 +---
src/gallium/drivers/r600/r600_pipe.c |
---
src/gallium/drivers/r600/evergreen_state.c | 16 -
src/gallium/drivers/r600/r600_blit.c |8 ++---
src/gallium/drivers/r600/r600_hw_context.c | 24 ++---
src/gallium/drivers/r600/r600_pipe.h |3 +-
src/gallium/drivers/r600/r600_state.c|
---
src/gallium/drivers/r600/evergreen_state.c | 20
src/gallium/drivers/r600/evergreend.h |2 ++
src/gallium/drivers/r600/r600_pipe.h |2 +-
src/gallium/drivers/r600/r600_state.c | 27 +++
src/gallium/drivers/r600/r600d.h
Update only those sampler states which are changed in a shader stage,
instead of always updating all sampler states in the shader stage.
That requires keeping a bitmask of those states which are enabled, and those
states which are dirty at a given point (subset of enabled states).
This is similar
---
src/gallium/drivers/r600/evergreen_state.c | 24
src/gallium/drivers/r600/r600_state.c| 24
src/gallium/drivers/r600/r600_state_common.c | 24
3 files changed, 24 insertions(+), 48 deletions(-)
diff --g
---
src/gallium/drivers/r600/evergreen_state.c | 14 --
src/gallium/drivers/r600/r600_pipe.h |5 -
src/gallium/drivers/r600/r600_state.c| 14 --
src/gallium/drivers/r600/r600_state_common.c | 22 +-
4 files changed, 17 ins
to easily and robustly handle multiple shader stages
---
src/gallium/drivers/r600/evergreen_state.c |8 +++
src/gallium/drivers/r600/r600_buffer.c | 31 ++
src/gallium/drivers/r600/r600_hw_context.c | 10 +
src/gallium/drivers/r600/r600_pipe.h
---
src/gallium/drivers/r600/evergreen_state.c | 14
src/gallium/drivers/r600/r600_state.c| 14
src/gallium/drivers/r600/r600_state_common.c | 46 +-
3 files changed, 37 insertions(+), 37 deletions(-)
diff --git a/src/gallium/drivers/r600/
---
src/gallium/drivers/r600/evergreen_state.c | 32 +--
src/gallium/drivers/r600/r600_pipe.c |4 +-
src/gallium/drivers/r600/r600_pipe.h | 48 +--
src/gallium/drivers/r600/r600_state.c| 31 +--
src/gallium/drivers/r600/r600_state_common.c | 116
Nothing too exciting. Besides cleanups, there are fine-grained sampler state
updates (it emits only the samplers which changed), support for geometry shader
resources (because it was easy; I am not working on GS right now), atomization
of some states, some fixes and a major cleanup in r600_draw_
Brian, Did you get a chance to look at my other patch as well:
([PATCH 2/2] _mesa_meta_GenerateMipmap: Generate
separate shaders for glsl 120 / 130) ?
Any more thoughts on including the code for 3D textures and
integer-textures ? I posted my views on this in an earlier
e-mail. I'll be happy to mak
On Thu, Mar 8, 2012 at 7:19 PM, Brian Paul wrote:
> There are several cases in which we need to explicity "rebase" colors
> (ex: set G=B=0) when getting GL_LUMINANCE textures:
> 1. If the luminance texture is actually stored as rgba
> 2. If getting a luminance texture, but returning rgba
> 3. If g
Our code generation for the GLSL 1.30+-style shadow sampling functions
(which return a float rather than a vec4) always returns the R channel.
This poses a problem for handling DEPTH_TEXTURE_MODE with surface state
swizzling: the R channel would have 0 (while A would have the result).
Since the sa
Haswell supports EXT_texture_swizzle and legacy DEPTH_TEXTURE_MODE
swizzling by setting SURFACE_STATE entries. This means we don't have to
bake the swizzle settings into the shader code by emitting MOV
instructions, and thus don't have to recompile shaders whenever the
swizzles change.
Signed-off
This patch unindents some code by converting:
if (condition) { ...lots of code... }
to the quick-exit style:
if (!condition) continue; ...lots of code...
Except that it leaves the swizzling code indented under an if (true)
block because the next patch needs to make it conditional (and the
https://bugs.freedesktop.org/show_bug.cgi?id=41740
Andreas Boll changed:
What|Removed |Added
AssignedTo|dri-devel@lists.freedesktop |mesa-dev@lists.freedesktop.
On 7 September 2012 09:32, Eric Anholt wrote:
> Paul Berry writes:
>
> > Currently, gen{6,7}_blorp_emit_surface_state assumes that the src and
> > dst surfaces are mapped to miplevel 0 and layer 0 (thus no surface
> > offset is required). This is a bug, since the user might try to blit
> > to a
On Sun, Sep 9, 2012 at 1:03 AM, Marek Olšák wrote:
> Based on the patch called "simplify and fix flushing and synchronization"
> by Jerome Glisse.
>
> Rebased, removed unneded code, simplified more and cleaned up.
>
> Also, SH_ACTION_ENA is not set when changing shaders (hw doesn't seem
> to need
On Thu, Sep 06, 2012 at 08:37:35AM +0300, Oliver McFadden wrote:
> On Wed, Sep 05, 2012 at 08:11:55AM -0600, Brian Paul wrote:
> > On 09/05/2012 03:38 AM, Oliver McFadden wrote:
> > > On Tue, Sep 04, 2012 at 12:41:12PM -0600, Brian Paul wrote:
> > >> On 09/04/2012 12:08 PM, Ian Romanick wrote:
> >
On Mon, Sep 10, 2012 at 12:25 PM, Michel Dänzer wrote:
> From: Michel Dänzer
>
> Signed-off-by: Michel Dänzer
For the series:
Reviewed-by: Alex Deucher
> ---
> src/gallium/drivers/radeonsi/si_state.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/gallium/dri
From: Michel Dänzer
* Handle arbitrary border colours.
* Use correct packing format for detecting special border colours.
Fixes piglit tex-border-1 and probably many other tests using border colours.
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/radeonsi_pipe.c |2 +
src/g
From: Michel Dänzer
Signed-off-by: Michel Dänzer
---
src/gallium/drivers/radeonsi/si_state.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/gallium/drivers/radeonsi/si_state.c
b/src/gallium/drivers/radeonsi/si_state.c
index 67880f2..5240036 100644
--- a/src/gallium/
https://bugs.freedesktop.org/show_bug.cgi?id=54736
Bug #: 54736
Summary: Creating a Pbuffer requires a pixmap of same depth.
Classification: Unclassified
Product: Mesa
Version: 8.0
Platform: All
OS/Version: All
Status:
https://bugs.freedesktop.org/show_bug.cgi?id=35244
Andreas Boll changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
On 09/10/2012 10:51 AM, Imre Deak wrote:
On Mon, 2012-09-10 at 10:12 +0300, Ian Romanick wrote:
On 09/10/2012 09:41 AM, Imre Deak wrote:
The following enums used to be extensions but later became part of the
core specification. The _EXT/_ARB versions of these are not present in
in the current X
On 09/10/2012 10:23 AM, Imre Deak wrote:
On Mon, 2012-09-10 at 10:07 +0300, Ian Romanick wrote:
On 09/10/2012 09:41 AM, Imre Deak wrote:
Signed-off-by: Imre Deak
---
include/GL/gl.h |1 +
1 file changed, 1 insertion(+)
diff --git a/include/GL/gl.h b/include/GL/gl.h
index e65e1bc..850
https://bugs.freedesktop.org/show_bug.cgi?id=48694
Michel Dänzer changed:
What|Removed |Added
AssignedTo|mesa-dev@lists.freedesktop. |dri-devel@lists.freedesktop
- Original Message -
> Hi everyone,
>
> I'd like to move the BlitFramebuffer implementation into gallium
> drivers. The pros are:
> - allowing MSAA resource blitting to be accelerated on any hardware
> - allowing stencil blitting to be accelerated on any hardware
> - drivers are more lik
Hi Ian,
I've rebased on your 8.0-staging branch.
You should probably squash the commit
6cabf2532 radeon: fix Base/base typo
into commit
35af2b6fe radeon: set swrast_renderbuffer::ColorType field when
mapping renderbuffers
to make bisecting easier.
Andreas.
The following changes since co
On Fre, 2012-09-07 at 12:09 -0400, Tom Stellard wrote:
> @@ -128,6 +129,18 @@ static void si_pipe_shader_ps(struct pipe_context *ctx,
> struct si_pipe_shader *s
> have_perspective = TRUE;
> if (shader->shader.input[i].centroid)
> have_cent
On Mon, 2012-09-10 at 10:12 +0300, Ian Romanick wrote:
> On 09/10/2012 09:41 AM, Imre Deak wrote:
> > The following enums used to be extensions but later became part of the
> > core specification. The _EXT/_ARB versions of these are not present in
> > in the current XML spec files, only defined in
On 09/08/2012 12:02 AM, Eric Anholt wrote:
Ian Romanick writes:
From: Ian Romanick
NOTE: This is a candidate for the 9.0 branch
GL_ARB_shader_objects and friends are marked as GL not GLL in
extensions.c -- should their functions still be exposed if we're
exposing the extensions?
Oops. G
On Mon, 2012-09-10 at 10:10 +0300, Ian Romanick wrote:
> On 09/10/2012 09:41 AM, Imre Deak wrote:
> > Needed by the next patch.
> >
> > Signed-off-by: Imre Deak
> > ---
> > src/mesa/main/context.c |2 ++
> > src/mesa/main/mtypes.h |2 ++
> > src/mesa/main/version.c |3 +++
> > 3
On Mon, 2012-09-10 at 10:07 +0300, Ian Romanick wrote:
> On 09/10/2012 09:41 AM, Imre Deak wrote:
> > Signed-off-by: Imre Deak
> > ---
> > include/GL/gl.h |1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/include/GL/gl.h b/include/GL/gl.h
> > index e65e1bc..850fe4b 100644
> > --
On 09/07/2012 11:51 PM, Eric Anholt wrote:
Ian Romanick writes:
From: Ian Romanick
NOTE: This is a candidate for the 9.0 branch
Signed-off-by: Ian Romanick
+ if (ctx->API != API_OPENGLES2) {
+ SET_VertexAttrib1sARB(dest, loopback_VertexAttrib1sARB);
+ SET_VertexAttrib1dARB(d
On 09/08/2012 12:47 AM, Andreas Boll wrote:
Hi list,
Actually I wanted to wait for my fdo account and then push a branch at
people.fdo with
the candidates for 8.0. But in the meantime I'm sending you an update
with some issues to solve.
I have a bunch of this on my 8.0-staging branch. You sho
On 09/10/2012 09:41 AM, Imre Deak wrote:
The following enums used to be extensions but later became part of the
core specification. The _EXT/_ARB versions of these are not present in
in the current XML spec files, only defined in GL/glext.h
Later we'll need to look up these in a python script us
On 09/10/2012 09:41 AM, Imre Deak wrote:
Needed by the next patch.
Signed-off-by: Imre Deak
---
src/mesa/main/context.c |2 ++
src/mesa/main/mtypes.h |2 ++
src/mesa/main/version.c |3 +++
3 files changed, 7 insertions(+)
diff --git a/src/mesa/main/context.c b/src/mesa/main/c
On 09/10/2012 09:41 AM, Imre Deak wrote:
Signed-off-by: Imre Deak
---
include/GL/gl.h |1 +
1 file changed, 1 insertion(+)
diff --git a/include/GL/gl.h b/include/GL/gl.h
index e65e1bc..850fe4b 100644
--- a/include/GL/gl.h
+++ b/include/GL/gl.h
@@ -276,6 +276,7 @@ typedef double
55 matches
Mail list logo