Re: [Mesa-dev] [PATCH] mesa: Do something sensible when on-line compression is requested but not possible

2012-08-24 Thread Kenneth Graunke
On 08/24/2012 08:23 PM, Ian Romanick wrote: > From: Ian Romanick > > It is possible to force S3TC extensions to be enabled. This is > generally done to support applications that will only supply > pre-compressed textures. This accounts for the vast majority of > applications. > > However, ther

[Mesa-dev] [PATCH] mesa: Do something sensible when on-line compression is requested but not possible

2012-08-24 Thread Ian Romanick
From: Ian Romanick It is possible to force S3TC extensions to be enabled. This is generally done to support applications that will only supply pre-compressed textures. This accounts for the vast majority of applications. However, there is still the possibility of an application asking for on-l

[Mesa-dev] [PATCH] i965: Allow creation of OpenGL 3.1 contexts

2012-08-24 Thread Ian Romanick
From: Ian Romanick v2: Fix API_OPENGL_CORE handling when TEXTURE_FLOAT_ENABLED is not defined. Based on review feedback from Eric Anholt. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_context.c | 19 +++ 1 files changed, 19 insertions(+), 0 deletions(-) diff

[Mesa-dev] [PATCH] mesa/es: Validate blend function enums in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
From: Ian Romanick v2: Add proper core-profile filtering. v3: Allow GL_SRC_ALPHA_SATURATE as a destination factor in GLES3. Based on review feedback from Eric Anholt. Signed-off-by: Ian Romanick --- src/mesa/main/APIspec.xml | 111 - src/mesa/main

[Mesa-dev] [PATCH] mesa/es: Validate glGetVertexAttribf pname in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
From: Ian Romanick v2: Add proper core-profile and GLES3 filtering. v3: Allow glGetVertexAttribfv(0, GL_CURRENT_VERTEX_ATTRIB_ARB, param) in OpenGL 3.1, just like OpenGL ES 2.0. Signed-off-by: Ian Romanick --- src/mesa/main/APIspec.xml | 16 src/mesa/main/varray.c| 15

Re: [Mesa-dev] [PATCH 02/20] mesa/es: Validate blend function enums in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
On 08/24/2012 03:07 PM, Eric Anholt wrote: Ian Romanick writes: case GL_SRC_ALPHA_SATURATE: case GL_SRC1_COLOR: case GL_SRC1_ALPHA: case GL_ONE_MINUS_SRC1_COLOR: case GL_ONE_MINUS_SRC1_ALPHA: - return ctx->Extensions.ARB_blend_func_extended; + return _mesa_is_

Re: [Mesa-dev] i965 SamplerUnits rework

2012-08-24 Thread Kenneth Graunke
On 08/24/2012 10:07 AM, Eric Anholt wrote: > Kenneth Graunke writes: > >> Greetings! >> >> This series reworks how i965 deals with sampler indirections, changing it >> to use linker-assigned sampler variable IDs in SEND instructions rather >> than baking in the ID of the texture unit they happen

[Mesa-dev] [PATCH 5/5] mesa/es: Validate glRenderbufferStorage internalFormat in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
From: Ian Romanick v2: Add proper core-profile and GLES3 filtering. v3: Allow GL_RGB10_A2UI in GLES3 based on review feedback from Eric Anholt. Signed-off-by: Ian Romanick --- src/mesa/main/APIspec.xml | 22 - src/mesa/main/fbobject.c | 196 ++--

[Mesa-dev] [PATCH 4/5] mesa/es: Validate glGetRenderbufferParameter pname in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
From: Ian Romanick v2: Add proper core-profile and GLES3 filtering. Signed-off-by: Ian Romanick Reviewed-by: Eric Anholt --- src/mesa/main/APIspec.xml | 28 src/mesa/main/fbobject.c |3 ++- 2 files changed, 2 insertions(+), 29 deletions(-) diff --git a/src

[Mesa-dev] [PATCH 3/5] mesa/es: Validate glGetFramebufferAttachmentParameter pname in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
From: Ian Romanick v2: Add proper core-profile, GLES1, and GLES3 filtering. v3: Fix the GL_FRAMEBUFFER_ATTACHMENT_OBJECT_NAME query when the attachment type is GL_NONE on GLES3. Other cleanups. Based on review feedback from Eric Anholt. Signed-off-by: Ian Romanick --- src/mesa/main/APIspec.

[Mesa-dev] [PATCH 1/5] mesa/es: Validate glFramebufferTexture2D textarget in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
From: Ian Romanick v2: Add proper core-profile and GLES3 filtering. v3: Change !_mesa_is_desktop_gl tests to _mesa_is_gles test. The test around GL_TEXTURE_2D_ARRAY got some other changes because that enum is also available with GLES3 (which uses API_OPENGLES2). Based on review feedback from E

[Mesa-dev] [PATCH 2/5] mesa/es: Validate glGenerateMipmap target in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
From: Ian Romanick v2: Add proper core-profile and GLES3 filtering. v3: Fix a typo in GL_TEXTURE_2D_ARRAY checking. v4: Change !_mesa_is_desktop_gl tests to _mesa_is_gles test. The test around GL_TEXTURE_2D_ARRAY got some other changes because that enum is also available with GLES3 (which uses

Re: [Mesa-dev] i965 SamplerUnits rework

2012-08-24 Thread Kenneth Graunke
On 08/24/2012 10:21 AM, Ian Romanick wrote: > Patches 1 through 6 are > > Reviewed-by: Ian Romanick > > I probably won't have a chance to get through the rest, so don't wait on > me. Thanks for the review, Ian. Do you (or anyone else) know if other drivers besides i915 still need the ProgramSt

Re: [Mesa-dev] [PATCH 3/5] mesa/es: Validate glGetFramebufferAttachmentParameter pname in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
On 08/24/2012 02:21 PM, Eric Anholt wrote: Ian Romanick writes: diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c index 77e9910..1d2047f 100644 --- a/src/mesa/main/fbobject.c +++ b/src/mesa/main/fbobject.c @@ -2366,8 +2366,7 @@ _mesa_GetFramebufferAttachmentParameterivEXT(GLenum

Re: [Mesa-dev] [PATCH 5/5] mesa/es: Validate glRenderbufferStorage internalFormat in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
On 08/24/2012 02:46 PM, Eric Anholt wrote: Ian Romanick writes: case GL_RED: case GL_R8: + return ctx->API != API_OPENGLES && ctx->Extensions.ARB_texture_rg + ? GL_RED : 0; R8 should have the gles3 support case here. case GL_R16: - return ctx->Extensions.ARB

Re: [Mesa-dev] Shrinking mesa binaries.

2012-08-24 Thread Matt Turner
On Fri, Aug 24, 2012 at 7:03 PM, Kenneth Graunke wrote: > We removed --enable-shared-dricore because it's now non-optional---you get > it all the time. Unfortunately, in our recent automake rework, it sounds > like we lost some of the visibility flags, which probably explains the huge > binaries

Re: [Mesa-dev] Shrinking mesa binaries.

2012-08-24 Thread Kenneth Graunke
On 08/24/2012 11:45 AM, nerdopolis wrote: Hi. I hope this is the correct place for this. I make a Wayland live cd, and in order for Wayland to work, I need to build mesa with Wayland support. I get Mesa to build just fine it's just that I notice that the binaries in /egl /dri and /gbm are MU

Re: [Mesa-dev] [PATCH 06/20] mesa/es: Validate glGetVertexAttribf pname in Mesa code rather than the ES wrapper

2012-08-24 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > v2: Add proper core-profile and GLES3 filtering. GL3.1 appears to drop the index == 0 error case in get_current_attrib. Other than that, I've reached this point of reviewing this series. Not sure how much farther I'll make it tonight. There's a h

[Mesa-dev] [Bug 47248] autogen missing dependency on flex and bison, causes infinite loop in glsl build

2012-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47248 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 33447] Code uses _GNU_SOURCE to determine locale facilities are available

2012-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=33447 --- Comment #4 from Matt Turner 2012-08-24 23:33:35 UTC --- I pushed a patch that stops detecting dlopen presence based on _GNU_SOURCE, but more _GNU_SOURCE usage still remains. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?t

[Mesa-dev] [PATCH] egl: fix invalid flag detection for EGL_KHR_create_context

2012-08-24 Thread Matt Turner
We want to check whether there are bits set outside of the valid flags. Fixes piglit test egl-create-context-invalid-flag-gl --- src/egl/main/eglcontext.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/egl/main/eglcontext.c b/src/egl/main/eglcontext.c index 829050d.

Re: [Mesa-dev] [PATCH 3/3] mesa: glGet: fix parameter lookup for apps using multiple APIs

2012-08-24 Thread Imre Deak
On Fri, 2012-08-24 at 11:21 -0700, Eric Anholt wrote: > Imre Deak writes: > > -if (values[table[hash & mask]].pname == d->pname) > > - break; > > -hash += prime_step; > > -j++; > > +if (values[TABLE_IDX(table[hash & mask])].pname == d->pname) > > + break; > > +

Re: [Mesa-dev] [PATCH 02/20] mesa/es: Validate blend function enums in Mesa code rather than the ES wrapper

2012-08-24 Thread Eric Anholt
Ian Romanick writes: > case GL_SRC_ALPHA_SATURATE: > case GL_SRC1_COLOR: > case GL_SRC1_ALPHA: > case GL_ONE_MINUS_SRC1_COLOR: > case GL_ONE_MINUS_SRC1_ALPHA: > - return ctx->Extensions.ARB_blend_func_extended; > + return _mesa_is_desktop_gl(ctx) > + && ctx->E

Re: [Mesa-dev] [PATCH 5/5] i965: Allow creation of OpenGL 3.1 contexts

2012-08-24 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/dri/i965/brw_context.c | 20 > 1 files changed, 20 insertions(+), 0 deletions(-) > > diff --git a/src/mesa/drivers/dri/i965/brw_context.c > b/src/mesa/drivers/dri/i965/brw

Re: [Mesa-dev] [PATCH 10/18] meta: Don't stray outside the confines of the API specified in the context

2012-08-24 Thread Paul Berry
On 24 August 2012 08:49, Ian Romanick wrote: > From: Paul Berry > > Signed-off-by: Paul Berry > Signed-off-by: Ian Romanick > --- > src/mesa/drivers/common/meta.c | 110 > +++ > src/mesa/main/enable.c |5 +- > 2 files changed, 68 insertions(+),

Re: [Mesa-dev] [PATCH] mesa: add texture target field to ChooseTextureFormat() driver hook

2012-08-24 Thread Eric Anholt
Brian Paul writes: > On 08/24/2012 02:03 PM, Eric Anholt wrote: >> Brian Paul writes: >> >>> This will let us choose the actual hardware format depending on the >>> type of texture. >>> >>> v2: fixup radeon, nouveau, intel and swrast drivers too >> >> Last one I see is: >> >> src/mesa/drivers/x1

Re: [Mesa-dev] [PATCH 5/5] mesa/es: Validate glRenderbufferStorage internalFormat in Mesa code rather than the ES wrapper

2012-08-24 Thread Eric Anholt
Ian Romanick writes: > case GL_RED: > case GL_R8: > + return ctx->API != API_OPENGLES && ctx->Extensions.ARB_texture_rg > + ? GL_RED : 0; R8 should have the gles3 support case here. > case GL_R16: > - return ctx->Extensions.ARB_texture_rg ? GL_RED : 0; > + retu

[Mesa-dev] [Bug 52033] [swrast] swrast/s_texfetch.c:1156: set_fetch_functions: Assertion `texImage->FetchTexel' failed.

2012-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52033 Brian Paul changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: [Mesa-dev] Feature testing

2012-08-24 Thread Ian Romanick
On 08/24/2012 02:12 PM, Brian Paul wrote: On 08/24/2012 09:46 AM, Ian Romanick wrote: @@ -372,6 +380,8 @@ _mesa_set_enable(struct gl_context *ctx, GLenum cap, GLboolean state) case GL_LIGHT5: case GL_LIGHT6: case GL_LIGHT7: + if (ctx->API != API_OPENGL&& ctx->AP

Re: [Mesa-dev] [PATCH 3/5] mesa/es: Validate glGetFramebufferAttachmentParameter pname in Mesa code rather than the ES wrapper

2012-08-24 Thread Eric Anholt
Ian Romanick writes: > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c > index 77e9910..1d2047f 100644 > --- a/src/mesa/main/fbobject.c > +++ b/src/mesa/main/fbobject.c > @@ -2366,8 +2366,7 @@ _mesa_GetFramebufferAttachmentParameterivEXT(GLenum > target, GLenum attachment, >

[Mesa-dev] Feature testing

2012-08-24 Thread Brian Paul
On 08/24/2012 09:46 AM, Ian Romanick wrote: @@ -372,6 +380,8 @@ _mesa_set_enable(struct gl_context *ctx, GLenum cap, GLboolean state) case GL_LIGHT5: case GL_LIGHT6: case GL_LIGHT7: + if (ctx->API != API_OPENGL&& ctx->API != API_OPENGLES) +goto inval

Re: [Mesa-dev] [PATCH 3/4] mesa/es: Validate glMapBuffer access in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
On 08/24/2012 01:32 PM, Eric Anholt wrote: Ian Romanick writes: diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index fb30d1a..6ad0787 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @@ -1039,7 +1039,7 @@ _mesa_BufferDataARB(GLenum target, GLsizeiptr

Re: [Mesa-dev] [PATCH 2/5] mesa/es: Validate glGenerateMipmap target in Mesa code rather than the ES wrapper

2012-08-24 Thread Eric Anholt
Ian Romanick writes: > diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c > index e6cfbc9..77e9910 100644 > --- a/src/mesa/main/fbobject.c > +++ b/src/mesa/main/fbobject.c > @@ -2527,16 +2527,23 @@ _mesa_GenerateMipmapEXT(GLenum target) > > switch (target) { > case GL_TEXTU

Re: [Mesa-dev] r300g broken

2012-08-24 Thread Brian Paul
On 08/24/2012 03:14 PM, son_of_the_osi...@interia.pl wrote: Hello ,r300g driver in current git master was compiled fine, also I cannot see anything disturbing in logs.Unfortunatelly when I try to run any opengl app it crashed (segfault). You should file a bug for this. And try these and put th

Re: [Mesa-dev] [PATCH 4/4] mesa/es: Validate glGetBufferParameteriv pname in Mesa code rather than the ES wrapper

2012-08-24 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > v2: Add proper core-profile and GLES3 filtering. > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c > index 6ad0787..f8938a5 100644 > --- a/src/mesa/main/bufferobj.c > +++ b/src/mesa/main/bufferobj.c > @@ -1142,7 +1142,7 @@ _mesa_M

[Mesa-dev] Shrining mesa binaries.

2012-08-24 Thread nerdopolis
Hi. I hope this is the correct place for this. I make a Wayland live cd, and in order for Wayland to work, I need to build mesa with Wayland support. I get Mesa to build just fine it's just that I notice that the binaries in /egl /dri and /gbm are MUCH larger then the ones provided by the dist

[Mesa-dev] r300g broken

2012-08-24 Thread son_of_the_osiris
Hello ,r300g driver in current git master was compiled fine, also I cannot see anything disturbing in logs.Unfortunatelly when I try to run any opengl app it crashed (segfault). ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.free

Re: [Mesa-dev] [PATCH 3/4] mesa/es: Validate glMapBuffer access in Mesa code rather than the ES wrapper

2012-08-24 Thread Eric Anholt
Ian Romanick writes: > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c > index fb30d1a..6ad0787 100644 > --- a/src/mesa/main/bufferobj.c > +++ b/src/mesa/main/bufferobj.c > @@ -1039,7 +1039,7 @@ _mesa_BufferDataARB(GLenum target, GLsizeiptrARB size, > case GL_STATIC_COPY

Re: [Mesa-dev] [PATCH 04/18] mesa: Expose texture buffer objects when the context is GL 3.1 core.

2012-08-24 Thread Eric Anholt
Ian Romanick writes: > From: Eric Anholt > > v2: Use API_OPENGL_CORE. > > v3: Only require desktop GL. If a driver can't support TexBOs in a non-core > context, it should not enable them. From the v3 comment, it sounds like you intend that i965 should not set GL_ARB_texture_buffer_object, sinc

Re: [Mesa-dev] [PATCH] mesa: add texture target field to ChooseTextureFormat() driver hook

2012-08-24 Thread Brian Paul
On 08/24/2012 02:03 PM, Eric Anholt wrote: Brian Paul writes: This will let us choose the actual hardware format depending on the type of texture. v2: fixup radeon, nouveau, intel and swrast drivers too Last one I see is: src/mesa/drivers/x11/xm_dd.c: driver->ChooseTextureFormat = choose

Re: [Mesa-dev] [PATCH] mesa: add texture target field to ChooseTextureFormat() driver hook

2012-08-24 Thread Eric Anholt
Brian Paul writes: > This will let us choose the actual hardware format depending on the > type of texture. > > v2: fixup radeon, nouveau, intel and swrast drivers too Last one I see is: src/mesa/drivers/x11/xm_dd.c: driver->ChooseTextureFormat = choose_tex_format; Other than that, Reviewed

Re: [Mesa-dev] [PATCH 2/2] mesa/es: Enable GL_OES_vertex_array_object

2012-08-24 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > Functionally the same as GL_ARB_vertex_array_object. > > Signed-off-by: Ian Romanick Even the "genned names are required" bit of the spec was covered by this patch. Looks good! Series is: Reviewed-by: Eric Anholt pgpm13zagWlbg.pgp Description

Re: [Mesa-dev] [PATCH 10/10] mesa: Use a new, more specific hook for shader uniform changes.

2012-08-24 Thread Paul Berry
On 24 August 2012 03:06, Kenneth Graunke wrote: > Gallium drivers and i965 don't require special notification when > sampler uniforms change. They simply see the _NEW_TEXTURE and adjust > their indirection tables. These drivers don't want ProgramStringNotify: > it simply causes pointless recomp

Re: [Mesa-dev] [PATCH 09/10] i965: Use linker-assigned sampler IDs in instruction encoding.

2012-08-24 Thread Paul Berry
On 24 August 2012 03:06, Kenneth Graunke wrote: > When assigning uniform locations, the linker assigns each sampler > uniform a sequential numerical ID. gl_shader_program::SamplerUnits maps > these sampler variable IDs to the actual texture units they reference > (specified via glUniform1i). > >

Re: [Mesa-dev] [PATCH 08/10] i965: Add a "sampler state index" parameter to update_sampler_state().

2012-08-24 Thread Paul Berry
On 24 August 2012 03:06, Kenneth Graunke wrote: > This represents the index into the sampler state table or sampler > default color table (the two are identical). > > Right now, this is still the texture unit, but that will change shortly. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/dri

[Mesa-dev] [PATCH] mesa: add texture target field to ChooseTextureFormat() driver hook

2012-08-24 Thread Brian Paul
This will let us choose the actual hardware format depending on the type of texture. v2: fixup radeon, nouveau, intel and swrast drivers too --- src/mesa/drivers/dri/intel/intel_fbo.c |3 ++- src/mesa/drivers/dri/nouveau/nouveau_texture.c |3 ++- src/mesa/drivers/dri/radeon/radeon

Re: [Mesa-dev] [PATCH 07/10] i965: Un-hardcode WM binding table from update_texture_surface.

2012-08-24 Thread Paul Berry
On 24 August 2012 03:06, Kenneth Graunke wrote: > Currently, we mirror the VS and WM binding tables' texture entries. > That may not continue to be true, so in preparation, pass in the binding > table and surface index as arguments. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dr

Re: [Mesa-dev] [PATCH 05/10] i965/fs: Rename "sampler" to "texunit" in texturing code.

2012-08-24 Thread Paul Berry
On 24 August 2012 03:05, Kenneth Graunke wrote: > The number we're passing around is actually the ID of the texture unit, > as opposed to the numerical value our of sampler uniforms. Calling it > "texunit" clarifies this slightly. > > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri

Re: [Mesa-dev] [PATCH 03/10] i965: Set SWIZZLE_NOOP for unused texture units in the program keys.

2012-08-24 Thread Paul Berry
On 24 August 2012 03:05, Kenneth Graunke wrote: > Previously, we left the swizzle key field as zero for unused texture > units. The precompile sets all of them to SWIZZLE_NOOP, which meant > that we mismatched almost every time. > > Since either works equally well, change it to SWIZZLE_NOOP to m

Re: [Mesa-dev] [PATCH 01/10] i965: Fix brw_link_shader to return false rather than NULL.

2012-08-24 Thread Paul Berry
On 24 August 2012 03:05, Kenneth Graunke wrote: > Fixes brw_shader.cpp:101:9: warning: converting to non-pointer type > 'GLboolean {aka unsigned char}' from NULL [-Wconversion-null] > > Signed-off-by: Kenneth Graunke > Oh, thank you. I keep getting this warning when I'm in the middle of other

Re: [Mesa-dev] [PATCH 1/3] mesa: Require that drivers supporting point sprites support point parameters

2012-08-24 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > All drivers in Mesa do. This allows a lot of extension checking code to be > gutted from the function. Series is: Reviewed-by: Eric Anholt pgp4JcfcKfALR.pgp Description: PGP signature ___ mesa-dev mail

Re: [Mesa-dev] [PATCH 3/3] mesa: glGet: fix parameter lookup for apps using multiple APIs

2012-08-24 Thread Eric Anholt
Imre Deak writes: > - if (values[table[hash & mask]].pname == d->pname) > - break; > - hash += prime_step; > - j++; > +if (values[TABLE_IDX(table[hash & mask])].pname == d->pname) > + break; > +hash += prime_step; > +j++; indentation change

[Mesa-dev] [Bug 53962] [build error] ln: accessing `.libs/libGL.so.1.6.0': No such file or directory

2012-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=53962 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 50604] [compile error] ../../../../../src/mesa/libdricore/../main/api_arrayelt.c:45:27: fatal error: main/dispatch.h: No such file or directory

2012-08-24 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50604 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

Re: [Mesa-dev] [PATCH 3/4] mesa: add generic compressed -> uncompressed format helper

2012-08-24 Thread Anuj Phogat
On Fri, Aug 24, 2012 at 7:53 AM, Brian Paul wrote: > _mesa_generic_compressed_format_to_uncompressed_format() probably wins the > prize for longest function name in Mesa. > --- > src/mesa/main/glformats.c | 39 +++ > src/mesa/main/glformats.h |3 +++ > 2

Re: [Mesa-dev] [PATCH 4/4] st/mesa: don't do (generic) compression of 1D or 1D_ARRAY textures

2012-08-24 Thread Anuj Phogat
On Fri, Aug 24, 2012 at 7:53 AM, Brian Paul wrote: > As with the previous commit for core Mesa. > --- > src/mesa/state_tracker/st_format.c | 12 +++- > 1 files changed, 11 insertions(+), 1 deletions(-) > > diff --git a/src/mesa/state_tracker/st_format.c > b/src/mesa/state_tracker/st_fo

Re: [Mesa-dev] [PATCH 2/4] mesa: don't try (generic) compression of 1D and 1D_ARRAY textures

2012-08-24 Thread Anuj Phogat
On Fri, Aug 24, 2012 at 7:53 AM, Brian Paul wrote: > See comments in the code for details. > > Note: we only need to special-case the generic compressed formats since > specific texture formats are error-checked earlier to see if the compression > format is compatible with the texture type. > ---

Re: [Mesa-dev] i965 SamplerUnits rework

2012-08-24 Thread Ian Romanick
On 08/24/2012 03:05 AM, Kenneth Graunke wrote: Greetings! This series reworks how i965 deals with sampler indirections, changing it to use linker-assigned sampler variable IDs in SEND instructions rather than baking in the ID of the texture unit they happen to be bound to. Instead, it now encod

Re: [Mesa-dev] [PATCH 1/4] mesa: add texture target field to ChooseTextureFormat() driver hook

2012-08-24 Thread Brian Paul
On 08/24/2012 10:22 AM, Eric Anholt wrote: Brian Paul writes: This will let us choose the actual hardware format depending on the type of texture. Looks like radeon/nouveau/x11 were missed in this update? And a call to the function in the intel code. I'll post a new patch later. -Brian

Re: [Mesa-dev] i965 SamplerUnits rework

2012-08-24 Thread Eric Anholt
Kenneth Graunke writes: > Greetings! > > This series reworks how i965 deals with sampler indirections, changing it > to use linker-assigned sampler variable IDs in SEND instructions rather > than baking in the ID of the texture unit they happen to be bound to. > > Instead, it now encodes that ma

Re: [Mesa-dev] [PATCH 1/4] radeonsi: Drop extraneous semicolons from pm4 state macro definitions.

2012-08-24 Thread Alex Deucher
On Fri, Aug 24, 2012 at 8:52 AM, Michel Dänzer wrote: > From: Michel Dänzer > > Could cause build failures if trying to use the macros in certain constructs. > > Signed-off-by: Michel Dänzer For the series: Reviewed-by: Alex Deucher > --- > src/gallium/drivers/radeonsi/si_state.h |6 +++

Re: [Mesa-dev] [PATCH 1/4] mesa: add texture target field to ChooseTextureFormat() driver hook

2012-08-24 Thread Eric Anholt
Brian Paul writes: > This will let us choose the actual hardware format depending on the > type of texture. Looks like radeon/nouveau/x11 were missed in this update? pgpwX8ePbW40y.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@list

Re: [Mesa-dev] [PATCH] radeonsi: Don't write to the PA_SC_RASTER_CONFIG register.

2012-08-24 Thread Alex Deucher
On Fri, Aug 24, 2012 at 11:37 AM, Michel Dänzer wrote: > From: Michel Dänzer > > It should be initialized by the kernel as necessary. Does this patch work ok after powering off the system to make sure there is no state in the register from a previous run? If all is well, add my reviewed-by. A

Re: [Mesa-dev] Mesa (master): i965/msaa: Add sample-alpha-to-coverage support for multiple render targets

2012-08-24 Thread Eric Anholt
Anuj Phogat writes: > Module: Mesa > Branch: master > Commit: e592f7df0361eb8b5c75944f0151c4e6b3f839dd > URL: > http://cgit.freedesktop.org/mesa/mesa/commit/?id=e592f7df0361eb8b5c75944f0151c4e6b3f839dd > > Author: Anuj Phogat > Date: Wed Aug 1 16:32:06 2012 -0700 > > i965/msaa: Add sample

Re: [Mesa-dev] [PATCH 1/4] radeonsi: Drop extraneous semicolons from pm4 state macro definitions.

2012-08-24 Thread Christian König
On 24.08.2012 14:52, Michel Dänzer wrote: From: Michel Dänzer Could cause build failures if trying to use the macros in certain constructs. Signed-off-by: Michel Dänzer For this series: Reviewed-by: Christian König --- src/gallium/drivers/radeonsi/si_state.h |6 +++--- 1 file chan

Re: [Mesa-dev] [PATCH] radeonsi: Don't write to the PA_SC_RASTER_CONFIG register.

2012-08-24 Thread Christian König
On 24.08.2012 17:37, Michel Dänzer wrote: From: Michel Dänzer It should be initialized by the kernel as necessary. Signed-off-by: Michel Dänzer Reviewed-by: Christian König --- src/gallium/drivers/radeonsi/si_state.c |1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/driv

Re: [Mesa-dev] [PATCH] mesa: Filter glGetProgramiv pnames based on available extensions

2012-08-24 Thread Ian Romanick
On 08/24/2012 08:51 AM, Brian Paul wrote: On 08/24/2012 09:42 AM, Ian Romanick wrote: From: Ian Romanick Previously you could always glGetProgramiv one of the transform feedback or geometry shader enums even if the extension wasn't supported. In addtion, this reverts part of bda6ad27. I think

[Mesa-dev] [PATCH 5/5] i965: Allow creation of OpenGL 3.1 contexts

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_context.c | 20 1 files changed, 20 insertions(+), 0 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_context.c b/src/mesa/drivers/dri/i965/brw_context.c index 2945b3c..2e2ca20 10064

[Mesa-dev] [PATCH 4/5] i965: Advertise GLSL 1.40 and TexBOs in core contexts

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/intel/intel_extensions.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_extensions.c b/src/mesa/drivers/dri/intel/intel_extensions.c index c1abcff..047d5b

[Mesa-dev] [PATCH 3/5] intel: Clean up bits of cruft in intelCreateContext

2012-08-24 Thread Ian Romanick
From: Ian Romanick This and the previous three commits should probably be squashed together... Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/intel/intel_screen.c | 51 ++-- 1 files changed, 11 insertions(+), 40 deletions(-) diff --git a/src/mesa/drivers/dri/in

[Mesa-dev] [PATCH 2/5] i965: Set context flags

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/i965/brw_context.c |8 src/mesa/drivers/dri/i965/brw_context.h |1 + src/mesa/drivers/dri/intel/intel_screen.c |5 +++-- 3 files changed, 12 insertions(+), 2 deletions(-) diff --git a/src/mesa/driv

[Mesa-dev] [PATCH 1/5] mesa/dri: Allow creation of forward-compatible contexts

2012-08-24 Thread Ian Romanick
From: Ian Romanick This is done by changing the API to API_OPENGL_CORE. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/common/dri_util.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common

[Mesa-dev] [PATCH 2/2] mesa/es: Enable GL_OES_vertex_array_object

2012-08-24 Thread Ian Romanick
From: Ian Romanick Functionally the same as GL_ARB_vertex_array_object. Signed-off-by: Ian Romanick --- src/mapi/glapi/gen/es_EXT.xml | 26 ++ src/mapi/glapi/gen/gles_api.py |5 + src/mesa/main/api_exec.c | 16 ++-- src/mesa/main/extension

[Mesa-dev] [PATCH 1/2] mesa: Enable GL_{ARB, APPLE}_vertex_array_object in all drivers

2012-08-24 Thread Ian Romanick
From: Ian Romanick This is a purely software extension. The drivers don't need to do any work to support it. Signed-off-by: Ian Romanick --- src/mesa/drivers/dri/intel/intel_extensions.c |2 -- src/mesa/drivers/dri/r200/r200_context.c |2 -- src/mesa/main/extensions.c

Re: [Mesa-dev] [PATCH] mesa: Filter glGetProgramiv pnames based on available extensions

2012-08-24 Thread Brian Paul
On 08/24/2012 09:42 AM, Ian Romanick wrote: From: Ian Romanick Previously you could always glGetProgramiv one of the transform feedback or geometry shader enums even if the extension wasn't supported. In addtion, this reverts part of bda6ad27. I think the hunks involving GL_PROGRAM_BINARY_LENG

[Mesa-dev] [PATCH 18/18] meta: Don't use deprecated keyword in 1.30 shader

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 2332825..268be24 100644 --- a/src/mesa/drivers/common/meta.c +++ b/sr

[Mesa-dev] [PATCH 16/18] mesa: Disallow more deprecated functions in core context

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/api_exec.c |2 +- src/mesa/main/vtxfmt.c |3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/api_exec.c b/src/mesa/main/api_exec.c index af73074..167a942 100644 --- a/src/mesa/main/api_ex

[Mesa-dev] [PATCH 17/18] mesa: Disallow alpha, luminance, and LA textures in core context

2012-08-24 Thread Ian Romanick
From: Ian Romanick Also disallow the 1, 2, 3, and 4 formats. Signed-off-by: Ian Romanick --- src/mesa/main/teximage.c | 10 ++ 1 files changed, 6 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/teximage.c b/src/mesa/main/teximage.c index 2595717..2be96f5 100644 --- a/src/me

[Mesa-dev] [PATCH 15/18] mesa: Require names from Gen in core context

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/bufferobj.c |4 src/mesa/main/texobj.c|5 + 2 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index f8938a5..728cc51 100644 --- a/src/mesa/mai

[Mesa-dev] [PATCH 14/18] mesa: Allow NULL vertex pointer without a VBO

2012-08-24 Thread Ian Romanick
From: Ian Romanick There is text in the OpenGL 3.x specs to explicitly allow this case. Weird. Signed-off-by: Ian Romanick --- src/mesa/main/varray.c | 17 + 1 files changed, 13 insertions(+), 4 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index

[Mesa-dev] [PATCH 13/18] mesa: Disallow VertexAttribPointer without a VAO in a core context

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/varray.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/varray.c b/src/mesa/main/varray.c index dc85a82..30557b8 100644 --- a/src/mesa/main/varray.c +++ b/src/mesa/main/varr

[Mesa-dev] [PATCH 12/18] mesa: Disallow wide lines in forward compatible context

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/lines.c | 17 + 1 files changed, 17 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/lines.c b/src/mesa/main/lines.c index 79bf567..e400b39 100644 --- a/src/mesa/main/lines.c +++ b/src/mesa/main/lines.c

[Mesa-dev] [PATCH 10/18] meta: Don't stray outside the confines of the API specified in the context

2012-08-24 Thread Ian Romanick
From: Paul Berry Signed-off-by: Paul Berry Signed-off-by: Ian Romanick --- src/mesa/drivers/common/meta.c | 110 +++ src/mesa/main/enable.c |5 +- 2 files changed, 68 insertions(+), 47 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/

[Mesa-dev] [PATCH 11/18] mesa: Only FRONT_AND_BACK is allowed for PolygonMode in core context

2012-08-24 Thread Ian Romanick
From: Ian Romanick Page 407 (page 423 of the PDF) of the OpenGL 3.0 spec says (in the list of deprecated functionality): "Separate polygon draw mode - PolygonMode face values of FRONT and BACK; polygons are always drawn in the same mode, no matter which face is being rasterized." Al

[Mesa-dev] [PATCH 04/18] mesa: Expose texture buffer objects when the context is GL 3.1 core.

2012-08-24 Thread Ian Romanick
From: Eric Anholt v2: Use API_OPENGL_CORE. v3: Only require desktop GL. If a driver can't support TexBOs in a non-core context, it should not enable them. Signed-off-by: Eric Anholt Signed-off-by: Ian Romanick Reviewed-by: Kenneth Graunke --- src/mesa/main/get.c | 16 +++

[Mesa-dev] [PATCH 09/18] mesa: Don't allow display lists or evaluators in core context

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/context.c |2 +- src/mesa/main/vtxfmt.c |8 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/mesa/main/context.c b/src/mesa/main/context.c index 0a52a1a..feddbaa 100644 --- a/src/mesa/main/conte

[Mesa-dev] [PATCH 08/18] mesa: Don't allow GL_EXTENSIONS query in core context

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/getstring.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/src/mesa/main/getstring.c b/src/mesa/main/getstring.c index 748a943..9c9ade3 100644 --- a/src/mesa/main/getstring.c +++ b/src/mesa/main/getstr

[Mesa-dev] [PATCH 07/18] mesa: Non-sprite points are deprecated

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/points.c | 14 +- 1 files changed, 13 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/points.c b/src/mesa/main/points.c index d66af2f..538f3cf 100644 --- a/src/mesa/main/points.c +++ b/src/mesa/main/points.

[Mesa-dev] [PATCH 06/18] mesa: Fix VAO deletion on GL 3.1 core.

2012-08-24 Thread Ian Romanick
From: Eric Anholt We were calling through a dispatch table entry that was NULL, since the apple variant is only on legacy desktop. Just call the function we mean instead of indirecting through the dispatch. --- src/mesa/main/arrayobj.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-)

[Mesa-dev] [PATCH 05/18] mesa: Enable a bunch of missing getters on 3.1 core.

2012-08-24 Thread Ian Romanick
From: Eric Anholt NOTE: maybe I enabled too many? --- src/mesa/main/get.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index cd2f683..b780c1f 100644 --- a/src/mesa/main/get.c +++ b/src/mesa/main/get.c @@ -707,7 +707,7 @@ stat

[Mesa-dev] [PATCH 03/18] mesa: Allow PACK / UNPACK queries for ES2

2012-08-24 Thread Ian Romanick
From: Ian Romanick These are part of the GL_EXT_unpack_subimage extension and ES 3.0. Signed-off-by: Ian Romanick --- src/mesa/main/get.c | 18 +- 1 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/mesa/main/get.c b/src/mesa/main/get.c index 332dfaf..3f7d223 1

[Mesa-dev] [PATCH 02/18] mesa: Kill ES2 wrapper functions

2012-08-24 Thread Ian Romanick
From: Ian Romanick v2: Fix completely broken condition around ClearColorIiEXT and ClearColorIuiEXT. v3: Add special VertexAttrib handling for ES2. Signed-off-by: Ian Romanick --- src/mesa/Android.gen.mk |8 +- src/mesa/Makefile.am| 15 -- src/mesa/SConscript | 18 -

[Mesa-dev] [PATCH 01/18] mesa: glGetVertexAttribPointerv is part of core profile and ES2

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/api_exec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/mesa/main/api_exec.c b/src/mesa/main/api_exec.c index 6b1499f..356b133 100644 --- a/src/mesa/main/api_exec.c +++ b/src/mesa/main/api_exec.c @

[Mesa-dev] [PATCH 3/3] mesa/es: Validate glPointParameter pname in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
From: Ian Romanick v2: Add proper core-profile filtering. Signed-off-by: Ian Romanick --- src/mesa/main/APIspec.xml | 13 - src/mesa/main/es1_conversion.c | 11 --- src/mesa/main/points.c |2 +- 3 files changed, 1 insertions(+), 25 deletions(-) diff --

[Mesa-dev] [PATCH 1/3] mesa: Require that drivers supporting point sprites support point parameters

2012-08-24 Thread Ian Romanick
From: Ian Romanick All drivers in Mesa do. This allows a lot of extension checking code to be gutted from the function. Signed-off-by: Ian Romanick --- src/mesa/main/points.c | 106 +--- 1 files changed, 46 insertions(+), 60 deletions(-) diff --gi

[Mesa-dev] [PATCH 2/3] mesa: Require OpenGL 2.0 for GL_POINT_SPRITE_COORD_ORIGIN

2012-08-24 Thread Ian Romanick
From: Ian Romanick The comment in the code even says this is the right thing to do. Signed-off-by: Ian Romanick --- src/mesa/main/points.c |9 - 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/points.c b/src/mesa/main/points.c index cb6ac39..eeb1b44 100

[Mesa-dev] [PATCH 20/20] mesa/es: Validate glGetTexEnv parameters in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/APIspec.xml | 82 - src/mesa/main/texenv.c| 10 +++--- 2 files changed, 5 insertions(+), 87 deletions(-) diff --git a/src/mesa/main/APIspec.xml b/src/mesa/main/APIspec.xml index

[Mesa-dev] [PATCH 18/20] mesa/es: Validate glGetTexGen parameters in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/APIspec.xml |8 -- src/mesa/main/es1_conversion.c | 54 +-- src/mesa/main/texgen.c | 19 - src/mesa/main/texgen.h |3 ++ 4 files changed, 22 inse

[Mesa-dev] [PATCH 19/20] mesa/es: Validate glTexEnv parameters in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/APIspec.xml | 149 --- src/mesa/main/es1_conversion.c | 192 +--- src/mesa/main/texenv.c | 31 --- 3 files changed, 43 insertions(+), 329 deletio

[Mesa-dev] [PATCH 17/20] mesa/es: Validate glTexGen parameters in Mesa code rather than the ES wrapper

2012-08-24 Thread Ian Romanick
From: Ian Romanick Signed-off-by: Ian Romanick --- src/mesa/main/APIspec.xml | 13 - src/mesa/main/es1_conversion.c | 110 +--- src/mesa/main/texgen.c | 44 +--- 3 files changed, 39 insertions(+), 128 deletions(-) diff --git

  1   2   >