Re: [Mesa-dev] [PATCH 0/2] i965: Back-port GPU hang workarounds (bug 50271)

2012-08-06 Thread Paul Berry
On 6 August 2012 21:20, Kenneth Graunke wrote: > On 08/05/2012 08:36 AM, Paul Berry wrote: > > Just looking for a quick patch review to make sure I've backported > > these patches to 8.0 correctly (and also confirmation that this > > backport is a good idea). These patches are intended to apply

[Mesa-dev] someone regressed tinderbox

2012-08-06 Thread Dave Airlie
http://tinderbox.x.org/builds/2012-08-06-0020/logs/libGL/#build Making all in glx gmake[4]: Entering directory `/home/tinderbox/mesa/mesa/src/egl/drivers/glx' CC egl_glx.lo In file included from ../../../../src/egl/main/egltypedefs.h:37, from ../../../../src/egl/main/eglconf

Re: [Mesa-dev] [PATCH 0/2] i965: Back-port GPU hang workarounds (bug 50271)

2012-08-06 Thread Kenneth Graunke
On 08/05/2012 08:36 AM, Paul Berry wrote: > Just looking for a quick patch review to make sure I've backported > these patches to 8.0 correctly (and also confirmation that this > backport is a good idea). These patches are intended to apply to the > 8.0 branch. > > The issue is that on Gen6 and G

[Mesa-dev] [PATCH] egl: remove redundant PFNEGLQUERYSTREAMTIMEKHRPROC typedef

2012-08-06 Thread Brian Paul
From: Brian Paul This typedef is present earlier in the header and isn't part of the EGL_KHR_stream_cross_process_fd extension. Looks like a Khronos glitch. --- include/EGL/eglext.h |1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/include/EGL/eglext.h b/include/EGL/eglex

Re: [Mesa-dev] [PATCH 15/15] intel: Advertise multisample DRI2 configs on gen >= 6

2012-08-06 Thread Eric Anholt
Chad Versace writes: > + /* Generate multisample configs. > +* > +* This loop breaks early, and hence is a no-op, on gen < 6. > +* > +* Multisample configs must follow the singlesample configs in order to > +* work around an X server bug present in 1.12. The X server chooses

Re: [Mesa-dev] [PATCH 08/15] intel: Refactor intel_miptree_map/unmap

2012-08-06 Thread Eric Anholt
Chad Versace writes: > Move the body of intel_miptree_map into a new function, > intel_miptree_map_singlesample. Now intel_miptree_map dispatches to the > new function. A future commit adds a multisample variant. > > Ditto for intel_miptree_unmap. > > CC: Paul Berry > CC: Eric Anholt > Signed-o

Re: [Mesa-dev] [PATCH 14/15] intel: Clarify intel_screen_make_configs

2012-08-06 Thread Eric Anholt
Chad Versace writes: > This function felt sloppy, so this patch cleans it up a little bit. > > - Rename `color` to `i`. It is not a color value, only an iterator int. I'm meh on this change. > - Move `depth_bits[0] = 0` into the non-accum loop because that is where > it used. The accum loop l

Re: [Mesa-dev] [PATCH 13/15] dri: Simplify use of driConcatConfigs

2012-08-06 Thread Eric Anholt
Chad Versace writes: > If either argument to driConcatConfigs(a, b) is null or the empty list, > then simply return the other argument as the resultant list. > > All callers were accomplishing that same behavior anyway. And each caller > accopmplished it with the same pattern. So this patch moves

Re: [Mesa-dev] [PATCH 12/15] intel: Refactor creation of DRI2 configs

2012-08-06 Thread Eric Anholt
Chad Versace writes: > DRI2 configs were constructed in intelInitScreen2. That function already > does too much, so move verbatim the code for creating configs to a new > function, intel_screen_make_configs. > > CC: Eric Anholt > Reviewed-by: Paul Berry > Signed-off-by: Chad Versace I haven't

Re: [Mesa-dev] [PATCH 10/15] intel: Support mapping multisample miptrees (v2)

2012-08-06 Thread Eric Anholt
Chad Versace writes: > Add two new functions: intel_miptree_{map,unmap}_multisample, to which > intel_miptree_{map,unmap} dispatch. Only mapping flat, renderbuffer-like > miptrees are supported. > > v2: > - Move the introduction of > intel_mipmap_tree::singlesample_{width0,height0} to t

Re: [Mesa-dev] [PATCH 19/22] i965/vs: Communicate the pull constant block read parameters through src_regs.

2012-08-06 Thread Eric Anholt
Kenneth Graunke writes: > On 07/31/2012 03:01 PM, Eric Anholt wrote: >> Similar to the previous commit for the fragment shader. >> --- >> src/mesa/drivers/dri/i965/brw_vec4.h |3 ++- >> src/mesa/drivers/dri/i965/brw_vec4_emit.cpp| 19 --- >> src/mesa/drivers/d

[Mesa-dev] [PATCH] glsl: Add a lowering pass to turn complicated UBO references to vector loads.

2012-08-06 Thread Eric Anholt
v2: Reduce the impenetrable code in emit_ubo_loads() by 23 lines by keeping the ir_variable as the variable part of the offset from handle_rvalue(), and track the constant offsets from that with a plain old integer value, avoiding a bunch of temporary variables in the array and struct h

Re: [Mesa-dev] [PATCH 17/22] i965: Bind UBOs as surfaces like we do for pull constants.

2012-08-06 Thread Eric Anholt
Kenneth Graunke writes: > On 07/31/2012 03:01 PM, Eric Anholt wrote: >> +const struct brw_tracked_state brw_vs_ubo_surfaces = { >> + .dirty = { >> + .mesa = (_NEW_PROGRAM | >> + _NEW_BUFFER_OBJECT), >> + .brw = (BRW_NEW_BATCH), > > You don't actually need the extra parenthesi

Re: [Mesa-dev] [PATCH 15/22] mesa: Add support for glUniformBlockBinding() in display lists.

2012-08-06 Thread Eric Anholt
Brian Paul writes: > On 07/31/2012 04:01 PM, Eric Anholt wrote: >> Fixes piglit GL_ARB_uniform_buffer_object/dlist. >> --- >> src/mesa/main/dlist.c | 27 +++ >> 1 file changed, 27 insertions(+) >> >> diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c >> index

Re: [Mesa-dev] [PATCH 03/22] glsl: Add a "ubo_load" expression type for fetches from UBOs.

2012-08-06 Thread Eric Anholt
Kenneth Graunke writes: > On 07/31/2012 03:01 PM, Eric Anholt wrote: >> diff --git a/src/glsl/ir.h b/src/glsl/ir.h >> index f019837..2807ba6 100644 >> --- a/src/glsl/ir.h >> +++ b/src/glsl/ir.h >> @@ -1018,9 +1018,18 @@ enum ir_expression_operation { >> ir_binop_pow, >> >> /** >> +*

Re: [Mesa-dev] R600 VDPAU 422 regression since r600g: make sure copying of all texture formats is accelerated

2012-08-06 Thread Marek Olšák
Does the attached patch fix this issue? Marek On Mon, Aug 6, 2012 at 5:40 PM, Andy Furniss wrote: > Kernel is dcn card is rv790 - vdpau csc/scale regressed. > > This only shows with 422 colour so most things work. > > commit 7c371f46958910dd2ca9487c89af1b72bbfdada9 > Author: Marek Olšák > Dat

Re: [Mesa-dev] [PATCH] glx/dri: Initialize reset to __DRI_CTX_RESET_NO_NOTIFICATION.

2012-08-06 Thread Jordan Justen
On Mon, Aug 6, 2012 at 4:49 PM, Kenneth Graunke wrote: > I noticed that we have a bit of inconsistency in how we handle context > defaults. In some cases, we initialize variables with default values in > dri{2,sw}_create_context_attribs. In other cases, we rely on > dri2_convert_glx_attribs to d

Re: [Mesa-dev] [PATCH 11/16] intel: Support mapping multisample miptrees

2012-08-06 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/06/2012 11:35 AM, Eric Anholt wrote: > Chad Versace writes: > >> Add two new functions: intel_miptree_{map,unmap}_multisample, to which >> intel_miptree_{map,unmap} dispatch. Only mapping flat, renderbuffer-like >> miptrees are supported. >

Re: [Mesa-dev] [PATCH 05/16] i965: Add functions up/downsampling on miptrees (v2)

2012-08-06 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/06/2012 11:38 AM, Eric Anholt wrote: > Chad Versace writes: > >> These functions do an up or downsample between mt and >> mt->singlesample_mt. > > >> +static void +intel_miptree_updownsample(struct intel_context *intel, + >> struct intel_mipm

Re: [Mesa-dev] [PATCH 03/16] intel: Add singlesample fields to intel_mipmap_tree

2012-08-06 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/06/2012 11:05 AM, Eric Anholt wrote: > Chad Versace writes: > >> Add the following fields: singlesamle_width0 singlesample_height0 >> singlesample_mt needs_downsample >> >> These will all be used by later commits that implement MSAA for windo

[Mesa-dev] [PATCH 15/15] intel: Advertise multisample DRI2 configs on gen >= 6

2012-08-06 Thread Chad Versace
This turns on window system MSAA. This patch changes the id of many GLX visuals and configs, but that couldn't be prevented. I attempted to preserve the id's of extant configs by appending the multisample configs to the end of the extant ones. But somewhere, perhaps in the X server, the configs ar

[Mesa-dev] [PATCH 02/15] intel: Set num samples for winsys renderbuffers (v3)

2012-08-06 Thread Chad Versace
Add a new param, num_samples, to intel_create_renderbuffer and intel_create_private_renderbuffer. No multisample GL config is yet advertised, so the value of num_samples is currently 0. For server-owned winsys buffers, gl_renderbuffer::NumSamples is not yet used. v2: Quantize num_samples just on

[Mesa-dev] [PATCH 00/16 v3] i965: Enable winsys MSAA on gen >= 6

2012-08-06 Thread Chad Versace
For test results, see the commit message in patch 16. The summary is that piglit, oglconform, and xonotic are all happy. It was nice to play xonotic without seeing ugly, jagged edges. Many of these patches have already been reviewed. I'm not seeking additional review for those, although additional

[Mesa-dev] [PATCH 13/15] dri: Simplify use of driConcatConfigs

2012-08-06 Thread Chad Versace
If either argument to driConcatConfigs(a, b) is null or the empty list, then simply return the other argument as the resultant list. All callers were accomplishing that same behavior anyway. And each caller accopmplished it with the same pattern. So this patch moves that external pattern into the

[Mesa-dev] [PATCH 14/15] intel: Clarify intel_screen_make_configs

2012-08-06 Thread Chad Versace
This function felt sloppy, so this patch cleans it up a little bit. - Rename `color` to `i`. It is not a color value, only an iterator int. - Move `depth_bits[0] = 0` into the non-accum loop because that is where it used. The accum loop later overwrites depth_bits[0]. - Redefine `msaa_samples_ar

[Mesa-dev] [PATCH 12/15] intel: Refactor creation of DRI2 configs

2012-08-06 Thread Chad Versace
DRI2 configs were constructed in intelInitScreen2. That function already does too much, so move verbatim the code for creating configs to a new function, intel_screen_make_configs. CC: Eric Anholt Reviewed-by: Paul Berry Signed-off-by: Chad Versace --- src/mesa/drivers/dri/intel/intel_screen.c

[Mesa-dev] [PATCH 09/15] intel: Refactor use of intel_miptree_map

2012-08-06 Thread Chad Versace
Move the opencoded construction and destruction of intel_miptree_map into new functions, intel_miptree_attach_map and intel_miptree_release_map. This patch prevents code duplication in a future commit that adds support for mapping multisample miptrees. CC: Eric Anholt CC: Paul Berry Signed-off-b

[Mesa-dev] [PATCH 11/15] intel: Downsample on DRI2 flush

2012-08-06 Thread Chad Versace
Reviewed-by: Eric Anholt Reviewed-by: Paul Berry Signed-off-by: Chad Versace --- src/mesa/drivers/dri/intel/intel_screen.c | 31 +++ 1 file changed, 31 insertions(+) diff --git a/src/mesa/drivers/dri/intel/intel_screen.c b/src/mesa/drivers/dri/intel/intel_screen.c

[Mesa-dev] [PATCH 10/15] intel: Support mapping multisample miptrees (v2)

2012-08-06 Thread Chad Versace
Add two new functions: intel_miptree_{map,unmap}_multisample, to which intel_miptree_{map,unmap} dispatch. Only mapping flat, renderbuffer-like miptrees are supported. v2: - Move the introduction of intel_mipmap_tree::singlesample_{width0,height0} to this patch, per Anholt. - R

[Mesa-dev] [PATCH 08/15] intel: Refactor intel_miptree_map/unmap

2012-08-06 Thread Chad Versace
Move the body of intel_miptree_map into a new function, intel_miptree_map_singlesample. Now intel_miptree_map dispatches to the new function. A future commit adds a multisample variant. Ditto for intel_miptree_unmap. CC: Paul Berry CC: Eric Anholt Signed-off-by: Chad Versace --- src/mesa/driv

[Mesa-dev] [PATCH 07/15] i965: Mark needed downsamples for msaa winsys buffers

2012-08-06 Thread Chad Versace
Add function intel_renderbuffer_set_needs_downsample. It is a no-op except on multisample winsys buffers shared with DRI2. Mark the needed downsamples with the new function at two locations: - Immediately after drawing is complete. - After blitting. Reviewed-by: Eric Anholt Reviewed-by:

[Mesa-dev] [PATCH 06/15] intel: Define functions for up/downsampling on miptrees (v3)

2012-08-06 Thread Chad Versace
Flesh out the stub functions intel_miptree_{up,down}sample. v2: - Add an upsample function. - Also up/downsample the stencil miptree. - Assert that the miptree is "flat". v3: - Move direction-dependent code out of shared function, per Anholt. - Move functions from brw_blorp_or

[Mesa-dev] [PATCH 04/15] intel: Allocate miptree for multisample DRI2 buffers (v3)

2012-08-06 Thread Chad Versace
Immediately after obtaining, with DRI2GetBuffersWithFormat, the DRM buffer handle for a DRI2 buffer, we wrap that DRM buffer handle with a region and a miptree. This patch additionally allocates an accompanying multisample miptree if the DRI2 buffer is multisampled. Since we do not yet advertise m

[Mesa-dev] [PATCH 05/15] i965: Add function brw_blorp_blit_miptrees

2012-08-06 Thread Chad Versace
Define a function, brw_blorp_blit_miptrees, that simply wraps brw_blorp_blit_params + brw_blorp_exec with C calling conventions. This enables intel_miptree.c, in a following commit, to perform blits with blorp for the purpose of downsampling multisample miptrees. CC: Eric Anholt CC: Paul Berry S

[Mesa-dev] [PATCH 03/15] intel: Refactor creation of hiz and mcs miptrees

2012-08-06 Thread Chad Versace
Move the logic for creating the ancillary hiz and mcs miptress for winsys and non-texture renderbuffers from intel_alloc_renderbuffer_storage to intel_miptree_create_for_renderbuffer. Let's try to isolate complex miptree logic to intel_mipmap_tree.c. Without this refactor, code duplication would b

[Mesa-dev] [PATCH 01/15] intel: Refactor quantize_num_samples (v1)

2012-08-06 Thread Chad Versace
Rename quantize_num_samples to intel_quantize_num_samples and change the first param from struct intel_context* to struct intel_screen*. The function will later be used by intelCreateBuffer, which is not bound to any context but is bound to a screen. v2: Keep the function in intel_fbo.c, per Anhol

Re: [Mesa-dev] [PATCH] glx/dri: Initialize reset to __DRI_CTX_RESET_NO_NOTIFICATION.

2012-08-06 Thread Kenneth Graunke
I noticed that we have a bit of inconsistency in how we handle context defaults. In some cases, we initialize variables with default values in dri{2,sw}_create_context_attribs. In other cases, we rely on dri2_convert_glx_attribs to do that for us. For example, in dri2_convert_glx_attribs: u

Re: [Mesa-dev] [PATCH mesa] i965: add more Haswell PCI IDs

2012-08-06 Thread Kenneth Graunke
On 08/06/2012 02:50 PM, Paulo Zanoni wrote: > From: Paulo Zanoni > > Signed-off-by: Paulo Zanoni Reviewed-by: Kenneth Graunke Do you have push access? If not, I can commit this for you. ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http

Re: [Mesa-dev] [PATCH] glx/dri: Initialize reset to __DRI_CTX_RESET_NO_NOTIFICATION.

2012-08-06 Thread Jordan Justen
Reviewed-by: Jordan Justen On Mon, Aug 6, 2012 at 3:12 PM, Kenneth Graunke wrote: > If the application has requested reset notification, then > dri2_convert_glx_attribs will initialize this to the correct value. > > Otherwise, it's supposed to initialize this to NO_NOTIFICATION, but > doesn't wh

Re: [Mesa-dev] [PATCH v2] docs: Add OpenGL 4.3 requirements

2012-08-06 Thread Ian Romanick
On 08/06/2012 12:47 PM, Jason Wood wrote: Add OpenGL 4.3 requirements. v2: Note that GLSL 4.3 has not been started, and that ARB_compute_shader has been started in Gallium drivers. Feel free to commit this as I do not have access. Signed-off-by: Jason Wood --- a/docs/GL3.txt 2012-08-06

Re: [Mesa-dev] [PATCH v2] docs: Add OpenGL 4.3 requirements

2012-08-06 Thread Brian Paul
On 08/06/2012 01:47 PM, Jason Wood wrote: Add OpenGL 4.3 requirements. v2: Note that GLSL 4.3 has not been started, and that ARB_compute_shader has been started in Gallium drivers. Feel free to commit this as I do not have access. Signed-off-by: Jason Wood --- a/docs/GL3.txt 2012-08-06 1

Re: [Mesa-dev] [PATCH 1/2] docs/helpwanted: add r600g and i915g todo lists

2012-08-06 Thread Brian Paul
On 08/06/2012 01:38 PM, Andreas Boll wrote: --- docs/helpwanted.html |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/docs/helpwanted.html b/docs/helpwanted.html index 6d6058e..8aa1b92 100644 --- a/docs/helpwanted.html +++ b/docs/helpwanted.html @@ -56,8 +56,12 @@ Yo

Re: [Mesa-dev] [Intel-gfx] [PATCH mesa] i965: add more Haswell PCI IDs

2012-08-06 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Mon, Aug 6, 2012 at 6:50 PM, Paulo Zanoni wrote: > From: Paulo Zanoni > > Signed-off-by: Paulo Zanoni > --- > include/pci_ids/i965_pci_ids.h | 33 ++- > src/mesa/drivers/dri/intel/intel_chipset.h | 67 > -- > sr

[Mesa-dev] [PATCH] glx/dri: Initialize reset to __DRI_CTX_RESET_NO_NOTIFICATION.

2012-08-06 Thread Kenneth Graunke
If the application has requested reset notification, then dri2_convert_glx_attribs will initialize this to the correct value. Otherwise, it's supposed to initialize this to NO_NOTIFICATION, but doesn't when num_attribs == 0. Fixes a regression since a8724d85f8cb2f0fb73b9c6c1f268f9084c6d473 where

Re: [Mesa-dev] [PATCH] i965/fs: Don't set the saturate bit on gen4 math send instructions.

2012-08-06 Thread Eric Anholt
Kenneth Graunke writes: > On 07/28/2012 05:55 PM, Eric Anholt wrote: >> The saturate bit gets communicated as part of the message descriptor, and >> setting it in the instruction somehow trashes the results. >> >> Fixes piglit general/fog-modes and ext_fog_coord-modes. >> >> Bugzilla: https://b

[Mesa-dev] R600 VDPAU 422 regression since r600g: make sure copying of all texture formats is accelerated

2012-08-06 Thread Andy Furniss
Kernel is dcn card is rv790 - vdpau csc/scale regressed. This only shows with 422 colour so most things work. commit 7c371f46958910dd2ca9487c89af1b72bbfdada9 Author: Marek Olšák Date: Sat Jul 28 00:38:42 2012 +0200 r600g: make sure copying of all texture formats is accelerated [drm:ra

[Mesa-dev] [PATCH mesa] i965: add more Haswell PCI IDs

2012-08-06 Thread Paulo Zanoni
From: Paulo Zanoni Signed-off-by: Paulo Zanoni --- include/pci_ids/i965_pci_ids.h | 33 ++- src/mesa/drivers/dri/intel/intel_chipset.h | 67 -- src/mesa/drivers/dri/intel/intel_context.c | 35 +++- 3 files changed, 130 insertions(+

Re: [Mesa-dev] [PATCH 05/16] i965: Add functions up/downsampling on miptrees (v2)

2012-08-06 Thread Chad Versace
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 08/06/2012 11:10 AM, Eric Anholt wrote: > Chad Versace writes: > >> These functions do an up or downsample between mt and >> mt->singlesample_mt. >> >> Conceptually, these functions belong in intel_mipmap_tree.c. However, >> they needs to interac

Re: [Mesa-dev] Last UBO patchbomb!

2012-08-06 Thread Kenneth Graunke
On 07/31/2012 03:01 PM, Eric Anholt wrote: > I've tested it with my piglit series and with Intel's oglconform. My piglit > series complains about negative-bindbuffer-buffer's expectations being > violated by patch 6, but I think that testcase wants to be replced by one that > is aware of gl >=3.1

Re: [Mesa-dev] [PATCH 19/22] i965/vs: Communicate the pull constant block read parameters through src_regs.

2012-08-06 Thread Kenneth Graunke
On 07/31/2012 03:01 PM, Eric Anholt wrote: > Similar to the previous commit for the fragment shader. > --- > src/mesa/drivers/dri/i965/brw_vec4.h |3 ++- > src/mesa/drivers/dri/i965/brw_vec4_emit.cpp| 19 --- > src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp |

Re: [Mesa-dev] down to 1 test page failing in WebGL 1.0.1 test on Radeon driver

2012-08-06 Thread Alex Deucher
On Mon, Aug 6, 2012 at 5:14 PM, Alex Deucher wrote: > On Mon, Aug 6, 2012 at 12:43 AM, Benoit Jacob wrote: >> Hi, >> >> Just so you know: the WebGL 1.0.1 tests are now passing on 2 drivers on >> Linux: the Intel Mesa driver, and the NVIDIA driver. >> >> Technically that's enough for us to claim

Re: [Mesa-dev] down to 1 test page failing in WebGL 1.0.1 test on Radeon driver

2012-08-06 Thread Alex Deucher
On Mon, Aug 6, 2012 at 12:43 AM, Benoit Jacob wrote: > Hi, > > Just so you know: the WebGL 1.0.1 tests are now passing on 2 drivers on > Linux: the Intel Mesa driver, and the NVIDIA driver. > > Technically that's enough for us to claim conformance (we need to pass with 2 > drivers on each OS we

Re: [Mesa-dev] [PATCH] mesa: In conditional rendering fallback, check the query status.

2012-08-06 Thread Brian Paul
On 08/06/2012 01:52 PM, Eric Anholt wrote: Otherwise, conditional rendering always takes the fallthrough "render it anyway" case unless the application had itself done a check or wait on the query. Fixes intel oglconform's conditional_render advanced.nofbo.readpixels. --- src/mesa/main/condren

[Mesa-dev] [PATCH] mesa: In conditional rendering fallback, check the query status.

2012-08-06 Thread Eric Anholt
Otherwise, conditional rendering always takes the fallthrough "render it anyway" case unless the application had itself done a check or wait on the query. Fixes intel oglconform's conditional_render advanced.nofbo.readpixels. --- src/mesa/main/condrender.c |2 ++ 1 file changed, 2 insertions(

Re: [Mesa-dev] [PATCH 09/22] glsl: Fix calculation of std140 offset alignment for mat2s.

2012-08-06 Thread Kenneth Graunke
On 07/31/2012 03:01 PM, Eric Anholt wrote: > We were getting the base offset of a vec2, not of a vec2[2] like the quoted > spec text says we should. > --- > src/glsl/glsl_types.cpp | 13 + > 1 file changed, 9 insertions(+), 4 deletions(-) > > diff --git a/src/glsl/glsl_types.cpp b/s

[Mesa-dev] [PATCH v2] docs: Add OpenGL 4.3 requirements

2012-08-06 Thread Jason Wood
Add OpenGL 4.3 requirements. v2: Note that GLSL 4.3 has not been started, and that ARB_compute_shader has been started in Gallium drivers. Feel free to commit this as I do not have access. Signed-off-by: Jason Wood --- a/docs/GL3.txt 2012-08-06 10:49:10.185597917 -0600 +++ b/docs/GL3.txt

Re: [Mesa-dev] [PATCH 05/22] glsl: Add a lowering pass to turn complicated UBO references to vector loads.

2012-08-06 Thread Kenneth Graunke
On 07/31/2012 03:01 PM, Eric Anholt wrote: > --- > src/glsl/Makefile.sources|1 + > src/glsl/ir_optimization.h |1 + > src/glsl/lower_ubo_reference.cpp | 325 > ++ > 3 files changed, 327 insertions(+) > create mode 100644 src/glsl/lower_

[Mesa-dev] [PATCH 2/2] docs: update piglit url

2012-08-06 Thread Andreas Boll
--- docs/helpwanted.html |2 +- docs/shading.html|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/helpwanted.html b/docs/helpwanted.html index 8aa1b92..e452689 100644 --- a/docs/helpwanted.html +++ b/docs/helpwanted.html @@ -37,7 +37,7 @@ deprecated starting i

[Mesa-dev] [PATCH 1/2] docs/helpwanted: add r600g and i915g todo lists

2012-08-06 Thread Andreas Boll
--- docs/helpwanted.html |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/docs/helpwanted.html b/docs/helpwanted.html index 6d6058e..8aa1b92 100644 --- a/docs/helpwanted.html +++ b/docs/helpwanted.html @@ -56,8 +56,12 @@ You can find some further To-do lists here: t

[Mesa-dev] [REVIEW-8.0] Cherry-pick bin/shortlog_mesa.sh script

2012-08-06 Thread Andreas Boll
To make Ian's life easier, please cherry-pick these two commits: mesa: added Ian's shortlog_mesa.sh script in bin/ 51c9c67a2ff2ec5963680fe5733691a6a991eab5 mesa: fix html in shortlog_mesa.sh script c1dcf9665c770d25ba8cbe827f4e3e69349d2665 Andreas.

Re: [Mesa-dev] [PATCH 14/16] dri: Simplify use of driConcatConfigs

2012-08-06 Thread Eric Anholt
Chad Versace writes: > If either argument to driConcatConfigs(a, b) is null or the empty list, > then simply return the other argument as the resultant list. > > All callers were accomplishing that same behavior anyway. And each caller > accopmplished it with the same pattern. So this patch moves

Re: [Mesa-dev] [PATCH 12/16] intel: Downsample on DRI2 flush

2012-08-06 Thread Eric Anholt
Chad Versace writes: > CC: Eric Anholt > Reviewed-by: Paul Berry > Signed-off-by: Chad Versace Reviewed-by: Eric Anholt pgp9FB4QzN2S0.pgp Description: PGP signature ___ mesa-dev mailing list mesa-dev@lists.freedesktop.org http://lists.freedesktop.

Re: [Mesa-dev] [PATCH 05/16] i965: Add functions up/downsampling on miptrees (v2)

2012-08-06 Thread Eric Anholt
Chad Versace writes: > These functions do an up or downsample between mt and mt->singlesample_mt. > +static void > +intel_miptree_updownsample(struct intel_context *intel, > + struct intel_mipmap_tree *mt, > + enum intel_updownsample direction

Re: [Mesa-dev] [PATCH 11/16] intel: Support mapping multisample miptrees

2012-08-06 Thread Eric Anholt
Chad Versace writes: > Add two new functions: intel_miptree_{map,unmap}_multisample, to which > intel_miptree_{map,unmap} dispatch. Only mapping flat, renderbuffer-like > miptrees are supported. > void > @@ -1513,5 +1606,8 @@ intel_miptree_unmap(struct intel_context *intel, >

Re: [Mesa-dev] [PATCH 07/16] intel: Add function for marking needed downsample

2012-08-06 Thread Eric Anholt
Chad Versace writes: > Add function intel_renderbuffer_set_needs_downsample. It is a no-op > except on multisample winsys buffers shared with DRI2. Squash into next commit and this gets Reviewed-by: Eric Anholt pgpCcBp2Gd83A.pgp Description: PGP signature

Re: [Mesa-dev] [PATCH] i965/fs: Don't set the saturate bit on gen4 math send instructions.

2012-08-06 Thread Kenneth Graunke
On 07/28/2012 05:55 PM, Eric Anholt wrote: > The saturate bit gets communicated as part of the message descriptor, and > setting it in the instruction somehow trashes the results. > > Fixes piglit general/fog-modes and ext_fog_coord-modes. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?i

Re: [Mesa-dev] [PATCH 05/16] i965: Add functions up/downsampling on miptrees (v2)

2012-08-06 Thread Eric Anholt
Chad Versace writes: > These functions do an up or downsample between mt and mt->singlesample_mt. > > Conceptually, these functions belong in intel_mipmap_tree.c. However, they > needs to interact with blorp, which is C++. So I created a new file, > brw_blorp_orphans.cpp, for these and other func

Re: [Mesa-dev] [PATCH 03/16] intel: Add singlesample fields to intel_mipmap_tree

2012-08-06 Thread Eric Anholt
Chad Versace writes: > Add the following fields: > singlesamle_width0 > singlesample_height0 > singlesample_mt > needs_downsample > > These will all be used by later commits that implement MSAA for window > system buffers. I really don't like splitting the commits for creation of

[Mesa-dev] [Bug 53179] New: libOSMesa / libdricore not linked well

2012-08-06 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=53179 Bug #: 53179 Summary: libOSMesa / libdricore not linked well Classification: Unclassified Product: Mesa Version: git Platform: Other OS/Version: All Status: NEW

Re: [Mesa-dev] [PATCH] Docs: Add OpenGL 4.3 requirements

2012-08-06 Thread Alex Deucher
On Mon, Aug 6, 2012 at 1:12 PM, Jason Wood wrote: > Add OpenGL 4.3 requirements. > > Signed-off-by: Jason Wood > > --- a/docs/GL3.txt 2012-08-06 10:49:10.185597917 -0600 > +++ b/docs/GL3.txt 2012-08-06 10:48:45.809477043 -0600 > @@ -130,5 +130,35 @@ > GL_ARB_map_buffer_alignment

Re: [Mesa-dev] [PATCH 2/4] i965/fs: Factor out texcoord setup into a helper function.

2012-08-06 Thread Eric Anholt
Kenneth Graunke writes: > With the textureRect support and GL_CLAMP workarounds, it's grown > sufficiently that it deserves its own function. Separating it out > makes the original function much more readable. This looks good. > While we're refactoring it, tidy up a conditional. Instead of:

Re: [Mesa-dev] [PATCH 4/4] i965/vs: Don't clobber sampler message MRFs with subexpressions.

2012-08-06 Thread Eric Anholt
Kenneth Graunke writes: > See the preceding commit for a description of the problem. > > NOTE: This is a candidate for stable release branches. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=52129 > Signed-off-by: Kenneth Graunke > --- > src/mesa/drivers/dri/i965/brw_vec4_visitor.cp

Re: [Mesa-dev] [PATCH] i965: Allocate dummy slots for point sprites before computing VUE map.

2012-08-06 Thread Eric Anholt
Kenneth Graunke writes: > Commit f0cecd43d6b6d moved the VUE map computation to be only once, at > VS compile time. However, it did so in slightly the wrong place: it > made the one call to brw_vue_compute_map happen right before the > allocation of dummy slots for replaced point sprite coordina

[Mesa-dev] [PATCH] Docs: Add OpenGL 4.3 requirements

2012-08-06 Thread Jason Wood
Add OpenGL 4.3 requirements. Signed-off-by: Jason Wood --- a/docs/GL3.txt 2012-08-06 10:49:10.185597917 -0600 +++ b/docs/GL3.txt 2012-08-06 10:48:45.809477043 -0600 @@ -130,5 +130,35 @@ GL_ARB_map_buffer_alignment not started +GL 4.3: + +GLSL 4.3 +ARB_arrays

Re: [Mesa-dev] [PATCH 1/2] radeon/winsys: fix winsys VM handling

2012-08-06 Thread Alex Deucher
On Mon, Aug 6, 2012 at 12:14 PM, Christian König wrote: > Move releasing the VM area after closing the bo handle. Maybe reference the bugzilla in the commit message? > > Signed-off-by: Christian König Reviewed-by: Alex Deucher > --- > src/gallium/winsys/radeon/drm/radeon_drm_bo.c |7 +++

[Mesa-dev] [PATCH 2/2] radeonsi: fix memory leak and/or segfaults

2012-08-06 Thread Christian König
Fix a stupid typo that could lead to memory leaks and/or segfaults. Signed-off-by: Christian König Reviewed-by: Alex Deucher --- src/gallium/drivers/radeonsi/radeonsi_pm4.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeonsi/radeonsi_pm4.c b/src/

[Mesa-dev] [PATCH 1/2] radeon/winsys: fix winsys VM handling

2012-08-06 Thread Christian König
Move releasing the VM area after closing the bo handle. Signed-off-by: Christian König --- src/gallium/winsys/radeon/drm/radeon_drm_bo.c |7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/gallium/winsys/radeon/drm/radeon_drm_bo.c b/src/gallium/winsys/radeon/drm/ra

Re: [Mesa-dev] [PATCH 5/5] llvmpipe: consolidate the sampler and sampler view setting code

2012-08-06 Thread Brian Paul
On 08/05/2012 01:27 AM, Jose Fonseca wrote: - Original Message - Less code. And as with softpipe, if/when we consolidate the pipe_context functions for binding sampler state, this will make the llvmpipe changes trivial. --- src/gallium/drivers/llvmpipe/lp_state_sampler.c | 118 ++