Re: [Mesa-dev] [PATCH 3/3] i965: Flag ARGB8888 renderbuffers as sRGB capable and support it.

2012-07-31 Thread Kenneth Graunke
On 07/31/2012 06:04 PM, Eric Anholt wrote: > Fixes rendering in l4d2, which assumes sRGB capability without asking. We > could convince the app to ask for sRGB, except that we don't expose visuals > with sRGB currently. This gives the app the ability to choose sRGB rendering > on the typical visu

[Mesa-dev] [Bug 52512] Build failures: glsl_lexer.cc & glsl_parser.cc don't exist

2012-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52512 Matt Turner changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 52512] Build failures: glsl_lexer.cc & glsl_parser.cc don't exist

2012-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52512 --- Comment #4 from Darren Salt 2012-08-01 02:42:04 UTC --- More information. make[5]: *** No rule to make target `../../../../../src/mesa/libdricore/../../glsl/glsl_lexer.cc', needed by `glsl_lexer.lo'. Stop. make[5]: Leaving directory `/.../

[Mesa-dev] [PATCH 3/3] i965: Flag ARGB8888 renderbuffers as sRGB capable and support it.

2012-07-31 Thread Eric Anholt
Fixes rendering in l4d2, which assumes sRGB capability without asking. We could convince the app to ask for sRGB, except that we don't expose visuals with sRGB currently. This gives the app the ability to choose sRGB rendering on the typical visual, without having to coordinate with the layer of

[Mesa-dev] [PATCH 2/3] i965: Pass the framebuffer to update_renderbuffer_surface().

2012-07-31 Thread Eric Anholt
We're going to want to look at the framebuffer for window system sRGB handling. --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c |5 +++-- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c |3 ++- src/mesa/drivers/dri/intel/intel_context.h|4 ++-- 3 files changed, 7 insert

[Mesa-dev] sRGB BlitFramebuffer fix (l4d2 works!)

2012-07-31 Thread Eric Anholt
This is the rendering fix idr and I came to agreement on. I'm hoping this doesn't make wine angry -- they're the only app I expect would have issues with this, and I think what they want should be controllable by GL_FRAMEBUFFER_SRGB (so hopefully things just work). ___

[Mesa-dev] [PATCH 1/3] meta: Implement sensible behavior for BlitFramebuffer with sRGB.

2012-07-31 Thread Eric Anholt
Prior to GL 4.2 spec, there was no guidance on how to implement BlitFramebuffer for sRGB. Mesa chose to implement skipping decode and encode, providing a reasonable behavior for sRGB -> sRGB or RGB -> RGB, but providing something absurd for mixing and matching the two. In GL 4.2, some text appear

Re: [Mesa-dev] [PATCH 2/2] mesa: Expose texture buffer objects when the context is GL 3.1 core.

2012-07-31 Thread Kenneth Graunke
On 07/31/2012 03:24 PM, Eric Anholt wrote: > --- > src/mesa/main/bufferobj.c |3 ++- > src/mesa/main/get.c | 16 +++- > src/mesa/main/teximage.c |6 -- > 3 files changed, 17 insertions(+), 8 deletions(-) > > diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/b

Re: [Mesa-dev] [PATCH 1/2] mesa: Replace VersionMajor/VersionMinor with a Version field.

2012-07-31 Thread Kenneth Graunke
On 07/31/2012 03:24 PM, Eric Anholt wrote: > As we get into supporting GL 3.x core, we come across more and more features > of the API that depend on the version number as opposed to just the extension > list. This will let us more sanely do version checks than "(VersionMajor == 3 > && VersionMino

[Mesa-dev] [PATCH] egl: update eglext.h to revision 18699

2012-07-31 Thread Matt Turner
Useful for EGL_KHR_create_context. --- include/EGL/eglext.h | 157 +- 1 files changed, 143 insertions(+), 14 deletions(-) diff --git a/include/EGL/eglext.h b/include/EGL/eglext.h index a7ea2ea..7c45b64 100644 --- a/include/EGL/eglext.h +++ b/includ

[Mesa-dev] [PATCH 1/2] mesa: Replace VersionMajor/VersionMinor with a Version field.

2012-07-31 Thread Eric Anholt
As we get into supporting GL 3.x core, we come across more and more features of the API that depend on the version number as opposed to just the extension list. This will let us more sanely do version checks than "(VersionMajor == 3 && VersionMinor >= 2) || VersionMajor >= 4". --- I didn't like a

[Mesa-dev] [PATCH 2/2] mesa: Expose texture buffer objects when the context is GL 3.1 core.

2012-07-31 Thread Eric Anholt
--- src/mesa/main/bufferobj.c |3 ++- src/mesa/main/get.c | 16 +++- src/mesa/main/teximage.c |6 -- 3 files changed, 17 insertions(+), 8 deletions(-) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index 5fdf52e..7216307 100644 --- a/src/mesa/m

Re: [Mesa-dev] [PATCH] radeon/llvm: fix calculation of max register number

2012-07-31 Thread Tom Stellard
On Tue, Jul 31, 2012 at 06:40:11PM +0200, Christian König wrote: > Signed-off-by: Christian König Reviewed-by: Tom Stellard > --- > src/gallium/drivers/radeon/SICodeEmitter.cpp |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/gallium/drivers/radeon/SICodeEmitter

[Mesa-dev] [PATCH 22/22] i965: Enable uniform buffer objects on gen6+.

2012-07-31 Thread Eric Anholt
--- docs/GL3.txt |2 +- src/mesa/drivers/dri/intel/intel_extensions.c |1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/docs/GL3.txt b/docs/GL3.txt index 7c68745..dc1df6d 100644 --- a/docs/GL3.txt +++ b/docs/GL3.txt @@ -50,7 +50,7 @@ Primi

[Mesa-dev] [PATCH 18/22] i965/fs: Communicate the pull constant block read parameters through fs_regs.

2012-07-31 Thread Eric Anholt
I wanted to add the surface index as a variable value for UBO support, and a reg seemed like the obvious way to go. This exposes more of the information to CSE, which we'll probably want to apply to pull constant loads for UBOs eventually (you might access 4 floats in a row, each of which would pr

[Mesa-dev] [PATCH 20/22] i965/fs: Add support for loading uniform buffer variables as pull constants.

2012-07-31 Thread Eric Anholt
Variable array indexing isn't finished, because the lowering pass turns it all into conditional moves of constant index accesses so I can't test it. --- src/mesa/drivers/dri/i965/brw_fs.cpp |5 +++ src/mesa/drivers/dri/i965/brw_fs_visitor.cpp | 43 +- src/mesa

[Mesa-dev] [PATCH 16/22] i965: Add an offset argument to constant buffer setup.

2012-07-31 Thread Eric Anholt
We'll use this for UBO surfaces. --- src/mesa/drivers/dri/i965/brw_state.h |2 ++ src/mesa/drivers/dri/i965/brw_vs_surface_state.c |2 +- src/mesa/drivers/dri/i965/brw_wm_surface_state.c |7 --- src/mesa/drivers/dri/i965/gen7_wm_surface_state.c |5 +++-- src/mesa/

[Mesa-dev] [PATCH 21/22] i965/vs: Add support for loading uniform buffer variables as pull constants.

2012-07-31 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 52 +++- src/mesa/drivers/dri/i965/brw_vs.c |5 +++ 2 files changed, 55 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp b/src/mesa/drivers/dri/i965/brw_vec4_visito

[Mesa-dev] [PATCH 17/22] i965: Bind UBOs as surfaces like we do for pull constants.

2012-07-31 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_context.h | 22 +++- src/mesa/drivers/dri/i965/brw_state.h|2 + src/mesa/drivers/dri/i965/brw_state_upload.c |4 ++ src/mesa/drivers/dri/i965/brw_vs.c |2 +- src/mesa/drivers/dri/i965/brw_vs_surface_state.c

[Mesa-dev] [PATCH 15/22] mesa: Add support for glUniformBlockBinding() in display lists.

2012-07-31 Thread Eric Anholt
Fixes piglit GL_ARB_uniform_buffer_object/dlist. --- src/mesa/main/dlist.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/src/mesa/main/dlist.c b/src/mesa/main/dlist.c index 510fd1e..e3dc9c0 100644 --- a/src/mesa/main/dlist.c +++ b/src/mesa/main/dlist.c @@ -482,

[Mesa-dev] [PATCH 19/22] i965/vs: Communicate the pull constant block read parameters through src_regs.

2012-07-31 Thread Eric Anholt
Similar to the previous commit for the fragment shader. --- src/mesa/drivers/dri/i965/brw_vec4.h |3 ++- src/mesa/drivers/dri/i965/brw_vec4_emit.cpp| 19 --- src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp |5 +++-- 3 files changed, 17 insertions(+), 10 delet

[Mesa-dev] [PATCH 14/22] mesa: Unbind uniform buffer bindings on glDeleteBuffers().

2012-07-31 Thread Eric Anholt
Fixes piglit GL_ARB_uniform_buffer_object/deletebuffers. --- src/mesa/main/bufferobj.c |7 +++ 1 file changed, 7 insertions(+) diff --git a/src/mesa/main/bufferobj.c b/src/mesa/main/bufferobj.c index ad28f8a..5fdf52e 100644 --- a/src/mesa/main/bufferobj.c +++ b/src/mesa/main/bufferobj.c @

[Mesa-dev] [PATCH 05/22] glsl: Add a lowering pass to turn complicated UBO references to vector loads.

2012-07-31 Thread Eric Anholt
--- src/glsl/Makefile.sources|1 + src/glsl/ir_optimization.h |1 + src/glsl/lower_ubo_reference.cpp | 325 ++ 3 files changed, 327 insertions(+) create mode 100644 src/glsl/lower_ubo_reference.cpp diff --git a/src/glsl/Makefile.sources

[Mesa-dev] [PATCH 12/22] glsl: Refuse to parse uniform block declarations when UBOs aren't available.

2012-07-31 Thread Eric Anholt
Fixes piglit GL_ARB_uniform_buffer_object/compiler/extension-disabled-block.frag --- src/glsl/glsl_parser.yy | 20 1 file changed, 20 insertions(+) diff --git a/src/glsl/glsl_parser.yy b/src/glsl/glsl_parser.yy index 04c64f0..ee6a672 100644 --- a/src/glsl/glsl_parser.yy +++

[Mesa-dev] [PATCH 11/22] glsl: Align GL_UNIFORM_BLOCK_DATA_SIZE according to std140 rules.

2012-07-31 Thread Eric Anholt
Fixes piglit GL_ARB_uniform_buffer_object/data-size test. --- src/glsl/link_uniforms.cpp | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/src/glsl/link_uniforms.cpp b/src/glsl/link_uniforms.cpp index 4f21a41..25dc1d7 100644 --- a/src/glsl/link_uniforms.cpp +++ b

[Mesa-dev] [PATCH 08/22] glsl: Fix glGetActiveUniformsiv(GL_UNIFORM_BLOCK_INDEX).

2012-07-31 Thread Eric Anholt
Previously, we were returning the index into the UniformBlocks of one of the linked shaders, when it's supposed to be the program global index. Fixes piglit getactiveuniformsiv-uniform_block_index. --- src/glsl/link_uniforms.cpp | 16 +--- 1 file changed, 13 insertions(+), 3 deletio

[Mesa-dev] [PATCH 13/22] mesa: Default to GL 3.1's limits on uniform blocks.

2012-07-31 Thread Eric Anholt
The ARB spec lets you get away with the default block counting against the blocks for combined size limits. The core spec says you need to be able to support the maximum size of default block *and* the maximum size of each uniform block. I see no reason that any driver would have a problem with t

[Mesa-dev] [PATCH 07/22] ir_to_mesa: Don't whack the ->location field of uniform block variables.

2012-07-31 Thread Eric Anholt
Fixes some failures in GL_ARB_uniform_buffer_object/maxblocks. --- src/mesa/program/ir_to_mesa.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/program/ir_to_mesa.cpp b/src/mesa/program/ir_to_mesa.cpp index 70c4cc8..d675da2 100644 --- a/src/mesa/program/ir_to_mes

[Mesa-dev] [PATCH 10/22] glsl: Only flag RowMajor on matrix-type variables.

2012-07-31 Thread Eric Anholt
We were only propagating it to the API when the variable was a matrix type, but we were still tripping over it in lower_ubo_reference when it was set on a vector. --- src/glsl/ast_to_hir.cpp | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/src/glsl/ast_to_hir.cp

[Mesa-dev] [PATCH 06/22] mesa: Make glBindBufferBase/glBindBufferRange() work on just-genned names.

2012-07-31 Thread Eric Anholt
In between glGenBuffers() and glBindBuffer(), the buffer object points to this dummy buffer with a name of 0, and a glBindBufferBase() would point to that. It seems pretty clear, given that glBindBufferBase() only cares about the current size of the buffer at render time, that it should bind up the

[Mesa-dev] [PATCH 09/22] glsl: Fix calculation of std140 offset alignment for mat2s.

2012-07-31 Thread Eric Anholt
We were getting the base offset of a vec2, not of a vec2[2] like the quoted spec text says we should. --- src/glsl/glsl_types.cpp | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/glsl/glsl_types.cpp b/src/glsl/glsl_types.cpp index 3d78660..8e7ae42 100644 ---

[Mesa-dev] [PATCH 03/22] glsl: Add a "ubo_load" expression type for fetches from UBOs.

2012-07-31 Thread Eric Anholt
Drivers will probably want to be able to take UBO references in a shader like: uniform ubo1 { float a; float b; float c; float d; } void main() { gl_FragColor = vec4(a, b, c, d); } and ge

[Mesa-dev] Last UBO patchbomb!

2012-07-31 Thread Eric Anholt
I've tested it with my piglit series and with Intel's oglconform. My piglit series complains about negative-bindbuffer-buffer's expectations being violated by patch 6, but I think that testcase wants to be replced by one that is aware of gl >=3.1 versus <=3.0. Intel's oglconform complains only ab

[Mesa-dev] [PATCH 02/22] glsl: Fix a reference to UniformBlocks during uniform linking.

2012-07-31 Thread Eric Anholt
When converting var->location from pointing at the program's UniformBlocks to pointing at the linked shader's UniformBlocks, I missed this change. It usually worked out in the end because the two lists happen to be the same in many testcases. Fixes a valgrind complaint on oglconform ubo-compile.c

[Mesa-dev] [PATCH 04/22] glsl: Add a variant of the rvalue visitor for handle_rvalue() on the way down.

2012-07-31 Thread Eric Anholt
For the UBO lowering pass, I want to see the whole dereference chain for replacing, not the innermost ir_dereference_variable. --- src/glsl/ir_rvalue_visitor.cpp | 127 +--- src/glsl/ir_rvalue_visitor.h | 31 +- 2 files changed, 147 insertions(+), 1

[Mesa-dev] [PATCH 01/22] glsl: Update the notes on adding a new expression type.

2012-07-31 Thread Eric Anholt
Reviewed-by: Ian Romanick --- src/glsl/README |1 - 1 file changed, 1 deletion(-) diff --git a/src/glsl/README b/src/glsl/README index dd80a53..0a0afcc 100644 --- a/src/glsl/README +++ b/src/glsl/README @@ -177,7 +177,6 @@ ir_unop_fract was added. The following areas need updating to add a

[Mesa-dev] [Bug 52512] Build failures: glsl_lexer.cc & glsl_parser.cc don't exist

2012-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52512 --- Comment #3 from Darren Salt 2012-07-31 21:32:42 UTC --- It was git master, yes. I use lightly-hacked Debian build scripts to do the build. I'd not done a git clean due to the debian directory; however, I've now removed those two files. (I w

[Mesa-dev] [Bug 52996] Read out of bounds in swizzle_for_size() (MesaLib/src/mesa/program/ir_to_mesa.cpp)

2012-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52996 --- Comment #2 from Ian Romanick 2012-07-31 19:42:15 UTC --- Is there a way to have AddressSanitizer drop into a debugger (like --db-attach=yes in Valgrind) when it hits an error? It would be interesting to go up to the topmost ir_to_mesa_visit

Re: [Mesa-dev] [PATCH] i965: Add support for GL_SKIP_DECODE_EXT on other SRGB formats.

2012-07-31 Thread Brian Paul
On 07/31/2012 12:02 PM, Eric Anholt wrote: Brian Paul writes: On 07/31/2012 09:30 AM, Eric Anholt wrote: Kenneth Graunke writes: On 07/30/2012 03:28 PM, Brian Paul wrote: On 07/30/2012 02:13 PM, Eric Anholt wrote: Fixes some failures in getteximage-formats. --- src/mesa/drivers/dri/

Re: [Mesa-dev] [PATCH] i965: Add support for GL_SKIP_DECODE_EXT on other SRGB formats.

2012-07-31 Thread Eric Anholt
Brian Paul writes: > On 07/31/2012 09:30 AM, Eric Anholt wrote: >> Kenneth Graunke writes: >> >>> On 07/30/2012 03:28 PM, Brian Paul wrote: On 07/30/2012 02:13 PM, Eric Anholt wrote: > Fixes some failures in getteximage-formats. > --- >src/mesa/drivers/dri/i965/brw_wm_surfac

Re: [Mesa-dev] [PATCH] Revert "glsl: warning: pragma `invariant(all)' not supported in GLSL ES 1.00"

2012-07-31 Thread Kenneth Graunke
On 07/31/2012 08:41 AM, Eric Anholt wrote: > Kenneth Graunke writes: > >> This reverts commit e72f20641a6ea7875b6021aac13e778ada3b3d50. >> >> The commit has two problems: >> - The commit message itself quotes language from the GLSL ES 1.00 >> specification that indicates that it /does/ support

Re: [Mesa-dev] [PATCH 03/11] mesa: Add support for glUniformBlockBinding() and the API to get it back.

2012-07-31 Thread Eric Anholt
Kenneth Graunke writes: > On 07/20/2012 03:33 PM, Eric Anholt wrote: >> Fixes piglit ARB_uniform_buffer_object/uniformbufferbinding. >> --- >> src/mesa/main/uniforms.c | 95 >> ++ >> 1 file changed, 95 insertions(+) >> >> diff --git a/src/mesa/main

[Mesa-dev] [PATCH] radeon/llvm: fix calculation of max register number

2012-07-31 Thread Christian König
Signed-off-by: Christian König --- src/gallium/drivers/radeon/SICodeEmitter.cpp |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/SICodeEmitter.cpp b/src/gallium/drivers/radeon/SICodeEmitter.cpp index a7647aa..9fc4aab 100644 --- a/src/gallium/drive

Re: [Mesa-dev] [PATCH] Revert "glsl: warning: pragma `invariant(all)' not supported in GLSL ES 1.00"

2012-07-31 Thread Eric Anholt
Kenneth Graunke writes: > This reverts commit e72f20641a6ea7875b6021aac13e778ada3b3d50. > > The commit has two problems: > - The commit message itself quotes language from the GLSL ES 1.00 > specification that indicates that it /does/ support the invariant(all) > pragma. This appears to be t

Re: [Mesa-dev] [PATCH] i965: Add support for GL_SKIP_DECODE_EXT on other SRGB formats.

2012-07-31 Thread Brian Paul
On 07/31/2012 09:30 AM, Eric Anholt wrote: Kenneth Graunke writes: On 07/30/2012 03:28 PM, Brian Paul wrote: On 07/30/2012 02:13 PM, Eric Anholt wrote: Fixes some failures in getteximage-formats. --- src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 14 ++ 1 file changed,

Re: [Mesa-dev] [PATCH] i965: Add support for GL_SKIP_DECODE_EXT on other SRGB formats.

2012-07-31 Thread Eric Anholt
Kenneth Graunke writes: > On 07/30/2012 03:28 PM, Brian Paul wrote: >> On 07/30/2012 02:13 PM, Eric Anholt wrote: >>> Fixes some failures in getteximage-formats. >>> --- >>> src/mesa/drivers/dri/i965/brw_wm_surface_state.c | 14 ++ >>> 1 file changed, 6 insertions(+), 8 deletions

Re: [Mesa-dev] [Intel-gfx] [PATCH 1/5] intel gen4/5: fix GL_VERTEX_PROGRAM_TWO_SIDE.

2012-07-31 Thread Eric Anholt
Olivier Galibert writes: > On Mon, Jul 30, 2012 at 10:30:57AM -0700, Eric Anholt wrote: >> I'm perfectly fine with the VUE containing slots for both when the app >> has gone out of its way to ask for deprecated two-sided color >> rendering. > > Are you also ok with recompiler the shaders when tha

[Mesa-dev] [Bug 52512] Build failures: glsl_lexer.cc & glsl_parser.cc don't exist

2012-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52512 --- Comment #2 from Michel Dänzer 2012-07-31 14:26:18 UTC --- The old *.cpp files still existing was what caused this for me, and removing them fixed it. -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --- You ar

[Mesa-dev] [Bug 52996] Read out of bounds in swizzle_for_size() (MesaLib/src/mesa/program/ir_to_mesa.cpp)

2012-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52996 --- Comment #1 from Brian Paul 2012-07-31 14:14:45 UTC --- The swizzle_for_size() function is (unchanged from Mesa 7.9 to today): static int swizzle_for_size(int size) { int size_swizzles[4] = { MAKE_SWIZZLE4(SWIZZLE_X, SWIZZLE_X, SWIZ

Re: [Mesa-dev] [PATCH 4/5] radeonsi: fix register count calculation

2012-07-31 Thread Christian König
On 31.07.2012 15:32, Michel Dänzer wrote: On Mit, 2012-07-25 at 19:58 +0200, Christian König wrote: Signed-off-by: Christian König --- src/gallium/drivers/radeonsi/si_state_draw.c |8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/gallium/drivers/radeonsi/si_s

Re: [Mesa-dev] [PATCH 4/5] radeonsi: fix register count calculation

2012-07-31 Thread Michel Dänzer
On Mit, 2012-07-25 at 19:58 +0200, Christian König wrote: > Signed-off-by: Christian König > --- > src/gallium/drivers/radeonsi/si_state_draw.c |8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/gallium/drivers/radeonsi/si_state_draw.c > b/src/gallium/drive

Re: [Mesa-dev] R600g : rejected cs and etqw corruption with - implement wait-free buffer transfer for DISCARD_RANGE

2012-07-31 Thread Andy Furniss
Andy Furniss wrote: Marek Olšák wrote: Hi Andy, this should be fixed by the commit: commit c3c83af380d703cdc24475bd39baa1722c333b44 Author: Marek Olšák Date: Wed Jul 18 18:33:37 2012 +0200 r600g: setup streamout before calling last r600_need_cs_space before drawing Please let me know

[Mesa-dev] [Bug 52996] New: Read out of bounds in swizzle_for_size() (MesaLib/src/mesa/program/ir_to_mesa.cpp)

2012-07-31 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=52996 Bug #: 52996 Summary: Read out of bounds in swizzle_for_size() (MesaLib/src/mesa/program/ir_to_mesa.cpp) Classification: Unclassified Product: Mesa Version: 7.9 Platfo

[Mesa-dev] [PATCH] Revert "glsl: warning: pragma `invariant(all)' not supported in GLSL ES 1.00"

2012-07-31 Thread Kenneth Graunke
This reverts commit e72f20641a6ea7875b6021aac13e778ada3b3d50. The commit has two problems: - The commit message itself quotes language from the GLSL ES 1.00 specification that indicates that it /does/ support the invariant(all) pragma. This appears to be the opposite of what the commit actual

Re: [Mesa-dev] [PATCH] gallium/util: Use GCC built-in functions for NaN and infinity.

2012-07-31 Thread Philipp Klaus Krause
This one doesn't make sense to me: For __GNUC__ it uses implementation-defined non-standard stuff. For other compilers it divides by zero, which is undefined behaviour. Why not use standard macros NAN and INFINITY from math.h? The standard (section 7.12 in the C11 standard, AFAIK the wording is the

Re: [Mesa-dev] [PATCH 03/11] mesa: Add support for glUniformBlockBinding() and the API to get it back.

2012-07-31 Thread Kenneth Graunke
On 07/20/2012 03:33 PM, Eric Anholt wrote: > Fixes piglit ARB_uniform_buffer_object/uniformbufferbinding. > --- > src/mesa/main/uniforms.c | 95 > ++ > 1 file changed, 95 insertions(+) > > diff --git a/src/mesa/main/uniforms.c b/src/mesa/main/uniform

Re: [Mesa-dev] [PATCH] gbm : Fix build for wayland include

2012-07-31 Thread Pekka Paalanen
On Mon, 30 Jul 2012 12:02:06 -0400 Kristian Høgsberg wrote: > On Thu, Jul 19, 2012 at 01:54:05PM +0900, Elvis Lee wrote: > > backends/gbm_dri.c fails to find wayland-server.h. > > Thanks, pushed. Yeah thanks, the build works for me too, now. > > Signed-off-by: Elvis Lee > > --- > > src/gbm/M