Re: [Mesa-dev] [PATCH] Always build shared glapi

2012-07-04 Thread Homer Hsing
>> On Sun, Jan 22, 2012 at 9:09 AM, Jon TURNEY >> wrote: >> > On 11/01/2012 23:37, Matt Turner wrote: >> >> No one on IRC knows why an unshared glapi is useful. >> > >> > It looks like this change stops OSMesa from builing on cygwin (See [1]) >> > >> > I think this is because we never tried buil

[Mesa-dev] [PATCH] Always build shared glapi

2012-07-04 Thread Homer Hsing
> On Sun, Jan 22, 2012 at 9:09 AM, Jon TURNEY > wrote: > > On 11/01/2012 23:37, Matt Turner wrote: > >> No one on IRC knows why an unshared glapi is useful. > > > > It looks like this change stops OSMesa from builing on cygwin (See [1]) > > > > I think this is because we never tried building it

[Mesa-dev] i965 Valleyview: 3DSTATE_URB_VS Minimum URB Entries Fix

2012-07-04 Thread Cheah, Douglas
Hello folks, I am not too sure if this right avenue but I am trying to get the patch below integrated into MESA. The patch below solves a bug where for several 3D application running on Intel's Valleyview hardware there would be massive corruption. Corruptions includes vertex being wrongly cl

[Mesa-dev] [PATCH 5/5] i965/fs: Invalidate live intervals after copy propagation.

2012-07-04 Thread Eric Anholt
For copy propgation, we've dropped the use of a GRF in favor of a (probably later) use of a different GRF. This definitely requires invalidating intervals. --- src/mesa/drivers/dri/i965/brw_fs_copy_propagation.cpp |3 +++ 1 file changed, 3 insertions(+) diff --git a/src/mesa/drivers/dri/i965

[Mesa-dev] [PATCH 1/5] i965/fs: Move class functions from the header to .cpp files.

2012-07-04 Thread Eric Anholt
Cuts compile time for brw_fs.h changes from 2.7s to .7s and reduces i965_dri.so size by 70k. --- src/mesa/drivers/dri/i965/brw_fs.cpp | 239 src/mesa/drivers/dri/i965/brw_fs.h | 304 +++--- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp |

[Mesa-dev] i965: backend optimizations, FS bugfixes

2012-07-04 Thread Eric Anholt
The first 3 patches are to reduce compile time and object size by avoiding c++ inlining I forced due to my laziness when originally typing these files. The last 2 are bugfixes for the FS that I noticed while working on the texture grf code. It produces some actual code changes in a closed-source

[Mesa-dev] [PATCH 2/5] i965/vs: Move class functions to brw_vec4.cpp.

2012-07-04 Thread Eric Anholt
This has less impact than for the FS (4k savings), because it was partially done already, but makes things more consistent. --- src/mesa/drivers/dri/i965/brw_vec4.cpp | 113 ++ src/mesa/drivers/dri/i965/brw_vec4.h | 119 2 files chan

[Mesa-dev] [PATCH 4/5] i965/fs: Invalidate live intervals in passes that remove an instruction.

2012-07-04 Thread Eric Anholt
Since live intervals are based on ip, removing an instruction trashes the intervals unless we were to go do some surgery. These happen to usually remove a use of a grf, so it's time to recalculate, anyway. --- src/mesa/drivers/dri/i965/brw_fs.cpp |6 ++ 1 file changed, 6 insertions(+) di

[Mesa-dev] [PATCH 3/5] i965/vs: Move the other two src_reg/dst_reg constructors to brw_vec4.cpp.

2012-07-04 Thread Eric Anholt
--- src/mesa/drivers/dri/i965/brw_vec4.cpp | 43 src/mesa/drivers/dri/i965/brw_vec4_visitor.cpp | 43 2 files changed, 43 insertions(+), 43 deletions(-) diff --git a/src/mesa/drivers/dri/i965/brw_vec4.cpp b/src/mesa/drivers/dri/i965/b

[Mesa-dev] [PATCH] Add emacs setup for the docs/devinfo.html comment wrapping recommendation.

2012-07-04 Thread Eric Anholt
--- .dir-locals.el |1 + 1 file changed, 1 insertion(+) diff --git a/.dir-locals.el b/.dir-locals.el index 3bd8328..4f0ad7a 100644 --- a/.dir-locals.el +++ b/.dir-locals.el @@ -3,6 +3,7 @@ (tab-width . 8) (c-basic-offset . 3) (c-file-style . "stroustrup") + (fill-column . 78) (ev

[Mesa-dev] [PATCH 3/3 v2] glx/dri2: Add support for GLX_ARB_create_context_robustness

2012-07-04 Thread Ian Romanick
From: Ian Romanick Add the infrastructure required for this extension. There is no xserver support and no driver support yet. Drivers can enable this be advertising DRI2 version 4 and accepting the __DRI_CTX_FLAG_ROBUST_BUFFER_ACCESS flag and the __DRI_CTX_ATTRIB_RESET_STRATEGY attribute in cre

Re: [Mesa-dev] [PATCH 06/18] glsl: Turn UBO variable declarations into ir_variables and check qualifiers.

2012-07-04 Thread Eric Anholt
Kenneth Graunke writes: > On 07/02/2012 05:38 PM, Eric Anholt wrote: >> Fixes piglit layout-*-non-uniform and layout-*-within-block. >> --- >> src/glsl/ast.h |6 ++ >> src/glsl/ast_to_hir.cpp | 36 +--- >> src/glsl/glsl_parser.yy

Re: [Mesa-dev] [PATCH 1/3] draw: draw_get_shader_param should return correct values WRT llvm

2012-07-04 Thread Marek Olšák
On Wed, Jul 4, 2012 at 7:41 PM, Olivier Galibert wrote: > On Wed, Jul 04, 2012 at 01:59:44PM +0200, Marek Ol??ák wrote: >> Please disregard patch 1 and 2. It wouldn't work. > > What's wrong with them? The way I understand it, Integer uniforms are converted to floats for a whole program object. Th

[Mesa-dev] [PATCH 5/6] intel: Drop other checks for old loader version.

2012-07-04 Thread Eric Anholt
--- src/mesa/drivers/dri/intel/intel_context.c | 64 +++- 1 file changed, 26 insertions(+), 38 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c index f62f0ec..9d8ac9c 100644 --- a/src/mesa/drivers/dri/inte

[Mesa-dev] [PATCH 6/6] intel: Add a comment explaining why we early return on matching BO names.

2012-07-04 Thread Eric Anholt
--- src/mesa/drivers/dri/intel/intel_context.c |4 1 file changed, 4 insertions(+) diff --git a/src/mesa/drivers/dri/intel/intel_context.c b/src/mesa/drivers/dri/intel/intel_context.c index 9d8ac9c..e5168ec 100644 --- a/src/mesa/drivers/dri/intel/intel_context.c +++ b/src/mesa/drivers/d

[Mesa-dev] [PATCH 2/6] intel: Convert to using private depth/stencil buffers.

2012-07-04 Thread Eric Anholt
This means that GLX buffer sharing of these no longer works. On the other hand, just *look* at this code reduction. --- src/mesa/drivers/dri/intel/intel_context.c | 572 +--- src/mesa/drivers/dri/intel/intel_screen.c | 16 +- src/mesa/drivers/dri/intel/intel_screen.h

[Mesa-dev] [PATCH 4/6] intel: Replace the non-getBuffersWithFormat compat path with an error message.

2012-07-04 Thread Eric Anholt
It's been broken (using NULL getBuffersWithFormat() instead of getBuffers()) due to a copy and paste error for a year now. GetBuffersWithFormat has been around since 2009, so I don't feel any guilt in not supporting it. --- src/mesa/drivers/dri/intel/intel_context.c | 21 - s

[Mesa-dev] Private window system depth/stencil buffers

2012-07-04 Thread Eric Anholt
We've been talking about doing this for a long time -- ignore the piece of the GLX spec about clients sharing auxiliary buffers across address spaces, and just allocate our own buffers. Ever since HiZ we think it's probably been broken, and it was probably just going to get worse with window syste

[Mesa-dev] [PATCH 3/6] intel: Remove dead intel_framebuffer_has_hiz().

2012-07-04 Thread Eric Anholt
--- src/mesa/drivers/dri/intel/intel_fbo.c |9 - src/mesa/drivers/dri/intel/intel_fbo.h |4 2 files changed, 13 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c b/src/mesa/drivers/dri/intel/intel_fbo.c index 99fee9d..e14e65e 100644 --- a/src/mesa/drivers/dri/

[Mesa-dev] [PATCH 1/6] intel: Add a function for creating a private window system buffer.

2012-07-04 Thread Eric Anholt
--- src/mesa/drivers/dri/intel/intel_fbo.c | 19 +-- src/mesa/drivers/dri/intel/intel_fbo.h |3 +++ 2 files changed, 20 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/dri/intel/intel_fbo.c b/src/mesa/drivers/dri/intel/intel_fbo.c index a801bb7..99fee9d 100644 -

Re: [Mesa-dev] [PATCH 1/3] draw: draw_get_shader_param should return correct values WRT llvm

2012-07-04 Thread Olivier Galibert
On Wed, Jul 04, 2012 at 01:59:44PM +0200, Marek Ol??ák wrote: > Please disregard patch 1 and 2. It wouldn't work. What's wrong with them? > I still plan to commit patch 3. Patch 3 makes sense. I probably should have done it like that in the first place (learned a lot since :-). OG.

Re: [Mesa-dev] powerpc / gallium/drivers/llvmpipe segfaults running lp_test_* tests

2012-07-04 Thread Jose Fonseca
- Original Message - > On Tue, 2012-07-03 at 16:07 -0500, Will Schmidt wrote: > > (gdb) info reg r3 > > r3 0xfffb7f6001017590977429520 > > (gdb) info reg r10 > > r100x7c0802a6f8010010 8937396376665391120 > > BenH points out to me that r10 value looks like

Re: [Mesa-dev] [PATCH 1/3] draw: draw_get_shader_param should return correct values WRT llvm

2012-07-04 Thread Marek Olšák
Please disregard patch 1 and 2. It wouldn't work. I still plan to commit patch 3. Marek On Wed, Jul 4, 2012 at 2:35 AM, Marek Olšák wrote: > --- > src/gallium/auxiliary/draw/draw_context.c | 34 ++-- > src/gallium/auxiliary/draw/draw_context.h | 13 +- > 2 fi

Re: [Mesa-dev] [PATCH] softpipe: check if we use llvm before calling draw_get_shader_param

2012-07-04 Thread Marek Olšák
On Wed, Jul 4, 2012 at 12:07 PM, Jose Fonseca wrote: > Shouldn't draw call tgsi_exec_get_shader_param internally instead when it > LLVM is not used? We can't really know if LLVM is used because we don't have access to draw_context in get_shader_param. Anyway, I take the patch back, because I do

Re: [Mesa-dev] [PATCH] softpipe: check if we use llvm before calling draw_get_shader_param

2012-07-04 Thread Jose Fonseca
Shouldn't draw call tgsi_exec_get_shader_param internally instead when it LLVM is not used? Jose - Original Message - > draw_get_shader_param returns correct CAPs if Draw was created using > draw_create. > > tgsi_exec_get_shader_param should be used if draw_create_no_llvm was > used. >

Re: [Mesa-dev] [PATCH] st_program.c: gl_ClipDistance must be interpolated in 3d space.

2012-07-04 Thread Jose Fonseca
Committed. Thanks for the patch, Oliver, and everybody else for their feedback. Jose - Original Message - > That old bug was hidden but the clipper always interpolating in 3d > space no matter what it should have been doing. Now that the > interpolation has been fixed, the bug shows up.