Re: [Mesa-dev] [PATCH 2/2] mesa: glsl: allow ES2 to report support for GLSL versions >= 1.20

2012-05-25 Thread Oliver McFadden
On Fri, May 25, 2012 at 01:13:13PM -0700, Eric Anholt wrote: > On Fri, 25 May 2012 16:16:30 +0300, Oliver McFadden > wrote: > > This bug was discovered while running the Khronos conformance test suite > > on i965 classic driver and receiving "implementation error: meta program > > compile failed.

Re: [Mesa-dev] [PATCH] i830_state:i830Enable(): Fix crash for GL_STENCIL_TEST

2012-05-25 Thread Kurt Roeckx
Can someone please review and commit this? A lot of the piglit tests fail because of this. Kurt On Fri, May 11, 2012 at 12:19:42AM +0200, Kurt Roeckx wrote: > commit 87f12bb2d95236c7b025d1a8be56b5ab1683d702 tried to fix rb->mt > being NULL, but change this case wrong. > > Note: this is a candi

Re: [Mesa-dev] [PATCH 4/6] meta: Cleanup the resources we allocate.

2012-05-25 Thread Ian Romanick
On 05/24/2012 06:29 PM, Stéphane Marchesin wrote: From: Antoine Labour When we have multiple shared contexts, and one of them is long-running, this will lead to never freeing those resources since they are shared. Instead, free them right away on context destruction since we know the other conte

Re: [Mesa-dev] [PATCH 2/6] glx: Handle a null reply in QueryVersion.

2012-05-25 Thread Ian Romanick
On 05/24/2012 06:29 PM, Stéphane Marchesin wrote: Works around crashes when X connections break. Reviewed-by: Ian Romanick This should also be tagged with: NOTE: This is a candidate for the 8.0 branch. --- src/glx/glxext.c |3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) di

Re: [Mesa-dev] [PATCH 6/6] mesa: Fix hash table leak

2012-05-25 Thread Ian Romanick
On 05/24/2012 06:29 PM, Stéphane Marchesin wrote: From: Antoine Labour When a value was replaced, the new key was strdup'd and leaked. To fix this, we modify the hash table implementation to return whether the value was replaced and free() the (now useless) duplicate string. This looks good, b

Re: [Mesa-dev] [PATCH 5/6] mesa: Free uniforms correclty.

2012-05-25 Thread Ian Romanick
On 05/24/2012 06:29 PM, Stéphane Marchesin wrote: From: Antoine Labour This is an array of uniforms, not a single one. Reviewed-by: Ian Romanick This should also be tagged with: NOTE: This is a candidate for the 8.0 branch. --- src/mesa/main/shaderobj.c |3 ++- 1 files changed, 2 i

Re: [Mesa-dev] [PATCH 2/2] mesa: glsl: allow ES2 to report support for GLSL versions >= 1.20

2012-05-25 Thread Ian Romanick
On 05/25/2012 01:13 PM, Eric Anholt wrote: On Fri, 25 May 2012 16:16:30 +0300, Oliver McFadden wrote: This bug was discovered while running the Khronos conformance test suite on i965 classic driver and receiving "implementation error: meta program compile failed." This bug was recently introd

Re: [Mesa-dev] [PATCH] mesa: Remove the generated glapi from source control, and just build it.

2012-05-25 Thread Ian Romanick
On 05/23/2012 12:45 PM, Eric Anholt wrote: Mesa already always depends on python to build. The checked in changes are not reviewed (because any trivial change rewrites the world). We also have been pushing commits between xml change and regen where at-build-time xml-generated code disagrees wit

Re: [Mesa-dev] [PATCH 2/2] mesa: glsl: allow ES2 to report support for GLSL versions >= 1.20

2012-05-25 Thread Eric Anholt
On Fri, 25 May 2012 16:16:30 +0300, Oliver McFadden wrote: > This bug was discovered while running the Khronos conformance test suite > on i965 classic driver and receiving "implementation error: meta program > compile failed." > > This bug was recently introduced by the i965 clear patch set and

Re: [Mesa-dev] [PATCH] - main/ff_fragment_shader.cpp

2012-05-25 Thread Eric Anholt
On Fri, 25 May 2012 10:51:31 -0700, Han Shen(沈涵) wrote: > Hi I am working on chromium, and while I was compiling mesa trunk > using gcc 4.7, I had to add explicit type cast for narrower conversion > inside the initialization list. > > Could you take a look at the patch and upstream it if it is ok

Re: [Mesa-dev] [PATCH] r600g: handle R16G16B16_FLOAT and R32G32B32_FLOAT in translate_colorswap

2012-05-25 Thread Marek Olšák
Pushed, thanks. Marek On Fri, May 25, 2012 at 4:27 PM, Kai Wasserbäch wrote: > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=50318 > > Signed-off-by: Kai Wasserbäch > --- >  Verified with a full Piglit run on my HW (see the bug). >  Thanks to Marek for pointing out b2d63860 to me! > >  In

[Mesa-dev] [Bug 50318] [r600g] Piglit: spec/ARB_texture_float/get-renderbuffer-internalformat: unsupported colorswap formats 30 and 93

2012-05-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50318 Kai changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [PATCH] - main/ff_fragment_shader.cpp

2012-05-25 Thread 沈涵
Hi I am working on chromium, and while I was compiling mesa trunk using gcc 4.7, I had to add explicit type cast for narrower conversion inside the initialization list. Could you take a look at the patch and upstream it if it is ok to you? Thanks, -Han diff --git a/src/mesa/main/ff_fragment_shade

Re: [Mesa-dev] No more make clean!

2012-05-25 Thread Dan Nicholson
On May 25, 2012 7:23 AM, "Brian Paul" wrote: > > On 05/24/2012 05:45 PM, Eric Anholt wrote: >> >> It still has the flaw that changes to source lists and Makefile.ams >> don't rebuild Makefile as often as they should. This is because our >> top-level Makefile isn't in automake, and has just a stub

[Mesa-dev] [PATCH] draw: simplify index buffer specification

2012-05-25 Thread Brian Paul
Replace draw_set_index_buffer() and draw_set_mapped_index_buffer() with draw_set_indexes() which simply takes a pointer and an index size. --- src/gallium/auxiliary/draw/draw_context.c | 30 ++ src/gallium/auxiliary/draw/draw_context.h |7 + src/gallium/au

Re: [Mesa-dev] [PATCH] gallium: add st_api feature mask to prevent advertising MS visuals

2012-05-25 Thread Roland Scheidegger
Am 25.05.2012 13:27, schrieb Christoph Bumiller: > On 25.05.2012 13:24, Christoph Bumiller wrote: >> v2: use a define for the maximum sample count >> v3: also test odd sample counts (r300 supports MS3) > > I'd only checked r500 docs which really doesn't support 3 samples (so it > seemed really no

Re: [Mesa-dev] [PATCH] gallium/targets: pass ldflags parameter to MKLIB

2012-05-25 Thread Brian Paul
On 05/23/2012 10:55 AM, Thomas Gstädtner wrote: Without passing the -ldflags parameter before $(LDFLAGS) in some cases flags will be passed to MKLIB which it does not understand. This might be -m64, -m32 or similar. Signed-off-by: Thomas Gstädtner --- src/gallium/targets/Makefile.xorg |2 +

[Mesa-dev] [Bug 50318] [r600g] Piglit: spec/ARB_texture_float/get-renderbuffer-internalformat: unsupported colorswap formats 30 and 93

2012-05-25 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=50318 --- Comment #2 from Kai 2012-05-25 07:30:16 PDT --- (In reply to comment #1) > I don't have the open driver installed right now and I don't have much time to > write code either. Just wanted to let you know, this could be easily fixed by > backp

[Mesa-dev] [PATCH] r600g: handle R16G16B16_FLOAT and R32G32B32_FLOAT in translate_colorswap

2012-05-25 Thread Kai Wasserbäch
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=50318 Signed-off-by: Kai Wasserbäch --- Verified with a full Piglit run on my HW (see the bug). Thanks to Marek for pointing out b2d63860 to me! In case you accept this patch: please commit it for me, I don't have access. src/gallium/driver

Re: [Mesa-dev] No more make clean!

2012-05-25 Thread Brian Paul
On 05/24/2012 05:45 PM, Eric Anholt wrote: It still has the flaw that changes to source lists and Makefile.ams don't rebuild Makefile as often as they should. This is because our top-level Makefile isn't in automake, and has just a stub am-refresh target. I have a series to convert that, but it

[Mesa-dev] [PATCH 12/13] clover: Add function for building a clover::module for non-TGSI targets v4

2012-05-25 Thread tstellar
From: Tom Stellard v2: -Separate IR type and LLVM triple -Do the OpenCL C->LLVM IR and linking steps for all PIPE_SHADER_IR types. v3: - Coding style fixes - Removed compatibility code for LLVM < 3.1 - Split build_module_llvm() into three functions: compile(), link(), and build_

[Mesa-dev] [PATCH 11/13] gallium: Add struct pipe_compute_program

2012-05-25 Thread tstellar
From: Tom Stellard This structure is used to pass non-TGSI programs to the drivers. clover will use this for LLVM bytecode programs. --- src/gallium/include/pipe/p_state.h |9 + 1 files changed, 9 insertions(+), 0 deletions(-) diff --git a/src/gallium/include/pipe/p_state.h b/src/

[Mesa-dev] [PATCH 10/13] clover: Remove target argument from compile_program_tgsi()

2012-05-25 Thread tstellar
From: Tom Stellard --- .../state_trackers/clover/core/compiler.hpp|3 +-- src/gallium/state_trackers/clover/core/program.cpp |2 +- .../state_trackers/clover/tgsi/compiler.cpp|3 +-- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/src/gallium/state_trac

[Mesa-dev] [PATCH 04/13] clover: Add a function for retrieving a device's preferred ir v3

2012-05-25 Thread Tom Stellard
A device now has two function for getting information about the IR it needs to return. ir_format() => returns the preferred IR ir_target() => returns the triple for the target that is understood by clang/llvm. v2: - renamed ir_target() to ir_format() - renamed llvm_triple() t

[Mesa-dev] [PATCH 03/13] gallium/compute: Add PIPE_COMPUTE_CAP_IR_TARGET v2

2012-05-25 Thread Tom Stellard
From: Francisco Jerez v2: Tom Stellard - Update CAP description --- src/gallium/docs/source/screen.rst |5 + src/gallium/include/pipe/p_defines.h |1 + 2 files changed, 6 insertions(+), 0 deletions(-) diff --git a/src/gallium/docs/source/screen.rst b/src/gallium/docs/source/scr

Re: [Mesa-dev] [PATCH] gallium: add st_api feature mask to prevent advertising MS visuals

2012-05-25 Thread Brian Paul
On 05/25/2012 05:24 AM, Christoph Bumiller wrote: v2: use a define for the maximum sample count v3: also test odd sample counts (r300 supports MS3) While multisample renderbuffers are supported by mesa, MS visuals are not, so we need a way to tell dri/st not to advertise them even if the gallium

[Mesa-dev] [PATCH 1/2] mesa: common/meta: avoid printing uninitialized bytes.

2012-05-25 Thread Oliver McFadden
Mesa 8.1-devel implementation error: meta program compile failed: �� Signed-off-by: Oliver McFadden --- src/mesa/drivers/common/meta.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/common/meta.c b/src/mesa/drivers/common/meta.c index 95336fc..316d7b

[Mesa-dev] [PATCH 2/2] mesa: glsl: allow ES2 to report support for GLSL versions >= 1.20

2012-05-25 Thread Oliver McFadden
This bug was discovered while running the Khronos conformance test suite on i965 classic driver and receiving "implementation error: meta program compile failed." This bug was recently introduced by the i965 clear patch set and would not be visible while using the GL API (only ES2 API) and only on

Re: [Mesa-dev] [PATCH 1/7] r600g: add RECIP_INT, PRED_SETE_INT to r600_bytecode_get_num_operands

2012-05-25 Thread Tom Stellard
On Fri, May 25, 2012 at 01:26:01PM +0400, Vadim Girlin wrote: > Fixes https://bugs.freedesktop.org/show_bug.cgi?id=50315 > > Tested-by: Kai Wasserbäch > Signed-off-by: Vadim Girlin For the series: Reviewed-by: Tom Stellard > --- > src/gallium/drivers/r600/r600_asm.c |2 ++ > 1 file chan

[Mesa-dev] help

2012-05-25 Thread Westermann Fu
-Original Message- From: mesa-dev-requ...@lists.freedesktop.org Sent: 25 May 2012 09:32:33 GMT To: mesa-dev@lists.freedesktop.org Subject: mesa-dev Digest, Vol 26, Issue 165 Send mesa-dev mailing list submissions to mesa-dev@lists.freedesktop.org To subscribe or unsubscribe via

Re: [Mesa-dev] [PATCH] gallium: add st_api feature mask to prevent advertising MS visuals

2012-05-25 Thread Christoph Bumiller
On 25.05.2012 13:24, Christoph Bumiller wrote: > v2: use a define for the maximum sample count > v3: also test odd sample counts (r300 supports MS3) I'd only checked r500 docs which really doesn't support 3 samples (so it seemed really no hw supported an odd number), but r300 seems to after all, s

[Mesa-dev] [PATCH] gallium: add st_api feature mask to prevent advertising MS visuals

2012-05-25 Thread Christoph Bumiller
v2: use a define for the maximum sample count v3: also test odd sample counts (r300 supports MS3) While multisample renderbuffers are supported by mesa, MS visuals are not, so we need a way to tell dri/st not to advertise them even if the gallium driver does support multisampled surfaces. Otherwi

[Mesa-dev] [PATCH] gallium: add st_api feature mask to prevent advertising MS visuals

2012-05-25 Thread Christoph Bumiller
v2: use a define for the maximum sample count While multisample renderbuffers are supported by mesa, MS visuals are not, so we need a way to tell dri/st not to advertise them even if the gallium driver does support multisampled surfaces. Otherwise applications selecting these non-functional visua

[Mesa-dev] [PATCH 7/7] Revert "r600g: set round_mode to truncate and get rid of tgsi_f2i on evergreen"

2012-05-25 Thread Vadim Girlin
This reverts commit 60bf0f05b472e66bf1175fcec7a274dab6f7e2a3. It seems round_mode behaves differently in some cases depending on the instruction/slot. Reverting it for now. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=50232 Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/evergr

[Mesa-dev] [PATCH 6/7] radeon/llvm: add FLT_TO_UINT, UINT_TO_FLT instructions

2012-05-25 Thread Vadim Girlin
Signed-off-by: Vadim Girlin --- src/gallium/drivers/radeon/R600Instructions.td | 20 1 file changed, 20 insertions(+) diff --git a/src/gallium/drivers/radeon/R600Instructions.td b/src/gallium/drivers/radeon/R600Instructions.td index 04f49cd..b6b9fe0 100644 --- a/src/galli

[Mesa-dev] [PATCH 5/7] radeon/llvm: prepare to revert the round mode state to default

2012-05-25 Thread Vadim Girlin
Use TRUNC before FLT_TO_INT on evergreen/cayman. Signed-off-by: Vadim Girlin --- src/gallium/drivers/radeon/R600Instructions.td | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/R600Instructions.td b/src/gallium/drivers/radeon/R600Instr

[Mesa-dev] [PATCH 4/7] radeon/llvm: fix sampler index in llvm_emit_tex

2012-05-25 Thread Vadim Girlin
Sampler index isn't a second source operand for some tgsi texture instructions. Fixes https://bugs.freedesktop.org/show_bug.cgi?id=50230 Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_llvm.c |6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/

[Mesa-dev] [PATCH 3/7] radeon/llvm: fix opcode for RECIP_UINT_r600

2012-05-25 Thread Vadim Girlin
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=50312 Tested-by: Kai Wasserbäch Signed-off-by: Vadim Girlin --- src/gallium/drivers/radeon/R600Instructions.td |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/radeon/R600Instructions.td b/src/gallium/

[Mesa-dev] [PATCH 2/7] radeon/llvm/loader: convert hardcoded gpu name to option

2012-05-25 Thread Vadim Girlin
Signed-off-by: Vadim Girlin --- src/gallium/drivers/radeon/loader.cpp |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/radeon/loader.cpp b/src/gallium/drivers/radeon/loader.cpp index 79348d5..3ea8cd8 100644 --- a/src/gallium/drivers/radeon/loader.cp

[Mesa-dev] [PATCH 1/7] r600g: add RECIP_INT, PRED_SETE_INT to r600_bytecode_get_num_operands

2012-05-25 Thread Vadim Girlin
Fixes https://bugs.freedesktop.org/show_bug.cgi?id=50315 Tested-by: Kai Wasserbäch Signed-off-by: Vadim Girlin --- src/gallium/drivers/r600/r600_asm.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/src/gallium/drivers/r600/r600_asm.c b/src/gallium/drivers/r600/r600_asm.c index b73bbb

Re: [Mesa-dev] [PATCH 1/1] mesa: meta_glsl_clear_init() use of "out" is not compatible with ES2.0.

2012-05-25 Thread Oliver McFadden
On Fri, May 25, 2012 at 11:18:07AM +0300, Oliver McFadden wrote: > Discovered by Eric Anholt's recent changes to the i965 driver GL clear > logic while executing some of the Khronos conformance tests. Oops. I didn't fix this completely; please ignore while I roll a new patch. > > Signed-off-by:

[Mesa-dev] [PATCH 1/1] mesa: meta_glsl_clear_init() use of "out" is not compatible with ES2.0.

2012-05-25 Thread Oliver McFadden
Discovered by Eric Anholt's recent changes to the i965 driver GL clear logic while executing some of the Khronos conformance tests. Signed-off-by: Oliver McFadden --- src/mesa/drivers/common/meta.c |3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/src/mesa/drivers/common