Re: [Mesa-dev] [PATCH] drirc: Add missing XML attributes that made the driconf application whine.

2012-03-20 Thread Kenneth Graunke
On 03/20/2012 04:23 PM, Eric Anholt wrote: These are used for pretty presentation of the application name in the UI. --- src/mesa/drivers/dri/common/drirc |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/c

[Mesa-dev] [Bug 47630] sp_texture.c:322:softpipe_get_transfer: Assertion `level <= resource->last_level' failed.

2012-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47630 Kenneth Graunke changed: What|Removed |Added Status|NEW |RESOLVED Resolution|

[Mesa-dev] [Bug 47630] sp_texture.c:322:softpipe_get_transfer: Assertion `level <= resource->last_level' failed.

2012-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47630 Vinson Lee changed: What|Removed |Added CC||bri...@vmware.com --- Comment #1 from Vinso

[Mesa-dev] [Bug 47630] New: sp_texture.c:322:softpipe_get_transfer: Assertion `level <= resource->last_level' failed.

2012-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47630 Bug #: 47630 Summary: sp_texture.c:322:softpipe_get_transfer: Assertion `level <= resource->last_level' failed. Classification: Unclassified Product: Mesa Version: git

Re: [Mesa-dev] [PATCH 1/2] glsl: propagate MaxUnrollIterations to the optimizer's loop unroller

2012-03-20 Thread Kenneth Graunke
On 03/20/2012 04:44 PM, Brian Paul wrote: Instead of the hard-coded value of 32. Note that MaxUnrollIterations defaults to 32 so there's no net change. But the gallium state tracker can override this. --- src/glsl/linker.cpp |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff

Re: [Mesa-dev] [PATCH] glx:dri_common.c: check psc->driScreen->createDrawable return value

2012-03-20 Thread Yuanhan Liu
On Tue, Mar 20, 2012 at 05:24:06PM +0800, Wang YanQing wrote: > On Tue, Mar 20, 2012 at 08:49:25AM +0100, Michel Dänzer wrote: > > > Please use one of the *MessageF() functions instead of fprintf directly. > > createDrawable may return NULL value, we should check it, or it will > make a segment f

Re: [Mesa-dev] [PATCH 3/6] intel: Handle devid overrides using libdrm.

2012-03-20 Thread Yuanhan Liu
On Tue, Mar 20, 2012 at 10:36:24AM -0700, Eric Anholt wrote: > On Mon, 19 Mar 2012 09:38:03 +0800, Yuanhan Liu > wrote: > > On Fri, Mar 16, 2012 at 04:26:43PM -0700, Eric Anholt wrote: > > > --- > > > src/mesa/drivers/dri/intel/intel_screen.c | 23 --- > > > 1 files changed

Re: [Mesa-dev] [PATCH 6/7] mesa: Skip looking at debug environment variables when setuid.

2012-03-20 Thread Jose Fonseca
- Original Message - > On 03/20/2012 03:23 PM, Eric Anholt wrote: > > On Thu, 8 Mar 2012 13:37:46 -0800 (PST), Jose > > Fonseca wrote: > >> FWIW, I think that debug builds of Mesa should allow debugging > >> options > >> all the time. Secure installs should use release builds. > >> > >>

[Mesa-dev] [PATCH 2/2] st/mesa: set MaxUnrollIterations = 64

2012-03-20 Thread Brian Paul
The default was 32 for the EmitNoLoops=0 case. This allows the oZone3D soft shadows test to work properly with the vmware driver. --- src/mesa/state_tracker/st_extensions.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa

[Mesa-dev] [PATCH 1/2] glsl: propagate MaxUnrollIterations to the optimizer's loop unroller

2012-03-20 Thread Brian Paul
Instead of the hard-coded value of 32. Note that MaxUnrollIterations defaults to 32 so there's no net change. But the gallium state tracker can override this. --- src/glsl/linker.cpp |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker

Re: [Mesa-dev] [PATCH] glx: Fix glXGetProcAddress() of global glX symbols post-automake conversion.

2012-03-20 Thread Matt Turner
On Tue, Mar 20, 2012 at 5:07 PM, Eric Anholt wrote: > When a GL LD_PRELOAD library like apitrace was used, > glXGetProcAddress() would return the preload's symbols instead of > libGL's symbol, leading to infinite recursion when the returned > function was called.  This didn't hit apitrace on most

[Mesa-dev] [PATCH] drirc: Add missing XML attributes that made the driconf application whine.

2012-03-20 Thread Eric Anholt
These are used for pretty presentation of the application name in the UI. --- src/mesa/drivers/dri/common/drirc |8 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/mesa/drivers/dri/common/drirc b/src/mesa/drivers/dri/common/drirc index 755174a..2d92878 100644 --- a

Re: [Mesa-dev] New libdrm features: AUB dump and unsynced maps.

2012-03-20 Thread Kenneth Graunke
On 03/16/2012 04:26 PM, Eric Anholt wrote: Here's the series of code I'd been delaying for the new libdrm release I just pushed out. The unsynchronized maps have been seen here before but didn't get much review, so I'm giving them another chance. For the series: Reviewed-by: Kenneth Graunke

Re: [Mesa-dev] [PATCH 6/7] mesa: Skip looking at debug environment variables when setuid.

2012-03-20 Thread Kenneth Graunke
On 03/20/2012 03:23 PM, Eric Anholt wrote: On Thu, 8 Mar 2012 13:37:46 -0800 (PST), Jose Fonseca wrote: FWIW, I think that debug builds of Mesa should allow debugging options all the time. Secure installs should use release builds. The added code lines are not portable, so they need to be com

Re: [Mesa-dev] [PATCH 6/7] mesa: Skip looking at debug environment variables when setuid.

2012-03-20 Thread Eric Anholt
On Thu, 8 Mar 2012 13:37:46 -0800 (PST), Jose Fonseca wrote: > FWIW, I think that debug builds of Mesa should allow debugging options > all the time. Secure installs should use release builds. > > The added code lines are not portable, so they need to be compiled > conditionally . At least #if !

Re: [Mesa-dev] [PATCH 5/8] i965: Set "Stencil Buffer Enable" bit on Haswell.

2012-03-20 Thread Eric Anholt
On Mon, 19 Mar 2012 14:10:42 -0700, Kenneth Graunke wrote: > Signed-off-by: Kenneth Graunke This and the next patch could use some brw_defines.h #define love instead of bare bitshifting. Other than that, Reviewed-by: Eric Anholt pgpf0Lz6r6TcU.pgp Description: PGP signature

[Mesa-dev] [PATCH] glx: Fix glXGetProcAddress() of global glX symbols post-automake conversion.

2012-03-20 Thread Eric Anholt
When a GL LD_PRELOAD library like apitrace was used, glXGetProcAddress() would return the preload's symbols instead of libGL's symbol, leading to infinite recursion when the returned function was called. This didn't hit apitrace on most apps because who calls glXGetProcAddress() on the global func

[Mesa-dev] [Bug 47607] [advocacy] Make Anomaly Warzone Earth work with Mesa

2012-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47607 --- Comment #1 from Kenneth Graunke 2012-03-20 13:26:57 PDT --- (In reply to comment #0) > • GLSL in the game fails to compile: "error: no matching function for call to > `texture2DLod(sampler2D, vec2, float)'" this is out of spec behaviour, but

[Mesa-dev] [Bug 47607] New: [advocacy] Make Anomaly Warzone Earth work with Mesa

2012-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47607 Bug #: 47607 Summary: [advocacy] Make Anomaly Warzone Earth work with Mesa Classification: Unclassified Product: Mesa Version: unspecified Platform: Other URL: http://forum

[Mesa-dev] [PATCH 5/5] glsl: Make ir_dereference_variable ctor assert the variable exists.

2012-03-20 Thread Kenneth Graunke
This also seems like a bad idea. There were too many instances for me to thoroughly scan the code as I did with the last two patches, but a quick scan indicated that most callers newly allocate a variable, dereference it, or NULL-check. In some cases, it wasn't clear that the value would be non-N

[Mesa-dev] [PATCH 4/5] glsl: Explicitly NULL-check variables before making a dereference.

2012-03-20 Thread Kenneth Graunke
The constructor currently returns a ir_dereference_variable of error type when provided NULL, but that's about to change in the next commit. Signed-off-by: Kenneth Graunke --- src/glsl/ast_to_hir.cpp |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/glsl/ast_to_hir.

[Mesa-dev] [PATCH 3/5] glsl: Make ir_dereference_record constructor assert the variable exists.

2012-03-20 Thread Kenneth Graunke
Providing a NULL pointer to the ir_dereference_record() constructor seems like a bad idea. Currently, if provided NULL, it returns a partially constructed value of error type. However, none of the callers are prepared to handle that scenario. Code inspection shows that all callers do one of the

[Mesa-dev] [PATCH 2/5] glsl: Make ir_dereference_array constructor assert the variable exists.

2012-03-20 Thread Kenneth Graunke
Providing a NULL pointer to the ir_dereference_array() constructor seems like a bad idea. Currently, if provided NULL, it returns a partially constructed value of error type. However, none of the callers are prepared to handle that scenario. Code inspection shows that all callers do one of the f

[Mesa-dev] [PATCH 1/5] glsl: Comment that expression flattening is used for matrix operations.

2012-03-20 Thread Kenneth Graunke
Signed-off-by: Kenneth Graunke --- src/glsl/ir_expression_flattening.cpp |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/src/glsl/ir_expression_flattening.cpp b/src/glsl/ir_expression_flattening.cpp index 0b7c537..bd4ac67 100644 --- a/src/glsl/ir_expression_flattenin

Re: [Mesa-dev] [PATCH] glsl: Don't require gl_Position to be written in GLSL 1.40.

2012-03-20 Thread Kenneth Graunke
On 03/19/2012 11:05 PM, Eric Anholt wrote: --- src/glsl/linker.cpp | 35 ++- 1 files changed, 30 insertions(+), 5 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 39169aa..471525e 100644 --- a/src/glsl/linker.cpp +++ b/src/glsl/linker

[Mesa-dev] [Bug 47478] [wine] Passing 0xffffffff as GLX_DRAWABLE_TYPE

2012-03-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=47478 Ian Romanick changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|mesa-dev@list

Re: [Mesa-dev] [PATCH] glsl: Don't require gl_Position to be written in GLSL 1.40.

2012-03-20 Thread Ian Romanick
On 03/19/2012 11:05 PM, Eric Anholt wrote: Reviewed-by: Ian Romanick --- src/glsl/linker.cpp | 35 ++- 1 files changed, 30 insertions(+), 5 deletions(-) diff --git a/src/glsl/linker.cpp b/src/glsl/linker.cpp index 39169aa..471525e 100644 --- a/src/glsl/lin

Re: [Mesa-dev] [PATCH 1/6] glx: Convert to automake.

2012-03-20 Thread Eric Anholt
On Mon, 19 Mar 2012 18:32:57 -0400, Matt Turner wrote: > On Wed, Feb 8, 2012 at 9:09 PM, Eric Anholt wrote: > This piece looks odd. If we've got shared glapi, we're linking in both > shared and static glapi. I tried removing $(GLAPI_LIB) from this, and > it did shrink libGL from 2.3 -> 1.8 MB, b

Re: [Mesa-dev] [PATCH 3/6] intel: Handle devid overrides using libdrm.

2012-03-20 Thread Eric Anholt
On Mon, 19 Mar 2012 09:38:03 +0800, Yuanhan Liu wrote: > On Fri, Mar 16, 2012 at 04:26:43PM -0700, Eric Anholt wrote: > > --- > > src/mesa/drivers/dri/intel/intel_screen.c | 23 --- > > 1 files changed, 4 insertions(+), 19 deletions(-) > > > > diff --git a/src/mesa/drivers

[Mesa-dev] [PATCH] mesa: only test cube face widths in _mesa_test_texobj_completeness()

2012-03-20 Thread Brian Paul
As Eric pointed out, we know the cube faces are square at this point so we only need to test the texture widths for consistency. --- src/mesa/main/texobj.c | 13 - 1 files changed, 8 insertions(+), 5 deletions(-) diff --git a/src/mesa/main/texobj.c b/src/mesa/main/texobj.c index d64

[Mesa-dev] [PATCH] mesa: Include mesa ES mapi generated files

2012-03-20 Thread Jakob Bornecrantz
Hi, all This puts the generated mapi files into the tarball, as requested by Jeremy Huddleston. This patch will be applied to both master and the 8.0 branches. Cheers, Jakob. Signed-off-by: Jakob Bornecrantz --- Makefile |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --g

Re: [Mesa-dev] [PATCH 08/13] mesa: rewrite/consolidate code in _mesa_test_texobj_completeness()

2012-03-20 Thread Brian Paul
On 03/20/2012 12:56 AM, Eric Anholt wrote: On Sun, 18 Mar 2012 10:49:24 -0600, Brian Paul wrote: Merge the mipmap level checking code that was separate cases for 1D, 2D, 3D and CUBE before. - if (img->_BaseFormat == GL_DEPTH_COMPONENT) { - incomplete(t, "GL_DEP

Re: [Mesa-dev] [PATCH 12/13] mesa: rework texture completeness testing

2012-03-20 Thread Brian Paul
On 03/20/2012 01:05 AM, Eric Anholt wrote: On Sun, 18 Mar 2012 10:49:28 -0600, Brian Paul wrote: -* Do mipmap consistency checking +* Do mipmap consistency checking. +* Note: we don't care about the current texture sampler state here. +* To determine texture completeness we'll e

Re: [Mesa-dev] [PATCH] shared-glapi: Convert to automake

2012-03-20 Thread Jon TURNEY
On 19/03/2012 15:50, Kristian Høgsberg wrote: > Ok, I pushed with the BUILT_SOURCES line, but didn't add -no-undefined. On 19/03/2012 19:54, Matt Turner wrote: > On Mon, Mar 19, 2012 at 3:52 PM, Jose Fonseca wrote: >> I didn't know that --no-undefined . It seems quite nice, but more for Linux >

Re: [Mesa-dev] [PATCH 1/2] st/vdpau: add VC-1 startcode if none is found in the stream

2012-03-20 Thread Christian König
On 15.03.2012 20:09, Emeric Grange wrote: As far as I know only MPEG TS uses the 0x01 start code for network synchronization purpose as you said (I'm not even sure it's really for resync). The H.264 Annex B is also the only "container format" that uses these start codes. MKV or MP4 and prob

Re: [Mesa-dev] [PATCH] glx:dri_common.c: check psc->driScreen->createDrawable return value

2012-03-20 Thread Wang YanQing
On Tue, Mar 20, 2012 at 08:49:25AM +0100, Michel Dänzer wrote: > Please use one of the *MessageF() functions instead of fprintf directly. createDrawable may return NULL value, we should check it, or it will make a segment failed. Signed-off-by: Wang YanQing --- src/glx/dri_common.c |6

Re: [Mesa-dev] [PATCH] glx:dri_common.c: check psc->driScreen->createDrawable return value

2012-03-20 Thread Michel Dänzer
On Die, 2012-03-20 at 11:49 +0800, Wang YanQing wrote: > createDrawable may return NULL value, we should check it, or it will > make a segment failed. > > Signed-off-by: Wang YanQing > --- > src/glx/dri_common.c |6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/src/glx/dri_comm

[Mesa-dev] [PATCH] glx:dri_common.c: check psc->driScreen->createDrawable return value

2012-03-20 Thread Wang YanQing
createDrawable may return NULL value, we should check it, or it will make a segment failed. Signed-off-by: Wang YanQing --- src/glx/dri_common.c |6 ++ 1 file changed, 6 insertions(+) diff --git a/src/glx/dri_common.c b/src/glx/dri_common.c index e7dba5a..6122d32 100644 --- a/src/glx/d

Re: [Mesa-dev] [PATCH 01/13] mesa: make _mesa_reference_sampler_object() an inline function

2012-03-20 Thread Eric Anholt
On Sun, 18 Mar 2012 10:49:17 -0600, Brian Paul wrote: > To make the no-change case faster, as we do for the other object-reference > functions. Other than the couple of minor comments I had, this series is: Reviewed-by: Eric Anholt pgpN6Ij1UOxSy.pgp Description: PGP signature

Re: [Mesa-dev] [PATCH 12/13] mesa: rework texture completeness testing

2012-03-20 Thread Eric Anholt
On Sun, 18 Mar 2012 10:49:28 -0600, Brian Paul wrote: > -* Do mipmap consistency checking > +* Do mipmap consistency checking. > +* Note: we don't care about the current texture sampler state here. > +* To determine texture completeness we'll either look at _BaseComplete > +* o