Fix this GCC warning on non-debug builds.
glsl_types.cpp: In member function 'gl_texture_index
glsl_type::sampler_index() const':
glsl_types.cpp:157: warning: control reaches end of non-void function
Signed-off-by: Vinson Lee
---
src/glsl/glsl_types.cpp |4 ++--
1 files changed, 2 insertions
Now that we no longer generate Mesa IR from GLSL IR, it's impossible to
use the old vertex shader backend for GLSL programs. There's simply no
Mesa IR to codegen from.
Any attempt to do so would result in immediate GPU hangs, presumably due
to the driver uploading an empty program with no EOT mes
On Mon, Jan 16, 2012 at 4:31 PM, Ian Romanick wrote:
> On 01/16/2012 01:30 PM, Brian Paul wrote:
>>
>>
>> The renderbuffer-cleanups-v2 branch removes all the old swrast
>> GetRow/PutRow stuff. All swrast rendering is now done through
>> renderbuffer mapping and the format_pack/unpack.c code.
>
>
>
Hi Jerome,
I skimmed over the patches and how libdrm interacts with r600g and it
looks good.
We don't generally include DRM-specific headers in radeon_winsys.h,
because that header is supposed to be cross-platform, but I guess we
can make an exception in this case as long as we keep radeon_surfac
On Mon 16 Jan 2012 03:59:05 PM PST, Christian Inci wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> Hello @all,
>
> wouldn't it be better to return if intel is NULL instead, as there's nothing
> after the if statement?
> (At least you wouldn't need to indent the code then.)
I agree. I'
https://bugs.freedesktop.org/show_bug.cgi?id=41221
Ian Romanick changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
Anuj, when a bugfix like this can be backported to a stable branch, please
annotate the commit message with
Note: This is a candidate for the X.X branch
or
Note: This is a candidate for the stable branches.
This helps the stable branch maintainer automate the backport
process.
Thanks,
Cha
TestMipMaps() function in src/OGLconform/textureNPOT.c calls glTexImage2D()
with width = 0. Texture with zero size skips miptree allocation due to a
condition in function _mesa_store_teximage3d(). While calling glGetTexImage()
it results in assertion failure in intel_map_texture_image() due to null
On 01/16/2012 10:38 AM, Kenneth Graunke wrote:
According to Table 6.8 (Page 348) in the OpenGL 3.0 specification,
glGetVertexAttribfv supports GL_VERTEX_ATTRIB_ARRAY_INTEGER.
Signed-off-by: Kenneth Graunke
This patch indirectly affects the oglc depth-tex test (which tries to
use this function
https://bugs.freedesktop.org/show_bug.cgi?id=44757
--- Comment #2 from almos 2012-01-16 16:16:27 PST ---
Created attachment 55654
--> https://bugs.freedesktop.org/attachment.cgi?id=55654
trianglestrip.txt
I found the problematic triangle for detail=7. The ball geometry is created by
building a
On 01/13/2012 04:57 PM, Chad Versace wrote:
Nothing works if HiZ is enabled and the DDX is incapable of HiZ (that is,
the DDX version is< 2.16).
The problem is that the refactoring that eliminated
intel_renderbuffer::stencil_rb broke the recovery path in
intel_verify_dri2_has_hiz(). Specifical
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hello @all,
wouldn't it be better to return if intel is NULL instead, as there's nothing
after the if statement?
(At least you wouldn't need to indent the code then.)
Kind regards,
Christian Inci
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.18
ping?
On Thu, Dec 22, 2011 at 4:34 PM, nob...@dreamwidth.org wrote:
> The error was erroneously removed in this commit:
>
> 719909698c67c287a393d2380278e7b7495ae018
> "mesa: Rewrite the way uniforms are tracked and handled"
>
> You also aren't even supposed to truncate the output to 'bufSize',
> s
The Haiku swrast driver is out of tree and this causes issues.
---
scons/gallium.py |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/scons/gallium.py b/scons/gallium.py
index 5a0c6fe..86adc3e 100755
--- a/scons/gallium.py
+++ b/scons/gallium.py
@@ -350,7 +350,7 @@ def g
Noticed this was missing when writing the "glapi: sort ARB extensions
by number" commit, which at least shows it was effective.
---
.../glapi/gen/ARB_texture_compression_rgtc.xml | 15 +++
src/mapi/glapi/gen/Makefile|1 +
src/mapi/glapi/gen/gl_API.xml
Noticed it was missing based on the lack of a descriptive enum
name from this bug's error message:
https://bugs.freedesktop.org/show_bug.cgi?id=44039
This moves two enums out of GL3x.xml. Though since this and
GL_ARB_texture_compression_rgtc are both strict subsets of GL3,
both extensions could h
And add comments to fill in for extensions that aren't there.
Noticed the comment about "ARB extensions sorted by extension number"
didn't extend to the directives when it became clear
GL_ARB_texture_rg was missing, going by the error message seen here:
https://bugs.freedesktop.org/show_bug.cgi?
glGetTexImage, for example, has no width/height/depth parameters.
Also, copy some missing parameter info from the original versions
of certain functions over to their ARB_robustness counterparts.
---
src/mapi/glapi/gen/ARB_robustness.xml | 26 +-
src/mapi/glapi/gen/gl_AP
On Tue, 2012-01-17 at 02:46 +0400, Vadim Girlin wrote:
> ---
> src/gallium/drivers/r600/r600_asm.c|2 +
> src/gallium/drivers/r600/r600_shader.c | 1010
> +++-
> 2 files changed, 871 insertions(+), 141 deletions(-)
Please ignore this patch, there is a bug not
On 01/16/2012 10:38 AM, Kenneth Graunke wrote:
> According to Table 6.8 (Page 348) in the OpenGL 3.0 specification,
> glGetVertexAttribfv supports GL_VERTEX_ATTRIB_ARRAY_INTEGER.
>
> Signed-off-by: Kenneth Graunke
> ---
> src/mesa/main/varray.c |2 +-
> 1 files changed, 1 insertions(+), 1 de
On 01/16/2012 01:30 PM, Brian Paul wrote:
The renderbuffer-cleanups-v2 branch removes all the old swrast
GetRow/PutRow stuff. All swrast rendering is now done through
renderbuffer mapping and the format_pack/unpack.c code.
Woo hoo! Thanks for tackling this! I've been slowly putting bandaids
---
src/gallium/drivers/r600/r600_asm.c|2 +
src/gallium/drivers/r600/r600_shader.c | 1010 +++-
2 files changed, 871 insertions(+), 141 deletions(-)
diff --git a/src/gallium/drivers/r600/r600_asm.c
b/src/gallium/drivers/r600/r600_asm.c
index 23350e2..7c76bd5
---
src/gallium/drivers/r600/r600_shader.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/drivers/r600/r600_shader.c
b/src/gallium/drivers/r600/r600_shader.c
index 9d15d02..701bb03 100644
--- a/src/gallium/drivers/r600/r600_shader.c
+++ b/src/gallium/drive
On 01/16/2012 02:30 PM, Brian Paul wrote:
The renderbuffer-cleanups-v2 branch removes all the old swrast
GetRow/PutRow stuff. All swrast rendering is now done through
renderbuffer mapping and the format_pack/unpack.c code.
The gl_renderbuffer type is smaller and cleaner now. Plus, a few more
ol
On 01/16/2012 12:51 PM, Anuj Phogat wrote:
TestMipMaps() function in src/OGLconform/textureNPOT.c calls glTexImage2D()
with width = 0. Texture with zero image width skips miptree allocation due to
a condition in function _mesa_store_teximage3d(). While calling glGetTexImage()
it results in assert
https://bugs.freedesktop.org/show_bug.cgi?id=44844
Brian Paul changed:
What|Removed |Added
Status|NEW |RESOLVED
Resolution|
On 01/16/2012 02:08 PM, Vinson Lee wrote:
Fix this GCC warning with non-LLVM builds.
sp_screen.c: In function ‘softpipe_get_shader_param’:
sp_screen.c:141:28: warning: unused variable ‘sp_screen’ [-Wunused-variable]
Signed-off-by: Vinson Lee
---
src/gallium/drivers/softpipe/sp_screen.c |2
https://bugs.freedesktop.org/show_bug.cgi?id=44844
Bug #: 44844
Summary: Misspelled color "lighgrey" in GLwDrawA.c
Classification: Unclassified
Product: Mesa
Version: 7.11
Platform: x86 (IA32)
OS/Version: All
Status: N
The renderbuffer-cleanups-v2 branch removes all the old swrast
GetRow/PutRow stuff. All swrast rendering is now done through
renderbuffer mapping and the format_pack/unpack.c code.
The gl_renderbuffer type is smaller and cleaner now. Plus, a few more
old driver hooks are removed.
There's
Fix this GCC warning with non-LLVM builds.
sp_screen.c: In function ‘softpipe_get_shader_param’:
sp_screen.c:141:28: warning: unused variable ‘sp_screen’ [-Wunused-variable]
Signed-off-by: Vinson Lee
---
src/gallium/drivers/softpipe/sp_screen.c |2 ++
1 files changed, 2 insertions(+), 0 dele
https://bugs.freedesktop.org/show_bug.cgi?id=44039
--- Comment #6 from Roland Scheidegger 2012-01-16 12:57:26
PST ---
(In reply to comment #5)
> We didn't already do this because the OpenGL 3.0 spec requires that GL_R32F be
> 32-bit float. Ken dug into this a bit, and the problem is that GEN4 c
>
> That is, lp_bld_arit.c functions such as lp_build_add() are be confident that
> passed the values and types are consistent, and all assertions to test that
> should be preserved.
>
> I hope this makes sense.
Thanks Jose, this seems sensible and I'll try and go in that
direction, some issues
https://bugs.freedesktop.org/show_bug.cgi?id=44039
--- Comment #5 from Ian Romanick 2012-01-16 12:00:58 PST
---
(In reply to comment #4)
> OK, I think I see the problem. I reproduced something similar with a piglit
> test.
>
> I have a gen 4 i965 laptop. If I compile with TEXTURE_FLOAT_ENABLE
TestMipMaps() function in src/OGLconform/textureNPOT.c calls glTexImage2D()
with width = 0. Texture with zero image width skips miptree allocation due to
a condition in function _mesa_store_teximage3d(). While calling glGetTexImage()
it results in assertion failure in intel_map_texture_image() due
Looks good to me.
Jose
- Original Message -
> To try to use less tex memory and maybe get better performance.
> Spotted by Roland Scheidegger.
> ---
> src/mesa/main/texformat.c |4
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/src/mesa/main/texformat.c b/s
https://bugs.freedesktop.org/show_bug.cgi?id=44039
Ian Romanick changed:
What|Removed |Added
Blocks||42993
--
Configure bugmail: https://bugs
v2:
- Rename output_type to output_mode
- Add shorthand definitions for TGSI_OUTPUT_*
---
src/gallium/auxiliary/tgsi/tgsi_info.c | 329
src/gallium/auxiliary/tgsi/tgsi_info.h | 34
2 files changed, 201 insertions(+), 162 deletions(-)
diff --git a/src/galli
- Original Message -
> On 01/13/2012 04:29 PM, Jose Fonseca wrote:
> >
> >
> > - Original Message -
> >> On 01/12/2012 09:06 AM, Chia-I Wu wrote:
> >>> On Tue, Jan 10, 2012 at 12:55 AM, Jose
> >>> Fonseca
> >>> wrote:
>
>
> - Original Message -
> > On Fr
Should I commit this for you?
If you approve :)
-- Alexander von Gluck
On 16.01.2012 13:31, Jose Fonseca wrote:
- Original Message -
svga is close, however there is a type conflict.
Haiku defines uint32, uint8, etc by default... the svga gallium
driver
defines them as well.
I think
- Original Message -
> svga is close, however there is a type conflict.
> Haiku defines uint32, uint8, etc by default... the svga gallium
> driver
> defines them as well.
> I think it's as easy as removing the svga *int* typedefs under
> haiku... but
> haven't had the
> bandwidth to test th
Looks good to me, Vinson. Thanks
Jose
- Original Message -
> Fix this GCC warning.
> lp_test_round.c: In function ‘test_round’:
> lp_test_round.c:126:13: warning: variable ‘packed’ set but not used
> [-Wunused-but-set-variable]
>
> Signed-off-by: Vinson Lee
> ---
> src/gallium/drivers/
Looks good too.
Jose
- Original Message -
> ---
> src/gallium/auxiliary/gallivm/lp_bld_tgsi_soa.c | 219
> +++
> src/gallium/auxiliary/tgsi/tgsi_exec.h | 13 ++
> src/gallium/auxiliary/tgsi/tgsi_ppc.c | 78 -
> 3 files changed, 148 ins
Looks good.
Jose
- Original Message -
> From: Tom Stellard
>
> ---
> src/gallium/auxiliary/gallivm/lp_bld_gather.c | 17
> +
> src/gallium/auxiliary/gallivm/lp_bld_gather.h |4
> 2 files changed, 21 insertions(+), 0 deletions(-)
>
> diff --git a/src/gallium
Tom,
Looks good.
Just two minor requests:
- I think that it might be easier to read if we had shorthand definitions for
TGSI_OUTPUT_XX in tgsi_info.c so that these enums take less space and the
opcodes stay aligned. For example:
#define NONE TGSI_OUTPUT_NONE
#define COMP TGSI_OUTPUT_COM
svga is close, however there is a type conflict.
Haiku defines uint32, uint8, etc by default... the svga gallium driver
defines them as well.
I think it's as easy as removing the svga *int* typedefs under haiku... but
haven't had the
bandwidth to test that yet.
llvm... well there is no llvm /
Looks good.
What's preventing src/gallium/drivers/llvmpipe and src/gallium/drivers/svga
from building on haiku? These pipe drivers should be fairly portable (unlike
src/gallium/winsys or src/gallium/targets dirs).
Jose
- Original Message -
>
> Enables building stock Mesa under the Ha
Enables building stock Mesa under the Haiku operating system.
---
common.py |2 +-
scons/gallium.py |2 ++
src/SConscript |5 +++--
src/gallium/SConscript | 14 ++
src/glu/sgi/SConscript | 16 +++-
5 files changed, 27 insertions(
According to Table 6.8 (Page 348) in the OpenGL 3.0 specification,
glGetVertexAttribfv supports GL_VERTEX_ATTRIB_ARRAY_INTEGER.
Signed-off-by: Kenneth Graunke
---
src/mesa/main/varray.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/mesa/main/varray.c b/src/mesa/ma
Hi Dave,
Thanks for looking at this.
The gist is there, but I'd prefer that the ambiguity of "ints encoded as
floats" stayed contained inside lp_bld_tgsi_* and never bleeds into
lp_bld_arith or other generic LLVM emiting helper functions. That is, when
lp_bld_arith and other functions are cal
- Original Message -
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 16.01.2012 08:13, Vinson Lee wrote:
> > Fix this GCC 4.6 warning with 64-bit builds. u_debug_stack.c: In
> > function ‘debug_backtrace_capture’: u_debug_stack.c:45:17: warning:
> > variable ‘frame_pointer’ set
Looks good Brian.
Maybe MESA_FORMAT_RGBA_FLOAT16 should probably be before MESA_FORMAT_RG_FLOAT32
for GL_R16F/GL_RG16F -- same memory footprint, but exact rounding -- but I
doubt it matters much either way.
Jose
- Original Message -
> The i965 driver advertises GL_ARB_texture_float and
To try to use less tex memory and maybe get better performance.
Spotted by Roland Scheidegger.
---
src/mesa/main/texformat.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/src/mesa/main/texformat.c b/src/mesa/main/texformat.c
index d393873..259eb90 100644
--- a/src/mes
The i965 driver advertises GL_ARB_texture_float and GL_ARB_texture_rg
support but the ctx->TextureFormatSupported[] table entries for
MESA_FORMAT_R_FLOAT32 and MESA_FORMAT_RGBA_FLOAT32 are false on gen 4
hardware. So the case for GL_R32F would fail and we'd print an
implementation error.
This pat
On 01/16/2012 09:53 AM, Roland Scheidegger wrote:
Am 16.01.2012 17:13, schrieb Brian Paul:
The i965 driver advertises GL_ARB_texture_float and GL_ARB_texture_rg
support but the ctx->TextureFormatSupported[] table entries for
MESA_FORMAT_R_FLOAT32 and MESA_FORMAT_RGBA_FLOAT32 are false on gen 4
h
On 01/16/2012 09:40 AM, Jose Fonseca wrote:
- Original Message -
The i965 driver advertises GL_ARB_texture_float and GL_ARB_texture_rg
support but the ctx->TextureFormatSupported[] table entries for
MESA_FORMAT_R_FLOAT32 and MESA_FORMAT_RGBA_FLOAT32 are false on gen 4
hardware. So the c
Am 16.01.2012 17:13, schrieb Brian Paul:
> The i965 driver advertises GL_ARB_texture_float and GL_ARB_texture_rg
> support but the ctx->TextureFormatSupported[] table entries for
> MESA_FORMAT_R_FLOAT32 and MESA_FORMAT_RGBA_FLOAT32 are false on gen 4
> hardware. So the case for GL_R32F would fail
- Original Message -
> The i965 driver advertises GL_ARB_texture_float and GL_ARB_texture_rg
> support but the ctx->TextureFormatSupported[] table entries for
> MESA_FORMAT_R_FLOAT32 and MESA_FORMAT_RGBA_FLOAT32 are false on gen 4
> hardware. So the case for GL_R32F would fail and we'd pri
On Mon, Jan 16, 2012 at 12:08:17PM +, Simon Farnsworth wrote:
> (resending due to my inability to work my e-mail client - I neither cc'd
> Jerome, nor used the correct identity, so the original appears to be held in
> moderation).
>
> On Thursday 12 January 2012, Jerome Glisse wrote:
> > Hi,
The i965 driver advertises GL_ARB_texture_float and GL_ARB_texture_rg
support but the ctx->TextureFormatSupported[] table entries for
MESA_FORMAT_R_FLOAT32 and MESA_FORMAT_RGBA_FLOAT32 are false on gen 4
hardware. So the case for GL_R32F would fail and we'd print an
implementation error.
This pat
https://bugs.freedesktop.org/show_bug.cgi?id=44039
--- Comment #4 from Brian Paul 2012-01-16 08:10:51 PST ---
OK, I think I see the problem. I reproduced something similar with a piglit
test.
I have a gen 4 i965 laptop. If I compile with TEXTURE_FLOAT_ENABLED, glxinfo
says GL_ARB_texture_float
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 16.01.2012 08:13, Vinson Lee wrote:
> Fix this GCC 4.6 warning with 64-bit builds. u_debug_stack.c: In
> function ‘debug_backtrace_capture’: u_debug_stack.c:45:17: warning:
> variable ‘frame_pointer’ set but not used
> [-Wunused-but-set-variable]
>
(resending due to my inability to work my e-mail client - I neither cc'd
Jerome, nor used the correct identity, so the original appears to be held in
moderation).
On Thursday 12 January 2012, Jerome Glisse wrote:
> Hi,
>
> I don't cross post as i am pretty sure all interested people are reading
Hi Vinson,
These lines were added by Dave in
commit 1865f341d8f45b389061fc08d2da90b7aa8a6099
Author: Dave Airlie
Date: Fri Jan 6 12:23:00 2012 +
draw: clipdistance support (v2)
Add support for using the clipdistance instead of clip plane.
Passes all piglit clipdista
Hi,
So I've been playing a bit more with integers in gallivm, but I'm not
100% sure how the original design though about incorporating them.
The lp_build_contexts seems to take a base type of a float and have
some sort of int types associated it with it, should I add more to
this struct for uints
64 matches
Mail list logo
