Re: [Mesa-dev] [PATCH] Fix _GNUC__ typo in check for gcc 3.x for _mesa_bitcount

2011-10-20 Thread Jason Wood
On 10/20/2011 06:58 PM, Alan Coopersmith wrote: Without this fix, builds with gcc 3.4.x end up depending on undefined _mesa_bitcount instead of gcc's __builtin_popcount. NOTE: This is a candidate for the stable branches. Signed-off-by: Alan Coopersmith --- src/mesa/main/imports.c |2 +-

[Mesa-dev] [PATCH] Fix _GNUC__ typo in check for gcc 3.x for _mesa_bitcount

2011-10-20 Thread Alan Coopersmith
Without this fix, builds with gcc 3.4.x end up depending on undefined _mesa_bitcount instead of gcc's __builtin_popcount. NOTE: This is a candidate for the stable branches. Signed-off-by: Alan Coopersmith --- src/mesa/main/imports.c |2 +- src/mesa/main/imports.h |2 +- 2 files changed,

Re: [Mesa-dev] [PATCH] st/mesa: Initialize variable.

2011-10-20 Thread Jakob Bornecrantz
Looks good! Reviewed-by: Jakob Bornecrantz - Original Message - > ptr is uninitialized if ib in NULL. > > Fixes Coverity uninitialized pointer read defect. > --- > src/mesa/state_tracker/st_draw.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/src/mesa/

[Mesa-dev] [PATCH] st/mesa: Initialize variable.

2011-10-20 Thread Vinson Lee
ptr is uninitialized if ib in NULL. Fixes Coverity uninitialized pointer read defect. --- src/mesa/state_tracker/st_draw.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/src/mesa/state_tracker/st_draw.c b/src/mesa/state_tracker/st_draw.c index 20ba993..a2bff04 100644 --

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-20 Thread Eric Anholt
On Thu, 20 Oct 2011 10:35:31 +0200, Michel Dänzer wrote: > On Mit, 2011-10-19 at 17:50 -0700, Eric Anholt wrote: > > So, Radeon maintainers, what do you think? And, does anyone else want > > to test it on the other drivers? I caught two bugs in my r300 testing > > (one too many lines cut in one

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-20 Thread Eric Anholt
On Thu, 20 Oct 2011 15:17:15 -0400, James Cloos wrote: > > "EA" == Eric Anholt writes: > > EA> Code to do so is at > EA> http://cgit.freedesktop.org/~anholt/mesa/log/?h=radeon-kill-dri1 > > I can test that on an r100 box (Mobility M7 LW). > > Does it need anything other than just a recompi

[Mesa-dev] [PATCH] st/mesa: fix a bug in and re-org setup_interleaved_attribs()

2011-10-20 Thread Brian Paul
From: Brian Paul We were mis-computing the size of the user-space vertex buffer in some circumstances. This led to a failed assertion at u_inlines.h:222 when using the VMware svga driver. For example, if we had arrays such as: array[0]: element_offset = 12, stride = 24 array[1]: element_offset

Re: [Mesa-dev] [PATCH] i965: Enable faster workaround-free math on Ivybridge.

2011-10-20 Thread Paul Berry
On 18 October 2011 12:24, Kenneth Graunke wrote: > According to the documentation, Ivybridge's math instruction works in > SIMD16 mode for the fragment shader, and no longer forbids align16 mode > for the vertex shader. > > The documentation claims that SIMD16 mode isn't supported for INT DIV, >

Re: [Mesa-dev] [PATCH] mesa: Skip mipmap generation if there is no source image.

2011-10-20 Thread Brian Paul
On 10/20/2011 01:23 PM, Ian Romanick wrote: On 10/17/2011 01:59 PM, Brian Paul wrote: On 10/17/2011 02:45 PM, Eric Anholt wrote: The spec doesn't explicitly mandate this behavior, but it seems like the only sensible thing to do (as opposed to assertion failing or segfaulting). Bugzilla: https:

Re: [Mesa-dev] [PATCH] mesa: Skip mipmap generation if there is no source image.

2011-10-20 Thread Ian Romanick
On 10/17/2011 01:59 PM, Brian Paul wrote: On 10/17/2011 02:45 PM, Eric Anholt wrote: The spec doesn't explicitly mandate this behavior, but it seems like the only sensible thing to do (as opposed to assertion failing or segfaulting). Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=40308

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-20 Thread James Cloos
> "EA" == Eric Anholt writes: EA> Code to do so is at EA> http://cgit.freedesktop.org/~anholt/mesa/log/?h=radeon-kill-dri1 I can test that on an r100 box (Mobility M7 LW). Does it need anything other than just a recompile of mesa from that branch? (I already run xorg and mesa master on tha

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-20 Thread Ian Romanick
On 10/20/2011 09:17 AM, Alex Deucher wrote: On Thu, Oct 20, 2011 at 12:01 PM, Alex Deucher wrote: On Wed, Oct 19, 2011 at 8:50 PM, Eric Anholt wrote: For the MapRenderbuffer() code (See http://cgit.freedesktop.org/~anholt/mesa/log/?h=rbmap for the current work, which has glReadPixels() conver

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-20 Thread Alex Deucher
On Thu, Oct 20, 2011 at 12:59 PM, Dave Airlie wrote: > On Thu, Oct 20, 2011 at 5:59 PM, Roland Scheidegger > wrote: >> Am 20.10.2011 18:10, schrieb Dave Airlie: > > So, Radeon maintainers, what do you think?  And, does anyone else want > to test it on the other drivers?  I caught two

Re: [Mesa-dev] [PATCH] mesa: Skip mipmap generation if there is no source image.

2011-10-20 Thread Eric Anholt
On Tue, 18 Oct 2011 16:56:48 -0600, Brian Paul wrote: > On 10/18/2011 04:09 PM, Eric Anholt wrote: > > The spec doesn't explicitly mandate this behavior, but it seems like > > the only sensible thing to do (as opposed to assertion failing or > > segfaulting). > > > > v2: Do the early return before

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-20 Thread Roland Scheidegger
Am 20.10.2011 18:59, schrieb Dave Airlie: > On Thu, Oct 20, 2011 at 5:59 PM, Roland Scheidegger > wrote: >> Am 20.10.2011 18:10, schrieb Dave Airlie: > > So, Radeon maintainers, what do you think? And, does anyone else want > to test it on the other drivers? I caught two bugs in my

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-20 Thread Corbin Simpson
On Thu, Oct 20, 2011 at 9:10 AM, Dave Airlie wrote: >>> >>> So, Radeon maintainers, what do you think?  And, does anyone else want >>> to test it on the other drivers?  I caught two bugs in my r300 testing >>> (one too many lines cut in one r300 commit, and I had also removed the >>> texsubimage c

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-20 Thread Dave Airlie
On Thu, Oct 20, 2011 at 5:59 PM, Roland Scheidegger wrote: > Am 20.10.2011 18:10, schrieb Dave Airlie: So, Radeon maintainers, what do you think?  And, does anyone else want to test it on the other drivers?  I caught two bugs in my r300 testing (one too many lines cut in one r3

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-20 Thread Roland Scheidegger
Am 20.10.2011 18:10, schrieb Dave Airlie: >>> >>> So, Radeon maintainers, what do you think? And, does anyone else want >>> to test it on the other drivers? I caught two bugs in my r300 testing >>> (one too many lines cut in one r300 commit, and I had also removed the >>> texsubimage code in an u

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-20 Thread Alex Deucher
On Thu, Oct 20, 2011 at 12:01 PM, Alex Deucher wrote: > On Wed, Oct 19, 2011 at 8:50 PM, Eric Anholt wrote: >> For the MapRenderbuffer() code (See >> http://cgit.freedesktop.org/~anholt/mesa/log/?h=rbmap for the current >> work, which has glReadPixels() converted so far and tested on gen6 with >>

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-20 Thread Dave Airlie
>> >> So, Radeon maintainers, what do you think?  And, does anyone else want >> to test it on the other drivers?  I caught two bugs in my r300 testing >> (one too many lines cut in one r300 commit, and I had also removed the >> texsubimage code in an unrelated-to-the-series commit, but it regressed

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-20 Thread Alex Deucher
On Wed, Oct 19, 2011 at 8:50 PM, Eric Anholt wrote: > For the MapRenderbuffer() code (See > http://cgit.freedesktop.org/~anholt/mesa/log/?h=rbmap for the current > work, which has glReadPixels() converted so far and tested on gen6 with > only one regression in the tip commit), I need to be able to

Re: [Mesa-dev] [PATCH] glsl-fs-normalmatrix: New test program for gl_NormalMatrix.

2011-10-20 Thread Eric Anholt
On Wed, 19 Oct 2011 13:15:05 -0700, Paul Berry wrote: Non-text part: multipart/alternative > On 18 October 2011 17:33, Eric Anholt wrote: > > > From: tom fogal > > > > v2: lots of hacking by anholt to make it look more like a normal > >piglit test and make all results visible at once. > > -

Re: [Mesa-dev] [PATCH] glsl: Fix gl_NormalMatrix swizzle setup to match i965's invariants.

2011-10-20 Thread Eric Anholt
On Wed, 19 Oct 2011 11:26:02 -0700, Paul Berry wrote: Non-text part: multipart/alternative > On 18 October 2011 17:33, Eric Anholt wrote: > > > A driver trying to set up builtin uniforms is faced with a problem: > > How do I walk the ir_variable structure (representing an array of > > structs, o

Re: [Mesa-dev] [PATCH 2/2] i965: use a cast to silence a signed/unsigned comparison warning

2011-10-20 Thread Eric Anholt
On Wed, 19 Oct 2011 13:24:33 -0700, Paul Berry wrote: Non-text part: multipart/alternative > On 19 October 2011 12:58, Brian Paul wrote: > > > On 10/19/2011 01:53 PM, Paul Berry wrote: > > > >> On 18 October 2011 18:07, Brian Paul >> > wrote: > >> > >>From:

[Mesa-dev] [Bug 41787] [llvmpipe] stencil broken

2011-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41787 --- Comment #15 from Brian Paul 2011-10-20 07:14:10 PDT --- I'm not 100% sure it's the same issue either, actually. But note that I didn't try to reproduce the trace's projection parameters or object coordinates. If I duplicated those params/co

Re: [Mesa-dev] [PATCH] Only use gcc visibility support with gcc4+.

2011-10-20 Thread Brian Paul
On 10/19/2011 02:44 PM, Tom Fogal wrote: I had a colleague hitting issues compiling with an old gcc3.2 system. These patches got them through. --- include/GL/gl.h |2 +- src/mesa/main/compiler.h |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/include/GL

[Mesa-dev] [Bug 41787] [llvmpipe] stencil broken

2011-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41787 --- Comment #14 from José Fonseca 2011-10-20 06:40:29 PDT --- Brian, I see the stray pixels with your example here, but I'm not sure if it is the same issue. See the attached screenshots of the trace at call 837, with llvmpipe and fglrx, and a

[Mesa-dev] [Bug 41787] [llvmpipe] stencil broken

2011-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41787 --- Comment #13 from José Fonseca 2011-10-20 06:33:13 PDT --- Created attachment 52587 --> https://bugs.freedesktop.org/attachment.cgi?id=52587 000837.diff.png -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email --

[Mesa-dev] [Bug 41787] [llvmpipe] stencil broken

2011-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41787 --- Comment #12 from José Fonseca 2011-10-20 06:32:47 PDT --- Created attachment 52586 --> https://bugs.freedesktop.org/attachment.cgi?id=52586 000837.llvmpipe.png -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=emai

[Mesa-dev] [Bug 41787] [llvmpipe] stencil broken

2011-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=41787 --- Comment #11 from José Fonseca 2011-10-20 06:32:09 PDT --- Created attachment 52585 --> https://bugs.freedesktop.org/attachment.cgi?id=52585 000837.fglrx.png -- Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email -

[Mesa-dev] [Bug 34401] glXGetScreenDriver doesn't report the same driver name as used in ~/.drirc

2011-10-20 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=34401 Michal Suchanek changed: What|Removed |Added Depends on||42035 -- Configure bugmail: https://b

Re: [Mesa-dev] [PATCH 4/4 dri] Revert "Duplicate state_tracker/dri/sw/dri_drawable.c"

2011-10-20 Thread Michel Dänzer
On Mit, 2011-10-19 at 20:16 -0400, nobled wrote: > This reverts commit 569bde1fa7d03fb7688d0d391b32e61e857ad44e. > --- A revert commit needs a rationale. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Debian, X and DRI d

Re: [Mesa-dev] Radeon DRI1 removal

2011-10-20 Thread Michel Dänzer
On Mit, 2011-10-19 at 17:50 -0700, Eric Anholt wrote: > For the MapRenderbuffer() code (See > http://cgit.freedesktop.org/~anholt/mesa/log/?h=rbmap for the current > work, which has glReadPixels() converted so far and tested on gen6 with > only one regression in the tip commit), I need to be able